WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
38,443 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

38443 Commits

Author SHA1 Message Date
Felix Arntz 1422d8ffd9 Customize: Safeguard a check on the `customize_validate_{$setting_id}` filter value to ensure it is a `WP_Error`. 
While the filter is documented to only support a `WP_Error`, it has been a common practice to return true in a validation function if no errors have occurred. This was already caught when the same filter was executed in `WP_Customize_Setting`, it was however missing in `WP_Customize_Manager::validate_setting_values()`.

Fixes #44809.

Built from https://develop.svn.wordpress.org/trunk@43578


git-svn-id: http://core.svn.wordpress.org/trunk@43407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-19 16:38:24 +00:00
omarreiss bdbaccce37 General: Explicitly assigns all JS globals to the window. 
Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

Built from https://develop.svn.wordpress.org/trunk@43577


git-svn-id: http://core.svn.wordpress.org/trunk@43406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-19 13:33:24 +00:00
John Blackbourn 879f43f278 Docs: Remove an erroneous closing brace from the description of `wp_list_pages()`. 
Props birgire

See #42505

Built from https://develop.svn.wordpress.org/trunk@43576


git-svn-id: http://core.svn.wordpress.org/trunk@43405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-19 11:17:26 +00:00
John Blackbourn 8730f3cb79 Customize: Increase the colour contrast of the line numbers in CodeMirror. 
Props earnjam, abdullahramzan, audrasjb, Luminus

Fixes #44763

Built from https://develop.svn.wordpress.org/trunk@43574


git-svn-id: http://core.svn.wordpress.org/trunk@43403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-19 11:01:23 +00:00
Sergey Biryukov 8efab48ede Administration: Remove `$title_class` variable, unused since [18683]. 
Props hitendra-chopda, torontodigits.
Fixes #44812.
Built from https://develop.svn.wordpress.org/trunk@43573


git-svn-id: http://core.svn.wordpress.org/trunk@43402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-19 10:18:26 +00:00
Gary Pendergast 41166ed741 Tests: Revert `wp-api-generated.js` change added in [43571]. 
The fixtures file was accidentally included in [43571], but that caused other tests to fail.

See #39122.


Built from https://develop.svn.wordpress.org/trunk@43572


git-svn-id: http://core.svn.wordpress.org/trunk@43401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 04:12:25 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Boone Gorges 8142df82bc Introduce `wp_insert_term_duplicate_term_check` filter. 
This filter allows plugins to intervene in the duplicate-term check
that takes place at the time of term creation. See [30238], #22023.

Props strategio.
Fixes #43271.
Built from https://develop.svn.wordpress.org/trunk@43570


git-svn-id: http://core.svn.wordpress.org/trunk@43399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-15 19:50:25 +00:00
Gary Pendergast 8244397ffb Coding Standards: Prepare for upgrading WPCS to 1.0.0. 
In order to get the best result when running `phpcbf` across the codebase, there are some manual tweaks we need to make.

These fall into three categories:
- Fixing incorrectly indented code which has flow-on effects when auto-fixing.
- Tweaking the layout of inline PHP inside HTML tags.
- Moving more complex inline PHP inside HTML tags, to execute earlier.

See #44600.


Built from https://develop.svn.wordpress.org/trunk@43569


git-svn-id: http://core.svn.wordpress.org/trunk@43398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-15 06:22:26 +00:00
Sergey Biryukov 08af3900c3 Privacy: Ensure the user request email is sent in the requested user's locale (or the site's default locale if they are not a registered user) when the administrator creating the request uses a different locale. 
Props desrosj, Chouby, iandunn, lbenicio, birgire, earnjam, swissspidy, garrett-eclipse.
Fixes #43985.
Built from https://develop.svn.wordpress.org/trunk@43568


git-svn-id: http://core.svn.wordpress.org/trunk@43397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-13 16:32:27 +00:00
K. Adam White a2648da538 Tests: Improve coverage for REST API term meta registration. 
Introduce tests to validate that register_meta and register_term_meta work as expected in WP_REST_Terms_Controller.

props timmydcrawford.
Fixes #39122.

Built from https://develop.svn.wordpress.org/trunk@43567


git-svn-id: http://core.svn.wordpress.org/trunk@43396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-12 00:06:24 +00:00
K. Adam White b5ec1e6d96 REST API: generate a valid fallback URI in wp.api.utils.getRootURL. 
When window.location.origin isn't set, correctly insert two slashes between the protocol and host when constructing the fallback URL.

props abdullahramzan.
Fixes #44764.

Built from https://develop.svn.wordpress.org/trunk@43566


git-svn-id: http://core.svn.wordpress.org/trunk@43395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-11 18:51:24 +00:00
Sergey Biryukov c0cc6617f2 Script/Style Dependencies: Make sure that inline scripts for handles without a source are printed. 
See [36550] for `WP_Styles`.

Props bpayton.
Fixes #44551.
Built from https://develop.svn.wordpress.org/trunk@43565


git-svn-id: http://core.svn.wordpress.org/trunk@43394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-11 17:42:49 +00:00
Sergey Biryukov c89962511b Script/Style Dependencies: Simplify some logic in `WP_Styles::do_item()`. 
Combine repetitive assignments, make the code more consistent with `WP_Scripts::do_item()`.

See #44551.
Built from https://develop.svn.wordpress.org/trunk@43564


git-svn-id: http://core.svn.wordpress.org/trunk@43393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-11 17:42:24 +00:00
Sergey Biryukov 4ad3539113 Docs: Correct description for `WP_Scripts::$default_version`. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@43563


git-svn-id: http://core.svn.wordpress.org/trunk@43392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-11 15:09:24 +00:00
Sergey Biryukov d7f3dbf939 Tests: Avoid a race condition in `test_date_i18n_handles_shorthand_formats()` by using a delta for comparing timestamps. 
See #20973, #38381.
Built from https://develop.svn.wordpress.org/trunk@43562


git-svn-id: http://core.svn.wordpress.org/trunk@43391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-11 13:29:25 +00:00
Sergey Biryukov b456c7eb12 Customize: Pass missing parameter to dynamic `option_{$option}` filter in `WP_Customize_Widgets::capture_filter_pre_get_option()`. 
Props dlh.
Fixes #44770.
Built from https://develop.svn.wordpress.org/trunk@43561


git-svn-id: http://core.svn.wordpress.org/trunk@43390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-11 12:45:26 +00:00
Rachel Baker 64bcc842af Docs: Update $meta_type descriptions to include ’term’ as a valid type in meta.php and class-wp-term-query.php. 
Props macbookandrew.
Merges [43557] to trunk.
Fixes #44751.

Built from https://develop.svn.wordpress.org/trunk@43560


git-svn-id: http://core.svn.wordpress.org/trunk@43389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-08 21:45:24 +00:00
Boone Gorges 38c33611e0 Correct param documentation for `WP_Term_Query`. 
The description of `$meta_type` introduced in [40053] was incorrect.

Props dlh.
Fixes #44608.
Built from https://develop.svn.wordpress.org/trunk@43559


git-svn-id: http://core.svn.wordpress.org/trunk@43388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-08 19:23:25 +00:00
Boone Gorges 297c7e4c8f Taxonomy: Introduce new hooks when registering/unregistering taxonomies for object types. 
Props soulseekah.
Fixes #44733.
Built from https://develop.svn.wordpress.org/trunk@43558


git-svn-id: http://core.svn.wordpress.org/trunk@43387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-08 19:15:27 +00:00
Konstantin Obenland 071984839c Toolbar: Check if `obj` is set before using it. 
Props pento.
See #44526.

Built from https://develop.svn.wordpress.org/trunk@43556


git-svn-id: http://core.svn.wordpress.org/trunk@43385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-06 19:33:28 +00:00
Sergey Biryukov aab929b8d6 Build/Test Tools: Add documentation for `tests_add_filter()`, `_test_filter_build_unique_id()`, `_delete_all_data()`, `_delete_all_posts()`. 
Props andizer.
Fixes #44703.
Built from https://develop.svn.wordpress.org/trunk@43555


git-svn-id: http://core.svn.wordpress.org/trunk@43384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-02 22:36:25 +00:00
laurelfulford 78a71b94bf Twenty Seventeen: Correct date in changelog for 4.9.8 release. 
Props pbiron, laurelfulford.
Fixes #44646.


Built from https://develop.svn.wordpress.org/trunk@43550


git-svn-id: http://core.svn.wordpress.org/trunk@43379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-02 15:33:24 +00:00
Sergey Biryukov 70bc51e46f Docs: Correct parameter name in `strip_shortcodes_tagnames` filter DocBlock. 
Props uttam007.
Fixes #44691.
Built from https://develop.svn.wordpress.org/trunk@43549


git-svn-id: http://core.svn.wordpress.org/trunk@43378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-02 15:13:27 +00:00
Felix Arntz 9e2e491f1f Multisite: Complete the new CRUD API for managing sites. 
New functions `wp_insert_site( $data )`, `wp_update_site( $id, $data )` and `wp_delete_site( $id )` are introduced to manage site rows in the `wp_blogs` table, forming the new CRUD API together with the existing `get_site()` / `get_sites()`. The new API provides various benefits over the previously existing API, fixing several cache invalidation issues and being hook-driven so that normalization and validation of the passed data can be fully customized.

New hooks introduced as part of this are the actions `wp_insert_site`, `wp_update_site`, `wp_delete_site`, `wp_validate_site_data` and the filter `wp_normalize_site_data`.

At this point, `wp_insert_site()` does not handle setting up the site's database tables, and `wp_delete_site()` does not handle dropping the site's database tables, so the two can not yet be used directly as full replacements of `wpmu_create_blog()` and `wpmu_delete_blog()`. Managing the site's database tables will be added via hooks as part of the follow-up ticket #41333.

The existing functions `wpmu_create_blog()`, `update_blog_details()`, and `wpmu_delete_blog()` make use of the respective new counterpart and will be obsolete once #41333 has been completed.

Props flixos90, jeremyfelt, spacedmonkey.
Fixes #40364.

Built from https://develop.svn.wordpress.org/trunk@43548


git-svn-id: http://core.svn.wordpress.org/trunk@43377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-01 13:06:26 +00:00
Aaron Jorbin d38f04eada Gutenbeg: you can't remove call outs that don't exist 
This commit should have just gone into the 4.9 branch. It did in [43544].

See: #44680
Unprops jorbin
props ocean90

Built from https://develop.svn.wordpress.org/trunk@43545


git-svn-id: http://core.svn.wordpress.org/trunk@43374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-31 15:16:25 +00:00
Aaron Jorbin b27951eb85 Gutenberg: Restrict "Try Gutenberg" based on capability and gutenstatus 
When Gutenberg is either not installed, or not activated, only show the callout to users with the install_plugins capability.
When Gutenberg is activated, expand that to include all users with the edit_posts capability.

Props pento.
Fixes #44680.

Built from https://develop.svn.wordpress.org/trunk@43543


git-svn-id: http://core.svn.wordpress.org/trunk@43372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-31 14:42:29 +00:00
John Blackbourn 58509ba12f Login and Registration: Pass the `$errors` parameter to the `lost_password` action. 
Props sebakurzyn

Fixes #44512

Built from https://develop.svn.wordpress.org/trunk@43542


git-svn-id: http://core.svn.wordpress.org/trunk@43371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-28 13:02:25 +00:00
laurelfulford 7063c45879 Twenty Seventeen: Bump version number and update changelog for 4.9.8 release. 
Props pbiron.
Fixes #44646.

Built from https://develop.svn.wordpress.org/trunk@43541


git-svn-id: http://core.svn.wordpress.org/trunk@43370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-27 18:37:25 +00:00
Peter Wilson 90f1ac17ec Cron: Add hooks and a function to allow hijacking cron implementation. 
This allows sites with a large cron option or a custom cron implementation to hijack the cron option to store cron data using custom functionality.

`wp_get_scheduled_event()` is new function to retrieve the event object for a given event based on the hook name, arguments and timestamp. If no timestamp is specified the next occurence is returned.

Preflight filters are added to all functions that read from or modify the cron option: `pre_schedule_event`, `pre_reschedule_event`, `pre_unschedule_event`, `pre_clear_scheduled_hook`, `pre_unschedule_hook`, `pre_get_scheduled_event` and `pre_next_scheduled`.

Additionally, the post scheduling hooks `next_scheduled` and `get_schedule` to allow plugins to modify an event after retrieving it from WordPress.

Props rmccue, DavidAnderson, ethitter, peterwilsoncc.
Fixes #32656.


Built from https://develop.svn.wordpress.org/trunk@43540


git-svn-id: http://core.svn.wordpress.org/trunk@43369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-27 02:23:25 +00:00
Sergey Biryukov 9c084c6968 Posts, Post Types: Introduce `edit_post_{$post->post_type}` hook. 
The hook fires before the general `edit_post` hook and has the same parameters.

It also complements the `save_post_{$post->post_type}` hook added in [25050].

Props Mte90, garrett-eclipse.
Fixes #34706.
Built from https://develop.svn.wordpress.org/trunk@43535


git-svn-id: http://core.svn.wordpress.org/trunk@43364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-25 20:57:25 +00:00
Sergey Biryukov a90f215d2c Privacy: Revert [43525]. 
The commenter cookies checkbox is not legally required, so should be disabled by default.

Fixes #44373.
Built from https://develop.svn.wordpress.org/trunk@43531


git-svn-id: http://core.svn.wordpress.org/trunk@43360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-24 17:06:24 +00:00
Sergey Biryukov 2072479adc REST API: Ensure attachments created with `WP_REST_Attachments_Controller::create_item()` on Windows have a relative path. 
Props ocean90, SergeyBiryukov, redcastor.
Fixes #40861.
Built from https://develop.svn.wordpress.org/trunk@43529


git-svn-id: http://core.svn.wordpress.org/trunk@43358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-24 16:52:25 +00:00
Sergey Biryukov 76e821e647 I18N: Separate two "About" strings with different context. 
Props desrosj, XpertOne, Nao.
Fixes #44139.
Built from https://develop.svn.wordpress.org/trunk@43527


git-svn-id: http://core.svn.wordpress.org/trunk@43356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-24 15:04:25 +00:00
Sergey Biryukov d68b2b5a2b Privacy: Remove the setting to enable comment cookies consent added in [43469]. 
This needs some more work to ensure expected behaviour.

See #44373.
Built from https://develop.svn.wordpress.org/trunk@43525


git-svn-id: http://core.svn.wordpress.org/trunk@43354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-24 12:51:29 +00:00
K. Adam White 5f7e85d589 Docs: Add `$object_subtype` param documentation for `sanitize_meta()`. 
Props timothyblynjacobs.

See #38323.

Built from https://develop.svn.wordpress.org/trunk@43521


git-svn-id: http://core.svn.wordpress.org/trunk@43350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-23 17:14:26 +00:00
K. Adam White a7735117b6 Docs: Update @since version to 4.9.8 for meta registration subtype handling. 
This feature has been backported to 4.9.8 so 5.0.0 is inaccurate.

See #38323.

Built from https://develop.svn.wordpress.org/trunk@43520


git-svn-id: http://core.svn.wordpress.org/trunk@43349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-23 17:02:25 +00:00
John Blackbourn 49fdd95ac0 Docs: Correct the parameter type for `WP_REST_Post_Types_Controller::prepare_item_for_response()`. 
Props subrataemfluence

Fixes #44437

Built from https://develop.svn.wordpress.org/trunk@43519


git-svn-id: http://core.svn.wordpress.org/trunk@43348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-22 12:26:28 +00:00
Sergey Biryukov ad68a69250 Comments: Ensure that themes overriding default `comment_form()` fields still display the cookies consent checkbox. 
The `comment_form_default_fields` filter can be used to remove the checkbox.

Props pross, SergeyBiryukov.
Fixes #44126.
Built from https://develop.svn.wordpress.org/trunk@43518


git-svn-id: http://core.svn.wordpress.org/trunk@43347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-20 00:38:24 +00:00
Konstantin Obenland 51f09ffc2a Toolbar: Fail gracefully when adding events to non-existent elements 
Avoids a type error when `obj` is not set.

Fixes #44526.

Built from https://develop.svn.wordpress.org/trunk@43517


git-svn-id: http://core.svn.wordpress.org/trunk@43346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-19 22:00:25 +00:00
Sergey Biryukov d0132b292e Privacy: Improve grammar on Privacy Settings screen. 
Props ianbelanger, garrett-eclipse.
Fixes #44612.
Built from https://develop.svn.wordpress.org/trunk@43513


git-svn-id: http://core.svn.wordpress.org/trunk@43342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-19 20:14:25 +00:00
Sergey Biryukov f309e3b660 Tests: Introduce `Tests_HTTP_Functions::skipTestOnTimeout()`, mirroring the same `WP_HTTP_UnitTestCase` method. 
See #44613.
Built from https://develop.svn.wordpress.org/trunk@43512


git-svn-id: http://core.svn.wordpress.org/trunk@43341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-19 19:53:26 +00:00
Sergey Biryukov 3f21ed0f42 Tests: Use `WP_HTTP_UnitTestCase::skipTestOnTimeout()` in more HTTP tests. 
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".

See #44613.
Built from https://develop.svn.wordpress.org/trunk@43511


git-svn-id: http://core.svn.wordpress.org/trunk@43340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-19 19:10:25 +00:00
Sergey Biryukov 78de1dffb5 Privacy: Use a consistent case for "Privacy Policy page" on Privacy Settings screen. 
Props XpertOne, idea15, garrett-eclipse.
Fixes #44130.
Built from https://develop.svn.wordpress.org/trunk@43508


git-svn-id: http://core.svn.wordpress.org/trunk@43337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-19 12:10:25 +00:00
Sergey Biryukov ac338b1666 Privacy: Use the actual Privacy Policy page title in `get_the_privacy_policy_link()`. 
Props desrosj, birgire, ianbelanger, Ov3rfly.
Fixes #44192.
Built from https://develop.svn.wordpress.org/trunk@43506


git-svn-id: http://core.svn.wordpress.org/trunk@43335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-18 11:50:25 +00:00
Sergey Biryukov 12b1b3e891 I18N: Update list of continents and cities for the timezone selection. 
Props soulseekah, dyrer.
Fixes #44574.
Built from https://develop.svn.wordpress.org/trunk@43504


git-svn-id: http://core.svn.wordpress.org/trunk@43333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-18 11:21:25 +00:00
Sergey Biryukov 058187d34f Filesystem API: Skip `https://` test for `wp_is_stream()` if `openssl` extension is not loaded. 
See #44533.
Built from https://develop.svn.wordpress.org/trunk@43503


git-svn-id: http://core.svn.wordpress.org/trunk@43332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-18 09:52:24 +00:00
Dion Hulse 708e355c79 Bump akismet external to 4.0.8. 
git-svn-id: http://core.svn.wordpress.org/trunk@43330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-18 06:47:37 +00:00
Sergey Biryukov e3439bbe09 Filesystem API: Add basic tests for `wp_is_stream()`. 
Props JPry.
See #44533.
Built from https://develop.svn.wordpress.org/trunk@43501


git-svn-id: http://core.svn.wordpress.org/trunk@43328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-18 01:02:26 +00:00
Sergey Biryukov 153783a7f1 Privacy: Add unit tests for `_wp_privacy_send_request_confirmation_notification()`, introduced in [43211]. 
Props birgire, desrosj, garrett-eclipse.
Fixes #43967.
Built from https://develop.svn.wordpress.org/trunk@43499


git-svn-id: http://core.svn.wordpress.org/trunk@43326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-07-17 22:56:25 +00:00