Commit Graph

23600 Commits

Author SHA1 Message Date
Andrew Nacin 191efaef61 Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods.
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25823


git-svn-id: http://core.svn.wordpress.org/trunk@25735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:55:09 +00:00
Dion Hulse 640f73ecd2 Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200
Built from https://develop.svn.wordpress.org/trunk@25822


git-svn-id: http://core.svn.wordpress.org/trunk@25734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:12:10 +00:00
Drew Jaynes bd09d15a2c Inline documentation for hooks in wp-admin/custom-header.php.
Props gizburdt for the initial patch.
Fixes #25443.

Built from https://develop.svn.wordpress.org/trunk@25821


git-svn-id: http://core.svn.wordpress.org/trunk@25733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 23:26:10 +00:00
Andrew Nacin 55b0b79179 "Future security updates will be applied automatically." see #22704.
Built from https://develop.svn.wordpress.org/trunk@25820


git-svn-id: http://core.svn.wordpress.org/trunk@25732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 23:06:09 +00:00
Drew Jaynes 359a2ce779 Inline documentation for hooks in wp-admin/edit-form-advanced.php.
Props ericlewis.
Fixes #25434.

Built from https://develop.svn.wordpress.org/trunk@25819


git-svn-id: http://core.svn.wordpress.org/trunk@25731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 22:59:09 +00:00
Dion Hulse 376a0a55c7 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200
Built from https://develop.svn.wordpress.org/trunk@25818


git-svn-id: http://core.svn.wordpress.org/trunk@25730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 22:27:09 +00:00
Dion Hulse ed07bab4b4 When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704
Built from https://develop.svn.wordpress.org/trunk@25817


git-svn-id: http://core.svn.wordpress.org/trunk@25729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:48:10 +00:00
Andrew Nacin 766b6d3842 Update the banner for update-core.php that tells users they are set up for security updates to happen in the background.
"This site is set up to install security updates of WordPress automatically. Cool!"

Checkmark is a placeholder; we'll tinker with this further today.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25816


git-svn-id: http://core.svn.wordpress.org/trunk@25728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:41:09 +00:00
Andrew Nacin bccefbbd83 Merge the should_auto_update() and can_auto_update() methods. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25815


git-svn-id: http://core.svn.wordpress.org/trunk@25727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:35:09 +00:00
Lance Willett 38b333977e Twenty Fourteen: cleanup, props iamtakashi. Fixes #25613.
* With the ephemera widget in place, `content-recent-formatted-post.php` is unused, see #25028.
* We're no longe filtering formatted posts from the main query, see #25330.
 * Fix a typo.
Built from https://develop.svn.wordpress.org/trunk@25814


git-svn-id: http://core.svn.wordpress.org/trunk@25726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 18:29:09 +00:00
Lance Willett fafbee59f9 Twenty Fourteen: implement tag auto-complete for featured content settings, and uppercase `__CLASS__` for consistency. Props kovshenin, see #25549.
Built from https://develop.svn.wordpress.org/trunk@25813


git-svn-id: http://core.svn.wordpress.org/trunk@25725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 18:27:09 +00:00
Dion Hulse 085f5c5fb9 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200
Built from https://develop.svn.wordpress.org/trunk@25812


git-svn-id: http://core.svn.wordpress.org/trunk@25724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 17:07:08 +00:00
Dion Hulse 8c35982ae8 Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath.
See #18201

Built from https://develop.svn.wordpress.org/trunk@25811


git-svn-id: http://core.svn.wordpress.org/trunk@25723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 15:20:10 +00:00
Andrew Nacin ba0ebf3736 Include translations in the update bubbles (as +1 if there are any). see #18200.
Built from https://develop.svn.wordpress.org/trunk@25810


git-svn-id: http://core.svn.wordpress.org/trunk@25722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 14:34:10 +00:00
Andrew Nacin b02867a1c4 Avoid printing a possible HTML element. fixes #24813.
Built from https://develop.svn.wordpress.org/trunk@25809


git-svn-id: http://core.svn.wordpress.org/trunk@25721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:46:10 +00:00
Lance Willett 34edaed317 Twenty Fourteen: first pass at implementing Featured Content settings, props obenland. See #25549.
Built from https://develop.svn.wordpress.org/trunk@25808


git-svn-id: http://core.svn.wordpress.org/trunk@25720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:22:09 +00:00
Dion Hulse 84cec7b526 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin.
See #18200, [25806]

Built from https://develop.svn.wordpress.org/trunk@25807


git-svn-id: http://core.svn.wordpress.org/trunk@25719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:19:09 +00:00
Dion Hulse 1c8e79353a Language Packs: Many many fixes such as:
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704


Built from https://develop.svn.wordpress.org/trunk@25806


git-svn-id: http://core.svn.wordpress.org/trunk@25718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:15:09 +00:00
Andrew Nacin 9fe39c464a Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value.
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.

Built from https://develop.svn.wordpress.org/trunk@25805


git-svn-id: http://core.svn.wordpress.org/trunk@25717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:02:09 +00:00
Lance Willett 83f5f48dea Twenty Fourteen: remove excerpts from featured posts, and display full titles instead. Props iamtakashi, closes #25581.
Built from https://develop.svn.wordpress.org/trunk@25804


git-svn-id: http://core.svn.wordpress.org/trunk@25716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 03:47:09 +00:00
Lance Willett 6a3e7ff614 Twenty Fourteen: link hover improvements, props sabreuse. See #25054.
Built from https://develop.svn.wordpress.org/trunk@25803


git-svn-id: http://core.svn.wordpress.org/trunk@25715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:37:10 +00:00
Lance Willett f98e6f60fb Twenty Fourteen: better logic for featured image HTML output, and add fallback message for focusable anchor elements, for accessibility. Fixes #25325.
Built from https://develop.svn.wordpress.org/trunk@25802


git-svn-id: http://core.svn.wordpress.org/trunk@25714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:24:10 +00:00
Andrew Nacin 4542fbb2ae Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief.
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.

Built from https://develop.svn.wordpress.org/trunk@25801


git-svn-id: http://core.svn.wordpress.org/trunk@25713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:03:10 +00:00
Andrew Nacin 9507d22243 Use correct variable. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25800


git-svn-id: http://core.svn.wordpress.org/trunk@25712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 22:07:09 +00:00
Andrew Nacin 95831a8a67 Remove accidental debug cruft in [25780]. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25799


git-svn-id: http://core.svn.wordpress.org/trunk@25711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 21:24:09 +00:00
Andrew Nacin 2100fa65fd Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet.
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25798


git-svn-id: http://core.svn.wordpress.org/trunk@25710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 20:35:10 +00:00
Andrew Nacin a6188bc84a Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25797


git-svn-id: http://core.svn.wordpress.org/trunk@25709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 20:01:09 +00:00
Andrew Nacin 82547b21b6 In show_message(), only print error data if it is a string.
see #25576, [25775].

Built from https://develop.svn.wordpress.org/trunk@25796


git-svn-id: http://core.svn.wordpress.org/trunk@25708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:51:10 +00:00
Andrew Nacin ee7050d892 3.7-beta2-25795
Built from https://develop.svn.wordpress.org/trunk@25795


git-svn-id: http://core.svn.wordpress.org/trunk@25707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:20:08 +00:00
Andrew Nacin 26c03ea5fb Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport.
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25794


git-svn-id: http://core.svn.wordpress.org/trunk@25706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:18:10 +00:00
Andrew Nacin eeaad19a26 Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir().
This occurs when we can't copy a file. We chmod it and try again.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25793


git-svn-id: http://core.svn.wordpress.org/trunk@25705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:14:10 +00:00
Lance Willett b4b6c09476 Twenty Fourteen: minor fixes to docs, props celloexpressions. See #25257
Built from https://develop.svn.wordpress.org/trunk@25792


git-svn-id: http://core.svn.wordpress.org/trunk@25704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 18:01:09 +00:00
Lance Willett c1ab04b466 Twenty Thirteen: fix description layout on attachment outputs, props obenland. Fixes #25578.
Built from https://develop.svn.wordpress.org/trunk@25791


git-svn-id: http://core.svn.wordpress.org/trunk@25703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 17:59:09 +00:00
Lance Willett 3910e56231 Twenty Fourteen: remove `style` tags from accent color output, following r25786. Fixes #25599, props celloexpressions.
Built from https://develop.svn.wordpress.org/trunk@25790


git-svn-id: http://core.svn.wordpress.org/trunk@25702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 17:56:10 +00:00
Lance Willett 9001d030f3 Twenty Thirteen: use correct font name in comment docs, props tenpura. Fixes #25593.
Built from https://develop.svn.wordpress.org/trunk@25789


git-svn-id: http://core.svn.wordpress.org/trunk@25701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 16:47:09 +00:00
Lance Willett 590b6831dc Twenty Fourteen: first pass at CSS revamp, props iamtakashi. See #25592.
Built from https://develop.svn.wordpress.org/trunk@25788


git-svn-id: http://core.svn.wordpress.org/trunk@25700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 16:46:09 +00:00
Dion Hulse 592123951b Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/.
My bad. See #22704, [25781].

Built from https://develop.svn.wordpress.org/trunk@25787


git-svn-id: http://core.svn.wordpress.org/trunk@25699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 14:55:09 +00:00
Andrew Nacin f9be8e4f0c Revert [25202] and enforce that wp_add_inline_style() does not want <style> tags.
Prior to 3.7, these tags were not printed (and thus needed to be provided), but only in the admin and when concatenation was enabled. They should never be required. Strip them when we find them and issue a notice for incorrect usage.

props atimmer, georgestephanis.
fixes #24813.

Built from https://develop.svn.wordpress.org/trunk@25786


git-svn-id: http://core.svn.wordpress.org/trunk@25698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 14:35:09 +00:00
Andrew Nacin 7b0088c938 Hide language-specific warnings/labels on update-core.php when we are dealing with a point release partial build.
see #22704, #18200.

Built from https://develop.svn.wordpress.org/trunk@25784


git-svn-id: http://core.svn.wordpress.org/trunk@25697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 05:08:09 +00:00
Andrew Nacin e503d0e2ec Hide auto updates from update-core.php directly in get_core_updates(). see #22704.
Built from https://develop.svn.wordpress.org/trunk@25783


git-svn-id: http://core.svn.wordpress.org/trunk@25696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 05:07:10 +00:00
Andrew Nacin 957df34182 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback.
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25782


git-svn-id: http://core.svn.wordpress.org/trunk@25695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 02:59:10 +00:00
Andrew Nacin cdede88a23 Automatic updates: Include error data in the follow-up API request.
props dd32.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25781


git-svn-id: http://core.svn.wordpress.org/trunk@25694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 23:33:10 +00:00
Andrew Nacin 9b56d4d11f Parse absolute paths out of error data. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25780


git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 22:25:08 +00:00
Dion Hulse 4dcca90887 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25779


git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:55:09 +00:00
Andrew Nacin 4fa3687e6a Account for the possible failure of disk_free_space() in update_core().
see #22704, #25576.

Built from https://develop.svn.wordpress.org/trunk@25778


git-svn-id: http://core.svn.wordpress.org/trunk@25691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:15:10 +00:00
Andrew Nacin 3e3c085db3 Auto updates: Only attempt a roll back when we've hit a critical error code.
Specifically, this means when we've failed in copying files.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25777


git-svn-id: http://core.svn.wordpress.org/trunk@25690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:03:09 +00:00
Andrew Nacin 145dbde82f Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
see #25576.

Built from https://develop.svn.wordpress.org/trunk@25776


git-svn-id: http://core.svn.wordpress.org/trunk@25689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:58:09 +00:00
Andrew Nacin 1516b990f1 In the upgrader, only print additional error data if it is a string.
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.

Built from https://develop.svn.wordpress.org/trunk@25775


git-svn-id: http://core.svn.wordpress.org/trunk@25688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:20:10 +00:00
Andrew Nacin d68a80217f In unzip_file(), confirm we have enough available disk space before extracting.
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.

Built from https://develop.svn.wordpress.org/trunk@25774


git-svn-id: http://core.svn.wordpress.org/trunk@25687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:15:09 +00:00
Andrew Nacin 31cf7e9d80 3.7-beta2-25773
Built from https://develop.svn.wordpress.org/trunk@25773


git-svn-id: http://core.svn.wordpress.org/trunk@25686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 19:40:09 +00:00