822b8afb50
Accessibility: Improve the Media Library inline uploader accessibility.
...
For better accessibility, expandable panels should be placed immediately after
the control that expands them. This change moves the Media Library inline
uploader up, right after the "Add New" button, also introducing consistency with
the Plugin and Theme uploaders.
Adds a proper ARIA role on the button and an `aria-expanded` attribute to give
better feedback to assistive technologies users about the uploader's expanded state.
Improves the focus handling when closing the uploader, improves the focus style
and color contrast ratio of the uploader "close" button.
Props mantismamita, karmatosed, adamsilverstein, afercia.
Fixes #37188 .
Built from https://develop.svn.wordpress.org/trunk@40359
git-svn-id: http://core.svn.wordpress.org/trunk@40266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 17:38:43 +00:00
c7b217cee9
JavaScript: when starting Backbone history, stop if previously started.
...
Prevent a potential error condition if Backbone history is started by a plugin or theme before core tries to start it.
Props tfrommen.
Fixes #39612 .
Built from https://develop.svn.wordpress.org/trunk@40076
git-svn-id: http://core.svn.wordpress.org/trunk@40013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-17 22:00:42 +00:00
e983399136
Media: properly refresh the position of the Plupload shim so it moves over the Select Files button or off the screen. Fixes selecting files in MS Edge on the Media grid and Media -> Add New screens.
...
Fixes #37039 .
Built from https://develop.svn.wordpress.org/trunk@37722
git-svn-id: http://core.svn.wordpress.org/trunk@37688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 04:54:29 +00:00
262f3f2f7e
Update grunt-contrib-uglify from ~0.10.0 to ~1.0.1
...
This changes every JS file in WordPress, so we need to test everything.
Props netweb.
See #36520 .
Built from https://develop.svn.wordpress.org/trunk@37212
git-svn-id: http://core.svn.wordpress.org/trunk@37178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 16:10:37 +00:00
34331fc574
Media: Fix broken delete/trash functionality in the library after [36546].
...
Props imath.
See #34350 .
Built from https://develop.svn.wordpress.org/trunk@36681
git-svn-id: http://core.svn.wordpress.org/trunk@36648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-24 16:03:26 +00:00
d349e9c290
Revert [32466], I will pick this up in 4.4.
...
See #32466 .
Built from https://develop.svn.wordpress.org/trunk@33342
git-svn-id: http://core.svn.wordpress.org/trunk@33314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 15:10:27 +00:00
bd974d7bf2
Use a less element-specific class name for links within page titles.
...
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.
Fixes #31650 .
Built from https://develop.svn.wordpress.org/trunk@33067
git-svn-id: http://core.svn.wordpress.org/trunk@33038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 16:42:24 +00:00
c9307fc95a
Update Grunt dev-dependencies
...
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).
Props wonderboymusic
See #31700
Built from https://develop.svn.wordpress.org/trunk@32988
git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
b212ee67e7
Media Library `Bulk Select` button size should be smaller.
...
Props afercia.
Fixes #32325 .
Built from https://develop.svn.wordpress.org/trunk@32862
git-svn-id: http://core.svn.wordpress.org/trunk@32833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:56:27 +00:00
2f82bbb60d
In `views/button/select-mode-toggle`, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's `toggleBulkEditHandler` method.
...
Props afercia.
Fixes #32324 .
Built from https://develop.svn.wordpress.org/trunk@32502
git-svn-id: http://core.svn.wordpress.org/trunk@32472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:27:27 +00:00
4af6d6f305
Media Grid: clean up our flawed `Backbone.Router` implementation so that the browser forward/back buttons work the same way as the left/right keys when the Edit Attachment frame is open.
...
Fixes #31846 .
Built from https://develop.svn.wordpress.org/trunk@32466
git-svn-id: http://core.svn.wordpress.org/trunk@32436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 05:42:28 +00:00
5e4616039c
Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
...
Props iseulde, ocean90.
Fixes #31912 .
Built from https://develop.svn.wordpress.org/trunk@32125
git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 15:31:28 +00:00
6cb16f7a21
Remove unused media JS files.
...
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31405
git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 22:45:28 +00:00
02c773efb0
Avoid re-registering the `keydown` event controller in the media grid so arrow controls don't skip media items.
...
Fixes #30348
Props UmeshSingla
Built from https://develop.svn.wordpress.org/trunk@30377
git-svn-id: http://core.svn.wordpress.org/trunk@30374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 04:28:22 +00:00
d8c913b3f9
Add the `date` filter from media grid to the media modal.
...
Props janhenckens, wonderboymusic.
Fixes #28990 .
Built from https://develop.svn.wordpress.org/trunk@29813
git-svn-id: http://core.svn.wordpress.org/trunk@29579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:32:16 +00:00
b885885b67
Media Grid/List Table parity: when `MEDIA_TRASH` is `true` and `trash` is the current filter for the grid, add a second bulk action button: "Delete Selected"
...
Fixes #29742 .
Built from https://develop.svn.wordpress.org/trunk@29811
git-svn-id: http://core.svn.wordpress.org/trunk@29577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:13:16 +00:00
668e758a78
Media Grid: when the modal is open, don't respond to arrow keys when `<textarea>` has focus.
...
Props ryelle.
Fixes #29725 .
Built from https://develop.svn.wordpress.org/trunk@29777
git-svn-id: http://core.svn.wordpress.org/trunk@29549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 03:00:17 +00:00
9e8b9a78ca
Media library: Unify headers between view modes.
...
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.
This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).
props pento, helen.
fixes #28946 .
Built from https://develop.svn.wordpress.org/trunk@29625
git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 15:58:15 +00:00
32e896f5b8
Media Grid: exit selection mode when Esc is pressed.
...
Fixes #29366 .
Built from https://develop.svn.wordpress.org/trunk@29600
git-svn-id: http://core.svn.wordpress.org/trunk@29374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 17:45:17 +00:00
7029af94e7
Media Grid: after completing a Bulk action, switch from `select` to `edit` mode.
...
Fixes #28842 .
Built from https://develop.svn.wordpress.org/trunk@29566
git-svn-id: http://core.svn.wordpress.org/trunk@29340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:20:16 +00:00
ca180e2544
Media Grid: don't auto-select attachments upon upload.
...
Props ocean90.
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29565
git-svn-id: http://core.svn.wordpress.org/trunk@29339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:54:14 +00:00
6352d703a0
Media Grid/Modal Keyboard navigation improvements:
...
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading.
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press
Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29560
git-svn-id: http://core.svn.wordpress.org/trunk@29335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:35:17 +00:00
2808d5c523
Media Grid: Cleanup toggling of Next/Previous in Edit modal.
...
Fixes #29264 .
Built from https://develop.svn.wordpress.org/trunk@29551
git-svn-id: http://core.svn.wordpress.org/trunk@29327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:11:15 +00:00
a28bc71819
Media Modal: Restore to the previous filter and search error message.
...
fixes #28963 .
Built from https://develop.svn.wordpress.org/trunk@29532
git-svn-id: http://core.svn.wordpress.org/trunk@29308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 16:28:19 +00:00
6d342e812f
Media Grid: improve the design of upload errors.
...
Props celloexpressions.
See #29141 .
Built from https://develop.svn.wordpress.org/trunk@29526
git-svn-id: http://core.svn.wordpress.org/trunk@29302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:22:17 +00:00
5aee14e9a1
Media Grid: on page load with `?item=` in the URL, if the model is not in the library: fetch it. Defer the triggering of `edit:attachment` until the model has been fetched.
...
Fixes #29052 .
Built from https://develop.svn.wordpress.org/trunk@29525
git-svn-id: http://core.svn.wordpress.org/trunk@29301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:13:16 +00:00
4dc4277a60
Media Grid: Improve position of fixed toolbar at small-screen sizes.
...
see #28842 .
Built from https://develop.svn.wordpress.org/trunk@29517
git-svn-id: http://core.svn.wordpress.org/trunk@29293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 14:03:14 +00:00
571111022e
Media Grid, support `MEDIA_TRASH`:
...
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.
Props koop for the knowledge sharing and thought partnership.
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29490
git-svn-id: http://core.svn.wordpress.org/trunk@29268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:31:19 +00:00
5fc736f49e
Media grid bulk selection styling:
...
* Fade content within each attachment item so that focus styling is still clear.
* Less jarring toolbar pinning.
* Tighten up the fade in/out transition.
see #28842 .
Built from https://develop.svn.wordpress.org/trunk@29489
git-svn-id: http://core.svn.wordpress.org/trunk@29267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 07:18:15 +00:00
b5922001b4
Remove debug line from [29484].
...
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29485
git-svn-id: http://core.svn.wordpress.org/trunk@29263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 00:37:15 +00:00
9c08ad236a
Media Grid: add Bulk Selection mode for deleting attachments.
...
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29484
git-svn-id: http://core.svn.wordpress.org/trunk@29262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 22:45:15 +00:00
99a10a450e
Media Grid: treat Edit Image like a `mode`, which it is, instead of a `state`, which it is not.
...
Fixes #29206 .
Built from https://develop.svn.wordpress.org/trunk@29483
git-svn-id: http://core.svn.wordpress.org/trunk@29261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 19:26:16 +00:00
ca03604712
In the Edit Attachment frame, when in Edit Image mode, add a key event for Escape. There are conflicting `keydown` handlers that don't propagate the event to the modal properly.
...
Fixes #29121 .
Built from https://develop.svn.wordpress.org/trunk@29481
git-svn-id: http://core.svn.wordpress.org/trunk@29259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 18:15:18 +00:00
ed5d17ab77
Media Grid: remove Router code that doesn't actually ever run.
...
See #29121 .
Built from https://develop.svn.wordpress.org/trunk@29444
git-svn-id: http://core.svn.wordpress.org/trunk@29222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 22:37:16 +00:00
1217efe905
Media Grid: remove Router code that doesn't actually ever run.
...
See #29121 .
Built from https://develop.svn.wordpress.org/trunk@29443
git-svn-id: http://core.svn.wordpress.org/trunk@29221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 22:33:15 +00:00
3f17e7040e
Create a new Backbone view, `media.view.Label`, which can be used as a subview in things like toolbars, which need screen reader text.
...
Make an initial instance of it for the label for Bulk Actions in Media Grid.
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29434
git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:09:17 +00:00
c5dff42d51
Revert [29428] to avoid errors with Add Media for now.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29432
git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 19:40:15 +00:00
afb0b3e4ef
Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
...
Props afercia.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29428
git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
f0f4174ed8
Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].
...
See #28819 .
Built from https://develop.svn.wordpress.org/trunk@29427
git-svn-id: http://core.svn.wordpress.org/trunk@29205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:03:17 +00:00
8ed123c97f
In `media.view.AttachmentFilters.All`, make `uploaded` conditional upon `media.view.settings.post.id` and include a new filter: `unattached`.
...
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead.
Props ocean90, wonderboymusic.
Fixes #29065 .
Built from https://develop.svn.wordpress.org/trunk@29426
git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00
935f10413e
Media Grid: expose the `$.Deffered()` object in `media.view.AttachmentsBrowser.updateContent()` so the grid can call `Backbone.history.start()` when models actually exist.
...
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.
See #29052 .
Built from https://develop.svn.wordpress.org/trunk@29420
git-svn-id: http://core.svn.wordpress.org/trunk@29198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 21:44:17 +00:00
a58a4da852
Media Grid: display upload errors in a dismissable sidebar.
...
See #29037 .
Built from https://develop.svn.wordpress.org/trunk@29415
git-svn-id: http://core.svn.wordpress.org/trunk@29193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 19:13:15 +00:00
27b0d4cd20
In `media.view.BulkSelectionActionButton.click()`, do not assume that `delete` is the only possible bulk action.
...
Fixes #29101 .
Built from https://develop.svn.wordpress.org/trunk@29403
git-svn-id: http://core.svn.wordpress.org/trunk@29181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:24:19 +00:00
27890cc734
Media Grid: don't blow away the Attachment Details modal every time a new model is loaded.
...
Props ericlewis.
Fixes #29104 .
Built from https://develop.svn.wordpress.org/trunk@29368
git-svn-id: http://core.svn.wordpress.org/trunk@29146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:40:17 +00:00
696c12bc55
Media Grid: don't select `body` with jQuery when instantiating `media.view.UploaderWindow`.
...
Props ericlewis.
See #28965 .
Built from https://develop.svn.wordpress.org/trunk@29367
git-svn-id: http://core.svn.wordpress.org/trunk@29145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:37:19 +00:00
0c2fe96a31
Media Grid: Close the modal if the attachment is deleted.
...
props ericlewis.
fixes #28819 .
Built from https://develop.svn.wordpress.org/trunk@29322
git-svn-id: http://core.svn.wordpress.org/trunk@29103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 14:58:19 +00:00
7bbbbe44c7
Media Grid: Improve lazy loading.
...
props kovshenin.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@29312
git-svn-id: http://core.svn.wordpress.org/trunk@29093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 17:58:15 +00:00
ab151eca85
Media Grid: Ignore user setting for `content`.
...
fixes #29034 .
Built from https://develop.svn.wordpress.org/trunk@29305
git-svn-id: http://core.svn.wordpress.org/trunk@29087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 11:44:18 +00:00
0e4c8b2b0c
Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
...
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857 .
Built from https://develop.svn.wordpress.org/trunk@29299
git-svn-id: http://core.svn.wordpress.org/trunk@29081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 01:00:16 +00:00
5be43cfeb1
Media Grid: Manage focus when toggling between the grid and an edit attachment modal
...
Props adamsilverstein for the initial patch.
Fixes #28857 .
Built from https://develop.svn.wordpress.org/trunk@29282
git-svn-id: http://core.svn.wordpress.org/trunk@29064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:05:15 +00:00
Andrea Fercia
Adam Silverstein
Andrew Ozz
Aaron Jorbin
Dominik Schilling
Scott Taylor
Konstantin Obenland
John Blackbourn
Helen Hou-Sandí
Sergey Biryukov