1cde7d86f9
Coding Standards: Fix WPCS issues in `wp-admin/includes/template.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47775
git-svn-id: http://core.svn.wordpress.org/trunk@47551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-08 16:36:18 +00:00
43a6aff0d4
Coding Standards: Use strict comparison in `wp-includes/widgets/class-wp-widget-rss.php`.
...
Props mukesh27.
Fixes #50125 .
Built from https://develop.svn.wordpress.org/trunk@47774
git-svn-id: http://core.svn.wordpress.org/trunk@47550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-08 08:36:18 +00:00
33194d29c2
Site Health: Improve the appearance of administration email verification box.
...
Add `max-width` on desktop view and some padding on smaller screens.
Props chetan200891, azaozz, Clorith, afragen.
Fixes #48607 .
Built from https://develop.svn.wordpress.org/trunk@47772
git-svn-id: http://core.svn.wordpress.org/trunk@47548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-07 21:42:11 +00:00
7ded6c2d2a
Administration: Remove any CSS related to Internet Explorer versions 6 – 10.
...
In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks!
* Removes ie.css and `ie` style handle.
* Removes IE specific class names and any related CSS.
* Drops support for IE8 and older in `wp_customize_support_script()`.
* Updates compatibility mode for CSS minification to `ie11`.
Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90.
Fixes #17232 , #46015 .
Built from https://develop.svn.wordpress.org/trunk@47771
git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 20:15:07 +00:00
a0224a579d
Menus: Add a Cancel link to the screen for creating a new menu.
...
The use case this helps the most is when there's only one menu and you click "create a new menu". In this case the Cancel link allows you to go back to the single existing menu.
Props garrett-eclipse, audrasjb.
Fixes #46367 .
Built from https://develop.svn.wordpress.org/trunk@47770
git-svn-id: http://core.svn.wordpress.org/trunk@47546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 19:35:11 +00:00
bf3296a9a0
Script Loader: Add the `$group` parameter to `WP_Dependencies::do_item()`.
...
Previously, the method was called with two parameters in `::do_items()`, while the method signature only included one parameter.
Technically, this was not an issue as `WP_Dependencies::do_item()` is a placeholder meant to be overwritten when extending the class. When handling scripts, `WP_Dependencies` is extended with `WP_Scripts`, and the `$group` parameter was only used in `WP_Scripts::do_item()`, which does expect a second argument.
However, officially adding the parameter to `WP_Dependencies::do_item()` signature prevents code misunderstanding and avoids a warning in PHP code inspection tools.
Props kaggdesign, soulseekah, azaozz, SergeyBiryukov.
Fixes #43627 .
Built from https://develop.svn.wordpress.org/trunk@47769
git-svn-id: http://core.svn.wordpress.org/trunk@47545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 16:27:12 +00:00
86ac5e1432
Site Health: Do not trigger the fatal error handler while updates are being installed.
...
Triggering the error handler during updates may cause false positives. For example, updates may temporarily "fail" while files are moved around, but work fine once completed. Sending emails about temporary failures would just be confusing to the recipient.
Props Clorith, airamerica.
Fixes #48964 .
Built from https://develop.svn.wordpress.org/trunk@47768
git-svn-id: http://core.svn.wordpress.org/trunk@47544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 14:38:17 +00:00
538e9fb308
Block Editor: Update _all_ of the block editor packages following the 5.4.1 release.
...
This is an extension of [47619] and [47765].
Fixes #50094 .
Props aduth, peterwilsoncc, whyisjake, ocean90, and afercia.
Built from https://develop.svn.wordpress.org/trunk@47766
git-svn-id: http://core.svn.wordpress.org/trunk@47542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 23:56:33 +00:00
4a11b9db02
Block Editor: Update WordPress Packages following the 5.4.1 release.
...
This bumps @wordpress/block-library 2.14.7 ➡️ 2.14.8
Fixes #50094 .
Props aduth, peterwilsoncc, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47765
git-svn-id: http://core.svn.wordpress.org/trunk@47541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 23:39:31 +00:00
62f6909480
Code standards: Drop a newline in the customizer to comply with WordPress Coding Standards
...
Extends [47763] and #46829 .
Built from https://develop.svn.wordpress.org/trunk@47764
git-svn-id: http://core.svn.wordpress.org/trunk@47540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 22:00:09 +00:00
7a48040e13
Menus: Denote the special pages in the Customizer menu editor.
...
The special pages here are the pages that are used for the Privacy Policy, Home, and the Posts page.
Fixes #46829 .
Props garrett-eclipse, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@47763
git-svn-id: http://core.svn.wordpress.org/trunk@47539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 21:17:06 +00:00
9782eb82ad
Site Health: Display the original PHP memory limit on Site Health Info screen.
...
This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value.
Props Clorith, espiat, zodiac1978, SergeyBiryukov.
Fixes #49329 .
Built from https://develop.svn.wordpress.org/trunk@47762
git-svn-id: http://core.svn.wordpress.org/trunk@47538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 18:58:09 +00:00
b1a275684a
Canonical: Only redirect non-existing page requests to the post permalink if the post is found.
...
Follow-up to [47760].
See #45337 , #40773 , #28081 , #11694 .
Built from https://develop.svn.wordpress.org/trunk@47761
git-svn-id: http://core.svn.wordpress.org/trunk@47537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 10:49:07 +00:00
5b046976cc
Canonical: Redirect paged requests for a static page assigned as the "Posts page".
...
This avoids displaying duplicate content of the home page under different URLs with appended page numbers.
This change only affects the `<!--nextpage-->` pagination (`page` query variable) and not the regular multiple posts pagination (`paged` query variable).
The posts page does not support the `<!--nextpage-->` pagination, so requests for invalid page numbers should be redirected to the page permalink, applying the logic previously implemented for single posts or pages.
Follow-up to [34492], [47727].
Props jeremyfelt, sachit.tandukar, SergeyBiryukov.
Fixes #45337 . See #40773 , #28081 , #11694 .
Built from https://develop.svn.wordpress.org/trunk@47760
git-svn-id: http://core.svn.wordpress.org/trunk@47536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 10:42:07 +00:00
37d179de1c
Coding Standards: Fix WPCS issues in `wp-includes/canonical.php`.
...
Reformat long conditions and dense code blocks for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47759
git-svn-id: http://core.svn.wordpress.org/trunk@47535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 09:05:08 +00:00
46854d7322
REST API: Support more JSON Schemas when filtering a response by context.
...
The array type, multi-types, and the additional properties keyword are now supported. Additionally, the filter recurses to an infinite depth.
Fixes #48819 .
Built from https://develop.svn.wordpress.org/trunk@47758
git-svn-id: http://core.svn.wordpress.org/trunk@47534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 02:46:05 +00:00
ed4bdbb8f1
Tests: Update wp-api-generated.js.
...
[47755] and [47756] caused a schema change, so the wp-api-generated.js file needs to be updated.
Built from https://develop.svn.wordpress.org/trunk@47757
git-svn-id: http://core.svn.wordpress.org/trunk@47533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 00:28:09 +00:00
7023be21f5
REST API: Accept POST requests in the block renderer endpoint.
...
Rendering a block is idempotent, so a GET is the most natural request method. However, the maximum length of URLs prevented blocks with large attributes from being rendered.
Props ryankienstra.
Fixes #49680 .
Built from https://develop.svn.wordpress.org/trunk@47756
git-svn-id: http://core.svn.wordpress.org/trunk@47532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 22:58:05 +00:00
facb1728b9
REST API: Validate that the oembed url parameter is a string.
...
This prevents a PHP warning from being issued by esc_url_raw when a non-string value is provided.
Props dd32.
Fixes #49991 .
Built from https://develop.svn.wordpress.org/trunk@47755
git-svn-id: http://core.svn.wordpress.org/trunk@47531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 22:42:06 +00:00
717f0d0a3e
Docs: Misc docblock corrections and improvements.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@47754
git-svn-id: http://core.svn.wordpress.org/trunk@47530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 19:38:08 +00:00
ac3c2fe60a
REST API: Support the uuid JSON Schema format.
...
This accepts a uuid of any version. A future commit could add support for restricting uuids to a specific version.
Props johnwatkins0.
Fixes #50053 .
Built from https://develop.svn.wordpress.org/trunk@47753
git-svn-id: http://core.svn.wordpress.org/trunk@47529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 19:20:09 +00:00
c215a6dc27
Build/Test Tools: Further enhancements to the local development environment readme.
...
Props desrosj, donmhico
See #50058
Built from https://develop.svn.wordpress.org/trunk@47752
git-svn-id: http://core.svn.wordpress.org/trunk@47528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 14:43:07 +00:00
36524e1e25
File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.
...
Buttons should use the default buttons styles, no exceptions.
Props passoniate, garethgillman.
See #49197 .
Fixes #49353 .
Built from https://develop.svn.wordpress.org/trunk@47751
git-svn-id: http://core.svn.wordpress.org/trunk@47527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 14:21:08 +00:00
bc3cee1d5b
Upload: Improve file input and button alignment in plugin/theme upload form.
...
Resets flexbox on smaller screens. Improves vertical alignment on large screens.
Follow-up to [47599] and [47271].
Props mukesh27, DarkoG.
See #48859 , #49914 .
Fixes #49951 .
Built from https://develop.svn.wordpress.org/trunk@47750
git-svn-id: http://core.svn.wordpress.org/trunk@47526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 13:36:12 +00:00
72ef4ae81a
Docs: Further update inline documentation for the `wpdb` class per the documentation standards.
...
Restore some previous edits from [46696], [47060], [47122], [47230] that were accidentally reverted in [47740].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47749
git-svn-id: http://core.svn.wordpress.org/trunk@47525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 11:45:06 +00:00
f89f744fb2
Media: Ensure a consistent structure for the array returned by `wp_get_attachment_image_src()`.
...
The array returned by this function previously included a fourth element only when an intermediate image size was used. This change ensures a consistent structure in the returned array regardless of the function's internal behaviour.
Props wido, joemcgill, johnbillion
Fixes #46113
Built from https://develop.svn.wordpress.org/trunk@47748
git-svn-id: http://core.svn.wordpress.org/trunk@47524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 22:57:06 +00:00
1a27d51b48
Menus: Allow empty taxonomy terms to be surfaced when searching for items.
...
This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms.
Props birgire, audrasjb
Fixes #45298
Built from https://develop.svn.wordpress.org/trunk@47747
git-svn-id: http://core.svn.wordpress.org/trunk@47523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 22:36:07 +00:00
cc4e27142e
Upgrade/Install: Unlink the logo on the installation and config setup screens.
...
This allows for a natural tab order during installation, without negatively impacting users who use the keyboard for navigation, those who use a screen reader, or those who use neither.
Props lwill, afercia, audrasjb.
Fixes #47759
Built from https://develop.svn.wordpress.org/trunk@47746
git-svn-id: http://core.svn.wordpress.org/trunk@47522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 21:46:08 +00:00
5641afd43b
Administration: Reduce the chance that a PHP error message that occurs before the admin menu gets output is covered by the admin menu.
...
Props EmpireOfLight, afercia, Mte90, audrasjb, sunnyratilal
Fixes #35155
Built from https://develop.svn.wordpress.org/trunk@47745
git-svn-id: http://core.svn.wordpress.org/trunk@47521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 21:01:05 +00:00
55117c5376
Build/Test Tools: Add information regarding the default credentials for the local development environment to the project readme.
...
Props bookdude13
Fixes #49273
Built from https://develop.svn.wordpress.org/trunk@47744
git-svn-id: http://core.svn.wordpress.org/trunk@47520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 20:19:08 +00:00
7307415f6d
Build/Test Tools: Add more comprehensive instructions to the readme for the local development environment.
...
See #50058
Built from https://develop.svn.wordpress.org/trunk@47743
git-svn-id: http://core.svn.wordpress.org/trunk@47519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 19:16:07 +00:00
d29f5c14ac
Build/Test Tools: Exclude plugins and themes within `src`.
...
Just like the `build` directory, `src` can include plugins and themes which shouldn't be linted by PHPCS.
Fixes #49781
Built from https://develop.svn.wordpress.org/trunk@47742
git-svn-id: http://core.svn.wordpress.org/trunk@47518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 18:17:05 +00:00
1c01b6c32e
Build/Test Tools: Remove unnecessary formatting before linting on Travis CI.
...
Fixes #49722
Built from https://develop.svn.wordpress.org/trunk@47741
git-svn-id: http://core.svn.wordpress.org/trunk@47517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 17:46:07 +00:00
736874a51e
Docs: Update inline documentation for the wpdb class.
...
Props theMikeD
Fixes #49477
Built from https://develop.svn.wordpress.org/trunk@47740
git-svn-id: http://core.svn.wordpress.org/trunk@47516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 17:25:07 +00:00
a6f3ad2d21
Users: Don't reset user language preference on user update.
...
Props johnbillion.
Fixes #38665 .
Built from https://develop.svn.wordpress.org/trunk@47739
git-svn-id: http://core.svn.wordpress.org/trunk@47515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 16:29:06 +00:00
4abdb06f72
Query: Simplify the logic in `WP::handle_404()` to allow for easier modifications.
...
See #45337 .
Built from https://develop.svn.wordpress.org/trunk@47738
git-svn-id: http://core.svn.wordpress.org/trunk@47514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 08:48:08 +00:00
25c841026d
General: More PHP compatibility adjustments.
...
In this round:
- Removed references to `safe_mode` in `class-php3.php`. This was removed in PHP 5.4.
- Add inline exclude comments for compatibility checks in getID3.
Follow up of [47735-47736].
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47737
git-svn-id: http://core.svn.wordpress.org/trunk@47513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 20:12:06 +00:00
791e3bdb38
General: Fix typo within `phpcs:ignore` inline comment.
...
Follow up of [47735].
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47736
git-svn-id: http://core.svn.wordpress.org/trunk@47512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:36:06 +00:00
89ddd19884
General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
...
As part of the continued effort to improve PHP compatibility, the following improvments are being made:
- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.
Props desrosj, earnjam, dryanpress.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47735
git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:07:09 +00:00
10945d2f3d
Taxonomy: Restore (un-deprecate) the `tag_row_actions` filter.
...
The filter provides a simple way for plugin authors to add actions generically for all taxonomy list tables without looping through each taxonomy individually.
Props joemcgill, delowardev.
Fixes #49808 .
Built from https://develop.svn.wordpress.org/trunk@47734
git-svn-id: http://core.svn.wordpress.org/trunk@47510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 16:45:09 +00:00
a72e30d847
External Libraries: Update the SimplePie library to the latest version (1.5.5).
...
This brings SimplePie in sync with the most up to date version, 1.5.5.
This update brings many bug fixes, small enhancements, and PHP compatibility fixes for newer versions of PHP.
For a full list of changes, see https://github.com/simplepie/simplepie/blob/master/CHANGELOG.md#155-may-1-2020 .
Props dshanske, slushman, etruel, wpshades, dmenard, desrosj, hareesh-pillai, stevenkword, jrf, Ipstenu, johnbillion.
Fixes #36669 .
Built from https://develop.svn.wordpress.org/trunk@47733
git-svn-id: http://core.svn.wordpress.org/trunk@47509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 14:26:07 +00:00
7f5686d40e
Build/Test Tools: Introduce a command for restarting the local Docker environment.
...
This change introduces the `env:restart` command for easier restarting of the local Docker environment.
Props desrosj, ianbelanger.
Fixes #50039 .
Built from https://develop.svn.wordpress.org/trunk@47730
git-svn-id: http://core.svn.wordpress.org/trunk@47507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-30 20:22:06 +00:00
8959d57ceb
Reverting [47728].
...
Unprops desrosj.
See #50039 .
Built from https://develop.svn.wordpress.org/trunk@47729
git-svn-id: http://core.svn.wordpress.org/trunk@47506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-30 20:17:09 +00:00
4a6383a2da
-username=desrosj
...
Built from https://develop.svn.wordpress.org/trunk@47728
git-svn-id: http://core.svn.wordpress.org/trunk@47505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-30 19:55:07 +00:00
eae1462bef
Canonical: Redirect paged requests for non-paginated posts to the post permalink.
...
This avoids displaying duplicate content of the same post under different URLs and ensures the canonical URL is correct.
Previously, requests for invalid page numbers were only redirected to the post permalink if the post was actually paginated using the `<!--nextpage-->` marker.
Follow-up to [34492].
Props jeremyfelt, prografika, sachit.tandukar, subrataemfluence, hronak, ekatherine, henry.wright, chesio, dd32, SergeyBiryukov.
Fixes #40773 . See #45337 , #28081 , #11694 .
Built from https://develop.svn.wordpress.org/trunk@47727
git-svn-id: http://core.svn.wordpress.org/trunk@47504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-30 12:05:14 +00:00
8ca76cabfc
Help/About: Revert [47699] from trunk.
...
Built from https://develop.svn.wordpress.org/trunk@47706
git-svn-id: http://core.svn.wordpress.org/trunk@47483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 18:44:11 +00:00
cf8bd373fe
Update the about page for WordPress 5.4.1
...
Built from https://develop.svn.wordpress.org/trunk@47699
git-svn-id: http://core.svn.wordpress.org/trunk@47476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 18:37:05 +00:00
b1a318f3bd
Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.
...
Fixes the image caption alignment issue by adding `text-align: center;` to `.wp-block-image .aligncenter figcaption`.
Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320 .
Built from https://develop.svn.wordpress.org/trunk@47689
git-svn-id: http://core.svn.wordpress.org/trunk@47466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 18:19:05 +00:00
800b71ca31
Coding Standards: Fix WPCS issues in `tests/formatting/SanitizeFileName.php`.
...
Follow-up to [47638].
Built from https://develop.svn.wordpress.org/trunk@47664
git-svn-id: http://core.svn.wordpress.org/trunk@47441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 17:26:18 +00:00
266b52513b
Docs: Correct `@since` versions, remove duplicate comment.
...
Follow-up to [47633].
Built from https://develop.svn.wordpress.org/trunk@47663
git-svn-id: http://core.svn.wordpress.org/trunk@47440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 17:25:10 +00:00
fd21a9346c
Formatting: Expand `sanitize_file_name` to have better support for utf8 characters.
...
Props: xknown, peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@47638
git-svn-id: http://core.svn.wordpress.org/trunk@47413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 15:40:07 +00:00
c16fa7c73d
Cache API: Ensure proper escaping around the stats method in the cache API.
...
Props: nickdaugherty, batmoo, whyisjake, westi.
Built from https://develop.svn.wordpress.org/trunk@47637
git-svn-id: http://core.svn.wordpress.org/trunk@47412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 15:36:06 +00:00
94f5dc0cad
Block Editor: Coding standards, properly escape class names.
...
Props: aduth, noisysocks, pento, talldanwp, jorgefilipecosta, whyisjake, ellatrix, ehti.
Built from https://develop.svn.wordpress.org/trunk@47636
git-svn-id: http://core.svn.wordpress.org/trunk@47411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 15:34:09 +00:00
3ee9488292
Query: Ensure that only a single post can be returned on date/time based queries.
...
Props: sstoqnov, peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@47635
git-svn-id: http://core.svn.wordpress.org/trunk@47410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 15:28:04 +00:00
f7b4147bea
User: Invalidate `user_activation_key` on password update.
...
Props: sstoqnov, sergeybiryukov.
Built from https://develop.svn.wordpress.org/trunk@47634
git-svn-id: http://core.svn.wordpress.org/trunk@47409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 15:25:07 +00:00
55cd633c37
Customize: Add additional filters to Customizer to prevent JSON corruption.
...
This solution extends the wp_insert_post_data filter to pass in addition to the slashed/sanitized/processed data, and the slashed/sanitized/unprocessed data, to also pass the initial slashed/unsanitized/unprocessed data which was passed into wp_insert_post(). This then allows plugins to have complete control over how sanitization is performed based on the post type.
Props westonruter, peterwilsoncc, sstoqnov, whyisjake, xknown.
Built from https://develop.svn.wordpress.org/trunk@47633
git-svn-id: http://core.svn.wordpress.org/trunk@47408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 15:14:10 +00:00
3dc1e33fb5
Networks and Sites: Link to Nginx documentation on Network Setup screen when Nginx is in use.
...
Props lipathor, audrasjb, johnbillion, flixos90.
Fixes #41166 .
Built from https://develop.svn.wordpress.org/trunk@47632
git-svn-id: http://core.svn.wordpress.org/trunk@47407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 14:43:09 +00:00
0da2c98ddc
Docs: Correct `@return` type for `WP_Theme::get_post_templates()`.
...
The method returns an array of strings, not a single string.
Props mayankmajeji, salvatore.formisano.
Fixes #50020 .
Built from https://develop.svn.wordpress.org/trunk@47631
git-svn-id: http://core.svn.wordpress.org/trunk@47406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-28 15:02:11 +00:00
5371e3fd62
Site Health: Avoid a PHP notice in `WP_Site_Health::wp_cron_scheduled_check()` if async test response does not contain the expected result.
...
Additionally, avoid a PHP notice in `::get_test_php_version()` if the minimum recommended version of PHP could not be determined.
Props schlessera, oakesjosh.
Fixes #49943 .
Built from https://develop.svn.wordpress.org/trunk@47628
git-svn-id: http://core.svn.wordpress.org/trunk@47403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-27 22:01:08 +00:00
352cb55cca
REST API: Support the (min|max)Length JSON Schema keywords.
...
Props sorenbronsted.
Fixes #48820 .
Built from https://develop.svn.wordpress.org/trunk@47627
git-svn-id: http://core.svn.wordpress.org/trunk@47402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-27 02:29:07 +00:00
e55ca10ddc
Comments: Ensure that inserting a comment with an empty type results in correct `comment` type.
...
Add unit tests for `wp_handle_comment_submission()` and `wp_insert_comment()` receiving an empty type.
Follow-up to [47597].
Props ocean90, imath.
Fixes #49236 .
Built from https://develop.svn.wordpress.org/trunk@47626
git-svn-id: http://core.svn.wordpress.org/trunk@47401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-26 13:44:07 +00:00
6b5087812c
Comments: Restore inclusion of an empty comment type when building the `WHERE` clause in `WP_Comment_Query::get_comment_ids()`.
...
This ensures that `get_comments( array( 'type' => 'comment' ) )` still includes comments that have not yet migrated to the `comment` type.
Follow-up to [47597].
Props ocean90.
See #49236 .
Built from https://develop.svn.wordpress.org/trunk@47625
git-svn-id: http://core.svn.wordpress.org/trunk@47400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-26 13:14:06 +00:00
77eb929b52
Upgrade/Install: Introduce `wp_in_maintenance_mode()`, a helper function to check if WordPress is currently in maintenance mode.
...
Props Clorith.
Fixes #49959 .
Built from https://develop.svn.wordpress.org/trunk@47623
git-svn-id: http://core.svn.wordpress.org/trunk@47398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-25 20:19:07 +00:00
43cfa7ee60
Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides.
...
Additionally, reduce the right margin on screen meta links (Help and Screen Options) to align with the tables.
Props jainnidhi, garrett-eclipse, ibdz, SergeyBiryukov.
Fixes #43279 .
Built from https://develop.svn.wordpress.org/trunk@47622
git-svn-id: http://core.svn.wordpress.org/trunk@47397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-25 12:27:11 +00:00
72ef7ee315
Bundled Themes: Twenty Twenty remove unnecessary `$css_dependencies` variable in `twentytwenty_block_editor_styles()`.
...
Removes the unnecessary `$css_dependencies` variable in `twentytwenty_block_editor_styles()`.
Props ocean90, Dency.
Fixes #49986 .
Built from https://develop.svn.wordpress.org/trunk@47618
git-svn-id: http://core.svn.wordpress.org/trunk@47393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-24 14:59:07 +00:00
ced8fb20a1
Code Modernization: Remove error suppression from `parse_url()` calls.
...
Previously, the `@` operator was used to prevent possible warnings emitted by `parse_url()` in PHP < 5.3.3 when URL parsing failed.
Now that the minimum version of PHP required by WordPress is 5.6.20, this is no longer needed.
Props netpassprodsr, Howdy_McGee.
Fixes #49980 . See #24780 .
Built from https://develop.svn.wordpress.org/trunk@47617
git-svn-id: http://core.svn.wordpress.org/trunk@47392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-24 07:28:10 +00:00
0dc461c72e
Networks and Sites: Don't display an empty Menu Settings section in network admin if there are no items.
...
This accounts for returning an empty array from the `mu_menu_items` filter.
Props dlh.
Fixes #49977 .
Built from https://develop.svn.wordpress.org/trunk@47616
git-svn-id: http://core.svn.wordpress.org/trunk@47391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-23 18:58:05 +00:00
b6c70b7712
Embeds: Fix incorrect usage of `get_home_url()` in oEmbed tests.
...
Switch to `home_url()` for consistency with other tests and to avoid confusion.
Props david.binda.
Fixes #49988 .
Built from https://develop.svn.wordpress.org/trunk@47615
git-svn-id: http://core.svn.wordpress.org/trunk@47390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-23 18:41:07 +00:00
f97ac354c6
Bundled Themes: Twenty Twenty button styles produce inconsistent output and cannot be edited.
...
Fixes the issue with button styles not working when the Gutenberg plugin is activated while maintaining backwards compatibility.
Props nrqsnchz, poena, kjellr.
Fixes #49896 .
Built from https://develop.svn.wordpress.org/trunk@47614
git-svn-id: http://core.svn.wordpress.org/trunk@47389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-23 15:41:09 +00:00
4632322382
Bundled Themes: Twenty Twenty resized images are centered inside the editor (with no alignment set) since WordPress 5.4.
...
Fixes the image alignment issue by removing `margin-left: auto;` and `margin-right: auto;` from `.editor-styles-wrapper .wp-block-image.is-resized`.
Props dianeco, JavierCasares.
Fixes #49600 .
Built from https://develop.svn.wordpress.org/trunk@47613
git-svn-id: http://core.svn.wordpress.org/trunk@47388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-22 19:25:08 +00:00
a753e44d4e
Bootstrap/Load: Deprecate `wp_unregister_GLOBALS()`.
...
The `register_globals` directive in PHP was deprecated in version 5.3 and removed entirely in 5.4.
Now that WordPress only supports PHP 5.6.20 and newer, the `wp_unregister_GLOBALS()` function can be deprecated.
Props ayeshrajans, desrosj, SergeyBiryukov.
Fixes #49938 .
Built from https://develop.svn.wordpress.org/trunk@47612
git-svn-id: http://core.svn.wordpress.org/trunk@47387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-22 15:42:09 +00:00
427405535f
Docs: Synchronize parameter documentation for various metadata functions, update per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47611
git-svn-id: http://core.svn.wordpress.org/trunk@47386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-22 10:31:09 +00:00
9aa0fff80e
Docs: Document the default value of `$single` and `$prev_value` parameters in various metadata functions.
...
Props denisco.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47610
git-svn-id: http://core.svn.wordpress.org/trunk@47385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-22 09:40:10 +00:00
29abe5c726
Bundled Themes: Twenty Twenty submenu items disappear underneath the Cover block.
...
Fixes the submenu issue by raising the z-index value of the site-header from 1 to 2.
Props kjellr, JavierCasares.
Fixes #49322 .
Built from https://develop.svn.wordpress.org/trunk@47609
git-svn-id: http://core.svn.wordpress.org/trunk@47384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 20:06:08 +00:00
116a9b3039
Bundled Themes: Twenty Twenty missed license for images.
...
Fixes the image license in the readme by removing screenshot.png.
Props h71, poena.
Fixes #49316 .
Built from https://develop.svn.wordpress.org/trunk@47608
git-svn-id: http://core.svn.wordpress.org/trunk@47383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 19:43:09 +00:00
c9ea34b6b3
Bundled Themes: Twenty Twenty block editor inserter is missing the `+`.
...
Fixes the disappearing `+` in the block editor when using the latest version of the Gutenberg plugin, by adding support for the native Gutenberg editor styles and removing `color: inherit;` from Twenty Twenty's style.css.
Props nrqsnchz, .
Fixes #49610 .
Built from https://develop.svn.wordpress.org/trunk@47607
git-svn-id: http://core.svn.wordpress.org/trunk@47382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 19:17:08 +00:00
6c243b4b0a
Networks and Sites: Display the Site Address field on Add Site screen in left-to-right text direction.
...
Props ramiy.
Fixes #49949 .
Built from https://develop.svn.wordpress.org/trunk@47606
git-svn-id: http://core.svn.wordpress.org/trunk@47381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 11:26:07 +00:00
b4373fafe9
Menus: Remove unused commented out code in `wp-admin/nav-menus.php`.
...
Props garrett-eclipse, audrasjb.
Fixes #49967 .
Built from https://develop.svn.wordpress.org/trunk@47605
git-svn-id: http://core.svn.wordpress.org/trunk@47380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 09:02:08 +00:00
589666abc3
External Libraries: Revert [47603].
...
With the Docker image for PHP 7.4 updated to stable version, this should no longer be necessary.
See https://github.com/WordPress/wpdev-docker-images/pull/26
Props ocean90.
Fixes #49945 .
Built from https://develop.svn.wordpress.org/trunk@47604
git-svn-id: http://core.svn.wordpress.org/trunk@47379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 15:41:08 +00:00
e9e5d8e2b2
External Libraries: Comment out magic quote functions in getID3().
...
For some reason, the `version_compare()` check does not work as expected on Travis.
Follow-up to [46113], [47601].
See #49945 .
Built from https://develop.svn.wordpress.org/trunk@47603
git-svn-id: http://core.svn.wordpress.org/trunk@47378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 12:12:06 +00:00
1bac2cbe66
External Libraries: Backport a commit from getID3() trunk to fix a PHP 7.4+ notice.
...
This addresses a "Trying to access array offset on value of type bool" notice in the `getid3_mp3::MPEGaudioHeaderValid()` method.
Props schlessera.
Fixes #49945 .
Built from https://develop.svn.wordpress.org/trunk@47602
git-svn-id: http://core.svn.wordpress.org/trunk@47377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 11:34:07 +00:00
694bec2071
External Libraries: Update getID3() to 1.9.19.
...
Changelog: https://github.com/JamesHeinrich/getID3/compare/v1.9.18...v1.9.19
Props ayeshrajans, schlessera.
See #49945 .
Built from https://develop.svn.wordpress.org/trunk@47601
git-svn-id: http://core.svn.wordpress.org/trunk@47376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 11:13:07 +00:00
71dea21c5f
Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency.
...
Props donmhico, bcworkz, seanchayes, mikeschroder, garrett-eclipse, akhileshsabharwal, ScottSmith, nacin, jenmylo, afercia, swissspidy, felix-edelmann, helen, melchoyce, karmatosed.
Fixes #26769 .
Built from https://develop.svn.wordpress.org/trunk@47600
git-svn-id: http://core.svn.wordpress.org/trunk@47375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 08:39:06 +00:00
30a35a4806
Upload: Better align file input and buttons in plugin/theme upload form.
...
Follow-up to [47271].
Props seedsca, piyushmca.
Fixes #49914 .
Built from https://develop.svn.wordpress.org/trunk@47599
git-svn-id: http://core.svn.wordpress.org/trunk@47374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-19 09:47:08 +00:00
ee387b9181
Accessibility: Widgets: Prevent checkboxes in widget control forms from overlapping on smaller screens.
...
Props jaz_on, milindmore22, passoniate, audrasjb, carriganvb, afercia, SergeyBiryukov.
Fixes #49228 .
Built from https://develop.svn.wordpress.org/trunk@47598
git-svn-id: http://core.svn.wordpress.org/trunk@47373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-18 07:03:09 +00:00
61a2f62ffd
Comments: Use `comment` instead of an empty string for the `comment_type` DB field value in comments table.
...
This is the first step to bring support for custom comment types into WordPress.
Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time.
Props imath, aaroncampbell, jeremyfelt, dshanske.
Fixes #49236 .
Built from https://develop.svn.wordpress.org/trunk@47597
git-svn-id: http://core.svn.wordpress.org/trunk@47372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 19:35:06 +00:00
012b134b23
Coding Standards: Fix WPCS indentation issue in `wp-admin/nav-menus.php`.
...
This was causing a `PEAR.Functions.FunctionCallSignature.Indent` error if PHP_CodeSniffer 3.5.3 or newer is installed locally, despite the task passing on Travis.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47596
git-svn-id: http://core.svn.wordpress.org/trunk@47371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 18:55:09 +00:00
af1a737b48
Coding Standards: Fix WPCS indentation issue in `wp-admin/includes/class-wp-links-list-table.php`.
...
This was causing a `Generic.WhiteSpace.ScopeIndent.IncorrectExact` error if PHP_CodeSniffer 3.4.1 or newer is installed locally, despite the task passing on Travis.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47595
git-svn-id: http://core.svn.wordpress.org/trunk@47370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 18:31:07 +00:00
cf9b35eccd
Bundled Themes: Twenty Twenty fix typo in readme.txt.
...
Fixed TikTok was misspelled as Tik Tok in the readme.txt.
Props Asif2BD.
Fixes #49932 .
Built from https://develop.svn.wordpress.org/trunk@47594
git-svn-id: http://core.svn.wordpress.org/trunk@47369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 15:47:08 +00:00
fc7561ce11
Coding Standards: Format the markup of widget forms in a more consistent manner.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47593
git-svn-id: http://core.svn.wordpress.org/trunk@47368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 09:38:07 +00:00
900cfc4816
Administration: Remove the smiley from overly happy "No activity yet!" message on Dashboard.
...
Props francoist, karmatosed, ibdz, estelaris, nrqsnchz, Presskopp.
Fixes #48387 .
Built from https://develop.svn.wordpress.org/trunk@47592
git-svn-id: http://core.svn.wordpress.org/trunk@47367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 07:57:10 +00:00
d9c2537d87
Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken.
...
Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.
Props kjellr, melchoyce.
Fixes #49699 .
Built from https://develop.svn.wordpress.org/trunk@47591
git-svn-id: http://core.svn.wordpress.org/trunk@47366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 19:47:10 +00:00
c03b6040fe
Bundled Themes: Twenty Twenty inline images in list blocks are not positioned correctly.
...
Fixes the alignment of inline images in list blocks to match the way they look in the editor.
Props poena, mayankmajeji, JavierCasares.
Fixes #49793 .
Built from https://develop.svn.wordpress.org/trunk@47590
git-svn-id: http://core.svn.wordpress.org/trunk@47365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 19:38:07 +00:00
5116ed9ebb
Bundled Themes: Twenty Twenty add TikTok to the social icon menu.
...
This adds TikTok as an option in the social icon menu.
Props mislavjuric, poena, audrasjb.
Fixes #49893 .
Built from https://develop.svn.wordpress.org/trunk@47589
git-svn-id: http://core.svn.wordpress.org/trunk@47364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 19:01:09 +00:00
4fbfbf5f61
Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing.
...
Props roytanck, shooper.
Fixes #49916 .
Built from https://develop.svn.wordpress.org/trunk@47588
git-svn-id: http://core.svn.wordpress.org/trunk@47363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 17:02:08 +00:00
b2f072b97e
Bundled Themes: Twenty Nineteen editor style interferes with navigation menu block.
...
Update editor styles to prepare for changes coming to the editor in 5.5. Currently the issue is only present when using the latest version of the Gutenberg plugin.
Props kjellr, Joen.
Fixes #49613 .
Built from https://develop.svn.wordpress.org/trunk@47587
git-svn-id: http://core.svn.wordpress.org/trunk@47362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 14:56:16 +00:00
90f5e0576b
Bundled Themes: Twenty Nineteen decrease the font size for widget titles.
...
Update styles to decrease the font size for widget titles.
Props kjellr, mukesh27.
Fixes #45865 .
Built from https://develop.svn.wordpress.org/trunk@47586
git-svn-id: http://core.svn.wordpress.org/trunk@47361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 14:38:10 +00:00
92538d89ee
Site Health: Detect an active PHP session as a possible reason for HTTP requests timing out.
...
PHP sessions created by a `session_start()` function call may interfere with REST API and loopback requests.
An active session should be closed by `session_write_close()` before making any HTTP requests.
Props matthieumota, netweblogic, Clorith, afragen, vjik, SergeyBiryukov.
Fixes #47320 .
Built from https://develop.svn.wordpress.org/trunk@47585
git-svn-id: http://core.svn.wordpress.org/trunk@47360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 08:20:09 +00:00
4e13efaf96
Code Modernization: Remove conditional use of `stream_get_contents()` PHP function.
...
The function was introduced in PHP 5.0.0. Now that the minimum version of PHP required by WordPress is 5.6.20, these conditions are no longer needed.
Props jrf.
Fixes #48091 .
Built from https://develop.svn.wordpress.org/trunk@47584
git-svn-id: http://core.svn.wordpress.org/trunk@47359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-15 11:54:08 +00:00
bb2c0198ab
Comments: Clarify that "Comment Moderation" and "Comment Blocklist" options in Discussion Settings also apply to browser's user agent string for submitted comments.
...
Props zodiac1978.
Fixes #49902 .
Built from https://develop.svn.wordpress.org/trunk@47583
git-svn-id: http://core.svn.wordpress.org/trunk@47358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-15 06:40:05 +00:00
2d04c2e5c8
Posts, Post Types: Pass the post object to the `before_delete_post`, `delete_post`, `deleted_post`, and `after_delete_post` actions.
...
Props jadpm.
Fixes #30940 .
Built from https://develop.svn.wordpress.org/trunk@47582
git-svn-id: http://core.svn.wordpress.org/trunk@47357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-14 19:26:07 +00:00
a4f6f2beae
Mail: Make the check for empty post title in `wp-mail.php` more resilient.
...
This addresses a regression in [47054], which caused posts sent via email to published with an empty title.
Props whyisjake, Otto42, MarkRH, MattyRob, mukesh27, afragen, pikamander2.
Fixes #49853 .
Built from https://develop.svn.wordpress.org/trunk@47580
git-svn-id: http://core.svn.wordpress.org/trunk@47355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-14 11:32:06 +00:00
a21b8a91c6
Docs: Add a `@since` note for un-deprecated `category_link` and `tag_link` filters.
...
Follow-up to [47576].
See #49759 .
Built from https://develop.svn.wordpress.org/trunk@47578
git-svn-id: http://core.svn.wordpress.org/trunk@47353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-14 08:15:19 +00:00
0a714eb26f
Taxonomy: Un-depracate `category_link` and `tag_link` filters.
...
Depracating these filter might have been an accident, so let's restore.
Props SergeyBiryukov, audrasjb, peterwilsoncc.
Fixes #49759 .
Built from https://develop.svn.wordpress.org/trunk@47576
git-svn-id: http://core.svn.wordpress.org/trunk@47351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-14 00:33:09 +00:00
ae59482c80
Plugins: Simplify the logic of `validate_plugin_requirements()`, update documentation.
...
This updates the function for consistency with `validate_theme_requirements()`.
Follow-up to [44978], [45546], [47573].
Fixes #43992 .
Built from https://develop.svn.wordpress.org/trunk@47574
git-svn-id: http://core.svn.wordpress.org/trunk@47349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-13 15:31:05 +00:00
d341f20fb1
Themes: Block theme activation if it requires a higher version of PHP or WordPress.
...
Introduce `validate_theme_requirements()` for validating a theme's WordPress and PHP version requirements.
Follow-up to [44978] and [45546] for plugins.
Props afragen, audrasjb, SergeyBiryukov.
See #43992 .
Built from https://develop.svn.wordpress.org/trunk@47573
git-svn-id: http://core.svn.wordpress.org/trunk@47348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-13 15:28:11 +00:00
87b3b38242
Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete.
...
This adds a "Copied!" text near the "Copy this section to clipboard" button to provide direct feedback that the action was completed.
Props garrett-eclipse, nickylimjj, xkon, desrosj, birgire.
Fixes #44588 .
Built from https://develop.svn.wordpress.org/trunk@47572
git-svn-id: http://core.svn.wordpress.org/trunk@47347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-12 14:26:11 +00:00
48225beffb
Rewrite Rules: Use double quotes instead of backticks in `.htaccess` instructions about `# BEGIN/END` markers.
...
Previously, the backticks resulted in extra markup being added when posted on support forums.
Props mayankmajeji, knutsp.
Fixes #49868 .
Built from https://develop.svn.wordpress.org/trunk@47571
git-svn-id: http://core.svn.wordpress.org/trunk@47346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-11 15:09:11 +00:00
9f379bb930
Docs: Fix typo in `WP_Upgrader::__construct()` DocBlock.
...
Props mattrad.
Fixes #49856 .
Built from https://develop.svn.wordpress.org/trunk@47570
git-svn-id: http://core.svn.wordpress.org/trunk@47345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-10 09:48:17 +00:00
92636d716a
Site Health instantiation prevents use of some hooks by plugins.
...
As the WP_Site_Health class is instantiated prior to plugins being required and the `plugins_loaded` hook being fired, it prevents plugins from using the following hooks in the functions called by `maybe_create_scheduled_event()`.
Fixes #49824 .
Props peterwilsoncc, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47568
git-svn-id: http://core.svn.wordpress.org/trunk@47343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-10 03:57:08 +00:00
e42f45e667
Customize: Give the WordPress logo a white background for dark mode browsers.
...
The favicon is transparent, which would normally look fine, but on a dark background it washes out.
Props DhrRob, audrasjb.
Fixes 49798.
Built from https://develop.svn.wordpress.org/trunk@47564
git-svn-id: http://core.svn.wordpress.org/trunk@47339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-10 02:50:07 +00:00
a1bf993892
Privacy: Support additional elements (table, ol, ul) in privacy policy guide new styling
...
The privacy policy guide supports a lot of HTML, include rules for lists, and ensure proper styling for the rest.
Props garrett-eclipse.
Fixes #49772 .
Built from https://develop.svn.wordpress.org/trunk@47560
git-svn-id: http://core.svn.wordpress.org/trunk@47335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 22:34:05 +00:00
951b1d89db
REST API: Handle parameter types consistently within set_param().
...
A request has multiple parameter types, including "query" and "json." Updating a parameter could previously modify a key's value in the wrong parameter type, leading to confusing and self-contradictory response objects.
Props mnelson4, TimothyBlynJacobs, vagios, jnylen0.
Fixes #40838 .
Built from https://develop.svn.wordpress.org/trunk@47559
git-svn-id: http://core.svn.wordpress.org/trunk@47334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 19:30:07 +00:00
f927fdedb4
Accessibility: Fix the headings hierarchy on the Freedoms page.
...
Props ryelle, afercia.
Fixes #49838 .
Built from https://develop.svn.wordpress.org/trunk@47558
git-svn-id: http://core.svn.wordpress.org/trunk@47333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 16:09:11 +00:00
856e1a27b8
Coding Standards: Use strict type check for `in_array()` and `array_search()`.
...
This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core.
Includes minor code layout fixes for better readability.
Follow-up to [47550].
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47557
git-svn-id: http://core.svn.wordpress.org/trunk@47332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 15:43:10 +00:00
7097f6cef0
Tests: Pass API key to distributed test reporter.
...
Pass environment variable for test reporter API key to
`docker-compose` so that it can authenticate and submit results
to the hosting distributed tests.
Props SergeyBiryukov, mikeschroder.
Fixes #49846 .
Built from https://develop.svn.wordpress.org/trunk@47556
git-svn-id: http://core.svn.wordpress.org/trunk@47331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 06:08:10 +00:00
c18e44d6b1
Privacy: Make the deprecated `wp_get_user_request_data()` function available on front end.
...
Previously, it was accidentally made available only in admin context.
Follow-up to [44606], [47245].
Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12.
Fixes #49802 .
Built from https://develop.svn.wordpress.org/trunk@47555
git-svn-id: http://core.svn.wordpress.org/trunk@47330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-08 18:33:08 +00:00
0e38f8ed26
Media: Enable lazy-loading of images by automatically adding the new `loading="lazy"` attribute to image tags on the front-end.
...
- Introduces `wp_lazy_loading_enabled()`, `wp_filter_content_tags()`, `wp_img_tag_add_loading_attr()`, and `wp_img_tag_add_srcset_and_sizes_attr()` functions.
- Introduces `wp_lazy_loading_enabled`, `wp_img_tag_add_loading_attr`, and `wp_img_tag_add_srcset_and_sizes_attr` filters.
Props flixos90, addyosmani, mor10, swissspidy, pierlo, westonruter, spacedmonkey, mikeschroder, jonoaldersonwp, peterwilsoncc, narwen, jeffpaul, OptimizingMatters, futtta, mukeshpanchal27, azaozz.
Fixes #44427 .
Built from https://develop.svn.wordpress.org/trunk@47554
git-svn-id: http://core.svn.wordpress.org/trunk@47329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-08 00:55:07 +00:00
195312ead2
Users: Pass the ID of the user that was logged out to the `wp_logout` action.
...
Props donmhico, figureone, TimothyBlynJacobs, rebasaurus.
Fixes #49533 .
Built from https://develop.svn.wordpress.org/trunk@47553
git-svn-id: http://core.svn.wordpress.org/trunk@47328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-07 16:14:10 +00:00
78e62aa3e4
Coding Standards: Whitelist `date_default_timezone_set()` usage in `wp-settings.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47552
git-svn-id: http://core.svn.wordpress.org/trunk@47327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-06 09:06:12 +00:00
57b7f0bc22
Coding Standards: Switch `WordPress.PHP.YodaConditions.NotYoda` back to error level.
...
This was marked as a warning in [45665] until all the issues associated with the sniff are addressed, so that linting on Travis could run across the entire codebase.
With all the instances now addressed, this override is no longer needed.
Follow-up to [47054], [47218], [47219].
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47551
git-svn-id: http://core.svn.wordpress.org/trunk@47326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:21:06 +00:00
38676936ba
Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
10e3e44219
Media: Remove `display: none;` from the (visually hidden) `<input type="file">` button used in Plupload to select files for uploading. Fixes selecting files in Edge <= 44 and iOS Safari.
...
Props treecutter, johnbillion, pbiron, isabel_brison, Ipstenu, azaozz.
Fixes #49753 for trunk.
Built from https://develop.svn.wordpress.org/trunk@47549
git-svn-id: http://core.svn.wordpress.org/trunk@47324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-04 22:54:09 +00:00
9f481cdf7a
Tests: Remove `test_post_thumbnails_types_true()`.
...
The test incorrectly describes the behavior of `current_theme_supports( 'post-thumbnails' )` and only passes by accident.
Follow-up to [30148].
Fixes #49801 .
Built from https://develop.svn.wordpress.org/trunk@47548
git-svn-id: http://core.svn.wordpress.org/trunk@47323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-04 00:27:06 +00:00
51619c00a4
REST API: Fix revisions controller get_item permission check.
...
r45812 incorrectly introduced a delete_post permissions check into the get_item method, breaking some plugins which requested revisions when generating previews.
Props sorenbronsted, yohannp, TimothyBlynJacobs.
Fixes #49645 .
Built from https://develop.svn.wordpress.org/trunk@47547
git-svn-id: http://core.svn.wordpress.org/trunk@47322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-03 19:40:08 +00:00
441001f29f
Docs: Add documentation for the `$parent` parameter of `get_admin_page_parent()`.
...
Props subrataemfluence.
Fixes #45849 .
Built from https://develop.svn.wordpress.org/trunk@47546
git-svn-id: http://core.svn.wordpress.org/trunk@47321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-03 17:23:11 +00:00
ca8463f4f4
Docs: Use third-person singular verbs for function descriptions in `wp-includes/category-template.php`, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47545
git-svn-id: http://core.svn.wordpress.org/trunk@47320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-02 15:51:08 +00:00
4ef14fd7af
Build/Test Tools: Remove a starting empty line from `svn:ignore` property on `wp-includes`.
...
Follow-up to [47352].
See #48154 .
Built from https://develop.svn.wordpress.org/trunk@47544
git-svn-id: http://core.svn.wordpress.org/trunk@47319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-01 13:45:09 +00:00
64b3c852bf
Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4.
...
Props ianbelanger, desrosj, SergeyBiryukov.
Fixes #49743 .
Built from https://develop.svn.wordpress.org/trunk@47539
git-svn-id: http://core.svn.wordpress.org/trunk@47314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-31 19:11:07 +00:00
402193798e
Twenty Nineteen: Update `style-editor.css` after [47327].
...
Props ianbelanger.
See #48526 .
Built from https://develop.svn.wordpress.org/trunk@47537
git-svn-id: http://core.svn.wordpress.org/trunk@47312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-31 18:57:11 +00:00
116d909f58
Twenty Nineteen: Update `style-rtl.css` after [47339].
...
Props ianbelanger.
See #49410 .
Built from https://develop.svn.wordpress.org/trunk@47536
git-svn-id: http://core.svn.wordpress.org/trunk@47311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-31 18:55:10 +00:00
042bf6dbd9
Administration: Make the height of dashboard widget headings consistent with that of post meta boxes on smaller screens.
...
This also ensures that the toggle arrow for dashboard widgets is properly aligned.
Props chetan200891.
Fixes #49727 .
Built from https://develop.svn.wordpress.org/trunk@47535
git-svn-id: http://core.svn.wordpress.org/trunk@47310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-31 02:52:07 +00:00
2e7235f7ca
Bundled Themes: Twenty Twenty Button block forces All Capital letters - revert [47531].
...
Reverts [47531] to add `text-transform: uppercase;` back to button blocks.
Props joyously.
Fixes #49710 .
Built from https://develop.svn.wordpress.org/trunk@47534
git-svn-id: http://core.svn.wordpress.org/trunk@47309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 18:29:08 +00:00
e38a57db0c
Help/About: Use CDN URLs for 5.4 About page header images.
...
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47532
git-svn-id: http://core.svn.wordpress.org/trunk@47307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 17:49:07 +00:00
340216b5eb
Bundled Themes: Twenty Twenty Button block forces All Capital letters.
...
Removes `text-transform: uppercase;` from button blocks in order to give the user the option to have a button without All Capital letters.
Props mukesh27.
Fixes #49710 .
Built from https://develop.svn.wordpress.org/trunk@47531
git-svn-id: http://core.svn.wordpress.org/trunk@47306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 15:20:07 +00:00
49d7b8c51f
Filesystem API: Correct punctuation in `request_filesystem_credentials()` error message.
...
Props mayankmajeji, kharisblank.
Fixes #49724 .
Built from https://develop.svn.wordpress.org/trunk@47530
git-svn-id: http://core.svn.wordpress.org/trunk@47305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 01:32:07 +00:00
c83710ccee
Site Health: Remove paragraph tag from the actions container in issue template.
...
Most of the tests pass content that is already wrapped in a paragraph or list tags, thus producing nested paragraphs or invalid markup.
Additionally, don't output an empty `<div>` tag if the test does not provide any actions.
Props maxpertici, afercia.
Fixes #48948 .
Built from https://develop.svn.wordpress.org/trunk@47529
git-svn-id: http://core.svn.wordpress.org/trunk@47304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 01:25:11 +00:00
764a1761aa
Site Health: Correct markup in `::get_test_php_extensions()` and `::get_test_background_updates()` description.
...
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.
Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.
Props afercia.
See #48948 .
Built from https://develop.svn.wordpress.org/trunk@47528
git-svn-id: http://core.svn.wordpress.org/trunk@47303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-29 03:46:06 +00:00
d552e475fd
Site Health: Add pretty links support information to debug data.
...
Props valentinbora, afragen.
Fixes #49422 .
Built from https://develop.svn.wordpress.org/trunk@47527
git-svn-id: http://core.svn.wordpress.org/trunk@47302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-28 21:20:06 +00:00
8f1eddef11
Comments: Ensure all elements in the array returned by `get_comment_count()` are integers.
...
Previously elements would be a mixture of strings and integers depending on their numeric value.
Props progremzion, m.usama.masood
Fixes #48093
Built from https://develop.svn.wordpress.org/trunk@47526
git-svn-id: http://core.svn.wordpress.org/trunk@47301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-28 20:44:09 +00:00
ce2dea9ef6
Help/About: Improve accessibility of the 5.4 About page:
...
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.
Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47521
git-svn-id: http://core.svn.wordpress.org/trunk@47296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 23:41:06 +00:00
a546a9c35c
Coding Standards: Remove some extra tabs in `wp-admin/user-new.php`.
...
Follow-up to [47516], [47519].
See #38665 .
Built from https://develop.svn.wordpress.org/trunk@47520
git-svn-id: http://core.svn.wordpress.org/trunk@47295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:30:09 +00:00
ee1bf5a911
Coding Standards: Fix WPCS issues in [47516].
...
See #38665 .
Built from https://develop.svn.wordpress.org/trunk@47519
git-svn-id: http://core.svn.wordpress.org/trunk@47294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:25:08 +00:00
0a2dad400d
Block Editor: Update WordPress Packages WordPress 5.4 RC 5 Take 2.
...
The following package versions were changed:
@wordpress/edit-post: 3.13.8 -> 3.13.9
Includes PR https://github.com/WordPress/gutenberg/pull/21220
Props aduth, mapk, ItsJonQ.
Fixes : #49717 .
Built from https://develop.svn.wordpress.org/trunk@47517
git-svn-id: http://core.svn.wordpress.org/trunk@47292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:08:24 +00:00
41ae74f7b4
Users: Add a user language preference option to the "Add New User" form.
...
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.
Props barryceelen, johnbillion
Fixes #38665
Built from https://develop.svn.wordpress.org/trunk@47516
git-svn-id: http://core.svn.wordpress.org/trunk@47291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 21:58:05 +00:00
38e37b83df
Site Health: Remove `esc_url()` used on "Debugging in WordPress" article URL in `WP_Fatal_Error_Handler::display_default_error_template()`.
...
The function may not be available in some contexts, for example if a fatal error happens in `advanced-cache.php` drop-in.
Props rob006.
Fixes #49709 .
Built from https://develop.svn.wordpress.org/trunk@47515
git-svn-id: http://core.svn.wordpress.org/trunk@47290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 18:22:06 +00:00
b9ef707d7d
Block Editor: Update WordPress Packages WordPress 5.4 RC 5.
...
The following package versions were changed:
@wordpress/annotations: 1.12.2 -> 1.12.3
@wordpress/block-directory: 1.5.6 -> 1.5.7
@wordpress/block-editor: 3.7.6 -> 3.7.7
@wordpress/block-library: 2.14.6 -> 2.14.7
@wordpress/blocks: 6.12.2 -> 6.12.3
@wordpress/components: 9.2.5 -> 9.2.6
@wordpress/core-data: 2.12.2 -> 2.12.3
@wordpress/edit-post: 3.13.7 -> 3.13.8
@wordpress/editor: 9.12.6 -> 9.12.7
@wordpress/format-library: 1.14.6 -> 1.14.7
@wordpress/list-reusable-blocks: 1.13.5 -> 1.13.6
@wordpress/nux: 3.12.5 -> 3.12.6
@wordpress/server-side-render: 1.8.5 -> 1.8.6
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21210 .
Props mcsf, aduth.
Fixes : #49716 .
Built from https://develop.svn.wordpress.org/trunk@47513
git-svn-id: http://core.svn.wordpress.org/trunk@47288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 18:10:36 +00:00
f4f1184deb
Build/Test Tools: Update QUnit and Sinon to the latest versions.
...
Update JS tests per the QUnit 2.x Upgrade Guide.
Fixes #37117 .
Built from https://develop.svn.wordpress.org/trunk@47512
git-svn-id: http://core.svn.wordpress.org/trunk@47287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 00:18:22 +00:00
58d5aad2a3
REST API: Fix _fields filtering of registered rest fields.
...
Use rest_is_field_included when determining which additional fields to include to permit filtering by nested field properties.
Props Dudo, kadamwhite, TimothyBlynJacobs.
Fixes #49648 .
Built from https://develop.svn.wordpress.org/trunk@47511
git-svn-id: http://core.svn.wordpress.org/trunk@47286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 17:52:16 +00:00
7dbad241cb
Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area.
...
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.
Props rebasaurus
Fixes #49268
Built from https://develop.svn.wordpress.org/trunk@47510
git-svn-id: http://core.svn.wordpress.org/trunk@47285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 17:50:15 +00:00
Sergey Biryukov
Dominik Schilling
whyisjake
TimothyBlynJacobs
John Blackbourn
Andrea Fercia
desrosj
ianbelanger
K. Adam White
Mike Schroder
Andrew Ozz
jorgefilipecosta