Dominik Schilling
2f998cac7f
Database: Normalize index definitions in `dbDelta()`.
...
`dbDelta()` compares the index definitions against the result of `SHOW INDEX FROM $table_name`. This requires a specific format so indices are not unnecessarily re-created. This format wasn't ensured, until now.
* Parse the raw index definition to extract the type, name and columns so a normalized definition can be built (#20263 , #34873 ).
* Standardize on uppercase types (#34871 ) and on 'KEY'. 'INDEX' is only a synonym for 'KEY'.
* Escape index names with backticks (#20263 ).
* Normalize columns: Ignore ASC and DESC definitions (#34959 ), remove whitespaces (#34869 ) and escape column names with backticks (#20263 ).
* Add backticks to all index change queries (#20263 ).
Props ocean90, pento, kurtpayne.
Fixes #20263 , #34869 , #34871 , #34873 , #34959 .
Built from https://develop.svn.wordpress.org/trunk@37583
git-svn-id: http://core.svn.wordpress.org/trunk@37551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-27 11:57:30 +00:00
Peter Wilson
e7c508cb40
Customize: Run autoprefixer following [37476]
...
Adds prefixes to box-shadow and transition properties.
See #34893
Built from https://develop.svn.wordpress.org/trunk@37582
git-svn-id: http://core.svn.wordpress.org/trunk@37550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-27 05:15:28 +00:00
Gary Pendergast
58da002b34
Setup: Sanity check for invalid table prefixes.
...
There are some table prefixes (for example, `7e1_`), which MySQL will try and parse as values when they're note quoted in backticks. Because not everything remembers to quote their table names, it's best if we just discourage their use during setup.
Fixes #36422 .
Built from https://develop.svn.wordpress.org/trunk@37581
git-svn-id: http://core.svn.wordpress.org/trunk@37549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-27 01:54:28 +00:00
Dominik Schilling
1244eaff8f
Plugins: Fix order of arguments for the `strpos()` function added in [37562].
...
See #36706 .
Built from https://develop.svn.wordpress.org/trunk@37580
git-svn-id: http://core.svn.wordpress.org/trunk@37548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 23:15:31 +00:00
Boone Gorges
37c25c326f
Add tests for `get_weekstartend()`.
...
Props pbearne, tloureiro.
Fixes #36415 .
Built from https://develop.svn.wordpress.org/trunk@37579
git-svn-id: http://core.svn.wordpress.org/trunk@37547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 15:48:29 +00:00
Drew Jaynes
9feb4113a2
Docs: Remove unnecessary backtick-escaping around two function references in the DocBlock for `get_object_term_cache()`.
...
Known classes, methods, and functions are now auto-linked and formatted in the Code Reference. :-)
See [37573]. See #36814 .
Built from https://develop.svn.wordpress.org/trunk@37578
git-svn-id: http://core.svn.wordpress.org/trunk@37546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 15:22:27 +00:00
Drew Jaynes
e742a17240
Docs: Link up a reference to the `get_terms_args` filter in the hook doc for `get_terms_defaults`.
...
See #35381 . See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37577
git-svn-id: http://core.svn.wordpress.org/trunk@37545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 15:17:27 +00:00
Boone Gorges
d904eeb08a
Pass the proper values to `get_terms` action.
...
* `$term_query` should be passed.
* Second and third params should come from the `$term_query->query_vars` array, so that they're fully parsed.
These changes were missed in [37572].
Props flixos90, sebastian.pisula.
See #35381 .
Fixes #36951 .
Built from https://develop.svn.wordpress.org/trunk@37576
git-svn-id: http://core.svn.wordpress.org/trunk@37544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 14:56:29 +00:00
Dominik Schilling
607335ad6b
Version bump.
...
Built from https://develop.svn.wordpress.org/trunk@37575
git-svn-id: http://core.svn.wordpress.org/trunk@37543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 10:06:28 +00:00
Gary Pendergast
0db17129a5
Database: Add support for `SPATIAL` keys to `dbDelta()`.
...
`dbDelta()` already supported spatial fields (by virtue of not checking field types), so it's nice to round that out with spatial key support, too.
Fixes #36948 .
Built from https://develop.svn.wordpress.org/trunk@37574
git-svn-id: http://core.svn.wordpress.org/trunk@37542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 04:59:27 +00:00
Boone Gorges
253686fae6
Store only term IDs in object term relationships caches.
...
Previously, objects containing all data about a term were stored in each
object's term cache. Besides being wasteful, this approach caused invalidation
issues, as when a modified term count required a flush for all objects
belonging to the term.
Backward compatibility is maintained for plugins that continue to put object
data directly into the `{$taxonomy}_relationships` cache bucket.
Fixes #36814 .
Built from https://develop.svn.wordpress.org/trunk@37573
git-svn-id: http://core.svn.wordpress.org/trunk@37541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 04:50:27 +00:00
Boone Gorges
df0c758e22
Introduce `WP_Term_Query` and use in `get_terms()`.
...
`WP_Term_Query` is modeled on existing query classes, such as those used
for comments and users. It provides a more consistent structure for generating
term queries, and should make it easier to add new functionality in the future.
Props flixos90, boonebgorges.
See #35381 .
Built from https://develop.svn.wordpress.org/trunk@37572
git-svn-id: http://core.svn.wordpress.org/trunk@37540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-26 04:33:30 +00:00
Drew Jaynes
b9ed1cb665
Docs: Reorder argument descriptions in the DocBlock for `wp_list_categories()` to match the default arguments list and improve reading at a glance.
...
Props birgire for the initial patch.
Fixes #36693 .
Built from https://develop.svn.wordpress.org/trunk@37571
git-svn-id: http://core.svn.wordpress.org/trunk@37539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 19:40:27 +00:00
Dominik Schilling
da72b04ab2
Upgrade: Allow update checks on `upgrader_process_complete` to be run during Ajax requests.
...
Fixes missing translation updates during shiny updates.
Fixes #36914 .
Built from https://develop.svn.wordpress.org/trunk@37570
git-svn-id: http://core.svn.wordpress.org/trunk@37538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 19:36:28 +00:00
Drew Jaynes
6c34bf08a1
Docs: Add missing documentation for the `style` argument in the DocBlock for `wp_list_categories()`.
...
Props birgire for the initial patch.
See #36693 .
Built from https://develop.svn.wordpress.org/trunk@37569
git-svn-id: http://core.svn.wordpress.org/trunk@37537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 19:35:37 +00:00
Drew Jaynes
ecf5a924fe
Docs: Add missing `@access` tags to methods in `WP_oEmbed_Controller`.
...
See [34903].
Props ramiy.
Fixes #36297 .
Built from https://develop.svn.wordpress.org/trunk@37568
git-svn-id: http://core.svn.wordpress.org/trunk@37536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 19:22:27 +00:00
Boone Gorges
267cc99293
Fix termmeta pre-fetching in `wp_get_object_terms()`.
...
[34529] introduced logic intended to prime the termmeta cache for certain
values of the `fields` parameter. There were a few bugs:
* The `all_with_object_id` param was misspelled.
* `term_id` was used instead of `ids`.
* The values being passed to `update_termmeta_cache()` in the case where `fields=ids` was not correct.
All of these would result in a failure to pre-fetch termmeta in some cases.
Props dlh.
Fixes #36932 .
Built from https://develop.svn.wordpress.org/trunk@37567
git-svn-id: http://core.svn.wordpress.org/trunk@37535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 18:44:29 +00:00
Drew Jaynes
a74fae7bd6
Posts: Add test coverage for `get_preview_post_link()`.
...
Props swissspidy.
Fixes #35915 .
Built from https://develop.svn.wordpress.org/trunk@37566
git-svn-id: http://core.svn.wordpress.org/trunk@37534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 18:31:28 +00:00
Boone Gorges
20301c4f6f
In `get_bookmarks()`, don't cache if 'orderby=rand'.
...
Props lukecavanagh, prettyboymp, c3mdigital, MikeHansenMe.
Fixes #18356 .
Built from https://develop.svn.wordpress.org/trunk@37565
git-svn-id: http://core.svn.wordpress.org/trunk@37533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 18:29:28 +00:00
Drew Jaynes
e7e20e4b54
Docs: Update the return description for `get_preview_post_link()` to note that it can also return null.
...
Props chris_dev, swissspidy.
See #35915 .
Built from https://develop.svn.wordpress.org/trunk@37564
git-svn-id: http://core.svn.wordpress.org/trunk@37532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 18:25:28 +00:00
Boone Gorges
6c8bcef213
Add tests for `get_bookmarks()` cache.
...
This changeset adds a unit test factory so that bookmark/link fixtures can be
created during tests.
Why are we writing tests for functionality that has been deprecated for years?
Because it's the Right Thing to Do.
See #18356 .
Built from https://develop.svn.wordpress.org/trunk@37563
git-svn-id: http://core.svn.wordpress.org/trunk@37531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 18:21:30 +00:00
Dominik Schilling
6b51ac4956
Plugins: In `get_plugin_data()` use the plugin slug for the text domain when no text domain is defined in the header.
...
Fixes #36706 .
Built from https://develop.svn.wordpress.org/trunk@37562
git-svn-id: http://core.svn.wordpress.org/trunk@37530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 16:54:28 +00:00
Drew Jaynes
318f745808
Docs: Correct DocBlock descriptions for the `$before`, `$after`, `$link_before`, and `$link_after` arguments for `wp_nav_menu()`.
...
* `$before` falls before the link markup starts
* `$after` falls after the link markup ends
* `$link_before` falls before the link text
* `$link_after` falls after the link text
Props wp_smith for the initial patch.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37561
git-svn-id: http://core.svn.wordpress.org/trunk@37529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 16:17:27 +00:00
Drew Jaynes
bef05b469b
Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs.
...
See #36913 .
Built from https://develop.svn.wordpress.org/trunk@37560
git-svn-id: http://core.svn.wordpress.org/trunk@37528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 16:05:27 +00:00
Ella Iseulde Van Dorpe
cf51b75834
TinyMCE: fix inline toolbar positioning
...
Introduced in [37000].
See 2fb8aa48e9
.
See 5734a8d880
.
Fixes #36876 .
Built from https://develop.svn.wordpress.org/trunk@37559
git-svn-id: http://core.svn.wordpress.org/trunk@37527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 15:13:28 +00:00
Drew Jaynes
62d4798863
Docs: Update hook docs for the `upgrader_package_options` filter and `upgrader_process_complete` action to reflect expected values in the core, language pack, theme, and plugin contexts.
...
Props nextendweb for the initial patch.
See [37550]. Fixes #36875 .
Built from https://develop.svn.wordpress.org/trunk@37558
git-svn-id: http://core.svn.wordpress.org/trunk@37526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 14:45:27 +00:00
Ella Iseulde Van Dorpe
294f2c98f1
Media: adjust test after [37556]
...
See #36888 .
Built from https://develop.svn.wordpress.org/trunk@37557
git-svn-id: http://core.svn.wordpress.org/trunk@37525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 14:06:27 +00:00
Ella Iseulde Van Dorpe
2934f338cf
Media: unhide audio fallback
...
Introduced in [28182].
Fixes #36888 .
Built from https://develop.svn.wordpress.org/trunk@37556
git-svn-id: http://core.svn.wordpress.org/trunk@37524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 13:33:29 +00:00
Gary Pendergast
e8660d53a2
Tests: Upgrade the HHVM job to use Ubuntu Trusty, and a more recent version of HHVM.
...
Also includes some tidying up of the `.travis.yml` file.
Props netweb.
Fixes #36930 .
Built from https://develop.svn.wordpress.org/trunk@37555
git-svn-id: http://core.svn.wordpress.org/trunk@37523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 06:12:30 +00:00
Dominik Schilling
8369b778e1
I18N: Update list of continents and cities for the timezone selection.
...
Fixes #36828 .
Built from https://develop.svn.wordpress.org/trunk@37554
git-svn-id: http://core.svn.wordpress.org/trunk@37522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 23:24:27 +00:00
Dominik Schilling
76ade1b21d
Dashboard: Improve grammar for WordPress News help text.
...
Also, move planet URL to a separate string to match the URL which is used for the feed.
Props ramiy for initial patch.
Fixes #35681 .
Built from https://develop.svn.wordpress.org/trunk@37553
git-svn-id: http://core.svn.wordpress.org/trunk@37521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 21:22:28 +00:00
Dominik Schilling
d23b1534b8
I18N: Add translators comments to wp-activate.php.
...
Props ramiy.
Fixes #35734 .
Built from https://develop.svn.wordpress.org/trunk@37552
git-svn-id: http://core.svn.wordpress.org/trunk@37520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 21:02:28 +00:00
Dominik Schilling
2d1c27e8b4
I18N: Add translators comments to wp-signup.php.
...
Props ramiy.
Fixes #35730 .
Built from https://develop.svn.wordpress.org/trunk@37551
git-svn-id: http://core.svn.wordpress.org/trunk@37519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 20:44:29 +00:00
Drew Jaynes
ada2858cd9
Docs: Fix the hook doc for `upgrader_process_complete` to notate all values that might be present in the `hook_extra` array in the various update contexts.
...
h/t Nextendweb.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37550
git-svn-id: http://core.svn.wordpress.org/trunk@37518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 17:52:30 +00:00
Gary Pendergast
733ccfe08a
Embeds: Ensure embed widths are integers.
...
This prevents a warning in PHP trunk when a non-integer width is passed.
See #36435 .
Built from https://develop.svn.wordpress.org/trunk@37549
git-svn-id: http://core.svn.wordpress.org/trunk@37517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 06:15:28 +00:00
Gary Pendergast
2441b7b52f
Database: Don't generate unnecessary warnings in `wpdb::query()`.
...
In the event that the database has gone away for some reason, calls to `mysqli_errno()` and `mysqli_error()` (and their `ext/mysql` equivalents, of course), will generate PHP warnings, which are unsightly, and not how we do things in these parts.
Props mbijon, craig-ralston for the original patch.
Fixes #23085 .
Built from https://develop.svn.wordpress.org/trunk@37548
git-svn-id: http://core.svn.wordpress.org/trunk@37516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 05:24:26 +00:00
Jeremy Felt
6c405b8f36
Multisite: Clean up `WP_Error` documentation and handling in `wp-signup.php`
...
Fixes #36927 .
Built from https://develop.svn.wordpress.org/trunk@37547
git-svn-id: http://core.svn.wordpress.org/trunk@37515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 04:16:27 +00:00
Jeremy Felt
a021ab4ce0
Multisite: Disable autocapitalize and autocorrect for `user_name` input on signup
...
Props rafaelangeline.
Fixes #36833 .
Built from https://develop.svn.wordpress.org/trunk@37546
git-svn-id: http://core.svn.wordpress.org/trunk@37514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-24 03:43:27 +00:00
Drew Jaynes
6d7abb8fd3
Docs: The `$context` parameter in `remove_meta_box()` is not optional.
...
Fixes a copy pasta error introduced in [34952].
Props travisnorthcutt.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37545
git-svn-id: http://core.svn.wordpress.org/trunk@37513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 20:57:28 +00:00
Drew Jaynes
9193013158
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
Fixes #36921 .
Built from https://develop.svn.wordpress.org/trunk@37544
git-svn-id: http://core.svn.wordpress.org/trunk@37512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 19:02:28 +00:00
Drew Jaynes
d28f1a08ef
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37543
git-svn-id: http://core.svn.wordpress.org/trunk@37511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 19:01:27 +00:00
Drew Jaynes
da78aeffe9
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37542
git-svn-id: http://core.svn.wordpress.org/trunk@37510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 18:59:27 +00:00
Drew Jaynes
9549a46d7c
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks in wp-includes/general-template.php.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37541
git-svn-id: http://core.svn.wordpress.org/trunk@37509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 18:57:28 +00:00
Drew Jaynes
e0408b36ca
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks in wp-includes/ms-functions.php.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37540
git-svn-id: http://core.svn.wordpress.org/trunk@37508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 18:56:27 +00:00
Drew Jaynes
fb6d8bae49
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks for core classes.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37539
git-svn-id: http://core.svn.wordpress.org/trunk@37507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 18:54:27 +00:00
Dominik Schilling
a5b8dca864
Database: Support backticks around field names when parsing a query for the field type.
...
Avoids an undefined index PHP warning by `dbDelta()`.
Props davidmosterd, ocean90.
See #20263 .
Built from https://develop.svn.wordpress.org/trunk@37538
git-svn-id: http://core.svn.wordpress.org/trunk@37506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 18:12:28 +00:00
Drew Jaynes
1947f4d17c
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks for wp-admin/* files.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37537
git-svn-id: http://core.svn.wordpress.org/trunk@37505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 17:28:27 +00:00
Drew Jaynes
e52762a725
Docs: Apply inline `@see` tags to hooks referenced in DocBlocks for root directory files.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as hooks.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37536
git-svn-id: http://core.svn.wordpress.org/trunk@37504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 17:07:28 +00:00
Drew Jaynes
f82641ad0e
Docs: Standardize filter docs in root folder files to use third-person singular verbs per the inline documentation standards for PHP.
...
Fixes #36913 .
Built from https://develop.svn.wordpress.org/trunk@37535
git-svn-id: http://core.svn.wordpress.org/trunk@37503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 16:44:27 +00:00
Drew Jaynes
11d6f0712e
Docs: Update the return notation for `get_current_screen()` to note that `null` can also be returned if the screen has not been defined.
...
Props screamingdev.
Fixes #36382 .
Built from https://develop.svn.wordpress.org/trunk@37534
git-svn-id: http://core.svn.wordpress.org/trunk@37502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 16:34:28 +00:00