Commit Graph

20546 Commits

Author SHA1 Message Date
Ryan Boren 33fe750dce Don't assign wp_the_query to wp_query by reference. Removing the ref avoids accidentally stomping wp_the_query.
Props scribu, wpmuguru
fixes #22125


git-svn-id: http://core.svn.wordpress.org/trunk@22434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:03:28 +00:00
Andrew Nacin 039279db28 Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505.
git-svn-id: http://core.svn.wordpress.org/trunk@22433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:00:51 +00:00
Andrew Nacin 8d079808c5 Align the check column on the Updates screen. props ocean90. fixes #22339.
git-svn-id: http://core.svn.wordpress.org/trunk@22432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:57:55 +00:00
Andrew Nacin 30d048a1e7 Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate.
props markjaquith, SergeyBiryukov. fixes #21841.



git-svn-id: http://core.svn.wordpress.org/trunk@22431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:56:10 +00:00
Andrew Nacin dc40f18228 Merge some strings. props pavelevap. fixes #22306.
git-svn-id: http://core.svn.wordpress.org/trunk@22430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:37:54 +00:00
Andrew Nacin e588812a49 Enforce a minimum of two arguments for wpdb::prepare(). The first argument is the query (or fragment thereof), which is required. Additional arguments are values to substitute into placeholders.
This will generate E_WARNINGs for insufficient arguments when prepare() is called with no additional arguments. This should discourage improper uses of prepare() under the guise of safely running a query.

props xknown. fixes #22262.



git-svn-id: http://core.svn.wordpress.org/trunk@22429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:30:59 +00:00
Andrew Nacin 3a86c87c31 Remove single-argument calls to wpdb:prepare(), which are invalid as nothing is being prepared. see #22262.
git-svn-id: http://core.svn.wordpress.org/trunk@22428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:28:08 +00:00
Andrew Nacin 2aa561013b Extend Press This by a few pixels to allow longer strings. props SergeyBiryukov. fixes #20975.
git-svn-id: http://core.svn.wordpress.org/trunk@22427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:27:19 +00:00
Andrew Nacin 5e4cb3af70 Display links if no link categories exist. props MikeHansenMe. fixes #22216.
git-svn-id: http://core.svn.wordpress.org/trunk@22426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:25:18 +00:00
Mark Jaquith 2ec9c4acc2 Use ImageOptim to losslessly smush our images. About half a MB in savings! fixes #22381. props waldojaquith
git-svn-id: http://core.svn.wordpress.org/trunk@22425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:49:10 +00:00
Andrew Nacin 0816e433b2 Larger buttons for the DB upgrade screens. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@22424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:38:17 +00:00
Andrew Nacin 69d63c243d Fix the 'Change' button in the users list table. props c3mdigital. fixes #22034.
git-svn-id: http://core.svn.wordpress.org/trunk@22423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:34:46 +00:00
Andrew Nacin a5c0829f35 Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697.
git-svn-id: http://core.svn.wordpress.org/trunk@22422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:01:31 +00:00
Ryan Boren 15f0f2524e Call Imagick::queryformats() non-statically to preserve back compat with older versions of Imagick.
Props mpvanwinkle77
fixes #22308
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:50:38 +00:00
Andrew Nacin 03794fddb3 Properly return new WP_Error objects. props bpetty. see #6812.
git-svn-id: http://core.svn.wordpress.org/trunk@22420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:49:00 +00:00
Ryan Boren 0794b91606 Use retina logo in install, upgrade, setup-config, repair, and confirmation screens.
Props kopepasah, SergeyBiryukov
fixes #22375


git-svn-id: http://core.svn.wordpress.org/trunk@22419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:34:22 +00:00
Ryan Boren fac33f51fa When using WP_User::set_role() to set the role, don't unset all caps when the requested role matches the current role.
Props scribu, jammitch
fixes #18932


git-svn-id: http://core.svn.wordpress.org/trunk@22418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:16:37 +00:00
Andrew Nacin 711f6f2619 Treat a single taxonomy passed as an array the same as when passed as a string in get_terms(). props wonderboymusic, fixes #17955.
git-svn-id: http://core.svn.wordpress.org/trunk@22417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 09:03:40 +00:00
Andrew Nacin 17a387ccb8 Use correct variable name in code comment. props SergeyBiryukov, fixes #21962.
git-svn-id: http://core.svn.wordpress.org/trunk@22416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 08:57:49 +00:00
Daryl Koopersmith 9329d742cb Use Mustache-insipired template tags.
Underscore's default ERB-style templates are incompatible with PHP when asp_tags is enabled. As a result, we've settled on an alternative syntax that should be familiar to devs: Mustache-inspired for interpolating and escaping content, and ERB-inspired for execution.

	`{{{a}}}` - interpolating
	`{{ a }}` - escaping
	`<# a #>` - execution

props rmccue. fixes #22344, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 08:41:17 +00:00
Andrew Nacin dd50d7d0e0 restrict_manage_users action. props jakemgold, johnjamesjacoby. fixes #19295.
git-svn-id: http://core.svn.wordpress.org/trunk@22414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 07:59:46 +00:00
Andrew Nacin 10b381a047 Revert type="email" on the registration form to avoid validation issues. see #22183.
git-svn-id: http://core.svn.wordpress.org/trunk@22413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 07:47:52 +00:00
Andrew Nacin 3a8a6471e3 Check for WP_Error in get_the_category(). props batmoo. fixes #21155.
git-svn-id: http://core.svn.wordpress.org/trunk@22412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:47:14 +00:00
Andrew Ozz c09c079a6f Allow commonly used obsolete HTML5 attributes in TinyMCE, table[summary|width|border|frame|rules|cellspacing|cellpadding|align|bgcolor] and a[name], fixes #22175
git-svn-id: http://core.svn.wordpress.org/trunk@22411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:36:10 +00:00
Andrew Nacin 28777ee3c4 Always return an integer from post_exists(). props barrykooij. fixes #21607.
git-svn-id: http://core.svn.wordpress.org/trunk@22410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:27:21 +00:00
Andrew Nacin 224a21db80 Stop adding title attributes to images (in the old media uploader). props martythornley. fixes #18984.
git-svn-id: http://core.svn.wordpress.org/trunk@22409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:23:03 +00:00
Andrew Nacin 0b60d08879 Proper default background color for Twenty Eleven. props miqrogroove. fixes #22347.
git-svn-id: http://core.svn.wordpress.org/trunk@22408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:14:00 +00:00
Bot (Assets) aa464fde32 Compress scripts/styles: 3.5-beta2-22407.
git-svn-id: http://core.svn.wordpress.org/trunk@22407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:58:35 +00:00
Andrew Nacin 9e2d46819e Revert [22387]. see #14466. see #22374.
git-svn-id: http://core.svn.wordpress.org/trunk@22406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:36:24 +00:00
Andrew Nacin 1a3e4a1207 Don't show a hand cursor when hovering over a disabled button. props sabreuse, fixes #22371.
git-svn-id: http://core.svn.wordpress.org/trunk@22405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:30:41 +00:00
Andrew Nacin cd47e0519e Use inline-block for wrapping filter links. props ocean90, SergeyBiryukov. fixes #21985.
git-svn-id: http://core.svn.wordpress.org/trunk@22404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:29:48 +00:00
Ryan Boren 8bb0fc5079 Revert [22365]. see #21167
git-svn-id: http://core.svn.wordpress.org/trunk@22403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 19:45:51 +00:00
Jon Cave 1049edd0bc Rename filter on $args sent to export_wp() for clarity. See #19863.
git-svn-id: http://core.svn.wordpress.org/trunk@22402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 14:51:45 +00:00
Jon Cave df39c7be71 Update shortcode regular expression commentary. See #17657.
git-svn-id: http://core.svn.wordpress.org/trunk@22401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 14:47:33 +00:00
Andrew Nacin abe7ee8ec8 Keyboard accessibility for the theme customizer. props lessbloat, jorbin, JustinSainton. fixes #21283.
git-svn-id: http://core.svn.wordpress.org/trunk@22400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 14:47:25 +00:00
Jon Cave ae96b842f9 Correctly associate new menu items with a menu when using wp_update_nav_menu_item()
wp_update_nav_menu_item() must pass tax_input to wp_insert_post() when creating items
otherwise the menu-item relationship isn't made.

See #22189.


git-svn-id: http://core.svn.wordpress.org/trunk@22399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 14:46:56 +00:00
Jon Cave 86d88f8b2d Actually pass old permalink structure with permalink_structure_changed action
Props doublesharp. Fixes #22351.


git-svn-id: http://core.svn.wordpress.org/trunk@22398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 12:41:33 +00:00
Daryl Koopersmith 349afb3c4f Media JS: Move state-related logic from sidebar views to the state controllers. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:19:39 +00:00
Andrew Ozz cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Andrew Nacin c2257fcba3 Remove methods that override but do nothing. props jeremyfelt for initial patch. fixes #22368.
git-svn-id: http://core.svn.wordpress.org/trunk@22395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:52:49 +00:00
Andrew Ozz 50c704fc80 Remove the Alt + Shift + G (old fullscreen mode) shortcut from the TinyMCE help popup, props SergeyBiryukov, see #21197
git-svn-id: http://core.svn.wordpress.org/trunk@22394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:28:01 +00:00
Andrew Nacin 9fadd65859 HiDPI versions of the generic menu page icon. props empireoflight, lessbloat. see #21019.
git-svn-id: http://core.svn.wordpress.org/trunk@22393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:25:18 +00:00
Andrew Nacin c9c8c0d214 Add the export_filters and wp_export_args hooks. props MartyThornley, brandondove. fixes #19863.
git-svn-id: http://core.svn.wordpress.org/trunk@22392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:06:44 +00:00
Andrew Nacin 80405f9935 For postboxes, only show arrows/handles on hover when JS is enabled. props TobiasBg. fixes #21611.
git-svn-id: http://core.svn.wordpress.org/trunk@22391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:05:47 +00:00
Andrew Ozz e58fb0852b Fix the right border of the editor textarea, props SergeyBiryukov, fixes #21906
git-svn-id: http://core.svn.wordpress.org/trunk@22390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:55:10 +00:00
Andrew Ozz f26bbc0dd7 Fix border at the bottom of active tabs in postboxes, fixes #17699
git-svn-id: http://core.svn.wordpress.org/trunk@22389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:38:16 +00:00
Ryan Boren 1bd2ae0538 Update contextual help for 'Search Engine Visibility' to reflect UI changes. Props DrewAPicture. see #16416
git-svn-id: http://core.svn.wordpress.org/trunk@22388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:17:28 +00:00
Andrew Nacin bc93c0fdc5 Prefix sidebar IDs on the widgets screen with "sidebar-". props batmoo. fixes #14466.
git-svn-id: http://core.svn.wordpress.org/trunk@22387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:17:25 +00:00
Andrew Nacin c04587d409 Add a $public_only argument to count_many_users_posts() and get_posts_by_author_sql(). Defaults to false, and allows the counts to be returned for only public posts. props ryan, westi. fixes #21431.
git-svn-id: http://core.svn.wordpress.org/trunk@22386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:11:25 +00:00
Ryan Boren 1fc0104667 Restore keyboard accessibility to the color picker. Props lessbloat. see #21206
git-svn-id: http://core.svn.wordpress.org/trunk@22385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:00:15 +00:00