WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
38,076 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

16999 Commits

Author SHA1 Message Date
Sergey Biryukov eba98dc78d Make the string `WordPress` translatable. 
Props mnelson4.
Merges [42999] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43114


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:55:24 +00:00
Sergey Biryukov 0896655aea Privacy: make the sections in the suggested privacy policy text postbox foldable. Add Read More/Read Less buttons. Fix copying of the suggested text by pressing the button. 
Props melchoyce, xkon, azaozz.
Merges [42992] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43113


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:54:24 +00:00
Sergey Biryukov 7aab5bc693 Fix typo in 'wp_get_default_privacy_policy_content' filter. 
Props claudiu.
Merges [42985] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43112


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:52:26 +00:00
Sergey Biryukov c60aa91d76 Privacy: Limit export and erasure to super admins on Multisite. 
Multisite networks have a variety of use cases, and in many of them single-site administrators are not trusted to take actions that affect the whole network, require making decisions about legal compliance, etc. By default, those actions should require super admin capabilities. Plugins can be used to override that behavior if a particular site's use case calls for it.

Props allendav, jeremyfelt, iandunn.
Merges [43085] to the 4.9 branch.
Fixes #43919.
Built from https://develop.svn.wordpress.org/branches/4.9@43111


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:49:26 +00:00
Sergey Biryukov a6284311e8 Privacy: improve `wp_privacy_erase_personal_data()`, return boolean values. 
Props ericdaams.
Merges [43061] to the 4.9 branch.
See #43602.
Built from https://develop.svn.wordpress.org/branches/4.9@43110


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:44:24 +00:00
Sergey Biryukov 8114ac92ef Privacy: add attachments to the personal data export file. 
Props allendav.
Merges [43054] to the 4.9 branch.
See #43883.
Built from https://develop.svn.wordpress.org/branches/4.9@43108


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:34:25 +00:00
Sergey Biryukov 2083557ea9 I18N: Use consistent pattern for placeholder references in translator comments in `wp_ajax_wp_privacy_erase_personal_data()`. 
Merges [43088] to the 4.9 branch.
See #43438.
Built from https://develop.svn.wordpress.org/branches/4.9@43107


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:24:25 +00:00
Sergey Biryukov fdb8a97664 Docs: Correct DocBlock formatting for `wp_privacy_personal_data_erasers` filter. 
Merges [43104] to the 4.9 branch.
See #43637.
Built from https://develop.svn.wordpress.org/branches/4.9@43106


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:20:25 +00:00
Sergey Biryukov 050ea51bcb Privacy: translate error messages, some fixes and improvements for the AJAX actions for exporting and erasing user data. 
Props desrosj, birgire.
Merges [43060] to the 4.9 branch.
See #43438.
Built from https://develop.svn.wordpress.org/branches/4.9@43105


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:19:26 +00:00
Sergey Biryukov 38e4408131 Privacy: fix and improve the help text about adding a privacy policy page. 
Props idea15, xkon.
Merges [43053] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43103


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 03:02:25 +00:00
Sergey Biryukov c7ac8db6e4 Privacy: add a postbox that is shown when editing the privacy policy page, and where plugins and core will output suggested content and additional privacy info. First run. 
Props melchoyce, azaozz.
Merges [42980] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43101


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:59:25 +00:00
Sergey Biryukov 6703bb7c72 Privacy: improve the screen for setting a privacy policy page. 
Props melchoyce, xkon, azaozz.
Merges [42978] and [43091] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43100


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:50:26 +00:00
Sergey Biryukov 1b0bd1ff7a Accessibility improvements for the Privacy Tools screen. 
Props afercia.
Merges [42823] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43099


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:48:26 +00:00
Sergey Biryukov 9af2f7cd35 Add Privacy Tools admin page under the Tools menu. 
Props allendav, xkon, azaozz.
Merges [42814] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43098


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:46:25 +00:00
Sergey Biryukov 894cec5697 Privacy: Add `wp_privacy_personal_data_export_file_created` filter. 
This runs immediately after the data export file has been successfully created, allowing plugins to introduce some workflow customizations. For example, a plugin could password-protect the export file, for peace of mind, even though the CSPRN in the filename makes brute force attacks nearly impossible.

Props iandunn.
Merges [43047] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43096


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:35:27 +00:00
Sergey Biryukov 06dd3449e9 Privacy: Add cron to delete expired export files to protect privacy. 
The primary means of protecting the files is the CSPRN appended to the filename, but there is no reason to keep the files after the data subject has downloaded them, so deleting them provides an additional layer of protection. Previously this was done from `wp_privacy_generate_personal_data_export_file()`, but that does not guarantee that it will be run regularly, and on smaller sites that could result in export files being exposed for much longer than necessary.

`wp_privacy_delete_old_export_files()` was moved to a front end file, so that it can be called from `cron.php`.

This introduces the `wp_privacy_export_expiration` filter, which allows plugins to customize how long the exports are kept before being deleted.

`index.html` was added to the `$exclusions` parameter of `list_files()` to make sure that it isn't deleted. If it were, then poorly-configured servers would allow the directory to be traversed, exposing all of the exported files.

Props iandunn, desrosj.
Merges [43046] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43095


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:33:26 +00:00
Sergey Biryukov 7a7e45a530 Privacy: Use a CSPRNG in export filenames for more security. 
`rand()` is deterministic and therefore offers much less protection in this context. `wp_generate_password()` is a convenient wrapper around `wp_rand()`, which uses `random_int()` to generate cryptographically-secure psuedorandom numbers.

Props iandunn.
Merges [43045] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43094


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:19:25 +00:00
Sergey Biryukov e5c53b9bbd Privacy: add means to export personal data by username or email address. Generate a zipped export file containing all data. First run. 
Props allendav.
Merges [43012] and [43089] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43092


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 02:16:25 +00:00
Sergey Biryukov d4be2db521 Privacy: make the emails in export and erasure list-tables clickable. 
Props birgire.
Merges [43057] to the 4.9 branch.
See #43911.
Built from https://develop.svn.wordpress.org/branches/4.9@43086


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 01:08:25 +00:00
Sergey Biryukov 14d25f6094 Privacy: update and enhance the method to confirm user requests by email. Introduce WP_User_Request to hold all request vars similarly to WP_Post. 
Props mikejolley, desrosj.
Merges [43011] and [43014] to the 4.9 branch.
See #43443.
Built from https://develop.svn.wordpress.org/branches/4.9@43084


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 01:04:26 +00:00
Sergey Biryukov e5b5b15b88 Privacy: update the method to confirm user requests by email. Use a single CPT to store the requests and to allow logging/audit trail. 
Props mikejolley.
Merges [43008] to the 4.9 branch.
See #43443.
Built from https://develop.svn.wordpress.org/branches/4.9@43083


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 01:01:25 +00:00
Sergey Biryukov b433465f15 Privacy: add helper function for anonymizing data in a standardized way. 
Props jesperher, allendav, iandunn, birgire, azaozz, joemcgill.
Merges [42971] and [43081] to the 4.9 branch.
Fixes #43545.
Built from https://develop.svn.wordpress.org/branches/4.9@43082


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 00:49:26 +00:00
Sergey Biryukov bcb3a839d1 Privacy: add functionality to anonymize commenters. 
Props xkon, fclaussen, allendav, birgire, azaozz.
Merges [42994] to the 4.9 branch.
See #43442.
Built from https://develop.svn.wordpress.org/branches/4.9@43080


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 00:21:25 +00:00
Sergey Biryukov 59593950dc Privacy: Fix JSHint errors. 
Introduced in [42986].

Props jorbin.
Merges [42989] to the 4.9 branch.
See #43440.
Built from https://develop.svn.wordpress.org/branches/4.9@43078


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 00:15:25 +00:00
Sergey Biryukov 82687eb7af Privacy: add means to erase personal data by username or email address. First run. 
Props allendav, coreymckrill, ericdaams, azaozz.
Merges [42986] to the 4.9 branch.
See #43637, #43602.
Built from https://develop.svn.wordpress.org/branches/4.9@43075


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-02 00:03:27 +00:00
Sergey Biryukov 309984de5f Privacy: add support for exporting multiple pages of personal data. 
Props allendav.
Merges [42889] to the 4.9 branch.
See #43438.
Built from https://develop.svn.wordpress.org/branches/4.9@43074


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 23:58:25 +00:00
Sergey Biryukov b1c0bffa78 Privacy: fix error message and list table sorting errors on the Export Personal Data and Remove Personal Data screens. 
Props azaozz.
Merges [42977] to the 4.9 branch.
See #43481.
Built from https://develop.svn.wordpress.org/branches/4.9@43073


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 23:49:26 +00:00
Sergey Biryukov 88bc6a609e Privacy: add new wp-admin screens for exporting and removing of personal data. 
Props melchoyce, mikejolley, allendav, xkon.
Merges [42967] to the 4.9 branch.
See #43481.
Built from https://develop.svn.wordpress.org/branches/4.9@43071


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 23:42:25 +00:00
Sergey Biryukov ee43146223 Privacy: add "Mine" filter for media similarly to posts and comments. 
Props audrasjb.
Merged [43056], [43062], [43063] to the 4.9 branch.
Fixes #43820.
Built from https://develop.svn.wordpress.org/branches/4.9@43064


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 22:04:28 +00:00
Sergey Biryukov 3408441e15 Help/About: Move "Get involved" link on Credits screen to the top of the page for better visibility. 
Props bridgetwillard, desrosj.
Merges [43032] to the 4.9 branch.
See #23348.
Built from https://develop.svn.wordpress.org/branches/4.9@43033


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 03:19:24 +00:00
Sergey Biryukov e40df25f76 Plugins: Show the required PHP version in the plugin details view, if specified. 
Props xkon.
Merges [42998] to the 4.9 branch.
Fixes #43650.
Built from https://develop.svn.wordpress.org/branches/4.9@43029


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-29 22:51:25 +00:00
Aaron Campbell 65a757621d Bump 4.9 branch to version 4.9.5 
Built from https://develop.svn.wordpress.org/branches/4.9@42933


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-03 20:17:40 +00:00
Gary Pendergast bac5694e88 Dashboard: Remove the "Try Gutenberg" callout. 
As eager as we all are to see Gutenberg put before a wider audience, there are still a handful of issues that need to be fixed, which won't be done before the 4.9.5 release.

Reverts [42869].
See #41316.


Built from https://develop.svn.wordpress.org/branches/4.9@42883


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-28 00:18:43 +00:00
Adam Silverstein 4650753c6b Media: Fix image cropping on touch screen devices. 
* In initCrop, handle touch events in addition to mouse events.
* In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.

Props yahil, alexgso, joemcgill.
Merges [42818] to the 4.9 branch.
Fixes #41242.


Built from https://develop.svn.wordpress.org/branches/4.9@42874


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-24 20:26:42 +00:00
Gary Pendergast 61be857c95 Dashboard: Introduce a "Try Gutenberg" callout. 
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.

Props pento, melchoyce, joen, karmatosed, joemcgill, SergeyBiryukov, jorbin.

Fixes #41316.


Built from https://develop.svn.wordpress.org/branches/4.9@42869


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-22 00:59:44 +00:00
Sergey Biryukov 9d75986391 Media: On Media Settings screen, make the pairs of labels and inputs always stacked vertically, on both mobile and desktop screens. 
Make `<br />` tags on the screen behave as line breaks again after [41836]. Add a missing fieldset + legend for better accessibility.

Props afercia, RavanH, obenland, garrett-eclipse.
Merges [42864] to the 4.9 branch.
Fixes #42724. See #34539.
Built from https://develop.svn.wordpress.org/branches/4.9@42865


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-20 22:49:39 +00:00
Dominik Schilling baba344254 Customizer menus: correct oversized viewport after dragging menu items. 
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.

Merge of [42817] to the 4.9 branch.

Props adamsilverstein, kwonye.
Fixes #36884.
Built from https://develop.svn.wordpress.org/branches/4.9@42850


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-18 16:49:41 +00:00
Dominik Schilling a3528374a8 Customizer: In menus, reset results when closing the 'add items' panel. 
Trigger a keyup event when clearing the search field in response to closing the add item panel. The keyup event triggers a search and resets the results. Previously, the search field was cleared while the potentially blank search results were left in place making it impossible to select new menu items.

Merge of [42744] to the 4.9 branch.

Props Blair jersyer, aranwer104, afercia.
See #43333.
Built from https://develop.svn.wordpress.org/branches/4.9@42846


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-18 15:10:42 +00:00
John Blackbourn 9b7814a4a1 Security: Loosen the admin referrer policy header value to allow the referring host to be sent from the admin area in all cases. 
This allows referrer-restricted content from third parties (such as images and fonts) to continue working in the admin area.

Props aranwer104, qcmiao

Fixes #43285

Merges [42830] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42831


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-12 10:59:39 +00:00
Mike Schroder 7546fcc64a Media: Correctly allow changing PDF thumbnail crop value. 
Corrects logic that kept plugins from setting crop value of intermediate image sizes for rendered PDFs.
Adds test.

Props leemon, SergeyBiryukov, chetan200891, birgire.
Merges [42792] to the 4.9 branch.
Fixes #43226.

Built from https://develop.svn.wordpress.org/branches/4.9@42813


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-09 03:21:40 +00:00
Sergey Biryukov a91c3fbdc0 General: Replace `Cheatin’ uh?` with friendlier error messages. 
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.

Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce, kristastevens for language; dmsnell for original patch; peterwilsoncc.
Merged [42648] and [42719] to the 4.9 branch.
Fixes #38332.
Built from https://develop.svn.wordpress.org/branches/4.9@42811


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-09 00:15:42 +00:00
Sergey Biryukov e0f0ee5de6 Users: Display partial names in the user listing tables. 
This allows showing a name when only the first or last name is provided.

Props shital-patel, antipole.
Merges [42256] and [42257] to the 4.9 branch.
Fixes #42713.
Built from https://develop.svn.wordpress.org/branches/4.9@42805


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-08 19:48:39 +00:00
Sergey Biryukov 7f190a310c Customize: Correct closing tags in `customize_themes_print_templates()`. 
Props johnpgreen, nandorsky.
Merges [42711] to the 4.9 branch.
Fixes #43307.
Built from https://develop.svn.wordpress.org/branches/4.9@42803


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-08 19:42:39 +00:00
Sergey Biryukov d8da981665 Build/Test Tools: Update prefixed CSS properties in `about.css`. 
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.

Props netweb, afercia.
Merges [42687] to the 4.9 branch.
Fixes #43190.
Built from https://develop.svn.wordpress.org/branches/4.9@42802


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-08 19:41:44 +00:00
Dion Hulse dd84717899 Bump the 4.9 branch to version 4.9.4. 
Built from https://develop.svn.wordpress.org/branches/4.9@42656


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-06 15:42:43 +00:00
Sergey Biryukov 2643287b2c Bump the 4.9 branch to version 4.9.3. 
Built from https://develop.svn.wordpress.org/branches/4.9@42650


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-05 20:05:41 +00:00
Sergey Biryukov dc9c4c4738 Customize: Ensure heartbeat keeps changeset locked when in branching mode. 
Props dlh.
See #42024.
Merges [42612] to the 4.9 branch.
Fixes #42658.
Built from https://develop.svn.wordpress.org/branches/4.9@42623


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-30 15:24:41 +00:00
Sergey Biryukov 3798ce6757 Role/Capability: Make `install_languages` capability check less restrictive. 
A user should still be able to have the capability, even when language packs cannot be automatically installed. The automatic installation part is separate from that now.

Props flixos90.
Merges [42606] to the 4.9 branch.
Fixes #42697.
Built from https://develop.svn.wordpress.org/branches/4.9@42607


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-24 22:59:38 +00:00
Sergey Biryukov 2c492ab774 Upgrade/Install: In `postMessage` events handler, check for `message` object existence before checking its `action` property. 
Props manikmist09.
Merges [42604] to the 4.9 branch.
Fixes #43005.
Built from https://develop.svn.wordpress.org/branches/4.9@42605


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-24 22:32:38 +00:00
Andrew Ozz bd00d61353 Merged revision 42574 from trunk: 
Editor: when keeping the scroll position treat all shortcodes as preview-able. Otherwise in some cases the marker span can get stuck inside the shortcode and break the markup.

Props azaozz, lizkarkoski and othellobloke for testing.
Fixes #42908 for 4.9.3.

Built from https://develop.svn.wordpress.org/branches/4.9@42575


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-23 17:48:41 +00:00
Sergey Biryukov 124bdbb0cd Media: Restore white background of the content area in media modal. 
Props afercia, chetan200891.
Merges [42572] to the 4.9 branch.
Fixes #43088.
Built from https://develop.svn.wordpress.org/branches/4.9@42573


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-23 14:03:42 +00:00
Weston Ruter db02fcb8f8 Customize: Let default status for Customizer be `draft` if user does not have capability to `publish`. 
Amends [41626].
Props sayedwp, westonruter.
See #30937.
Fixes #42686 for 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42544


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-22 19:12:43 +00:00
Weston Ruter 3ed6b9efd4 Customize: Prevent showing SFTP theme installation notification in multisite when user cannot install themes. 
Props flixos90.
See #37661, #42184.
Fixes #42674 for 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42537


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-22 06:16:41 +00:00
Weston Ruter 2441c3c3f1 Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed. 
Amends [38810].
Props dlh.
Fixes #42497 for 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42535


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-22 05:23:40 +00:00
Sergey Biryukov d9bf3e5e60 Plugins: Update review filter links in Details modal. 
Props darko-a7, afercia.
Merges [42459] to the 4.9 branch.
Fixes #43016. See #meta3379.
Built from https://develop.svn.wordpress.org/branches/4.9@42524


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-17 07:02:41 +00:00
Weston Ruter 4c4d1ecbe5 Widgets: Prevent `checkValidity` from running on a form when widget is first adding to sidebar. 
Amends [41352].
See #23120.
Fixes #43003 for 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42522


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-17 01:31:41 +00:00
Dion Hulse 4abf1b12c9 Bump the 4.9 branch to version 4.9.2. 
Built from https://develop.svn.wordpress.org/branches/4.9@42494


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 21:37:40 +00:00
Sergey Biryukov 5e9186aaa5 Plugins: Fix the plugin details modal "Close" button after [42443]. 
Props rinkuyadav999.
Merges [42491] to the 4.9 branch.
Fixes #43082.
Built from https://develop.svn.wordpress.org/branches/4.9@42493


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 20:58:43 +00:00
Dion Hulse e77f8257ea External Libraries: Remove unnecessary / obsoleted MediaElement.js files. 
Props joemcgill.
Merges [42462] to the 4.9 branch.
Fixes #42720 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42465


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 06:41:51 +00:00
Sergey Biryukov 3bc41df4e4 Widgets: When checking for errors in Custom HTML widget, pass correct value to `toggleClass()` for Save button. 
`toggleClass()` expects a boolean as a second argument, not an integer.

Props iCaleb.
Merges 42457 to the 4.9 branch.
Fixes #42867.
Built from https://develop.svn.wordpress.org/branches/4.9@42458


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 23:51:38 +00:00
Sergey Biryukov d72fbf753f Plugins: Fix the plugin details modal in the install plugin search tab after [41356]. 
Props afercia.
Merges [42443] to the 4.9 branch.
Fixes #43082.
Built from https://develop.svn.wordpress.org/branches/4.9@42456


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 23:07:41 +00:00
Sergey Biryukov 9026b41b3b Media: Bring consistency to `getimagesize()` error suppression. 
Props chasewg, joemcgill, jeremyfelt.
Merges [42449] to the 4.9 branch.
Fixes #42480.
Built from https://develop.svn.wordpress.org/branches/4.9@42450


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 20:02:39 +00:00
Sergey Biryukov 77ce550e5c Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer. 
Props chetan200891 for initial patch.
Merges [42447] to the 4.9 branch.
Fixes #42871.
Built from https://develop.svn.wordpress.org/branches/4.9@42448


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 19:30:40 +00:00
Andrew Ozz 397b2de6e5 Merged revision 42430 from trunk: 
Editor: ensure there is a selection before getting the caret position. Fixes a bug in Firefox when there is no selection for a hidden element.

Props johnschulz, azaozz.

Fixes #43012 for 4.9.2.

Built from https://develop.svn.wordpress.org/branches/4.9@42442


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-13 11:28:43 +00:00
Sergey Biryukov 25dea6d03a Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px. 
Props obenland.
Amends [41817].
Merges [42152] to the 4.9 branch.
See #42157.
Fixes #42492.
Built from https://develop.svn.wordpress.org/branches/4.9@42436


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-12 19:26:41 +00:00
Dion Hulse 5973b3a5e1 Upgrade: When deleting old files, if deletion fails attempt to empty the file instead. 
Props joemcgill, dd32.
Merges [42433] to the 4.9 branch.
Fixes #42963 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42434


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-10 06:11:39 +00:00
John Blackbourn c4a15959f5 Bump 4.9 branch to version 4.9.1. 
Built from https://develop.svn.wordpress.org/branches/4.9@42316


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-29 18:55:42 +00:00
John Blackbourn ecd15e008a Hardening: Use a properly generated hash for the `newbloguser` key instead of a determinate substring. 
Merges [42258] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42264


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-29 16:08:41 +00:00
Dion Hulse 0236fd226e Theme Editor: Translate the URL to the Child Themes Codex page. 
Props odysseygate, johnpgreen.
Merges [42247] to the 4.9 branch.
Fixes #42454.

Built from https://develop.svn.wordpress.org/branches/4.9@42248


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 03:53:40 +00:00
Dion Hulse 9fe3e9edf0 Theme Editor: Validate files are editable based on their relative filenames, rather than full file path. 
This fixes theme editing on Windows platforms where `validate_file()` will return `2` on a full file path.

Merges [42244] to the 4.9 branch.
Fixes #42609.

Built from https://develop.svn.wordpress.org/branches/4.9@42245


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 03:29:25 +00:00
Dion Hulse e1095eeb9f Theme/Plugin Editor: Remove the caching added in [41806] as it causes more problems than it fixes. 
While caching here seemed like a good idea in theory, in practice the cache would be often stale causing development issues.
We exclude common folders (such as `node_modules`) from the scanning to avoid directories which are not useful to the end-user, so as long as those exclusion lists are held up this shouldn't cause too much of a degredation in the future.
We may consider adding caching here again in the future if it's determined that it is really needed.

Props precies, ibenic, mariovalney, schlessera, and all the others who commented on the ticket(s).
This partually reverts [41806].
Merges [42242] to the 4.9 branch.
See #6531.
Fixes #42573 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42243


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 03:00:38 +00:00
Dion Hulse 6dc1dd28f5 Themes: Prevent JS error on Themes admin screen when only one theme is installed. 
Amends [42029].
Props chetan200891, afercia.
See #42348, westonruter.
Merges [42222] to the 4.9 branch.
Fixes #42673.

Built from https://develop.svn.wordpress.org/branches/4.9@42223


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-24 02:56:42 +00:00
John Blackbourn 97ba6be232 Docs: Correct the `@since` property for the `page_attributes_misc_attributes` action. 
Props jeremyescott, jfarthing84

Fixes #42607

Merges [42203] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42219


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-23 18:03:43 +00:00
Dion Hulse cee7720939 Upgrade: Fix updating plugins which include a numeric file/folder names. 
The fix in [41821] caused numeric folder names to be reindexed to 0..n when in the root directory (for example, `my-plugin/24/`).

Props edo888.
See #41524.
Merges [42214] to the 4.9 branch.
Fixes #42628 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42215


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-21 04:16:41 +00:00
Dion Hulse b09cebf575 Rewrite Rules: Correct the logic in `extract_from_markers()` after [41928]. 
Props stodorovic, SergeyBiryukov.
Merges [42199] to the 4.9 branch.
Fixes #42579. See #39920.

Built from https://develop.svn.wordpress.org/branches/4.9@42213


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-21 03:47:38 +00:00
Dion Hulse 66a3d52431 Multisite: Fix broken update `blog_versions` query after [41661]. 
Props Mista-Flo, lenasterg, flixos90.
Merges [42210] to the 4.9 branch.
Fixes #42641.

Built from https://develop.svn.wordpress.org/branches/4.9@42212


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-21 03:43:40 +00:00
Weston Ruter a5f8e0917f Editor: Disable `wp_keep_scroll_position` in IE11 since buggy; fix `matches` polyfill conflict with ME.js by doing runtime feature detection in context window. 
Props westonruter, SergeyBiryukov, Clorith for testing.
See #41962, #42029.
Fixes #42553 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42192


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 19:00:38 +00:00
Weston Ruter 73615e0bc4 File Editor: Eliminate gap inserted between code editor and heading in IE11 when CodeMirror initializes. 
Props afercia, melchoyce, Clorith for testing, SergeyBiryukov for testing.
See #12423.
Fixes #42554 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42190


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 18:31:37 +00:00
Weston Ruter 567de560e9 Customize: Prevent themes panel from auto-expanding in IE11. 
In IE11 the `input` event erroneously gets triggered initially without any user input.

Amends [41648].
See #37661.
Fixes #42556 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42188


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 18:13:40 +00:00
Weston Ruter ecf8680978 Editor: Improve scrolling behavior and prevent autosave logic from causing dirty state when just switching between Visual and Text tabs. 
Props pento.
See #41962, #42029.
Fixes #42530 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42184


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 00:22:42 +00:00
Weston Ruter 36282a2a9c About Page: Fix issue with overlapping images and text on IE11 and Edge 15. 
Props Clorith, ryelle, afercia, la-geek, SergeyBiryukov.
See #42087.
Fixes #42545 for 4.9

Built from https://develop.svn.wordpress.org/branches/4.9@42182


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-14 23:04:40 +00:00
Weston Ruter 0110751ddc Editor: Cease adding paragraphs when switching editor tabs. 
Fixes an error since [41783] in which extra paragraphs could be added to content when switching editor tabs.

Props pento, adamsilverstein, aduth.
Fixes #42531 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42178


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-14 05:28:41 +00:00
Gary Pendergast 5e736b62e0 Editor: When switching Editor tabs, don't scroll unnecessarily. 
- When switching to the Text view, wait until after the Visual editor element has been hidden, before focussing the `<textarea>`.
- When switching to the Visual view, only scroll if the cursor is not visible on the current screen.

Merge of 52175 to the 4.9 branch.

Fixes #42530.


Built from https://develop.svn.wordpress.org/branches/4.9@42176


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-14 05:21:39 +00:00
Weston Ruter eb18399c10 About: Fix jumping behavior for titles and columns when scrolling. 
Props ryelle.
See #42087.
Fixes #42514, #42526 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42174


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-13 22:48:36 +00:00
Weston Ruter c268b2f28c Customize: Allow notifications for linting errors in code editor control (for Additional CSS) to be overridden to allow saving. 
Implements the same override that was implemented in [41721] for the theme/plugin editors.

See #41897, #41887.
Fixes #42528 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42172


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-13 22:47:12 +00:00
Weston Ruter 15b14c30c1 Customize: Prevent PHP notice on theme-switch dashboard welcome link (and link to themes admin screen) when user cannot `customize`. 
Props skostadinov, ocean90.
Amends [41699].
See #42050.
Fixes #42525 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42170


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-13 22:45:47 +00:00
Weston Ruter 11e007c502 About: Add vertical alignment for developer happiness sections. 
Also run CSS autoprefixer to add `-ms-` prefixes for CSS grid identifiers for IE11.

Props Presskopp.
Amends [42121].
See #42087.
Fixes #42524 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42162


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-13 05:49:36 +00:00
Weston Ruter b0c557fbb2 About: Fix grammar typo with pluralization. 
Props metodiew, westonruter.
Amends [42121].
See #42087.
Fixes #42476 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42160


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-13 05:20:36 +00:00
Weston Ruter 277261edeb About: Synchronize 4.9 tagline across about pages for credits, freedoms, and privacy. 
Props dave.pullig.
Amends [41943].
See #42087.
Fixes #42518 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42158


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-12 20:00:37 +00:00
Weston Ruter 1b39843b11 Theme Editor: Fix styling of child theme notice. 
Props westonruter, melchoyce, ndiego.
See #24048.
Fixes #42491 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42156


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-11 20:44:38 +00:00
Weston Ruter 6cc5d01d17 Customize: Restore ability to add Custom Link nav menu items for jump links and other URLs that were previously allowed. 
Simplify regular expression for checking URL validity to just do basic checks to confirm the value looks like a URL. Leave the complete validation to the server-side logic in `WP_Customize_Nav_Menu_Item_Setting::sanitize()` to avoid having to maintain two separate codebases for validating URLs.

Props westonruter, SergeyBiryukov for testing.
Amends [41697].
See #32816.
Fixes #42506 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42154


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-10 23:43:39 +00:00
Weston Ruter a647fbead2 Settings: Replace `count()` call with `empty()` in `get_settings_errors()` to prevent PHP 7.2 warnings when `$wp_settings_errors` is `null`. 
Props pross, dd32, westonruter.
See #40109.
Fixes #42498 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42147


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-10 22:32:47 +00:00
Weston Ruter 389166f9aa Customize: Ensure autosave revision is dismissed immediately after implicit restoration notice dismissal as done with explicit notice dismissal. 
Fixes issue where a drafted/scheduled changeset could inadvertently re-use the previous autosave revision in the preview while a user expects it to have been dismissed.

See #39896, [41597].
Fixes #42502 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42145


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-10 21:45:38 +00:00
Weston Ruter af74789be0 Widgets: Style the Image Widget's link field as invalid when a bad URL is supplied. 
Fixes issue where user may supply an invalid URL and be unable to save the widget on the Widgets admin screen without being told why.

Amends [41252].
See #41274.
Fixes #42488 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42141


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-10 01:29:40 +00:00
Weston Ruter ca12fb6710 Customize: Fix reliability of just-in-time publishing for changesets that miss their schedule when visiting `customize.php`. 
When just doing `wp_publish_post()` for the changeset from `customize.php`, any option-based settings will fail to get saved because `WP_Customize_Manager` would have already been loaded with `settings_previewed`, resulting in `update_option()` calls being short-circuited. So an admin-ajax request to `customize_save` is used to work around this.

Props westonruter, jeremyfelt, dlh for testing, LittleBigThing for testing.
Amends [41626].
See #28721, #39221.
Fixes #42457 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42139


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-09 04:45:38 +00:00
Weston Ruter 707a3196f7 Customize: Ensure `autosaving` message gets sent to preview after initial change when `saved` state is first dirty. 
Amends [41667].
Fixes #42475 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42137


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-09 04:21:40 +00:00
Weston Ruter e6a91f7ccf Settings: Fix date/time format previewing. 
Props afercia.
Amends [41857].
Fixes #41603 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42135


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-09 03:57:36 +00:00
Weston Ruter bbef4fd178 Customize: Restore search icon to available widgets pane incorrectly removed in [41893]. 
See #42215.
Fixes #42472 for 4.9.

Built from https://develop.svn.wordpress.org/branches/4.9@42133


git-svn-id: http://core.svn.wordpress.org/branches/4.9@41964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-09 01:06:34 +00:00
Konstantin Obenland 4eda9c7388 About: Hardcoded image sources. 
We're committed to these images now.

See #42087.

Built from https://develop.svn.wordpress.org/trunk@42123


git-svn-id: http://core.svn.wordpress.org/trunk@41954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-07 04:26:48 +00:00
Weston Ruter e4fe01e2b4 Customize: Fix logic inversion in [42113] which prevented themes from being installed in Customizer. 
Also fix PHP notice related to parent themes and WordPress.org theme query results.

Props dd32, obenland, celloexpressions, westonruter, atachibana for testing.
See #42406, #37661.
Fixes #42442.

Built from https://develop.svn.wordpress.org/trunk@42122


git-svn-id: http://core.svn.wordpress.org/trunk@41953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-07 04:17:47 +00:00
Mel Choyce 2382232692 About Page: Implement design. 
Props ryelle, karmatosed, transl8or, obenland, melchoyce.
See #42087.

Built from https://develop.svn.wordpress.org/trunk@42121


git-svn-id: http://core.svn.wordpress.org/trunk@41952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-07 04:11:47 +00:00
Weston Ruter a74afff787 Customize: Prevent `customize_autosaved=on` from getting added to frontend preview URLs. 
Amends [41969].
See #39896, #42450.
Fixes #42433.

Built from https://develop.svn.wordpress.org/trunk@42118


git-svn-id: http://core.svn.wordpress.org/trunk@41947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-06 23:11:53 +00:00
John Blackbourn b8de3548d3 Administration: Ensure the new Privacy Policy screen appears when within the Network Admin and User Admin. 
Props hnle, dd32
Fixes #42443

Built from https://develop.svn.wordpress.org/trunk@42116


git-svn-id: http://core.svn.wordpress.org/trunk@41945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-06 18:17:54 +00:00
Konstantin Obenland 65c1468ff5 File Editors: Account for network admin use 
Fixes a bug where files couldn't be accessed in multisite installs.

Props flixos90, westonruter.
Fixes #42420.


Built from https://develop.svn.wordpress.org/trunk@42115


git-svn-id: http://core.svn.wordpress.org/trunk@41944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-03 18:51:49 +00:00
Weston Ruter 76e01c3562 Customize: Ensure `changeset_uuid` param for autosave auto-draft gets stripped from location after previewing theme switch when not in branching mode. 
Amends [41597].
See #39896.
Fixes #42415.

Built from https://develop.svn.wordpress.org/trunk@42114


git-svn-id: http://core.svn.wordpress.org/trunk@41943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-03 17:37:52 +00:00
Weston Ruter d0608c5585 Customize: Make sure theme switch blocking in the Customizer is consistently applied when changeset is drafted/scheduled. 
* Consider both `selectedChangesetStatus` and `changesetStatus` states when deciding to disable.
* Factor out common logic into `canSwitchTheme` function on `ThemesPanel`.
* Keep Live Preview and Install buttons disabled in Themes controls and detail overlays when appropriate.

Props westonruter, dlh.
Amends [41788].
See #42126, #37661, #39896.
Fixes #42406.

Built from https://develop.svn.wordpress.org/trunk@42113


git-svn-id: http://core.svn.wordpress.org/trunk@41942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-03 00:59:47 +00:00
Weston Ruter 83c29a4d08 Theme Editor: Ensure files listed recursively can be both viewed and edited. 
Prevent edits to 2-level deep theme files from returning a `disallowed_theme_file` error when attempting to save an edit. Aligns logic for gathering `$allowed_files` in `theme-editor.php` for listing files with the validation logic in `wp_edit_theme_plugin_file()`.

Amends [41806].
See #6531.
Fixes #42425.

Built from https://develop.svn.wordpress.org/trunk@42112


git-svn-id: http://core.svn.wordpress.org/trunk@41941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-02 23:05:48 +00:00
Weston Ruter ef272167c4 Customize: Present the date/time control input fields in the same format (and order) as `date_format`. 
Props westonruter, obenland, atachibana for testing, Mirucon for testing.
See #42373, #28721.
Fixes #42394.

Built from https://develop.svn.wordpress.org/trunk@42111


git-svn-id: http://core.svn.wordpress.org/trunk@41940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-02 23:00:49 +00:00
Weston Ruter 926f2114f0 Customize: Strip zero padding when setting month to prevent de-selection; add zero-padding for `number` input fields when blurring. 
Amends [42042].
See #42373.
Fixes #42392.

Built from https://develop.svn.wordpress.org/trunk@42104


git-svn-id: http://core.svn.wordpress.org/trunk@41933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-01 21:04:53 +00:00
Weston Ruter 8a1dc558a1 Customize: Consolidate sourcing of control `params`. 
Prevent needlessly iterating over `controlConstructor` to find `type` when it is already supplied.

Amends [41750], [41726].
See #42083.

Built from https://develop.svn.wordpress.org/trunk@42048


git-svn-id: http://core.svn.wordpress.org/trunk@41882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-31 02:59:47 +00:00
Konstantin Obenland b61de38e87 Customize: Spiff up theme updates 
Fixes UI bugs around theme updates in the Customizer. Theme versions now get updated and users are no longer left alone after a successful update.

Props rinkuyadav999, celloexpressions for initial patch.
Fixes #42365.

Built from https://develop.svn.wordpress.org/trunk@42046


git-svn-id: http://core.svn.wordpress.org/trunk@41880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-31 01:33:47 +00:00
Gary Pendergast 8981414082 About page: Tweak the privacy policy language, for clarity. 
See #40794.


Built from https://develop.svn.wordpress.org/trunk@42045


git-svn-id: http://core.svn.wordpress.org/trunk@41879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-31 00:21:49 +00:00
Mel Choyce f7aa0e24a7 About Page: Update the blurb in "Warning: Potential Danger Ahead!" to be more accurate. 
Props transl8or, karmatosed, chanthaboune.
See #42087.

Built from https://develop.svn.wordpress.org/trunk@42044


git-svn-id: http://core.svn.wordpress.org/trunk@41878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-30 20:58:50 +00:00
Weston Ruter ca84147401 Customize: Allow 0:00-0:59 in date/time control when 24-hour time used. 
* Let min hour be 0 and max be 23 in 24-hour time; let min hour be 1 and max be 12 in 12-hour time.
* Show error notification when an invalid date value is provided, not just when not a future date.
* Fix translation of custom validity message.
* Start checking for validity after all inputs have been initially populated.
* Remove support for being able to enter 24:00.
* Cease forcing date input elements from being casted to integers, to allow for invalid inputs to be detected.

Props westonruter, Presskopp, peterwilsoncc, atachibana for testing.
See #39896, #28721.
Fixes #42373.

Built from https://develop.svn.wordpress.org/trunk@42042


git-svn-id: http://core.svn.wordpress.org/trunk@41876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-30 16:40:47 +00:00
Weston Ruter fbb0b8bc8f Customize: Debounce requests for theme searches and the updating of the resulting filter count. 
Props celloexpressions.
See #37661.
Fixes #42343.

Built from https://develop.svn.wordpress.org/trunk@42040


git-svn-id: http://core.svn.wordpress.org/trunk@41874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-30 03:57:52 +00:00
Weston Ruter 5fc9fddccc Customize: Fix interface alignment between `Setting` and `Control`, adding `defaults` to `wp.customize.Setting` and using `wp.customize.previewer` as default `previewer` param. 
Also move jsdoc from class to `initialize` method and correct the param types.

Amends [41726], [42037], [32681].
See #42083, #30737.

Built from https://develop.svn.wordpress.org/trunk@42038


git-svn-id: http://core.svn.wordpress.org/trunk@41872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-29 03:08:53 +00:00
Weston Ruter 35172737ef Customize: Support instantiation of partials with flat/unwrapped params for parity with controls, sections, and panels in [41726]. 
* Passing `options.params` when constructing `Partial` is now deprecated in favor of just passing `options`.
* Improve usage of jsdoc in JS `Partial` class.
* Also add `defaults` property to `wp.customize.selectiveRefresh.Partial` class for parity with `Control`.

See #42083.

Built from https://develop.svn.wordpress.org/trunk@42037


git-svn-id: http://core.svn.wordpress.org/trunk@41871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-29 00:15:53 +00:00
Weston Ruter cb7483b595 Customize: Fix mobile placement of panes for available widgets and nav menu items. 
Props Mahvash-Fatima.
Amends [41893].
See #42215.
Fixes #42359.

Built from https://develop.svn.wordpress.org/trunk@42036


git-svn-id: http://core.svn.wordpress.org/trunk@41870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-28 06:54:47 +00:00
Weston Ruter 84b969efea Customize: Ensure `id` for section and panel is passed among `params` to respective templates. 
Fixes issue where JS-added Publish Settings section failed to get container element ID set properly to hide its section-meta.

Amends [42025].
See #42337, #42083.

Built from https://develop.svn.wordpress.org/trunk@42035


git-svn-id: http://core.svn.wordpress.org/trunk@41869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-28 06:37:47 +00:00
Weston Ruter 685e3c1a67 Customize: Deprecate nav menu classes that are no longer used, instead of removing them immediately. 
* Deprecate PHP classes `WP_Customize_New_Menu_Section` and `WP_Customize_New_Menu_Control`.
* Deprecate JS class `wp.customize.Menus.NewMenuControl`.
* Also introduce `wp.customize.Menus.createNavMenu()` for logic to create nav menus separately from the logic for handling UI interactions.

Amends [41768].
See #40104, #42364.
Fixes #42357.

Built from https://develop.svn.wordpress.org/trunk@42034


git-svn-id: http://core.svn.wordpress.org/trunk@41868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-28 05:48:47 +00:00
Weston Ruter 9dca5ae189 Customize: Fix deep-linking to sections for themes via `autofocus[section]` query parameter. 
* Expand containing panel when expanding themes section.
* Consolidate UI changes related to a section's expanded state change.
* Prevent collapsing current section when expanding.
* Auto-expand first themes section when expanding panel if one is not expanded already.

See #37661, #42354.
Fixes #42360.

Built from https://develop.svn.wordpress.org/trunk@42033


git-svn-id: http://core.svn.wordpress.org/trunk@41867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-28 05:22:46 +00:00
Weston Ruter d348f1624b Customize: Improve Media control accessibility and compatibility for `settings` passed as arrays or as solitary `setting`. 
* Eliminate Media control template from having dependency on `params.settings.default` for element ID, to fix compat with `params.settings` array or single `params.setting`. See #36167.
* Move description out of label and add `aria-describedby` to Media control's Select button. See #30738, #33085.
* Obtain notification container whenever content is (re-)rendered (such as for Media control). See #38794.
* Re-render notifications after control content is re-rendered, if control is in expanded section. See #38794.

Amends [41390].
See #36167, #38794, #33085, #30738.

Built from https://develop.svn.wordpress.org/trunk@42031


git-svn-id: http://core.svn.wordpress.org/trunk@41865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-27 20:18:47 +00:00
Weston Ruter 7b0de1f1b0 Themes: Switch back from throttling to debouncing in theme searches on admin screen. 
Start debouncing after initial search performed when `search` query param is present to prevent initial "flash of unsearched themes".

Props afercia, westonruter.
Amends [41797].
See #40254.
Fixes #42348.

Built from https://develop.svn.wordpress.org/trunk@42029


git-svn-id: http://core.svn.wordpress.org/trunk@41863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-27 03:31:53 +00:00
Weston Ruter a6af74ec32 Customize: Register the Publish Settings section in JS to ensure it does not get unregistered via PHP. 
The `publish_settings` section is a fundamental dependency for Customizer, so it must be guaranteed to be registered.

Also unconditionally register core types for panels, sections, and controls in case plugin unhooks all `customize_register` actions.

See #39896.
Fixes #42337.

Built from https://develop.svn.wordpress.org/trunk@42025


git-svn-id: http://core.svn.wordpress.org/trunk@41859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 21:45:49 +00:00
Weston Ruter 3ed6bbf4a4 Customize: Link `elements` prior to embedding to prevent possible errors when a control is associated with a non-existent section. 
Fixes issue specifically with attempting to access an orphaned control's `elements` immediately after it has been added. Normally this would not happen because a control would not be registered without a section, and also a control should only be interacted with once its `embedded` deferred has been resolved.

Also harden logic for gathering list of deferred setting IDs.

See #37964.
Fixes #42330.

Built from https://develop.svn.wordpress.org/trunk@42024


git-svn-id: http://core.svn.wordpress.org/trunk@41858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 16:49:49 +00:00
Sergey Biryukov 6b3b489a5d Permalinks: Change mention of URI to URL in the description of `%category%` tag. 
Props danieltj, tobifjellner.
Fixes #42147.
Built from https://develop.svn.wordpress.org/trunk@42023


git-svn-id: http://core.svn.wordpress.org/trunk@41857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 11:11:45 +00:00
Weston Ruter d19c79fa21 Customize: Remove `theme_installing` notification when installation fails. 
Amends [41648].
Props celloexpressions.
See #42184, #37661.

Built from https://develop.svn.wordpress.org/trunk@42018


git-svn-id: http://core.svn.wordpress.org/trunk@41852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 01:14:46 +00:00
Gary Pendergast 3cd984f024 About page: The link URLs in the privacy policy shouldn't be translatable. 
Both of these URLs live on the main wordpress.org site, not Rosetta sites.

See #40794.


Built from https://develop.svn.wordpress.org/trunk@42017


git-svn-id: http://core.svn.wordpress.org/trunk@41851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 01:07:47 +00:00
iandunn 2762709d2a Dashboard: Strip ports from IPs to avoid PHP warnings. 
Fixes #41083.
Props pento, iandunn, EatonZ, birgire, dd32.

Built from https://develop.svn.wordpress.org/trunk@42016


git-svn-id: http://core.svn.wordpress.org/trunk@41850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 00:07:46 +00:00
Weston Ruter 12c626c82e Update `$_old_files` to add the deleted MediaElement.js files when it was upgraded from 2.22.0 to 4.2.3. 
Amends [41198].
See #39686.
Fixes #42097.

Built from https://develop.svn.wordpress.org/trunk@42015


git-svn-id: http://core.svn.wordpress.org/trunk@41849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-25 00:02:50 +00:00
Sergey Biryukov 116e4712cb I18N: Use a consistent pattern for translator comments for placeholders in the string added in [42013]. 
See #41974.
Built from https://develop.svn.wordpress.org/trunk@42014


git-svn-id: http://core.svn.wordpress.org/trunk@41848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:40:46 +00:00
Mel Choyce 7495a110cc Code Editors: Add a persistent notification on CSS files, encouraging people to use the CSS panel in the Customizer instead of editing their CSS files directly. 
Props helen, westonruter, nic.bertino, michelleweber.
Fixes #42100.

Built from https://develop.svn.wordpress.org/trunk@42013


git-svn-id: http://core.svn.wordpress.org/trunk@41847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:35:46 +00:00
Weston Ruter d96b7af890 Permalinks: Fix placement of structure tags based on last cursor position. 
Props felipeelia, afercia.
See #29872.
Fixes #42042.

Built from https://develop.svn.wordpress.org/trunk@42012


git-svn-id: http://core.svn.wordpress.org/trunk@41846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:27:48 +00:00
John Blackbourn 2f3e91028a Filesystem API: Add more specificity to the rules for valid files in `validate_file()`. 
This now treats files containing `./` as valid, and also treats files containing a trailing `../` as valid due to widespread use of this pattern in theme and plugin zip files.

Adds tests.

Props Ipstenu, borgesbruno, DavidAnderson, philipjohn, birgire
Fixes #42016, #36170

Built from https://develop.svn.wordpress.org/trunk@42011


git-svn-id: http://core.svn.wordpress.org/trunk@41845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:15:49 +00:00
John Blackbourn 16cfe96580 Filesystem API: Don't immediately return an error for invalid file names contained within a Zip while it's being extracted. 
This allows the extraction of the rest of the valid files within the archive to continue.

See #42016

Built from https://develop.svn.wordpress.org/trunk@42010


git-svn-id: http://core.svn.wordpress.org/trunk@41844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:11:50 +00:00
Weston Ruter 48e726bbef Embeds: Improve consistency of update and refresh logic for oEmbed caching between `oembed_cache` and post meta. 
* Allow updating oEmbed cache during `parse-embed` requests for non-post editors (such as widgets).
* Update any existing `oembed_cache` post when `usecache` and TTL has passed.
* Do not overwrite a previously valid cache with `{{unknown}}`.

Props dlh.
See #34115.
Fixes #42310.

Built from https://develop.svn.wordpress.org/trunk@42009


git-svn-id: http://core.svn.wordpress.org/trunk@41843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:10:48 +00:00
Sergey Biryukov 5dd45b38c8 Transients: After [41963], add missing cron task for `delete_expired_transients()`. 
Props dlh.
Fixes #41699.
Built from https://develop.svn.wordpress.org/trunk@42008


git-svn-id: http://core.svn.wordpress.org/trunk@41842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 23:00:47 +00:00
John Blackbourn 4812370aab Docs: Improve the docs for `validate_file()` and `validate_file_to_edit()`. 
See #42016, #36170, #41017

Built from https://develop.svn.wordpress.org/trunk@42007


git-svn-id: http://core.svn.wordpress.org/trunk@41841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 22:50:49 +00:00
Sergey Biryukov 29d5ee851c I18N: Use a consistent pattern for translator comments for placeholders in some more Customizer strings. 
See #41974.
Built from https://develop.svn.wordpress.org/trunk@42006


git-svn-id: http://core.svn.wordpress.org/trunk@41840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 22:47:46 +00:00
Sergey Biryukov f156f90ff5 I18N: Add a context for remaining "Schedule" strings. 
Props Mirucon.
Fixes #42165.
Built from https://develop.svn.wordpress.org/trunk@42005


git-svn-id: http://core.svn.wordpress.org/trunk@41839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 22:35:47 +00:00
Weston Ruter a1ec65b695 Themes: Harmonize list of theme features on Theme Install screen with list in the Customizer. 
Use the core list, rather than the .org API, due to inconsistencies and to ensure tags are translated.

Props celloexpressions.
See #37661, #42306.

Built from https://develop.svn.wordpress.org/trunk@42003


git-svn-id: http://core.svn.wordpress.org/trunk@41837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 21:46:47 +00:00
Mel Choyce c0d0380baa Code Editors: Tweak styles to work better on smaller screens. 
See #42100.

Built from https://develop.svn.wordpress.org/trunk@41999


git-svn-id: http://core.svn.wordpress.org/trunk@41833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 20:29:46 +00:00
Mel Choyce 9c7eb32fc2 Credits: Update "Contributing Developers" to "Noteworthy Contributors." 
"Developers" excludes the various major contributors in non-developer roles, so let's update this term to be more inclusive.

See #41022.

Built from https://develop.svn.wordpress.org/trunk@41998


git-svn-id: http://core.svn.wordpress.org/trunk@41832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 19:29:47 +00:00
Weston Ruter 6737643773 Customize: Prevent theme installation and deletion in Customizer while SFTP credentials need to be requested. 
This is a temporary measure while we wait for credentials to be able to be supplied in the Customizer.

Amends [41788].
See #42184, #37661, #42126.

Built from https://develop.svn.wordpress.org/trunk@41997


git-svn-id: http://core.svn.wordpress.org/trunk@41831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 19:06:47 +00:00
Mel Choyce b008754486 Code Editors: Update copy in warning modals. 
Props helen.
See #42100.

Built from https://develop.svn.wordpress.org/trunk@41996


git-svn-id: http://core.svn.wordpress.org/trunk@41830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 18:47:47 +00:00
Weston Ruter 226263bfec Code Editor: Define default `gutters` and toggle lint markers based on changes to `lint` option. 
Explicitly define `gutters` in base `defaultSettings` to improve merges of multiple calls to `wp_enqueue_code_editor()`.

Props westonruter, georgestephanis for testing.
Amends [41974].
See #12423.

Built from https://develop.svn.wordpress.org/trunk@41992


git-svn-id: http://core.svn.wordpress.org/trunk@41826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 16:35:54 +00:00
Sergey Biryukov 4c16522bbe Taxonomy: Use `keypress` instead of `keyup` for listening for Enter key to add a tag via Tags meta box. 
Fixes issue with Japanese input.

Props miyauchi.
Fixes #42234.
Built from https://develop.svn.wordpress.org/trunk@41988


git-svn-id: http://core.svn.wordpress.org/trunk@41822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 11:30:49 +00:00
Sergey Biryukov 654386a5b7 Taxonomy: After [40984], add the `most_used` label for non-hierarchical taxonomies too, and use it on the Menus screen. 
Props johnbillion.
Fixes #41150.
Built from https://develop.svn.wordpress.org/trunk@41987


git-svn-id: http://core.svn.wordpress.org/trunk@41821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 11:23:24 +00:00
Sergey Biryukov ffddfb573b I18N: Remove `<code>` and `<kbd>` tags from translatable strings on Settings screens. 
Move URLs to separate strings.

Props ramiy.
Fixes #40763.
Built from https://develop.svn.wordpress.org/trunk@41986


git-svn-id: http://core.svn.wordpress.org/trunk@41820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 10:51:52 +00:00
Weston Ruter 9093718b15 Editor: Specify `maxwidth` in `parse-embed` requests based on width of editor iframe so that TinyMCE view embeds fit, particularly in Text widgets. 
See #40854, #34115.

Built from https://develop.svn.wordpress.org/trunk@41985


git-svn-id: http://core.svn.wordpress.org/trunk@41819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-24 04:07:50 +00:00