Commit Graph

42303 Commits

Author SHA1 Message Date
Peter Wilson 3a58019c39 Version bump for 5.5.4.
Built from https://develop.svn.wordpress.org/branches/5.5@50738


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 01:35:01 +00:00
Peter Wilson 3623a537fa Grouped merges for 5.5.4.
* REST API: Allow authors to read their own password protected posts.
* About page update

Merges [50717] to the 5.5 branch.

Built from https://develop.svn.wordpress.org/branches/5.5@50725


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 01:07:00 +00:00
Peter Wilson 879e812239 Editor: Update of @wordpress npm packages for 5.5.4.
Built from https://develop.svn.wordpress.org/branches/5.5@50722


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 00:10:23 +00:00
desrosj 88e3d8ef14 Build/Test Tools: Prevent PHPUnit tests on `push` for forks/private mirrors.
The reorganization of the PHPUnit workflow in [50441] unintentionally caused the tests to be run for every `push` event, even for forks and private mirrors.

Previously, the second job required the first one to pass, and the conditional check on the first prevented both from running. Because the first job is no longer required for the second, both jobs must have the appropriate conditional check.

Merges [50670] to the 5.5 branch.
Fixes #52983.
Built from https://develop.svn.wordpress.org/branches/5.5@50673


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 15:29:04 +00:00
desrosj 64dc3f9159 Build/Test Tools: Backport GitHub Action and build improvements to the 5.5 branch.
This backports several build and test tool improvements to the 5.5 branch. Most notably, this includes:

- The changes required to allow each workflow to be triggered by the `workflow_dispatch` event so that tests can be run on a schedule [50590].
- The ability to run PHPUnit tests from `src` instead of `build` [50441-50443].
- Splitting single site and multisite tests into parallel jobs [50379].
- Split slow tests into separate, parallel jobs for PHP 5.6 [50444].
- Better branch and path scoping for GitHub Action workflows when running on `pull_request` [50432,50479].
- Several `devDependency` updates.

Merges [50267,50299,50379,50387,50413,50416,50432,50435-50436,50441-50444,50446,50473-50474,50476,50479,50485-50487,50545,50579,50590,50592,50598] to the 5.5 branch.
See #50401, #51734, #51801, #51802, #52548, #52608, #52612, #52623, #52624, #52625, #52645, #52653, #52658, #52660, #52667, #52786.
Built from https://develop.svn.wordpress.org/branches/5.5@50603


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 17:49:17 +00:00
desrosj fa18a89a67 Build/Test Tools: Restore automated testing in the 5.5 branch.
This commit merges the workflow files required to run automated testing on GitHub Actions.

In addition, [49836] and [50285] have been included in order to keep the local Docker environment consistent across all branches.

Merges [49162,49168-49169,49175,49204,49227-49228,49244,49369,49371,49548,49781-49784,49786,49836,49938,50268,50285,50298] to the 5.5 branch.
See #50401.
Built from https://develop.svn.wordpress.org/branches/5.5@50302


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 17:39:59 +00:00
desrosj 425d33ee65 Build/Test Tools: Fix tests after [50188].
This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.

Props peterwilsoncc.
Merges [50192] to the 5.5 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/5.5@50194


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 03:42:02 +00:00
desrosj 2d74427834 Build/Test Tools: Support NodeJS 14.x in the 5.5 branch.
This updates the 5.5 branch to support the latest LTS version of NodeJS (currently 14.x) in an effort to allow the same version of NodeJS to be used across all WordPress branches receiving security updates as a courtesy.

In addition to backporting the package updates that happened after branching 5.5, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [48705,49636,49933,49937,49939-49940,49983,49989-49990,50016-50017,50126,50176,50185] to the 5.5 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/5.5@50188


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 03:06:34 +00:00
Sergey Biryukov 54362b988a Tests: Set up the plugin download in multisite plugin tests to come locally.
This brings consistency between single site and multisite in REST API plugin installation tests.

Previously, multisite tests were unnecessarily downloading the plugin from WordPress.org on each test run, causing external HTTP requests and leading to failures in case of a timeout.

Follow-up to [48242], [49491], [49913].

Merges [49951] to the 5.5 branch.
See #51669.
Built from https://develop.svn.wordpress.org/branches/5.5@50086


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-30 10:41:53 +00:00
Sergey Biryukov 317f7331fc Tests: Disable update checks while running REST API plugin installation tests.
This prevents external HTTP requests that are not required for the tests in question and may interfere with the results in case of a timeout.

Follow-up to [48242], [49491].

Merges [49913] to the 5.5 branch.
See #51669.
Built from https://develop.svn.wordpress.org/branches/5.5@50084


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-30 10:38:58 +00:00
desrosj 9c3b41b023 Build/Test Tools: Remove the TravisCI configuration file.
In [49162], GitHub Action workflow configuration files were introduced to run all of Core’s automated testing with the intent to fully transition after some time was allowed for testing.

After two full months of testing, the time to finish this transition has come.

We thank TravisCI for testing the codebase through nearly 20 major and many more minor releases.

Merges [49876] to the 5.5 branch.
See #52161. See #50401.
Built from https://develop.svn.wordpress.org/branches/5.5@49878


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 21:06:07 +00:00
desrosj eb3e30b6e8 Build/Test Tools: Remove the Appveyor configuration file.
Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.5 branch.
See #51968.
Built from https://develop.svn.wordpress.org/branches/5.5@49810


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 12:29:10 +00:00
Sergey Biryukov 30cfb5eed3 Security: Update the Security Policy for the 5.5 branch.
See [49645], [49646].
Props whyisjake.
Built from https://develop.svn.wordpress.org/branches/5.5@49647


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 23:07:05 +00:00
desrosj 2b186198ca Build/Test Tools: Fix Travis configuration error.
Follow up to [49500].

See #51705.
Built from https://develop.svn.wordpress.org/branches/5.5@49501


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 15:57:04 +00:00
desrosj 21df5a2520 Build/Test Tools: Remove the E2E test job from the 5.5 branch.
The E2E test job does not currently perform any meaningful tests, so continuing to run them is not necessary for older branches.

Props johnbillion.
See #51705.
Built from https://develop.svn.wordpress.org/branches/5.5@49500


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 15:54:06 +00:00
desrosj 433f7ec7a1 Build/Test Tools: Remove jobs that are allowed to fail for the 5.5 branch.
Because PHP 8 support will not be backported to the 5.5 branch, the test job in the Travis matrix will never pass, making it unnecessary to continue running.

See #51705.
Built from https://develop.svn.wordpress.org/branches/5.5@49497


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 15:02:07 +00:00
Sergey Biryukov 18b7e09efb Post WordPress 5.5.3 version bump. The 5.5 branch is now 5.5.4 alpha.
Built from https://develop.svn.wordpress.org/branches/5.5@49468


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-30 21:17:06 +00:00
Sergey Biryukov 3448d022f8 WordPress 5.5.3.
Props audrasjb.
Fixes #51684.
Built from https://develop.svn.wordpress.org/branches/5.5@49458


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-30 19:32:05 +00:00
whyisjake fd75e76255 Upgrade/Install: During the install process, add additional checking for exising tables.
This commit brings the changes in [49452] to the 5.5 branch.

If reinstalling WordPress, there is a condition where tables would exist in the database. Ensures that when that is the case, the install process can carry along without issue.

Fixes #51676.

Props xknown, garubi, mukesh27, desrosj, johnbillion, metalandcoffee, davidbaumwald, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.5@49453


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-30 17:56:08 +00:00
Sergey Biryukov 1efd16777a Post WordPress 5.5.2 version bump. The 5.5 branch is now 5.5.3 alpha.
Built from https://develop.svn.wordpress.org/branches/5.5@49449


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 20:56:08 +00:00
desrosj f9e0a7396c WordPress 5.5.2.
Props audrasjb.
Fixes #51649.
Built from https://develop.svn.wordpress.org/branches/5.5@49447


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 20:02:05 +00:00
noisysocks 67a606b0f4 Editor: Update packages
@wordpress/block-directory: 1.13.8 -> 1.13.9
@wordpress/block-editor: 4.3.8 -> 4.3.9
@wordpress/block-library: 2.22.8 -> 2.22.9
@wordpress/edit-post: 3.21.8 -> 3.21.9
@wordpress/edit-site: 1.11.8 -> 1.11.9
@wordpress/editor: 9.20.8 -> 9.20.9
@wordpress/format-library: 1.22.8 -> 1.22.9

See #51659.

Built from https://develop.svn.wordpress.org/branches/5.5@49446


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 20:00:29 +00:00
whyisjake 13bdf36937 XML-RPC: Improve error messages for unprivileged users.
Add specific permission checks to avoid ambiguous failure messages.

This brings the changes in [49380] to the 5.5 branch.

Props zieladam, peterwilsoncc, xknown, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.5@49389


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 18:28:08 +00:00
whyisjake d80104976c Coding Standards: Use a strict comparison operator when comparing values.
Props batmoo, mukesh27.

Built from https://develop.svn.wordpress.org/branches/5.5@49381


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:46:06 +00:00
whyisjake f2b1d503c0 Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.
Props xknown, zieladam, peterwilsoncc, whyisjake

Built from https://develop.svn.wordpress.org/branches/5.5@49379


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:35:04 +00:00
whyisjake 270c69eacd Meta: Sanitize meta key before checking protection status.
Props zieladam, peterwilsoncc, xknown, whyisjake.


Built from https://develop.svn.wordpress.org/branches/5.5@49378


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:33:05 +00:00
whyisjake 951e583bb4 Upgrade/install: Improve logic check when determining installation status.
Improve handling of ambiguous return values to determine if a blog is installed.

Props zieladam, xknown.

Built from https://develop.svn.wordpress.org/branches/5.5@49377


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:26:03 +00:00
whyisjake 107e7856e6 XML-RPC: Return error message if attachment ID is incorrect.
Throw an error for incorrect attachment IDs when requesting a media object to ensure return signature is correct and doesn't include incorrectly typed values within the object.

Props zieladam, peterwilsoncc, whyisjake.
See #49905.

Built from https://develop.svn.wordpress.org/branches/5.5@49376


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:00:03 +00:00
whyisjake a428042e49 Coding standards: Modify escaping functions to avoid potential false positives.
Props xknown, zieladam, peterwilsoncc.Y


Built from https://develop.svn.wordpress.org/branches/5.5@49375


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 16:58:05 +00:00
whyisjake 8518cbeea9 Embeds: Disable embeds on deactivated Multisite sites.
Props xknown, whyisjake, zieladam, peterwilsoncc.

Built from https://develop.svn.wordpress.org/branches/5.5@49374


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 16:54:05 +00:00
whyisjake 180e707b2e External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
Props xknown, peterwilsoncc, desrosj, dd32, whyisjake.


Built from https://develop.svn.wordpress.org/branches/5.5@49373


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 16:38:08 +00:00
noisysocks 55e14b6d32 Editor: Update packages
@wordpress/block-directory: 1.13.7 -> 1.13.8
@wordpress/block-editor: 4.3.7 -> 4.3.8
@wordpress/block-library: 2.22.7 -> 2.22.8
@wordpress/blocks: 6.20.3 -> 6.20.4
@wordpress/components: 10.0.6 -> 10.0.7
@wordpress/core-data: 2.20.3 -> 2.20.4
@wordpress/edit-post: 3.21.7 -> 3.21.8
@wordpress/editor: 9.20.7 -> 9.20.8
@wordpress/format-library: 1.22.7 -> 1.22.8
@wordpress/icons: 2.4.0 -> 2.4.1
@wordpress/list-reusable-blocks: 1.21.6 -> 1.21.7
@wordpress/nux: 3.20.6 -> 3.20.7
@wordpress/plugins: 2.20.3 -> 2.20.4
@wordpress/server-side-render: 1.16.6 -> 1.16.7

Props talldanwp.
See #51659, #51053, #50949.

Built from https://develop.svn.wordpress.org/branches/5.5@49372


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 06:13:33 +00:00
desrosj 9e31b4e809 Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment.
This introduces the `LOCAL_PHPUNIT` environment variable, which allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.

Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.

Props johnbillion, SergeyBiryukov.
Merges [49362] to the 5.5 branch.
See #50042.
Built from https://develop.svn.wordpress.org/branches/5.5@49363


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 23:34:21 +00:00
whyisjake fa2673ce4b Embeds: Remove Facebook and Instagram as an oEmbed Source
Facebook has depracated all non-authenticated endpoints for Facebook and Instagram.

This commit brings the changes from [49359] to the 5.5 branch.

See: https://developers.facebook.com/docs/plugins/oembed-legacy
See also: https://make.wordpress.org/core/2020/09/22/facebook-and-instagram-embeds-to-be-deprecated-october-24th/

With this change, endpoints are being removed. If a site is dependent on this feature, they need to pass either an app or client token. There are a few plugins that add this functionality.

Fixes #50861.
Props johnbillion, joyously, mkaz, dimadin, ayeshrajans, davisshaver, paaljoachim, Clorith, bridgetwillard, jb510, sippis, Clorith, TimothyBlynJacobs, desrosj, smub, audrasjb, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.5@49361


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 21:23:06 +00:00
Sergey Biryukov 321e099745 General: Ensure that filtered arguments in `get_search_form()` contain all required default values.
Props kellybleck, davidbaumwald, whyisjake, SergeyBiryukov.
Merges [49355] to the 5.5 branch.
Fixes #51645.
Built from https://develop.svn.wordpress.org/branches/5.5@49356


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 17:09:06 +00:00
desrosj ecd6a4c549 Build/Test Tools: Specify a type when using `wp config set`.
This prevents an error if constants are not predefined when running the Docker install script while using older combinations of WordPress/PHP/WP-CLI.

Backports [49335] to the 5.5 branch.
See #48301.
Built from https://develop.svn.wordpress.org/branches/5.5@49340


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 19:03:06 +00:00
desrosj 3bdec70780 Build/Test Tools: Set the local development environment to a local environment type by default.
Props igorradovanov, TimothyBlynJacobs, johnbillion.
Merges [49121] to the 5.5 branch.
See #50903.
Built from https://develop.svn.wordpress.org/branches/5.5@49339


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 19:01:03 +00:00
Sergey Biryukov 8f1ac79d9f Posts, Post Types: Check if taxonomy is set for the `tax_input` parameter of `wp_insert_post()`.
This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.

Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Merges [49328] to the 5.5 branch.
Fixes #51320.
Built from https://develop.svn.wordpress.org/branches/5.5@49332


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 17:56:05 +00:00
Sergey Biryukov f062c1a2cc Build Tools: Update mergeinfo for [49313].
See #51624.
Built from https://develop.svn.wordpress.org/branches/5.5@49315


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 22:58:06 +00:00
Sergey Biryukov bb32328f5e Build Tools: Fix running installing Composer dependencies using Composer 2.0.
This updates the `dealerdirect/phpcodesniffer-composer-installer` package to allow installing version `0.7.0` which supports Composer 2.0.

Props itowhid06, jrf.
Merges [49306] to the 5.5 branch.
See #51624.
Built from https://develop.svn.wordpress.org/branches/5.5@49313


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 22:47:06 +00:00
Sergey Biryukov 1d0dc9f672 Tests: Declare UTF-8 encoding for QUnit test suite.
This was done for trunk in [49101] as part of other changes, and is now backported to the 5.5 branch.

Follow-up to [49275].

Props iandunn, SergeyBiryukov.
Fixes #51130.
Built from https://develop.svn.wordpress.org/branches/5.5@49307


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-25 01:31:05 +00:00
Dion Hulse 82ed257403 Bump Akismet external to 4.1.7.
git-svn-id: http://core.svn.wordpress.org/branches/5.5@49044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 04:42:44 +00:00
tellyworth 542c3d4bb1 Community Events: Display dates and times in the user's time zone.
Fixes #51130
Merges [49145], [49146], [49147], [49152], and [49201] to the 5.5 branch.
Props sippis, hlashbrooke, audrasjb, Rarst, iandunn

Built from https://develop.svn.wordpress.org/branches/5.5@49275


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 04:05:05 +00:00
Peter Wilson 59ca490c66 XML-RPC: Fix length validation of anonymous commenter's email address.
Fix the first step of validating an anonymous commenters in which the length is checked prior to running regular expressions.

Follow up to [47808].
Merges [49271] to the 5.5 branch.
Fixes #51595.


Built from https://develop.svn.wordpress.org/branches/5.5@49273


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 02:47:07 +00:00
Sergey Biryukov f7533ee854 Comments: Hide the link to the initial parent comment in the reply heading when replying to another comment.
This ensures that the reply heading is updated correctly on single post URLs with the `?replytocom` query argument.

Follow-up to [47506], [48876], [48904].

Props mailnew2ster, wpamitkumar, audrasjb, desrosj, SergeyBiryukov.
Merges [49187] to the 5.5 branch.
Fixes #51175.
Built from https://develop.svn.wordpress.org/branches/5.5@49191


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 17:11:06 +00:00
Sergey Biryukov 5188ab0ce7 Upgrade/Install: Check if plugin or theme update results are available before applying the notification filters.
This avoids a PHP notice for an undefined index of either `plugin` or `theme` in the `auto_{plugin|theme}_update_send_email` filter hook.

Props afragen, audrasjb.
Merges [49166] to the 5.5 branch.
Fixes #51400.
Built from https://develop.svn.wordpress.org/branches/5.5@49167


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-15 23:31:07 +00:00
Sergey Biryukov f2b876135c Bootstrap/Load: Revert [49161] from the 5.5 branch.
See #50913.
Built from https://develop.svn.wordpress.org/branches/5.5@49164


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-15 21:19:05 +00:00
Aaron Jorbin 4c768414d6 Bootstrap/Load: Don't assume WP_CONTENT_DIR is defined
When the mysql extention isn't loaded and a custom db dropin is not in place, we give folks a nice error. However, we can't assume that the WP_CONTENT_DIR constant is set yet since this runs before we define default constants.

This fixes a PHP8 error.

See: #50913.


Built from https://develop.svn.wordpress.org/branches/5.5@49161


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-15 17:07:06 +00:00
Sergey Biryukov 2434d8188d Comments: Check if a valid comment ID was passed when editing a comment.
This avoids a PHP notice after submitting the Edit Comment form.

Follow-up to [48050].

Props regan.khadgi.
Merges [48958] to the 5.5 branch.
Fixes #51263.
Built from https://develop.svn.wordpress.org/branches/5.5@48959


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-08 22:46:07 +00:00
Sergey Biryukov a4b9563038 Media: In `wp_ajax_image_editor()`, check if the `error` property exists before accessing it.
This avoids a PHP notice when editing an image.

Follow-up to [48375].

Props Mista-Flo.
Merges [48946] to the 5.5 branch.
Fixes #51251.
Built from https://develop.svn.wordpress.org/branches/5.5@48956


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-07 13:07:03 +00:00