Scott Taylor
3ca4223a00
After [29197], use `! empty()` instead of `isset()`. Don't call `has_shortcode()` internally twice if it's true.
...
Props kovshenin.
Fixes #26343 .
Built from https://develop.svn.wordpress.org/trunk@29207
git-svn-id: http://core.svn.wordpress.org/trunk@28991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 17:38:13 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Drew Jaynes
e731028303
Fix syntax for single- and multi-line comments in root-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29205
git-svn-id: http://core.svn.wordpress.org/trunk@28989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:12:16 +00:00
Helen Hou-Sandí
b7445ec8a4
Media Grid Attachment Details modal UI improvements:
...
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.
Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.
props ericlewis, helen, melchoyce. see #28844 . fixes #28915 .
Built from https://develop.svn.wordpress.org/trunk@29204
git-svn-id: http://core.svn.wordpress.org/trunk@28988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 03:55:15 +00:00
Andrew Ozz
95735cf298
TinyMCE:
...
- Update to 4.1.2, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt
- Update the tests to 4.1.2.
Fixes #28576 .
Built from https://develop.svn.wordpress.org/trunk@29203
git-svn-id: http://core.svn.wordpress.org/trunk@28987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 00:59:16 +00:00
Andrew Ozz
d74a2a9f07
TinyMCE wpView: prevent fatal (security) errors when trying to access iframe.contentWindow in pausePlayers() and unsetPlayers(). See #28905 .
...
Built from https://develop.svn.wordpress.org/trunk@29202
git-svn-id: http://core.svn.wordpress.org/trunk@28986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 00:50:15 +00:00
Scott Taylor
d395142fb9
In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
...
Props joedolson.
Fixes #28853 .
Built from https://develop.svn.wordpress.org/trunk@29201
git-svn-id: http://core.svn.wordpress.org/trunk@28985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:50:14 +00:00
Scott Taylor
8496504f59
Properly set `$subdomain_error` to `false` when applicable in `ms_subdomain_constants()`. This was previously untestable because it used static vars: use globals instead.
...
Adds unit test.
Fixes #28697 .
Built from https://develop.svn.wordpress.org/trunk@29200
git-svn-id: http://core.svn.wordpress.org/trunk@28984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:35:14 +00:00
Drew Jaynes
9ae01ba532
Fix a typo in the `@access` tag for `WP_List_Table::__get()`.
...
Props joehoyle.
Fixes #28925 . See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29199
git-svn-id: http://core.svn.wordpress.org/trunk@28983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:13:14 +00:00
Scott Taylor
c2a7544cd6
Make sure that the `ready` event only fires once for relevant MCE views that are sandbox'd in iframes. Move some editor callbacks to `initialize`.
...
Props avryl.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29198
git-svn-id: http://core.svn.wordpress.org/trunk@28982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:10:16 +00:00
Scott Taylor
1292ee0151
Make `has_shortcode()` recursive/work for nested shortcodes.
...
Adds unit test.
Props katzwebdesign.
Fixes #26343 .
Built from https://develop.svn.wordpress.org/trunk@29197
git-svn-id: http://core.svn.wordpress.org/trunk@28981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:05:17 +00:00
Scott Taylor
cf3deb2ecb
Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident.
...
Adds a unit test.
Props dlh.
Fixes #19205 .
Built from https://develop.svn.wordpress.org/trunk@29196
git-svn-id: http://core.svn.wordpress.org/trunk@28980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 21:52:15 +00:00
Andrew Ozz
1637f1617f
TinyMCE: fix `aligncenter` for html5-captions, props obenland, fixes #28681 .
...
Built from https://develop.svn.wordpress.org/trunk@29195
git-svn-id: http://core.svn.wordpress.org/trunk@28979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 21:28:16 +00:00
Scott Taylor
e75d42daff
Cleanup after [29179]:
...
* Remove `wp.media.mixin.pauseAllPlayers()` - was only ever intended to be used in MCE views, reaches too far into global scope. Rendered irrelevant since [28364].
* Remove `wp.media.mixin.pausePlayers()` - added in [28364]. MCE views no longer keep track of player instances and call mixin methods, they refer to their child iframes and call MEjs methods on the iframe's `window.mejs.players`.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29194
git-svn-id: http://core.svn.wordpress.org/trunk@28978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 19:36:14 +00:00
Scott Taylor
69986d87a7
Cleanup after [29179]:
...
Don't attach nodes to the view instance and check if the iframe still exists before resizing.
Props avryl.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29193
git-svn-id: http://core.svn.wordpress.org/trunk@28977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 19:32:16 +00:00
Andrew Ozz
100e5ca40b
Autosave: always expose the `wp.autosave.local` methods, fixes #28924 .
...
Built from https://develop.svn.wordpress.org/trunk@29192
git-svn-id: http://core.svn.wordpress.org/trunk@28976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 18:34:16 +00:00
Scott Taylor
cd497224a3
Cleanup after [29179]:
...
* Pause players when media is edited via modal
* Remove players on unind
* Account for failure when an empty node is passed to an `mce.view.View`
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29191
git-svn-id: http://core.svn.wordpress.org/trunk@28975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 18:19:14 +00:00
Andrew Ozz
7f7c3fb54f
TinyMCE wpView: add noop() when returning early, fixes #28921
...
Built from https://develop.svn.wordpress.org/trunk@29190
git-svn-id: http://core.svn.wordpress.org/trunk@28974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 17:55:16 +00:00
Scott Taylor
75d3fe3e65
Cleanup after [29179]:
...
* Cleanup players when the editor is hidden - window scope is unique to each frame
* Add the editor body class to each iframe sandbox
* Remove unneeded code from `wp-mediaelement.js`
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29189
git-svn-id: http://core.svn.wordpress.org/trunk@28973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 16:14:14 +00:00
Andrew Nacin
4bf7cdd49b
DB schema change: Add comment_author_email(10) index.
...
props tellyworth, pento.
fixes #21435 .
Built from https://develop.svn.wordpress.org/trunk@29188
git-svn-id: http://core.svn.wordpress.org/trunk@28972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 15:54:16 +00:00
Scott Taylor
57e966100f
Cleanup after [29179]:
...
* `_WP_Editors::editor_settings()` no longer needs to load MEjs styles
* Make sure each identical shortcode with multiple instances also has an iframe sandbox for each instance
* For the time being, make audio and video shortcodes bypass the loading placeholder to avoid whiplash visually
Props avryl, wonderboymusic.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29187
git-svn-id: http://core.svn.wordpress.org/trunk@28971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 15:40:14 +00:00
Andrew Ozz
a97559bf57
Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328 .
...
Built from https://develop.svn.wordpress.org/trunk@29186
git-svn-id: http://core.svn.wordpress.org/trunk@28970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 04:06:16 +00:00
Andrew Ozz
e400129cd8
Editor scrolling: on setcontent, resize the editor after some delay to allow the browser to render the content. Props avryl, see #28328 .
...
Built from https://develop.svn.wordpress.org/trunk@29185
git-svn-id: http://core.svn.wordpress.org/trunk@28969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 02:30:15 +00:00
Andrew Ozz
5bef617d04
TinyMCE wpView: handle execCommand when the "fake caret" P is selected, props avryl, see #28595
...
Built from https://develop.svn.wordpress.org/trunk@29184
git-svn-id: http://core.svn.wordpress.org/trunk@28968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 02:19:15 +00:00
Andrew Ozz
c6afe2dd3e
TinyMCE wpView:
...
- Cast off commands targeted to a view except undo, redo, RemoveFormat and mceToggleFormat (bold, italic, etc.).
- Disable the link and unlink buttons when a view is selected.
Props avryl, see #28595
Built from https://develop.svn.wordpress.org/trunk@29183
git-svn-id: http://core.svn.wordpress.org/trunk@28967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 00:10:17 +00:00
Andrew Ozz
5f54195855
TinyMCE wpView: remove unused code, props avryl, see #28595
...
Built from https://develop.svn.wordpress.org/trunk@29182
git-svn-id: http://core.svn.wordpress.org/trunk@28966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 23:39:15 +00:00
Lance Willett
f2adf04025
Twenty Thirteen: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable `button` element rather than `h3` for the toggle element. Fixes #28293 , props rclations and obenland.
...
Built from https://develop.svn.wordpress.org/trunk@29181
git-svn-id: http://core.svn.wordpress.org/trunk@28965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 23:10:15 +00:00
Andrew Ozz
5ff77be200
Editor scrolling: also disable in IE < 9. See #28328 .
...
Built from https://develop.svn.wordpress.org/trunk@29180
git-svn-id: http://core.svn.wordpress.org/trunk@28964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 22:37:14 +00:00
Scott Taylor
93fdff3581
Simplify creation of audio, video, and playlist MCE views by placing them in iframe sandboxes.
...
Wins:
* Eliminates duplication of code between PHP and JS
* Views can load JS without messing with TinyMCE and scope
* MEjs doesn't break when it loads a file plugin-mode. This allows any file type the MEjs supports to play in MCE views.
* YouTube now works as the source for video.
* Users can still style the views, editor stylesheets are included in these sandboxes.
* Audio and Video URLs and `[embed]`s are no longer broken.
* Remove the crazy compat code necessary to determine what file types play in what browser.
* Remove unneeded Underscore templates.
* Remove the compat code for playlists.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29179
git-svn-id: http://core.svn.wordpress.org/trunk@28963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 22:18:14 +00:00
Scott Taylor
043715e8a4
Add a new AJAX action: `parse-media-shortcode`. This async call will replace JS rendering of audio/video/playlist shortcodes.
...
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29178
git-svn-id: http://core.svn.wordpress.org/trunk@28962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 22:08:14 +00:00
Scott Taylor
237b3a9344
`_WP_Editors::editor_settings()` should make use of `get_editor_stylesheets()`.
...
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29177
git-svn-id: http://core.svn.wordpress.org/trunk@28961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 22:01:14 +00:00
Scott Taylor
89d9bbd7f6
Make audio and video URLs/embed handlers work in `<iframe>`-sandbox'd MCE views.
...
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29176
git-svn-id: http://core.svn.wordpress.org/trunk@28960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 21:51:15 +00:00
Helen Hou-Sandí
b3e1b3d925
No-JS fallback for the Media Library grid view. props michalzuber. fixes #28830 , see #24716 .
...
Built from https://develop.svn.wordpress.org/trunk@29175
git-svn-id: http://core.svn.wordpress.org/trunk@28959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 20:45:15 +00:00
Lance Willett
f5fcb58404
Twenty Fourteen: optimize featured content lookup to reduce the number of queries for featured posts. Props Chouby and obenland, closes #26744 .
...
Built from https://develop.svn.wordpress.org/trunk@29174
git-svn-id: http://core.svn.wordpress.org/trunk@28958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 06:44:15 +00:00
Dominik Schilling
1ecb1f0e8b
Remove unused variable in `WP_Theme_Install_List_Table::install_theme_info()`. Unused since [26380].
...
props Corphi.
fixes #28749 .
Built from https://develop.svn.wordpress.org/trunk@29173
git-svn-id: http://core.svn.wordpress.org/trunk@28957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 20:28:15 +00:00
Dominik Schilling
e45cc8b5e2
Fix wrong indentation in [29136].
...
Built from https://develop.svn.wordpress.org/trunk@29172
git-svn-id: http://core.svn.wordpress.org/trunk@28956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 20:09:14 +00:00
Dominik Schilling
d8ffbb19fc
Remove `plugin_install_details_link` filter, which was added in [29047].
...
see #28785 .
Built from https://develop.svn.wordpress.org/trunk@29171
git-svn-id: http://core.svn.wordpress.org/trunk@28955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 19:50:14 +00:00
Dominik Schilling
57c914f75a
Customizer: Add meta capability `customize` which is mapped to `edit_theme_options`.
...
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.
props westonruter, nacin.
fixes #28605 .
Built from https://develop.svn.wordpress.org/trunk@29170
git-svn-id: http://core.svn.wordpress.org/trunk@28954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 19:01:16 +00:00
Lance Willett
e90f45e031
Twenty Fourteen: pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@29169
git-svn-id: http://core.svn.wordpress.org/trunk@28953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:49:15 +00:00
Lance Willett
22997677e0
Twenty Fourteen: improve styles for media "play" button. Props iamtakashi, closes #26469 .
...
Built from https://develop.svn.wordpress.org/trunk@29168
git-svn-id: http://core.svn.wordpress.org/trunk@28952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:48:15 +00:00
Lance Willett
65c6477bc3
Twenty Fourteen: RTL display adjustment for Custom Header, props yoavf. Fixes #28670 .
...
Built from https://develop.svn.wordpress.org/trunk@29167
git-svn-id: http://core.svn.wordpress.org/trunk@28951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:41:15 +00:00
Scott Taylor
c3b068a599
Missed one: `WP_MS_Sites_List_Table::display_rows()` must be `public`.
...
Props extendwings.
Fixes #28894 .
Built from https://develop.svn.wordpress.org/trunk@29166
git-svn-id: http://core.svn.wordpress.org/trunk@28950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 15:42:15 +00:00
Drew Jaynes
3665b5a1a1
Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29165
git-svn-id: http://core.svn.wordpress.org/trunk@28949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 01:12:14 +00:00
Drew Jaynes
f1b19b24f3
Inline documentation cleanup for 4.0 audit.
...
Added in [28652]:
* Various phpDoc improvements for `wp_embed_handler_youtube()`
* Adds `@see` reference to `wp_embed_handler_youtube()` in 'wp_embed_handler_youtube' filter docs
Added in [29029]:
* s/post_id/post ID in `@return` description for `attachment_url_to_postid()`
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29164
git-svn-id: http://core.svn.wordpress.org/trunk@28948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 01:07:15 +00:00
Drew Jaynes
c5a59037f1
Inline documentation cleanup for 4.0 audit.
...
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29163
git-svn-id: http://core.svn.wordpress.org/trunk@28947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 01:02:15 +00:00
Drew Jaynes
c00e3d9a46
Fill out inline documentation for the `__call()` magic method added to the `WP_Comment_Query` class in [28519].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29162
git-svn-id: http://core.svn.wordpress.org/trunk@28946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:48:14 +00:00
Drew Jaynes
5f87736bc4
Fill out inline documentation for the `__call()` magic method added to the `wp_xmlrpc_server` class in [28515].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29161
git-svn-id: http://core.svn.wordpress.org/trunk@28945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:46:15 +00:00
Drew Jaynes
a20e839eaf
Inline documentation cleanup for 4.0 audit.
...
Document the first parameter, `$time`, in the 'oembed_ttl' filter, added in [28972].
See #14759 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29160
git-svn-id: http://core.svn.wordpress.org/trunk@28944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:44:14 +00:00
Drew Jaynes
2c9c48c87b
Inline documentation cleanup for 4.0 audit.
...
phpDoc tweaks for methods, properties, and filters added in [29051]:
* `WP_Customize_Widgets::is_widget_rendered()` method
* `WP_Customize_Widgets::is_sidebar_rendered()` method
See #27993 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29159
git-svn-id: http://core.svn.wordpress.org/trunk@28943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:42:15 +00:00
Drew Jaynes
20ce795ff2
Inline documentation cleanup for 4.0 audit.
...
phpDoc tweaks for methods added in [28861]:
* `WP_Customize_Panel` constructor method
* `WP_Customize_Panel::render()` method
See #27406 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29158
git-svn-id: http://core.svn.wordpress.org/trunk@28942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:40:15 +00:00