Commit Graph

20868 Commits

Author SHA1 Message Date
Andrew Ozz d03333735f Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs.
Props webaware, joemcgill, azaozz.
Fixes #35045 and #35102 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36121


git-svn-id: http://core.svn.wordpress.org/trunk@36087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 01:04:27 +00:00
Andrew Ozz 597bbf0318 Responsive images: add compatibility for versions < 2.7 when the full image path was stored in the metadata. Introduces `_wp_get_attachment_relative_path()` and uses it in `wp_get_attachment_url()`.
Props dd32, SergeyBiryukov.
Fixes #35106 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36120


git-svn-id: http://core.svn.wordpress.org/trunk@36086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 00:06:28 +00:00
Aaron Jorbin 09688bd59c Ensure only approved comments trigger post author notifications
Posts that are trashed shouldn't trigger post author notifications.  Adds unit tests to enforce this.

Props scottbrownconsulting, peterwilsoncc, swissspidy
Fixes #35006


Built from https://develop.svn.wordpress.org/trunk@36119


git-svn-id: http://core.svn.wordpress.org/trunk@36085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-29 17:54:28 +00:00
Dion Hulse f106974374 Tests: After [36100] use an object style which is compatible with PHP5 `get_object_vars()`.
See #35058.

Built from https://develop.svn.wordpress.org/trunk@36117


git-svn-id: http://core.svn.wordpress.org/trunk@36083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-29 05:44:25 +00:00
Gary Pendergast d48c98a30b Tests: When testing the `utf8mb4` charset, ensure that the current MySQL server has `utf8mb4` support.
See #35249.


Built from https://develop.svn.wordpress.org/trunk@36116


git-svn-id: http://core.svn.wordpress.org/trunk@36082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-29 04:40:27 +00:00
Rachel Baker a828b700fc Comments: Return early from `wp_update_comment_count()` if there is not a valid post.
Props ambrosey, juanfra. 
Fixes #34977


Built from https://develop.svn.wordpress.org/trunk@36115


git-svn-id: http://core.svn.wordpress.org/trunk@36080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 22:58:28 +00:00
Drew Jaynes 23a6ee1af1 Docs: Hash notate properties and defaults for the benefit of `$args` parameter documentation for `WP_Customize_Control::__construct()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36114


git-svn-id: http://core.svn.wordpress.org/trunk@36079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 20:10:35 +00:00
Sergey Biryukov 5540c0b8db Import: Add a missing space to `post_exists()`.
The lack of space resulted in SQL error when searching for posts by content.

Props yetAnotherDaniel, johnbillion.
Fixes #35246.
Built from https://develop.svn.wordpress.org/trunk@36113


git-svn-id: http://core.svn.wordpress.org/trunk@36078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 19:07:28 +00:00
John Blackbourn 76c33b7e33 Themes: Add `singular` to the list of body classes when viewing a single post object.
Adds tests

Fixes #35164
Props danielpataki, johnbillion

Built from https://develop.svn.wordpress.org/trunk@36112


git-svn-id: http://core.svn.wordpress.org/trunk@36077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 17:21:29 +00:00
John Blackbourn d84621cc19 Docs: Correct a funky docblock in `funky_javascript_fix()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36111


git-svn-id: http://core.svn.wordpress.org/trunk@36076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 17:18:30 +00:00
Andrew Ozz 698b825760 Responsive images: when creating `srcset` do not exclude the image size which is in the `src` attribute even when it is larger than `max_srcset_image_width`.
Props joemcgill.
Fixes #35108 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36110


git-svn-id: http://core.svn.wordpress.org/trunk@36075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 02:29:28 +00:00
Boone Gorges eefe6b0779 Force non-public taxonomies to have a query_var of `false`.
[35333] implemented `public=false` for taxonomies. The implementation prevented
non-public taxonomies from having their archives accessed via query_var during
a normal request. But it didn't prevent non-public taxonomies from registering
their query vars in the `$wp_taxonomies` global. The latter implementation
details causes problems specifically when a taxonomy is registered with
`query_var=true`; for public taxonomies, `register_taxonomy()` translates this
into a query_var equivalent to the taxonomy name, but in the case of non-public
taxonomies, the query_var was set to the boolean itself. The boolean then
causes problems when using non-strict comparison to filter taxonomy objects by
query_var, as when using `get_taxonomies()`.

This changeset addresses the issue by forcing the query_var property of
non-public taxonomies to `false`.

Fixes #35089.
Built from https://develop.svn.wordpress.org/trunk@36108


git-svn-id: http://core.svn.wordpress.org/trunk@36073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-27 16:41:27 +00:00
Sergey Biryukov 20594e4ecc Docs: Improve documentation for `wp_admin_css_color()`.
Props kiranpotphode.
Fixes #34857.
Built from https://develop.svn.wordpress.org/trunk@36107


git-svn-id: http://core.svn.wordpress.org/trunk@36072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-27 16:32:29 +00:00
Sergey Biryukov b0b561517d Docs: Fix typo in a comment in `wp_rand()`.
Props boluda.
Fixes #35228.
Built from https://develop.svn.wordpress.org/trunk@36102


git-svn-id: http://core.svn.wordpress.org/trunk@36067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 11:07:28 +00:00
Dion Hulse 85718ebf9a Allow `map_deep()` to work with object properties containing a reference. Restores the previous behaviour of `stripslashes_deep()`.
Props jeff@pyebrook.com, swissspidy.
See #22300, [35252].
Fixes #35058.

Built from https://develop.svn.wordpress.org/trunk@36100


git-svn-id: http://core.svn.wordpress.org/trunk@36065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 05:22:26 +00:00
Dion Hulse 484f118eec Tests: Use the correct URL in some shortcode tests.
Built from https://develop.svn.wordpress.org/trunk@36099


git-svn-id: http://core.svn.wordpress.org/trunk@36064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:51:26 +00:00
Dion Hulse 2038a29352 Shortcodes: `=` is a reserved character in shortcode names, mark it as such.
This allows for shortcodes such as `[shortcode=attribute]` to work, which while never intentionally supported were widely used in the pre-shortcode days.

Props aaroncampbell.
Fixes #34939 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36097


git-svn-id: http://core.svn.wordpress.org/trunk@36062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:46:28 +00:00
Dion Hulse 67c5150ba6 Canonical: Output correct canonical links for paged posts when not using pretty permalinks.
Props peterwilsoncc.
Fixes #34890

Built from https://develop.svn.wordpress.org/trunk@36096


git-svn-id: http://core.svn.wordpress.org/trunk@36061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:28:26 +00:00
Dion Hulse 1d19b930fc Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive.
Props kucrut.
Fixes #34449 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36095


git-svn-id: http://core.svn.wordpress.org/trunk@36060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:05:25 +00:00
Dion Hulse d5d401ad10 Pages: `get_page_uri()` should return the URI at which the resource being accessed is available at, this may include non-'publish' status posts.
Reverts [34001] and fixes the original issue in #15963 - avoiding a PHP Notice for when the post doesn't exist.

Props tharsheblows.
See #15963.
Fixes #35084.

Built from https://develop.svn.wordpress.org/trunk@36094


git-svn-id: http://core.svn.wordpress.org/trunk@36059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 03:46:28 +00:00
Sergey Biryukov 63cc66469b Toolbar: In Comments link, replace title attribute containing the number of pending comments with a screen reader text.
Props slushman, rachelbaker.
Fixes #34895.
Built from https://develop.svn.wordpress.org/trunk@36093


git-svn-id: http://core.svn.wordpress.org/trunk@36058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 01:40:27 +00:00
Sergey Biryukov 7270205975 Remove redundant title attribute from `wp_star_rating()`. Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.
Built from https://develop.svn.wordpress.org/trunk@36092


git-svn-id: http://core.svn.wordpress.org/trunk@36057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:48:27 +00:00
Sergey Biryukov 7d9d7f2df4 Docs: Clarify that `get_post_types()` accepts `'not'` as its `$operator` parameter.
Props barryceelen.
Fixes #35225.
Built from https://develop.svn.wordpress.org/trunk@36091


git-svn-id: http://core.svn.wordpress.org/trunk@36056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:38:25 +00:00
Sergey Biryukov b742304f13 Docs: Clarify that `wp_filter_object_list()` accepts `'not'` as its `$operator` parameter.
Props barryceelen.
See #35225.
Built from https://develop.svn.wordpress.org/trunk@36090


git-svn-id: http://core.svn.wordpress.org/trunk@36055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:37:26 +00:00
Aaron Jorbin 94aac7055c Help Tab Order should be based on the Priority Argument
[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.

Props meitar,  swissspidy, jorbin
Fixes #35215. See #33941.

Built from https://develop.svn.wordpress.org/trunk@36089


git-svn-id: http://core.svn.wordpress.org/trunk@36054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 22:44:27 +00:00
Sergey Biryukov 2328667dc9 Theme Editor: Break `$wp_file_descriptions` array into sections and reorder for consistency and readability.
Props ramiy.
Fixes #35223.
Built from https://develop.svn.wordpress.org/trunk@36088


git-svn-id: http://core.svn.wordpress.org/trunk@36053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 21:12:26 +00:00
Sergey Biryukov 11b89a88a9 Theme Editor: Add `taxonomy.php`, `home.php`, `front-page.php`, `date.php`, and `singular.php` to file descriptions.
Props ramiy.
See #35223.
Built from https://develop.svn.wordpress.org/trunk@36087


git-svn-id: http://core.svn.wordpress.org/trunk@36052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 21:05:25 +00:00
Sergey Biryukov d9d21cf3ff Docs: Correct `@return` type for `rest_parse_date()`.
Props TimothyBlynJacobs.
Fixes #35224.
Built from https://develop.svn.wordpress.org/trunk@36086


git-svn-id: http://core.svn.wordpress.org/trunk@36051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 20:41:26 +00:00
Sergey Biryukov 8009f97f79 Docs: Correct `@return` type for `count_user_posts()`.
Props nofearinc.
Fixes #35222.
Built from https://develop.svn.wordpress.org/trunk@36085


git-svn-id: http://core.svn.wordpress.org/trunk@36050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 20:18:27 +00:00
Gary Pendergast f9bba421b5 User: Don't continue checking a password reset key, if the hash is empty.
An empty reset key hash will never be valid, so we can skip seeing if it can be used to validate the given key, and return a failure early.

This fixes a warning in the unit tests under HHVM.

See #33926.



Built from https://develop.svn.wordpress.org/trunk@36084


git-svn-id: http://core.svn.wordpress.org/trunk@36049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-24 02:49:26 +00:00
Gary Pendergast bd1d11b3cf Upgrade PHPMailer from 5.2.10 to 5.2.14.
The full list of changes is available here: https://github.com/PHPMailer/PHPMailer/compare/v5.2.10...v5.2.14

Fixes #35212 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36083


git-svn-id: http://core.svn.wordpress.org/trunk@36048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-24 01:59:26 +00:00
Konstantin Obenland 6c54bf4dcb Menus: Bring back line break between menu items.
While removing line breaks was great for all use cases except justified menu
items, it broke menus with justified menu items.
Reverts [34321].

Props wp-architect.
Fixes #35107.


Built from https://develop.svn.wordpress.org/trunk@36081


git-svn-id: http://core.svn.wordpress.org/trunk@36046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-24 00:21:27 +00:00
Konstantin Obenland 8c72912432 Taxonomy: Pass object ids to delete_* actions.
Allows for more targeted updates to affected posts in callbacks.
Disambiguates `$objects` variable and amends unit tests.

Fixes #35213.

Built from https://develop.svn.wordpress.org/trunk@36080


git-svn-id: http://core.svn.wordpress.org/trunk@36045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 23:44:26 +00:00
Boone Gorges 9e0f434726 Improve post-filter sanitization of excluded terms in `get_adjacent_post()`.
See [36078], #35211.
Built from https://develop.svn.wordpress.org/trunk@36079


git-svn-id: http://core.svn.wordpress.org/trunk@36044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 20:15:25 +00:00
Boone Gorges 753243a6f7 Move excluded_terms filter in `get_adjacent_post()`.
The filter was added in 4.4 [34528] #9571, but in a place where it could not
affect the adjacent post query.

Fixes #35211.
Built from https://develop.svn.wordpress.org/trunk@36078


git-svn-id: http://core.svn.wordpress.org/trunk@36043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 19:57:27 +00:00
Boone Gorges 7d734dd91f Move `get_adjacent_post()` tests to their own file.
See #35211.

Built from https://develop.svn.wordpress.org/trunk@36077


git-svn-id: http://core.svn.wordpress.org/trunk@36042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 19:39:27 +00:00
Boone Gorges 303efba1ec Respect `$_wp_suspend_cache_invalidation` in `clean_object_term_cache()`.
Props mwidmann.
Fixes #35208.
Built from https://develop.svn.wordpress.org/trunk@36076


git-svn-id: http://core.svn.wordpress.org/trunk@36041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 19:29:28 +00:00
Sergey Biryukov 421604cb67 Twenty Fifteen: Add left margin for lists inside blockquotes in `editor-style.css`.
Props diddledan.
Fixes #33380.
Built from https://develop.svn.wordpress.org/trunk@36075


git-svn-id: http://core.svn.wordpress.org/trunk@36040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 13:10:28 +00:00
John Blackbourn 0003a004db Docs: Miscellaneous docblock code quality tweaks.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36074


git-svn-id: http://core.svn.wordpress.org/trunk@36039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 07:53:26 +00:00
John Blackbourn 7e43e20436 Docs: `@see != @since`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36073


git-svn-id: http://core.svn.wordpress.org/trunk@36038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 07:13:26 +00:00
Drew Jaynes 5a69733045 Docs: Properly mark the optional `$redirect`, `$network_wide`, and `$silent` parameters as such in the DocBlock for `activate_plugin()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36072


git-svn-id: http://core.svn.wordpress.org/trunk@36037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 07:00:27 +00:00
Drew Jaynes 0a314eed32 Docs: Add missing `@since` and properly mark the optional `$type` parameter as such in the DocBlock for the deprecated `get_others_unpublished_posts()` function.
Introduced in [5707].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36071


git-svn-id: http://core.svn.wordpress.org/trunk@36036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 06:58:25 +00:00
Drew Jaynes ad64c0f2d7 Docs: Properly mark the `$exclude_zeros` parameter in the DocBlock for `get_editable_user_ids()` as optional.
Also fixes a couple of typos.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36070


git-svn-id: http://core.svn.wordpress.org/trunk@36035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 06:53:26 +00:00
John Blackbourn 1402c3d8b4 Docs: Miscellaneous docblock corrections.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36069


git-svn-id: http://core.svn.wordpress.org/trunk@36034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 06:31:27 +00:00
Dion Hulse 04bca9732b Users: When determining whether to show the reassign content option during user delete, don't rely upon `WP_Query` as it doesn't return all forms of content `wp_delete_user()` operates on.
This restores the reassign form when a user has a non-public post type or links assigned to them.

Props swissspidy & tharsheblows for initial patches.
Fixes #34993 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36068


git-svn-id: http://core.svn.wordpress.org/trunk@36033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 04:46:28 +00:00
Andrew Ozz e7b3d9cd11 Editor: remove the format_for_editor filter from `the_editor_content` after it runs as the next editor instance on the same page may not need it.
Props marcochiesi, azaozz.
Fixes #28403.
Built from https://develop.svn.wordpress.org/trunk@36062


git-svn-id: http://core.svn.wordpress.org/trunk@36027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-22 22:39:31 +00:00
John Blackbourn c1976fff71 Revert [35804]. This change has unintended side effects, notably that media URLs in the admin area now unexpectedly use the `https` scheme. A more comprehensive approach will be taken in 4.5.
See #13941, #35120

Built from https://develop.svn.wordpress.org/trunk@36061


git-svn-id: http://core.svn.wordpress.org/trunk@36026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-22 13:02:29 +00:00
Gary Pendergast 324cbf5d7e Embeds: Don't show embed discovery link on a static front page.
There's currently no iframe content being generated for a static front page. Giving out a link to that isn't an ideal user experience.

Props peterwilsoncc.

Fixes #35194 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36059


git-svn-id: http://core.svn.wordpress.org/trunk@36024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-22 10:50:31 +00:00
Boone Gorges e638f72a9a Order terms by 'name' when populating object term cache.
[34217] removed the `ORDER BY` clause from `update_object_term_cache()`, for
improved performance. But this proved to cause problems in cases where users
were expecting the results of `get_the_terms()` to be ordered by 'name'. Let's
revert the change for the time being, and look into more disciplined ordering
in a future release.

Props afercia.
See #28922. Fixes #35180.
Built from https://develop.svn.wordpress.org/trunk@36056


git-svn-id: http://core.svn.wordpress.org/trunk@36021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-22 01:51:28 +00:00
Gary Pendergast 2f53c1ada2 Tests: Use the `default_storage_engine` MySQL option on newer MySQL versions.
In MySQL 5.5.3, `storage_engine` was deprecated in favour of `default_storage_engine`, and subsequently removed in MySQL 5.7. To avoid errors when running tests on MySQL 5.7, we need to switch between the options based on MySQL version.

Props skithund, jeremyfelt.

Fixes #34692.


Built from https://develop.svn.wordpress.org/trunk@36055


git-svn-id: http://core.svn.wordpress.org/trunk@36020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 22:27:25 +00:00
Drew Jaynes 79705d5cc1 Docs: Fix a typo in the 4.4.0 changlog entry in the `intermediate_image_sizes_advanced` hook doc.
Props morganestes.
Fixes #35190.

Built from https://develop.svn.wordpress.org/trunk@36054


git-svn-id: http://core.svn.wordpress.org/trunk@36019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 22:24:27 +00:00
Andrea Fercia dc31b503ec Accessibility: Remove the revisions limit title attribute from the Publish box.
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.
Built from https://develop.svn.wordpress.org/trunk@36053


git-svn-id: http://core.svn.wordpress.org/trunk@36018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 14:39:28 +00:00
John Blackbourn 779d639c85 Tests: Prevent role capability pollution in `Tests_Post_GetPostsByAuthorSql::test_user_has_access_only_to_private_posts_for_certain_post_types()`.
Built from https://develop.svn.wordpress.org/trunk@36050


git-svn-id: http://core.svn.wordpress.org/trunk@36015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 07:16:29 +00:00
John Blackbourn bfc3302852 Tests: Fix all the things.
See #30017, #32394

Built from https://develop.svn.wordpress.org/trunk@36049


git-svn-id: http://core.svn.wordpress.org/trunk@36014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 07:10:27 +00:00
John Blackbourn 405d5ba71d Query: Re-initialise any dynamically-added public query vars before running the public query vars test.
See #35115

Built from https://develop.svn.wordpress.org/trunk@36048


git-svn-id: http://core.svn.wordpress.org/trunk@36013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 07:00:28 +00:00
John Blackbourn 3fdd127ce2 Tests: Shave a second off the user capability tests by reusing its user fixtures.
See #30017, #32394

Built from https://develop.svn.wordpress.org/trunk@36047


git-svn-id: http://core.svn.wordpress.org/trunk@36012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 06:57:37 +00:00
John Blackbourn 45019c3467 Query: Introduce a unit test which will fail when new public query vars are introduced without also updating the test. This adds an extra layer of explicitness to introducing public query vars in order to avoid introducing unintentional clashes with URL query vars that are already in use.
See #35115 

Built from https://develop.svn.wordpress.org/trunk@36045


git-svn-id: http://core.svn.wordpress.org/trunk@36010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 05:49:28 +00:00
John Blackbourn d4eb85569b Login: Revert [34213] and [35897]. It has become apparent that there is a need for a separate function (and corresponding filter) which allows for the login form action URL to differ from the URL used to access the login form, so that plugins or implementations which change the login URL do not need to worry about handling the form submission at the same URL.
For now, we'll revert to the pre-4.4 behaviour of hard-coding the login form action URL as `wp-login.php` and look at implementing a separate function and corresponding filter in 4.5.

Props KrissieV, salcode, JPry
Fixes #34925
See #35103

Built from https://develop.svn.wordpress.org/trunk@36042


git-svn-id: http://core.svn.wordpress.org/trunk@36007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 03:23:29 +00:00
Boone Gorges 26caa329f2 Respect approval status when determining comment page count in `comments_template()`.
Since 4.4, when fetching the first page of comments and the 'newest' comments
are set to display first, `comments_template()` must perform arithmetic to
determine which comments to show. See #8071. This arithmetic requires the
total comment count for the current post, which is calculated with a separate
`WP_Comment_Query`. This secondary comment query did not properly account for
non-approved comment statuses; all unapproved comments should be part of the
comment count for admins, and individual users should have their own
unapproved comments included in the count. As a result, `comments_template()`
was, in some cases, being fooled into thinking that a post had fewer comments
available for pagination than it actually had, which resulted in empty pages
of comments.

We correct this problem by mirroring 'status' and 'include_unapproved' params
of the main comment query within the secondary query used to calculate
pagination.

Fixes #35068.
Built from https://develop.svn.wordpress.org/trunk@36040


git-svn-id: http://core.svn.wordpress.org/trunk@36005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 03:07:32 +00:00
John Blackbourn afc7f43ca0 Comments: When a comment is submitted, ensure the `user_ID` element in the array that's passed to the `preprocess_comment` filter gets populated.
Fixes #34997

Built from https://develop.svn.wordpress.org/trunk@36038


git-svn-id: http://core.svn.wordpress.org/trunk@36003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 02:47:26 +00:00
Gary Pendergast ba8b95cdbe Texturize: Transform `&` into `&#038;` in tag attributes.
[35709] was overly broad, and stopped transforming `&` characters within tag attributes. So that sites aren't generating invalid HTML, we need to restore this functionality, while continuing to not transform `&` within blocked tags.

Fixes #35008 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36036


git-svn-id: http://core.svn.wordpress.org/trunk@36001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 02:43:26 +00:00
Gary Pendergast dbf5d782ad Query: Remove `title` from the public query vars list.
[33706] added `title` as a public query var, but there's not really a practical need for this, and it interferes with any plugin that uses `title` as a query var for itself.

Props tyxla.

Fixes #35115 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36034


git-svn-id: http://core.svn.wordpress.org/trunk@35999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 00:43:27 +00:00
Drew Jaynes a28bfe8ba6 Docs: Add missing notations for the optional `$tab_index` and `$extended` parameters in the DocBlock for the deprecated `the_editor()` function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36033


git-svn-id: http://core.svn.wordpress.org/trunk@35998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-20 21:21:27 +00:00
Andrea Fercia 7849bb7d94 Accessibility: Remove title attributes from the updates links on the Plugin and Themes list tables.
Adds `aria-label` attributes on some links and on the "update nag" link. Adds translator comments.

Fixes #35167.
Built from https://develop.svn.wordpress.org/trunk@36032


git-svn-id: http://core.svn.wordpress.org/trunk@35997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-20 16:09:28 +00:00
Andrew Ozz 6e49a963b1 Responsive images: fix calculations when determining whether to include particular image file in `srcset`.
Props joemcgill.
Fixes #34955 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36031


git-svn-id: http://core.svn.wordpress.org/trunk@35996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-20 02:39:32 +00:00
Drew Jaynes 5399b2137f Docs: Add missing parameter and return notations to the DocBlock for the deprecated `get_usernumposts()` function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36030


git-svn-id: http://core.svn.wordpress.org/trunk@35995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 19:41:30 +00:00
Eric Lewis e844695e12 Docs: Add documentation to wp-blog-header.php.
Fixes #35161.

Built from https://develop.svn.wordpress.org/trunk@36029


git-svn-id: http://core.svn.wordpress.org/trunk@35994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 11:20:28 +00:00
Drew Jaynes 013d1178e5 Docs: Add missing parameter and return notations in the DocBlock for `get_profile()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36028


git-svn-id: http://core.svn.wordpress.org/trunk@35993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 09:04:26 +00:00
Drew Jaynes 543420158f Docs: Properly mark the `$classname` parameter as optional.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36027


git-svn-id: http://core.svn.wordpress.org/trunk@35992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 09:00:26 +00:00
Drew Jaynes eb158d65c7 Docs: Add missing parameter and return notations to the DocBlock for the deprecated `wp_specialchars()` function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36026


git-svn-id: http://core.svn.wordpress.org/trunk@35991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:58:25 +00:00
Drew Jaynes 57878dd1b9 Docs: Add missing parameter notations and descriptions in the DocBlock for `get_link()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36025


git-svn-id: http://core.svn.wordpress.org/trunk@35990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:54:26 +00:00
Drew Jaynes 932c91b766 Docs: Add missing parameter and return notations in the DocBlock for the deprecated `_nc()` function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36024


git-svn-id: http://core.svn.wordpress.org/trunk@35989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:48:27 +00:00
Drew Jaynes 7b1ac33dee Docs: Add a missing summary, parameter, and return descriptiosn to the DocBlock for the deprecated function, `get_linkrating()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36023


git-svn-id: http://core.svn.wordpress.org/trunk@35988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:23:26 +00:00
Drew Jaynes df0c1aa0ed Docs: Add a missing notation for the `$gmt_time` parameter in the DocBlock for `spawn_cron()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36022


git-svn-id: http://core.svn.wordpress.org/trunk@35987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:20:27 +00:00
Drew Jaynes decb25a8ae Docs: Add missing DocBlocks for `hash_hmac()` and `_hash_hmac()`.
Both will be ignored from parsing as and serve as compat functions for PHP's `hash_hmac()`.

Introduced in [18111].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36021


git-svn-id: http://core.svn.wordpress.org/trunk@35986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 05:11:27 +00:00
Drew Jaynes c10ec122ca Docs: Fix inline comment syntax in `_mb_strlen()`, an internal compat method for `mb_strlen()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36020


git-svn-id: http://core.svn.wordpress.org/trunk@35985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:59:33 +00:00
Drew Jaynes 87786b4373 Docs: Add missing DocBlocks for `mb_strlen()` and `_mb_strlen()`.
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_strlen()`, which is not enabled by default.

Introduced in [32114].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36019


git-svn-id: http://core.svn.wordpress.org/trunk@35984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:56:29 +00:00
Drew Jaynes 9e04750fc4 Docs: Fix inline comment syntax in `_mb_substr()`, an internal compat method for `mb_substr()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36018


git-svn-id: http://core.svn.wordpress.org/trunk@35983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:50:28 +00:00
Drew Jaynes be6589730d Docs: Add missing DocBlocks for `mb_substr()` and `_mb_substr()`.
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_substr()`, which is not enabled by default.

Introduced in [17621].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36017


git-svn-id: http://core.svn.wordpress.org/trunk@35982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:47:28 +00:00
Andrea Fercia 67e1f55c4b Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen.
When JavaScript is off, the reorder menu item and Edit menu item links now use `aria-label`
attributes instead of title attributes.

Fixes #35134.
Built from https://develop.svn.wordpress.org/trunk@36016


git-svn-id: http://core.svn.wordpress.org/trunk@35981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 00:17:26 +00:00
Andrea Fercia 5787972a67 Accessibility: Remove title attributes from the Theme browser.
Also, adds translators comments and removes a no more used variable, see [27748].

Fixes #35140.
Built from https://develop.svn.wordpress.org/trunk@36015


git-svn-id: http://core.svn.wordpress.org/trunk@35980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 00:00:29 +00:00
Andrea Fercia f7f14d94f3 Accessibility: Improvements for the Authentication Check modal dialog "Close X".
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.
Built from https://develop.svn.wordpress.org/trunk@36014


git-svn-id: http://core.svn.wordpress.org/trunk@35979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:51:26 +00:00
Drew Jaynes 05e0d7c3c3 Docs: Add missing parameter and return descriptions to the DocBlocks for `_wp_object_name_sort_cb()` and `_wp_object_count_sort_cb()`, both `uasort()` callbacks.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36013


git-svn-id: http://core.svn.wordpress.org/trunk@35978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:38:26 +00:00
Drew Jaynes 9b89047bf2 Docs: Add a missing notation for the `$context` parameter in the DocBlock for `_nx_noop()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36012


git-svn-id: http://core.svn.wordpress.org/trunk@35977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:16:26 +00:00
Drew Jaynes 13bead9e58 Docs: Fix the syntax for the `get_previous_post_link()` DocBlock to ensure it's read and parsed as such instead of as a multi-line comment.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36011


git-svn-id: http://core.svn.wordpress.org/trunk@35976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:14:26 +00:00
Drew Jaynes f4af7643d8 Docs: Add a missing summary, description, and `@since` version to the DocBlock for `wp_redirect_admin_locations()`.
Introduced in [19880].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36010


git-svn-id: http://core.svn.wordpress.org/trunk@35975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:08:26 +00:00
Drew Jaynes 907e0ce6f1 Docs: Add a missing notation for the `$bookmark_id` parameter in the DocBlock for `clean_bookmark_cache()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36009


git-svn-id: http://core.svn.wordpress.org/trunk@35974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:01:28 +00:00
Boone Gorges 31db92d83e Add `current-cat-ancestor` class to ancestor items in `wp_list_categories()`.
Pairs nicely with `current-cat-parent`.

Props jrchamp, swisssipdy, ardathksheyna, wonderboymusic.
Fixes #10676.
Built from https://develop.svn.wordpress.org/trunk@36008


git-svn-id: http://core.svn.wordpress.org/trunk@35973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 18:38:25 +00:00
Aaron Jorbin 0eaedf734f Remove RDIO from oEmbed providers
RDIO is shutting down. https://www.rdio.com/farewell/

Props swissspidy
Fixes #35152


Built from https://develop.svn.wordpress.org/trunk@36007


git-svn-id: http://core.svn.wordpress.org/trunk@35972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 18:16:27 +00:00
Boone Gorges b2f4f73633 Ensure that `wp_list_categories()` supports comma-separated lists for 'exclude' and 'exclude_tree'.
[34696] introduced a regression whereby comma-separated values for 'exclude'
and 'exclude_tree' would be handled improperly when merging the two parameters,
resulting in category IDs being incorrectly dropped from the combined array.

Props gblsm, hnle.
Fixes #35156.
Built from https://develop.svn.wordpress.org/trunk@36005


git-svn-id: http://core.svn.wordpress.org/trunk@35970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 18:12:25 +00:00
Boone Gorges 5d46c03508 Ensure `get_terms()` results are unique when using 'meta_query'.
The introduction of 'meta_query' to `get_terms()` in 4.4 made it possible for
`get_terms()` to erroneously return duplicate results. To address the issue,
we add the `DISTINCT` keyword to the SQL query when a 'meta_query' parameter
has been provided.

Props @jadpm.
Fixes #35137.
Built from https://develop.svn.wordpress.org/trunk@36003


git-svn-id: http://core.svn.wordpress.org/trunk@35968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 17:44:25 +00:00
Sergey Biryukov 3f35196e48 Docs: Fix copy/paste error in `wp_remote_retrieve_cookies()` description.
Props mark8barnes.
Fixes #35157.
Built from https://develop.svn.wordpress.org/trunk@36002


git-svn-id: http://core.svn.wordpress.org/trunk@35967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 17:23:29 +00:00
Sergey Biryukov ff36a54824 Widgets: Add missing closing tag for spinner after [35317].
Props rabmalin.
Fixes #35150.
Built from https://develop.svn.wordpress.org/trunk@36001


git-svn-id: http://core.svn.wordpress.org/trunk@35966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 12:02:28 +00:00
Andrea Fercia 6fdd27a1d6 Accessibility: Remove the title attribute from the Featured Image postbox thumbnail.
The title attribute is now replaced with plain text in a `howto` paragraph, as done for example in the Tags postbox.
Adds an `aria-describedby` attribute on the thumbnail link to target the description.
Also, fixes the focus style on the featured image thumbnail.

Fixes #35076.
Built from https://develop.svn.wordpress.org/trunk@36000


git-svn-id: http://core.svn.wordpress.org/trunk@35965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 23:44:26 +00:00
Pascal Birchler a7e13d0af9 Editor: Correctly indent definition lists when switching from the visual to the text editor.
Props ocean90, katieburch.
Fixes #23299.
Built from https://develop.svn.wordpress.org/trunk@35999


git-svn-id: http://core.svn.wordpress.org/trunk@35964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 23:06:25 +00:00
Andrea Fercia e8b900d9f5 Accessibility: Remove title attributes from the Link Manager screen.
Title attributes are now replaced with `aria-label` where appropriate.
Also fixes some typos in the DocBlocks.

Fixes #35135.
Built from https://develop.svn.wordpress.org/trunk@35998


git-svn-id: http://core.svn.wordpress.org/trunk@35963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 22:53:28 +00:00
Pascal Birchler 333bdb535a Remove unused variables after [35995] and [35996].
See #34439.
Built from https://develop.svn.wordpress.org/trunk@35997


git-svn-id: http://core.svn.wordpress.org/trunk@35962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:41:27 +00:00
Pascal Birchler 51bb4db622 Network Admin: Remove the list of files which will be deleted when deleting a theme.
Fixes #34439.
Built from https://develop.svn.wordpress.org/trunk@35996


git-svn-id: http://core.svn.wordpress.org/trunk@35961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:35:26 +00:00
Pascal Birchler 740d197731 Plugins: Remove the list of files which will be deleted when uninstalling a plugin.
See #34439.
Built from https://develop.svn.wordpress.org/trunk@35995


git-svn-id: http://core.svn.wordpress.org/trunk@35960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:31:27 +00:00
Pascal Birchler 7b6c596e92 In `WP::handle_404()`, make sure `$wp_query->post` is a `WP_Post` object before cloning it.
Props igmoweb for initial patch.
See #35013.
Built from https://develop.svn.wordpress.org/trunk@35994


git-svn-id: http://core.svn.wordpress.org/trunk@35959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:13:29 +00:00
Drew Jaynes 9572878fab Docs: Add missing parameter notations to the DocBlock for `get_author_posts_url()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35993


git-svn-id: http://core.svn.wordpress.org/trunk@35958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:30:43 +00:00
Drew Jaynes 76cc768e90 Docs: Add a better summary, missing `@since` version, parameter and return descriptions to the DocBlock for `_get_widget_id_base()`.
Introduced in [11484].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35992


git-svn-id: http://core.svn.wordpress.org/trunk@35957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:27:28 +00:00
Drew Jaynes 94575687b9 Docs: Add a missing summary, `@since` version, and parameter descriptions in the DocBlock for `_register_widget_form_callback()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35991


git-svn-id: http://core.svn.wordpress.org/trunk@35956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:23:26 +00:00
Drew Jaynes c13824b1c0 Docs: Fix syntax for marking parameters optional in the DocBlock for `is_active_widget()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35990


git-svn-id: http://core.svn.wordpress.org/trunk@35955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:19:26 +00:00
Drew Jaynes 9de8a1466a Docs: Add a missing summary, `@since` version, and parameter descriptions to the DocBlock for `_register_widget_update_callback()`.
Introduced in [10798].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35989


git-svn-id: http://core.svn.wordpress.org/trunk@35954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:16:26 +00:00
Boone Gorges 6d4bc4d88e Better focus in tag cloud tests.
We should avoid testing complete markup strings, unless we are specifically
testing for the format of the markup.

Fixes #35138.
Built from https://develop.svn.wordpress.org/trunk@35988


git-svn-id: http://core.svn.wordpress.org/trunk@35953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:12:30 +00:00
Boone Gorges 61679499b1 More focused test for post_type in tag cloud links.
We should not be testing the entire tag cloud markup, as it leads to collateral
damage wheneven `wp_generate_tag_cloud()` is touched. See [35984].

See #25566, #35138.
Built from https://develop.svn.wordpress.org/trunk@35987


git-svn-id: http://core.svn.wordpress.org/trunk@35952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:56:26 +00:00
Drew Jaynes 28412d2ef2 Docs: Add missing parameter and return descriptions to the DocBlock for `_wp_get_user_contactmethods()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35986


git-svn-id: http://core.svn.wordpress.org/trunk@35951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:41:27 +00:00
Drew Jaynes b6281e857f Docs: Add a missing summary and `@since` version to the DocBlock for `_maybe_update_core()`.
Introduced in [10583].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35985


git-svn-id: http://core.svn.wordpress.org/trunk@35950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:38:26 +00:00
Boone Gorges 20651de171 Introduce 'tag-link-position-x' class to tag cloud links.
The new class describes the cardinal position of a link in the cloud, allowing
more fine-grained CSS and JS targeting.

Props Mte90, chmac.
Fixes #5172.
Built from https://develop.svn.wordpress.org/trunk@35984


git-svn-id: http://core.svn.wordpress.org/trunk@35949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:27:28 +00:00
Andrea Fercia 2cc4ca6875 Accessibility: Improvements for the "Send Trackbacks" postbox.
Adds an `aria-describedby` attribute targeting the input field description and styles the description as a... description.

Fixes #35123.
Built from https://develop.svn.wordpress.org/trunk@35983


git-svn-id: http://core.svn.wordpress.org/trunk@35948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:37:26 +00:00
Drew Jaynes d5a9811f02 Docs: Add a missing summary, parameter, and return notations to the DocBlock for `strip_shortcode_tag()`.
Introduced in [18952].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35982


git-svn-id: http://core.svn.wordpress.org/trunk@35947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:23:26 +00:00
Drew Jaynes 81abb11839 Docs: Add a missing notation for the `$args` parameter in the DocBlock for `wp_get_post_revisions()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35981


git-svn-id: http://core.svn.wordpress.org/trunk@35946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:18:26 +00:00
Drew Jaynes 7b19006ce1 Docs: Add missing parameter and return notations to the DocBlock for `_wp_sanitize_utf8_in_redirect()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35980


git-svn-id: http://core.svn.wordpress.org/trunk@35945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:15:27 +00:00
Drew Jaynes bc4a65a036 Docs: Clarify the summary and add missing parameter notations to the DocBlock for `_wp_delete_tax_menu_item()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35979


git-svn-id: http://core.svn.wordpress.org/trunk@35944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:11:25 +00:00
Sergey Biryukov 20d779ea8c Widgets: Remove extra quotes from widget title in `WP_Widget_RSS`, accidentally added in [33814].
Props ShinichiN.
Fixes #34978 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35978


git-svn-id: http://core.svn.wordpress.org/trunk@35943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 22:35:27 +00:00
Andrea Fercia f83c787887 Accessibility: Correctly associate the search input label in the new Themes favorites tab introduced in [35527].
Fixes #35122.
Built from https://develop.svn.wordpress.org/trunk@35977


git-svn-id: http://core.svn.wordpress.org/trunk@35942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 22:30:27 +00:00
Pascal Birchler fa9b71e423 Docs: Document the default value for the `$validate` parameter in the `validate_current_theme` hook docs.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35976


git-svn-id: http://core.svn.wordpress.org/trunk@35941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 20:10:25 +00:00
Pascal Birchler b6c660c38f Docs: Clarify the return value for `wp_create_categories()`.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35975


git-svn-id: http://core.svn.wordpress.org/trunk@35940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:59:27 +00:00
Pascal Birchler 1b86ccd006 Docs: Correct a parameter name for the `press_this_redirect_in_parent` filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35974


git-svn-id: http://core.svn.wordpress.org/trunk@35939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:43:26 +00:00
Pascal Birchler 624cb1445d Docs: Correct a parameter name for the `force_filtered_html_on_import` filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35973


git-svn-id: http://core.svn.wordpress.org/trunk@35938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:40:26 +00:00
Pascal Birchler 4e6e728703 Docs: Correct a parameter name for the `validate_current_theme` filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35972


git-svn-id: http://core.svn.wordpress.org/trunk@35937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:36:28 +00:00
Pascal Birchler 4a6d77c8e5 Docs: Correct a parameter name for the `allow_subdirectory_install` filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35971


git-svn-id: http://core.svn.wordpress.org/trunk@35936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:32:26 +00:00
Pascal Birchler 2e35e20010 Docs: Correct a parameter name for the `do_mu_upgrade` filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35970


git-svn-id: http://core.svn.wordpress.org/trunk@35935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:30:28 +00:00
John Blackbourn 26dfc6159f Correct a parameter name for the `allow_password_reset` filter so its entry on developer.wordpress.org displays correctly.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35969


git-svn-id: http://core.svn.wordpress.org/trunk@35934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:20:26 +00:00
Drew Jaynes 3cba9d7f61 Docs: Add missing parameter descriptions to the DocBlock for `WP_Query::set_found_posts()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35968


git-svn-id: http://core.svn.wordpress.org/trunk@35933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 18:11:26 +00:00
Drew Jaynes ee0335e930 Docs: Add a missing summary to the DocBlock for `WP_Locale::rtl_src_admin_notice()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35967


git-svn-id: http://core.svn.wordpress.org/trunk@35932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 18:08:26 +00:00
Drew Jaynes c9a11ae9f2 Docs: Mark the `upgrade_XX()` functions to be ignored from parsing for the Code Reference.
There is no great value in generating reference pages for these funcitons as they explicitly serve a core-only purpose.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35966


git-svn-id: http://core.svn.wordpress.org/trunk@35931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:59:27 +00:00
Drew Jaynes 36367e7f6e Docs: Add missing DocBlocks, including summaries and `@since` versions, to the `__construct()` and `init()` methods in `WP_Scripts`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35965


git-svn-id: http://core.svn.wordpress.org/trunk@35930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:48:27 +00:00
Drew Jaynes 25eca6974e Docs: Add a missing summary, `@since` version, and parameter descriptions to the DocBlock for `wp_xmlrpc_server::pingback_error()`.
Introduced in [23329]. Also corrects return descriptions for two deprecated methods.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35964


git-svn-id: http://core.svn.wordpress.org/trunk@35929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:38:27 +00:00
Drew Jaynes 7614bd71d3 Docs: Add a missing summary, `@since` version, and parameter descriptions to the DocBlock for `wp_xmlrpc_server::add_enclosure_if_new()`.
Introduced in [10383].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35963


git-svn-id: http://core.svn.wordpress.org/trunk@35928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:32:28 +00:00
Drew Jaynes 92dd7b7447 Docs: Add missing notations for the unused `$args` parameter in the `blogger_getTemplate()` and `blogger_setTemplate()` methods in `wp_xmlrpc_server`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35962


git-svn-id: http://core.svn.wordpress.org/trunk@35927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:26:28 +00:00
Drew Jaynes d057c51893 Docs: Add missing property and method summaries in DocBlocks for `Walker_PageDropdown`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35961


git-svn-id: http://core.svn.wordpress.org/trunk@35926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 16:36:28 +00:00
Sergey Biryukov ae37057114 KSES: Allow the `reversed` attribute for `<ol>`.
Props lancewillett.
Fixes #35079.
Built from https://develop.svn.wordpress.org/trunk@35960


git-svn-id: http://core.svn.wordpress.org/trunk@35924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 09:54:26 +00:00
Sergey Biryukov 6ffc7914f1 I18N: Add a unit test for `before_last_bar()`.
Props realloc.
Fixes #35073.
Built from https://develop.svn.wordpress.org/trunk@35959


git-svn-id: http://core.svn.wordpress.org/trunk@35923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 08:04:26 +00:00
Sergey Biryukov f9f77d86d8 Accessibility: Add missing label for the theme upload input.
See [11152] for plugins.

Props mercime.
Fixes #35113.
Built from https://develop.svn.wordpress.org/trunk@35958


git-svn-id: http://core.svn.wordpress.org/trunk@35922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 07:56:29 +00:00
Drew Jaynes fcd35518d9 Docs: Add a missing notation for the `$args` parameter in the DocBlock for `wp_xmlrpc_server::_multisite_getUsersBlogs()`.
Also adds a missing `@since` version. The method was introduced in [12852].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35957


git-svn-id: http://core.svn.wordpress.org/trunk@35921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:49:26 +00:00
Drew Jaynes 489023e001 Docs: Add a missing summary and `@since` version to the DocBlock for `wp_xmlrpc_server::serve_request()`.
Introduced in [11789].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35956


git-svn-id: http://core.svn.wordpress.org/trunk@35920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:43:26 +00:00
Drew Jaynes 4ced4fce3a Docs: Add missing summaries and `@since` versions to DocBlocks for the `_get_display_callback()`, `_get_update_callback()`, and `_get_form_callback()` methods in `WP_Widget`.
Introduced in [10764].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35955


git-svn-id: http://core.svn.wordpress.org/trunk@35919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:39:25 +00:00
Drew Jaynes 2dda796547 Docs: Add variadic markers to the optional `$object_id` parameter notation for `WP_User::has_cap()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35954


git-svn-id: http://core.svn.wordpress.org/trunk@35918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:32:28 +00:00
Andrea Fercia c69481a410 Accessibility: Remove title attributes from the Plugin Cards on the Plugin install screen.
Fixes #35050.
Built from https://develop.svn.wordpress.org/trunk@35953


git-svn-id: http://core.svn.wordpress.org/trunk@35917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:33:28 +00:00
Andrea Fercia 6dac60da98 Accessibility: add missing labels for Plugins and Themes checkboxes in the Updates screen.
Also, adds translator comments and improves readability.

Props SergeyBiryukov, afercia, oaron for the initial patch.
Fixes #34774.
Built from https://develop.svn.wordpress.org/trunk@35952


git-svn-id: http://core.svn.wordpress.org/trunk@35916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:18:30 +00:00
Sergey Biryukov c2fcab7d82 I18N: After [35884], remove `html_entity_decode()` for the thousands separator in `WP_Locale::init()`, use the `&nbsp;` entity directly.
We can't `get_option( 'blog_charset' )` here, because the database may not be available.

Fixes #10373.
Built from https://develop.svn.wordpress.org/trunk@35951


git-svn-id: http://core.svn.wordpress.org/trunk@35915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 21:35:29 +00:00
Dominik Schilling bc6b11d0de Revert [35949].
Passing an object to `wp_list_pluck()` throws also a fatal error, see https://3v4l.org/9YsaD.

See #35087.
Built from https://develop.svn.wordpress.org/trunk@35950


git-svn-id: http://core.svn.wordpress.org/trunk@35914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 19:50:29 +00:00
Pascal Birchler ac940d0587 Ensure `wp_list_pluck()` throws a warning when not being passed an array.
We should not paper over the code and hide warnings from developers by casting values to an array.

See #35087.
Built from https://develop.svn.wordpress.org/trunk@35949


git-svn-id: http://core.svn.wordpress.org/trunk@35913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 18:29:29 +00:00
Rachel Baker 719239ca1e Comments: Use an integer as the default value for `comment_post_ID` in `wp_insert_comment` to match database column.
Props MikeHansenMe, juanfra, rabmalin. 
Fixes #34956


Built from https://develop.svn.wordpress.org/trunk@35948


git-svn-id: http://core.svn.wordpress.org/trunk@35912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 15:13:27 +00:00
Andrea Fercia 282e7c36eb Accessibility: Add an ARIA role `button` to links that behave like buttons when JavaScript is on.
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.

Patch prepared during WordCamp US 2015 Contributor Day.

Props mcapybara, garusky, takayukister.

See #26504.
Fixes #34867.
Built from https://develop.svn.wordpress.org/trunk@35947


git-svn-id: http://core.svn.wordpress.org/trunk@35911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 13:25:28 +00:00
Dion Hulse 8db5455eea Filesystem: Avoid PHP warnings when using the FTP Sockets class.
See #35026 

Built from https://develop.svn.wordpress.org/trunk@35946


git-svn-id: http://core.svn.wordpress.org/trunk@35910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 03:12:26 +00:00
Dion Hulse bda1b2ace9 Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
See #28013

Fixes #34976 for trunk
Fixes #34976 for trunk

Built from https://develop.svn.wordpress.org/trunk@35944


git-svn-id: http://core.svn.wordpress.org/trunk@35908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 02:36:28 +00:00
Weston Ruter 3fdb8bafc4 Customize: Ensure that "Change" button appears when there are only 2 themes.
Fixes defect introduced in [35535].

Props igmoweb.
See #34549.
Fixes #35081.

Built from https://develop.svn.wordpress.org/trunk@35943


git-svn-id: http://core.svn.wordpress.org/trunk@35907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 01:21:26 +00:00
Dion Hulse 060476a1f2 Filesystem API: Cast the port to an int in the FTPSockets class. PemFTP requires that the port be specified as an integer, not a numeric string.
Fixes #35088

Built from https://develop.svn.wordpress.org/trunk@35942


git-svn-id: http://core.svn.wordpress.org/trunk@35906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 00:29:26 +00:00
Drew Jaynes 10367a4692 Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Rewrite::iis7_url_rewrite_rules()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35941


git-svn-id: http://core.svn.wordpress.org/trunk@35905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:58:27 +00:00
Drew Jaynes af5f4a0d9c Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Streams::test()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35940


git-svn-id: http://core.svn.wordpress.org/trunk@35904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:54:26 +00:00
Drew Jaynes 338b618fc0 Docs: Remove an extra 'arguments' introduced in [35938].
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35939


git-svn-id: http://core.svn.wordpress.org/trunk@35903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:52:25 +00:00
Drew Jaynes edb1dc0f36 Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Curl::test()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35938


git-svn-id: http://core.svn.wordpress.org/trunk@35902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:43:26 +00:00
Drew Jaynes 64ea48f76a Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Http_Curl::stream_body()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35937


git-svn-id: http://core.svn.wordpress.org/trunk@35901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:41:26 +00:00
Drew Jaynes 8d884c25a3 Docs: Clarify documentation for `WP_Role::has_cap()` to more clearing indicate that the method checks for capabilities against the role rather than the user.
Also updates syntax in the DocBlock summary and description.

Props GunGeekATX for the initial patch.
Fixes #35080.

Built from https://develop.svn.wordpress.org/trunk@35935


git-svn-id: http://core.svn.wordpress.org/trunk@35899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 20:05:27 +00:00
Boone Gorges 3bc0e35684 Omit `cpage` query var in comment link if comment pagination is disabled.
WP 4.4 changed the way comment pagination is calculated. See #8071. In the
context of `get_comment_link()`, these changes introduced a regression that
causes `cpage` (or its pretty-permalink correlate `comment-page-x`) to appear
in comment links when comment pagination is disabled. The current changeset
fixes the regression.

Fixes #34946.
Built from https://develop.svn.wordpress.org/trunk@35933


git-svn-id: http://core.svn.wordpress.org/trunk@35897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:46:46 +00:00
Boone Gorges b6dbe1cea9 Don't use `array_merge()` when building comment children arrays.
`array_merge()` is much slower than building the combined array using a
`foreach` loop. The performance difference was causing a speed regression with
the `get_children()` functionality introduced in 4.4.

Props rogerhub.
Fixes #35025.
Built from https://develop.svn.wordpress.org/trunk@35931


git-svn-id: http://core.svn.wordpress.org/trunk@35895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:37:43 +00:00
Drew Jaynes 0c59fd02bb Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Http_Curl::stream_headers()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35930


git-svn-id: http://core.svn.wordpress.org/trunk@35894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:21:35 +00:00
Drew Jaynes f32fba3dab Docs: Add more complete property and method documentation for `Walker_Page`.
* Adds missing DocBlock summaries
* Adds missing `@param` descriptions
* Marks some optional parameters as such
* Reorders some DocBlock tags

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35929


git-svn-id: http://core.svn.wordpress.org/trunk@35893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 18:06:31 +00:00
Drew Jaynes fc9fa08592 Docs: Add a missing description for the `$id` parameter in the DocBlock for `Walker_PageDropdown::start_el()`, which is implemented by `Walker` but unused by the subclass method.
Also marks the other optional parameters as such.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35928


git-svn-id: http://core.svn.wordpress.org/trunk@35892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:54:27 +00:00
Drew Jaynes 0fbe903434 Docs: Document the `$id` parameter for `Walker_Comment::start_el()`, which is implemented by `Walker` but unused in the subclass method.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35927


git-svn-id: http://core.svn.wordpress.org/trunk@35891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:50:26 +00:00
Drew Jaynes 5817eea3c9 Docs: Document the `$id` parameter for `Walker_CategoryDropdown::start_el()`, which is implemented by `Walker` but unused in the subclass method.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35926


git-svn-id: http://core.svn.wordpress.org/trunk@35890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:47:30 +00:00
Andrea Fercia b5f5dff136 Authentication modal dialog: the spinner should disappear when loading is done.
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311.

Fixes #34951.
Built from https://develop.svn.wordpress.org/trunk@35925


git-svn-id: http://core.svn.wordpress.org/trunk@35889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:40:27 +00:00
Andrea Fercia 0faf2dd57b Accessibility: Remove title attributes from the Network Themes list table.
Title attributes in the "Themes" screen and in the "Edit Site" screen Themes tab
are now replaced with `aria-label` attributes. Also, replaces string
concatenation with `add_query_arg()` and `sprintf()` to allow translator
comments to be properly parsed and for better code readability.

Props SergeyBiryukov, afercia.
Fixes #35051.
Built from https://develop.svn.wordpress.org/trunk@35924


git-svn-id: http://core.svn.wordpress.org/trunk@35888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:07:39 +00:00
Sergey Biryukov d0b7dd489e I18N: Remove `<strong>` tags from translatable strings in `WP_Customize_Manager::register_controls()` and `WP_Customize_Header_Image_Control::render_content()`.
Add translator comments.

See #35039.
Built from https://develop.svn.wordpress.org/trunk@35923


git-svn-id: http://core.svn.wordpress.org/trunk@35887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 12:54:27 +00:00
Dion Hulse ca7a95df36 Update random_compat to latest master (~1.1.5)
Changes:
 * Checks `disable_classes` for `COM()` before using to avoid PHP Warnings
 * Uses `stream_set_chunk_size()` to avoid reading 8KiB from `/dev/urandom` unintentionally.
See #34948

Built from https://develop.svn.wordpress.org/trunk@35922


git-svn-id: http://core.svn.wordpress.org/trunk@35886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 07:46:28 +00:00
Sergey Biryukov 36e8fa050f Docs: Capitalize 'URL' correctly in `the_guid()` DocBlock. Fix a typo.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35920


git-svn-id: http://core.svn.wordpress.org/trunk@35884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 05:21:26 +00:00
Dion Hulse e8b2a769ee HTTP: Partially revert [34283] which removed the 1024bit certificates from our trust store.
Most browsers no longer trust 1024bit certificates, or certificates signed by them, instead verifying them by a trusted intermediate or a cross-sign from another trusted certificate.

Unfortunately, as it turns out, OpenSSL prior to 1.0.1g cannot correctly handle certificates chains such as this, even if one of the intermediates is trusted.
The solution is that we need to continue to trust the 1024bit legacy root certificates forthe foreseeable future

This adds the following certificates back into our trust store:
{{{
GTE CyberTrust Global Root
Thawte Server CA
Thawte Premium Server CA
Verisign Class 3 Public Primary Certification Authority
Verisign Class 3 Public Primary Certification Authority - G2
ValiCert Class 1 VA
ValiCert Class 2 VA
RSA Root Certificate 1
Entrust.net Secure Server CA
Equifax Secure Global eBusiness CA
Equifax Secure eBusiness CA 1
America Online Root Certification Authority 1
America Online Root Certification Authority 2
NetLock Business (Class B) Root
NetLock Express (Class C) Root
Verisign Class 3 Public Primary Certification Authority
}}}

Props rmccue
Fixes #34935 for trunk.

Built from https://develop.svn.wordpress.org/trunk@35919


git-svn-id: http://core.svn.wordpress.org/trunk@35883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 05:20:28 +00:00
John Blackbourn 4836d6c700 Correct the position of the `$alt` parameter's `@param` doc in `image_add_caption()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35918


git-svn-id: http://core.svn.wordpress.org/trunk@35882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 03:01:25 +00:00
Jeremy Felt 72c6868fae MS: Fix pagination in MS Sites List Table when entering a page number.
When a page number is manually entered in the sites list table and no bulk action is selected, add `paged` as a query argument to the redirect.

Fixes #32982.

Built from https://develop.svn.wordpress.org/trunk@35917


git-svn-id: http://core.svn.wordpress.org/trunk@35881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:59:27 +00:00
John Blackbourn aace0e33c1 Correct some `@param` doc names in the `WP_Tax_Query` and `WP_User_Query` classes.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35916


git-svn-id: http://core.svn.wordpress.org/trunk@35880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:50:27 +00:00
John Blackbourn 3f38dfa688 Correct a parameter name in the `@param` docs for `get_home_url()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35915


git-svn-id: http://core.svn.wordpress.org/trunk@35879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:45:27 +00:00
John Blackbourn 593cc9abbd Add missing `@param` docs to `wp_safe_redirect()` and `wp_sanitize_redirect()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35914


git-svn-id: http://core.svn.wordpress.org/trunk@35878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:43:25 +00:00
John Blackbourn 9f7165d522 Add missing `@param` doc to `wp_hash()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35913


git-svn-id: http://core.svn.wordpress.org/trunk@35877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:39:26 +00:00
John Blackbourn c2248060fe Add missing variadic markers to the optional parameters of `do_action()` and `apply_filters()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35912


git-svn-id: http://core.svn.wordpress.org/trunk@35876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:36:25 +00:00
John Blackbourn 2984cdf457 Revert [35910].
Built from https://develop.svn.wordpress.org/trunk@35911


git-svn-id: http://core.svn.wordpress.org/trunk@35875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:35:26 +00:00
John Blackbourn de7ccd262a Built from https://develop.svn.wordpress.org/trunk@35910
git-svn-id: http://core.svn.wordpress.org/trunk@35874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:33:25 +00:00
John Blackbourn 48380c58a5 Add missing `@param` doc to `wp_check_password()` and update the `check_password` filter docs.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35909


git-svn-id: http://core.svn.wordpress.org/trunk@35873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:30:26 +00:00
John Blackbourn b2e373d64d Correct the name of the `@param` doc for `WP_Query::parse_tax_query()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35908


git-svn-id: http://core.svn.wordpress.org/trunk@35872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:08:26 +00:00
John Blackbourn 6bb33fb2f4 Add a missing `@param` doc to `wp_update_term_count()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35907


git-svn-id: http://core.svn.wordpress.org/trunk@35871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:04:26 +00:00
John Blackbourn e059193943 Remove a redundant `@param` tag from `the_taxonomies()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35906


git-svn-id: http://core.svn.wordpress.org/trunk@35870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:02:27 +00:00
Andrea Fercia fa80eb011f Accessibility: remove title attributes from the available headers in the (no more used) `custom-header.php` screen.
Fixes #35062.
Built from https://develop.svn.wordpress.org/trunk@35905


git-svn-id: http://core.svn.wordpress.org/trunk@35869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 00:09:27 +00:00
Pascal Birchler 47306630ca Docs: Improve documentation for `format_for_editor()` and the `'the_editor_content'` filter it is hooked to.
Props AramZS for initial patch.
Fixes #34866.
Built from https://develop.svn.wordpress.org/trunk@35904


git-svn-id: http://core.svn.wordpress.org/trunk@35868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:22:26 +00:00
Sergey Biryukov d5d5d64e3d I18N: Use better context for post statuses.
See #35054.
Built from https://develop.svn.wordpress.org/trunk@35903


git-svn-id: http://core.svn.wordpress.org/trunk@35867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:18:26 +00:00
Sergey Biryukov fe131bacd1 I18N: Use better context for comment statuses.
See #35054.
Built from https://develop.svn.wordpress.org/trunk@35902


git-svn-id: http://core.svn.wordpress.org/trunk@35866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:11:26 +00:00
Sergey Biryukov 5b29dbbf09 I18N: Add missing context for 'Trash' strings.
Fixes #35054.
Built from https://develop.svn.wordpress.org/trunk@35901


git-svn-id: http://core.svn.wordpress.org/trunk@35865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:03:26 +00:00
Sergey Biryukov 34ce39c782 List tables: After [34006], remove unnecessary context from 'View' string, for consistency with other strings in the same context.
Props MikeHansenMe, subharanjan.
Fixes #34914.
Built from https://develop.svn.wordpress.org/trunk@35900


git-svn-id: http://core.svn.wordpress.org/trunk@35864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 18:37:26 +00:00
Sergey Biryukov 346cce3c48 Customizer: Change "Display Header Text" checkbox label to "Display Site Title and Tagline", to make it clearer that it affects both settings.
Props juanfra, vlad.olaru.
Fixes #31829.
Built from https://develop.svn.wordpress.org/trunk@35899


git-svn-id: http://core.svn.wordpress.org/trunk@35863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 17:50:28 +00:00
Sergey Biryukov bff39f181e Credits: After [26354], replace another instance of the "Contributing to WordPress" Codex link with http://make.wordpress.org/.
Remove redundant translator comments, add comments for placeholders instead.

See #25806.
Built from https://develop.svn.wordpress.org/trunk@35898


git-svn-id: http://core.svn.wordpress.org/trunk@35862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 15:24:27 +00:00
Pascal Birchler 2981d66990 Login: After [34213], use the `login_post` scheme again for login forms.
See #34925.
Built from https://develop.svn.wordpress.org/trunk@35897


git-svn-id: http://core.svn.wordpress.org/trunk@35861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 14:03:26 +00:00
Pascal Birchler b804b26269 Admin: After [35128], make the 'Configure' link work again for dashboard widgets.
See #34987.
Built from https://develop.svn.wordpress.org/trunk@35896


git-svn-id: http://core.svn.wordpress.org/trunk@35860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 13:57:26 +00:00
Sergey Biryukov 8ad27a1405 Docs: Improve documentation for `wp_count_terms()`.
Props bordoni, swissspidy.
Fixes #34861.
Built from https://develop.svn.wordpress.org/trunk@35895


git-svn-id: http://core.svn.wordpress.org/trunk@35859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 12:11:27 +00:00
Andrea Fercia 188d41b53c Dashboard: remove not clickable spaces between icons and links in the "At a Glance" panel. Also, some CSS cleanup.
Props 5um17 for the initial patch.
Fixes #27813.
Built from https://develop.svn.wordpress.org/trunk@35894


git-svn-id: http://core.svn.wordpress.org/trunk@35858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 12:01:30 +00:00
Jeremy Felt b24fd73bd0 MS: Update "Add New Site" address description text for accuracy.
Add hyphens to the list of allowed characters and add the `description` class to helper text paragraph tag.

Props thomaswm for the initial patch.
Fixes #26388.

Built from https://develop.svn.wordpress.org/trunk@35893


git-svn-id: http://core.svn.wordpress.org/trunk@35857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 03:13:27 +00:00
Mel Choyce 09b5c2b3d0 Customizer: Bold pixel value under Site Icon to match the Custom Header instructions.
Props karmatosed.
Fixes #35039.

Built from https://develop.svn.wordpress.org/trunk@35892


git-svn-id: http://core.svn.wordpress.org/trunk@35856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 00:14:27 +00:00
Joe Hoyle 6e27cd7944 Remove accidental .svn addition to .gitignore
Introduced in 35890, oops!

Built from https://develop.svn.wordpress.org/trunk@35891


git-svn-id: http://core.svn.wordpress.org/trunk@35855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 18:27:26 +00:00
Joe Hoyle ee94a28953 REST API: Improve formatting of failed validation errors.
If a validation_callback returns a WP_Error it should give the same response format as if it returned `false`. This makes programmatically reading the validation errors better.

Props bradyvercher for initial patch.
Fixes #35028.

Built from https://develop.svn.wordpress.org/trunk@35890


git-svn-id: http://core.svn.wordpress.org/trunk@35854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 18:23:28 +00:00
Drew Jaynes c06143270e Docs: Document the optional `$args` parameter in `wp_delete_term()` in the hash notation style.
Props slushman, swissspidy.
Fixes #34862.

Built from https://develop.svn.wordpress.org/trunk@35889


git-svn-id: http://core.svn.wordpress.org/trunk@35853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 16:27:27 +00:00
Sergey Biryukov 3f61b6bafa Docs: Improve documentation for `request_filesystem_credentials()` and the corresponding filter.
Props swissspidy, danhgilmore, slushman.
Fixes #34858.
Built from https://develop.svn.wordpress.org/trunk@35888


git-svn-id: http://core.svn.wordpress.org/trunk@35852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 16:16:26 +00:00
Sergey Biryukov 56a31f392b Docs: Remove `@todo` entry from `get_archives_link()`, as all optional arguments are now documented.
See #34856.
Built from https://develop.svn.wordpress.org/trunk@35887


git-svn-id: http://core.svn.wordpress.org/trunk@35851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:55:27 +00:00
Sergey Biryukov 3da5165287 Docs: Document optional parameters in `get_archives_link()`.
Props kiranpotphode.
Fixes #34856.
Built from https://develop.svn.wordpress.org/trunk@35886


git-svn-id: http://core.svn.wordpress.org/trunk@35850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:52:27 +00:00
Pascal Birchler 54b8c3e53b Docs: Fix some minor DocBlock alignment issues.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35885


git-svn-id: http://core.svn.wordpress.org/trunk@35849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:37:28 +00:00
Sergey Biryukov e20fb91e54 I18N: In `WP_Locale::init()`, replace space as a thousands separator with a non-breaking space.
* If PHP version is 5.4.0 or greater, a regular space as a thousands separator is replaced with a non-breaking space, decoded using the `blog_charset` option.
* If PHP version is 5.2.x or 5.3.x, `&nbsp;` or `&#160;` as a thousands separator is replaced with a regular space, as multiple bytes are not supported there.

Fixes #10373.
Built from https://develop.svn.wordpress.org/trunk@35884


git-svn-id: http://core.svn.wordpress.org/trunk@35848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 02:06:35 +00:00
Sergey Biryukov 386e788efb Editor: Move 'Password protected' and 'Private' options description directly after 'Visibility' setting description.
Props christophherr.
Fixes #34919.
Built from https://develop.svn.wordpress.org/trunk@35883


git-svn-id: http://core.svn.wordpress.org/trunk@35847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:56:29 +00:00
Sergey Biryukov f0cdd8d0b4 Docs: Correct `wp_debug_mode()` description to clarify that `WP_DEBUG_DISPLAY` is true by default.
Props jrf.
Fixes #34960.
Built from https://develop.svn.wordpress.org/trunk@35882


git-svn-id: http://core.svn.wordpress.org/trunk@35846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:49:26 +00:00
Sergey Biryukov d53a13ee87 Fix typo in `wp-admin/setup-config.php`.
Props obrienlabs.
Fixes #34916.
Built from https://develop.svn.wordpress.org/trunk@35881


git-svn-id: http://core.svn.wordpress.org/trunk@35845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:45:27 +00:00
Sergey Biryukov 89e0d7dc9e I18N: In `wp_maybe_decline_date()`, bail early if translation functions are not available, e.g. in `SHORTINIT` mode.
Fixes #34967 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35880


git-svn-id: http://core.svn.wordpress.org/trunk@35844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:42:38 +00:00
Sergey Biryukov 224d20e99b Revert [35878].
See #34967.
Built from https://develop.svn.wordpress.org/trunk@35879


git-svn-id: http://core.svn.wordpress.org/trunk@35843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:41:34 +00:00
Sergey Biryukov 746c697099 I18N: In `wp_maybe_decline_date()`, bail early if translation functions are not available, e.g. in `SHORTINIT` mode.
Fixes #34967 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35878


git-svn-id: http://core.svn.wordpress.org/trunk@35842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:35:35 +00:00
Drew Jaynes 1ae97a2078 Docs: Update the summary for the `comment_form_fields` hook docs to explicitly mention inclusion of the textarea element as a filterable element.
Previously [35723]

Props bappidgreat.
Fixes #34973.

Built from https://develop.svn.wordpress.org/trunk@35877


git-svn-id: http://core.svn.wordpress.org/trunk@35841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:07:27 +00:00
John Blackbourn 36679a6e89 Avoid a PHP notice when trying to access the `post_parent` property of hierarchical post type nav menu items.
FIxes #34446

Built from https://develop.svn.wordpress.org/trunk@35876


git-svn-id: http://core.svn.wordpress.org/trunk@35840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:06:29 +00:00
Andrea Fercia 24afea92c2 When editing terms, properly display an admin `notice-warning` when `tag_ID` is empty.
Also, avoids two related PHP notices when empty or not set (and thus the global `$tag` is a WP_Error object).

Fixes: #34515.
Built from https://develop.svn.wordpress.org/trunk@35875


git-svn-id: http://core.svn.wordpress.org/trunk@35839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:49:41 +00:00
Pascal Birchler 1294c2bc3a Admin Menu: Deprecate `add_object_page()` and `add_utility_page()`.
These functions are not used in core and are just wrappers for `add_menu_page()`.

Fixes #23108.
Built from https://develop.svn.wordpress.org/trunk@35874


git-svn-id: http://core.svn.wordpress.org/trunk@35838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:12:26 +00:00
Pascal Birchler ba9475786a Dashboard: Do not show "Search Engines Discouraged" text when the `blog_public` option is not set.
Search engines are only discouraged from indexing the site when the option is explicitly set to `0`.

Fixes #34860.
Built from https://develop.svn.wordpress.org/trunk@35873


git-svn-id: http://core.svn.wordpress.org/trunk@35837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:03:26 +00:00
John Blackbourn 4a934d72bb Ensure that all the capabilities that any users have are being tested. This ensures that if new capabilities are introduced in the future, tests will be required for them.
See #35024

Built from https://develop.svn.wordpress.org/trunk@35872


git-svn-id: http://core.svn.wordpress.org/trunk@35836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:00:27 +00:00
John Blackbourn 8854836a0a Introduce tests for the `unfiltered_upload` capability, which no user should have (unless the `ALLOW_UNFILTERED_UPLOADS` constant is defined).
See #35024

Built from https://develop.svn.wordpress.org/trunk@35871


git-svn-id: http://core.svn.wordpress.org/trunk@35835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 21:55:26 +00:00
Pascal Birchler 5fa8ea8c6b Passwords: Hide weak password confirmation checkbox when password strength improves.
Props subharanjan for initial patch.
Fixes #34950.
Built from https://develop.svn.wordpress.org/trunk@35870


git-svn-id: http://core.svn.wordpress.org/trunk@35834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 21:54:27 +00:00
John Blackbourn a2c79a2fc6 Correct the hash notation documentation introduced in [34891].
See #32147

Built from https://develop.svn.wordpress.org/trunk@35869


git-svn-id: http://core.svn.wordpress.org/trunk@35833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 20:16:27 +00:00
Drew Jaynes 2cad8ec9e3 Docs: Remove indentation from a wrapped line in the DocBlock description for `get_post_type_labels()` to prevent incorrect formatting when parsed.
With the false indentation in place, the parser for the Code Reference incorrectly interprets it as a block quote.

Fixes #35019.

Built from https://develop.svn.wordpress.org/trunk@35868


git-svn-id: http://core.svn.wordpress.org/trunk@35832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 18:42:27 +00:00
Sergey Biryukov 6d90a7b0cb Post Template: Pass the post ID to `the_guid` and `get_the_guid` filters.
Props danielbachhuber for initial patch.
Fixes #35015.
Built from https://develop.svn.wordpress.org/trunk@35867


git-svn-id: http://core.svn.wordpress.org/trunk@35831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 16:39:26 +00:00
Andrea Fercia 70330165c4 Accessibility: on the Updates screen, remove a redundant title attribute.
Removes the title attribute from the Plugin details link and adds the Plugin name hidden with `screen-reader-text` within the link text.

Props Cheffheid.
Fixes #35001.
Built from https://develop.svn.wordpress.org/trunk@35866


git-svn-id: http://core.svn.wordpress.org/trunk@35830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 16:32:26 +00:00
Drew Jaynes b3d28ad0b9 Administration: Improve the message displayed in the login form modal when a user's session has expired.
Props obrienlabs.
Fixes #34340.

Built from https://develop.svn.wordpress.org/trunk@35865


git-svn-id: http://core.svn.wordpress.org/trunk@35829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 16:01:28 +00:00
Drew Jaynes 0fcf24a38e Docs: Document the optional `$options` parameter for `wp_register_widget_control()` as a hash notation.
Props stephanethomas.
Fixes #34855.

Built from https://develop.svn.wordpress.org/trunk@35864


git-svn-id: http://core.svn.wordpress.org/trunk@35828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 15:24:28 +00:00
John Blackbourn 62b3d21229 Add assertions for role names as capabilities in the capabilities tests. This ensures the role name is only available as a capability to the corresponding role.
See #35007

Built from https://develop.svn.wordpress.org/trunk@35863


git-svn-id: http://core.svn.wordpress.org/trunk@35827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 11:07:29 +00:00
Gary Pendergast f76712f652 About: Add a fallback `-webkit-calc()` to `about.css`
We forgot to run `grunt precommit` before [35834] was committed.

This change doesn't need to be backported to the 4.4 branch, as it only affects Chrome < 26, it's really just to clean up the behaviour of `grunt precommit`.

See #34663.



Built from https://develop.svn.wordpress.org/trunk@35862


git-svn-id: http://core.svn.wordpress.org/trunk@35826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:53:26 +00:00
Eric Lewis 6be07725fb Add inline documentation for `get_page_by_path()`.
Fixes #34964.

Built from https://develop.svn.wordpress.org/trunk@35861


git-svn-id: http://core.svn.wordpress.org/trunk@35825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:50:26 +00:00
Eric Lewis b07bb412ee Don't suppress error messages in database function calls.
Fixes #21870.

Built from https://develop.svn.wordpress.org/trunk@35860


git-svn-id: http://core.svn.wordpress.org/trunk@35824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:40:26 +00:00
Gary Pendergast 49e2977b7e Build Tools: Update grunt-contrib-imagemin to v1.0.0
This updates `imagemin` to 4.0.0, which fixes an error when running `grunt imagemin:core`.

Props netweb.

Fixes #35003.


Built from https://develop.svn.wordpress.org/trunk@35859


git-svn-id: http://core.svn.wordpress.org/trunk@35823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:39:23 +00:00
Boone Gorges f4f2116edd Be sure to force-delete when cleaning up fixtures in `get_comment_link()` tests.
Introduced in [35857].

Mega-super-anti-props boonebgorges.
Built from https://develop.svn.wordpress.org/trunk@35858


git-svn-id: http://core.svn.wordpress.org/trunk@35822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 02:47:25 +00:00
Boone Gorges cef6eee086 Share fixtures in `get_comment_link()` tests.
See #30017.
Built from https://develop.svn.wordpress.org/trunk@35857


git-svn-id: http://core.svn.wordpress.org/trunk@35821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 02:27:27 +00:00
Dominik Schilling 6fb81e3338 L10n: Use an absolute path for the `is_dir()` check when looking for installed translations.
Avoids warnings when `open_basedir` restrictions are in effect.

Props Profforg.
Fixes #34526.
Built from https://develop.svn.wordpress.org/trunk@35856


git-svn-id: http://core.svn.wordpress.org/trunk@35820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 23:09:27 +00:00
Andrea Fercia 81b70b5af7 Updates screen: make the new strings introduced in [35854] translatable.
Props walbo.
Fixes #34763.
Built from https://develop.svn.wordpress.org/trunk@35855


git-svn-id: http://core.svn.wordpress.org/trunk@35819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 19:24:26 +00:00
Andrea Fercia 984e1321ba Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.
Fixes #34763.
Built from https://develop.svn.wordpress.org/trunk@35854


git-svn-id: http://core.svn.wordpress.org/trunk@35818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 17:21:29 +00:00
Rachel Baker 9dd574bd99 Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.
In `wp_update_comment()` only check if the given `comment_post_ID` is valid if it isn’t `0`.  This allows comments that were created programmatically via `wp_insert_comment()` without the (optional) `comment_post_ID` parameter to be edited.

Props subharanjan for the initial patch.
Fixes #34954


Built from https://develop.svn.wordpress.org/trunk@35853


git-svn-id: http://core.svn.wordpress.org/trunk@35817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 15:17:29 +00:00
Boone Gorges 812060f940 Improve handling for `WP_Error` objects in `get_the_terms()`.
`wp_get_object_terms()` can return a `WP_Error` object. As such, the
`get_the_terms()` cache wrapper should handle them properly. To wit:

* Don't try to map an error object to `get_term()`. Introduced in [35032].
* Don't cache an error object as taxonomy relationships. Introduced in at least [16487], maybe earlier.

Props stephenharris.
Fixes #34723.
Built from https://develop.svn.wordpress.org/trunk@35850


git-svn-id: http://core.svn.wordpress.org/trunk@35814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:35:27 +00:00
John Blackbourn 6fd3c9fc64 Comments: Commit tests missed in [35848].
See #28617

Built from https://develop.svn.wordpress.org/trunk@35849


git-svn-id: http://core.svn.wordpress.org/trunk@35813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:16:25 +00:00
John Blackbourn a027edc277 Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times.
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.

If this breaks the internet, I'll eat my hat.

Fixes #28617

Built from https://develop.svn.wordpress.org/trunk@35848


git-svn-id: http://core.svn.wordpress.org/trunk@35812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:06:30 +00:00
John Blackbourn 8826804952 Formatting: Don't make links inside `<script>` and `<style>` tags clickable.
Fixes #30162
Props ninos-ego, adamsilverstein

Built from https://develop.svn.wordpress.org/trunk@35847


git-svn-id: http://core.svn.wordpress.org/trunk@35811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 23:55:32 +00:00
Andrea Fercia 2ae5db3856 Accessibility: remove no-purpose title attributes from the login screen.
Also, it's hard to convey the ironic tone of the sentences used for these title attributes in languages other than English.

Fixes #34943.
Built from https://develop.svn.wordpress.org/trunk@35846


git-svn-id: http://core.svn.wordpress.org/trunk@35810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 22:20:29 +00:00
Rachel Baker 17061829e4 Docs: Better param descriptions and fix incorrect param name within REST API deprecated functions
`rest_handle_deprecated_function`: you get better parameter descriptions.
`rest_handle_deprecated_argument`: you get a corrected parameter name ($replacement->$message), appropriate i18n translation hints, and better parameter descriptions.

Props ocean90.
Fixes #34908


Built from https://develop.svn.wordpress.org/trunk@35845


git-svn-id: http://core.svn.wordpress.org/trunk@35809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 21:26:29 +00:00
Drew Jaynes a4cd391d50 Docs: Move the hook doc for the `view_mode_post_types` filter to directly precede the `apply_filters()` line.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35844


git-svn-id: http://core.svn.wordpress.org/trunk@35808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 16:17:27 +00:00
Dominik Schilling 7551362d57 About Page: Add release video and update post embed.
Props camikaos, siobhan, rosso99, wonderboymusic.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35839


git-svn-id: http://core.svn.wordpress.org/trunk@35803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 23:23:26 +00:00
Dominik Schilling ba4a508daf Install/Upgrade: Keep indexing bots away until a site is ready to be seen.
Built from https://develop.svn.wordpress.org/trunk@35837


git-svn-id: http://core.svn.wordpress.org/trunk@35801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 21:56:27 +00:00
Scott Taylor f642373090 About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels. Adjust the layout accordingly, and improve the layout at smaller breakpoints.
Props melchoyce.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35834


git-svn-id: http://core.svn.wordpress.org/trunk@35798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 20:25:28 +00:00
Dominik Schilling dc7ff95661 About Page: Remove three superfluous parentheses.
Props jaspermdegroot.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35833


git-svn-id: http://core.svn.wordpress.org/trunk@35797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 18:15:26 +00:00
Dominik Schilling d5475667b0 About Page: Use w.org CDN for images.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35832


git-svn-id: http://core.svn.wordpress.org/trunk@35796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 17:57:26 +00:00
Michael Arestad d23bd49fdd Administration: Adds a height to number inputs.
Number inputs didn't match the height of other form elements. Now they have a height of 28px and 40px on mobile. Both align with the sizes of other elements.

Props valendesigns. 
Fixes #28984.

Built from https://develop.svn.wordpress.org/trunk@35831


git-svn-id: http://core.svn.wordpress.org/trunk@35795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 16:07:25 +00:00
Dominik Schilling 1b41572d4c Bundled Themes: Update POT files.
See #34804.
Built from https://develop.svn.wordpress.org/trunk@35829


git-svn-id: http://core.svn.wordpress.org/trunk@35793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 15:18:28 +00:00
Scott Taylor 1b60538074 About Page: use the source of the Make/Core Embed response instead of discovering it (or reading from the cache) every time.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35826


git-svn-id: http://core.svn.wordpress.org/trunk@35790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 03:38:24 +00:00
Scott Taylor 932195771f About Page: use `srcset` for images, also known as Recursive Dogfooding.
Props joemcgill.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35825


git-svn-id: http://core.svn.wordpress.org/trunk@35789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 03:33:27 +00:00
Dominik Schilling b3a00ca1e9 About Page: Add Cloudup embed and cache the embeds as site transients.
Props wonderboymusic.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35823


git-svn-id: http://core.svn.wordpress.org/trunk@35787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 23:28:25 +00:00
Rachel Baker 55bb9a8c01 REST API: Make strings translatable in `register_rest_route`.
Adds i18n to the `doing_it_wrong()` messages for invalid parameters within `register_rest_route()`.

Props Latz,danielbachhuber.
Fixes #34902


Built from https://develop.svn.wordpress.org/trunk@35822


git-svn-id: http://core.svn.wordpress.org/trunk@35786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 22:40:27 +00:00
Mike Schroder 6f3da8d57b Media: Don't generate responsive image attributes if `src` does not match ID in `wp-image-` class.
We rely on the `wp-image-` class to quickly find an attachment ID to add responsive image attributes.
To avoid incorrect images being displayed, do not add these attributes if the `src` does not match the
meta from the attachment ID in the class.

Props azaozz, kovshenin, joemcgill.
Fixes: #34898.

Built from https://develop.svn.wordpress.org/trunk@35820


git-svn-id: http://core.svn.wordpress.org/trunk@35784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 20:08:51 +00:00
Dominik Schilling 3c0c5e6ad5 List Tables: Revert [34728] and [35482].
Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.

See #25493.
See #34825.
Built from https://develop.svn.wordpress.org/trunk@35818


git-svn-id: http://core.svn.wordpress.org/trunk@35782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 19:16:26 +00:00
Joe Hoyle 5031ca5c23 Prevent unnecessary $wpdb->update() when hierarchical post doesn't have children.
Props danielbachhuber.
Fixes #34896.

Built from https://develop.svn.wordpress.org/trunk@35817


git-svn-id: http://core.svn.wordpress.org/trunk@35781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 17:47:25 +00:00
Mel Choyce b6a14367e4 About: Update image of the Twenty Sixteen red color scheme so it matches the updated scheme color.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35816


git-svn-id: http://core.svn.wordpress.org/trunk@35780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 17:08:25 +00:00
Pascal Birchler 331fdaf184 Docs: After [35314], fix the DocBlock for `url_shorten()`.
See #20166.
Built from https://develop.svn.wordpress.org/trunk@35813


git-svn-id: http://core.svn.wordpress.org/trunk@35777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 16:39:25 +00:00
Dominik Schilling ef223adbdb About: Sync tagline from about page with credits and freedoms.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35812


git-svn-id: http://core.svn.wordpress.org/trunk@35776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 16:17:27 +00:00
Ella Iseulde Van Dorpe 657d3b50af Make date format consistent across the admin
The 'date_format' and 'time_format' options shouldn't affect the backend.

See #30864


Built from https://develop.svn.wordpress.org/trunk@35811


git-svn-id: http://core.svn.wordpress.org/trunk@35775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 04:26:27 +00:00
Weston Ruter 07339e61c0 Customizer: Apply `customize_dynamic_setting_class` and `customize_dynamic_setting_args` filters in calls to `WP_Customize_Manager::add_setting( $id, $args )`.
Ensure that plugin filters apply as expected for any settings registered statically without passing in an explicit class instance to `WP_Customize_Manager::add_setting()`.

Fixes #34597.

Built from https://develop.svn.wordpress.org/trunk@35810


git-svn-id: http://core.svn.wordpress.org/trunk@35774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 23:22:25 +00:00
Michael Adams 699c377856 Meta Boxes: Preserve radio inputs' state when sorting metaboxes.
When sorting a metabox, a clone of that metabox is created as a drag/drop "helper".
Previously, any checked radio input in the original metabox would become unchecked, when its clone "helper" was inserted into the DOM
(since only one radio within a set of radios of the same name can be checked).

Continued use of the clone helper is important so that the element being dragged isn't subject to the click and other event handlers attached to the real metabox,
so we can't just switch to dragging around the real metabox.  See, for example, comment:10:ticket:16972.

Preserve the radios' state via some name attribute trickery.

Fixes #16972

Built from https://develop.svn.wordpress.org/trunk@35809


git-svn-id: http://core.svn.wordpress.org/trunk@35773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:49 +00:00
Helen Hou-Sandí 83795d99be Plugins: Provide a link to searching the plugin directory when no search results are found.
Many new users do not know the difference between managing installed plugins and those found in the plugin directory. This helps with discoverability. The link is not provided in multisite installs because we assume that somebody with that kind of power in a network is experienced enough not to need it. This can always be reconsidered later.

props mordauk for the initial patch.
fixes #29865.

Built from https://develop.svn.wordpress.org/trunk@35808


git-svn-id: http://core.svn.wordpress.org/trunk@35772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:25 +00:00
Mel Choyce bba9132925 Twenty Eleven/Docs: Remove duplicate "can" from footer template.
See #34885.

Built from https://develop.svn.wordpress.org/trunk@35807


git-svn-id: http://core.svn.wordpress.org/trunk@35771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:12:25 +00:00
Nikolay Bachiyski c512f8cbdd Docs: clarify inline docs for hash_equals
Before the docs implied the complexity of the function was O(1) by using the term "constant time", now we use the more descriptive term "Timing attack safe".

Props AramZS.
Fixes #32778.

Built from https://develop.svn.wordpress.org/trunk@35805


git-svn-id: http://core.svn.wordpress.org/trunk@35769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:04:51 +00:00
John Blackbourn d35bc1b936 Use `site_url()` when generating `WP_CONTENT_URL` so it correctly adjusts for pages served over HTTPS. This mainly only affects old plugins which still use `WP_CONTENT_URL` instead of the newer `plugins_url()` function.
Fixes #13941
Props micropat

Built from https://develop.svn.wordpress.org/trunk@35804


git-svn-id: http://core.svn.wordpress.org/trunk@35768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:04:26 +00:00
Pascal Birchler 4ace55b0dc Docs: Add proper `@param` and `@return` tags for `capital_P_dangit()`.
Props timplunkett.
Fixes #34863.
Built from https://develop.svn.wordpress.org/trunk@35803


git-svn-id: http://core.svn.wordpress.org/trunk@35767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:02:27 +00:00
Mike Schroder 8d220df08b Bundled Themes: Bump version numbers in default themes.
Props davidakennedy.
Fixes #34804.


Built from https://develop.svn.wordpress.org/trunk@35802


git-svn-id: http://core.svn.wordpress.org/trunk@35766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:01:27 +00:00
Andrea Fercia bc7950519b Notices: improve styling consistency of links within notices.
For accessibility, links inside lines or blocks of text should be always underlined.

Props walbo.
Fixes #34606.
Built from https://develop.svn.wordpress.org/trunk@35801


git-svn-id: http://core.svn.wordpress.org/trunk@35765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:00:26 +00:00
Eric Lewis 0e8e5124c1 Posts: Don't modify post_name if it wasn't supplied to `wp_insert_post()`.
Previously when updating a post using wp_insert_post(), post_name was 
regenerated based on post_title every time if post_name was not passed in 
explicitly. This irons out the expectation that properties not passed into the 
function should not be modified.

Props jason_the_adams. 
Fixes #34865.

Built from https://develop.svn.wordpress.org/trunk@35800


git-svn-id: http://core.svn.wordpress.org/trunk@35764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:58:25 +00:00
Pascal Birchler f522e69a57 Docs: Fix a typo in the `stylesheet_directory` filter docs.
Props ixkaito.
Fixes #34859.
Built from https://develop.svn.wordpress.org/trunk@35799


git-svn-id: http://core.svn.wordpress.org/trunk@35763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:57:24 +00:00
Konstantin Kovshenin 84affbd3a9 Docs: Make "list table table tag" a bit more readable.
See: #34885, r35796.

Built from https://develop.svn.wordpress.org/trunk@35797


git-svn-id: http://core.svn.wordpress.org/trunk@35761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:54:26 +00:00
Konstantin Kovshenin 919867b090 Docs: Remove some more dittography.
See #34885, r35793.

Built from https://develop.svn.wordpress.org/trunk@35796


git-svn-id: http://core.svn.wordpress.org/trunk@35760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:50:25 +00:00
Pascal Birchler 59351cb62d Toolbar: Allow adding `lang` and `dir` attributes to toolbar items.
This is useful from a multilingual and accessibility perspective.

Props Chouby, leemon.
Fixes #33513.
Built from https://develop.svn.wordpress.org/trunk@35795


git-svn-id: http://core.svn.wordpress.org/trunk@35759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:37:25 +00:00
Jeremy Felt 714d5885d9 Te Docs: Fix te the misspelling.
Previously, [35793].

Fixes #34888.

Built from https://develop.svn.wordpress.org/trunk@35794


git-svn-id: http://core.svn.wordpress.org/trunk@35758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:32:25 +00:00
Gary Pendergast 31f51e2cbb The the Docs: Fix the the dittography
Sometimes, it's easy to to type the the same word twice, especially if if it's a simple word. We probably shouldn't do do do (do do do doo) it, though.

(I've excluded external libs from this change.)

Fixes #34885.


Built from https://develop.svn.wordpress.org/trunk@35793


git-svn-id: http://core.svn.wordpress.org/trunk@35757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:23:25 +00:00
Aaron Campbell 894526c78d Consider both home and site domains to be valid in `wp_validate_redirect()`.
Props layotte.
Fixes #34028.

Built from https://develop.svn.wordpress.org/trunk@35792


git-svn-id: http://core.svn.wordpress.org/trunk@35756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:17:24 +00:00
Michael Arestad 5eae357697 Administration: Improve color contrast of 'Add New' buttons.
This also includes improved focus styles for 'Add New'.

fixes #34876, #34864.

Built from https://develop.svn.wordpress.org/trunk@35791


git-svn-id: http://core.svn.wordpress.org/trunk@35755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:07:25 +00:00
Boone Gorges 714be37ea5 Show user_login in Dashboard user dropdowns.
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.

The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.

This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.

Props krogsgard, boonebgorges.
Fixes #31251.
Built from https://develop.svn.wordpress.org/trunk@35790


git-svn-id: http://core.svn.wordpress.org/trunk@35754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:57:26 +00:00
Rachel Baker 2cd2cb6e17 Multisite: Clarify purpose of hook from [35786] and match our naming convention.
`network_site_new_created_user_pending` -> `pre_network_site_new_created_user` 

See #33631

Built from https://develop.svn.wordpress.org/trunk@35789


git-svn-id: http://core.svn.wordpress.org/trunk@35753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:32:24 +00:00
Konstantin Kovshenin e1966f061d Allow usage of angle brackets in a site title or tagline.
The whole string is escaped with `esc_html()` anyway, so we don't
need to `wp_kses_post()`. This is a better experience for users who
want to use angle brackets in their site title or description.
Does not allow any HTML, adds unit tests.

props BandonRandon, pauldewouters.
fixes #27942.

Built from https://develop.svn.wordpress.org/trunk@35788


git-svn-id: http://core.svn.wordpress.org/trunk@35752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:29:25 +00:00
Drew Jaynes 4048bfb25c Docs: Fix mid-file separator syntax in wp-includes/wp-db.php.
Props liamdempsey.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35787


git-svn-id: http://core.svn.wordpress.org/trunk@35751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:26:24 +00:00
Rachel Baker 66ea0d6e1b Multisite: Add hook before a new user is created during the creation of a new site.
New `network_site_new_created_user_pending` action fires before a new user will be created via the network site-new.php page. 

Props mackensen
Fixes #33631

Built from https://develop.svn.wordpress.org/trunk@35786


git-svn-id: http://core.svn.wordpress.org/trunk@35750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:10:26 +00:00
Konstantin Obenland 2b7183c94b Plugins: Allow long plugin names to wrap on small screens.
Props mapk, rickalee.
Fixes #32569.


Built from https://develop.svn.wordpress.org/trunk@35785


git-svn-id: http://core.svn.wordpress.org/trunk@35749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 19:58:24 +00:00
Boone Gorges f8eec84133 Bump readme.html to 4.5.
Built from https://develop.svn.wordpress.org/trunk@35784


git-svn-id: http://core.svn.wordpress.org/trunk@35748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 18:49:26 +00:00
Weston Ruter 76fe3244eb Customizer: Re-use public `api.preview` instance in widgets preview instead of unnecessarily capturing in `api.Preview` constructor wrapper.
The preview instance is no longer private.

Props joshlevinson, westonruter.
Fixes #30890.
See #30726.

Built from https://develop.svn.wordpress.org/trunk@35783


git-svn-id: http://core.svn.wordpress.org/trunk@35747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 18:39:25 +00:00
Jeremy Felt a9da055b5b MS: Populate `public` on empty `$current_blog` during subdomain activation.
Activation of a subdomain site is done through that new site's address. This address does not exist in the `wp_blogs` table until activation is complete.

In this case we need to make sure `public` is populated to avoid a PHP notice.

Props uglyrobot.
Fixes #24760.

Built from https://develop.svn.wordpress.org/trunk@35782


git-svn-id: http://core.svn.wordpress.org/trunk@35746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 18:24:26 +00:00
Weston Ruter 0c311ef2d6 Customizer: Return added instances for panels, sections, controls, and settings when calling `WP_Customize_Manager::add_*()` methods.
Add missing phpDoc.

Props fusillicode, jubstuff.
Fixes #34596.

Built from https://develop.svn.wordpress.org/trunk@35781


git-svn-id: http://core.svn.wordpress.org/trunk@35745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 18:10:25 +00:00
Mark Jaquith 446de48b4f About Page: Add the WordPress 4.4 tagline.
"Connected" because of REST API and cross-site embeds.
"Responsive" because of responsive images and under-the-hood tweaks.

See #34663.
Built from https://develop.svn.wordpress.org/trunk@35780


git-svn-id: http://core.svn.wordpress.org/trunk@35744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 17:52:25 +00:00
Andrew Nacin 45032198e3 Updates: Avoid stomping global `$wp_version` in `wp_version_check()` and related.
fixes #34868.

Built from https://develop.svn.wordpress.org/trunk@35779


git-svn-id: http://core.svn.wordpress.org/trunk@35743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 17:39:27 +00:00
Boone Gorges 82ade1db66 Bump package.json to 4.5.0.
Built from https://develop.svn.wordpress.org/trunk@35778


git-svn-id: http://core.svn.wordpress.org/trunk@35742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 17:36:25 +00:00
Dion Hulse 70e9f5b543 Upgrader: FTP: Cleanup temporary files during FTP download failures.
Props ruud@joyo
Fixes #34772

Built from https://develop.svn.wordpress.org/trunk@35777


git-svn-id: http://core.svn.wordpress.org/trunk@35741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 17:07:25 +00:00
Andrew Nacin fc81fef986 Trunk is now 4.5-alpha.
Built from https://develop.svn.wordpress.org/trunk@35776


git-svn-id: http://core.svn.wordpress.org/trunk@35740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 16:44:25 +00:00
Andrew Nacin 0cf9d8b922 Add initial_db_version to wp_version_check().
fixes #34854.

Built from https://develop.svn.wordpress.org/trunk@35774


git-svn-id: http://core.svn.wordpress.org/trunk@35738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 15:44:27 +00:00
Scott Taylor 4ae83ec7ec REST API: Core typically sends nocache headers on all auth'ed responses, as in `wp`, `admin-ajax`, etc. Because the REST API infrastructure is hooked in pre-wp, we should be setting this ourselves.
Adds unit tests.

Props joehoyle.
Fixes #34832.

Built from https://develop.svn.wordpress.org/trunk@35773


git-svn-id: http://core.svn.wordpress.org/trunk@35737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:36:25 +00:00
Boone Gorges 43d1ab4720 Use 'invalid_username' error code when tripping 'illegal_user_logins'.
This gives us better compatibility with existing errors thrown by
`sanitize_user()`, especially in Multisite, where user_login has more
restrictions on allowed characters.

Props markjaquith.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35772


git-svn-id: http://core.svn.wordpress.org/trunk@35736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:25:26 +00:00
Aaron Jorbin c589ceb880 Make comment screen row actions focusable
In [34504], tabbing through row actions on comments that lacked links was broken. This restores the desired behavior and ensures that the row actions can be seen by no-js users.

Second Permanent Committer sign off was by WonderBoyMusic

See #15520
Fixes #34791
Props afercia, azaozz


Built from https://develop.svn.wordpress.org/trunk@35771


git-svn-id: http://core.svn.wordpress.org/trunk@35735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:13:24 +00:00
Scott Taylor 9ea3f9f676 Canonical: introduce `strip_fragment_from_url()` and use when comparing URLs in `redirect_canonical()`.
Props tellyworth.
Fixes #19918.

Built from https://develop.svn.wordpress.org/trunk@35770


git-svn-id: http://core.svn.wordpress.org/trunk@35734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:11:26 +00:00
Drew Jaynes ef1280f770 About page: Make strings translatable.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35769


git-svn-id: http://core.svn.wordpress.org/trunk@35733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 18:09:25 +00:00
Drew Jaynes 7b20f48413 About page: Final string changes.
Props petya, ocean90, DrewAPicture
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35768


git-svn-id: http://core.svn.wordpress.org/trunk@35732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 17:55:28 +00:00
Dominik Schilling 3be896b142 Unit Tests: Implement `addWarning()` method in SpeedTrapListener.
The method was introduced in PHPUnit 5.1.0, released today.

Fixes #34846.
Built from https://develop.svn.wordpress.org/trunk@35767


git-svn-id: http://core.svn.wordpress.org/trunk@35731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 16:41:26 +00:00
Drew Jaynes 65fb187505 About page: Add non-breaking spaces to "Reddit Comments" and "Speaker Deck" oEmbed provider names to prevent line wrapping between the words.
Props ocean90.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35766


git-svn-id: http://core.svn.wordpress.org/trunk@35730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 16:27:25 +00:00
Drew Jaynes 3e1f22c196 About page: Fix some minor string errors and simplify URL-building for the plugin install link for capable users.
Props ocean90, DrewAPicture
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35765


git-svn-id: http://core.svn.wordpress.org/trunk@35729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 16:13:28 +00:00
Dominik Schilling 7250749032 Reset Password: Add a missing `new` operator for `WP_Error` in `get_password_reset_key()`.
Missed in [34923].

Fixes #34180.

Built from https://develop.svn.wordpress.org/trunk@35764


git-svn-id: http://core.svn.wordpress.org/trunk@35728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 15:31:26 +00:00
Drew Jaynes de586c98c4 First pass of the 4.4 about page. Adds strings (not yet translatable) and screen shots (not CDN).
Props wonderboymusic, markjaquith, helen, nacin, liljimmi, mordauk, melchoyce, ryelle, ocean90, DrewAPicture
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35763


git-svn-id: http://core.svn.wordpress.org/trunk@35727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 12:24:26 +00:00
Andrew Nacin 9834e9993a Embeds: Enforce, via unit tests, the no-ampersand rule for wp-embed.js.
fixes #34698.

Built from https://develop.svn.wordpress.org/trunk@35762


git-svn-id: http://core.svn.wordpress.org/trunk@35726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 05:46:25 +00:00
Scott Taylor 8cf8e2c66d WP oEmbed: validate the `secret` send via `postMessage` in `wp.receiveEmbedMessage`. Also, compare `window` instances.
In the data sent to us from the embedded iframe by postMessage(), the secret value is being used directly in a document.querySelectorAll() call without first being validated or escaped.

In theory, this could lead to some broken embeds.

Props mdawaffe.
Fixes #34831.

Built from https://develop.svn.wordpress.org/trunk@35761


git-svn-id: http://core.svn.wordpress.org/trunk@35725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 20:17:25 +00:00
Helen Hou-Sandí 2f287af8aa Media: Avoid `rel="rel="` situations.
props lucymtc, swissspidy.
fixes #34826. see #32074.

Built from https://develop.svn.wordpress.org/trunk@35760


git-svn-id: http://core.svn.wordpress.org/trunk@35724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 17:17:26 +00:00
Gary Pendergast caf4b8270c Readme: Bump recommended MySQL version to 5.6, as 5.5 is now over 5 years old.
Happy birthday, MySQL 5.5! 

Fixes #34840.


Built from https://develop.svn.wordpress.org/trunk@35759


git-svn-id: http://core.svn.wordpress.org/trunk@35723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 16:46:26 +00:00
Mark Jaquith 6cc98e6fcd Route HEAD API requests through the GET callback method
fixes #34837
props danielbachhuber
Built from https://develop.svn.wordpress.org/trunk@35758


git-svn-id: http://core.svn.wordpress.org/trunk@35722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 16:34:25 +00:00
Boone Gorges 939291df9f Ensure that order is specified when querying for comment descendants.
Props tellyworth.
Fixes #34838.
Built from https://develop.svn.wordpress.org/trunk@35757


git-svn-id: http://core.svn.wordpress.org/trunk@35721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 15:50:27 +00:00
Scott Taylor fc349932c0 Install: after [35508], the margin on the header for the Install screen is too big.
Props SergeyBiryukov.
Fixes #34819.

Built from https://develop.svn.wordpress.org/trunk@35756


git-svn-id: http://core.svn.wordpress.org/trunk@35720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 21:02:25 +00:00
Scott Taylor 9b5ffe8062 Responsive Images: Currently images are included in the `srcset` if the aspect ratio difference is smaller than `0.01`. This number is too high, set it to `0.002`
Props joemcgill.
Fixes #34810.

Built from https://develop.svn.wordpress.org/trunk@35755


git-svn-id: http://core.svn.wordpress.org/trunk@35719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:58:24 +00:00
Scott Taylor c0f8bd0de2 Customize Unit Tests: also `remove_action( 'after_setup_theme', 'twentysixteen_setup' )`. TwentyFifteen is already removed.
See #31550.

Built from https://develop.svn.wordpress.org/trunk@35754


git-svn-id: http://core.svn.wordpress.org/trunk@35718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:56:24 +00:00
Scott Taylor eaae2546f5 Media: don't use `get_media_embedded_in_content()` in `wp_make_content_images_responsive()`.
Adds unit test.

Props azaozz.
Fixes #34807.

Built from https://develop.svn.wordpress.org/trunk@35753


git-svn-id: http://core.svn.wordpress.org/trunk@35717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:50:25 +00:00
Scott Taylor d569b9609e Media: show Trash filter for Media list table when `MEDIA_TRASH` is true.
Props chacha102.
Fixes #34795.

Built from https://develop.svn.wordpress.org/trunk@35752


git-svn-id: http://core.svn.wordpress.org/trunk@35716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:48:25 +00:00
Scott Taylor cd9515d306 Unit Tests: fix responsive image unit tests. Correct the logic in video shortcode unit test for width.
Props joemcgill, wonderboymusic.
Fixes #34790.

Built from https://develop.svn.wordpress.org/trunk@35751


git-svn-id: http://core.svn.wordpress.org/trunk@35715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:45:28 +00:00
Ryan McCue d1436af513 REST API: Unabbreviate error string.
Props daniel-koskinen.
Fixes #34818.

Built from https://develop.svn.wordpress.org/trunk@35750


git-svn-id: http://core.svn.wordpress.org/trunk@35714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-30 09:51:27 +00:00
Mark Jaquith 1a43f0b290 Do not pass FALSE as second parameter in variable class_exists() checks
Because these are generally plugin-provided, we want plugins to be
able to use autoloaders.

fixes #20523
Built from https://develop.svn.wordpress.org/trunk@35749


git-svn-id: http://core.svn.wordpress.org/trunk@35713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-30 04:15:27 +00:00
John Blackbourn ec24d6e001 In a similar vein to [34133], escape the email address and IP address of comment authors to increase defence in depth.
Built from https://develop.svn.wordpress.org/trunk@35748


git-svn-id: http://core.svn.wordpress.org/trunk@35712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-29 02:43:24 +00:00
John Blackbourn 6f37afb6ec When a post is scheduled for publication, treat it the same as a published post when calculating the capabilities required to edit or delete it.
Fixes #33694

Built from https://develop.svn.wordpress.org/trunk@35747


git-svn-id: http://core.svn.wordpress.org/trunk@35711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-29 02:27:18 +00:00
John Blackbourn 2b81411a0d Remove debug mode from WP-CLI by default, as it now outputs too much debugging information to be of use during normal development.
Fixes #34801
Props rodrigosprimo

Built from https://develop.svn.wordpress.org/trunk@35746


git-svn-id: http://core.svn.wordpress.org/trunk@35710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-28 18:37:27 +00:00
John Blackbourn 28c78799c3 Ensure the correct error message is returned when a user attempts to comment on a post to which they do not have access.
Adds more tests.

Built from https://develop.svn.wordpress.org/trunk@35745


git-svn-id: http://core.svn.wordpress.org/trunk@35709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-28 18:29:32 +00:00
Scott Taylor aa624c4029 WordPress 4.4 RC 1 version bump
Built from https://develop.svn.wordpress.org/trunk@35744


git-svn-id: http://core.svn.wordpress.org/trunk@35708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 23:02:24 +00:00
Scott Taylor cbed27ccf0 WordPress 4.4 RC 1
Built from https://develop.svn.wordpress.org/trunk@35743


git-svn-id: http://core.svn.wordpress.org/trunk@35707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:53:27 +00:00
Dominik Schilling 9fb5c540bb Users: Allow to create users without sending an email to the new user.
This adds a checkbox to `wp-admin/user-new.php` to prevent sending an email with the username and a password reset link to the new user. Restores the behavior of pre-4.3.

Fixes #33504.
Props tharsheblows, SergeyBiryukov, DrewAPicture, ocean90.
Built from https://develop.svn.wordpress.org/trunk@35742


git-svn-id: http://core.svn.wordpress.org/trunk@35706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:38:29 +00:00
Ryan McCue 7ce9772866 REST API: Mark WP_REST_Server::get_raw_data as static.
This is just a utility function for getting the request body, not
tied to the server class.

Fixes #34768.

Built from https://develop.svn.wordpress.org/trunk@35741


git-svn-id: http://core.svn.wordpress.org/trunk@35705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:22:25 +00:00
Helen Hou-Sandí e24681632e Avoid potential fatal errors after [35718].
While these classes are intended for admin use, there are developers out there who include `wp-admin/includes/template.php` to access them in other contexts. There is no intention to continue to support this indefinitely, but a breaking change like that would need to happen very early in a cycle and communicated loudly.

In the meantime, if you're reading this commit message and you do the above, please update your code to not do that. Thank you :)

fixes #33413.

Built from https://develop.svn.wordpress.org/trunk@35740


git-svn-id: http://core.svn.wordpress.org/trunk@35704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:19:26 +00:00
Helen Hou-Sandí 2eb60b8278 Set Twenty Sixteen as the default theme.
With thanks to all those who contributed.

props iamtakashi, karmatosed, iandstewart, dd32, mor10, grapplerulrich, davidakennedy, frank-klein, tywayne, wenthemes, monika, metodiew, nhuja, headonfire, Chrisdc1, philiparthurmoore, karpstrucking, cais, mt8.biz, fjarrett, sdavis2702, SergeyBiryukov, eduardozulian, webdevmattcrom, ehtis, peterwilsoncc, tfrommen, fsylum, wonderboymusic, ocean90, obenland, cainm, mrahmadawais, drewapicture, trenzterra, tevko, kraftbj, walbo, nacin.
fixes #34306.

Built from https://develop.svn.wordpress.org/trunk@35739


git-svn-id: http://core.svn.wordpress.org/trunk@35703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 21:52:26 +00:00
Scott Taylor 79a2915a9b Upgrade: New themes are not automatically installed on upgrade. This can still be explicitly asked for by defining `CORE_UPGRADE_SKIP_NEW_BUNDLED` as `false`.
In `populate_options()`, if the theme specified by `WP_DEFAULT_THEME` doesn't exist, fall back to the latest core default theme. If we can't find a core default theme, `WP_DEFAULT_THEME` is the best we can do. 

Props nacin, jeremyfelt, dd32.
See #34306.

Built from https://develop.svn.wordpress.org/trunk@35738


git-svn-id: http://core.svn.wordpress.org/trunk@35702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 21:45:25 +00:00
Konstantin Obenland 77c6154881 Template: Defining a default value for `show_home` breaks back compat.
To add a home link to the fallback menu output many themes only check if that
argument is set. Including Twenty Ten and Twenty Eleven. They check with
`isset()` so child themes and other instances using `wp_page_menu()` have a
chance to disable the home link by setting it to `false`.

Fixes #11095.


Built from https://develop.svn.wordpress.org/trunk@35737


git-svn-id: http://core.svn.wordpress.org/trunk@35701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 18:55:26 +00:00
Scott Taylor a2ec7caf93 Add a unit test for `wp_nav_menu()` with `container => ''`
See #32464.


Built from https://develop.svn.wordpress.org/trunk@35736


git-svn-id: http://core.svn.wordpress.org/trunk@35700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 18:19:27 +00:00
Dominik Schilling 0632e4ab84 Passwords: Support the pre-4.3 behavior of `wp_new_user_notification()`.
Hello, it's me again. A pluggable function named `wp_new_user_notification()`. A few months ago, after [33023], I have lost my second parameter `$plaintext_pass`. But thanks to [33620] I got a new one.
Bad idea - It hasn't had the same behavior as my previous parameter.
To solve that the second parameter got deprecated and reintroduced as the third parameter in [34116]. I was happy again, for a short time.
You remember my lost friend `$plaintext_pass`? No? Well, if its value was empty no notification was sent to the user. This behavior was still lost. And that's what this change is about: Don't notify a user if a plugin uses `wp_new_user_notification( $user_id )`.

You're asking if I'm happy now? Dunno, but maybe you have learned something about pluggable functions, have you?

Props danielbachhuber.
Fixes #34377.
Built from https://develop.svn.wordpress.org/trunk@35735


git-svn-id: http://core.svn.wordpress.org/trunk@35699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-24 23:07:26 +00:00
Dominik Schilling 16b95ab2a7 HTTP Tests: Use `login.wordpress.org/wp-login.php` in `test_get_response_cookies()`.
The old URL redirects to `login.wordpress.org` because it's the new canonical URL for all logins on wordpress.org.

Fixes #34782.
Built from https://develop.svn.wordpress.org/trunk@35734


git-svn-id: http://core.svn.wordpress.org/trunk@35698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-24 22:00:26 +00:00
Dominik Schilling 7f3082491d Passwords: Re-enable password fields before submitting the form.
Avoids an PHP undefined notice when creating new users.

Fixes #33699.
Built from https://develop.svn.wordpress.org/trunk@35733


git-svn-id: http://core.svn.wordpress.org/trunk@35697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-24 21:17:27 +00:00
Sergey Biryukov 64fdd0c6a0 Users: Move the tests added in [35116] and [35618] to a more appropriate place and give them a better name.
See #28435, #29880.
Built from https://develop.svn.wordpress.org/trunk@35732


git-svn-id: http://core.svn.wordpress.org/trunk@35696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 18:40:25 +00:00
Sergey Biryukov 60c8e272f5 Docs: Improve DocBlock formatting for `add_menu_page()` and `add_submenu_page()` wrappers.
See #34360.
Built from https://develop.svn.wordpress.org/trunk@35731


git-svn-id: http://core.svn.wordpress.org/trunk@35695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:56:26 +00:00
Helen Hou-Sandí 2cdeac7cf6 Pass the `$post` object as context to `postmeta_form_keys`.
see #33885, #18979.

Built from https://develop.svn.wordpress.org/trunk@35730


git-svn-id: http://core.svn.wordpress.org/trunk@35694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:15:29 +00:00
Gary Pendergast d04396d0ad Docs: Replace a reference to WP.org with WordPress.org.
Built from https://develop.svn.wordpress.org/trunk@35729


git-svn-id: http://core.svn.wordpress.org/trunk@35693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 22:38:26 +00:00
Andrew Ozz 50a5fbb269 Editor: remove wpLink dependency on jQuery UI.
Props afercia.
Fixes #34716.
Built from https://develop.svn.wordpress.org/trunk@35728


git-svn-id: http://core.svn.wordpress.org/trunk@35692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 19:27:26 +00:00
Andrew Ozz 91759029e9 TinyMCE: fix the regexp used to protect line breaks inside script and pre tags to match `<script>` that load external scripts.
Fixes #34760.
Built from https://develop.svn.wordpress.org/trunk@35727


git-svn-id: http://core.svn.wordpress.org/trunk@35691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 19:13:28 +00:00
Sergey Biryukov ae04eba0b6 Comments: After [35670], change the CSS class for the pending comments count back to `moderated`.
Fixes #34680.
Built from https://develop.svn.wordpress.org/trunk@35726


git-svn-id: http://core.svn.wordpress.org/trunk@35690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 15:23:26 +00:00
Sergey Biryukov bc1e479fd0 After [35718], update the location of some files in `This filter is documented in` docs.
Partially reverts [33954].

Fixes #33413.
Built from https://develop.svn.wordpress.org/trunk@35725


git-svn-id: http://core.svn.wordpress.org/trunk@35689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 03:51:28 +00:00
Weston Ruter 5dae1386aa Customize: Ensure that a setting (especially a multidimensional one) can still be previewed when the post value to preview is set after `preview()` is invoked.
* Introduce `customize_post_value_set_{$setting_id}` and `customize_post_value_set` actions which are done when `WP_Customize_Manager::set_post_value()` is called.
* Clear the `preview_applied` flag for aggregated multidimensional settings when a post value is set. This ensures the new value is used instead of a previously-cached previewed value.
* Move `$is_preview` property from subclasses to `WP_Customize_Setting` parent class.
* Deferred preview: Ensure that when `preview()` short-circuits due to not being applicable that it will be called again later when the post value is set.
* Populate post value for updated-widget with the (unsanitized) JS-value in `WP_Customize_Widgets::call_widget_update()` so that value will be properly sanitized when accessed in `WP_Customize_Manager::post_value()`.

Includes unit tests with assertions to check the reported issues and validate the fixes.

Fixes defect introduced in [35007].
See #32103.
Fixes #34738.

Built from https://develop.svn.wordpress.org/trunk@35724


git-svn-id: http://core.svn.wordpress.org/trunk@35688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-21 02:52:27 +00:00
Sergey Biryukov fd9bd77fe5 Comments: In `comment_form()`, introduce the `comment_form_fields` filter for comment fields, including the textarea.
Correct the docs for `comment_notes_before` and `comment_notes_after` arguments as well as `comment_form_before_fields` and `comment_form_after_fields` actions to better describe the current behaviour.

Fixes #34731.
Built from https://develop.svn.wordpress.org/trunk@35723


git-svn-id: http://core.svn.wordpress.org/trunk@35687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 18:56:27 +00:00
Sergey Biryukov 17af54fc7c Customizer: Use correct context and translator comments for menu location strings.
See #33431.
Built from https://develop.svn.wordpress.org/trunk@35722


git-svn-id: http://core.svn.wordpress.org/trunk@35686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 17:46:25 +00:00
Helen Hou-Sandí 277747f944 Postbox handle buttons don't need a focus outline.
see #33808, #34242.

Built from https://develop.svn.wordpress.org/trunk@35721


git-svn-id: http://core.svn.wordpress.org/trunk@35685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 15:56:25 +00:00
Dominik Schilling 22fe87c3b3 Build: Update source for `includes:embed` after [35718].
See #33413.
Built from https://develop.svn.wordpress.org/trunk@35720


git-svn-id: http://core.svn.wordpress.org/trunk@35684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 15:37:26 +00:00
Dominik Schilling 6fa25ac809 4.4-beta4-35719.
Built from https://develop.svn.wordpress.org/trunk@35719


git-svn-id: http://core.svn.wordpress.org/trunk@35683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 13:46:27 +00:00
Andrew Nacin 1579e45d41 Simplify the include graph after work to split out classes.
see #33413. More details there.

Built from https://develop.svn.wordpress.org/trunk@35718


git-svn-id: http://core.svn.wordpress.org/trunk@35682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 07:24:30 +00:00
Helen Hou-Sandí e549e56f02 Custom fields: Allow for short-circuiting the meta key dropdown.
Adds the `postmeta_form_keys` filter which allows for a potentially expensive query against postmeta to be avoided.

props ericmann, tollmanz, nacin.
see #33885.

Built from https://develop.svn.wordpress.org/trunk@35717


git-svn-id: http://core.svn.wordpress.org/trunk@35681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:50 +00:00
Sergey Biryukov 4341637ba6 Docs: Remove redundant `type` strings from the `wp_calculate_image_srcset` filter DocBlock.
Props DH-Shredder, joemcgill.
See #34733.
Built from https://develop.svn.wordpress.org/trunk@35716


git-svn-id: http://core.svn.wordpress.org/trunk@35680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:26 +00:00
Sergey Biryukov db4a87b0fd Docs: Add `@see` tags for `wp_get_attachment_image_srcset()` and `wp_get_attachment_image_sizes()`.
Update `@see` tags for `wp_make_content_images_responsive()` and `wp_image_add_srcset_and_sizes()`.

Props jaspermdegroot.
See #34733.
Built from https://develop.svn.wordpress.org/trunk@35715


git-svn-id: http://core.svn.wordpress.org/trunk@35679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:13:26 +00:00
Dion Hulse 048f327bfc Merge the changes to GlotPress's POMO from upstream to WordPress's copy.
Fixes #34748

Built from https://develop.svn.wordpress.org/trunk@35714


git-svn-id: http://core.svn.wordpress.org/trunk@35678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 04:34:25 +00:00
Dion Hulse 870cdfb024 Bump the version of MediaElement in script-loader.php to match what we're shipping with.
See #33798
Fixes #34743

Built from https://develop.svn.wordpress.org/trunk@35713


git-svn-id: http://core.svn.wordpress.org/trunk@35677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 03:32:26 +00:00
Sergey Biryukov cc7736a024 ru_RU: In back-compat styles for admin menu, inherit the width from the parent element, `#adminmenuwrap`, to account for media queries.
See #20974.
Built from https://develop.svn.wordpress.org/trunk@35712


git-svn-id: http://core.svn.wordpress.org/trunk@35676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 01:40:25 +00:00
Sergey Biryukov 3418279862 ru_RU: After [35710], remove fixed width for admin menu, as it does not account for media queries.
See #20974.
Built from https://develop.svn.wordpress.org/trunk@35711


git-svn-id: http://core.svn.wordpress.org/trunk@35675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 01:04:25 +00:00
Sergey Biryukov a1116d9534 Add some back-compat styles for ru_RU.
This prevents the admin menu from disappearing if an old `ru_RU.php` file is left over after updating directly from 3.1.x or an older version to the latest release.

See #20974.
Built from https://develop.svn.wordpress.org/trunk@35710


git-svn-id: http://core.svn.wordpress.org/trunk@35674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 00:36:27 +00:00
Gary Pendergast a3cd85eefd Texturize: Only convert `&` to `&#038;` within text nodes.
Previously, `&` would be converted everywhere, which caused problems when it was converted within a `<script>`, for example.

`convert_chars()` is now removed from the `the_content` filter, as it was doing the same job as `wptexturize()`.

KSES correctly handles converting `&` within HTML attributes, so there's no need for `wptexturize()` and `convert_chars()` to do the same job.

Fixes #34698.


Built from https://develop.svn.wordpress.org/trunk@35709


git-svn-id: http://core.svn.wordpress.org/trunk@35673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 23:31:26 +00:00
Gary Pendergast 603d3c0013 Embeds: Remove `&` characters from the inline embed JS.
Older versions of WordPress will convert those `&` characters to `&#038;`, which makes for some non-functional JS. If folks are running an older release, let's not make their lives more difficult than it already is.

Props pento, peterwilsoncc.

See #34698.


Built from https://develop.svn.wordpress.org/trunk@35708


git-svn-id: http://core.svn.wordpress.org/trunk@35672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 23:06:26 +00:00
John Blackbourn 8951e37f8f Ensure the count for users with no role remains accurate when users with multiple roles are present.
See #34495

Built from https://develop.svn.wordpress.org/trunk@35707


git-svn-id: http://core.svn.wordpress.org/trunk@35671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 17:11:25 +00:00
Konstantin Obenland 595ade87f9 Template: Use `template-loader.php` as cononical source of truth for conditional ordering.
Reverts [35700] which didn't account for author archives without posts.
Determination of the correct title is now based on the same order of
conditionals that template loader uses to select the right template.

H/t ocean90.
Fixes #34516.


Built from https://develop.svn.wordpress.org/trunk@35706


git-svn-id: http://core.svn.wordpress.org/trunk@35670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 17:09:26 +00:00
John Blackbourn c98359ddcf Clean up the `grammarian` role so it doesn't pollute other tests.
See #24153

Built from https://develop.svn.wordpress.org/trunk@35705


git-svn-id: http://core.svn.wordpress.org/trunk@35669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 16:47:25 +00:00
John Blackbourn 932236420c Move the `show_ui` logic into the `get_edit_post_link()` and `get_edit_term_link()` functions to facilitate post types and terms which specify `show_ui` as false but provide a custom editing UI via the `get_edit_post_link` and `get_edit_term_link` filters.
Fixes #33763
Fixes #33938

Built from https://develop.svn.wordpress.org/trunk@35704


git-svn-id: http://core.svn.wordpress.org/trunk@35668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 16:25:26 +00:00
Helen Hou-Sandí f6651352d9 Color picker: update to the new button style.
props paulwilde.
fixes #34734.

Built from https://develop.svn.wordpress.org/trunk@35703


git-svn-id: http://core.svn.wordpress.org/trunk@35667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 14:37:33 +00:00
Gary Pendergast 53acbb936e Embeds: Remove the `allow_insecure_embeds` filter.
This reverts [35640]. On further reflection, it really didn't do what it said it did.

Fixes #34588.


Built from https://develop.svn.wordpress.org/trunk@35702


git-svn-id: http://core.svn.wordpress.org/trunk@35666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 05:02:27 +00:00
Boone Gorges f173cdfb18 On 4.4 upgrade, remove the unused 'add_users' cap from all roles.
Fixes #16719.
Built from https://develop.svn.wordpress.org/trunk@35701


git-svn-id: http://core.svn.wordpress.org/trunk@35665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 03:53:28 +00:00
Konstantin Obenland b875cd1b72 Template: Get the author name directly from `$authordata`.
Since [25574] `$authordata` gets set up in `WP::register_globals()` - no need
to take a detour over the queried object.

Props greenshady for initial patch.
Fixes #34516.

Built from https://develop.svn.wordpress.org/trunk@35700


git-svn-id: http://core.svn.wordpress.org/trunk@35664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 00:06:25 +00:00
Konstantin Obenland 3f2c4fa8d2 Media: Reset box-sizing for input elements in the entire media modal.
See [29727].

Props tyxla for initial patch.
Fixes #34556.


Built from https://develop.svn.wordpress.org/trunk@35699


git-svn-id: http://core.svn.wordpress.org/trunk@35663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:36:28 +00:00
Scott Taylor a99f7baa5a List Tables: Fix PHP error notice when `$columns` is `null`
Use of `register_column_headers()` and `print_column_headers()` creates a `_WP_List_Table_Compat` without any columns. When the List Table object doesn't have any columns, there's naturally no primary column.

Props danielbachhuber.
Fixes #34148.

Built from https://develop.svn.wordpress.org/trunk@35698


git-svn-id: http://core.svn.wordpress.org/trunk@35662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:01:26 +00:00
Dominik Schilling 68f16dca18 Buttons: Update colors for disabled buttons.
Props hugobaeta.
Fixes #31459.
Built from https://develop.svn.wordpress.org/trunk@35697


git-svn-id: http://core.svn.wordpress.org/trunk@35661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:47:26 +00:00
Drew Jaynes b10a946c2c Docs: Clarify some parameter and return descriptions in the DocBlocks for `wp_get_attachment_image_srcset()` and `wp_calculate_image_srcset()`, `wp_get_attachment_image_sizes()`, and the `wp_calculate_image_srcset` filter.
Props joemcgill.
See #34733.

Built from https://develop.svn.wordpress.org/trunk@35696


git-svn-id: http://core.svn.wordpress.org/trunk@35660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:44:27 +00:00
Dominik Schilling d1805c9da8 Customizer: Merge two similar strings.
Remove also `{{ data.menu_name }}` since it doesn't print anything.

Fixes #33630.
Built from https://develop.svn.wordpress.org/trunk@35695


git-svn-id: http://core.svn.wordpress.org/trunk@35659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:25:25 +00:00
Dominik Schilling dfd30b10b0 Customizer: Remove two unused strings.
Fixes #33632.
Built from https://develop.svn.wordpress.org/trunk@35694


git-svn-id: http://core.svn.wordpress.org/trunk@35658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:12:26 +00:00
John Blackbourn 1368f7d489 Add support for oEmbeds from Speaker Deck.
Fixes #28597

Built from https://develop.svn.wordpress.org/trunk@35693


git-svn-id: http://core.svn.wordpress.org/trunk@35657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:05:25 +00:00
Jeremy Felt f7b29ecd1b Multisite: Re-Account for striped table rows with `.site-*` classes.
[34356] removed the table row specificity on rules for `.site-deleted`, `.site-spammed`, `.site-archived`, and `.site-matured` so that the styles would be properly applied to other elements. Now, the zebra striping rules override these styles on even rows.

We can account for `tr` specific and more generic applications of these classes.

Fixes #33595.

Built from https://develop.svn.wordpress.org/trunk@35692


git-svn-id: http://core.svn.wordpress.org/trunk@35656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:59:26 +00:00
Boone Gorges b17cb707dc Eliminate a db query when building the admin menu for non-privileged users.
Users who cannot `edit_posts` do not see the Comments nav item anyway, so
don't bother running a query that gets a comment count to display in the menu.

Props bordoni, johnbillion.
Fixes #19372.
Built from https://develop.svn.wordpress.org/trunk@35691


git-svn-id: http://core.svn.wordpress.org/trunk@35655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:34:26 +00:00
Boone Gorges 31219ee677 In `WP_Query`, set `is_home` to `false` during REST requests.
Props danielbachhuber.
Fixes #34373.
Built from https://develop.svn.wordpress.org/trunk@35690


git-svn-id: http://core.svn.wordpress.org/trunk@35654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:18:26 +00:00
Drew Jaynes f94f58fbb1 Embeds: Introduce `print_embed_comments_button()`, `print_embed_sharing_button()`, and `print_embed_sharing_dialog()`, which respectively output the comments button, sharing buttons, and sharing dialog elements in the embed template.
This change hooks these new output functions to existing hooks in the embed template, allowing for more straightforward display control of these elements.

Leaves the embed header and footer intact pending further modularization in a future release.

Props juliobox, swissspidy, DrewAPicture.
See #34561.

Built from https://develop.svn.wordpress.org/trunk@35689


git-svn-id: http://core.svn.wordpress.org/trunk@35653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:51:26 +00:00
Aaron Jorbin e8d8e79371 Revert [34291] bringing back my-hacks
Keeping myhacks support is a small price to pay for not breaking people's sites.  Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.

https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.

Fixes #33741.



Built from https://develop.svn.wordpress.org/trunk@35688


git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:49:26 +00:00
John Blackbourn 16502d03f2 Remove `register_api_field()` from core. This is the only core function that utilises the `$wp_rest_additional_fields` global, and doesn't belong as part of the infrastructure.
See https://github.com/WP-API/WP-API/pull/1748

Fixes #34730

Built from https://develop.svn.wordpress.org/trunk@35687


git-svn-id: http://core.svn.wordpress.org/trunk@35651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:39:26 +00:00
Sergey Biryukov 5d61c1b8d1 I18N: After [35620], move the code for standardizing on `\n` line endings to `Translation_Entry::key()`.
Props dd32.
Fixes #22172.
Built from https://develop.svn.wordpress.org/trunk@35686


git-svn-id: http://core.svn.wordpress.org/trunk@35650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:37:25 +00:00
Dominik Schilling c25efe2d52 Revert [35336] and [35337].
See #28344.
Built from https://develop.svn.wordpress.org/trunk@35685


git-svn-id: http://core.svn.wordpress.org/trunk@35649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:30:25 +00:00
Aaron Jorbin d507b5636f Set cssmin compatibility to ie7
This matches the autoprefixer setting. This changes all compiled CSS.

Fixes #34540.
Props christophherr, peterwilsoncc, netweb


Built from https://develop.svn.wordpress.org/trunk@35684


git-svn-id: http://core.svn.wordpress.org/trunk@35648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:28:25 +00:00
Scott Taylor 19834a4c21 List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
Props bradyvercher.
Fixes #29870.

Built from https://develop.svn.wordpress.org/trunk@35683


git-svn-id: http://core.svn.wordpress.org/trunk@35647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:25:26 +00:00
Scott Taylor af0498989c List Tables: After [34728], don't try to infer `orderby` from query params.
List tables are really good.

Props cklosows.
Fixes #25493.

Built from https://develop.svn.wordpress.org/trunk@35682


git-svn-id: http://core.svn.wordpress.org/trunk@35646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:19:26 +00:00
Scott Taylor 8caf5d9759 Plugins: add dismissible notices to update failures.
Adds unit test.

Props afercia, mehulkaklotar.
Fixes #33465.

Built from https://develop.svn.wordpress.org/trunk@35681


git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
Boone Gorges 68b8f41780 Allow filtering by non-public taxonomies on edit.php.
[35333] enforces protection for taxonomies by preventing non-public taxonomies
from registering query_vars in `register_taxonomy()`. This broke the use of
taxonomy query_vars on edit.php, breaking backward compatibility and
creating inconsistency with the treatment introduced in [34247], which allowed
`taxonomy=foo` filtering on the Dashboard, even when `foo` is non-public. In
this changeset, we make the same Dashboard exception for the query_var.

Fixes #21949.
Built from https://develop.svn.wordpress.org/trunk@35680


git-svn-id: http://core.svn.wordpress.org/trunk@35644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:59:49 +00:00
Scott Taylor af0282891d Rewrite: alleviate conflicts between image attachment pages and posts when permalink structure is `/%postname%/`.
Adds unit test.

Props SergeyBiryukov.
Fixes #24612.

Built from https://develop.svn.wordpress.org/trunk@35679


git-svn-id: http://core.svn.wordpress.org/trunk@35643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:59:25 +00:00
Scott Taylor 13ea469061 Media: when making images responsive, check if they already have a `sizes` attribute.
Adds unit test.

Props jaspermdegroot.
Fixes #34678.

Built from https://develop.svn.wordpress.org/trunk@35678


git-svn-id: http://core.svn.wordpress.org/trunk@35642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:48:26 +00:00
Scott Taylor f2e9e98fa6 Media: in `media_send_to_editor()`, use `wp_json_encode()` instead of `addslashes()`.
Props TobiasBg.
Fixes #22135.

Built from https://develop.svn.wordpress.org/trunk@35677


git-svn-id: http://core.svn.wordpress.org/trunk@35641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:40:27 +00:00
Scott Taylor a9fb6e9ae0 Customizer i18n: provide translator context for current menu name and location.
Props ryankienstra.
Fixes #33431.

Built from https://develop.svn.wordpress.org/trunk@35676


git-svn-id: http://core.svn.wordpress.org/trunk@35640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:21:28 +00:00
Scott Taylor f1d0763785 Comments: after [35593], extend support to IE8 and improve checking for elements hidden with CSS
Props afercia.
Fixes #29974.

Built from https://develop.svn.wordpress.org/trunk@35675


git-svn-id: http://core.svn.wordpress.org/trunk@35639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:15:28 +00:00
Scott Taylor 838592c1ba List Tables: because we can never eradicate the existence of globals, ensure that `$comment` is hoisted into the global space inside `WP_Comments_List_Table::single_row()`.
Fixes #34654.

Built from https://develop.svn.wordpress.org/trunk@35674


git-svn-id: http://core.svn.wordpress.org/trunk@35638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:05:30 +00:00
Scott Taylor f0bbe00890 After [35616], improve the consistency of tabs styling.
Props afercia.
Fixes #34214.

Built from https://develop.svn.wordpress.org/trunk@35673


git-svn-id: http://core.svn.wordpress.org/trunk@35637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:55:26 +00:00
Drew Jaynes 3a45270a43 Docs: Properly mark optional parameters as such in the DocBlock and function signature for `wp_calculate_image_sizes()`.
Also updates the subsequent hook docs for the `wp_calculate_image_sizes` filter.

Props joemcgill.
Fixes #34612.

Built from https://develop.svn.wordpress.org/trunk@35672


git-svn-id: http://core.svn.wordpress.org/trunk@35636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:53:27 +00:00
John Blackbourn 407f641cf3 Update `WP_REST_Response::as_error()` to handle the new format error responses introduced in [35653].
Props danielbachhuber
Fixes #34551

Built from https://develop.svn.wordpress.org/trunk@35671


git-svn-id: http://core.svn.wordpress.org/trunk@35635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:29:26 +00:00
Sergey Biryukov bc41f44158 I18N: After [34424], replace the placeholder with comments count after `translate_nooped_plural()` runs, not before.
Props hnle.
Fixes #34680.
Built from https://develop.svn.wordpress.org/trunk@35670


git-svn-id: http://core.svn.wordpress.org/trunk@35634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:04:28 +00:00
Drew Jaynes 283b7d0a66 Plugins: Rename the `delete_plugin` action hook (introduced in [35094]) to `deleted_plugin` as it fires ''following'' a plugin deletion attempt.
Further, introduce a new `delete_plugin` action hook, to be fired ''before'' a plugin deletion attempt. Both changes bring parity with other such transactional hooks in core that fire before and after certain actions, including on plugin activation/deactivation and install/uninstall, among others.

Props johnjamesjacoby.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35669


git-svn-id: http://core.svn.wordpress.org/trunk@35633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:58:26 +00:00
Sergey Biryukov 8919d9a88a I18N: Move translatable Codex URLs to separate strings in `wp-includes/ms-load.php`.
Props ramiy.
Fixes #34687.
Built from https://develop.svn.wordpress.org/trunk@35668


git-svn-id: http://core.svn.wordpress.org/trunk@35632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:42:26 +00:00
Sergey Biryukov d9faafbd44 I18N: Move translatable Codex URLs to separate strings in `wp-includes/functions.php`.
Props ramiy.
See #34687.
Built from https://develop.svn.wordpress.org/trunk@35667


git-svn-id: http://core.svn.wordpress.org/trunk@35631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:41:27 +00:00
Sergey Biryukov 0d4cf36199 I18N: Remove `<a>` tag from translatable string in `wp-admin/includes/class-wp-comments-list-table.php`.
Props ramiy.
Fixes #34686.
Built from https://develop.svn.wordpress.org/trunk@35666


git-svn-id: http://core.svn.wordpress.org/trunk@35630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:34:27 +00:00
Sergey Biryukov 7cb5ca6b33 I18N: Remove `<a>` tag from translatable string in `wp-admin/comment.php`.
Props ramiy.
See #34686.
Built from https://develop.svn.wordpress.org/trunk@35665


git-svn-id: http://core.svn.wordpress.org/trunk@35629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:33:30 +00:00
Sergey Biryukov 5539193dd0 I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ftpsockets.php`.
Fixes #34684.
Built from https://develop.svn.wordpress.org/trunk@35664


git-svn-id: http://core.svn.wordpress.org/trunk@35628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:23:29 +00:00
Sergey Biryukov a7c5161db1 I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ftpext.php`.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35663


git-svn-id: http://core.svn.wordpress.org/trunk@35627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:22:27 +00:00
Sergey Biryukov 0237fadd3a I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-base.php`.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35662


git-svn-id: http://core.svn.wordpress.org/trunk@35626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:21:26 +00:00
Sergey Biryukov 6b94d7c89c I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ssh2.php`.
Props ramiy.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35661


git-svn-id: http://core.svn.wordpress.org/trunk@35625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:18:40 +00:00
John Blackbourn aeaea96bed Correct the parameter type for the `$stylesheet` parameter in the `mce_css` filter documentation.
Fixes #34721
Props hnle

Built from https://develop.svn.wordpress.org/trunk@35660


git-svn-id: http://core.svn.wordpress.org/trunk@35624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:07:37 +00:00
Ryan McCue 0801acbdd8 REST API: Remove redundant "0" parameter.
This is just an artifact of how we parse the URL, and is already available
via $request->get_route()

Props danielbachhuber.
Fixes #34647.

Built from https://develop.svn.wordpress.org/trunk@35659


git-svn-id: http://core.svn.wordpress.org/trunk@35623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 07:24:28 +00:00
Ella Iseulde Van Dorpe 72f09b29df TinyMCE 4.2.8 update
Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=889

(No plugin, theme, skin or test changes)

Fixes #34671 and #34720.

Built from https://develop.svn.wordpress.org/trunk@35658


git-svn-id: http://core.svn.wordpress.org/trunk@35622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 23:19:01 +00:00
Dominik Schilling 31ca684bb4 Buttons: Don't transform disabled buttons by 1px on `:active`.
Fixes #34717.
Built from https://develop.svn.wordpress.org/trunk@35657


git-svn-id: http://core.svn.wordpress.org/trunk@35621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 23:18:29 +00:00
Ryan McCue aa71d8b7ff oEmbed: Drop the trailing slash from the namespace.
Props swissspidy.
Fixes #34709.

Built from https://develop.svn.wordpress.org/trunk@35656


git-svn-id: http://core.svn.wordpress.org/trunk@35620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 11:27:29 +00:00
Gary Pendergast ffc4d6965c WPDB: Fall back to the connection charset when sanity checking strings.
If `DB_CHARSET` isn't defined (or is empty), `wpdb::$charset` will be empty, too. `wpdb::strip_invalid_text()` assumes that it isn't empty, however, so we need to fall back to the connection character set when we're running our sanity checks.

Fixes #34708.


Built from https://develop.svn.wordpress.org/trunk@35655


git-svn-id: http://core.svn.wordpress.org/trunk@35619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 06:13:26 +00:00
Ryan McCue 1a5f0d3857 REST API: Update tests for [35653]
See #34551.

Built from https://develop.svn.wordpress.org/trunk@35654


git-svn-id: http://core.svn.wordpress.org/trunk@35618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 05:27:25 +00:00
Ryan McCue 81ffd2492c REST API: Optimise for singular error instances.
Previously, the API returned a list of errors, as WP_Error can hold multiple
error codes internally. This isn't a particularly common use case, and it
makes handling errors on the client side more complex than it needs to be.

Fixes #34551.

Built from https://develop.svn.wordpress.org/trunk@35653


git-svn-id: http://core.svn.wordpress.org/trunk@35617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 04:12:26 +00:00
Ryan McCue 9524ebb38e REST API: Include enum and description in help data.
Props lcherpit.
Fixes #34543.

Built from https://develop.svn.wordpress.org/trunk@35652


git-svn-id: http://core.svn.wordpress.org/trunk@35616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 02:49:28 +00:00
Ryan McCue b03e036e94 REST API: Require namespace when registering routes.
Props danielbachhuber.
Fixes #34416.

Built from https://develop.svn.wordpress.org/trunk@35651


git-svn-id: http://core.svn.wordpress.org/trunk@35615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 02:39:30 +00:00
Ryan McCue b0ee5efef2 REST API: Change link relations to api.w.org
Fixes #34303.

Built from https://develop.svn.wordpress.org/trunk@35650


git-svn-id: http://core.svn.wordpress.org/trunk@35614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-17 02:24:27 +00:00
Dominik Schilling 9df7c4edea Passwords: Only disable hidden password fields if they are really hidden.
Makes the password field on install and for password resets editable again. Both fields were accidentally set to disabled in [35603].

Props adamsilverstein, flixos90.
Fixes #33699.
Built from https://develop.svn.wordpress.org/trunk@35649


git-svn-id: http://core.svn.wordpress.org/trunk@35613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:49:26 +00:00
Dominik Schilling c29fe96196 Thickbox: Change only the `background-image` property for HiDPI screens.
`background` resets `background-size` and makes the spinner fuzzy. Introduced in [35418].

See #33311.
Built from https://develop.svn.wordpress.org/trunk@35648


git-svn-id: http://core.svn.wordpress.org/trunk@35612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:33:25 +00:00
Dominik Schilling a7848ea08b Themes: Hide the favorites form when performing a search.
The search is global and ignores the user setting. Same for filters.

See #34206.
Built from https://develop.svn.wordpress.org/trunk@35647


git-svn-id: http://core.svn.wordpress.org/trunk@35611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:50:26 +00:00
Dominik Schilling 99f4fc4404 Themes: Check if the browse view is set in `wp_ajax_query_themes()` to avoid a PHP notice when searching for new themes.
Introduced in [35527].

See #34206.
Built from https://develop.svn.wordpress.org/trunk@35646


git-svn-id: http://core.svn.wordpress.org/trunk@35610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:47:54 +00:00
Boone Gorges 767518ffaa Correct documentation for 'fields' param of `WP_User_Query`.
[29843] introduced this documentation, and incorrectly stated that short
column names (eg 'login' instead of 'user_login') could be used.

Props birgire.
Fixes #34701.
Built from https://develop.svn.wordpress.org/trunk@35645


git-svn-id: http://core.svn.wordpress.org/trunk@35609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:04:55 +00:00
Dion Hulse 42ff945649 Decrease the chances that `wp_tempnam()` will conflict with an existing file by suffixing a random ID to the generated filename.
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.

Fixes #34562

Built from https://develop.svn.wordpress.org/trunk@35644


git-svn-id: http://core.svn.wordpress.org/trunk@35608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 05:33:25 +00:00
Weston Ruter acba061485 Customize: Ensure multi-line label alignment for checkbox/radio inputs on both desktop and mobile.
Follow-up to [35608].

Props bordoni, delawski.
Fixes #34607.

Built from https://develop.svn.wordpress.org/trunk@35643


git-svn-id: http://core.svn.wordpress.org/trunk@35607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 04:44:26 +00:00
Dion Hulse be94558c46 Upgrader: Pass the `$args['hook_extra']` context to the `upgrader_source_selection` filter.
Props afragen
Fixes #34696

Built from https://develop.svn.wordpress.org/trunk@35642


git-svn-id: http://core.svn.wordpress.org/trunk@35606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 02:47:25 +00:00
John Blackbourn 43bc6dc931 Revert [35639] pending investigation into failures on PHP 5.2.
See #19455

Built from https://develop.svn.wordpress.org/trunk@35641


git-svn-id: http://core.svn.wordpress.org/trunk@35605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 00:54:28 +00:00
Gary Pendergast 3783e497c6 Embeds: Add the `allow_insecure_embeds` filter.
This allows a site to disable non-SSL embeds.

Fixes #34588.


Built from https://develop.svn.wordpress.org/trunk@35640


git-svn-id: http://core.svn.wordpress.org/trunk@35604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 00:23:26 +00:00
John Blackbourn 45658705f3 On servers running PHP <= 5.4 which have `magic_quotes_sybase` enabled, the superglobals need to be magic-quoted before `magic_quotes_sybase` is subsequently disabled to avoid incorrect un-slashing. This must surely effect a miniscule number of servers, but so be it.
Fixes #19455
Props summerblue, kurtpayne, lucatume

Built from https://develop.svn.wordpress.org/trunk@35639


git-svn-id: http://core.svn.wordpress.org/trunk@35603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-15 23:00:28 +00:00
Dominik Schilling 40b303069a Schema: Increase length of `user_pass` and `user_activation_key` fields to 255.
Props grvrulz and Miglosh for testing.
Fixes #33904.
Built from https://develop.svn.wordpress.org/trunk@35638


git-svn-id: http://core.svn.wordpress.org/trunk@35602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-15 14:19:28 +00:00
Gary Pendergast 9974c9b18d Emoji: Ensure twemoji kicks in on certain DOM mutations.
Twemoji will replace the `img` with the emoji character, in the event that the image fails to load. We deliberately avoid trying to change that emoji character when it's changed back. We do need to replace emoji characters that are changed by something other than Twemoji, which this rectifies.

Fixes #34640.


Built from https://develop.svn.wordpress.org/trunk@35637


git-svn-id: http://core.svn.wordpress.org/trunk@35601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-14 09:52:29 +00:00
Helen Hou-Sandí ae9e173082 Buttons: Standardize on `.button-link` for link-like buttons.
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.

props paulwilde for the initial patch.
fixes #34242.

Built from https://develop.svn.wordpress.org/trunk@35636


git-svn-id: http://core.svn.wordpress.org/trunk@35600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 15:47:27 +00:00
Weston Ruter 268626d061 Customize: Exclude `referer` URL from being used for Close link if it is `customize.php`.
This fixes an edge case where the Close button could never link the user out of the Customizer, if the user initially accessed it without a `url` param and then clicked a link (provided by a plugin) that took them to another `customize.php` URL.

See #32637.

Built from https://develop.svn.wordpress.org/trunk@35635


git-svn-id: http://core.svn.wordpress.org/trunk@35599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 05:25:28 +00:00
Gary Pendergast 329bec7ca1 Embeds: Add support for the www subdomain to Instagram embed URLs.
Props skithund.

Fixes #34651.


Built from https://develop.svn.wordpress.org/trunk@35634


git-svn-id: http://core.svn.wordpress.org/trunk@35598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 23:04:27 +00:00
Aaron Jorbin 7552f6fb2a Remove PHP 7 from allowed failures list
PHP 7 has released it's 7th (and potentially final) Release Candidate today. While it is still not recommended for use in production, it is at a point that a test failure with it is something that needs to be triaged immediately. Congratulations to the PHP internals team on the upcoming final release of PHP 7.

Fixes #33410


Built from https://develop.svn.wordpress.org/trunk@35633


git-svn-id: http://core.svn.wordpress.org/trunk@35597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 21:45:29 +00:00
Sergey Biryukov 6209004bf7 Remove `<code>` tags from translatable string in `wp-includes/load.php`.
Add translator comment.

Props ramiy.
Fixes #34621.
Built from https://develop.svn.wordpress.org/trunk@35632


git-svn-id: http://core.svn.wordpress.org/trunk@35596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 18:21:24 +00:00
Sergey Biryukov 541ab45e8f Fix failing multisite test after [35629].
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35631


git-svn-id: http://core.svn.wordpress.org/trunk@35595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 17:12:25 +00:00
Sergey Biryukov 95c55ca251 Cast `'illegal_user_logins'` filter result to array.
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35630


git-svn-id: http://core.svn.wordpress.org/trunk@35594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:34:27 +00:00
Sergey Biryukov b08ae1d60b Users: After [35189], make `'illegal_user_logins'` check case-insensitive.
Props juliobox.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35629


git-svn-id: http://core.svn.wordpress.org/trunk@35593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:30:28 +00:00
Gary Pendergast 5e878b4e72 Build: Prevent non-breaking spaces from accidentally being inserted into JavaScript files.
See #34658.


Built from https://develop.svn.wordpress.org/trunk@35628


git-svn-id: http://core.svn.wordpress.org/trunk@35592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 12:05:26 +00:00
Gary Pendergast 6381e168b7 Pinking Shears: Remove some errant non-breaking spaces from a few JavaScript files.
Props francoisb.

Fixes #34658.


Built from https://develop.svn.wordpress.org/trunk@35627


git-svn-id: http://core.svn.wordpress.org/trunk@35591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 12:04:27 +00:00
Scott Taylor 23bc08f370 WordPress 4.4 Beta 4 version bump
Built from https://develop.svn.wordpress.org/trunk@35626


git-svn-id: http://core.svn.wordpress.org/trunk@35590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 00:03:25 +00:00
Scott Taylor 6cb728d295 WordPress 4.4 Beta 4
Built from https://develop.svn.wordpress.org/trunk@35625


git-svn-id: http://core.svn.wordpress.org/trunk@35589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:53:25 +00:00
Konstantin Obenland e1901c38c1 Template: Un-deprecate `wp_title()`.
Before it can be deprecated we should identify alternative usages and define
a path forward for them.

See [35294], #31078.


Built from https://develop.svn.wordpress.org/trunk@35624


git-svn-id: http://core.svn.wordpress.org/trunk@35588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:50:25 +00:00
Scott Taylor 35d501c5de Revert [35621], breaks XML-RPC unit tests.
See #30775.


Built from https://develop.svn.wordpress.org/trunk@35623


git-svn-id: http://core.svn.wordpress.org/trunk@35587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:34:27 +00:00
Scott Taylor 128a9c3acd List Tables: after [34271], account for searches when calculating pagination.
Fixes #29870.


Built from https://develop.svn.wordpress.org/trunk@35622


git-svn-id: http://core.svn.wordpress.org/trunk@35586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:14:26 +00:00
Scott Taylor 415ab45b9f Posts: allow empty posts to be deleted - `$maybe_empty` should not be set to `true` for updates.
Props DrewAPicture.
Fixes #30775.


Built from https://develop.svn.wordpress.org/trunk@35621


git-svn-id: http://core.svn.wordpress.org/trunk@35585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:49:50 +00:00
Sergey Biryukov c8e0cd5c65 I18N: In `Translations::translate_entry()`, account for multi-line strings in files with Windows line endings.
Fixes #22172.
Built from https://develop.svn.wordpress.org/trunk@35620


git-svn-id: http://core.svn.wordpress.org/trunk@35584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:49:25 +00:00
Dominik Schilling 1f15d30396 Upgrade: Revert [34543] because of incomplete and incorrect functionality.
See #33932.
Fixes #34434.
Built from https://develop.svn.wordpress.org/trunk@35619


git-svn-id: http://core.svn.wordpress.org/trunk@35583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:46:26 +00:00
Scott Taylor 9eb60905f2 Users: in `wp_insert_user()`, when a password isn't provided and the user exists, ensure that the password isn't wiped out.
Adds unit test.

Props leewillis77.
Fixes #29880.

Built from https://develop.svn.wordpress.org/trunk@35618


git-svn-id: http://core.svn.wordpress.org/trunk@35582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:31:26 +00:00
Scott Taylor e6611c6b01 Mail: after [33124], add unit tests.
Props mdawaffe.
Fixes #28039.

Built from https://develop.svn.wordpress.org/trunk@35617


git-svn-id: http://core.svn.wordpress.org/trunk@35581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:05:26 +00:00
Scott Taylor b4daf516ec Help/About: unify tab styling.
Props afercia.
Fixes #34214.

Built from https://develop.svn.wordpress.org/trunk@35616


git-svn-id: http://core.svn.wordpress.org/trunk@35580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 21:54:26 +00:00
Dominik Schilling 27e4384e89 Comments: Dynamically update the document title text for all languages, not only English.
See [33821].
Fixes #33414.
Built from https://develop.svn.wordpress.org/trunk@35615


git-svn-id: http://core.svn.wordpress.org/trunk@35579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 21:00:27 +00:00
Sergey Biryukov db8c89cccb Remove non-translatable HTML code from the first post content in `populate_network()` and `wp_install_defaults()`.
Add translator comment.

Props ramiy.
Fixes #34619.
Built from https://develop.svn.wordpress.org/trunk@35614


git-svn-id: http://core.svn.wordpress.org/trunk@35578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 20:55:26 +00:00
Sergey Biryukov d206e633c2 Users: Only show the profile picture if 'Show Avatars' option in Discussion Settings is enabled.
Props ocean90.
See #32286.
Built from https://develop.svn.wordpress.org/trunk@35613


git-svn-id: http://core.svn.wordpress.org/trunk@35577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:41:25 +00:00
Dominik Schilling 5403b62a6a REST API: Use correct `@access` tag for `WP_REST_Request->get_parameter_order()`.
Props Frozzare.
Fixes #34624.
Built from https://develop.svn.wordpress.org/trunk@35612


git-svn-id: http://core.svn.wordpress.org/trunk@35576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:39:25 +00:00
Dominik Schilling 0251086dec About: Don't use `_n_noop()` for singular/plural strings which provide no placeholder for a number.
This allows for using proper plural forms in languages with more than two forms.

Props SergeyBiryukov.
Fixes #34307.
See #28502.
Built from https://develop.svn.wordpress.org/trunk@35611


git-svn-id: http://core.svn.wordpress.org/trunk@35575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:29:25 +00:00
Sergey Biryukov 694ff83cc6 Users: Add user's Gravatar to 'About the user' section on user profile page.
Add `user_profile_picture_description` filter for the description text displayed under the Gravatar.

Props carolinegeven, obrienlabs, SergeyBiryukov.
Fixes #32286.
Built from https://develop.svn.wordpress.org/trunk@35610


git-svn-id: http://core.svn.wordpress.org/trunk@35574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:28:28 +00:00
Andrea Fercia 62e236b3c6 Accessibility: Improve form labels and descriptions for the Tags meta box in the Edit Post screen.
Fixes #34627.
Built from https://develop.svn.wordpress.org/trunk@35609


git-svn-id: http://core.svn.wordpress.org/trunk@35573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 15:24:29 +00:00
Weston Ruter 025074bbda Customize: Prevent multi-line checkbox control labels from wrapping under checkbox.
Props bordoni.
Fixes #34607.

Built from https://develop.svn.wordpress.org/trunk@35608


git-svn-id: http://core.svn.wordpress.org/trunk@35572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 09:37:27 +00:00
Andrew Ozz 7e1c68ea78 TinyMCE:
- Fix the inline toolbar on images in iOS, move it out of the way so the default inline toolbar is not over it.
- Fix selecting images on touch in the editor (iOS Safari fails to select them most of the time).

Fixes #34557.
Built from https://develop.svn.wordpress.org/trunk@35607


git-svn-id: http://core.svn.wordpress.org/trunk@35571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 03:27:25 +00:00
Gary Pendergast d3f30288e9 Emoji: Use twemoji in browsers that don't support Unicode 8 emoji.
Some less advanced browsers are yet to add support for the important advances made in Unicode 8. Let's make ensure that their users can experience emoji in their full glory.

See #33592.


Built from https://develop.svn.wordpress.org/trunk@35606


git-svn-id: http://core.svn.wordpress.org/trunk@35570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 02:25:25 +00:00
Andrea Fercia 5f93491286 Accessibility: improvements for the taxonomies Quick Edit form.
Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to `wp.a11y.speak`
to give assistive technologies users an audible feedback.

Patch prepared at #wpcdit, first Italian WordPress Contributor Day.

Props garusky, chiara_09.
Fixes #34613.
Built from https://develop.svn.wordpress.org/trunk@35605


git-svn-id: http://core.svn.wordpress.org/trunk@35569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 00:24:28 +00:00
Drew Jaynes eba05b2c98 Permalinks: Use "Plain" instead of "None" for the `?p-###`, which is still a valid permalink structure, just not a "pretty" one.
Permalinks are enabled by default (where supported) since in 4.2. When that change was made, it rended the "Default" label (previous to [35599]) inaccurate.

Props Ankit-K-Gupta.
Fixes #34509.

Built from https://develop.svn.wordpress.org/trunk@35604


git-svn-id: http://core.svn.wordpress.org/trunk@35568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 22:19:27 +00:00
Dominik Schilling 66dee42444 Passwords: Disable hidden input fields on profile/user edit page.
Prevents an issue where password helpers would autofill the hidden password fields and inadvertently causing password changes when editing other fields on the profile page.

Props adamsilverstein.
Fixes #33699.
Built from https://develop.svn.wordpress.org/trunk@35603


git-svn-id: http://core.svn.wordpress.org/trunk@35567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 20:41:26 +00:00
Andrew Ozz 93fa052e49 TinyMCE: prevent resize handles in newer IE when inserting a wpView.
Fixes #29400.
Built from https://develop.svn.wordpress.org/trunk@35602


git-svn-id: http://core.svn.wordpress.org/trunk@35566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 19:33:26 +00:00
Drew Jaynes a90d108b82 Docs: Remove an empty line from the hook doc for the `wp_calculate_image_srcset` filter, introduced in [35592].
Props kraftbj.
See #34612.

Built from https://develop.svn.wordpress.org/trunk@35601


git-svn-id: http://core.svn.wordpress.org/trunk@35565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 17:15:29 +00:00
Dion Hulse 49e6e41fb4 Update random_compat to master.
Clarifies strings, Merges [35587] upstream.
See #34409, #28633

Built from https://develop.svn.wordpress.org/trunk@35600


git-svn-id: http://core.svn.wordpress.org/trunk@35564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 12:00:30 +00:00
Drew Jaynes c5a8c3aa86 Permalinks: Rename the "Default" permalink structure to "None" as permalinks have been enabled by default (where supported) since 4.2.
Updates help tabs and contextual text to match.

Props johnbillion, DrewAPicture.
Fixes #34509.

Built from https://develop.svn.wordpress.org/trunk@35599


git-svn-id: http://core.svn.wordpress.org/trunk@35563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 06:58:25 +00:00
Drew Jaynes 626549448a Docs: Move an inline comment that was preventing the hook docs for the `user_has_cap` filter from being parsed.
Props ocean90.
Fixes #34639.

Built from https://develop.svn.wordpress.org/trunk@35598


git-svn-id: http://core.svn.wordpress.org/trunk@35562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 06:45:25 +00:00
Andrew Ozz 8b3c5fb300 TinyMCE: always remove trailing `<br>` added by WebKit browsers to the clipboard.
Fixes #34642.
Built from https://develop.svn.wordpress.org/trunk@35597


git-svn-id: http://core.svn.wordpress.org/trunk@35561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 04:32:25 +00:00
Gary Pendergast 1f24f52673 Emoji: Add some new flags, and a handful from Unicode 8.0.
Including the following that should be used as often as possible:

U+1F1E6 U+1F1FA Flag for Australia
U+1F3CF Cricket Bat and Ball
U+1F32F Burrito

See #33592.


Built from https://develop.svn.wordpress.org/trunk@35596


git-svn-id: http://core.svn.wordpress.org/trunk@35560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 03:35:25 +00:00
Andrew Ozz f34c16674a Responsive images: fix args order and streamline the srcset and sizes generation and better inline docs in `get_header_image_tag()`.
See #21389.
Built from https://develop.svn.wordpress.org/trunk@35595


git-svn-id: http://core.svn.wordpress.org/trunk@35559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 01:59:25 +00:00
Andrew Ozz a86cac1676 Responsive images: add template helper functions to generate the tag for a (responsive) header image that includes srcset and sizes attributes.
Props Otto42, joemcgill, DH-Shredder, azaozz.
Fixes #21389.
Built from https://develop.svn.wordpress.org/trunk@35594


git-svn-id: http://core.svn.wordpress.org/trunk@35558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 01:17:26 +00:00
Andrea Fercia e6e4496822 Comments: in `comment_form()` when replying to a comment ensure to set focus on the first focusable form element, regardless of what that form element is.
Props azaozz.
See #29974.
Built from https://develop.svn.wordpress.org/trunk@35593


git-svn-id: http://core.svn.wordpress.org/trunk@35557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 00:43:26 +00:00
Drew Jaynes c98b62c452 Docs: Fix some formatting in the hook doc for the `wp_calculate_image_srcset` filter and clarify the summary.
See #34612.

Built from https://develop.svn.wordpress.org/trunk@35592


git-svn-id: http://core.svn.wordpress.org/trunk@35556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 23:34:27 +00:00
Andrew Ozz 7d0aa3a54a Responsive images: properly arrange the parameters for the `wp_calculate_image_srcset` filter and add fix the inline documentation.
Props joemcgill.
Fixes #34612.
Built from https://develop.svn.wordpress.org/trunk@35591


git-svn-id: http://core.svn.wordpress.org/trunk@35555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 23:30:26 +00:00
Konstantin Obenland 5eeeeb89ce Menu: Continue to use post dashicon as default menu icon.
Prevents a bug where custom post types without a specified menu icon would
adopt the menu icon of the preceding post type. Introduced in [33723].

See #16865.
Fixes #34637.


Built from https://develop.svn.wordpress.org/trunk@35590


git-svn-id: http://core.svn.wordpress.org/trunk@35554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 22:00:26 +00:00
Andrew Ozz 42a955a89b TinyMCE: update the keyboard shortcuts for the link dialog in the `wplink` plugin. Fixes Ctrl + Alt + A on MacOS.
Fixes #34636.
Built from https://develop.svn.wordpress.org/trunk@35589


git-svn-id: http://core.svn.wordpress.org/trunk@35553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 21:32:28 +00:00
Boone Gorges 02532ee7d5 Fix documentation typo introduced in [35585].
Props swissspidy, barryceelen.
See #34626.
Built from https://develop.svn.wordpress.org/trunk@35588


git-svn-id: http://core.svn.wordpress.org/trunk@35552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 14:03:28 +00:00
Dion Hulse f9c7ca8496 Random_Compat: Bump the OpenSSL requirement for windows servers to 5.4.1 while the upstream issue is resolved.
Before PHP 5.4.1 the OpenSSL extension used a OpenSSL provided function which is seemingly slow under some circumstances, PHP 5.4.1+ uses the windows crypto API.

Fixes #34409

Built from https://develop.svn.wordpress.org/trunk@35587


git-svn-id: http://core.svn.wordpress.org/trunk@35551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 04:50:25 +00:00
Dion Hulse 2103984c02 Fix a typo in a docblock
Built from https://develop.svn.wordpress.org/trunk@35586


git-svn-id: http://core.svn.wordpress.org/trunk@35550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:38:26 +00:00
Boone Gorges 545124ffb3 When deleting a term, delete its metadata as well.
Props barryceelen.
Fixes #34626.
Built from https://develop.svn.wordpress.org/trunk@35585


git-svn-id: http://core.svn.wordpress.org/trunk@35549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:36:26 +00:00
Weston Ruter f4659f7ee0 Customize: Fix focus and autofocus on `nav_menu_item` controls.
Embed the `nav_menu_item` control not only when the contained `nav_menu` section expands, but also if the control was autofocused (via the `autofocus[control]` query param). Also applies change from [33596] to work-around a broken `:focusable` selector in jQuery UI.

See #33258.
Fixes #34629.

Built from https://develop.svn.wordpress.org/trunk@35584


git-svn-id: http://core.svn.wordpress.org/trunk@35548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:14:25 +00:00
Weston Ruter 1032bc6775 Customize: Fix broken unit test for `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`.
Fixes issue in [35580] which caused unit tests to fail while run under multisite.

Fixes #32812.


Built from https://develop.svn.wordpress.org/trunk@35583


git-svn-id: http://core.svn.wordpress.org/trunk@35547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 02:56:25 +00:00
Dion Hulse 09ada24c99 Upgrade: Force disable the rest-api plugin on upgrade to 4.4 unless it's beta5+. Previous versions of the plugin were not configured correctly to gradefully degrade during update which would cause fatal errors.
Props wonderboymusic.
Fixes #34415

Built from https://develop.svn.wordpress.org/trunk@35582


git-svn-id: http://core.svn.wordpress.org/trunk@35546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 01:22:28 +00:00
Weston Ruter 5411447dd3 Customize: Fix sub-nav menu items from appearing to bump to root level in preview upon saving.
This issue would appear when the parent nav menu item was also newly-inserted. The issue was only apparent in the prevew, as the actual data saved was correct. The `menu_item_parent` properties of the saved sub-nav menu items needed to get updated to refer to the newly-inserted parent `nav_menu_item` post IDs, as opposed to retaining the placeholder IDs.

Fixes #34628.

Built from https://develop.svn.wordpress.org/trunk@35581


git-svn-id: http://core.svn.wordpress.org/trunk@35545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 01:19:26 +00:00
Weston Ruter c470b872bd Customize: Improve alignment of `WP_Customize_Nav_Menu_Item_Setting::sanitize()` behavior with `wp_update_nav_menu_item()`.
* Apply `title_save_pre`, `excerpt_save_pre`, and `content_save_pre` filters on a nav menu item's `title`, `attr_title`, and `description` properties respectively. This ensures that arbitrary markup can be supplied if the user has `unfiltered_html` cap, and for these fields to have markup stripped if not.
* Ensure a nav menu item's `post_status` is sanitized as `publish` or `draft` using the same conditions as `wp_update_nav_menu_item()`.
* Align `WP_Customize_Nav_Menu_Item_Setting::sanitize()` behavior for sanitizing `position` to be the same as `wp_update_nav_menu_item()`.
* Also apply `nav_menu_attr_title` and `nav_menu_description` filters in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()` to ensure that previewing markup entered into menu item description will preview the same way as when the nav menu item is saved.
* Add unit tests.

Fixes #32812.

Built from https://develop.svn.wordpress.org/trunk@35580


git-svn-id: http://core.svn.wordpress.org/trunk@35544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 00:48:26 +00:00
Dion Hulse f47801d504 Media: Allow `media_sideload_image()` to work when the upload directory is a PHP Stream. Using copy() instead of rename() allows the function to work across different stream sources.
Props mattheu.
Fixes #29257

Built from https://develop.svn.wordpress.org/trunk@35579


git-svn-id: http://core.svn.wordpress.org/trunk@35543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 00:44:27 +00:00
Gary Pendergast af06409b97 Embeds: Add a filter for the site title HTML.
Props swissspidy.

Fixes #34534.



Built from https://develop.svn.wordpress.org/trunk@35578


git-svn-id: http://core.svn.wordpress.org/trunk@35542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 00:11:26 +00:00
Gary Pendergast a2349a2377 Embeds: Fix support for embedding in non-WordPress sites.
This moves the last of the iframe message code from PHP to JavaScript, so it can be included in any site, without needing to rely on any of WordPress' internal behaviour.

Props swissspidy.

Fixes #34451.


Built from https://develop.svn.wordpress.org/trunk@35577


git-svn-id: http://core.svn.wordpress.org/trunk@35541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 00:08:27 +00:00
Dominik Schilling 5e0dac0f8f Widgets: Fix typo in `WP_Widget_Tag_Cloud::form()`.
Props skithund.
Fixes #34623.
Built from https://develop.svn.wordpress.org/trunk@35576


git-svn-id: http://core.svn.wordpress.org/trunk@35540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 20:35:27 +00:00
Jeremy Felt 23c1050fb9 MS: Allow "Network Admin Email" to be a non-user during network setup.
The network admin email setting for a network is often used as a catch-all or notification email separate from the actual user ID set as the owner of the new network. If a non-user email address is set during network installation, we can defer to the current user as the actual network admin and apply the entered email as the address to which general notifications are sent and emails are sent from.

In the future, we'll want to update the messaging around "Network Admin Email" to reflect its reality. See #34293.

Props jjeaton.
Fixes #34065.

Built from https://develop.svn.wordpress.org/trunk@35575


git-svn-id: http://core.svn.wordpress.org/trunk@35539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 03:16:26 +00:00
Andrew Ozz 9fb7dcc30d TinyMCE: update to 4.2.7. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=888
Fixes #34620.
Built from https://develop.svn.wordpress.org/trunk@35574


git-svn-id: http://core.svn.wordpress.org/trunk@35538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 02:32:26 +00:00
Jeremy Felt c0a3348487 Multisite: Clarify documentation for `WP_Network::get_by_path()`.
See #31985.

Built from https://develop.svn.wordpress.org/trunk@35573


git-svn-id: http://core.svn.wordpress.org/trunk@35537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 02:25:25 +00:00
Jeremy Felt f3c2c7350c Site Icon: Wrap site icon retrieval with `switch_to_blog()` as needed.
When the site icon for another site is requested, retrieving its ID via `get_blog_option()` is not enough. `switch_to_blog()` is used to set proper context when required.

Adds multsite tests for `has_site_icon()`.

Props imath.
Fixes #34312.

Built from https://develop.svn.wordpress.org/trunk@35572


git-svn-id: http://core.svn.wordpress.org/trunk@35536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 02:04:27 +00:00
Jeremy Felt d1c09d96bf Site Icon: Use new `wp_get_attachment_image_url()` to retrieve URL.
`wp_get_attachment_image_url()` is a nice replacement for `wp_get_attachment_image_src()` here after its introduction in 4.4.

Props imath.
See #34312.

Built from https://develop.svn.wordpress.org/trunk@35571


git-svn-id: http://core.svn.wordpress.org/trunk@35535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 01:59:26 +00:00
Sergey Biryukov a4dc43106c Remove `<code>` tags from translatable string in `wp-admin/network/settings.php`.
Add translator comment.

Props ramiy.
Fixes #34618.
Built from https://develop.svn.wordpress.org/trunk@35570


git-svn-id: http://core.svn.wordpress.org/trunk@35534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 01:34:26 +00:00
Andrew Ozz 1b44ae6663 Responsive images: make the new functions and filters signatures more consistent.
Props joemcgill.
Fixes #34612.
Built from https://develop.svn.wordpress.org/trunk@35569


git-svn-id: http://core.svn.wordpress.org/trunk@35533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 21:36:27 +00:00
Scott Taylor 175064637f Administration: when hiding the login modal and unbind the auth check, also unbind the heartbeat auth check.
Props nofearinc.
Fixes #28962.

Built from https://develop.svn.wordpress.org/trunk@35568


git-svn-id: http://core.svn.wordpress.org/trunk@35532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:22:25 +00:00
Scott Taylor e649fabb6a Accessibility: add missing `alt` attributes to a gaggle of `<img>`s.
Props afercia.
Fixes #34583.

Built from https://develop.svn.wordpress.org/trunk@35567


git-svn-id: http://core.svn.wordpress.org/trunk@35531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:12:27 +00:00
Scott Taylor b17272831c List Tables: fix row links CSS for RTL.
Props afercia.
Fixes #34150.

Built from https://develop.svn.wordpress.org/trunk@35566


git-svn-id: http://core.svn.wordpress.org/trunk@35530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:05:25 +00:00
Scott Taylor 7a24b60c2a List Tables: to ensure that `get_primary_column_name()` can match columns that were added via the `"manage_{$screen->id}_columns"` filer, call `get_column_headers()` instead of `$this->get_columns()`.
List Table classes and `WP_Screen` are already tangled together. The parent list table constructor adds a filter that is called by a function that references the instance globally, even though we have access to it via composition directly in the class that is adding the filter. So the fact that functions here have to be called that reference a screen instance we already have access to is what one might call... less than elegant.

#OOP

Props SergeyBiryukov.
Fixes #34508.

Built from https://develop.svn.wordpress.org/trunk@35565


git-svn-id: http://core.svn.wordpress.org/trunk@35529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 15:27:25 +00:00
Dominik Schilling a3d58b3fbe Build Tools: Update the `preserveComments` option for `uglify:jqueryui`.
Uglify2 doesn't support the value "some" anymore. Replace it with the `/^!/` regex which produces the same output as before.

See https://build.trac.wordpress.org/changeset/35502 and https://build.trac.wordpress.org/changeset/35528.
Fixes #34177.
Built from https://develop.svn.wordpress.org/trunk@35564


git-svn-id: http://core.svn.wordpress.org/trunk@35528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 12:37:26 +00:00
Dominik Schilling adc233f617 Build Tools: Update `autoprefixer` to 0.6.1.
Release Post: https://github.com/postcss/autoprefixer/releases/tag/6.1.0

Includes changes to CSS files after `grunt precommit` because of the new transition support and a new parser for gradients (see [34637]).

See #34177.
Built from https://develop.svn.wordpress.org/trunk@35563


git-svn-id: http://core.svn.wordpress.org/trunk@35527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 11:57:31 +00:00
Dominik Schilling 4c5347fe1a Build Tools: Update `grunt-postcss` to 0.7.1.
Change: https://github.com/nDmitry/grunt-postcss/commit/6e18c7d5

See #34177.
Built from https://develop.svn.wordpress.org/trunk@35562


git-svn-id: http://core.svn.wordpress.org/trunk@35526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 11:43:34 +00:00
Andrew Ozz 72a1124c45 Responsive images: omit full size images from srcset attributes when the original file is an intermediate sized GIF so we don't accidentally add animation to an otherwise flat image. Update the tests to cover this case.
Props joemcgill, H-Shredder, SergeyBiryukov.
Fixes #34528.
Built from https://develop.svn.wordpress.org/trunk@35561


git-svn-id: http://core.svn.wordpress.org/trunk@35525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 02:10:25 +00:00
Andrew Ozz be44f0a3f7 Responsive images: add test for invalid size name. Remove invalid size from other tests.
Props jaspermdegroot.
See #33641.
Built from https://develop.svn.wordpress.org/trunk@35560


git-svn-id: http://core.svn.wordpress.org/trunk@35524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 01:33:27 +00:00
Sergey Biryukov 788ea5ba5a Reset Password: Improve wording for a string used in password reset email.
Props obrienlabs.
Fixes #34605.
Built from https://develop.svn.wordpress.org/trunk@35559


git-svn-id: http://core.svn.wordpress.org/trunk@35523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 22:36:25 +00:00
Drew Jaynes efdc838019 Docs: Add a missing version to the file header for wp-admin/users.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35558


git-svn-id: http://core.svn.wordpress.org/trunk@35522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 21:54:33 +00:00
Sergey Biryukov 9dd3f6fb16 Remove `<code>` tags from translatable strings in `wp-admin/setup-config.php`.
Add translator comments.

Props ramiy.
Fixes #34579.
Built from https://develop.svn.wordpress.org/trunk@35557


git-svn-id: http://core.svn.wordpress.org/trunk@35521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 17:22:26 +00:00
Sergey Biryukov 2583c1e4ec Replace `7 * DAY_IN_SECONDS` with `WEEK_IN_SECONDS` in `get_weekstartend()`.
Props MikeHansenMe.
Fixes #34603.
Built from https://develop.svn.wordpress.org/trunk@35556


git-svn-id: http://core.svn.wordpress.org/trunk@35520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 16:37:27 +00:00
Sergey Biryukov 5f16d19be7 Use the `MONTH_IN_SECONDS` constant added in [33698] for the month representation in `human_time_diff()` logic.
Props tyxla.
Fixes #34602.
Built from https://develop.svn.wordpress.org/trunk@35555


git-svn-id: http://core.svn.wordpress.org/trunk@35519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 16:34:26 +00:00
Sergey Biryukov 7ad65267b6 Media: Avoid a PHP warning in `wp_generate_attachment_metadata()` if `$metadata` is not an array.
This was previously fixed in [25968], but accidentally reverted in [32545].

Props skithund.
Fixes #34599.
Built from https://develop.svn.wordpress.org/trunk@35554


git-svn-id: http://core.svn.wordpress.org/trunk@35518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 09:25:26 +00:00
Weston Ruter b9d9c6d3c9 Customize: Fix typo in `WP_Customize_Manager::_cmp_priority()` which caused unstable sorting for same-priority constructs in PHP.
The issue, however, does not manifest in the UI because the UI is now built via JS and the `wp.customize.utils.prioritySort()` algorithm did not have the same typo.

Props bordoni, westonruter.
Fixes #34594.

Built from https://develop.svn.wordpress.org/trunk@35553


git-svn-id: http://core.svn.wordpress.org/trunk@35517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 06:58:25 +00:00
Sergey Biryukov cbe0cad509 Remove `<code>` tags from translatable strings in `wp-admin/includes/network.php`.
Add translator comments.

Props ramiy.
Fixes #34598.
Built from https://develop.svn.wordpress.org/trunk@35552


git-svn-id: http://core.svn.wordpress.org/trunk@35516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:59:25 +00:00
Sergey Biryukov d6e25c0aae Remove `<code>` tags from translatable strings in `wp-admin/includes/class-wp-upgrader.php`.
Add translator comments.

Props ramiy.
Fixes #34580.
Built from https://develop.svn.wordpress.org/trunk@35551


git-svn-id: http://core.svn.wordpress.org/trunk@35515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:41:25 +00:00
Sergey Biryukov 8c2ed5330a Remove `<code>` tag from translatable string in `wp-admin/options-media.php`.
Add translator comment.

Props ramiy.
Fixes #34581.
Built from https://develop.svn.wordpress.org/trunk@35550


git-svn-id: http://core.svn.wordpress.org/trunk@35514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:28:25 +00:00
Sergey Biryukov 387d3bca32 Add translator comments for strings in `wp-admin/edit-comments.php`.
Props ramiy for initial patch.
Fixes #34586.
Built from https://develop.svn.wordpress.org/trunk@35549


git-svn-id: http://core.svn.wordpress.org/trunk@35513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:23:25 +00:00
Sergey Biryukov 77b0fad640 Remove `<code>` tags from translatable strings in `wp-includes/class-wp-user.php`.
Add translator comments.

Props ramiy.
Fixes #34576.
Built from https://develop.svn.wordpress.org/trunk@35548


git-svn-id: http://core.svn.wordpress.org/trunk@35512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:06:25 +00:00
Sergey Biryukov a0fa0d3328 Remove `<code>` tags from translatable strings in `wp-load.php`.
Add translator comments.

Props ramiy.
Fixes #34574.
Built from https://develop.svn.wordpress.org/trunk@35547


git-svn-id: http://core.svn.wordpress.org/trunk@35511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 23:59:26 +00:00
Sergey Biryukov b5b3b0b913 Remove `<code>` tag from translatable string in `trackback_url()`.
Add translator commment.

Props ramiy.
Fixes #34573.
Built from https://develop.svn.wordpress.org/trunk@35546


git-svn-id: http://core.svn.wordpress.org/trunk@35510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 23:39:25 +00:00
Sergey Biryukov 09b9fae4db Remove `<code>` tag from translatable string in `the_author()`.
Add translator commment.

Props ramiy.
See #34573.

Built from https://develop.svn.wordpress.org/trunk@35545


git-svn-id: http://core.svn.wordpress.org/trunk@35509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 23:38:27 +00:00
Sergey Biryukov 123765d9c8 I18N: Add a translator comment for the string introduced in [24758] and made translatable in [29840].
Props swissspidy.
See #34249.
Built from https://develop.svn.wordpress.org/trunk@35544


git-svn-id: http://core.svn.wordpress.org/trunk@35508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 21:18:25 +00:00
Sergey Biryukov a7e305b06f Use correct placeholders in translator comments added in [35542].
See #34249.
Built from https://develop.svn.wordpress.org/trunk@35543


git-svn-id: http://core.svn.wordpress.org/trunk@35507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 21:05:25 +00:00
Drew Jaynes 48f4b7cfc3 I18N: Add translator comments to three `_doing_it_wrong()` messages added for 4.3 and 4.4.
Also adds a full-stop to an invalid taxonomy message introduced in [34745] and later modified in [35428] for `wp_insert_post()`.

Props pavelevap.
Fixes #34249.

Built from https://develop.svn.wordpress.org/trunk@35542


git-svn-id: http://core.svn.wordpress.org/trunk@35506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 20:56:32 +00:00
Aaron Jorbin 627844ca34 Bump grunt-contrib-cssmin to 0.14.0
This updates the underlying version of cssmin

Fixes #34177


Built from https://develop.svn.wordpress.org/trunk@35541


git-svn-id: http://core.svn.wordpress.org/trunk@35505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 17:58:28 +00:00
Aaron Jorbin 63026a897c Bump grunt-contrib-copy to 0.8.2
updates an underlying dependency and fixes an issue with multiple copies

see #34177


Built from https://develop.svn.wordpress.org/trunk@35540


git-svn-id: http://core.svn.wordpress.org/trunk@35504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 17:56:30 +00:00
Aaron Jorbin 25d8f212b7 Bump grunt-sass to 1.1.0
This bumps the underlying version of node-sass to 3.4.0 and libsass to 3.3.0. It causes no difference in the current sass output.

Props netweb.
See #34177.


Built from https://develop.svn.wordpress.org/trunk@35539


git-svn-id: http://core.svn.wordpress.org/trunk@35503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 17:53:43 +00:00
Aaron Jorbin d60ca2f758 Bump grunt-contrib-uglify to 0.10.0
This includes an update to the underlying version of uglify which causes all of the JS to be modified.

See #34177


Built from https://develop.svn.wordpress.org/trunk@35538


git-svn-id: http://core.svn.wordpress.org/trunk@35502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 17:47:30 +00:00
Boone Gorges 91a5e4c502 Make `get_term()` behave more consistently in the context of shared terms.
When `WP_Term` was introduced in [34997], the `$taxonomy` parameter for
`get_term()` was made optional. This meant that, when the optional param was
omitted, `get_term()` had no way of determining which term was intended when
the term_id was shared between multiple taxonomies. As a (somewhat sneaky) way
of fixing things, `get_term()` split any shared terms it found. But this could
cause problems with developer expectations: it's not clear why requesting a
term should result in a database update, much less a potential change in the
ID of a term.

In place of this technique, this changeset introduces a number of changes that
make the handling of shared terms a bit less insane:

* When a taxonomy is provided to `get_term()`, and a cached term is found matching the term_id, make sure the taxonomy also matches before returning it.
* When a taxonomy is not provided, ensure that the term is not shared before adding it to the cache.
* When a term is shared between taxonomies and no taxonomy is provided, return a `WP_Error` rather than splitting the term.
* When a term is shared between taxonomies, only one of which is valid, return the term from that taxonomy.

Props boonebgorges, dlh.
Fixes #34533.
Built from https://develop.svn.wordpress.org/trunk@35537


git-svn-id: http://core.svn.wordpress.org/trunk@35501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 16:45:25 +00:00
Sergey Biryukov 3caaa702bf Comments: Use `_n()` in `get_comments_number_text()` when setting the default string for multiple comments.
Fixes #34593.
Built from https://develop.svn.wordpress.org/trunk@35536


git-svn-id: http://core.svn.wordpress.org/trunk@35500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 15:36:28 +00:00
Weston Ruter 1a55cbe59d Customize: Hide "Change" button in themes section if there are fewer than two available themes.
Props danielbachhuber, westonruter.
Fixes #34549.

Built from https://develop.svn.wordpress.org/trunk@35535


git-svn-id: http://core.svn.wordpress.org/trunk@35499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 01:26:25 +00:00
Weston Ruter e0ac4e4d05 Customize: Correct phpdoc `@return` type for `WP_Customize_Manager::add_dynamic_settings()`.
Fixes regression in [32032], where `WP_Customize_Setting[]` should have been changed to `array` instead of `WP_Customize_Setting`.

See #31888.

Built from https://develop.svn.wordpress.org/trunk@35534


git-svn-id: http://core.svn.wordpress.org/trunk@35498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 00:43:24 +00:00
Gary Pendergast 84c8243514 Themes: Remove an errant comma from `theme.js`.
Added in [35527].

See #34206.


Built from https://develop.svn.wordpress.org/trunk@35533


git-svn-id: http://core.svn.wordpress.org/trunk@35497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 23:49:26 +00:00
Gary Pendergast 27df997eed Media Library: After [35499], increase the specificity of our selectors so that they don't cause problems for the `wp-admin` Media Library page.
Props aaronrutley.

Fixes #32005.


Built from https://develop.svn.wordpress.org/trunk@35532


git-svn-id: http://core.svn.wordpress.org/trunk@35496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 23:43:26 +00:00
Dominik Schilling 2c54b0358e After [35518] define `$_POST['post_view']` in `test_dont_process_terms_if_taxonomy_does_not_allow_show_on_quick_edit()`.
See #34577.
Built from https://develop.svn.wordpress.org/trunk@35531


git-svn-id: http://core.svn.wordpress.org/trunk@35495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 23:06:24 +00:00
Scott Taylor 07bb2da0c9 Bump 4.4-beta3 (again, again)
Built from https://develop.svn.wordpress.org/trunk@35530


git-svn-id: http://core.svn.wordpress.org/trunk@35494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 22:03:24 +00:00
Scott Taylor 14aca69402 4.4-beta3 (again)
Built from https://develop.svn.wordpress.org/trunk@35529


git-svn-id: http://core.svn.wordpress.org/trunk@35493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 22:00:26 +00:00
Scott Taylor 2487cfb005 Bump 4.4-beta3
Built from https://develop.svn.wordpress.org/trunk@35528


git-svn-id: http://core.svn.wordpress.org/trunk@35492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:56:25 +00:00
Sergey Biryukov a41e5d0270 Themes: Add a Favorites tab to the Add Themes screen.
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.
Built from https://develop.svn.wordpress.org/trunk@35527


git-svn-id: http://core.svn.wordpress.org/trunk@35491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:49:26 +00:00
Scott Taylor d8b65d5582 Bump 4.4-beta3
Built from https://develop.svn.wordpress.org/trunk@35526


git-svn-id: http://core.svn.wordpress.org/trunk@35490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:47:26 +00:00
Scott Taylor 149f39d203 4.4-beta3
Built from https://develop.svn.wordpress.org/trunk@35525


git-svn-id: http://core.svn.wordpress.org/trunk@35489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:46:28 +00:00
Andrew Ozz 09c16cb4ac Responsive images: do not generate `srcset` for GIFs that are inserted at full size. Prevents breaking animated GIFs.
Props joemcgill.
Fixes #34528.
Built from https://develop.svn.wordpress.org/trunk@35524


git-svn-id: http://core.svn.wordpress.org/trunk@35488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:44:25 +00:00
Andrea Fercia 3c0ed4295e List tables: Improve the displaying of pagination links on small screens.
Pagination links can break in two lines on small screens. Implements a partial fix, new ideas and better solutions should be explored though.

See #33962.
Built from https://develop.svn.wordpress.org/trunk@35523


git-svn-id: http://core.svn.wordpress.org/trunk@35487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:43:25 +00:00
Dominik Schilling 600b303668 Revert [35372] because of possible encoding issues, needs more investigation.
See #10373.
Built from https://develop.svn.wordpress.org/trunk@35522


git-svn-id: http://core.svn.wordpress.org/trunk@35486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:39:26 +00:00
Aaron Jorbin 37ad21d444 Bump grunt-contrib-compress
Upsteam changelog: change to verbose output dependency updates Archiver 0.16

See #34177


Built from https://develop.svn.wordpress.org/trunk@35521


git-svn-id: http://core.svn.wordpress.org/trunk@35485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:36:30 +00:00
Aaron Jorbin 57a4f0841e Bump grunt-postcss
See #34177

Built from https://develop.svn.wordpress.org/trunk@35520


git-svn-id: http://core.svn.wordpress.org/trunk@35484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:32:53 +00:00
Sergey Biryukov c6c366fec0 Adjust some of the strings added in [35508].
Fixes #34519.
Built from https://develop.svn.wordpress.org/trunk@35519


git-svn-id: http://core.svn.wordpress.org/trunk@35483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:32:26 +00:00
Dominik Schilling 122f38f748 List Tables: Define the global `$mode` variable for Quick Edit savings.
Also remove two unused global imports for `$mode`.

Fixes #34577.
Built from https://develop.svn.wordpress.org/trunk@35518


git-svn-id: http://core.svn.wordpress.org/trunk@35482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:29:25 +00:00
Sergey Biryukov 5d87e7d2b8 Introduce `wp_maybe_decline_date()` for languages where certain date formats need to be declined, and hook it to the `date_i18n` filter.
If the locale specifies that month names require a genitive case in certain formats like `'j F Y'` or `'j. F'`, the month name will be replaced with a correct form. 

Fixes #11226.
Built from https://develop.svn.wordpress.org/trunk@35517


git-svn-id: http://core.svn.wordpress.org/trunk@35481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:28:26 +00:00
Andrea Fercia c443d45708 Admin: Ensure notices with the `below-h2` class are not repositioned after [35238].
Keeps the `.below-h2` class for backwards compatibility with plugins that are (incorrectly) using it. Plugins should use `.inline` instead.

Props stephenharris.
Fixes #34570. See #34294.
Built from https://develop.svn.wordpress.org/trunk@35516


git-svn-id: http://core.svn.wordpress.org/trunk@35480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:27:26 +00:00
Boone Gorges 973223ad5f Don't allow term meta to be added to shared taxonomy terms.
`add_term_meta()` and `update_term_meta()` identify terms by `$term_id`. In
cases where a term is shared between taxonomies, `$term_id` is insufficient to
distinguish where the metadata belongs.

When attempting to add/update termmeta on a shared term, a `WP_Error` object
is returned. This gives developers enough information to decide whether they'd
like to force the term to be split and retry the save, or show an error in the
UI, or whatever.

Props boonebgorges, mboynes, DH-Shredder, jorbin, aaroncampbell.
Fixes #34544.
Built from https://develop.svn.wordpress.org/trunk@35515


git-svn-id: http://core.svn.wordpress.org/trunk@35479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:24:26 +00:00
Scott Taylor 16637eeee4 REST API: in `WP_REST_Server::dispatch()`, move `preg_match()` out of it's current loop, which doesn't affect the context passed to it.
Props TobiasBg.
Fixes #34488.

Built from https://develop.svn.wordpress.org/trunk@35514


git-svn-id: http://core.svn.wordpress.org/trunk@35478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:23:25 +00:00
Aaron Jorbin 9e5726c233 Bump matchdep from 0.3.0 to 1.0.0
This drops support for node 0.8.0 so if you still using that, it's time to upgrade your node.

See #34177


Built from https://develop.svn.wordpress.org/trunk@35513


git-svn-id: http://core.svn.wordpress.org/trunk@35477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:21:36 +00:00
Boone Gorges 5c1ca9d943 `WP_Comment_Query`: Fill comment objects from database when cache is unavailable.
This fixes a bug where widgets loaded in a preview or the Customizer are
rendered inside of a `wp_suspend_cache_addition()` block and thus could not
find comment objects in the cache.

Props rommelxcastro, stevehenty.
Fixes #34138.
Built from https://develop.svn.wordpress.org/trunk@35512


git-svn-id: http://core.svn.wordpress.org/trunk@35476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:09:27 +00:00
Drew Jaynes 1ddb8b94af Customizer: Adjust styles on panel titles to prevent descenders – such as with the letters g, j, p, q, or y – from getting cut off in some browsers.
Props umeshnevase.
Fixes #33575.

Built from https://develop.svn.wordpress.org/trunk@35511


git-svn-id: http://core.svn.wordpress.org/trunk@35475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:53:26 +00:00
Drew Jaynes 3575214485 Pages: Introduce the `get_page_uri` filter, which makes it possible to manipulate a given page's URI before it's returned from the like-named `get_page_uri()`.
Props tanner-m for the initial patch.
Fixes #15963.

Built from https://develop.svn.wordpress.org/trunk@35510


git-svn-id: http://core.svn.wordpress.org/trunk@35474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:29:25 +00:00
Scott Taylor d763eb80b7 XMLRPC: ensure that empty strings are not passed as `null`, which will then fail `isset()`
Props solarissmoke.
Fixes #16980.

Built from https://develop.svn.wordpress.org/trunk@35509


git-svn-id: http://core.svn.wordpress.org/trunk@35473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:08:25 +00:00
Aaron Jorbin b026ad4b75 Adjust heading structure for pages using wp-admin/css/install.css
The readme, installation, upgrade, and repair pages use a common css file. The heading structure for these pages was inconstant with h2s where there should be h1s, h1s where there is no relevant info and sometimes, no h1s at all.

Fixes #34519
Props rianrietveld


Built from https://develop.svn.wordpress.org/trunk@35508


git-svn-id: http://core.svn.wordpress.org/trunk@35472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:00:24 +00:00
Scott Taylor 9135920061 Roles: map `add_users` cap to `promote_users` and remove it.
"Never used, will be removed." - The Ghost of 3.5 Nacin

Props Craig Ralston, renoirb.
Fixes #16719.

Built from https://develop.svn.wordpress.org/trunk@35507


git-svn-id: http://core.svn.wordpress.org/trunk@35471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 17:54:25 +00:00
Scott Taylor 5e9ed67b82 Feeds: `<comments>` is optional in RSS2, so don't include it when comments aren't present or open. Same for `<wfw:commentRss>` and `<slash:comments>`
Adds unit test.

Props swissspidy, realloc, hakre, sivel.
Fixes #9134.

Built from https://develop.svn.wordpress.org/trunk@35506


git-svn-id: http://core.svn.wordpress.org/trunk@35470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 17:47:25 +00:00
Sergey Biryukov 7d09847957 Add missing `@group` to `Tests_Rel_No_Follow`.
See #9959.
Built from https://develop.svn.wordpress.org/trunk@35505


git-svn-id: http://core.svn.wordpress.org/trunk@35469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 16:36:24 +00:00
Drew Jaynes 96616877ac Taxonomy: Introduce the dynamic `taxonomy_labels_{$taxonomy}` filter, which can be used to manipulate the labels for a given taxonomy.
The addition of this hook brings parity with the earlier-introduced `post_type_labels_{$post_type}` filter, which allows for similarly manipulating labels for a given post type.

Note: It isn't possible to unset or remove default labels via either of these hooks, only to overwrite. This is because WordPress relies on defaults being set for use in various UIs and admin experiences.

Props flixos90.
Fixes #34554.

Built from https://develop.svn.wordpress.org/trunk@35504


git-svn-id: http://core.svn.wordpress.org/trunk@35468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 16:03:25 +00:00
Drew Jaynes fd10901db5 Docs: Add a missing return description for `_get_custom_object_labels()`, a private core helper function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35503


git-svn-id: http://core.svn.wordpress.org/trunk@35467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 15:47:27 +00:00
Sergey Biryukov 18852f07f2 Menus: After [35450], use correct IDs in `$initial_meta_boxes`.
Props swissspidy.
Fixes #33925.
Built from https://develop.svn.wordpress.org/trunk@35502


git-svn-id: http://core.svn.wordpress.org/trunk@35466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 10:56:26 +00:00
Weston Ruter 154e3d4593 Customize: Simplify condition for returning `nav_menus_invalid_post_type` error.
Props swissspidy.
See #16075.

Built from https://develop.svn.wordpress.org/trunk@35501


git-svn-id: http://core.svn.wordpress.org/trunk@35465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 07:29:25 +00:00
Weston Ruter 77e365efbf Customize: Add support for `post_type_archive` nav menu items.
Props celloexpressions, westonruter.
Fixes #16075.

Built from https://develop.svn.wordpress.org/trunk@35500


git-svn-id: http://core.svn.wordpress.org/trunk@35464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 04:30:26 +00:00
Gary Pendergast e0cab8383c Media Library: Allow longer labels in the filter dropdowns.
Props aaronrutley, AlbertoCT.

Fixes #32005.



Built from https://develop.svn.wordpress.org/trunk@35499


git-svn-id: http://core.svn.wordpress.org/trunk@35463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 00:41:24 +00:00
Andrew Ozz 9e436c7e0f Responsive images:
- Fix `_wp_upload_dir_baseurl()` to cache by blog_id.
- Replace `path_join()` with `trailingslashit()`, it's much faster.
- Rename $image_url to $image_src for consistency (used at about 50 other places).
- Couple of tests fixes.

See #34430.
Built from https://develop.svn.wordpress.org/trunk@35498


git-svn-id: http://core.svn.wordpress.org/trunk@35462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 00:22:26 +00:00
Sergey Biryukov a9d6fa9c7a Formatting: `wp_make_link_relative()` should return an empty string if no path is present in the link.
Props bcworkz, MikeHansenMe, chriscct7, SergeyBiryukov.
Fixes #26819.
Built from https://develop.svn.wordpress.org/trunk@35497


git-svn-id: http://core.svn.wordpress.org/trunk@35461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 21:36:25 +00:00
Sergey Biryukov 40a58409d8 Accessibility: After [35130], adjust the `h2.nav-tab-wrapper` selector to only override `.wrap > h2:first-child`.
This improves compatibility with plugins that use navigation tabs as a first H2 heading on their screens.

Props afercia.
Fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@35496


git-svn-id: http://core.svn.wordpress.org/trunk@35460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 20:49:27 +00:00
Drew Jaynes 6b14ca9407 Docs: Fix two notations for the `$_wp_real_parent_file` global, which is an array.
Props NExt-Season.
Fixes #34443.

Built from https://develop.svn.wordpress.org/trunk@35495


git-svn-id: http://core.svn.wordpress.org/trunk@35459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 20:13:26 +00:00
Andrea Fercia 04c2cd1913 Accessibility: Improve buttons focus and links style in the install screens.
Fixes #34530.
Built from https://develop.svn.wordpress.org/trunk@35494


git-svn-id: http://core.svn.wordpress.org/trunk@35458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 17:59:24 +00:00
Andrea Fercia 862cf19772 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.
Built from https://develop.svn.wordpress.org/trunk@35493


git-svn-id: http://core.svn.wordpress.org/trunk@35457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 16:02:25 +00:00
Andrea Fercia d7485cf10b WP oEmbed: Improve the Sharing dialog accessibility.
Improves ARIA attributes, focus handling, and constrains tabbing within the modal dialog.

Fixes #34484.
Built from https://develop.svn.wordpress.org/trunk@35492


git-svn-id: http://core.svn.wordpress.org/trunk@35456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 15:49:27 +00:00
Andrew Ozz ea3d7c7962 Responsive images:
- More fixes to inline docs.
- Replace the last `wp_get_attachment_metadata()` with `get_post_meta()`.
- For consistency only accept array or named size in `wp_get_attachment_image_sizes()`.

Props jaspermdegroot.
See #34430.
Built from https://develop.svn.wordpress.org/trunk@35491


git-svn-id: http://core.svn.wordpress.org/trunk@35455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 00:19:28 +00:00
Drew Jaynes 64f5e0683a Docs: Document use of the `$comment_status` global in the DocBlock for `WP_Comments_List_Table::handle_row_actions()`.
Props shimakyohsuke.
Fixes #34425.

Built from https://develop.svn.wordpress.org/trunk@35490


git-svn-id: http://core.svn.wordpress.org/trunk@35454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 21:33:27 +00:00
Sergey Biryukov f43a25bbe1 Docs: After [32654], remove duplicate `@param` tag in `WP_List_Table::set_pagination_args()` DocBlock.
Add `@since` tag.

Props bobbingwide.
See #32444.
Built from https://develop.svn.wordpress.org/trunk@35489


git-svn-id: http://core.svn.wordpress.org/trunk@35453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 21:03:24 +00:00
Sergey Biryukov a44ee99ca5 Build Tools: Add Microsoft Edge to Autoprefixer options.
Props christophherr.
Fixes #34550.
Built from https://develop.svn.wordpress.org/trunk@35488


git-svn-id: http://core.svn.wordpress.org/trunk@35452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 20:44:27 +00:00
Gary Pendergast c39ae3e5e2 Upgrades: Add support for `FULLTEXT` indexes to `dbDelta()`.
Props edirect24, mdawaffe, pento.

Fixes #14445.


Built from https://develop.svn.wordpress.org/trunk@35487


git-svn-id: http://core.svn.wordpress.org/trunk@35451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 23:10:25 +00:00
Weston Ruter 2e98e461a2 Customize: Fix auto-expand (and focus) on newly added widgets.
Add widget controls with an initially-true `active` state so that calling `expand()` will not be short-circuited. Previously the `active` state would be set once the preview refreshes, but this happens too late for the `addWidget` call. Fixes regression introduced in [35231].

Fixes #34514.

Built from https://develop.svn.wordpress.org/trunk@35486


git-svn-id: http://core.svn.wordpress.org/trunk@35450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 22:27:26 +00:00
Drew Jaynes 6924523366 Docs: Correctly notate that the default `$width` and `$height` embed dimensions are passed to the `embed_defaults` filter as a compacted array, and not two distinct parameters.
Props swissspidy.
Fixes #34522.

Built from https://develop.svn.wordpress.org/trunk@35485


git-svn-id: http://core.svn.wordpress.org/trunk@35449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 15:42:25 +00:00
Sergey Biryukov d49160ba5b Docs: Correct `$post` parameter description for `display_post_states` filter.
Props grapplerulrich.
Fixes #34541.
Built from https://develop.svn.wordpress.org/trunk@35484


git-svn-id: http://core.svn.wordpress.org/trunk@35448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 14:06:26 +00:00
Weston Ruter 8fed77574c Customize: Return user to referring URL when leaving Customizer in absence of `return` query param.
When referring URL is not available, default returning user to frontend URL instead of admin URL. Themes page is updated to include the `return` path in Customizer links.

Props McGuive7, westonruter.
Fixes #32637.

Built from https://develop.svn.wordpress.org/trunk@35483


git-svn-id: http://core.svn.wordpress.org/trunk@35447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 06:40:28 +00:00
Sergey Biryukov 10f3ff1753 Post List Table: Hierarchical post types should not default to sorting by date.
Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.
Built from https://develop.svn.wordpress.org/trunk@35482


git-svn-id: http://core.svn.wordpress.org/trunk@35446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 00:49:24 +00:00
Andrew Ozz 26b6acd081 Responsive images: add `$image_url` parameter to `wp_get_attachment_image_sizes()` and use it in the filter. This allows themes and plugins to identify the image.
Props joemcgill.
Fixes #34477.
Built from https://develop.svn.wordpress.org/trunk@35481


git-svn-id: http://core.svn.wordpress.org/trunk@35445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 22:49:24 +00:00
Scott Taylor 60eaf79b67 Canonical: when `/%post_id%/` is the permalink structure, don't redirect IDs that match Auto Drafts.
Props SergeyBiryukov.
Fixes #29431.

Built from https://develop.svn.wordpress.org/trunk@35480


git-svn-id: http://core.svn.wordpress.org/trunk@35444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:54:25 +00:00
Scott Taylor d8eacd51d8 Media: add a new image size, `medium_large`. Bumps db version to add new options.
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.

Built from https://develop.svn.wordpress.org/trunk@35479


git-svn-id: http://core.svn.wordpress.org/trunk@35443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:50:25 +00:00
Scott Taylor 382d455235 WP oEmbed: Improve height attribute sanitization
Props afercia, swissspidy.
Fixes #34527.

Built from https://develop.svn.wordpress.org/trunk@35478


git-svn-id: http://core.svn.wordpress.org/trunk@35442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:39:25 +00:00
Scott Taylor 35dd8003b0 Admin Menu: allow more than one menu item to be added at the same priority/position.
Props chriscct7.
Fixes #23316.

Built from https://develop.svn.wordpress.org/trunk@35477


git-svn-id: http://core.svn.wordpress.org/trunk@35441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:31:24 +00:00
Scott Taylor e4a2e0c4a9 Filesystem: in `WP_Filesystem_FTPext::parselisting()`, check for the existence of `$b['islink']` before using it.
Props jesin.
Fixes #27975.

Built from https://develop.svn.wordpress.org/trunk@35476


git-svn-id: http://core.svn.wordpress.org/trunk@35440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:17:24 +00:00
Scott Taylor 244cb3e595 Comments: don't auto-close comments on draft posts.
Adds unit tests.

Props solarissmoke, MikeHansenMe, nacin, rachelbaker.
Fixes #20262.

Built from https://develop.svn.wordpress.org/trunk@35475


git-svn-id: http://core.svn.wordpress.org/trunk@35439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:13:24 +00:00
Scott Taylor a36900c076 REST API: remove the `@internal` annotation from `rest_api_default_filters()`.
Props swissspidy, rachelbaker.
Fixes #34219.

Built from https://develop.svn.wordpress.org/trunk@35474


git-svn-id: http://core.svn.wordpress.org/trunk@35438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:08:25 +00:00
Scott Taylor 5c57e68d48 Nav Menus: add responsive styles for viewport between 768 and 1000px.
Props datta.parad, chriscct7.
Fixes #28912.

Built from https://develop.svn.wordpress.org/trunk@35473


git-svn-id: http://core.svn.wordpress.org/trunk@35437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:05:26 +00:00
Sergey Biryukov 74969ca0d3 Embeds: In `get_post_embed_html()`, move the optional `$post` argument after the required `$width` and `$height`.
Props swissspidy.
Fixes #34523.
Built from https://develop.svn.wordpress.org/trunk@35472


git-svn-id: http://core.svn.wordpress.org/trunk@35436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 15:51:25 +00:00
Sergey Biryukov 0b845e0364 Embeds: In `get_oembed_response_data()`, make the `$post` argument required.
`get_oembed_response_data()` is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Props swissspidy.
See #34523.
Built from https://develop.svn.wordpress.org/trunk@35471


git-svn-id: http://core.svn.wordpress.org/trunk@35435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 15:42:25 +00:00
Sergey Biryukov 64fdde928a Embeds: Fix typo in `oembed_request_post_id` filter DocBlock.
Props swissspidy.
See #34523.
Built from https://develop.svn.wordpress.org/trunk@35470


git-svn-id: http://core.svn.wordpress.org/trunk@35434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 15:38:25 +00:00
Andrea Fercia d5937d6a2c Dashboard: Activity widget CSS cleanup after [35420].
Props tyxla.
Fixes #34524. See #33558.
Built from https://develop.svn.wordpress.org/trunk@35469


git-svn-id: http://core.svn.wordpress.org/trunk@35433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 13:49:25 +00:00