Dominik Schilling
41197a7c31
Customizer: Improve ability to filter active state for widget area Customizer sections.
...
* Mark panels, sections, controls as active if preview explicitly indicates.
* Introduce `WP_Customize_Sidebar_Section` PHP class, and `SidebarSection` JS class.
* Move logic for determining whether a sidebar section is active from the `SidebarControl` to `SidebarSection`.
props westonruter.
fixes #30235 .
Built from https://develop.svn.wordpress.org/trunk@30329
git-svn-id: http://core.svn.wordpress.org/trunk@30328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:19:23 +00:00
Boone Gorges
92e3890daa
Correct `@since` tag in `count_user_posts()` docs.
...
Props pavelevap, DrewAPicture.
See #21364 .
Built from https://develop.svn.wordpress.org/trunk@30328
git-svn-id: http://core.svn.wordpress.org/trunk@30327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:15:23 +00:00
Dominik Schilling
120cb5e6ef
Improve keyboard accessibility on Custom Header and Custom Background screen.
...
props florianziegler.
fixes #29289 .
Built from https://develop.svn.wordpress.org/trunk@30327
git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:00:57 +00:00
Dominik Schilling
e0c9ba2d63
Customizer: Prevent double-encoding in `WP_Customize_Control`.
...
Control's label and description may include HTML.
fixes #29572 .
Built from https://develop.svn.wordpress.org/trunk@30326
git-svn-id: http://core.svn.wordpress.org/trunk@30325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 11:44:23 +00:00
Ian Stewart
3acf55cf96
Twenty Fifteen: cleaning up JS introduced in r30305 that doesn't pass jshint.
...
Props boonebgorges, fixes #29988 .
Built from https://develop.svn.wordpress.org/trunk@30325
git-svn-id: http://core.svn.wordpress.org/trunk@30324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 03:18:23 +00:00
Ian Stewart
3f967c8f1a
Twenty Fifteen: unfix the sidebar if we have a menu with submenus as there is a chance visitors might not be able to scroll down to see submenus in some situations.
...
Props mattwiebe, fixes #30208 .
Built from https://develop.svn.wordpress.org/trunk@30324
git-svn-id: http://core.svn.wordpress.org/trunk@30323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 03:09:22 +00:00
Boone Gorges
912cdc5978
Pass query object to 'the_post' filter.
...
Props tlovett1.
Fixes #30327 .
Built from https://develop.svn.wordpress.org/trunk@30323
git-svn-id: http://core.svn.wordpress.org/trunk@30322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:25:22 +00:00
Boone Gorges
a0b8caa29b
Introduce `$post_type` param for `count_user_posts()`.
...
Props Caspie, engelen, DrewAPicture.
Fixes #21364 .
Built from https://develop.svn.wordpress.org/trunk@30322
git-svn-id: http://core.svn.wordpress.org/trunk@30321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:19:22 +00:00
Andrew Ozz
6b9b865b33
Twenty Fifteen: reduce the margins on the editor body in esitor-style.css. Fixes #30331 .
...
Built from https://develop.svn.wordpress.org/trunk@30321
git-svn-id: http://core.svn.wordpress.org/trunk@30320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:02:24 +00:00
Boone Gorges
d7df822944
Manually delete fixture in `test_mysqli_flush_sync()`.
...
This test creates a dummy post and subsequently runs a query containing
`DROP PROCEDURE`. This latter query implies a `COMMIT`, which means that the
post is not cleaned up for later tests. Manually deleting the post with
`wp_delete_post()` solves this problem.
Fixes #28155 .
Built from https://develop.svn.wordpress.org/trunk@30320
git-svn-id: http://core.svn.wordpress.org/trunk@30319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:00:21 +00:00
Andrew Ozz
14ae707fd6
Fix typo in translatable string, see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30319
git-svn-id: http://core.svn.wordpress.org/trunk@30318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 01:00:23 +00:00
Andrew Ozz
69105d29e8
TinyMCE: enhance the inline toolbar for images:
...
- Add alignment (left, center, right, none) buttons.
- Position the menu above the image when possible, except on iOS.
- Fix selecting images on iOS.
First run, part props avryl. See #30147 .
Built from https://develop.svn.wordpress.org/trunk@30318
git-svn-id: http://core.svn.wordpress.org/trunk@30317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 00:56:22 +00:00
Ian Stewart
07eba31e0b
Twenty Fifteen: improve appearance of page links when there are tons of pages to link to
...
Props iamtakashi, fixes #30301
Built from https://develop.svn.wordpress.org/trunk@30317
git-svn-id: http://core.svn.wordpress.org/trunk@30316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:39:23 +00:00
Ian Stewart
40c73b7d0d
Twenty Fifteen: adding context to pagination links for screenreaders.
...
Props afercia, iamtakashi, fixes #30152
Built from https://develop.svn.wordpress.org/trunk@30316
git-svn-id: http://core.svn.wordpress.org/trunk@30315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:26:25 +00:00
Ian Stewart
99a35f20e6
Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes.
...
Props celloexpressions, iandstewart, fixes #30316
Built from https://develop.svn.wordpress.org/trunk@30315
git-svn-id: http://core.svn.wordpress.org/trunk@30314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:01:21 +00:00
Ian Stewart
7f970d53b1
Twenty Fifteen: adding context to page links for screenreaders.
...
Props afercia, fixes #30174 .
Built from https://develop.svn.wordpress.org/trunk@30314
git-svn-id: http://core.svn.wordpress.org/trunk@30313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 22:55:22 +00:00
Helen Hou-Sandí
06201646c3
Use a brighter blue against dark backgrounds in the admin menu and toolbar.
...
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.
props melchoyce. fixes #30323 .
Built from https://develop.svn.wordpress.org/trunk@30313
git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 20:28:22 +00:00
Ian Stewart
50271a97d5
Twenty Fifteen: clean up sprintf from template tags and use the correct escaping for twentyfifteen template tags.
...
Props aprea, obenland, fixes #30319
Built from https://develop.svn.wordpress.org/trunk@30312
git-svn-id: http://core.svn.wordpress.org/trunk@30311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 17:21:21 +00:00
Dion Hulse
e17d09f233
PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628
...
Built from https://develop.svn.wordpress.org/trunk@30311
git-svn-id: http://core.svn.wordpress.org/trunk@30310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 10:44:23 +00:00
Dion Hulse
3e702d8b52
Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
...
See #29628
Built from https://develop.svn.wordpress.org/trunk@30310
git-svn-id: http://core.svn.wordpress.org/trunk@30309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 03:06:23 +00:00
Dominik Schilling
6d83c8c29e
Customizer: Add support for the media library in Background Image controls.
...
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.
props celloexpressions, and ericlewis for docs.
see #21483 .
Built from https://develop.svn.wordpress.org/trunk@30309
git-svn-id: http://core.svn.wordpress.org/trunk@30308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 23:52:22 +00:00
Dominik Schilling
8b32164b67
Customizer: Trigger `widget-added` event when initializing.
...
Widget controls are now added to the pane dynamically via JavaScript, see #28709 .
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.
props westonruter.
fixes #30236 .
Built from https://develop.svn.wordpress.org/trunk@30308
git-svn-id: http://core.svn.wordpress.org/trunk@30307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:46:23 +00:00
Dominik Schilling
d21799ee1f
Customizer: Use `jQuery.fn.toggle()` instead of `slideUp`/`slideDown` if panel/section/control is not inserted into DOM yet.
...
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709 .
props westonruter.
fixes #30251 .
Built from https://develop.svn.wordpress.org/trunk@30307
git-svn-id: http://core.svn.wordpress.org/trunk@30306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:37:22 +00:00
Dominik Schilling
b250062311
Customizer: When navigating around the site within the Customizer preview, update the document title.
...
props westonruter.
fixes #28542 .
Built from https://develop.svn.wordpress.org/trunk@30306
git-svn-id: http://core.svn.wordpress.org/trunk@30305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:29:23 +00:00
Ian Stewart
1317409eda
Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.
...
Props celloexpressions, see #29988
Built from https://develop.svn.wordpress.org/trunk@30305
git-svn-id: http://core.svn.wordpress.org/trunk@30304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:36:23 +00:00
Ian Stewart
87bd82a0ab
Twenty Fifteen: simplify the code used to generate screen reader text for the is_home title.
...
Props davidakennedy, fixes #30305
Built from https://develop.svn.wordpress.org/trunk@30304
git-svn-id: http://core.svn.wordpress.org/trunk@30303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:24:22 +00:00
Ian Stewart
47ec29c1ba
Twenty Fifteen: create consistent spacing with embeds and images.
...
Props afercia, fixes #30286
Built from https://develop.svn.wordpress.org/trunk@30303
git-svn-id: http://core.svn.wordpress.org/trunk@30302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:04:21 +00:00
Ian Stewart
1f2397af34
Twenty Fifteen: simpler CSS by using divs instead of spans for menu descriptions.
...
Props philiparthurmoore, fixes #30296
Built from https://develop.svn.wordpress.org/trunk@30302
git-svn-id: http://core.svn.wordpress.org/trunk@30301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:02:22 +00:00
Boone Gorges
5fe8fa2b40
Correct grammar error in `WP_Date_Query` error message.
...
Props Offereins.
See #25834 .
Built from https://develop.svn.wordpress.org/trunk@30301
git-svn-id: http://core.svn.wordpress.org/trunk@30300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 14:56:24 +00:00
Boone Gorges
4cf91d7c1d
Improve localization for `WP_Date_Query` error strings.
...
* Don't create an extra variable for the string when it's only used once.
* Avoid using `<code>` HTML tags inside of translatable string.
* Improve data types and escaping on sprintfed values.
Props dd32.
Fixes #25834 .
Built from https://develop.svn.wordpress.org/trunk@30300
git-svn-id: http://core.svn.wordpress.org/trunk@30299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 13:24:24 +00:00
Gary Pendergast
21467af4db
wpdb: When flushing results on a mysqli connection, make sure that `wpdb::$dbh` is a valid mysqli connection handle.
...
Fixes a unit test failure introduced in [30297].
Fixes #28155 .
Props soulseekah.
Built from https://develop.svn.wordpress.org/trunk@30299
git-svn-id: http://core.svn.wordpress.org/trunk@30298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 02:17:28 +00:00
Boone Gorges
dd61164577
Exclude external-http tests when running `phpunit`.
...
The external-http tests are very slow, and `Wp_Http` functionality is fairly
isolated, so the benefits of skipping these tests by default outweigh the
risks.
A `grunt phpunit:external-http` subtask has been added, to ensure that the
tests are executed during exhaustive runs of the test suite, such as in
continuous integration.
Fixes #30304 .
Built from https://develop.svn.wordpress.org/trunk@30298
git-svn-id: http://core.svn.wordpress.org/trunk@30297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 14:49:24 +00:00
Gary Pendergast
0013150649
`wpdb::flush()` was not flushing results correctly when using mysqli.
...
This change also allows stored procedures or queries made with `mysqli_multi_query()` to be flushed.
Includes unit tests.
Fixes #28155 .
Props soulseekah.
Built from https://develop.svn.wordpress.org/trunk@30297
git-svn-id: http://core.svn.wordpress.org/trunk@30296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 05:40:23 +00:00
Andrew Ozz
5f27bdc78d
TinyMCE: enable direct calls to `_WP_Editors::wp_mce_translation()`. When using TinyMCE directly, this makes it easier to load the translation of the default strings. Fixes #30293 .
...
Built from https://develop.svn.wordpress.org/trunk@30296
git-svn-id: http://core.svn.wordpress.org/trunk@30295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:07:22 +00:00
Boone Gorges
383c75db29
Fix PHP notice in `Tests_Feed_RSS2::test_items()`.
...
A notice was being thrown when `get_the_tags()` returned false, and `foreach()`
was run over that return value.
See [30283].
Built from https://develop.svn.wordpress.org/trunk@30295
git-svn-id: http://core.svn.wordpress.org/trunk@30294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:05:22 +00:00
Andrew Ozz
b3da068590
TinyMCE: remove strings that are not translated before outputting the translations. Fixes #27797 .
...
Built from https://develop.svn.wordpress.org/trunk@30294
git-svn-id: http://core.svn.wordpress.org/trunk@30293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:00:22 +00:00
Andrew Ozz
ba10ab197b
Heartbeat:
...
- Use the page visibility API (when available) and document.hasFocus() instead of window.onfocus/onblur. Improves speeding up/slowing down the interval and works for iframes by default.
- Add a setting for minimal interval. Maximum value is 10 min. This overrides all other intervals and cannot be changed after setting it at initialization. Can be used to reduce the frequency of requests on hosts that have low limits for used CPU time, etc.
- Extend the setting of interval to support 120 sec. (60 sec, is still the default).
- Always suspend after one hour of keyboard/mouse/touch inactivity.
Fixes #29779 .
Built from https://develop.svn.wordpress.org/trunk@30293
git-svn-id: http://core.svn.wordpress.org/trunk@30292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 01:47:24 +00:00
Gary Pendergast
f572927353
WPDB's `__get()` function should perform strict comparisons against member names
...
Built from https://develop.svn.wordpress.org/trunk@30292
git-svn-id: http://core.svn.wordpress.org/trunk@30291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-09 12:04:23 +00:00
Aaron Jorbin
2508d31b81
Remove failing Unbalanced tags tests
...
Patch with tests added to #6297 for use in the future
Props MikeHansenMe for creating patch of current unit test
see #30284
Built from https://develop.svn.wordpress.org/trunk@30291
git-svn-id: http://core.svn.wordpress.org/trunk@30290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 23:15:23 +00:00
Aaron Jorbin
70416f2225
Remove failing shortcode unit tests
...
Test added to #14050 in case we want to include it in a future fix.
see #30284
Built from https://develop.svn.wordpress.org/trunk@30290
git-svn-id: http://core.svn.wordpress.org/trunk@30289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 22:51:22 +00:00
Aaron Jorbin
2ed6de333b
Remove failing uploadfile test in trunk
...
The test has been added to #11946 and can be readded when that ticket is fixed.
Props MikeHansenMe for creating patch of current unit test
See #30284
Built from https://develop.svn.wordpress.org/trunk@30289
git-svn-id: http://core.svn.wordpress.org/trunk@30288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:56:22 +00:00
Drew Jaynes
3e94d3a931
Fix incorrect documentation in the DocBlocks for `get_lastpostmodified()` and `_get_last_post_time()`.
...
Props ericlewis for the initial patch.
Fixes #30249 .
Built from https://develop.svn.wordpress.org/trunk@30287
git-svn-id: http://core.svn.wordpress.org/trunk@30287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:08:45 +00:00
Jeremy Felt
112f854021
Move tests for ms_files_rewriting to separate group, ms-files
...
When the `ms_files_rewriting` flag is enabled, `ms_upload_constants()` is required to properly set upload directory constants. Once this fires, it is impossible to clean up for a non `ms_files_rewriting` test by turning the option back off.
Excluding these tests by default offer a more consistent environment overall. Any tests written for uploaded files in multisite should ideally have a correspondign test in this area.
This commit also moves existing `ms_files_rewriting` tests for `test_switch_upload_dir()`.
Fixes #30256
Built from https://develop.svn.wordpress.org/trunk@30286
git-svn-id: http://core.svn.wordpress.org/trunk@30286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:08:24 +00:00
Boone Gorges
ef442d8224
Remove failing test related to post galleries.
...
It relied on the old _WPDataset technique, which is no longer used.
The test has been added to #UT30 as a patch, in case anyone wants to make
future use of it.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30285
git-svn-id: http://core.svn.wordpress.org/trunk@30285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:02:22 +00:00
Drew Jaynes
92c153aa8c
Fix the syntax for some status-related documentation introduced in [30155].
...
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30284
git-svn-id: http://core.svn.wordpress.org/trunk@30284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:56:22 +00:00
Boone Gorges
77e2821d54
Improve `Tests_Feed_RSS2::test_items()`.
...
* Better reference to post author, to avoid PHP notices.
* Code styling.
* More reliable checking of tags and categories.
Props kurtpayne.
Fixes #UT32. See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30283
git-svn-id: http://core.svn.wordpress.org/trunk@30283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:55:22 +00:00
Boone Gorges
9e5cb0301c
Remove failing unit tests from 'canonical' group.
...
Each removed test has been turned into a patch and posted to the open ticket
that it belongs to.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30282
git-svn-id: http://core.svn.wordpress.org/trunk@30282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:37:22 +00:00
Drew Jaynes
e7b465046a
Cross-reference `WP_Comment_Query::query()` as the location for finding information on default arguments for `WP_Comment_Query`.
...
Also updates the return types on `get_comments()` and `get_approved_comments()`, as an integer can also be returned if the `$count` argument is true.
Fixes #30111 .
Built from https://develop.svn.wordpress.org/trunk@30281
git-svn-id: http://core.svn.wordpress.org/trunk@30281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:35:22 +00:00
Drew Jaynes
35e509b0c8
Document default arguments for `WP_Comment_Query` class as a hash notation.
...
Props boonebgorges, DrewAPicture.
See #30111 .
Built from https://develop.svn.wordpress.org/trunk@30280
git-svn-id: http://core.svn.wordpress.org/trunk@30280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:19:23 +00:00
Jeremy Felt
bd3a0b33b1
Use `remove_added_uploads()` in `tearDown()` for XMLRPC tests
...
This cleanup avoids false test failures due to incrementing filenames in the uploads directory.
Fixes #30290
Built from https://develop.svn.wordpress.org/trunk@30279
git-svn-id: http://core.svn.wordpress.org/trunk@30279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:18:22 +00:00