Sergey Biryukov
d5d0b367ab
Improve documentation for media_handle_upload().
...
props ericlewis.
fixes #30962 .
Built from https://develop.svn.wordpress.org/trunk@31109
git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 05:05:23 +00:00
Scott Taylor
60b0cd7943
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Scott Taylor
af0e5cc851
Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments.
...
Props tw2113 for the initial patch.
See #18788 .
Built from https://develop.svn.wordpress.org/trunk@31034
git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
Scott Taylor
2dbd0d0a8f
In `image_size_input_fields()`:
...
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30981
git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:19:24 +00:00
Scott Taylor
2c32752abd
Improve various `@param` docs for `src/wp-admin/*`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30680
git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:00:22 +00:00
Drew Jaynes
78bb3e5ff5
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
...
Also adds a few inline `@see` cross-references as they apply.
Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30648
git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
Drew Jaynes
5212725fbe
4.1 Docs Audit: Convert a hook reference to an inline `@see` tag in the hook docs for the `image_add_caption_text` filter.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30600
git-svn-id: http://core.svn.wordpress.org/trunk@30590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:56:24 +00:00
Drew Jaynes
9955384dbe
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30543
git-svn-id: http://core.svn.wordpress.org/trunk@30532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:53:22 +00:00
Scott Taylor
5e3a64e83d
Correct some types in `wp-admin/*`-location files' doc blocks.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30203
git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Scott Taylor
7d7a8aa0eb
Correct all `@return unknown` instances.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30202
git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor
bd2521d5ee
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30201
git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Gary Pendergast
007ec52958
Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8.
...
Change all core calls from `json_encode()` to `wp_json_encode()`.
Fixes #28786 .
Built from https://develop.svn.wordpress.org/trunk@30055
git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:35:19 +00:00
Andrew Ozz
7a55ab9164
Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29776
git-svn-id: http://core.svn.wordpress.org/trunk@29548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 00:14:18 +00:00
Sergey Biryukov
26124b9aad
Pass the attachment ID to the 'image_add_caption_text' filter.
...
fixes #29607 .
Built from https://develop.svn.wordpress.org/trunk@29754
git-svn-id: http://core.svn.wordpress.org/trunk@29526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 10:11:16 +00:00
Sergey Biryukov
79d017a024
Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor.
...
props collinsinternet, DrewAPicture.
fixes #29607 .
Built from https://develop.svn.wordpress.org/trunk@29753
git-svn-id: http://core.svn.wordpress.org/trunk@29525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 09:56:17 +00:00
Scott Taylor
69998d452b
In `media_handle_upload()`, don't call `wp_read_image_metadata()` on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling `@wp_read_image_metadata()`.
...
Props jrf for the initial patch.
Fixes #28907 .
Built from https://develop.svn.wordpress.org/trunk@29737
git-svn-id: http://core.svn.wordpress.org/trunk@29511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 20:15:17 +00:00
Andrew Ozz
69e7171f41
Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602
...
Built from https://develop.svn.wordpress.org/trunk@29729
git-svn-id: http://core.svn.wordpress.org/trunk@29503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 22:40:16 +00:00
Scott Taylor
fa0acbe3bb
Don't overwrite the `length` property unnecessarily when generating metadata for audio and video files.
...
Props jrf, wonderboymusic.
Fixes #29176 .
Built from https://develop.svn.wordpress.org/trunk@29728
git-svn-id: http://core.svn.wordpress.org/trunk@29502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 21:57:15 +00:00
Sergey Biryukov
1eb26d3ff3
Use https for apps.wordpress.org links.
...
props pento.
fixes #29595 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29721
git-svn-id: http://core.svn.wordpress.org/trunk@29495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 06:29:15 +00:00
Andrew Nacin
00fac0639d
Link to apps.wordpress.org instead of wordpress.org/mobile.
...
props pento.
fixes #29496 .
Built from https://develop.svn.wordpress.org/trunk@29703
git-svn-id: http://core.svn.wordpress.org/trunk@29477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-04 14:22:15 +00:00
Sergey Biryukov
5faf09a261
Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances.
...
props nacin.
fixes #28090 .
Built from https://develop.svn.wordpress.org/trunk@29671
git-svn-id: http://core.svn.wordpress.org/trunk@29445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 09:08:16 +00:00
Dominik Schilling
8ea68677f3
Media Upload: Improve styling of error messages.
...
props afercia, michalzuber.
fixes #29047 .
Built from https://develop.svn.wordpress.org/trunk@29355
git-svn-id: http://core.svn.wordpress.org/trunk@29131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 14:14:19 +00:00
Sergey Biryukov
be718ee860
Declare the variable before using it.
...
props danielbachhuber.
fixes #28932 .
Built from https://develop.svn.wordpress.org/trunk@29215
git-svn-id: http://core.svn.wordpress.org/trunk@28999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 22:01:14 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Scott Taylor
57dbc55e6e
When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well.
...
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.
Fixes #27891 .
Built from https://develop.svn.wordpress.org/trunk@29029
git-svn-id: http://core.svn.wordpress.org/trunk@28817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 17:48:17 +00:00
Scott Taylor
650261b549
In deprecated media iframe code, `attachment_fields_to_save` filter should not be called twice after initial image upload in post.
...
Props SergeyBiryukov.
Fixes #20720 .
Built from https://develop.svn.wordpress.org/trunk@28871
git-svn-id: http://core.svn.wordpress.org/trunk@28671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-27 21:32:16 +00:00
Andrew Ozz
b9fd9db83b
Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640 .
...
Built from https://develop.svn.wordpress.org/trunk@28847
git-svn-id: http://core.svn.wordpress.org/trunk@28651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 04:15:15 +00:00
Scott Taylor
41ab39f42c
In `media_buttons()`, add a static var `$instance` to increment the `id` attribute of `insert-media-button-%d` on each call.
...
Props ericlewis.
Fixes #28090 .
Built from https://develop.svn.wordpress.org/trunk@28837
git-svn-id: http://core.svn.wordpress.org/trunk@28641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 01:05:14 +00:00
Drew Jaynes
1868c1fc4b
Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php.
...
Also add `@param` and `@return` descriptions.
See #28408 .
Built from https://develop.svn.wordpress.org/trunk@28632
git-svn-id: http://core.svn.wordpress.org/trunk@28451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 17:38:14 +00:00
Scott Taylor
8b7b72d75e
In `media_sideload_image()`, check the returned value of `download_url()` earlier to avoid attempting to `unlink()` an instance of `WP_Error`.
...
Props georgestephanis.
Fixes #28204 .
Built from https://develop.svn.wordpress.org/trunk@28567
git-svn-id: http://core.svn.wordpress.org/trunk@28392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 21:33:14 +00:00
Scott Taylor
130771a383
`hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28497
git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Scott Taylor
54321f4c6e
Eliminate use of `extract()` in `get_media_item()`.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28407
git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
Scott Taylor
2bea9fcc0b
In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags.
...
Fixes #25637 .
Built from https://develop.svn.wordpress.org/trunk@28368
git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:12:15 +00:00
Scott Taylor
1daa7d6723
Leverage `size_format()` when displaying `max_upload_size`:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
Built from https://develop.svn.wordpress.org/trunk@28343
git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
Scott Taylor
71ac0f21c2
In `get_media_item()`, `$tags` and `$_tags` are set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28297
git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:41:17 +00:00
Scott Taylor
dd73ad4299
In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28271
git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:45:16 +00:00
Andrew Ozz
c9f5ed0801
Plupload: restore the settings in media_upload_form(), see #27763
...
Built from https://develop.svn.wordpress.org/trunk@28110
git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:41:15 +00:00
Drew Jaynes
4af2840a47
Clarify PHPDoc return description for `media_handle_upload()`.
...
Props jdgrimes.
Fixes #27519 .
Built from https://develop.svn.wordpress.org/trunk@27880
git-svn-id: http://core.svn.wordpress.org/trunk@27711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 22:33:15 +00:00
Scott Taylor
01d2062af3
Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
...
Props nacin.
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27869
git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 05:16:16 +00:00
Andrew Nacin
c95f232727
Cleanups for audio/video metadata, see [27862].
...
see #27574 .
Built from https://develop.svn.wordpress.org/trunk@27864
git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 21:08:14 +00:00
Scott Taylor
d947a55495
Metadata for audio and video files:
...
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27862
git-svn-id: http://core.svn.wordpress.org/trunk@27693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 19:28:16 +00:00
Drew Jaynes
7dc9b02577
Correct misleading verbiage in 'print' hook docs.
...
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.
Props ericlewis for the initial patch.
Fixes #26924 .
Built from https://develop.svn.wordpress.org/trunk@27695
git-svn-id: http://core.svn.wordpress.org/trunk@27534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 08:05:15 +00:00
Andrew Nacin
9babc32900
Use correct variable. see [27373].
...
props TobiasBg.
fixes #14424 .
Built from https://develop.svn.wordpress.org/trunk@27675
git-svn-id: http://core.svn.wordpress.org/trunk@27518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:25:16 +00:00
Andrew Ozz
69b74a75cd
Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle.
...
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.
Built from https://develop.svn.wordpress.org/trunk@27662
git-svn-id: http://core.svn.wordpress.org/trunk@27505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-23 23:45:19 +00:00
Dominik Schilling
d1f3abe55c
Remove "Show" prefix from filter dropdowns, see #26743 .
...
Built from https://develop.svn.wordpress.org/trunk@27626
git-svn-id: http://core.svn.wordpress.org/trunk@27469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 22:13:14 +00:00
Andrew Nacin
fe260c6a15
Assign correct variable.
...
props nendeb55.
fixes #27351 . see #14424 , [27373].
Built from https://develop.svn.wordpress.org/trunk@27501
git-svn-id: http://core.svn.wordpress.org/trunk@27344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 13:24:14 +00:00
Andrew Nacin
449ffedfb9
maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata().
...
props kovshenin.
fixes #26825 .
Built from https://develop.svn.wordpress.org/trunk@27441
git-svn-id: http://core.svn.wordpress.org/trunk@27288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 19:34:14 +00:00
Mark Jaquith
fb56a9942b
Eliminate some of our last remaining `create_function()` instances
...
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore
props obenland, markjaquith, nacin. fixes #14424
Built from https://develop.svn.wordpress.org/trunk@27373
git-svn-id: http://core.svn.wordpress.org/trunk@27222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 16:21:16 +00:00
Andrew Nacin
0c16c0477b
Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
...
props Ipstenu, markjaquith.
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@27369
git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:34:27 +00:00
Scott Taylor
e92770ba93
* Videos should always render at the same aspect ratio.
...
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page
See #27243 .
Built from https://develop.svn.wordpress.org/trunk@27328
git-svn-id: http://core.svn.wordpress.org/trunk@27180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 21:28:14 +00:00
Andrew Ozz
d896fa2487
Upgrade Plupload to 2.1.1, props kovshenin, see #25663
...
Built from https://develop.svn.wordpress.org/trunk@27316
git-svn-id: http://core.svn.wordpress.org/trunk@27168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 20:01:16 +00:00
Scott Taylor
03dda3b273
Introduce `maybe_regenerate_attachment_metadata( $attachment )`. On the Edit Media screen, call it for Audio and Video files.
...
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.
This is the minimum viable product for #26825 , but leaving the ticket open unless this function needs to be called in other places.
See #26825 .
Built from https://develop.svn.wordpress.org/trunk@27127
git-svn-id: http://core.svn.wordpress.org/trunk@26994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 22:41:12 +00:00
Andrew Ozz
87589dd445
Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086 .
...
Built from https://develop.svn.wordpress.org/trunk@27036
git-svn-id: http://core.svn.wordpress.org/trunk@26912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:28:12 +00:00
Andrew Ozz
eb1d21d782
Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712 .
...
Built from https://develop.svn.wordpress.org/trunk@27029
git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 19:06:15 +00:00
Drew Jaynes
f51b1f8def
Inline documentation for hooks in wp-admin/includes/media.php.
...
Props kpdesign, DrewAPicture.
Fixes #25375 .
Built from https://develop.svn.wordpress.org/trunk@26908
git-svn-id: http://core.svn.wordpress.org/trunk@26791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-06 05:48:12 +00:00
Scott Taylor
7a7b9c89ec
Use parens to ensure that RegEx OR matches the front when determining that mime-type matches `audio|video` in `attachment_submitbox_metadata()`.
...
Props kovshenin.
See #23926 .
Built from https://develop.svn.wordpress.org/trunk@25727
git-svn-id: http://core.svn.wordpress.org/trunk@25640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 15:32:10 +00:00
Helen Hou-Sandí
9d5c2eb55f
Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170 .
...
Built from https://develop.svn.wordpress.org/trunk@25608
git-svn-id: http://core.svn.wordpress.org/trunk@25525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 20:23:10 +00:00
Helen Hou-Sandí
0758df9758
Add file size to attachment publish meta box. props desrosj. fixes #25170 .
...
Built from https://develop.svn.wordpress.org/trunk@25403
git-svn-id: http://core.svn.wordpress.org/trunk@25333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 15:10:09 +00:00
Helen Hou-Sandí
8798685de5
Alignment standards for [25296]. props DrewAPicture. see #25171 .
...
Built from https://develop.svn.wordpress.org/trunk@25300
git-svn-id: http://core.svn.wordpress.org/trunk@25263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 22:07:09 +00:00
Helen Hou-Sandí
304426cece
Add dynamic classes for attachment metadata submitbox sections. see #22333 , #25171 .
...
Built from https://develop.svn.wordpress.org/trunk@25297
git-svn-id: http://core.svn.wordpress.org/trunk@25260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:20:09 +00:00
Helen Hou-Sandí
89421ddeaa
Add `media_submitbox_misc_sections` and `audio_submitbox_misc_sections` filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171 .
...
Built from https://develop.svn.wordpress.org/trunk@25296
git-svn-id: http://core.svn.wordpress.org/trunk@25259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:19:10 +00:00
Sergey Biryukov
897ddbd76c
Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
...
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236 .
Built from https://develop.svn.wordpress.org/trunk@25277
git-svn-id: http://core.svn.wordpress.org/trunk@25242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 14:10:09 +00:00
Helen Hou-Sandí
eb44516e48
Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333 .
...
Built from https://develop.svn.wordpress.org/trunk@25083
git-svn-id: http://core.svn.wordpress.org/trunk@25068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 15:24:10 +00:00
Sergey Biryukov
aadd546d48
Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005 .
...
Built from https://develop.svn.wordpress.org/trunk@25028
git-svn-id: http://core.svn.wordpress.org/trunk@25015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 16:25:12 +00:00
Mark Jaquith
e553e85ebb
Remove `$pagenow` global from three functions that don’t use it.
...
Props jeremyfelt. Fixes #24920 .
git-svn-id: http://core.svn.wordpress.org/trunk@24974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-02 04:42:08 +00:00
Andrew Nacin
bc0a60920d
Remove curly quotes from auto content generation for audio tracks on upload. Texturize should be doing this on display.
...
props tollmanz.
fixes 24810.
git-svn-id: http://core.svn.wordpress.org/trunk@24788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-24 05:47:00 +00:00
Andrew Nacin
2c67dea9bc
Media: Add awareness to Attachment Display Settings that audio and video can be embedded.
...
Also:
* Add file length metadata to Attachment Details.
* Round the kb/s bitrate on post.php.
fixes #24449 .
git-svn-id: http://core.svn.wordpress.org/trunk@24777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 05:39:08 +00:00
Andrew Nacin
e46e52ec0f
ID3 1.9.7.
...
props wonderboymusic.
fixes #24737 .
git-svn-id: http://core.svn.wordpress.org/trunk@24696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-13 00:37:36 +00:00
Andrew Nacin
c2db94d10c
Use meta caps edit_post, read_post, and delete_post directly, rather than consulting the post type object. map_meta_cap() handles that for us. props markjaquith, kovshenin. fixes #23226 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 20:05:42 +00:00
Andrew Nacin
44abe2e502
Use wp_basename() in newer media code for filenames to avoid encoding issues on display. props SergeyBiryukov, fixes #23267 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 13:55:50 +00:00
Andrew Nacin
6500a24719
Call shortcode functions directly. props kovshenin, fixes #24505 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-03 20:19:00 +00:00
Andrew Nacin
3231e8cbd0
Pass $post to hooks in edit-form-advanced.php including edit_form_advanced and edit_form_after_*. fixes #24611 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-19 21:10:51 +00:00
Andrew Nacin
797ee34bc3
Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Sergey Biryukov
415a5c60da
* Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually.
...
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.
props solarissmoke, bpetty, SergeyBiryukov. fixes #11446 .
git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 00:22:02 +00:00
Andrew Nacin
b34ca3234e
Remove manual printing of userSettings as utils.js receives this as inline script data (since 3.5). see #24210 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 15:49:20 +00:00
Andrew Nacin
00b7fa589a
Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com.
...
props mboynes, jonbishop, SergeyBiryukov.
fixes #23322 .
git-svn-id: http://core.svn.wordpress.org/trunk@24052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:17:25 +00:00
Mark Jaquith
94c5f0aca1
Use ID3 data for audio and video
...
fixes #23926 . props wonderboymusic, SergeyBiryukov, johnbillion.
git-svn-id: http://core.svn.wordpress.org/trunk@23979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 22:27:24 +00:00
Sergey Biryukov
8d546ad739
Avoid an undefined index notice in wp_read_video_metadata(). props ocean90. fixes #23953 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 00:29:12 +00:00
Mark Jaquith
fec4b66f5b
Sanity checks on image metadata to avoid warnings, etc.
...
fixes #23733 . props wonderboymusic.
git-svn-id: http://core.svn.wordpress.org/trunk@23873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:51:35 +00:00
Mark Jaquith
ebdcf967a3
Show a playable audio/video preview on the Edit Attachment screen.
...
props wonderboymusic. fixes #23726
git-svn-id: http://core.svn.wordpress.org/trunk@23768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 05:17:25 +00:00
Mark Jaquith
12d3fc7999
Add functions for generating metadata for video and audio, using the
...
ID3 library. Also allows themes/plugins to add thumbnail support
to these media types. Think stuff like album art, movie covers, and
video freeze-frames.
props wonderboymusic. fixes #23673
git-svn-id: http://core.svn.wordpress.org/trunk@23766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 04:55:42 +00:00
Ryan Boren
469d1a3099
Escape form action urls with esc_url() rather than esc_attr().
...
Props SergeyBiryukov
fixes #23266
git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 14:01:25 +00:00
Helen Hou-Sandí
fffc2e1ab1
Prevent an unseemly gap on the edit screen when nothing else displays before normal meta boxes. Give better HTML and visual structure to items added via `edit_form_after_title` and `edit_form_after_editor`. Using a class of `.edit-form-section` will now get you a 20px bottom margin; perfect for your additions to the post edit screen. fixes #23240 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 23:22:17 +00:00
Andrew Nacin
7b47322e22
Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer().
...
Use wp_slash() instead of addslashes().
see #21767 .
git-svn-id: http://core.svn.wordpress.org/trunk@23578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:58:43 +00:00
Ryan Boren
5f809d1d22
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:00:25 +00:00
Ryan Boren
43a7e695e9
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Mark Jaquith
dab5a6ef7d
Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content.
...
props adamsilverstein. fixes #23195 and #22933
git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:30:09 +00:00
Andrew Nacin
5d980a8e8e
Whenever we have compat fields to render, send a dummy menu_order field (which was always sent in 3.4) to ensure an unchecked checkbox can still be processed by attachment_fields_to_save. fixes #22868 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-05 03:50:28 +00:00
Mark Jaquith
1419b404a8
Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743 . props koopersmith, nacin, helenyhou.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:52:19 +00:00
Daryl Koopersmith
8efc323e2e
Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:28:21 +00:00
Andrew Nacin
173806d7a1
Restore the Description field to the media UI in 3.5.
...
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.
Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.
Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.
Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768 , this should be fixed. For now, Description stays.
This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984 ). So, here is a more obvious 'workaround' for the tooltip community.
Finally, this:
* Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
* Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
* Hides the 'Describe this file...' placeholder when a field is read-only in the modal.
props nacin, helenyhou.
fixes #22759 .
git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Mark Jaquith
bc8ddb3e64
Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
...
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Ryan Boren
d4abd95449
Scope button classes so they can be used on the frontend without interfering with theme styles.
...
Props helenyhou, koopersmith
fixes #22644
git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Ryan Boren
27d943786b
Introduce API to add back the description field in the new media popup.
...
Props nacin
fixes #22642
git-svn-id: http://core.svn.wordpress.org/trunk@22929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 23:52:30 +00:00
Ryan Boren
cc9b248937
Always send nocache_headers() for admin-ajax.php. This prevents iOS from caching ajax calls. http://stackoverflow.com/questions/12506897/is-safari-on-ios-6-caching-ajax-results
...
Turn off multi selection uploads for mobile devices. Currently Plupload cannot upload multiple files in iOS Safari. Only the first file makes it to the queue.
Empty wp on unload to work around caching in iOS Safari.
Props azaozz, miqrogroove, nacin
fixes #22552
git-svn-id: http://core.svn.wordpress.org/trunk@22872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:17:53 +00:00
Ryan Boren
11c5f2c1fc
Only show the image edit button for image attachments. Props markoheijnen. fixes #22596
...
git-svn-id: http://core.svn.wordpress.org/trunk@22867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:06:02 +00:00
Ryan Boren
b7c0d84c7f
In media_upload_flash_bypass(), pass the post id in the media-new.php url.
...
In media-new.php, use post_id from REQUEST if passed and the current user can edit the post.
Fixes adding media with the browser uploader.
Props nacin, ocean90
fixes #22572
git-svn-id: http://core.svn.wordpress.org/trunk@22853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 23:10:19 +00:00
Andrew Nacin
4e9e4bf2cf
Back compat for media_buttons_context, which is not the correct filter for adding new media buttons. If you want to add additional media buttons, use the media_buttons action instead. fixes #22559 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:32:35 +00:00
Ryan Boren
5b94b6b43e
In media_buttons(), consult global post_ID if get_post() comes up with nothing.
...
Default postID to 0 in wp_enqueue_media().
Props nacin
fixes #22085
git-svn-id: http://core.svn.wordpress.org/trunk@22846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:03:37 +00:00
Andrew Nacin
efd9913490
Mustn't forget to hide the legacy media uploader! see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 13:23:27 +00:00
Andrew Nacin
9120cf3375
WP_Image_Editor: the last stand.
...
* Have wp_get_image_editor() rather than WP_Image_Editor::get_instance(). Having static factory methods would be less confusing if there weren't also static methods tied to individual editor implementations.
* Lazy-load the WP_Image_Editor base class and editor implementations.
* Have WP_Image_Editor_GD::supports_mime_type() actually check which types it supports.
* Deprecate gd_edit_image_support() in favor of wp_image_editor_supports().
props DH-Shredder, scribu, markoheijnen. fixes #22356 . see #6821 .
git-svn-id: http://core.svn.wordpress.org/trunk@22817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:52:16 +00:00
Daryl Koopersmith
0d08430cfe
Media: Replace the thumbnail on post.php using a request variable instead of the referer. props ocean90. fixes #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 03:43:16 +00:00
Andrew Nacin
55a6c62e76
Support attachment_fields_to_save and attachment_fields_to_edit for attachments going through post.php. see #22186 . see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 18:53:00 +00:00
Andrew Nacin
9b54e5c380
Have the media modal direct users to media-new.php for the browser uploader. fixes #22444 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:30:48 +00:00
Andrew Nacin
229a919b27
media-new.php: Remove unused scripts, strings, error handling, save handling, and save button. fixes #22083 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:10:17 +00:00
Andrew Nacin
75c464671d
Revert accidental changes to admin/includes/media.php in [22755]. see #22083 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 14:04:24 +00:00
Andrew Nacin
1935e74233
Properly nest the if tag. props helenyhou. see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:32:26 +00:00
Andrew Nacin
e276fc44be
Have media-new.php return simple rows of basic attachment data, with an 'Edit' link next to each taking them to post.php (in a new window). Not ideal, but this is largely a fallback screen at this point.
...
This is bolted on to existing code, the vast majority of which is destined to be ripped out in 3.6 once things settle.
see #22083 .
git-svn-id: http://core.svn.wordpress.org/trunk@22755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:05:44 +00:00
Andrew Nacin
96576a2dca
Properly refresh the thumbnail on post.php after an image edit. props ocean90. see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:05:24 +00:00
Andrew Nacin
9ad10730c0
Non-images don't have alternative text. props helenyhou. see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:03:35 +00:00
Andrew Nacin
8f3a9e1907
Stop inserting title attributes for images inserted into the editor by modifying get_image_send_to_editor(), not the generic get_image_tag().
...
see #18984 , [22409].
git-svn-id: http://core.svn.wordpress.org/trunk@22747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 11:50:30 +00:00
Daryl Koopersmith
b75ec467b2
Media: Whoops. Remove error_log. see [22699], #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:40:31 +00:00
Daryl Koopersmith
b1f720c616
Media: Improve media buttons on the front end.
...
* Use a less specific selector (the body, actually) to delegate opening the media dialog.
* Allow the editor ID to be the empty string so the `media_buttons` action can be called without arguments.
see #22284 , #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:35:30 +00:00
Andrew Nacin
4b9ef4ee05
Remove errant return. props SergeyBiryukov. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 09:48:34 +00:00
Andrew Nacin
bd158c503f
Move code from image_attachment_fields_to_edit() to get_attachment_fields_to_edit(). The level of abstraction is unnecessary, and it makes it more difficult to call only the filter in the new media modal. Also, that function is sloooow. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:10:38 +00:00
Andrew Nacin
479d27013a
Avoid doing all of the extra work in get_attachment_fields_to_edit() for fields we will just discard. We just need the filter, and the taxonomies. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:20:47 +00:00
Andrew Nacin
0a888e8aa0
Prevent notices when post_id is not passed to the old media upload forms. props ldebrouwer. fixes #22465 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:42:14 +00:00
Daryl Koopersmith
fd6b847330
Media: Make edit gallery button use new media. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 09:06:10 +00:00
Daryl Koopersmith
82213846c3
Media: Add backwards compatibility for attachment_fields_to_edit and attachment_fields_to_save. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:26:42 +00:00
Daryl Koopersmith
bed08350f4
Media: Backwards compatibility for media_upload_tabs.
...
* Adds `createIframeStates()` to the `MediaFrame` view. It creates states and bindings for the `media_upload_tabs` output, and is included on `MediaFrame.Post` by default.
* Hijacks `tb_remove()` when the media modal is open to ensure the modal closes correctly.
* Adds a `chromeless` parameter to thickbox media tab URLs to render the UI without the old row of tabs.
see #22186 , #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 07:51:37 +00:00
Daryl Koopersmith
0a67c025e5
Media: Add wp_enqueue_media to easily include all media dependencies.
...
Also, media templates now print on `wp_footer`.
props sushkov. fixes #22060 , see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 04:57:25 +00:00
Andrew Nacin
9d7cb4ac7a
Translate. see #19956 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 04:40:56 +00:00
Daryl Koopersmith
0a5cdbb838
Media: Rename the "Beta Media" button to "Add Media". fixes #19956 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 04:35:38 +00:00
Andrew Nacin
c26f579b13
Put the label outside the span to ensure margins when the text wraps. props waclawjacek. fixes #19254 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:41:31 +00:00
Andrew Nacin
039279db28
Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:00:51 +00:00
Andrew Nacin
224a21db80
Stop adding title attributes to images (in the old media uploader). props martythornley. fixes #18984 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:23:03 +00:00
Ryan Boren
53c0024945
Use wp_basename() instead of basename() so that multibyte characters are not stomped. Props SergeyBiryukov. fixes #21217
...
git-svn-id: http://core.svn.wordpress.org/trunk@22367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 14:33:56 +00:00
Ryan Boren
ad724f3b7b
Attachment editor improvements. Put the non-editable metadata into the submit/publish box.
...
Props helenyhou
see #21391
git-svn-id: http://core.svn.wordpress.org/trunk@22364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 14:04:22 +00:00
Andrew Nacin
4cbc20ada1
Pass the post date to wp_upload_dir() during sideloads, just as we do uploads. Ensures that sideloaded images make it into the right uploads directory.
...
props solarisssmoke, fixes #16777 .
git-svn-id: http://core.svn.wordpress.org/trunk@22105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-03 18:49:37 +00:00
Ryan Boren
82ae25da11
Respect ssl for the image src link in edit_form_image_editor(). see #21391
...
git-svn-id: http://core.svn.wordpress.org/trunk@22093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 19:51:23 +00:00
Andrew Ozz
d62abf57d6
Fix "add media" icon in DFW for IE < 9, restore media-button.png, add media-button-2x.png and make them background images, see #21019
...
git-svn-id: http://core.svn.wordpress.org/trunk@22077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-28 00:33:40 +00:00
Daryl Koopersmith
0c42e6121a
Add QuickPress support for new media workflow.
...
* Adds the code required to include the new media scripts, styles, and settings to `media_button()`.
* Improves script dependencies, namely making `media-upload` require `media-views`.
* Some CSS tweaks for the making the new button work well with QuickPress.
see #21390 , fixes #22021 .
git-svn-id: http://core.svn.wordpress.org/trunk@22072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 20:04:34 +00:00
Andrew Nacin
2cdd7b7840
Don't give a 'Beta Media' string to the translators that is only temporary.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 05:19:34 +00:00
Daryl Koopersmith
eec758fd26
BUTTON.
...
Add a "Beta Media" button to the post editor. Currently, it is only capable of inserting images. Other attachment types and galleries need not apply... yet.
* Added `wp.media.string.image( attachment, props )` for generating an image as a string from an attachment and relevant attachment display properties.
* Properly localized the gallery workflow.
* Added `Workflow.update()`, which closes the modal, triggers an `update` event, and resets the selection.
* Added `wp.mce.media` to manage the various media workflows for editors.
see #21813 , #21814 , #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 04:09:43 +00:00
Andrew Nacin
1acd8b556f
New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
...
Be on the lookout for weirdness.
props lessbloat. see #21456 .
git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Ozz
1924ec4117
Add menu-vs-2x.png and 2x media-button.png, pngcrush all in wp-admin/images, props empireoflight, see #21019
...
git-svn-id: http://core.svn.wordpress.org/trunk@21980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 19:44:42 +00:00
Andrew Nacin
33af30eb7f
Use the regular post type UI for editing single media items (attachments).
...
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
* Taxonomies attached to the media library now appear in the admin menu (if show_ui).
* Editing, cropping, uploading, etc. is still very rough, but mostly functional.
API-wise:
* New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
* Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
* wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
* New edit_form_after_title hook.
props helenyhou, ocean90. see #21391 .
git-svn-id: http://core.svn.wordpress.org/trunk@21948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 22:52:54 +00:00
Andrew Nacin
c1b0670c2d
Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Andrew Nacin
52320dc5b3
It is 'Alternative Text', not 'Alternate Text'. props alecrust, RyanJKoehler. fixes #21176 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 16:55:43 +00:00
Andrew Nacin
96d002c4dd
Return term slugs rather than term names in attachment_fields_to_edit() as that is what we are dealing with. props eddiemoya, fixes #20765 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 17:34:01 +00:00
Andrew Nacin
63f80ff4af
Basic phpdoc for admin includes media.php. props c3mdigital. fixes #21144 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 18:31:42 +00:00
Ryan Boren
f56d8278bb
Remove return ref from all calls to get_post()
...
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:01:10 +00:00
Ryan Boren
15dd7f70b0
Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194
...
git-svn-id: http://core.svn.wordpress.org/trunk@21504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:39:15 +00:00
ryan
44ef6d8e80
Deprecate and stub _media_button. fixes #21317
...
git-svn-id: http://core.svn.wordpress.org/trunk@21353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 21:33:01 +00:00
ryan
1c175f829e
Deprecate and stub _insert_into_post_button(). fixes #20427
...
git-svn-id: http://core.svn.wordpress.org/trunk@21352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 21:30:06 +00:00
westi
4c33feb5ef
Multisite: Tidy up [21256] and introduce/correct PHPDoc for a few other media upload functions.
...
Fixes #21179 props SergeyBiryukov.
git-svn-id: http://core.svn.wordpress.org/trunk@21260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-11 10:20:15 +00:00
westi
2039e3a8f0
Multisite: Make it easy to replace or augment the over-quota message displayed when you try and upload new media and you have reached your quota.
...
Fixes #21179 props dllh, jkudish.
git-svn-id: http://core.svn.wordpress.org/trunk@21256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-10 13:33:44 +00:00
markjaquith
109768b788
Hide UI for Attachment taxonomies if show_ui is false for that taxonomy. props simonwheatley. fixes #21104
...
git-svn-id: http://core.svn.wordpress.org/trunk@21240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 04:56:50 +00:00
markjaquith
6a1d888ea5
Better image extension regexes, so we don't just grab the "jpe" from "jpeg" files in media_sideload_image(). props sivel. fixes #16693
...
git-svn-id: http://core.svn.wordpress.org/trunk@21219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-05 20:51:55 +00:00
nacin
a90957aca0
Inline documentation for image_attachment_fields_to_save(). props Moraleida.me. fixes #20803 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 20:31:28 +00:00
ryan
6e030d2ed4
Preserve context when searching in the media upload form. Props SergeyBiryukov. fixes #20856
...
git-svn-id: http://core.svn.wordpress.org/trunk@21008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 16:00:08 +00:00
azaozz
6499a905a3
Image captions: revert label change back to "Caption", fixes #18311
...
git-svn-id: http://core.svn.wordpress.org/trunk@20826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-18 02:50:05 +00:00
ryan
fa13d2cf18
Update upload-html-bypass string to reflect that the uploader is no longer new. Props Ipstenu. fixes #20627
...
git-svn-id: http://core.svn.wordpress.org/trunk@20735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-07 16:48:35 +00:00
azaozz
e8beafd57b
Change the image caption shortcode format to [caption ...]<a><img /></a> caption text + html[/caption]. That way HTML tags in captions are better supported and the shortcode wouldn't break when using the wrong quotes. Props sushkov, nacin, fixes #18311
...
git-svn-id: http://core.svn.wordpress.org/trunk@20679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 01:14:52 +00:00
azaozz
f58a801e62
Fix typo in the error message shown when a device doesn't support uploading, props SergeyBiryukov, fixes #20410
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-20 01:10:39 +00:00
azaozz
817b932ed1
Don't hide links to the upload form and show an error for mobile devices that cannot upload, see #20410
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-12 00:16:37 +00:00
azaozz
1d12cd07b0
Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 01:19:30 +00:00
nacin
d5cc12048e
Use _callback, rather than an unhelpful 2, for a preg_replace callback function name. Add proper phpdoc. see #20369 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 20:05:31 +00:00
duck_
1480a33d25
Simplify caption cleanup callbacks; if the function was called we know that the 0 index is set. See #20369 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 19:52:34 +00:00
azaozz
f06fb15878
Pluck a tab (whitespace), props SergeyBiryukov, see #20369
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 18:26:14 +00:00
azaozz
2441cb0cae
Fix second callback when filtering caption text for shortcode, props SergeyBiryukov, fixes #20369
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 17:38:49 +00:00
ryan
d3134e2688
Allow selecting custom header and background images from the media library. Props aaroncampbell, sabreuse, greuben. fixes #19840
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-05 00:20:28 +00:00
nacin
a95f3d243a
Revert label change in [20282]. see #18311 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-28 20:32:29 +00:00
markjaquith
dc82254e2f
Wrap attachment delete link in <p> for semantics and alignment. props aaroncampbell, lancewillett. fixes #19785
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-28 20:28:34 +00:00
nacin
9cca792f6c
Revert UI for caption fields to pre-[19982], keeping textarea for the caption field. No monospaced font, revert label. see #18311 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-24 13:37:42 +00:00
azaozz
3015057d58
Don't use class="code" for the captions textareas as it resets RTL, see #18311
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-21 22:48:36 +00:00
azaozz
ca3ab6c5c2
Add support for line breaks to the caption textareas, see #18311
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-14 21:53:11 +00:00
azaozz
f3b63e4537
Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
azaozz
9f4408c741
Based on the current UX feedback, remove the "Insert Link" UI from under the caption fields, see #18311
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-05 07:31:31 +00:00
ryan
e4ce1046b0
Pass post id to get_upload_iframe_src() instead of relying on a global. Props tott. fixes #20003
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-27 19:23:03 +00:00
azaozz
73c87020c7
HTML in image captions, first run, see #18311
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-24 01:58:18 +00:00
nacin
bfeb575df9
Use relative paths for admin-ajax.php to avoid cross-domain issues with IDN domains in IE and Opera. props SergeyBiryukov, fixes #18952 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 16:12:11 +00:00
ryan
c924060858
Remove extraneuos newlines
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-21 18:42:11 +00:00
ryan
6bba5a265b
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
azaozz
5ec6bd4833
Sanitize options for resizing in the uploader, props mhauan, nacin, fixes #19399
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 21:05:22 +00:00
azaozz
3fcae6d702
Output the "After a file has been uploaded..." message by using the post-upload-ui action, fixes #18764
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 20:46:15 +00:00
azaozz
6c38abc51d
Show Insert into post button in the media library when the current post supports editor (not the attachment parent), props SergeyBiryukov, fixes #18912
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-19 04:28:39 +00:00
azaozz
7f9b0fcc1e
Don't show the uploader on iPads (it's pointless), fixes #19004
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 08:43:16 +00:00
azaozz
af14c4fdb0
Change text prompt in HTML uploader, props jane, fixes #19276
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 01:25:27 +00:00
nacin
f0eebf3376
Remove extra space. props danielbachhuber.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-17 04:41:51 +00:00
azaozz
8f4fd39550
Add big-file-upload-warning for IE and Opera, left-align the percentage in the progress bar, see #19228
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 23:21:16 +00:00
azaozz
e09e8f465c
Filter the link href when inserting external image in the editor, props DrewAPicture, fixes #18445
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 19:35:32 +00:00
azaozz
a491abfbb2
Media Lib: fix displaying file headers in IE7, delegate the Show/Hide JS, prevent displaying upload error for the same file twice, see #19228
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-13 18:37:30 +00:00
azaozz
7123026a3b
Add error message when a big file fails to upload, expose the XHR request in plipload and abort() it, see #19228
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-13 02:01:13 +00:00
azaozz
9961962861
Uploader: fix file-size-exceeded error handling, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-12 00:52:26 +00:00
nacin
64ab05ab09
Normal sentence case. see #19228 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-11 20:32:20 +00:00
azaozz
a37b440bac
Bring back the multi-file/html uploader switching, see #19228
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-11 19:40:23 +00:00
ryan
61fca35691
Don't show 'Use as featured image' in the image insert dialog if the post type does not support thumbnails. Props SergeyBiryukov. fixes #18669
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-11 19:38:34 +00:00
azaozz
6074eda69d
Uploader: fix progress bar JS and update the style (light blue bars), see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 20:33:26 +00:00
nacin
087eb4e30a
Rename attachment link button from 'Post URL' to 'Attachment Post URL.' props jeremyclarke, fixes #13544 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-09 19:23:31 +00:00
azaozz
eca4184725
Revert media.php too, see #19174
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 22:42:20 +00:00
azaozz
623220187a
Remove the Resize files checkbox for now (revisit in 3.4), fixes #19174
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 22:23:40 +00:00
nacin
534578f339
Space out two strings. props ocean90, fixes #19167 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-05 20:21:12 +00:00
azaozz
f7fa2684e8
Uploader: split "Drop files here -or-..." on two lines, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-05 18:09:38 +00:00
azaozz
84a23bfd81
Remove the Cancel Upload button, fixes #19050
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 01:47:12 +00:00
azaozz
b63ffa3f38
Disable the Cancel Upload button after the upload has finished or if it was interrupted, fixes #19050
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 21:38:28 +00:00
ryan
62afab8db3
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 19:13:23 +00:00
nacin
7ed04cc2f3
Deprecate media_upload_(image|audio|video|file)(), type_url_form_(image|audio|video|file)(). These now wrap wp_media_upload_handler() and wp_media_insert_url_form(). see #17578 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-23 17:58:06 +00:00
nacin
1387dfd1f2
Fix media/audio/file URL insertion. Strip slashes off title text. Leave red X to images only. fixes #14996 . fixes #17578 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 19:32:40 +00:00
azaozz
e849d3b270
Use IE conditionals when adding the ie8 class, introduce _wp_admin_html_begin(), props scribu, fixes #18966
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-17 20:57:32 +00:00
duck_
6926503ebf
Fix notices in wp_iframe() and iframe_header() by referencing $wp_htmltag_class as a global. See r18975 and #18314 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-15 10:43:55 +00:00
azaozz
0f2431e25a
RTL, IE7 and IE7 RTL fixes, add class="ie8" to the html tag, see #18314
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-15 07:33:01 +00:00
azaozz
000208b86d
Fix visibility of Select Files button in IE7, change border color when hovering over the drag drop area of the uploader, see #18918 , see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-12 22:24:53 +00:00
azaozz
eb792ad204
Add translation comment, props ocean90, fixes #18881
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-08 03:14:41 +00:00
azaozz
7672731d95
Fix prepending $editor_id to the Add Media link, see #17578
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 19:12:55 +00:00
azaozz
18630a3d5a
Add cap check before showing a link to image options, improved handling for translation, props SergeyBiryukov, see #18881
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 16:59:33 +00:00
azaozz
4878bc6ca0
As per the recommendations: make the text inside the files drop box larger, improve the explanation about the "resize image" checkbox, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-06 09:57:50 +00:00
nacin
7afd7005aa
Align the bytes.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 22:57:17 +00:00
nacin
330cf9d4a4
type_url_form_image() becomes wp_media_insert_url_form(), media_upload_image() becomes wp_media_upload_handler(). type_url_form_* and media_upload_* are restored as wrappers. Don't deprecate yet. see #17578 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 22:36:03 +00:00
nacin
593bce9f3e
UI touches for the single media button. see #17578 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 21:07:04 +00:00
nacin
cb1477ecfd
Merge the four media buttons into one.
...
* Lots of red.
* Removes the type_url_form_\$type filter, where \$type is audio, video, file, or image.
* Replacement filter is a generic type_url_form_media filter for the new unified form.
* Some functions have gone missing; they'll be restored and deprecated in a later pass.
see #17578 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@18831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-30 06:22:29 +00:00
azaozz
75432d53b0
Clean up remnants from having negative Post_IDs, props markjaquith, fixes #18235
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 21:47:52 +00:00
azaozz
fea5c38ef4
Add filter so the users can select custom image sizes added by themes and plugins, props alexkingorg, fixes #18520
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-28 17:27:48 +00:00
duck_
29c5eaadfd
Remove extraneous closing script tag. Props ryanhellyer. See r18482, #18206 . Fixes #18760 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-23 14:36:57 +00:00
azaozz
ae2219cd30
Update plupload to 1.5b and add "drop area" for drag and drop uploading, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-18 02:25:23 +00:00
duck_
551198c5ca
Don't obliterate $title if $desc isn't set. Props kawauso. Fixes #18185 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-17 18:27:32 +00:00
azaozz
2605391379
Improve handling of plupload init and add a filter, stop including cookies in the init (not needed with plupload), see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 05:30:58 +00:00
westi
0668193437
When inserting a Gallery to be ordered by Date/Time use the post_date field for ordering rather than ID so that if the user/plugin has updated this to reflect the date/time when an image was captured we order correctly. Fixes #17485 props SergeyBiryukov.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-24 11:37:25 +00:00
azaozz
1cdec6ff6e
Merge most admin css files, first run, see #18314
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-21 03:46:43 +00:00
azaozz
9a65f6e237
Fix handling of resizing images after upload, props ocean90, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-06 21:04:15 +00:00
azaozz
d012143326
Fix send_to_editor() and Insert/Upload buttons URLs, see #17144
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-06 01:35:02 +00:00
azaozz
f634dd5af4
Editor API enhancement, first run (still needs some work), see #17144
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-03 10:19:00 +00:00
azaozz
07bf8b352e
Remove tabs from JS, props duck_, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-31 08:44:29 +00:00
azaozz
34467767ff
Add SWFUpload back for plugins that queue it directly, fix some escaping in media.php, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 19:21:21 +00:00
azaozz
c5657820fb
Remove debug bits, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 09:03:24 +00:00
azaozz
91a8720fff
Pluploader take 1, props jacobwg, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 08:59:35 +00:00
azaozz
5256d7951f
<!DOCTYPE html> for all, fixes #18202
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-22 00:25:41 +00:00
ryan
db253a3fe7
Perform a cap check on attachments in media_upload_form_handler(). For trunk
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-28 21:44:56 +00:00
ryan
593659b8d0
Hardening. Santizers for WPLANG and new_admin_email. Prevent stomping ID and filter. Validate locale filename. Props westi.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-27 15:56:42 +00:00
dd32
ed5785c9ef
Only hide the browser uploader by default if the Flash uploader is enabled. Fixes #17772
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-12 12:47:18 +00:00
ryan
81a5f821fb
Sanitize guid on save and display. Sanitize mime type on save. Don't allow changing mime type via edit form handlers. Protect hidden meta.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 23:19:42 +00:00
azaozz
33b0327924
Add JS detection to wp_iframe output, remove "display:none" from the Flash uploader button, props jacobwg, fixes #17473
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-19 16:12:13 +00:00
nacin
16e649f95f
Remove type attribute from textarea. props solarissmoke.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-07 08:30:08 +00:00
ryan
924f783fda
Add some nonce checks to the uploaders. Props duck_. For trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-28 21:30:59 +00:00
ryan
498c93cb81
Revert [17327] and [15858]. Props markmcwilliams, JohnONolan, et al. see #16298 #8352
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-22 03:25:29 +00:00
ryan
55d6d8af12
PHP4 compat. Props SergeyBiryukov, westi. see #16080
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-03 19:19:34 +00:00
nacin
9009245db5
Tag textareas escaped earlier with textarea_escaped. see #15454 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-25 17:58:01 +00:00
westi
56584f6801
Ensure that images added using Press This get the correct source url set. Fixes #15841 props duck_.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-23 15:41:05 +00:00
nacin
e1eec3925a
More @since. props SergeyBiryukov, fixes #15445 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:25:21 +00:00
ryan
3a66c698ee
Remove some unnecessary esc_textarea() calls. Props garyc40. see #15454
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 17:48:20 +00:00
ryan
3949ce12d0
Pink trailing whites.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00
nacin
20bbf977a2
Fix the background colors for the Select Files upload buttons. props TECannon. fixes #8545 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 19:42:57 +00:00
nacin
fed2907095
Fix notice. props vericgar, fixes #11976 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-05 03:01:42 +00:00
scribu
c45f3936a7
More s/upgrade/update. Props michaelh. See #15656
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 09:16:28 +00:00
nacin
85c0930679
define isRtl in the media upload iframe. props filosofo, fixes #15639 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 12:44:48 +00:00
markjaquith
5f15bf9db2
Prevent media upload links from being clicked before lightbox is ready to handle them. fixes #15621
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 20:41:47 +00:00
ryan
3f72e340d6
Update since phpdoc. Props demetris. fixes #15445
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
nacin
69b3167678
Revert [15688], [15689], [15691]. Try again in 3.2. see #14966 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-22 17:17:26 +00:00
ryan
07d265659b
get_media_item_args, swfupload_post_params, and swfupload_success_handler filters. Props simonwheatley. fixes #13817
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 00:04:04 +00:00