49fdd95ac0
Docs: Correct the parameter type for `WP_REST_Post_Types_Controller::prepare_item_for_response()`.
...
Props subrataemfluence
Fixes #44437
Built from https://develop.svn.wordpress.org/trunk@43519
git-svn-id: http://core.svn.wordpress.org/trunk@43348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-22 12:26:28 +00:00
ad68a69250
Comments: Ensure that themes overriding default `comment_form()` fields still display the cookies consent checkbox.
...
The `comment_form_default_fields` filter can be used to remove the checkbox.
Props pross, SergeyBiryukov.
Fixes #44126 .
Built from https://develop.svn.wordpress.org/trunk@43518
git-svn-id: http://core.svn.wordpress.org/trunk@43347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-20 00:38:24 +00:00
51f09ffc2a
Toolbar: Fail gracefully when adding events to non-existent elements
...
Avoids a type error when `obj` is not set.
Fixes #44526 .
Built from https://develop.svn.wordpress.org/trunk@43517
git-svn-id: http://core.svn.wordpress.org/trunk@43346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 22:00:25 +00:00
d0132b292e
Privacy: Improve grammar on Privacy Settings screen.
...
Props ianbelanger, garrett-eclipse.
Fixes #44612 .
Built from https://develop.svn.wordpress.org/trunk@43513
git-svn-id: http://core.svn.wordpress.org/trunk@43342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 20:14:25 +00:00
f309e3b660
Tests: Introduce `Tests_HTTP_Functions::skipTestOnTimeout()`, mirroring the same `WP_HTTP_UnitTestCase` method.
...
See #44613 .
Built from https://develop.svn.wordpress.org/trunk@43512
git-svn-id: http://core.svn.wordpress.org/trunk@43341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 19:53:26 +00:00
3f21ed0f42
Tests: Use `WP_HTTP_UnitTestCase::skipTestOnTimeout()` in more HTTP tests.
...
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".
See #44613 .
Built from https://develop.svn.wordpress.org/trunk@43511
git-svn-id: http://core.svn.wordpress.org/trunk@43340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 19:10:25 +00:00
78de1dffb5
Privacy: Use a consistent case for "Privacy Policy page" on Privacy Settings screen.
...
Props XpertOne, idea15, garrett-eclipse.
Fixes #44130 .
Built from https://develop.svn.wordpress.org/trunk@43508
git-svn-id: http://core.svn.wordpress.org/trunk@43337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 12:10:25 +00:00
ac338b1666
Privacy: Use the actual Privacy Policy page title in `get_the_privacy_policy_link()`.
...
Props desrosj, birgire, ianbelanger, Ov3rfly.
Fixes #44192 .
Built from https://develop.svn.wordpress.org/trunk@43506
git-svn-id: http://core.svn.wordpress.org/trunk@43335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 11:50:25 +00:00
12b1b3e891
I18N: Update list of continents and cities for the timezone selection.
...
Props soulseekah, dyrer.
Fixes #44574 .
Built from https://develop.svn.wordpress.org/trunk@43504
git-svn-id: http://core.svn.wordpress.org/trunk@43333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 11:21:25 +00:00
058187d34f
Filesystem API: Skip `https://` test for `wp_is_stream()` if `openssl` extension is not loaded.
...
See #44533 .
Built from https://develop.svn.wordpress.org/trunk@43503
git-svn-id: http://core.svn.wordpress.org/trunk@43332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 09:52:24 +00:00
708e355c79
Bump akismet external to 4.0.8.
...
git-svn-id: http://core.svn.wordpress.org/trunk@43330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 06:47:37 +00:00
e3439bbe09
Filesystem API: Add basic tests for `wp_is_stream()`.
...
Props JPry.
See #44533 .
Built from https://develop.svn.wordpress.org/trunk@43501
git-svn-id: http://core.svn.wordpress.org/trunk@43328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 01:02:26 +00:00
153783a7f1
Privacy: Add unit tests for `_wp_privacy_send_request_confirmation_notification()`, introduced in [43211].
...
Props birgire, desrosj, garrett-eclipse.
Fixes #43967 .
Built from https://develop.svn.wordpress.org/trunk@43499
git-svn-id: http://core.svn.wordpress.org/trunk@43326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 22:56:25 +00:00
90d63591c6
Privacy: Mark Privacy Policy page as such in the Pages list table.
...
Props desrosj, subrataemfluence, ianbelanger, danieltj.
Fixes #44006 .
Built from https://develop.svn.wordpress.org/trunk@43495
git-svn-id: http://core.svn.wordpress.org/trunk@43322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:46:25 +00:00
5d4df64715
Twenty Seventeen: Correct list item style for nested unordered lists.
...
Props macbookandrew, audrasjb.
Fixes #44109 .
Built from https://develop.svn.wordpress.org/trunk@43493
git-svn-id: http://core.svn.wordpress.org/trunk@43320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:35:24 +00:00
df49ab8363
Docs: Change `@since` entry for `WP_Term_Query::populate_terms()` added in [43049] to 4.9.8.
...
See #42691 .
Built from https://develop.svn.wordpress.org/trunk@43491
git-svn-id: http://core.svn.wordpress.org/trunk@43318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:25:26 +00:00
172aa4aa3e
Privacy: Enable pagination screen options for privacy requests list tables.
...
Props birgire, pbiron.
Fixes #44025 .
Built from https://develop.svn.wordpress.org/trunk@43486
git-svn-id: http://core.svn.wordpress.org/trunk@43313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:04:24 +00:00
01d8979bee
Customize: Do not attempt to count uncountable value.
...
Props dlh.
Fixes #44104 .
Built from https://develop.svn.wordpress.org/trunk@43480
git-svn-id: http://core.svn.wordpress.org/trunk@43307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 14:38:24 +00:00
8f49d94630
Privacy: Rename `username_or_email_to_export` POST variable on Erase Personal Data screen to a more generic `username_or_email_for_privacy_request`.
...
Props ianbelanger, allendav.
Fixes #44181 .
Built from https://develop.svn.wordpress.org/trunk@43478
git-svn-id: http://core.svn.wordpress.org/trunk@43305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 14:15:25 +00:00
b1330814e2
Privacy: Add `$request` to `$email_data` to make it available to all filters.
...
Props desrosj.
Fixes #44379 .
Built from https://develop.svn.wordpress.org/trunk@43477
git-svn-id: http://core.svn.wordpress.org/trunk@43304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 13:53:25 +00:00
04b8839454
Privacy: Add filter for the subject of the erasure complete notification emails.
...
Props desrosj.
Fixes #44265 .
Built from https://develop.svn.wordpress.org/trunk@43475
git-svn-id: http://core.svn.wordpress.org/trunk@43302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 13:42:25 +00:00
323a5a2dc8
Privacy: Fix tests after [43467].
...
See #44141 .
Built from https://develop.svn.wordpress.org/trunk@43471
git-svn-id: http://core.svn.wordpress.org/trunk@43298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 09:58:24 +00:00
3b3542fe15
Privacy: Add a setting to disable comment cookie consent.
...
Fixes #44373 .
Built from https://develop.svn.wordpress.org/trunk@43469
git-svn-id: http://core.svn.wordpress.org/trunk@43296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 09:08:26 +00:00
cc1bfb1e55
Privacy: Don't replace comment author URL and email with anything.
...
Props TZ-Media, desrosj, birgire.
Fixes #44141 .
Built from https://develop.svn.wordpress.org/trunk@43467
git-svn-id: http://core.svn.wordpress.org/trunk@43294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 09:00:25 +00:00
46fa15291f
Streams: Return early from `wp_is_stream()` for paths that aren't streams.
...
Some versions of PHP appear to have a memory leak that is occasionally triggered by calling `stream_get_wrappers()`. In order to avoid calling this, we can return early from `wp_is_stream()` when `$path` doesn't contain `://`.
Props pbiron, JPry, dontstealmyfish.
Fixes #44532 .
Built from https://develop.svn.wordpress.org/trunk@43466
git-svn-id: http://core.svn.wordpress.org/trunk@43293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 07:54:25 +00:00
0e5e77a895
Privacy: Remove some unnecessary code comments.
...
[42967] introduced some WPCS-related comments, probably accidentally saved by an IDE.
Props burhandodhy.
Fixes #44590 .
Built from https://develop.svn.wordpress.org/trunk@43465
git-svn-id: http://core.svn.wordpress.org/trunk@43292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 07:43:24 +00:00
7c696fbed2
Editor: Use `apply_filters_deprecated()` for some deprecated filters.
...
The `htmledit_pre` and `richedit_pre` filters have been deprecated since 4.3.0, since before `apply_filters_deprecated()` existed. They're now correctly run using `apply_filters_deprecated()`.
Props sebastienthivinfocom, lbenicio, ianbelanger.
Fixes #44341 .
Built from https://develop.svn.wordpress.org/trunk@43464
git-svn-id: http://core.svn.wordpress.org/trunk@43291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 07:38:24 +00:00
c173331dc4
REST API: Fix some incorrect `@since` tags.
...
[43437] included some new methods, which were incorrectly tagged as being `@since 4.9.7`. This updates them to `4.9.8`.
Props danielbachhuber.
Fixes 44287.
Built from https://develop.svn.wordpress.org/trunk@43463
git-svn-id: http://core.svn.wordpress.org/trunk@43290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 07:27:25 +00:00
17899c1932
REST API: Attachments controller should respect upload limits.
...
When the REST API is in use on WordPress multisite, the `WP_REST_Attachments_Controller` should respect the "Max upload file size" and "Site upload space" site options.
Props flixos90, danielbachhuber.
Fixes #43751 .
Built from https://develop.svn.wordpress.org/trunk@43462
git-svn-id: http://core.svn.wordpress.org/trunk@43289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 07:22:29 +00:00
be92bbbbbb
Docs: Change `@since` entry for `add_inline_data` action added in [42676] to 4.9.8.
...
See #36085 .
Built from https://develop.svn.wordpress.org/trunk@43460
git-svn-id: http://core.svn.wordpress.org/trunk@43287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 15:27:25 +00:00
cf4f8d8737
Login and Registration: Set a better default value for `$wp_error` parameter in `login_header()`.
...
To prevent someone from passing a string (which would not be added to a new `WP_Error` instance), check for `is_wp_error()` explicitly.
Props desrosj, chetan200891, spyderbytes, lbenicio, sebastien@thivinfo.com , abdullahramzan.
Fixes #44052 .
Built from https://develop.svn.wordpress.org/trunk@43457
git-svn-id: http://core.svn.wordpress.org/trunk@43284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 14:10:26 +00:00
4faf05ca6a
Privacy: Change `@since` entry for `_wp_privacy_settings_filter_draft_page_titles()` added in [43376] to 4.9.8.
...
See #44100 .
Built from https://develop.svn.wordpress.org/trunk@43454
git-svn-id: http://core.svn.wordpress.org/trunk@43281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:48:25 +00:00
357a663899
Privacy: Change `@since` entry for `user_request_confirmed_email_subject` filter added in [43373] to 4.9.8.
...
See #44382 .
Built from https://develop.svn.wordpress.org/trunk@43451
git-svn-id: http://core.svn.wordpress.org/trunk@43278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 12:12:25 +00:00
26ca877782
TinyMCE: update to 4.8.0, changelog: https://www.tiny.cloud/docs/changelog/#version480july112018
...
Fixes #44134 .
Built from https://develop.svn.wordpress.org/trunk@43447
git-svn-id: http://core.svn.wordpress.org/trunk@43274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 08:07:26 +00:00
691dc59ad3
Privacy: Silence is golden and invisible.
...
"Be more discrete." declared matt in [3155], and since then, "Silence is Golden" has been the calling card of placeholder index files. Historically, these have been php files, but [43012] changed that and added index.html files for privacy export generated folders.
The php silence files produce no visible content. This adds consistency with these new html files in that there will be no visible content. Silence will fall when the question is asked.
Fixes #44195 .
Props audrasjb, rafsuntaskin, Ov3rfly, johnbillion, pento
Built from https://develop.svn.wordpress.org/trunk@43446
git-svn-id: http://core.svn.wordpress.org/trunk@43273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-15 23:39:27 +00:00
7216f9e623
REST API: Update the test fixture generator following [43439]
...
As [43439] added data that contains object IDs, it can cause `wp-api-generated.js` to be unnecessarily regenerated.
Regenerating our list of fixtures that need normalising rectifies this.
See #44321 .
Built from https://develop.svn.wordpress.org/trunk@43441
git-svn-id: http://core.svn.wordpress.org/trunk@43268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 04:46:25 +00:00
fd6f50e86f
REST API: Tweak permission checks for taxonomy and term endpoints
...
To match behaviour in the Classic Editor, we need to slightly loosen permissions on taxonomy and term endpoints. This allows users to create terms to assign to a post that they're editing.
Props danielbachhuber.
Fixes #44096 .
Built from https://develop.svn.wordpress.org/trunk@43440
git-svn-id: http://core.svn.wordpress.org/trunk@43267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 04:24:25 +00:00
2f803422fa
REST API: Expose revision count and last revision ID on Post response
...
So that REST API clients can show appropriate UI for a post's revisions, it needs to know how many revisions the post has, and what the latest revision ID is.
Props kadamwhite, danielbachhuber, birgire, TimothyBlynJacobs.
Fixes #44321 .
Built from https://develop.svn.wordpress.org/trunk@43439
git-svn-id: http://core.svn.wordpress.org/trunk@43266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 04:07:24 +00:00
0ba364411d
REST API: Declare user capabilities using JSON Hyper Schema's "targetSchema".
...
There are a variety of operations a WordPress user can only perform if they have the correct capabilities. A REST API client should only display UI for one of these operations if the WordPress user can perform the operation.
Rather than requiring REST API clients to calculate whether to display UI based on potentially complicated combinations of user capabilities, `targetSchema` allows us to expose a single flag to show whether the corresponding UI should be displayed.
This change also includes flags on post objects for the following actions:
- `action-publish`: The current user can publish this post.
- `action-sticky`: The current user can make this post sticky, and the post type supports sticking.
- `action-assign-author': The current user can change the author on this post.
- `action-assign-{$taxonomy}`: The current user can assign terms from the "$taxonomy" taxonomy to this post.
- `action-create-{$taxonomy}`: The current user can create terms int the "$taxonomy" taxonomy.
Props TimothyBlynJacobs, danielbachhuber.
Fixes #44287 .
Built from https://develop.svn.wordpress.org/trunk@43437
git-svn-id: http://core.svn.wordpress.org/trunk@43264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-11 06:23:27 +00:00
632d61cead
Plugins: Disable "Install Now" button for plugins that require a higher version of PHP or WordPress.
...
Display a notice with an explanation and the steps required to resolve the issue.
Props afragen, schlessera, flixos90, nerrad, melchoyce, boemedia, hedgefield, joyously, johnalarcon, lakenh, afercia, acirujano, ibantxillo, SergeyBiryukov.
Fixes #43986 .
Built from https://develop.svn.wordpress.org/trunk@43436
git-svn-id: http://core.svn.wordpress.org/trunk@43263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-09 13:45:25 +00:00
9768bde3c4
Privacy: Fix a further inconsistency of site name and URL usage in notification emails.
...
This is a follow-up to [43388].
Props desrosj.
Fixes #44396 .
Built from https://develop.svn.wordpress.org/trunk@43435
git-svn-id: http://core.svn.wordpress.org/trunk@43262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-08 13:55:28 +00:00
60252611be
Date/Time: Add support for the `c` and `r` shorthand formats in `date_i18n()`.
...
Props Rarst, pbearne
Fixes #20973
Built from https://develop.svn.wordpress.org/trunk@43434
git-svn-id: http://core.svn.wordpress.org/trunk@43261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 23:10:25 +00:00
4c2fcf36a3
Media: Update the `@since` tag for `wp_normalize_path()` as this has been backported to th 3.9 (and all other) branches.
...
See #42837
Built from https://develop.svn.wordpress.org/trunk@43406
git-svn-id: http://core.svn.wordpress.org/trunk@43234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 15:21:25 +00:00
c9dce0606b
Media: Limit thumbnail file deletions to the same directory as the original file.
...
Built from https://develop.svn.wordpress.org/trunk@43392
git-svn-id: http://core.svn.wordpress.org/trunk@43220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 14:32:25 +00:00
44b8c2e36b
Docs: Fix default values for `customize/controls.js`.
...
The old values cannot be parsed by JSDoc.
Props herregroen.
Fixes #44520 .
Built from https://develop.svn.wordpress.org/trunk@43391
git-svn-id: http://core.svn.wordpress.org/trunk@43219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 14:07:24 +00:00
5f461574e8
Tests: Fix failing test after [43388].
...
Fixes #44396 .
Built from https://develop.svn.wordpress.org/trunk@43390
git-svn-id: http://core.svn.wordpress.org/trunk@43218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 08:53:25 +00:00
46589d1578
Date/Time: Fix usage of `$gmt` parameter in `date_i18n()` and clarify its behavior.
...
The docs for `date_i18n()` and its filter now correctly state that the `$gmt` parameter is only taken into account if no timestamp is provided. Furthermore, a bug with that parameter is fixed, as it is now ensured that the timezone used with it is `UTC`.
Props Rarst.
Fixes #38771 .
Built from https://develop.svn.wordpress.org/trunk@43389
git-svn-id: http://core.svn.wordpress.org/trunk@43217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-04 23:43:25 +00:00
057b221af7
Privacy: Use consistent values for the site name and URL used in notification emails.
...
The functions `send_confirmation_on_profile_email()`, `_wp_privacy_send_request_confirmation_notification()`, `_wp_privacy_send_erasure_fulfillment_notification()`, and `wp_send_user_request()` all include a title and URL indicating the current site. However, so far they have dealt with those values inconsistently, sometimes using the site values, other times using the network values if in a multisite. This changeset ensures that only the current site is taken into account in all cases and that special characters in the site name are consistently decoded.
Props subrataemfluence, desrosj.
Fixes #44396 .
Built from https://develop.svn.wordpress.org/trunk@43388
git-svn-id: http://core.svn.wordpress.org/trunk@43216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-03 17:00:25 +00:00
dc036d5333
Date/Time: Add support for `gmt_offset` to `date_i18n()`.
...
Prior to this change, `date_i18n()` only supported the `timezone_string` option, causing incorrect timezones to appear in formatted dates on sites that still rely on the `gmt_offset` option.
Props Rarst.
Fixes #34835 .
Built from https://develop.svn.wordpress.org/trunk@43387
git-svn-id: http://core.svn.wordpress.org/trunk@43215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-03 15:59:25 +00:00
b76a714bba
Taxonomy: Introduce `is_taxonomy_viewable()`.
...
This utility function allows for easy detection whether terms for a taxonomy are considered publicly viewable.
Props andizer.
Fixes #44466 .
Built from https://develop.svn.wordpress.org/trunk@43386
git-svn-id: http://core.svn.wordpress.org/trunk@43214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-03 10:29:28 +00:00
John Blackbourn
Sergey Biryukov
Konstantin Obenland
Dion Hulse
Andrew Ozz
Gary Pendergast
Aaron Jorbin
Felix Arntz
atimmer