Commit Graph

27860 Commits

Author SHA1 Message Date
Ian Stewart 4b23645ad4 Twenty Fifteen: nicer styles for playlists.
Props iamtakashi, fixes #30163


Built from https://develop.svn.wordpress.org/trunk@30213


git-svn-id: http://core.svn.wordpress.org/trunk@30213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:33:23 +00:00
Ian Stewart cdfbccddb2 Twenty Fifteen: add a fallback icon for social links where we don't have an icon
Props iamtakashi, fixes #30148


Built from https://develop.svn.wordpress.org/trunk@30212


git-svn-id: http://core.svn.wordpress.org/trunk@30212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:02:22 +00:00
Ian Stewart c1b360a665 Twenty Fifteen: prevent a flash of visible sub menus before scripts load.
Props mattwiebe, aferica, fixes #30056.


Built from https://develop.svn.wordpress.org/trunk@30211


git-svn-id: http://core.svn.wordpress.org/trunk@30211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:58:23 +00:00
Boone Gorges 7919a6d812 Improve docblocks for `get_the_taxonomies()` and `the_taxonomies()`.
* In `the_taxonomies()`, only document those arguments that are specific to the function. Arguments shared with `get_the_taxonomies()` should be documented in the later function's docblock.
* Add $args hash documentation to `get_the_taxonomies()`.
* Remove the redundant default argument definition in `the_taxonomies()`.

Fixes #27238.
Built from https://develop.svn.wordpress.org/trunk@30210


git-svn-id: http://core.svn.wordpress.org/trunk@30210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:45 +00:00
Boone Gorges eec3eea392 Introduce `term_template` param to `get_the_taxonomies()`.
This parameter allows theme and plugin authors to specify the formatting they
would like on the term links as they are parsed into the taxonomy list.

Props hereswhatidid, dlh, davidjlaietta.
See #27238.
Built from https://develop.svn.wordpress.org/trunk@30209


git-svn-id: http://core.svn.wordpress.org/trunk@30209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:24 +00:00
Ian Stewart a46c99cf78 Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus
Props morganestes, iamtakashi, fixes #30108


Built from https://develop.svn.wordpress.org/trunk@30208


git-svn-id: http://core.svn.wordpress.org/trunk@30208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 17:01:23 +00:00
Boone Gorges 89526ca7f1 Ignore case when checking string 'false' in `wp_validate_boolean()`.
Props TobiasBg, kitchin.
Fixes #30238.
Built from https://develop.svn.wordpress.org/trunk@30207


git-svn-id: http://core.svn.wordpress.org/trunk@30207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:55:23 +00:00
Boone Gorges 99c5817822 Add unit tests for `wp_validate_boolean()`.
Props TobiasBg.
See #30238.
Built from https://develop.svn.wordpress.org/trunk@30206


git-svn-id: http://core.svn.wordpress.org/trunk@30206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:52:21 +00:00
Boone Gorges fc4b17a5d2 In `in_object_in_term()`, only check numeric string values against term_id.
The previous `in_array()` check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.

Props nobinobi, realloc.
Fixes #29467.
Built from https://develop.svn.wordpress.org/trunk@30205


git-svn-id: http://core.svn.wordpress.org/trunk@30205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:44 +00:00
Boone Gorges d2a8ae2544 Add some unit tests for `is_object_in_term()`.
These tests check a number of the ways that different kinds of values for
`$terms` (integers that match term_id, strings that match term_id or name or
slug) are handled.

See #29467.
Built from https://develop.svn.wordpress.org/trunk@30204


git-svn-id: http://core.svn.wordpress.org/trunk@30204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:22 +00:00
Scott Taylor 5e3a64e83d Correct some types in `wp-admin/*`-location files' doc blocks.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30203


git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Scott Taylor 7d7a8aa0eb Correct all `@return unknown` instances.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30202


git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor bd2521d5ee Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30201


git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Scott Taylor 196d85a9f6 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/misc.php`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30200


git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:01:24 +00:00
Scott Taylor 37f94bdfd0 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/plugin.php`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30199


git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:59:22 +00:00
Scott Taylor 64167f0845 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30198


git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:55:22 +00:00
Scott Taylor d9d825db72 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/taxonomy.php`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30197


git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:50:23 +00:00
Scott Taylor 06f49a43a1 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30196


git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:45:24 +00:00
Scott Taylor 5a3256c00b Fill in the `@param` types for the args for `make_site_theme_from_default()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30195


git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:43:21 +00:00
Scott Taylor ef944e8c19 Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function?
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30194


git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:41:23 +00:00
Scott Taylor 082a1d06ae Fill in the `@param` types for the args for `dbDelta()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30193


git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:40:22 +00:00
Scott Taylor 150b4e5157 Fill in the `@param` types for the args in `WP_Text_Diff_Renderer_Table->interleave_changed_lines()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30192


git-svn-id: http://core.svn.wordpress.org/trunk@30192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:39:22 +00:00
Scott Taylor 3e4ca28eb9 Correct the `@param` type for the `$query` arg for `remove_query_arg()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30191


git-svn-id: http://core.svn.wordpress.org/trunk@30191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:29:22 +00:00
Scott Taylor 8eee18ec0e Fill in types for the `@param`s for `wp_comment_reply()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30190


git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:21:22 +00:00
Scott Taylor 63c55ae93c Correct type in the doc block for `get_theme_support()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30189


git-svn-id: http://core.svn.wordpress.org/trunk@30189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:18:22 +00:00
Scott Taylor 3535af5b77 Correct the return value doc block for `get_theme_support()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30188


git-svn-id: http://core.svn.wordpress.org/trunk@30188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:17:23 +00:00
Scott Taylor 0eb038d97b In `Custom_Image_Header`:
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.

Built from https://develop.svn.wordpress.org/trunk@30187


git-svn-id: http://core.svn.wordpress.org/trunk@30187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:15:22 +00:00
Scott Taylor a14a4fc9a5 In `Custom_Background`, declare `$updated` as a property.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30186


git-svn-id: http://core.svn.wordpress.org/trunk@30186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:08:22 +00:00
Scott Taylor 15c062eb79 In `wp_audio|video_shortcode()`, make sure that `autoplay` and `loop` are booleans. Passing `'false'` to them will force them to be active, which is bad.
Fixes #29825.

Built from https://develop.svn.wordpress.org/trunk@30185


git-svn-id: http://core.svn.wordpress.org/trunk@30185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:03:21 +00:00
Scott Taylor a587ebc946 In `WP_Tax_Query`, declare `$primary_table` and `$primary_id_column` as properties.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30184


git-svn-id: http://core.svn.wordpress.org/trunk@30184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:45:22 +00:00
Scott Taylor 2750f0cec7 In `WP_Locale`, declare `$number_format` as a property.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30183


git-svn-id: http://core.svn.wordpress.org/trunk@30183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:40:22 +00:00
Scott Taylor a23c230c01 In `WP_Comment_Query`, declare `$query_vars` and `$comments` as properties.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30182


git-svn-id: http://core.svn.wordpress.org/trunk@30182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:08:22 +00:00
Scott Taylor c598d35e41 Almost every method in `wp_xmlrpc_server` can also return `IXR_Error` and should be labeled as such. Rehabilitate some `return` syntax.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30181


git-svn-id: http://core.svn.wordpress.org/trunk@30181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:04:22 +00:00
Scott Taylor e02c724249 `WP_Image_Editor_GD` and `WP_Image_Editor_Imagick` should specify type in a doc block for the `$image` property, instead of inferring `bool` and `null`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30180


git-svn-id: http://core.svn.wordpress.org/trunk@30180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:38:23 +00:00
Scott Taylor a887301869 In `WP_HTTP_IXR_Client`:
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class

See #30224.

Built from https://develop.svn.wordpress.org/trunk@30179


git-svn-id: http://core.svn.wordpress.org/trunk@30179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:32:22 +00:00
Scott Taylor 68a67a9b0d Fix the return docs for `WP_Embed->maybe_make_link()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30178


git-svn-id: http://core.svn.wordpress.org/trunk@30178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:27:23 +00:00
Jeremy Felt 796ceebb25 Use common core syntax for checking DOING_AJAX
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891

Built from https://develop.svn.wordpress.org/trunk@30177


git-svn-id: http://core.svn.wordpress.org/trunk@30177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:24:23 +00:00
Jeremy Felt 00c86aea63 Delete admin_created_user_subject() rather than deprecate
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.

Fixes #29915

Built from https://develop.svn.wordpress.org/trunk@30176


git-svn-id: http://core.svn.wordpress.org/trunk@30176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:07:23 +00:00
Jeremy Felt c3f51ce97a Improve layout of test for cached invalid, then valid site details
* Rename method to `test_get_blog_details_when_site_does_not_exist()`.
* Always assume `MAX(blog_id)` is 1 and therefore always create a burner.
* Remove tests specific to `wpmu_delete_blog()` and cache, to be handled elsewhere.
* Remove extra asertions.

See #30080, #23405

Built from https://develop.svn.wordpress.org/trunk@30175


git-svn-id: http://core.svn.wordpress.org/trunk@30175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 01:05:22 +00:00
Jeremy Felt 132be9d66d Split tests for wp_get_sites()
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30174


git-svn-id: http://core.svn.wordpress.org/trunk@30174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:40:22 +00:00
Scott Taylor 783f36f855 In `_WP_Editors::editor_settings()`, `$str1` and `$str2` don't need to be initialized empty.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30173


git-svn-id: http://core.svn.wordpress.org/trunk@30173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:22:22 +00:00
Scott Taylor 303d01869c Declare the `$uploaded_headers` and `$default_headers` properties for `WP_Customize_Header_Image_Control`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30172


git-svn-id: http://core.svn.wordpress.org/trunk@30172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:18:23 +00:00
Scott Taylor 73c8e4cf10 Declare the `$update_count` and `$update_current` properties for `WP_Upgrader`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30171


git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:07:23 +00:00
Scott Taylor 3fc8778359 Declare the `$options` property for `WP_Upgrader_Skin`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30170


git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:03:22 +00:00
Scott Taylor 4d0f66854a Fix the return value doc for `WP_List_Table->get_pagination_arg()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30169


git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:00:23 +00:00
Scott Taylor 6a109700d0 In `wp_ajax_get_tagcloud()`, bail immediately if `$_POST['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30168


git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:54:22 +00:00
Scott Taylor a786fb779c In `wp_ajax_ajax_tag_search()`, bail immediately if `$_GET['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30167


git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:48:22 +00:00
Scott Taylor a79b6fdde3 In `get_the_pagination()`, don't pass `$links` to `_navigation_markup()` if it is not a string - `paginate_links()` can return an `array`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30166


git-svn-id: http://core.svn.wordpress.org/trunk@30166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:41:23 +00:00
Scott Taylor 892be738b0 Make the docs type for `return` in `wpmu_create_user()` more specific.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30165


git-svn-id: http://core.svn.wordpress.org/trunk@30165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:33:21 +00:00
Scott Taylor e41e38183d In `customize.php`, check that `$autofocus` is an `array` after running `wp_unslash()` instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30164


git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:17:22 +00:00