WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,678 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

42678 Commits

Author SHA1 Message Date
Sergey Biryukov 4bb4107f50 General: Use correct value for the `speak` property in various CSS files. 
Follow-up to [49263].

Props hareesh-pillai.
Fixes #51622.
Built from https://develop.svn.wordpress.org/trunk@49309


git-svn-id: http://core.svn.wordpress.org/trunk@49071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 02:25:09 +00:00
TimothyBlynJacobs 367c97df67 REST API: Prevent PHP warning when metadata schema is missing properties. 
This switches to the new `rest_default_additional_properties_to_false()` function which doesn't have this issue and deprecates the `WP_REST_Meta_Fields::default_additional_properties_to_false()` method.

Props austin880625.
Fixes #51389.

Built from https://develop.svn.wordpress.org/trunk@49308


git-svn-id: http://core.svn.wordpress.org/trunk@49070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 20:30:08 +00:00
TimothyBlynJacobs 5f5457dff2 Build Tools: Fix running installing composer dependencies using composer 2.0. 
This updates the `dealerdirect/phpcodesniffer-composer-installer` package to allow installing version `0.7.0` which supports composer 2.0.

Props itowhid06, jrf.
Fixes #51624.

Built from https://develop.svn.wordpress.org/trunk@49306


git-svn-id: http://core.svn.wordpress.org/trunk@49068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 01:14:07 +00:00
Sergey Biryukov 7b2c3a006e Tests: Correct newly introduced `@covers` tags. 
When global functions are covered, they need to be prefixed with `::` (double colon) to distinguish them from class name.

See https://phpunit.readthedocs.io/en/7.0/annotations.html#covers for more details.

Follow-up to [49000], [49171].

Props jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@49305


git-svn-id: http://core.svn.wordpress.org/trunk@49067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 00:33:04 +00:00
Sergey Biryukov 5770b676b0 Docs: Correct an example in `wp_kses_normalize_entities()` description. 
Props ediamin.
Fixes #51620.
Built from https://develop.svn.wordpress.org/trunk@49304


git-svn-id: http://core.svn.wordpress.org/trunk@49066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 00:14:05 +00:00
TimothyBlynJacobs 19c72d58e7 REST API, XML-RPC: Synchronise empty comment content checks. 
The REST API and XML-RPC now uses the same detection methodology for empty comment content as `wp_handle_comment_submission()`. Specifically, comments now have their content trimmed and '0' is allowed.

Props jaswrks, rmccue, dd32, rachelbaker, Cawa-93, aduth, TimothyBlynJacobs.
Fixes #43177.

Built from https://develop.svn.wordpress.org/trunk@49303


git-svn-id: http://core.svn.wordpress.org/trunk@49065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 22:46:09 +00:00
TimothyBlynJacobs 36c4c943ba REST API: Don't validate status if it hasn't changed. 
In particular, this allows for sending `status=inherit` to an attachment if it's current status is `inherit`. This status would be rejected because it is an "internal" post status which isn't exposed.

As a general rule, a developer should always be able to PUT back a GET response without error.

Props dfenton, pputzer, TimothyBlynJacobs.
Fixes #40399.


Built from https://develop.svn.wordpress.org/trunk@49302


git-svn-id: http://core.svn.wordpress.org/trunk@49064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 16:04:05 +00:00
TimothyBlynJacobs abbc108d19 REST API: Make template handling resilient against plugins setting the global post. 
Plugins shouldn't be setting the global post object during a REST API request, but if they did this could cause unexpected errors when creating a post with a template.

Props Kipperlenny, TimothyBlynJacobs.
Fixes #49695.

Built from https://develop.svn.wordpress.org/trunk@49301


git-svn-id: http://core.svn.wordpress.org/trunk@49063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 14:12:05 +00:00
TimothyBlynJacobs 3a01517c90 REST API: Reuse `namespace` property instead of the undeclared `rest_namespace`. 
Props itowhid06.
Fixes #48297.

Built from https://develop.svn.wordpress.org/trunk@49300


git-svn-id: http://core.svn.wordpress.org/trunk@49062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 13:54:06 +00:00
TimothyBlynJacobs 9baba12f00 REST API: Support generating comment up links to custom posts controllers. 
The comments controller now uses the `rest_get_route_for_post` function introduced in WordPress 5.5 to generate the link. This function is filterable to allow for custom controllers to properly define their REST API route.

Props dsifford, TimothyBlynJacobs.
Fixes #44152.

Built from https://develop.svn.wordpress.org/trunk@49299


git-svn-id: http://core.svn.wordpress.org/trunk@49061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 13:20:07 +00:00
Sergey Biryukov 4d695ba6b3 Coding Standards: Remove unused `$current_role` variable from Add New User form. 
Follow-up to [9614], [28296].

Props ravipatel.
Fixes #51619.
Built from https://develop.svn.wordpress.org/trunk@49298


git-svn-id: http://core.svn.wordpress.org/trunk@49060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 12:49:05 +00:00
Sergey Biryukov 10091823f1 Coding Standards: Use consistent formatting for `<div class="wrap">` sections in `wp-admin/update-core.php`. 
Follow-up to [28500], [28530].

Props ravipatel.
Fixes #51618.
Built from https://develop.svn.wordpress.org/trunk@49297


git-svn-id: http://core.svn.wordpress.org/trunk@49059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 12:33:07 +00:00
TimothyBlynJacobs 4aca25b296 REST API: Regenerate wp-api-generated.js after [49276]. 
See #51583.

Built from https://develop.svn.wordpress.org/trunk@49296


git-svn-id: http://core.svn.wordpress.org/trunk@49058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 04:29:10 +00:00
TimothyBlynJacobs 2d5d7a2aaa REST API: Deprecate `WP_REST_Meta_Fields::register_field()`. 
This method never worked properly and cannot be fixed due to incompatible method signatures.

Props flixos90, kadamwhite, jnylen0, TimothyBlynJacobs.
Fixes #39959.

Built from https://develop.svn.wordpress.org/trunk@49295


git-svn-id: http://core.svn.wordpress.org/trunk@49057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 04:27:09 +00:00
TimothyBlynJacobs f6d39d1c51 App Passwords: Improve accessibility. 
- Make form inputs stacked instead of inline.
- Provide a visible label for the app name.
- Add screen reader text to dismiss button.
- Make "Revoke" button label more descriptive.
- Use aria-disabled instead of disabled to avoid focus loss.
- Display password in a readonly input to assist copy and paste.
- Remove large sections of italic text.
- Use `.form-wrap` and `.form-field` to give consistent form styling.
- Improve labeling and placeholder text.

Props alexstine, georgestephanis, afercia, TimothyBlynJacobs.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49294


git-svn-id: http://core.svn.wordpress.org/trunk@49056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 03:34:06 +00:00
Sergey Biryukov d195b0dfbb Docs: Add missing duplicate hook references for `allow_(dev|minor|major)_auto_core_updates` filters. 
Follow-up to [49254].

See #50907.
Built from https://develop.svn.wordpress.org/trunk@49293


git-svn-id: http://core.svn.wordpress.org/trunk@49055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 00:31:05 +00:00
Sergey Biryukov bb63c1cbd9 Upgrade/Install: Account for new `WP_AUTO_UPDATE_CORE` values in auto-updates settings form. 
This updates `core_auto_updates_settings()` to account for the new `beta` and `rc` values for the `WP_AUTO_UPDATE_CORE` constant.

Additionally, recognize these new values as acceptable in Site Health tests.

Follow-up to [48804], [49245], [49254].

Fixes #51319. See #50907.
Built from https://develop.svn.wordpress.org/trunk@49292


git-svn-id: http://core.svn.wordpress.org/trunk@49054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 00:26:05 +00:00
TimothyBlynJacobs e992757e5b App Passwords: Include site_url in the success redirect payload. 
Props georgestephanis.
Fixes #51602.

Built from https://develop.svn.wordpress.org/trunk@49291


git-svn-id: http://core.svn.wordpress.org/trunk@49053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 00:07:08 +00:00
Sergey Biryukov ce4b1cc8ba Toolbar: Keep IE 11 scrollbar on the side instead of overlapping the toolbar. 
Props sabernhardt, shital-patel, y_kolev.
Fixes #48545.
Built from https://develop.svn.wordpress.org/trunk@49290


git-svn-id: http://core.svn.wordpress.org/trunk@49052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 19:49:08 +00:00
Sergey Biryukov ee3dac88f0 Privacy: Use more appropriate verbiage when downloading personal data export file from a row action. 
Props garrett-eclipse, bridgetwillard.
Fixes #49319.
Built from https://develop.svn.wordpress.org/trunk@49289


git-svn-id: http://core.svn.wordpress.org/trunk@49051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 19:33:07 +00:00
Sergey Biryukov d9838eed62 Posts, Post Types: Set better default title for custom post types without title support. 
The default title is now set to "(no title supported)" instead of "Auto Draft".

Props garrett-eclipse, rajanit2000, bridgetwillard, donmhico, nrqsnchz.
Fixes #45516.
Built from https://develop.svn.wordpress.org/trunk@49288


git-svn-id: http://core.svn.wordpress.org/trunk@49050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 19:09:10 +00:00
Sergey Biryukov 36d58abc8e Help/About: Clarify that discouraging search engines does not prevent them from crawling the site. 
Props carike, garrett-eclipse, hellofromTonya.
Fixes #51274.
Built from https://develop.svn.wordpress.org/trunk@49287


git-svn-id: http://core.svn.wordpress.org/trunk@49049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 18:07:13 +00:00
Sergey Biryukov f83aa63730 Coding Standards: Split long `printf()` calls for search results for better readability. 
Follow-up to [49284].

See #37353.
Built from https://develop.svn.wordpress.org/trunk@49286


git-svn-id: http://core.svn.wordpress.org/trunk@49048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 17:19:14 +00:00
Aaron Campbell 608ba462dd Upgrade/Install: Improve copy for opt-in to automatic major version updates. 
Props marybaum, kebbet.
See #50907.

Built from https://develop.svn.wordpress.org/trunk@49285


git-svn-id: http://core.svn.wordpress.org/trunk@49047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 16:36:14 +00:00
Helen Hou-Sandí e0c12cc818 Administration: Unify search results message on list tables. 
This wraps the search string in a `<strong>` tag, which makes easier to parse visually especially when your search string also contains double quotes.

Props Mista-Flo, mapk, sergeybiryukov.
Fixes #37353.

Built from https://develop.svn.wordpress.org/trunk@49284


git-svn-id: http://core.svn.wordpress.org/trunk@49046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 16:01:15 +00:00
Helen Hou-Sandí 4847fb4263 Administration: Better targeting for required form field highlighting. 
Previously, any `input` or `select` inside of a `.form-invalid` wrapper would get the red border highlighting, including submit buttons which was not visually correct. This now only applies to form elements with a class of `.form-required` inside of the `.form-invalid` wrapper. It also continues to apply the border to elements with both classes (`.form-invalid.form-required`) as that is how some of the admin markup is structured.

Plugin authors may need to do the same sort of class application seen in this commit, i.e. add `.form-required` to certain form elements.

Props sabernhardt, dilipbheda, helen.
Fixes #50686.

Built from https://develop.svn.wordpress.org/trunk@49283


git-svn-id: http://core.svn.wordpress.org/trunk@49045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 15:05:09 +00:00
Dion Hulse c575f66422 Bump Akismet external to 4.1.7. 
git-svn-id: http://core.svn.wordpress.org/trunk@49043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 04:41:58 +00:00
Sergey Biryukov 298cd04a63 Coding Standards: Update some alignment in `wp-admin/authorize-application.php` for consistency. 
Save blogs count to a variable for reusing.

Follow-up to [49270].

See #51489.
Built from https://develop.svn.wordpress.org/trunk@49282


git-svn-id: http://core.svn.wordpress.org/trunk@49042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 01:19:06 +00:00
Sergey Biryukov 0a70f9b004 Docs: Document the return value of `wp_prepare_attachment_for_js()` using hash notation. 
Props stevenlinx, Mista-Flo, johnbillion.
Fixes #50835.
Built from https://develop.svn.wordpress.org/trunk@49281


git-svn-id: http://core.svn.wordpress.org/trunk@49041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 00:43:07 +00:00
desrosj 57ae91be78 Build/Test Tools: Remove debug text included in [49267]. 
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49280


git-svn-id: http://core.svn.wordpress.org/trunk@49040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 18:12:01 +00:00
TimothyBlynJacobs ce34d0ab00 App Passwords: Support an app_id to uniquely identify instances of an app. 
Apps may now optionally include an `app_id` parameter when directing the user to the Authorize Application screen. This allows for instances of an application to be identified and potentially revoked or blocked.

Props TimothyBlynJacobs, georgestephanis.
Fixes #51583.

Built from https://develop.svn.wordpress.org/trunk@49276


git-svn-id: http://core.svn.wordpress.org/trunk@49038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 15:06:09 +00:00
Sergey Biryukov 83c900e8b3 Upgrade/Install: Add missing `</form>` tag in auto-updates settings form. 
Props imath, ahortin, dd32, afragen.
Fixes #51598. See #50907.
Built from https://develop.svn.wordpress.org/trunk@49274


git-svn-id: http://core.svn.wordpress.org/trunk@49036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 03:38:10 +00:00
TimothyBlynJacobs fe8bb3ea58 App Passwords: Fix success=false not being appended to fallback reject url. 
Props TimothyBlynJacobs, georgestephanis.
Fixes #51581.

Built from https://develop.svn.wordpress.org/trunk@49272


git-svn-id: http://core.svn.wordpress.org/trunk@49034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:44:05 +00:00
Peter Wilson 9dc6d6147a XML-RPC: Fix length validation of anonymous commenter's email address. 
Fix the first step of validating an anonymous commenters in which the length is checked prior to running regular expressions.

Follow up to [47808].
Fixes #51595.


Built from https://develop.svn.wordpress.org/trunk@49271


git-svn-id: http://core.svn.wordpress.org/trunk@49033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:42:06 +00:00
TimothyBlynJacobs 85c49351af App Passwords: Explain that apps can access to all sites in a network. 
Props georgestephanis, spacedmonkey, johnjamesjacoby, SergeyBiryukov, marybaum.
Fixes #51489.

Built from https://develop.svn.wordpress.org/trunk@49270


git-svn-id: http://core.svn.wordpress.org/trunk@49032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:36:11 +00:00
Sergey Biryukov cd04c0d68b Build/Test Tools: Only define `WP_PLUGIN_DIR` in when running core tests. 
This takes into account non-core plugins that rely on `WP_PLUGIN_DIR` being set to the expected plugin's directory in `WP_CONTENT_DIR`, or already have the constant defined.

Follow-up to [49236].

Props pierlo.
Fixes #51594.
Built from https://develop.svn.wordpress.org/trunk@49269


git-svn-id: http://core.svn.wordpress.org/trunk@49031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 00:44:05 +00:00
Peter Wilson f8e9df7a95 Tests: Use shared fixtures in XML-RPC new comment unit tests. 
See #51344.


Built from https://develop.svn.wordpress.org/trunk@49268


git-svn-id: http://core.svn.wordpress.org/trunk@49030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 00:19:08 +00:00
desrosj a8abe177a4 Build/Test Tools: Pass GitHub Action related environment variables to the Docker container. 
This ensures that `WP_UnitTestCase::skipOnAutomatedBranches()` has access to these variables so that time sensitive tests can be skipped when appropriate.

This also updates that logic to be more clear.

Follow up to [49264].

Props ocean90, johnbillion.
See #50401, #49050, #47767.
Built from https://develop.svn.wordpress.org/trunk@49267


git-svn-id: http://core.svn.wordpress.org/trunk@49029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 19:57:10 +00:00
Sergey Biryukov ecf8e59918 Docs: Add a `@since` note about `async_direct_test` key to the `site_status_tests` filter. 
Follow-up to [49232].

See #51547.
Built from https://develop.svn.wordpress.org/trunk@49266


git-svn-id: http://core.svn.wordpress.org/trunk@49028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 14:55:09 +00:00
Sergey Biryukov bbfc20ee44 Coding Standards: Rename a variable in `wp-login.php` for consistency with other instances. 
See #50767.
Built from https://develop.svn.wordpress.org/trunk@49265


git-svn-id: http://core.svn.wordpress.org/trunk@49027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 14:46:05 +00:00
desrosj f9902dc742 Build/Test Tools: Skip some tests when not in the primary branch. 
This skips time sensitive tests when GitHub Actions workflows are not being run on `master` branch.

See #50401, #39486.
Built from https://develop.svn.wordpress.org/trunk@49264


git-svn-id: http://core.svn.wordpress.org/trunk@49026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 14:07:09 +00:00
desrosj a7d6e929c9 Administration: Fix an invalid property in the Dashicons CSS file. 
Props komagain.
Fixes #51587.
Built from https://develop.svn.wordpress.org/trunk@49263


git-svn-id: http://core.svn.wordpress.org/trunk@49025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 13:16:07 +00:00
Helen Hou-Sandí 990875a7ae Post-post WordPress 5.6 beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49262


git-svn-id: http://core.svn.wordpress.org/trunk@49024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 22:23:05 +00:00
Helen Hou-Sandí a0f350b597 Post-WordPress 5.6 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49261


git-svn-id: http://core.svn.wordpress.org/trunk@49023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 22:19:06 +00:00
Helen Hou-Sandí 7e29e531bd WordPress 5.6 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@49260


git-svn-id: http://core.svn.wordpress.org/trunk@49022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 21:47:06 +00:00
Sergey Biryukov fcc04a6a37 Coding Standards: Fix WPCS issues in [49258]. 
See #46619.
Built from https://develop.svn.wordpress.org/trunk@49259


git-svn-id: http://core.svn.wordpress.org/trunk@49021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 21:20:07 +00:00
Helen Hou-Sandí e1e6e949ff Privacy: Add "Mark as completed" action. 
Props garrett-eclipse, ocean90, joostdevalk, mista-flo, helen.
Fixes #46619.

Built from https://develop.svn.wordpress.org/trunk@49258


git-svn-id: http://core.svn.wordpress.org/trunk@49020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 21:07:07 +00:00
TimothyBlynJacobs 7fe78e2f18 REST API: Make sure all supported JSON Schema keywords are output in the index. 
Previously, only a small subset of keywords were exposed which limited the utility of `OPTIONS` requests.

Props raubvogel, TimothyBlynJacobs.
Fixes #51020.

Built from https://develop.svn.wordpress.org/trunk@49257


git-svn-id: http://core.svn.wordpress.org/trunk@49019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 20:19:09 +00:00
Sergey Biryukov fbd8078d4e Comments: Add a filter for top level comments query arguments in `comments_template()`. 
Props hellofromTonya, Howdy_McGee, garrett-eclipse, davidbaumwald, thomaslhotta.
Fixes #38074.
Built from https://develop.svn.wordpress.org/trunk@49256


git-svn-id: http://core.svn.wordpress.org/trunk@49018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 20:11:06 +00:00
Helen Hou-Sandí 5b4d643d60 Privacy: Add requester IP to password reset emails. 
Props garrett-eclipse, bridgetwillard, isharis, ocean90.
Fixes #43856.

Built from https://develop.svn.wordpress.org/trunk@49255


git-svn-id: http://core.svn.wordpress.org/trunk@49017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 20:03:08 +00:00