Commit Graph

27331 Commits

Author SHA1 Message Date
Boone Gorges 50f1b45594 Add expectedIncorrectUsage flags for unit tests that generate invalid dates.
Since [29925], passing an invalid date to WP_Date_Query will generate a
_doing_it_wrong() notice. The current changeset adds the
`@expectedIncorrectUsage` flag to those existing unit tests that generate
invalid dates, such as those that test canonical redirect and is_404()
conditionals.

Fixes #25834.
Built from https://develop.svn.wordpress.org/trunk@29932


git-svn-id: http://core.svn.wordpress.org/trunk@29684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 00:41:18 +00:00
Boone Gorges 3949a8b6cc Remove invalid `continue` calls from WP_Tax_Query::get_sql_for_clause().
This was leftover code from the previous implementation, which used a `foreach()`
loop. See [29901].

Props nofearinc.
See #29738, #29718.
Built from https://develop.svn.wordpress.org/trunk@29931


git-svn-id: http://core.svn.wordpress.org/trunk@29683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 22:07:20 +00:00
Ian Stewart 31c0fa1c6e Twenty Fifteen: readable comment details in the dark colour scheme.
Props NikV, fixes #29970.


Built from https://develop.svn.wordpress.org/trunk@29930


git-svn-id: http://core.svn.wordpress.org/trunk@29682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 22:01:18 +00:00
Andrew Ozz 553bb3cf77 Editor-expand:
- Better calculation for the caret position when auto-scrolling while typing.
- Fix auto-scrolling for non-WebKit browsers when the caret is above the top of the editor.
Fixes #29954
Built from https://develop.svn.wordpress.org/trunk@29929


git-svn-id: http://core.svn.wordpress.org/trunk@29681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 21:31:18 +00:00
Ian Stewart 48e1232075 Twenty Fifteen: document the site-branding class in header.php.
Props NikV, fixes #29961.


Built from https://develop.svn.wordpress.org/trunk@29928


git-svn-id: http://core.svn.wordpress.org/trunk@29680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:52:18 +00:00
Ian Stewart f196453cb8 Twenty Fifteen: make sure we don't see borders through transparent linked images.
Props iamtakashi, fixes #29963.


Built from https://develop.svn.wordpress.org/trunk@29927


git-svn-id: http://core.svn.wordpress.org/trunk@29679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:48:18 +00:00
Ian Stewart 2934146919 Twenty Fifteen: Removes flashing of background behind fixed position elements when scrolling in mobile and desktop Safari.
Props iamtakashi, fixes #29973 and #29987.

Built from https://develop.svn.wordpress.org/trunk@29926


git-svn-id: http://core.svn.wordpress.org/trunk@29678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:35:20 +00:00
Boone Gorges cac92b2876 Throw notices when invalid date values are passed to WP_Date_Query.
`_doing_it_wrong()` notices are now generated when passing out-of-range values
(`month=13`) or invalid dates (`2014-02-29`).

Includes unit tests.

Props ChriCo.
Fixes #25834.
Built from https://develop.svn.wordpress.org/trunk@29925


git-svn-id: http://core.svn.wordpress.org/trunk@29677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:12:18 +00:00
Dominik Schilling e3e1433e9a Themes: Make it possible to delete broken themes.
props ideag, obenland.
fixes #28165.
Built from https://develop.svn.wordpress.org/trunk@29924


git-svn-id: http://core.svn.wordpress.org/trunk@29676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:46:18 +00:00
Boone Gorges 838444446b Introduce nested query support to WP_Date_Query.
This enhancement makes it possible to filter post, comment, and other queries
by date in ways that are arbitrarily complex, using mixed AND and OR relations.

Includes unit tests for the new syntax. In a few places, the existing unit
tests were slightly too strict (such as when checking the exact syntax of a SQL
string); these existing tests have been narrowed.

Props boonebgorges.
Fixes #29822.
Built from https://develop.svn.wordpress.org/trunk@29923


git-svn-id: http://core.svn.wordpress.org/trunk@29675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:34:17 +00:00
Ian Stewart da93ef02b9 Twenty Fifteen: indented nested lists in comments.
Props pauldewouters, iamtakashi, fixes #29981.


Built from https://develop.svn.wordpress.org/trunk@29922


git-svn-id: http://core.svn.wordpress.org/trunk@29674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:32:19 +00:00
Ian Stewart 24e6e8cc0a Twenty Fifteen: correct margin for pagination.
Props kwight; fixes #29964.


Built from https://develop.svn.wordpress.org/trunk@29921


git-svn-id: http://core.svn.wordpress.org/trunk@29673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:16:18 +00:00
Dominik Schilling d79cc63828 Update jQuery UI to 1.11.2.
Changelog: http://jqueryui.com/changelog/1.11.2/

see #29833.
Built from https://develop.svn.wordpress.org/trunk@29920


git-svn-id: http://core.svn.wordpress.org/trunk@29672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:02:38 +00:00
Ian Stewart 1a6b4131c7 Twenty Fifteen: add print styles.
Props iamtakashi, closes #29967


Built from https://develop.svn.wordpress.org/trunk@29919


git-svn-id: http://core.svn.wordpress.org/trunk@29671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:02:20 +00:00
Ian Stewart 747e7189a3 Twenty Fifteen: correct font fallback for Noto Serif in editor styles; Props Manoz69; Fixes #29984
Built from https://develop.svn.wordpress.org/trunk@29918


git-svn-id: http://core.svn.wordpress.org/trunk@29670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 18:40:20 +00:00
Scott Taylor fb019893f9 In `wp.Uploader`, when `uploader:ready` is triggered, set `ready` to `true` on the instance. This allows media workflows to check for an existing uploaded instance when opening.
Without this check, workflows might wait for `uploader:ready`, which could already have been fired. This would result in an unresponsive editor dropzone.

Fixes #29689.

Built from https://develop.svn.wordpress.org/trunk@29917


git-svn-id: http://core.svn.wordpress.org/trunk@29669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 05:54:18 +00:00
Scott Taylor 84a26a78a8 Cache `get_term_by()` calls:
* Add a helper function, `wp_get_last_changed()`, to retrieve a last-modified timestamp by cache group
* When caching a term, also make cache entries for slug and name via `slug:{$term_id}` and `name:{$term_id}` keys in the `$taxonomy:$last_changed` bucket that reference the term_id
* In `clean_term_cache()` and `update_term_cache()`, respect `$_wp_suspend_cache_invalidation`
* Original term cache entries maintain BC

Adds unit tests.

Props wonderboymusic, tollmanz, boonebgorges.
Fixes #21760.

Built from https://develop.svn.wordpress.org/trunk@29915


git-svn-id: http://core.svn.wordpress.org/trunk@29668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 04:45:17 +00:00
Scott Taylor 72d12b514d Add a 6th (!) attribute to `wp_get_attachment_link()` to allow `aria-describedby` to be added to gallery output.
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402.

Built from https://develop.svn.wordpress.org/trunk@29914


git-svn-id: http://core.svn.wordpress.org/trunk@29667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 04:28:17 +00:00
Boone Gorges 1470990892 Check that search value is scalar before parsing.
Prevents PHP notices when non-scalar values are passed.

Includes unit tests.

Props tivnet.
Fixes #29736.
Built from https://develop.svn.wordpress.org/trunk@29912


git-svn-id: http://core.svn.wordpress.org/trunk@29666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 03:32:20 +00:00
Andrew Ozz 6de7c43ab3 Twenty Fifteen, editor-style.css: revert the font-size back to 19px and margin back to 83px, merge the two body selectors (don't seem needed), remove redundant rtl rules and fix body.rtl selector. See #29799
Built from https://develop.svn.wordpress.org/trunk@29911


git-svn-id: http://core.svn.wordpress.org/trunk@29665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 00:27:19 +00:00
Andrew Ozz f6e96fa748 Twenty Fifteen: no `rem` in editor-style.css for now, see #29799
Built from https://develop.svn.wordpress.org/trunk@29910


git-svn-id: http://core.svn.wordpress.org/trunk@29664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 22:48:18 +00:00
Andrew Ozz dc0fee4550 Twenty Fifteen: make font-size/line-height in editor-style.css the same as in style.css. Remove margins from the editor body, interferes with autoresize in some browsers and is overriden in the default styles. See #29799
Built from https://develop.svn.wordpress.org/trunk@29909


git-svn-id: http://core.svn.wordpress.org/trunk@29663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 22:37:18 +00:00
Dominik Schilling bf16aac8e1 Comments: Don't print an empty HTML markup when `comment_reply_link()` returns no link.
props obenland.
fixes #29895.
Built from https://develop.svn.wordpress.org/trunk@29908


git-svn-id: http://core.svn.wordpress.org/trunk@29662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 21:56:19 +00:00
Dominik Schilling b89c915ed6 Customizer: Don't trigger a change event if two unchanged object values are equal, second pass.
Make Underscore.js a dependency for `customize-base` and use `_.isEqual()` to compare the values.
(Underscore.js was already enqueued via wp-util.js for Widgets.)

props westonruter.
fixes #26061.
Built from https://develop.svn.wordpress.org/trunk@29907


git-svn-id: http://core.svn.wordpress.org/trunk@29661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 18:26:17 +00:00
Dominik Schilling 4020eacd8b Customizer: Only POST dirty settings to preview to improve performance.
props westonruter.
fixes #29983.
Built from https://develop.svn.wordpress.org/trunk@29905


git-svn-id: http://core.svn.wordpress.org/trunk@29660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:50:18 +00:00
Dominik Schilling 1ab3190ddc Theme install: Remove unused strings.
fixes #29488.
Built from https://develop.svn.wordpress.org/trunk@29904


git-svn-id: http://core.svn.wordpress.org/trunk@29659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:22:18 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Boone Gorges af6beda45b Avoid redundant table joins in WP_Tax_Query.
IN clauses that are connected by OR require only a single table join. To avoid
extraneous joins, keep track of generated table aliases, and let sibling
clauses piggy-back on those aliases when possible.

Introduces WP_Tax_Query::sanitize_relation() to reduce some repeated code.

Adds unit tests to verify the JOIN consolidation, and integration tests for
cases where JOINS are being combined.

Props boonebgorges, otto42, jakub.tyrcha.
Fixes #18105.
Built from https://develop.svn.wordpress.org/trunk@29902


git-svn-id: http://core.svn.wordpress.org/trunk@29657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 16:40:18 +00:00
Boone Gorges 295f5fc9de Support nested tax query syntax in redirect_canonical().
The proper place to look for a list of queried terms is in the flat
queried_terms array, not in tax_query->queries.

See #29738.
Built from https://develop.svn.wordpress.org/trunk@29901


git-svn-id: http://core.svn.wordpress.org/trunk@29656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 15:43:19 +00:00
Sergey Biryukov 16a55620c3 Twenty Fifteen: Update some more bundled theme references after [29895].
see #29799.
Built from https://develop.svn.wordpress.org/trunk@29900


git-svn-id: http://core.svn.wordpress.org/trunk@29655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 14:35:18 +00:00
Sergey Biryukov 320ee24a55 Add line breaks at the end of network setup rules to avoid unintended merging with a subsequent line.
props socki03.
fixes #29945.
Built from https://develop.svn.wordpress.org/trunk@29899


git-svn-id: http://core.svn.wordpress.org/trunk@29654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 14:13:20 +00:00
Andrew Ozz f19ad10571 Admin menu:
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29898


git-svn-id: http://core.svn.wordpress.org/trunk@29653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 06:05:18 +00:00
Andrew Ozz ca92ca385e Twenty Fifteen: clean up skip-link-focus-fix.js, see #29799
Built from https://develop.svn.wordpress.org/trunk@29897


git-svn-id: http://core.svn.wordpress.org/trunk@29652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 05:49:19 +00:00
Boone Gorges 09fbcfc1ad Support 'EXISTS' and 'NOT EXISTS' in `WP_Tax_Query`.
These new values for the 'operator' parameter make it possible to filter items
that have no term from a given taxonomy, or any term from a given taxonomy.

Includes unit tests.

Fixes #29181.
Built from https://develop.svn.wordpress.org/trunk@29896


git-svn-id: http://core.svn.wordpress.org/trunk@29651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 00:54:21 +00:00
Andrew Nacin be7825789d Set Twenty Fifteen as the new default theme. see #29799.
Built from https://develop.svn.wordpress.org/trunk@29895


git-svn-id: http://core.svn.wordpress.org/trunk@29650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 19:58:19 +00:00
Andrew Nacin e2041b8fbb Twenty Fifteen: JSHint fixes.
* Define global variables set by wp_localize_script().
 * Remove currently unused $ variable.
 * Use dot notation when appropriate.
 * Update Gruntfile.js to ignore the html5 shiv.
see #29799.

Built from https://develop.svn.wordpress.org/trunk@29893


git-svn-id: http://core.svn.wordpress.org/trunk@29649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 19:48:19 +00:00
Ian Stewart affa411402 Importing Twenty Fifteen, first pass at our new default theme for 2015, set for 4.1.
It's good for posts, it's good for pages, it might be good for you. Development will occur in trunk. Have at it.

Props matt, iandstewart, iamtakashi, obenland, cainm, kristastevens, karmatosed, chellycat, lancewillett, kwight, davidakennedy. See #29799


Built from https://develop.svn.wordpress.org/trunk@29892


git-svn-id: http://core.svn.wordpress.org/trunk@29648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 19:28:18 +00:00
Boone Gorges 0143196338 Introduce support for nested queries in WP_Tax_Query.
Previously, tax query arguments could be joined by a single AND or OR relation.
Now, these queries can be arbitrarily nested, allowing clauses to be linked
together with multiple relations.

In a few places, WP_Query runs through a list of clauses in a tax_query in order
to set certain query vars for backward compatibility. The necessary changes have
been made to WP_Query to support this feature with the new complex structure of
tax_query. Unit tests are included for these backward compatibility fixes.

Unit tests for the new nesting syntax are included.

Props boonebgorges.
Fixes #29718. See #29738.
Built from https://develop.svn.wordpress.org/trunk@29891


git-svn-id: http://core.svn.wordpress.org/trunk@29647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 04:03:19 +00:00
Boone Gorges d64b1ed955 Use only LEFT JOINs when a meta_query contains a NOT EXISTS clause.
Mixing LEFT and INNER JOIN in these cases results in posts with no metadata
being improperly excluded from results.

Props johnrom.
Fixes #29062.
Built from https://develop.svn.wordpress.org/trunk@29890


git-svn-id: http://core.svn.wordpress.org/trunk@29646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 02:17:18 +00:00
Andrew Ozz 3ef60bf29b Quicktags: fix strict check for `instance['0']`, props afercia, fixes #29767
Built from https://develop.svn.wordpress.org/trunk@29889


git-svn-id: http://core.svn.wordpress.org/trunk@29645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 01:26:18 +00:00
Boone Gorges 54708e3e6d Use assertEqualSets() for a few taxonomy-related tests.
assertEquals() was causing problems in environments where the tests take more
than one second to run, thereby causing results to be returned in the incorrect
order.
Built from https://develop.svn.wordpress.org/trunk@29888


git-svn-id: http://core.svn.wordpress.org/trunk@29644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 00:19:18 +00:00
Boone Gorges d1d9915f07 Introduce support for nested queries in WP_Meta_Query.
Previously, meta query arguments could be joined by a single AND or OR relation.
Now, these queries can be arbitrarily nested, allowing clauses to be linked
together with multiple relations.

Adds unit tests for the new nesting syntax. Modifies a few existing unit tests
that were overly specific for the old SQL syntax. Backward compatibility with
existing syntax is fully maintained.

Props boonebgorges, DrewAPicture.
See #29642.
Built from https://develop.svn.wordpress.org/trunk@29887


git-svn-id: http://core.svn.wordpress.org/trunk@29643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-13 22:03:18 +00:00
Andrew Ozz c3b2243a98 Editor-expand: reset the editor height after the window is resized. Fixes #29952 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29886


git-svn-id: http://core.svn.wordpress.org/trunk@29642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-13 21:15:19 +00:00
Boone Gorges dbfaf60506 Don't create dummy data for each date query test.
The integration tests for using date_query in WP_Query require the creation of
dummy post data, much of which is common between a number of tests. However,
newer tests do not require as much data, so to reduce overhead we create the
data explicitly only when we need it, instead of in the setUp() method.

See #29781.
Built from https://develop.svn.wordpress.org/trunk@29885


git-svn-id: http://core.svn.wordpress.org/trunk@29641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-13 00:18:18 +00:00
Andrew Ozz f1c169f2ac Quicktags: move focusing the editor after inserting content to the end of the code blocks. Fixes a bug in Chrome where both the textarea and the window may auto-scroll to unexpected position on clicking a Quicktags button. Part props avryl, fixes #29944 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29884


git-svn-id: http://core.svn.wordpress.org/trunk@29640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 23:12:19 +00:00
Andrew Ozz 912ffccdf6 TinyMCE: fix the 'wpgallery' plugin to use a placeholder for galleries when either the 'wpview' plugin or wp.mce is not loaded. Fixes #28756
Built from https://develop.svn.wordpress.org/trunk@29883


git-svn-id: http://core.svn.wordpress.org/trunk@29639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 18:13:20 +00:00
Sergey Biryukov e5d518abee Avoid PHP notices if 'plugin' is not set for tab=plugin-information.
props avryl.
fixes #29936.
Built from https://develop.svn.wordpress.org/trunk@29882


git-svn-id: http://core.svn.wordpress.org/trunk@29638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 13:06:19 +00:00
Jeremy Felt 3a8676278d Do not send a welcome notification when noconfirmation has been flagged
When adding a new user to a site on the network, 2 emails are sent out - one for confirmation and one as a welcome. If the option for no confirmation is selected, neither should send.

props transom
Fixes #16235

Built from https://develop.svn.wordpress.org/trunk@29880


git-svn-id: http://core.svn.wordpress.org/trunk@29637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 01:11:18 +00:00
Andrew Ozz 0fbefeaaf9 Fix support for the `hide` option in wpColorPicker, props tollmanz, fixes #29632
Built from https://develop.svn.wordpress.org/trunk@29879


git-svn-id: http://core.svn.wordpress.org/trunk@29636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 00:51:18 +00:00
Andrew Ozz f6d0b7ff33 Quicktags: remove `accesskey` attributes the buttons and don't add empty `title` attributes, fixes #29358
Built from https://develop.svn.wordpress.org/trunk@29878


git-svn-id: http://core.svn.wordpress.org/trunk@29635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 00:47:19 +00:00