Commit Graph

23170 Commits

Author SHA1 Message Date
Scott Taylor 569bcc5dad Use `wp_get_nav_menus()` instead of `get_terms('nav_menu')` in `WP_Nav_Menu_Widget` to preserve use of `wp_get_nav_menus' filter.
Props Frank Klein.
Fixes #25263.


Built from https://develop.svn.wordpress.org/trunk@25332


git-svn-id: http://core.svn.wordpress.org/trunk@25294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 23:30:10 +00:00
Scott Taylor dbec80b469 Support `orderby => meta_value` in `WP_User_Query`. Adds unit test.
Props wpsmith.
Fixes #21581.


Built from https://develop.svn.wordpress.org/trunk@25331


git-svn-id: http://core.svn.wordpress.org/trunk@25293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 23:10:09 +00:00
Scott Taylor 988caeb9a7 Check `$profileuser->rich_editing` for empty before using it in Edit User admin code.
Props sorich87, c3mdigital.
Fixes #17328.


Built from https://develop.svn.wordpress.org/trunk@25330


git-svn-id: http://core.svn.wordpress.org/trunk@25292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 22:49:08 +00:00
Scott Taylor cb70e277af Add an additional available param (the `WP_User` instance) to the `user_has_cap` filter.
Props Viper007Bond.
Fixes #24490.


Built from https://develop.svn.wordpress.org/trunk@25329


git-svn-id: http://core.svn.wordpress.org/trunk@25291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 22:23:10 +00:00
Scott Taylor 2f267f6a2a Add filter `flush_rewrite_rules_hard` to give devs chance to prevent writing to file when hard-flushing rewrite rules.
Props jeremyfelt, nacin.
Fixes #23491.


Built from https://develop.svn.wordpress.org/trunk@25328


git-svn-id: http://core.svn.wordpress.org/trunk@25290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 22:19:09 +00:00
Scott Taylor 3f5ec88eda Introduce `get_previous_post_link()`, `get_next_post_link()`, and `get_adjacent_post_link()`. Allows developers to retrieve the value without `echo`ing.
Props yoavf, markjaquith, SergeyBiryukov.
Fixes #17302.


Built from https://develop.svn.wordpress.org/trunk@25327


git-svn-id: http://core.svn.wordpress.org/trunk@25289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 22:12:10 +00:00
Andrew Nacin a461a25d76 Loose validation for is_serialized() in maybe_serialize().
Built from https://develop.svn.wordpress.org/trunk@25320


git-svn-id: http://core.svn.wordpress.org/trunk@25282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 18:10:09 +00:00
Andrew Nacin 3e41af8489 Better protocol validation in set_url_scheme().
Built from https://develop.svn.wordpress.org/trunk@25319


git-svn-id: http://core.svn.wordpress.org/trunk@25281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 18:08:11 +00:00
Andrew Nacin cf3fddde96 Validate referrers to prevent off-domain redirects.
Built from https://develop.svn.wordpress.org/trunk@25318


git-svn-id: http://core.svn.wordpress.org/trunk@25280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 18:07:10 +00:00
Andrew Nacin c8a7b53c65 Tighten allowed upload file types.
Built from https://develop.svn.wordpress.org/trunk@25317


git-svn-id: http://core.svn.wordpress.org/trunk@25279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 18:04:09 +00:00
Andrew Nacin 8fe0d246fb Ignore user ID post data.
Built from https://develop.svn.wordpress.org/trunk@25316


git-svn-id: http://core.svn.wordpress.org/trunk@25278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 17:58:09 +00:00
Scott Taylor d39c01d30e Consistently wrap `author` and `excerpt` nodes with `CDATA` in feeds.
Fixes #18056.


Built from https://develop.svn.wordpress.org/trunk@25315


git-svn-id: http://core.svn.wordpress.org/trunk@25277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 16:55:09 +00:00
Helen Hou-Sandí 399a2f2ac2 Show the IP address, if available, in the comment edit screen submit meta box. props leewillis77. fixes #24638.
Built from https://develop.svn.wordpress.org/trunk@25314


git-svn-id: http://core.svn.wordpress.org/trunk@25276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 14:41:11 +00:00
Scott Taylor a563a5b2fa Replace the ancient `phpfreaks.com` RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like `&` were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
Fixes #9064.


Built from https://develop.svn.wordpress.org/trunk@25313


git-svn-id: http://core.svn.wordpress.org/trunk@25275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 03:18:08 +00:00
Scott Taylor 8bd9659d0d Move checks for `post_type` being an array inline. See [25291], [25292], #18614.
Built from https://develop.svn.wordpress.org/trunk@25312


git-svn-id: http://core.svn.wordpress.org/trunk@25274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 03:02:10 +00:00
Scott Taylor 7af06e7ab3 Add an action at the end of `WP_Query::parse_tax_query()` called (wait for it...) `parse_tax_query` which will enable developers to alter `$this->tax_query->queries` before SQL is generated. `pre_get_posts` is too early for many scenarios.
Built from https://develop.svn.wordpress.org/trunk@25311


git-svn-id: http://core.svn.wordpress.org/trunk@25273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 02:36:09 +00:00
Scott Taylor d24a3940de Make sure the queried object is non-null before accessing its properties.
Props markoheijnen, ryan.
Fixes #21394.


Built from https://develop.svn.wordpress.org/trunk@25310


git-svn-id: http://core.svn.wordpress.org/trunk@25272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 02:28:11 +00:00
Dion Hulse 3514c7d1c4 WP_HTTP: Correct the @since, and, @deprecated PHPDoc tags to reflect the class history. See #25007
Built from https://develop.svn.wordpress.org/trunk@25309


git-svn-id: http://core.svn.wordpress.org/trunk@25271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 08:10:10 +00:00
Dion Hulse 068df26686 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577
Built from https://develop.svn.wordpress.org/trunk@25308


git-svn-id: http://core.svn.wordpress.org/trunk@25270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 07:54:11 +00:00
Dion Hulse 2caf5fe381 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core().
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874

Built from https://develop.svn.wordpress.org/trunk@25307


git-svn-id: http://core.svn.wordpress.org/trunk@25269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 06:45:08 +00:00
Dion Hulse 023a4c7336 WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589
Built from https://develop.svn.wordpress.org/trunk@25306


git-svn-id: http://core.svn.wordpress.org/trunk@25268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 03:05:09 +00:00
Dion Hulse 7a6fad844a WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments.
Built from https://develop.svn.wordpress.org/trunk@25305


git-svn-id: http://core.svn.wordpress.org/trunk@25267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:55:09 +00:00
Dion Hulse 6d1ffc62ea WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237
Built from https://develop.svn.wordpress.org/trunk@25304


git-svn-id: http://core.svn.wordpress.org/trunk@25266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:43:08 +00:00
Dion Hulse f66f154ced WP_HTTP: When streaming to file, ensure that fwrite() suceeds and correctly writes the file to disk. Fixes #16057
Built from https://develop.svn.wordpress.org/trunk@25303


git-svn-id: http://core.svn.wordpress.org/trunk@25265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 01:18:08 +00:00
Sergey Biryukov b85814e48c Inline documentation for hooks in http.php.
props tw2113.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25302


git-svn-id: http://core.svn.wordpress.org/trunk@25264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-08 22:04:09 +00:00
Helen Hou-Sandí 8798685de5 Alignment standards for [25296]. props DrewAPicture. see #25171.
Built from https://develop.svn.wordpress.org/trunk@25300


git-svn-id: http://core.svn.wordpress.org/trunk@25263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 22:07:09 +00:00
Sergey Biryukov 6e5a5d21e0 Document 'wp_link_query_args' and 'wp_link_query' filters. props DrewAPicture. fixes #18042.
Built from https://develop.svn.wordpress.org/trunk@25299


git-svn-id: http://core.svn.wordpress.org/trunk@25262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 19:47:10 +00:00
Sergey Biryukov 05d55a400b Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
Built from https://develop.svn.wordpress.org/trunk@25298


git-svn-id: http://core.svn.wordpress.org/trunk@25261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 18:17:10 +00:00
Helen Hou-Sandí 304426cece Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.
Built from https://develop.svn.wordpress.org/trunk@25297


git-svn-id: http://core.svn.wordpress.org/trunk@25260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:20:09 +00:00
Helen Hou-Sandí 89421ddeaa Add `media_submitbox_misc_sections` and `audio_submitbox_misc_sections` filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171.
Built from https://develop.svn.wordpress.org/trunk@25296


git-svn-id: http://core.svn.wordpress.org/trunk@25259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:19:10 +00:00
Sergey Biryukov 3b08ae25e4 Clarify a string in discussion settings. props Ipstenu, DrewAPicture. fixes #16705.
Built from https://develop.svn.wordpress.org/trunk@25295


git-svn-id: http://core.svn.wordpress.org/trunk@25258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 15:36:09 +00:00
Sergey Biryukov b2ce0b4f93 Add 'wp_link_query_args' and 'wp_link_query' filters to allow for customizing the internal linking dialog. props CoenJacobs, goldenapples. fixes #18042.
Built from https://develop.svn.wordpress.org/trunk@25293


git-svn-id: http://core.svn.wordpress.org/trunk@25257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 12:21:12 +00:00
Scott Taylor d7704991b3 Check the value passed to `get_post_type_object()`. If it's an array, use the first item. `get_query_var( 'post_type' )` can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests.
In `template-loader.php`, move `is_post_type_archive()` and `is_tax()` directly below `is_home()`.

See #18614, [25291].


Built from https://develop.svn.wordpress.org/trunk@25292


git-svn-id: http://core.svn.wordpress.org/trunk@25256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 23:39:09 +00:00
Scott Taylor a67d551dac Ensure that the post type object is the queried object when a post type has been registered with `has_archive => true`. Ensure it is not stomped when decorated with `tax_query`. Adds unit tests.
Props nacin.
Fixes #18614.


Built from https://develop.svn.wordpress.org/trunk@25291


git-svn-id: http://core.svn.wordpress.org/trunk@25255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 22:07:09 +00:00
Andrew Nacin 4079183e42 Document the event hook in wp-cron.php. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25290


git-svn-id: http://core.svn.wordpress.org/trunk@25254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 20:52:10 +00:00
Scott Taylor d7cc1f506a Introduce `wp_using_ext_object_cache()` - mimic `wp_suspend_cache_invalidation()` and discourage direct access to `$_wp_using_ext_object_cache`, cleaning up importing of globals in functions and provides function to modify that global. Loads the packaged object cache when an external cache hasn't been loaded or doesn't contain `wp_cache_init()`.
Fixes #21401.


Built from https://develop.svn.wordpress.org/trunk@25289


git-svn-id: http://core.svn.wordpress.org/trunk@25253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 18:10:09 +00:00
Andrew Nacin 74092c3960 Correct @since in admin-footer. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25288


git-svn-id: http://core.svn.wordpress.org/trunk@25252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:38:09 +00:00
Scott Taylor bfdc55b24d Allow `is_tag()` to accept `term_id`, `slug`, 'term_name` or array of any. Many other `is_*()` funcs already do this. Adds unit tests.
Props ramiy.
Fixes #18746.


Built from https://develop.svn.wordpress.org/trunk@25287


git-svn-id: http://core.svn.wordpress.org/trunk@25251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:27:08 +00:00
Andrew Nacin 3a28152826 Inline docs for hooks in MagPie.
props natejacobs.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25286


git-svn-id: http://core.svn.wordpress.org/trunk@25250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:19:09 +00:00
Scott Taylor a4841da471 Use `get_the_title()` when dealing with `post_type`-like items in the admin.
Props nacin, DrewAPicture.
Fixes #14975.


Built from https://develop.svn.wordpress.org/trunk@25285


git-svn-id: http://core.svn.wordpress.org/trunk@25249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:08:08 +00:00
Andrew Nacin 20b0153753 Document the 'query' filter in wp-db.
props natejacobs.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25284


git-svn-id: http://core.svn.wordpress.org/trunk@25248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:07:09 +00:00
Andrew Nacin e17beb58f7 Mark the hooks in custom-background.php as duplicates.
* image_size_names_choose should be documented in wp-includes/media.php
 * wp_create_file_in_uploads should be documented in custom-header.php

see #25229.

Built from https://develop.svn.wordpress.org/trunk@25283


git-svn-id: http://core.svn.wordpress.org/trunk@25247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:05:09 +00:00
Andrew Nacin 090e0e24b9 Document comment_edit_redirect.
props dustyf.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25282


git-svn-id: http://core.svn.wordpress.org/trunk@25246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:01:09 +00:00
Andrew Nacin 8b91d32f98 Inline documentation for hooks in xmlrpc.php.
The old link for RSD is dead; update to the new one.

props bftrick.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25281


git-svn-id: http://core.svn.wordpress.org/trunk@25245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 16:56:09 +00:00
Scott Taylor b22bc5e389 Check bad dates and redirect, instead of 404ing, as necessary and appropriate.
Adds query, conditional, and canonical Unit Tests.

Props kovshenin, SergeyBiryukov, DrewAPicture.
Fixes #10935.


Built from https://develop.svn.wordpress.org/trunk@25280


git-svn-id: http://core.svn.wordpress.org/trunk@25244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 16:36:09 +00:00
Andrew Nacin 5e0040a6ca Add new ajax_query_attachments_args filter.
props alex-ye.
fixes #24285.

Built from https://develop.svn.wordpress.org/trunk@25279


git-svn-id: http://core.svn.wordpress.org/trunk@25243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 15:18:09 +00:00
Sergey Biryukov 897ddbd76c Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.
Built from https://develop.svn.wordpress.org/trunk@25277


git-svn-id: http://core.svn.wordpress.org/trunk@25242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 14:10:09 +00:00
Sergey Biryukov 14308c0d41 Deprecate get_blogaddress_by_domain(), unused since [25261]. props jeremyfelt. fixes #25235.
Built from https://develop.svn.wordpress.org/trunk@25276


git-svn-id: http://core.svn.wordpress.org/trunk@25241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 11:41:09 +00:00
Dion Hulse db6cf37f91 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049
Built from https://develop.svn.wordpress.org/trunk@25274


git-svn-id: http://core.svn.wordpress.org/trunk@25240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 08:29:09 +00:00
Andrew Nacin 9fdfa7ef5c Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25273


git-svn-id: http://core.svn.wordpress.org/trunk@25239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:38:09 +00:00