8725644d40
Posts: Introduce `get_post_types_by_support()`.
...
Similar to `get_post_types()`, this new function returns a list of post type names that support a specific feature.
Props wpsmith, barryceelen, swissspidy.
Fixes #34010 .
Built from https://develop.svn.wordpress.org/trunk@36652
git-svn-id: http://core.svn.wordpress.org/trunk@36619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 22:50:26 +00:00
9612c26db3
Users: Introduce `_wp_get_current_user()` for improved backward compatibility.
...
This new helper function is used by the pluggable functions `wp_get_current_user()` and `get_currentuserinfo()`, which was previously being called by the former before [36311]. Without it, infinite loops could be caused when plugins implement these functions, as they are now called the other way around.
Fixes #19615 .
Built from https://develop.svn.wordpress.org/trunk@36651
git-svn-id: http://core.svn.wordpress.org/trunk@36618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 22:26:28 +00:00
fa3032b076
Customize: Fix and extend broken ajax unit tests to account for partials being skipped from rendering.
...
Fixes regression introduced in [36643].
See #35914 .
Built from https://develop.svn.wordpress.org/trunk@36650
git-svn-id: http://core.svn.wordpress.org/trunk@36617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 21:46:27 +00:00
57aec38add
Styles: Clarify the allowed values for the `$media` parameter of `wp_register_style()`/`wp_enqueue_style()`.
...
Adds unit test.
Fixes #35921 .
Built from https://develop.svn.wordpress.org/trunk@36649
git-svn-id: http://core.svn.wordpress.org/trunk@36616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 20:41:26 +00:00
383c422527
Embeds: Only display an iframe when it was successfully loaded.
...
This prevents showing a blank iframe by first checking if a message was successfully received from it.
Fixes #35894 .
Built from https://develop.svn.wordpress.org/trunk@36648
git-svn-id: http://core.svn.wordpress.org/trunk@36615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 20:23:25 +00:00
6d8a3f3612
Query: Search should match `post_excerpt` in addition to title and content.
...
When ordering search results, exact matches in the post excerpt are weighted
above those in post content, but below those in the post title.
Props swissspidy, sebastian.pisula.
FIxes #35762 .
Built from https://develop.svn.wordpress.org/trunk@36647
git-svn-id: http://core.svn.wordpress.org/trunk@36614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 20:14:26 +00:00
8b786f3d1c
Make `$taxonomy` parameter optional in `get_edit_term_link()`.
...
Props nicdford, sc0ttkclark.
Fixes #35922 .
Built from https://develop.svn.wordpress.org/trunk@36646
git-svn-id: http://core.svn.wordpress.org/trunk@36613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 20:07:28 +00:00
87a9bf2b37
Docs: Use markdown instead of HTML for `code` formatting.
...
Fixes phpdoc usage in [36622], [36608], [35724], [35307].
See #35898 .
See #35869 .
See #34738 .
See #33552 .
Built from https://develop.svn.wordpress.org/trunk@36645
git-svn-id: http://core.svn.wordpress.org/trunk@36612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 19:18:27 +00:00
613cd1b020
Docs: Correct `$number` type in `number_format_i18n()`.
...
Props salcode.
Fixes #35893 .
Built from https://develop.svn.wordpress.org/trunk@36644
git-svn-id: http://core.svn.wordpress.org/trunk@36611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 18:44:26 +00:00
aa2db425d8
Customize: Skip exporting partials to client and handling rendering requests if user can't modify associated settings.
...
Introduces `WP_Customize_Partial::check_capabilities()` for parity with `WP_Customize_Control::check_capabilities()`.
See #27355 .
Fixes #35914 .
Built from https://develop.svn.wordpress.org/trunk@36643
git-svn-id: http://core.svn.wordpress.org/trunk@36610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 18:14:26 +00:00
e66a510e0c
Docs: Update the type for `$callback` parameters to `callable` in DocBlocks for `add_settings_section()` and `add_settings_field()`.
...
Props aidanlane.
Fixes #35772 .
Built from https://develop.svn.wordpress.org/trunk@36642
git-svn-id: http://core.svn.wordpress.org/trunk@36609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 18:05:27 +00:00
410ed6d615
Customizer: Add visual feedback to reorder buttons.
...
Props coreymcollins, melchoyce.
Fixes #35041 .
Built from https://develop.svn.wordpress.org/trunk@36641
git-svn-id: http://core.svn.wordpress.org/trunk@36608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 17:54:26 +00:00
54ab5fa68c
Users: Pass the array of user IDs being deleted to the `delete_user_form` action hook in two places.
...
Also updates documentation for the first parameter, `$current_user`, to clarify that it holds the `WP_User` object for the _current_ user, not the one being deleted.
Props usermrpapa.
Fixes #35063 .
Built from https://develop.svn.wordpress.org/trunk@36640
git-svn-id: http://core.svn.wordpress.org/trunk@36607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 17:42:27 +00:00
0485352508
Customizer: Contain "No image set/selected" in dashed border.
...
Props Ankit K Gupta, chris_dev.
Fixes #35826 .
Built from https://develop.svn.wordpress.org/trunk@36639
git-svn-id: http://core.svn.wordpress.org/trunk@36606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 17:27:26 +00:00
81e9462ca3
Themes: Improve error messages for broken themes.
...
Props mayukojpn for initial patch.
Fixes #35286 .
Built from https://develop.svn.wordpress.org/trunk@36638
git-svn-id: http://core.svn.wordpress.org/trunk@36605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 17:20:27 +00:00
0c242d0666
Embeds: Make the click event handler work for dynamically added links.
...
Props JamesDiGioia.
Fixes #35630 .
Built from https://develop.svn.wordpress.org/trunk@36637
git-svn-id: http://core.svn.wordpress.org/trunk@36604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 17:16:26 +00:00
a0aa608970
Docs: Improve documentation for `WP_REST_Request` to highlight a caveat of ArrayAccess when it comes to passing similar arguments for multiple request methods.
...
Props danielbachhuber, DrewAPicture.
Fixes #35799 .
Built from https://develop.svn.wordpress.org/trunk@36636
git-svn-id: http://core.svn.wordpress.org/trunk@36603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:57:26 +00:00
33048247c8
Embeds: Load the default site icon from the `wp-includes` directory.
...
Files inside the `wp-admin` directory may not be publicly available. This copies the blue WordPress logo to `wp-includes/images`.
Props thewanderingbrit.
Fixes #35322 .
Built from https://develop.svn.wordpress.org/trunk@36635
git-svn-id: http://core.svn.wordpress.org/trunk@36602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:55:27 +00:00
c5b77145a8
Docs: Improve description of `get_term()` return value.
...
Props sebastian.pisula.
Fixes #35919 .
Built from https://develop.svn.wordpress.org/trunk@36634
git-svn-id: http://core.svn.wordpress.org/trunk@36601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:48:25 +00:00
b47a3831ee
Script Loader: Introduce `wp_add_inline_script()`.
...
This new function can be used to add inline JavaScript before and after enqueued scripts, just like `wp_add_inline_style()` works for CSS.
Props atimmer, abiralneupane, ocean90, swissspidy.
Fixes #14853 .
Built from https://develop.svn.wordpress.org/trunk@36633
git-svn-id: http://core.svn.wordpress.org/trunk@36600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:44:26 +00:00
ba5cc4e776
Query: Allow a seed value to be passed when using 'rand' `$orderby`.
...
`WP_Query` allows random ordering; `'orderby' => 'rand'` translates to
`ORDER BY RAND()`. This syntax results in random ordering that is not
consistent from request to request. MySQL supports the passing of a seed value
to random sorts, such as `ORDER BY RAND(3)`, which will return the same
random value each time it's called. `WP_Query` now supports this syntax, by
passing `RAND(3)` (or whatever integer seed value you'd like) as the value
of `'orderby'`.
Props hlashbrooke.
Fixes #35692 .
Built from https://develop.svn.wordpress.org/trunk@36632
git-svn-id: http://core.svn.wordpress.org/trunk@36599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:40:26 +00:00
710be9d2ba
L10n: Add test for `wp_dropdown_languages()`.
...
Props realloc.
Fixes #35294 .
Built from https://develop.svn.wordpress.org/trunk@36631
git-svn-id: http://core.svn.wordpress.org/trunk@36598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:28:26 +00:00
f6b632983f
Updates: Pass locales of all available languages to the themes/plugins update API.
...
This ensures that language packs for all languages in a Multisite install are updated.
Fixes #34937 .
Built from https://develop.svn.wordpress.org/trunk@36630
git-svn-id: http://core.svn.wordpress.org/trunk@36597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:17:26 +00:00
724ccb492f
In `WP::handle_404()` introduce a filter `pre_handle_404` to short-circuit default header status handling.
...
This comes handy if you use WordPress without posts, means `$wp_query` contains no results.
Props prettyboymp, hakre, prettyboymp, Denis-de-Bernardy, ethitter, ocean90.
Fixes #10722 .
Built from https://develop.svn.wordpress.org/trunk@36629
git-svn-id: http://core.svn.wordpress.org/trunk@36596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 16:08:25 +00:00
d7b56a13d9
In `wp_upload_dir()` do not cache error from `wp_mkdir_p()` when a directory cannot be created. Keep trying to create the dirs. This happens mostly in file upload context.
...
See #34359 .
Built from https://develop.svn.wordpress.org/trunk@36628
git-svn-id: http://core.svn.wordpress.org/trunk@36595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 15:58:28 +00:00
3d68488ff6
TinyMCE: inline text patterns
...
First run.
See #33300 .
Built from https://develop.svn.wordpress.org/trunk@36627
git-svn-id: http://core.svn.wordpress.org/trunk@36594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 08:33:27 +00:00
b23b89c8a9
Docs: Correct `param` types on some filters in `wp_filter_comment()`.
...
Introduced in [26491].
Props meitar, netweb.
Fixes #35908 .
Built from https://develop.svn.wordpress.org/trunk@36626
git-svn-id: http://core.svn.wordpress.org/trunk@36593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 03:06:26 +00:00
072c791df0
Query: `is_*( $int )` should not falsely match strings starting with "$int".
...
Another chapter in the Storied Annals of Weird `in_array()` Behavior:
`in_array( 4, array( "4-cool-dudes" ) );` resolves to `true`, such that
`is_page( 4 )` was returning true for posts with the name `'4-cool-dudes'`.
We work around this behavior by ensuring that values passed to the `is_`
methods are cast to strings before the `in_array()` checks. ID checks still
work as expected; see #24674 .
Props mikejolley, swissspidy, boonebgorges.
Fixes #35902 .
Built from https://develop.svn.wordpress.org/trunk@36625
git-svn-id: http://core.svn.wordpress.org/trunk@36592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 02:21:25 +00:00
53e0315242
Customize: Let `WP_Customize_Selective_Refresh` class be `final` to match manager and other component classes.
...
This class is not intended to be extended.
See #27355 .
Built from https://develop.svn.wordpress.org/trunk@36624
git-svn-id: http://core.svn.wordpress.org/trunk@36591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 01:28:25 +00:00
49c7012a7e
Customize: Ensure `dynamic_sidebar()` finishes with removing the sidebar ID from the `current_dynamic_sidebar_id_stack`.
...
This ensures that widgets appearing after a nested sidebar will continue to be selective refreshable.
See #27355 .
Built from https://develop.svn.wordpress.org/trunk@36623
git-svn-id: http://core.svn.wordpress.org/trunk@36590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 01:22:26 +00:00
aa9ef96a52
Customize: Prevent dropping backslashes from input on general settings and settings for nav menus and some widgets.
...
Ensures that intentional backslashes (e.g. "\o/") can be used in:
* Site title
* Site description
* Nav menu name
* Custom Menu widget title
* Tag Cloud widget title
* Text widget body if can't `unfiltered_html`
The latter three are also fixed on the widgets admin page.
Fixes #35898 .
Built from https://develop.svn.wordpress.org/trunk@36622
git-svn-id: http://core.svn.wordpress.org/trunk@36589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 01:02:26 +00:00
e512f158df
Add translators comments to wp-admin/users.php.
...
Props ramiy.
Fixes #35885 .
Built from https://develop.svn.wordpress.org/trunk@36621
git-svn-id: http://core.svn.wordpress.org/trunk@36588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 00:05:28 +00:00
13f76b11d1
Template: Update label for the username field in `wp_login_form()` after [36617].
...
See #9568 .
Built from https://develop.svn.wordpress.org/trunk@36620
git-svn-id: http://core.svn.wordpress.org/trunk@36587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:38:27 +00:00
fcb3e5ec2f
Accessibility: Improve the color contrast ratio for the input placeholders.
...
Also, cleans up a bit the CSS removing rules for elements that don't use
placeholders any more.
Fixes #35777 .
Built from https://develop.svn.wordpress.org/trunk@36619
git-svn-id: http://core.svn.wordpress.org/trunk@36586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:29:26 +00:00
f96653c2b5
Accessibility: Remove title attributes from the Plugin details modal.
...
Also, improves accessibility of the star rating reviews links.
Fixes #35111 .
Built from https://develop.svn.wordpress.org/trunk@36618
git-svn-id: http://core.svn.wordpress.org/trunk@36585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:18:29 +00:00
7ebe2c1e7a
Authentication: Allow users to log in using their email address.
...
Introduces `wp_authenticate_email_password()` which is hooked into `authenticate` after `wp_authenticate_username_password()`.
Props Denis-de-Bernardy, ericlewis, vhomenko, MikeHansenMe, swissspidy, ocean90.
Fixes #9568 .
Built from https://develop.svn.wordpress.org/trunk@36617
git-svn-id: http://core.svn.wordpress.org/trunk@36584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:15:27 +00:00
83d147c29d
Media: Update unit tests after change to default image quality.
...
Updates unit tests to reflect new default quality setting of '82' after [36615].
See #33642 .
Built from https://develop.svn.wordpress.org/trunk@36616
git-svn-id: http://core.svn.wordpress.org/trunk@36583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:14:26 +00:00
55cc876141
Media: Reduce default image compression quality to '82'.
...
Changes default image compression quality from '90' to '82'.
This reduces generated image file sizes by ~25% while
keeping DSSIM < 0.0023, with both Imagick and GD.
Props @joemcgill, @dnewton.
See #33642 .
Built from https://develop.svn.wordpress.org/trunk@36615
git-svn-id: http://core.svn.wordpress.org/trunk@36582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 22:19:26 +00:00
3f7441d674
Allow `get_terms()` to fetch terms regardless of taxonomy.
...
`get_terms()` has historically required that a taxonomy be specified when
querying terms. This requirement is related to the fact that terms could
formerly be shared between taxonomies, making `$taxonomies` critical for
disambiguation. Since terms can no longer be shared as of 4.4, it'
s desirable to be able to query for terms regardless of what taxonomy they're in.
Because it's now optional to pass taxonomies, it's no longer necessary to have
`$taxonomies` as the first (and required) parameter for `get_terms()`. The new
function signature is `get_terms( $args )`, where 'taxonomy' can (optionally) be
passed as part of the `$args` array. This syntax is more consistent with
functions like `get_users()` and `get_posts()`.
We've maintained backward compatibility by always giving precedence to the old
argument format. If a second parameter is detected, or if it's detected that
the first parameter is a list of taxonomy names rather than an `$args` array,
`get_terms()` will parse the function arguments in the legacy fashion.
Props flixos90, swissspidy, DrewAPicture, boonebgorges.
Fixes #35495 .
Built from https://develop.svn.wordpress.org/trunk@36614
git-svn-id: http://core.svn.wordpress.org/trunk@36581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 22:17:26 +00:00
360a30d55e
Menus: Ensure backslashes are saved in menu item fields.
...
This was a regression introduced in [36510] which caused menu item fields to not save field content with backslashes in them.
Props westonruter.
See #14134 .
Built from https://develop.svn.wordpress.org/trunk@36613
git-svn-id: http://core.svn.wordpress.org/trunk@36580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 19:55:28 +00:00
eba32e3b6f
Accessibility: Remove the revisions limit warning from the Publish box.
...
After [36053] don't show a warning about something users can't change
because there's no control exposed in the UI for that. The Revisions
screen is probably a better place to show a more complete information.
Fixes #35029 .
Built from https://develop.svn.wordpress.org/trunk@36612
git-svn-id: http://core.svn.wordpress.org/trunk@36579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 16:23:26 +00:00
ae2657dd32
Customize: Prevent PHP notice and JS error caused by widgets and nav menus components if user only has `customize` capability.
...
Short-circuits components from initializing their hooks needlessly if current user lacks required capability.
Fixes #35895 .
Built from https://develop.svn.wordpress.org/trunk@36611
git-svn-id: http://core.svn.wordpress.org/trunk@36578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 05:31:27 +00:00
5228a99e97
Customize: Update unit test for `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()` to account for slashing if user can't `unfiltered_html`.
...
Fixes unit tests which broke under multisite config after [36608].
Fixes #35869 .
Built from https://develop.svn.wordpress.org/trunk@36610
git-svn-id: http://core.svn.wordpress.org/trunk@36577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 05:10:27 +00:00
68f3ee8f64
Docs: `WP_Meta_Query` accepts 'EXISTS' or 'NOT EXISTS' for `$compare`.
...
Props apaliku, jdgrimes.
Fixes #35891 .
Built from https://develop.svn.wordpress.org/trunk@36609
git-svn-id: http://core.svn.wordpress.org/trunk@36576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 03:56:27 +00:00
b206327acb
Customize: Fix previewing and updating of nav menu items containing slashed/slashable characters.
...
Prevents slashes from being added when a user without `unfiltered_html` previews a nav menu item containing an apostrophe or some other slashable character, and prevents the loss of an intentional slash (e.g. "\o/") when saving a nav menu item, regardless of capability.
Fixes #35869 .
Built from https://develop.svn.wordpress.org/trunk@36608
git-svn-id: http://core.svn.wordpress.org/trunk@36575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 00:14:25 +00:00
04da8bb63a
Posts: Non-trashed posts should take slug priority over trashed posts.
...
When determining a unique post slug, trashed posts are taken into account. Previously, new posts would add suffixes to their slugs (e.g. `about-2`) when a post in the trash had the desired slug (e.g. `about`).
To avoid this behavior, when a post is trashed its slug (i.e. `post_name`) is now suffixed with `-%trashed%`. The post's pre-trash slug is stored as post meta, and if the post is restored from trash, its desired slug is reapplied.
For existing trashed posts which don't have the `-%trashed%` suffix, the suffix is added when a post with its desired slug is created.
Props ocean90, boonebgorges, ryan, SergeyBiryukov, coffee2code, helen, williamsba1.
See #11863 .
Built from https://develop.svn.wordpress.org/trunk@36607
git-svn-id: http://core.svn.wordpress.org/trunk@36574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-21 21:45:28 +00:00
b3d6f127eb
Customize: Fix "Loading..." message from persisting in panel title when user does not have `manage_options` cap to edit `blogname`.
...
Reverts part of [36388].
Fixes #35579 .
Built from https://develop.svn.wordpress.org/trunk@36606
git-svn-id: http://core.svn.wordpress.org/trunk@36573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-21 06:15:28 +00:00
141b4dbd91
JSHint for [36602].
...
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36605
git-svn-id: http://core.svn.wordpress.org/trunk@36572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 22:14:27 +00:00
826e2d8ea1
Script Loader: Fix missing script output when the groups of dependencies are different.
...
Aka: Don't lose the grandchild.
Props gitlost, ocean90.
Fixes #35873 .
Built from https://develop.svn.wordpress.org/trunk@36604
git-svn-id: http://core.svn.wordpress.org/trunk@36571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 22:11:25 +00:00
a40a04ef42
i18n-tools: Respect the coding standards when adding textdomains with add-textdomain.php.
...
Props GaryJ, groovecoder.
Fixes #21616 .
Built from https://develop.svn.wordpress.org/trunk@36603
git-svn-id: http://core.svn.wordpress.org/trunk@36570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 21:44:25 +00:00
30feff9c99
TinyMCE, inline link dialog:
...
- Fix passing values to the (old) modal on open when non-linked text is selected and Advanced is clicked before pasting an URL.
- When the user has selected text partially including a link and opens the editing dialog, auto-select the link only. Helps when a linked word is selected by double-clicking.
- Remove all placeholders on saving.
- Do not add undo level on inserting link placeholder.
- Remove the placeholder when canceling from the modal.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36602
git-svn-id: http://core.svn.wordpress.org/trunk@36569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 21:36:25 +00:00
f636747fa4
Docs: Fix two incorrect notations of the `$show_admin_bar` global to specify a boolean type, not `WP_Admin_Bar`.
...
See [36491]. Fixes #35686 .
Built from https://develop.svn.wordpress.org/trunk@36601
git-svn-id: http://core.svn.wordpress.org/trunk@36568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 21:27:26 +00:00
0307aadf0f
i18n-tools: Add the ability to parse a whole directory with add-textdomain.php.
...
Props iamntz.
Fixes #35499 .
Built from https://develop.svn.wordpress.org/trunk@36600
git-svn-id: http://core.svn.wordpress.org/trunk@36567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 21:03:25 +00:00
c57946c3f2
i18n-tools: Remove PHP4 constructor from add-textdomain.php.
...
`_deprecated_constructor()` isn't available in non-WordPress context.
See #31982 .
Built from https://develop.svn.wordpress.org/trunk@36599
git-svn-id: http://core.svn.wordpress.org/trunk@36566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 20:34:25 +00:00
fce93c4771
In `get_terms()`, assemble `WHERE` conditions in an array instead of concatenating.
...
This method is more reliable when adding new `WHERE` conditions.
See #35495 .
Built from https://develop.svn.wordpress.org/trunk@36598
git-svn-id: http://core.svn.wordpress.org/trunk@36565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 20:04:26 +00:00
acb6cb1d74
TinyMCE: fix the regex that removes spaces from empty paragraphs. Was causing problems when wpautop is disabled and there are many U+00A0 chars between the opening `<p>` and an inline tag. These chars are inserted by the browsers to maintain consecutive spaces typed by the users in contentEditable.
...
Fixes #35890 .
Built from https://develop.svn.wordpress.org/trunk@36597
git-svn-id: http://core.svn.wordpress.org/trunk@36564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 19:56:27 +00:00
24cfa6a40a
Tests: Test that jQuery can be moved into footer after [36550].
...
Props gitlost.
See #25247 .
Built from https://develop.svn.wordpress.org/trunk@36596
git-svn-id: http://core.svn.wordpress.org/trunk@36563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 16:17:25 +00:00
21b9965613
Theme Compat: Replace the custom comment form with `comment_form()` and reduce number of links.
...
`comment_form()` has nearly the same markup as the custom form but also includes the latest enhancements like improved a11y and more filters.
Add translators comments, props ramiy.
Fixes #35888 .
Built from https://develop.svn.wordpress.org/trunk@36595
git-svn-id: http://core.svn.wordpress.org/trunk@36562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 14:41:27 +00:00
26955c8507
Tests: Add decorators to PHPMailer mock object.
...
The new `get_recipient()` and `get_sent()` methods greatly simplify the
syntax required when writing tests for `wp_mail()`.
Props welcher.
Fixes #34161 .
Built from https://develop.svn.wordpress.org/trunk@36594
git-svn-id: http://core.svn.wordpress.org/trunk@36561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 03:41:27 +00:00
9fdb970ceb
Docs: Add missing @since and @access tags to `get_curies` method and filter from r36533
...
See #34729 , #32246 .
Built from https://develop.svn.wordpress.org/trunk@36593
git-svn-id: http://core.svn.wordpress.org/trunk@36560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 23:42:27 +00:00
a04b869652
Styles: Pass the media attribute as an argument to the `style_loader_tag` filter.
...
Props sebastian.pisula.
Fixes #34765 .
Built from https://develop.svn.wordpress.org/trunk@36592
git-svn-id: http://core.svn.wordpress.org/trunk@36559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 21:05:26 +00:00
0285fd946d
Script Loader: Don't parse `$src` if the current color scheme isn't registered.
...
Avoids a `parse_url()` call on each request if the default colors scheme is in use.
Fixes #35882 .
Built from https://develop.svn.wordpress.org/trunk@36591
git-svn-id: http://core.svn.wordpress.org/trunk@36558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 20:44:26 +00:00
9d8204467c
Styles: Bail if `WP_Styles::_css_href()` returns an empty value.
...
The style `colors` gets registered with `true` as the source value which gets handled later by `wp_style_loader_src()`, a callback for the `style_loader_src` filter in `WP_Styles::_css_href()`. `wp_style_loader_src()` may return false, for example for the default color scheme.
This was removed in [36550].
See #35229 .
Built from https://develop.svn.wordpress.org/trunk@36590
git-svn-id: http://core.svn.wordpress.org/trunk@36557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 20:34:26 +00:00
edceb0173c
TinyMCE: update to 4.3.4. Changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt .
...
Fixes #35876 .
Built from https://develop.svn.wordpress.org/trunk@36589
git-svn-id: http://core.svn.wordpress.org/trunk@36556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 19:19:26 +00:00
06225cc394
Comments: Refresh the Moderate Comment screen for a friendlier experience with email moderation actions.
...
Brings some love to this neglected screen:
* format `comment_content`, instead of escaping in one massive block of text
* only wrap the comment date in a link if the comment permalink exists
* include link to the Edit Comment screen at the bottom of the comment_content
* update the message styles to match other screens
* append `#wpbody-content` to the comment email message links for accessibility
Props johnbillion, rachelbaker, afercia, melchoyce, karmatosed.
Fixes #34133
Built from https://develop.svn.wordpress.org/trunk@36588
git-svn-id: http://core.svn.wordpress.org/trunk@36555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 19:14:26 +00:00
30866ceb5d
Accessibility: Improve color contrast updating any `#999` gray used for text or icons to a darker gray.
...
Fixes #35660 .
Built from https://develop.svn.wordpress.org/trunk@36587
git-svn-id: http://core.svn.wordpress.org/trunk@36554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:44:27 +00:00
6b775d4afe
Customize: Add selective refresh framework with implementation for widgets and re-implementation for nav menus.
...
See https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/ .
Props westonruter, valendesigns, DrewAPicture, ocean90.
Fixes #27355 .
Built from https://develop.svn.wordpress.org/trunk@36586
git-svn-id: http://core.svn.wordpress.org/trunk@36553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:41:28 +00:00
0f88dbfee0
Accessibility: Fix displaying of Universal time and Local time info on the General Settings screen.
...
In [36263] they were mistakenly moved within a conditional check.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36585
git-svn-id: http://core.svn.wordpress.org/trunk@36552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 16:09:26 +00:00
08510d2e5d
Accessibility: after [36000] conditionally print out the `aria-describedby` attribute on the Featured Image postbox.
...
Fixes #35076 .
Built from https://develop.svn.wordpress.org/trunk@36584
git-svn-id: http://core.svn.wordpress.org/trunk@36551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 15:10:28 +00:00
34010353cc
Customize: Prevent consecutive `refresh` requests from preview from causing JS error.
...
Fixes "Uncaught TypeError: this.targetWindow is not a function".
See #27355 .
Fixes #35866 .
Built from https://develop.svn.wordpress.org/trunk@36583
git-svn-id: http://core.svn.wordpress.org/trunk@36550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 03:47:27 +00:00
77dbab1e1b
Accessibility: Reduce the WordPress shades of grey, Episode 2.
...
See #35783 .
Built from https://develop.svn.wordpress.org/trunk@36582
git-svn-id: http://core.svn.wordpress.org/trunk@36549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 22:30:27 +00:00
ecdcae565e
Plugins: Remove an unused variable after [35953].
...
Fixes #35050 .
Built from https://develop.svn.wordpress.org/trunk@36581
git-svn-id: http://core.svn.wordpress.org/trunk@36548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:33:25 +00:00
6f2a56bf3e
Themes: After [36546] restore theme search functionality.
...
* Correct several incorrect uses of `_.union`. Since Underscore 1.7.0 `_.union` supports only arrays and not variadic args.
* Use a namespaced event `themes:update`. Backbone 1.2 added a built in `update` event that triggers after any amount of models are added or removed from a collection.
Props adamsilverstein.
See #34350 .
Built from https://develop.svn.wordpress.org/trunk@36580
git-svn-id: http://core.svn.wordpress.org/trunk@36547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:21:26 +00:00
284f88e35a
Themes: Fix flickering of the theme screenshot on hover in WebKit browsers.
...
Props JoeFusco.
Fixes #35787 .
Built from https://develop.svn.wordpress.org/trunk@36579
git-svn-id: http://core.svn.wordpress.org/trunk@36546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:11:27 +00:00
529a53e903
Formatting: Avoid a PHP warning when `wptexturize()` is called with a trailing less-than symbol.
...
Props westonruter.
Fixes #35864 .
Built from https://develop.svn.wordpress.org/trunk@36578
git-svn-id: http://core.svn.wordpress.org/trunk@36545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 20:31:27 +00:00
cc1261f7fd
Docs: Add an explanation for the dynamic portion of the `{$taxonomy}_term_edit_form_top` hook, introduced in [36526].
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36577
git-svn-id: http://core.svn.wordpress.org/trunk@36544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 18:19:26 +00:00
e020ccd081
Docs: Add formatting to a changelog entry in the hook doc for the `rest_dispatch_request` filter.
...
See [36534]. See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36576
git-svn-id: http://core.svn.wordpress.org/trunk@36543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 18:18:25 +00:00
71b735974b
Media Library: After [36546] restore the "Add new" functionality.
...
Rework handling of the `'toggle:upload:attachment'` event using `.on` vs `.listenTo` for better compatibility with the current version of Backbone.
Props adamsilverstein.
See #34350 .
Fixes #35853 .
Built from https://develop.svn.wordpress.org/trunk@36575
git-svn-id: http://core.svn.wordpress.org/trunk@36542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 17:50:26 +00:00
d499011145
Add missing test changes for [36573].
...
See #34755 .
Built from https://develop.svn.wordpress.org/trunk@36574
git-svn-id: http://core.svn.wordpress.org/trunk@36541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 17:44:26 +00:00
658d825ea9
Customizer: In nav menus show the location name instead of slug.
...
Props ryankienstra.
Fixes #34755 .
Built from https://develop.svn.wordpress.org/trunk@36573
git-svn-id: http://core.svn.wordpress.org/trunk@36540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 17:16:27 +00:00
7ee69ca8d1
Remove extra spaces between function names and brackets
...
These were introduced when making list table view modes sticky.
See #16774 , #34365 .
Built from https://develop.svn.wordpress.org/trunk@36572
git-svn-id: http://core.svn.wordpress.org/trunk@36539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 16:51:27 +00:00
956627ff83
Don't display errors during Ajax requests.
...
See #34915 for REST and #23811 for XML-RPC.
Props pento.
Fixes #26262 .
Built from https://develop.svn.wordpress.org/trunk@36571
git-svn-id: http://core.svn.wordpress.org/trunk@36538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 16:43:27 +00:00
04ad9e674d
HTTP API: Certificate bundle: Attempt to move a certificate lower in the file to allow older OpenSSL versions to parse it & communicate with WordPress.org securely again.
...
The OpenSSL version which was failing in this case was `OpenSSL 0.9.8e 23 Feb 2007`.
See #35637 #30434 #25007
Built from https://develop.svn.wordpress.org/trunk@36570
git-svn-id: http://core.svn.wordpress.org/trunk@36537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 08:21:28 +00:00
2d94e025a2
Replace `wp_upload_dir()` with the new `wp_get_upload_dir()` in all cases where a file is not being uploaded. Deprecate `_wp_upload_dir_baseurl()`, and replace it with `wp_get_upload_dir()`.
...
See #34359 .
Built from https://develop.svn.wordpress.org/trunk@36569
git-svn-id: http://core.svn.wordpress.org/trunk@36536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 00:24:27 +00:00
c6ee6246ef
Docs: Remove a duplicate `@static` tag from the `WP_Customize_Panel->instance_count` property DocBlock.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36568
git-svn-id: http://core.svn.wordpress.org/trunk@36535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 00:14:26 +00:00
d9945e5bd4
Reintroduce term meta unit test accidentally removed in [36566].
...
Built from https://develop.svn.wordpress.org/trunk@36567
git-svn-id: http://core.svn.wordpress.org/trunk@36534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 23:02:25 +00:00
571e14f897
More performance improvements to metadata lazyloading.
...
Comment and term meta lazyloading for `WP_Query` loops, introduced in 4.4,
depended on filter callback methods belonging to `WP_Query` objects. This meant
storing `WP_Query` objects in the `$wp_filter` global (via `add_filter()`),
requiring that PHP retain the objects in memory, even when the local variables
would typically be expunged during normal garbage collection. In cases where a
large number of `WP_Query` objects were instantiated on a single pageload,
and/or where the contents of the `WP_Query` objects were quite large, serious
performance issues could result.
We skirt this problem by moving metadata lazyloading out of `WP_Query`. The
new `WP_Metadata_Lazyloader` class acts as a lazyload queue. Query instances
register items whose metadata should be lazyloaded - such as post terms, or
comments - and a `WP_Metadata_Lazyloader` method will intercept comment and
term meta requests to perform the cache priming. Since `WP_Metadata_Lazyloader`
instances are far smaller than `WP_Query` (containing only object IDs), and
clean up after themselves far better than the previous `WP_Query` methods (bp
only running their callbacks a single time for a given set of queued objects),
the resource use is decreased dramatically.
See [36525] for an earlier step in this direction.
Props lpawlik, stevegrunwell, boonebgorges.
Fixes #35816 .
Built from https://develop.svn.wordpress.org/trunk@36566
git-svn-id: http://core.svn.wordpress.org/trunk@36533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:58:26 +00:00
da5b3a55c4
Improve the performance of `wp_upload_dir()`:
...
- Cache the output in non-persistent cache.
- Cache the result from `wp_mkdir_p()` in persistent cache (when present).
- Introduce `wp_get_upload_dir()` for use when not uploading files. It is equivalent to `wp_upload_dir()` but does not check for the existence or create the upload directory.
- Change tests to use the non-cached `_wp_upload_dir()`. They change options on the fly (should never be used in production) to simulate different environments.
- Introduce `_upload_dir_no_subdir()` and `_upload_dir_https()` to facilitate testing. These use the proper `upload_dir` filter to simulate different environments.
Props kovshenin, azaozz.
See #34359 .
Built from https://develop.svn.wordpress.org/trunk@36565
git-svn-id: http://core.svn.wordpress.org/trunk@36532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:51:26 +00:00
84350eb6b6
Add changelog entry for `publicly_queryable` argument in `register_taxonomy()`.
...
Missed in [36525].
Fixes #34491 .
Built from https://develop.svn.wordpress.org/trunk@36564
git-svn-id: http://core.svn.wordpress.org/trunk@36531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:04:32 +00:00
ca6726f331
Tests: Add test for `wp_get_installed_translations()`.
...
Introduces language files in /tests/phpunit/data/language. Each file includes the header and 5 translations.
Props realloc for initial patch.
Fixes #35284 .
Built from https://develop.svn.wordpress.org/trunk@36563
git-svn-id: http://core.svn.wordpress.org/trunk@36530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:02:26 +00:00
3e14571132
Multisite: Make view mode sticky for network users and sites list tables.
...
Fixes #34365 .
Built from https://develop.svn.wordpress.org/trunk@36562
git-svn-id: http://core.svn.wordpress.org/trunk@36529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:00:27 +00:00
e7a7f08c8b
Multisite: Avoid a PHP Notice when saving a site address without a path.
...
Props kjbenk.
Fixes #35631 .
Built from https://develop.svn.wordpress.org/trunk@36561
git-svn-id: http://core.svn.wordpress.org/trunk@36528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 20:50:27 +00:00
bffdae7b1d
Plugins: Remove slashes from search terms and use `urldecode()` in non-URL contexts.
...
Fixes #35712 .
Built from https://develop.svn.wordpress.org/trunk@36560
git-svn-id: http://core.svn.wordpress.org/trunk@36527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 20:15:26 +00:00
10234c1907
Tests: Add a test for testing `wp_enqueue_script()` with an alias handle in the footer.
...
Props kovshenin.
See #35643 .
Built from https://develop.svn.wordpress.org/trunk@36559
git-svn-id: http://core.svn.wordpress.org/trunk@36526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:53:26 +00:00
8b781dfaa7
Updates: Prevent further actions if an update button is disabled.
...
Props adamsilverstein, afercia.
Fixes #35257 .
Built from https://develop.svn.wordpress.org/trunk@36558
git-svn-id: http://core.svn.wordpress.org/trunk@36525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:42:26 +00:00
d1d90a3263
Make `$wp_local_package` explicitly global in wp-settings.php.
...
Props danielbachhuber.
Fixes #34975 .
Built from https://develop.svn.wordpress.org/trunk@36557
git-svn-id: http://core.svn.wordpress.org/trunk@36524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:32:25 +00:00
309ea2f138
Multisite: Add a hook to the end of the network's Add New User form.
...
The `network_user_new_form` action can be used to extend the new user form.
Props ptahdunbar.
Fixes #15389 .
Built from https://develop.svn.wordpress.org/trunk@36556
git-svn-id: http://core.svn.wordpress.org/trunk@36523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:15:26 +00:00
39cd3583a4
Multisite: Add a hook to the end of the Add Site form.
...
The `network_site_new_form` action can be used to extend the new site form.
Props igmoweb, ocean90.
Fixes #34739 .
Built from https://develop.svn.wordpress.org/trunk@36555
git-svn-id: http://core.svn.wordpress.org/trunk@36522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:03:25 +00:00
7e5a563876
Credits: Remove unused strings.
...
Props Ankit K Gupta.
Fixes #34909 .
Built from https://develop.svn.wordpress.org/trunk@36554
git-svn-id: http://core.svn.wordpress.org/trunk@36521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:00:28 +00:00
de0e09983d
Install: Enhance the language of the "Success" message.
...
Props ckoerner.
Fixes #34897 .
Built from https://develop.svn.wordpress.org/trunk@36553
git-svn-id: http://core.svn.wordpress.org/trunk@36520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 18:58:26 +00:00
442a637e1e
Tests: Add `Tests_dbDelta::assertTableHasPrimaryKey()`.
...
Also fix a typo in the name for the compound key.
Props charlestonsw.
Fixes #34877 .
Built from https://develop.svn.wordpress.org/trunk@36552
git-svn-id: http://core.svn.wordpress.org/trunk@36519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 18:55:27 +00:00
27b3dddb2e
Styles:
...
- Restore loading order for wp-admin: open-sans, dashicons, etc.
- Remove couple of redundant dependencies.
See #35229 .
Built from https://develop.svn.wordpress.org/trunk@36551
git-svn-id: http://core.svn.wordpress.org/trunk@36518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 18:01:26 +00:00
bc5d22266d
Script/Style Dependencies: Make sure that inline styles for handles without a source are printed.
...
This prevents breaking plugins which are adding inline styles to the `wp-admin` handle after [36341].
Props dd32, ocean90.
Fixes #35229 .
Built from https://develop.svn.wordpress.org/trunk@36550
git-svn-id: http://core.svn.wordpress.org/trunk@36517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 17:11:26 +00:00
0d89816985
Tests: Indent `test_wp_register_script()` with tabs.
...
Built from https://develop.svn.wordpress.org/trunk@36549
git-svn-id: http://core.svn.wordpress.org/trunk@36516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 16:07:26 +00:00
c673740166
Autoprefixer for [36532].
...
See #31195 .
Built from https://develop.svn.wordpress.org/trunk@36548
git-svn-id: http://core.svn.wordpress.org/trunk@36515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 15:39:26 +00:00
a9afddcd20
Tests: Indent `test_wp_register_style()` with tabs.
...
Built from https://develop.svn.wordpress.org/trunk@36547
git-svn-id: http://core.svn.wordpress.org/trunk@36514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 15:37:26 +00:00
4693b25171
Update Backbone and Underscore to the latest versions.
...
Backbone, from 1.1.2 to 1.2.3. Underscore, from 1.6.0 to 1.8.3.
The new versions of Backbone and Underscore offer numerous small bug fixes and some optimizations and other improvements. Check the [http://backbonejs.org/#changelog Backbone changelog] and [http://underscorejs.org/#changelog Underscore changelog] for the full details.
The new versions include some significant changes that may break existing code. Plugins or themes that rely on the bundled Backbone and/or Underscore libraries should carefully check functionality with the latest versions and run any available unit tests to ensure compatibility.
Some changes of note that were addressed in core as part of this upgrade:
* `_.flatten` no longer works with objects since Underscore.js 1.7. `_.flatten()` working with objects was an unintended side-affect of the implementation, see [https://github.com/jashkenas/underscore/issues/1904#issuecomment-60241576 underscore#1904]. Check any `_flatten` usage and only flatten arrays.
* As of Backbone 1.2.0, you can no longer modify the `events` hash or your view's `el` property in `initialize`, so don't try to modify them there.
* Since Underscore 1.7, Underscore templates no longer accept an initial data object. `_.template` always returns a function now so make sure you use it that way.
Props adamsilverstein.
Fixes #34350 .
Built from https://develop.svn.wordpress.org/trunk@36546
git-svn-id: http://core.svn.wordpress.org/trunk@36513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 15:22:26 +00:00
53245b1294
Setup: Improve wording on the page for the database connection details.
...
See #26879 .
Built from https://develop.svn.wordpress.org/trunk@36545
git-svn-id: http://core.svn.wordpress.org/trunk@36512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 15:03:26 +00:00
7482a4d4ac
Setup: Use "Username" instead of "User Name".
...
Props thisisit.
Fixes #35850 .
Built from https://develop.svn.wordpress.org/trunk@36544
git-svn-id: http://core.svn.wordpress.org/trunk@36511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 15:00:28 +00:00
2413e41f8c
Do not strip slashes from the whole &_POST when doing autosaves.
...
Props joehoyle.
Fixes #35408 .
Built from https://develop.svn.wordpress.org/trunk@36543
git-svn-id: http://core.svn.wordpress.org/trunk@36510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 00:10:27 +00:00
0ff58701e0
Comments: look for wp_error when checking whether `$wpdb->get_col_length()` has failed.
...
See #10377 .
Built from https://develop.svn.wordpress.org/trunk@36542
git-svn-id: http://core.svn.wordpress.org/trunk@36509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 23:50:27 +00:00
9e73dea03a
Introduce a `$parent_class` parameter for `_deprecated_constructor()`.
...
Use the parameter for the deprecated constructor warning in `WP_Widget` to provide an indication to which widget is using the PHP4 style constructor.
Props sebastian.pisula.
Fixes #33440 .
Built from https://develop.svn.wordpress.org/trunk@36541
git-svn-id: http://core.svn.wordpress.org/trunk@36508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 23:20:26 +00:00
8a52014638
In `wp_title()` fix a 7 year old typo.
...
Props joelerr.
Fixes #34879 .
Built from https://develop.svn.wordpress.org/trunk@36540
git-svn-id: http://core.svn.wordpress.org/trunk@36507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 22:28:26 +00:00
3f3fe5a7ed
Themes: Use the attachment ID as the key in `get_uploaded_header_images()`.
...
Prevents missing header images when an image has the same name as another header image.
Props sirbrillig.
Fixes #31786 .
Built from https://develop.svn.wordpress.org/trunk@36539
git-svn-id: http://core.svn.wordpress.org/trunk@36506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 22:12:27 +00:00
51473acfb3
i18n: Prevent `is_textdomain_loaded()` from returning true even if there are no translations for the domain.
...
In `get_translations_for_domain()` don't fill the global `$l10n` with `NOOP_Translations` instances, return a `NOOP_Translations` instance instead.
Props nacin, jrf.
Fixes #21319 .
Built from https://develop.svn.wordpress.org/trunk@36538
git-svn-id: http://core.svn.wordpress.org/trunk@36505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 21:15:29 +00:00
008cba0333
Accessibility: Reduce the WordPress shades of grey, first part.
...
See #35783 .
Built from https://develop.svn.wordpress.org/trunk@36537
git-svn-id: http://core.svn.wordpress.org/trunk@36504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 16:09:29 +00:00
3e65236aa7
REST API: Apply rest_post_dispatch to embedded responses.
...
Fixes #35628 .
Props @danielbachhuber.
Built from https://develop.svn.wordpress.org/trunk@36536
git-svn-id: http://core.svn.wordpress.org/trunk@36503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 06:06:27 +00:00
03ba67a0b7
REST API: Allow explicit HEAD callbacks.
...
HEAD callbacks can now be registered independently, with the GET
callback still used as a fallback.
Fixes #34841 .
Built from https://develop.svn.wordpress.org/trunk@36535
git-svn-id: http://core.svn.wordpress.org/trunk@36502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 05:51:26 +00:00
0438795671
REST API: Add routing args to rest_dispatch_request filter.
...
This allows requests to be hijacked via the filter more easily.
Fixes #35507 .
Built from https://develop.svn.wordpress.org/trunk@36534
git-svn-id: http://core.svn.wordpress.org/trunk@36501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 04:40:26 +00:00
47bee5157b
REST API: Add support for CURIEs.
...
CURIEs are Compact URIs, which provide a more usable way to use
custom relations in the API. The `wp` CURIE is registered by default
for `https://api.w.org/ ` URI relations.
Fixes #34729 .
Props joehoyle.
Built from https://develop.svn.wordpress.org/trunk@36533
git-svn-id: http://core.svn.wordpress.org/trunk@36500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 02:19:27 +00:00
b5e18056e5
Customize: Add a user-friendly way to preview site responsiveness for desktop, tablet, and mobile.
...
Introduces `WP_Customize_Manager::get_previewable_devices()` with a `customize_previewable_devices` filter to change the default device and which devices are available for previewing. This is a feature that was first pioneered on WordPress.com.
Props celloexpressions, folletto, valendesigns, westonruter, welcher, adamsilverstein, michaelarestad, Fab1en.
Fixes #31195 .
Built from https://develop.svn.wordpress.org/trunk@36532
git-svn-id: http://core.svn.wordpress.org/trunk@36499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 01:57:26 +00:00
a6b6adb45d
REST API: Fix tests from r36529.
...
See #35329 .
Built from https://develop.svn.wordpress.org/trunk@36531
git-svn-id: http://core.svn.wordpress.org/trunk@36498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 01:51:25 +00:00
85e82cf571
REST API: Don’t display errors during REST API requests.
...
Uses `wp_debug_mode()` to prevent response from being broken by debug errors. Matches similar behavior of the XML-RPC API.
Props rockwell15.
Fixes #34915 .
Built from https://develop.svn.wordpress.org/trunk@36530
git-svn-id: http://core.svn.wordpress.org/trunk@36497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 01:36:25 +00:00
796f0c844c
REST API: Add helper function to get server instance.
...
This allows using rest_do_request() outside of the API itself easily.
Props danielbachhuber, swissspidy.
Built from https://develop.svn.wordpress.org/trunk@36529
git-svn-id: http://core.svn.wordpress.org/trunk@36496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-16 01:12:26 +00:00
4ac63be963
Accessibility: improve the color contrast ratio for the TinyMCE button icons.
...
Also, tries to use the new grays from the Design Handbook wherever applicable.
Props michaelarestad, afercia.
Fixes #35604 .
Built from https://develop.svn.wordpress.org/trunk@36528
git-svn-id: http://core.svn.wordpress.org/trunk@36495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-15 21:11:28 +00:00
e41a0998e6
Docs: Add an internal note to the DocBlock for `comment_form_title()` explaining restoration of the `$comment` global.
...
See [36512]. See #35624 .
Built from https://develop.svn.wordpress.org/trunk@36527
git-svn-id: http://core.svn.wordpress.org/trunk@36494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-13 19:15:28 +00:00
9a178f2510
Introduce `{$taxonomy}_term_edit_form_top` action to edit-tag-form.php.
...
This new action gives developers a place to output content at the beginning
of the form element on edit-tags.php.
Props flixos90.
Fixes #35252 .
Built from https://develop.svn.wordpress.org/trunk@36526
git-svn-id: http://core.svn.wordpress.org/trunk@36493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-13 04:01:26 +00:00
48b8ea78da
Introduce `publicly_queryable` taxonomy argument.
...
Taxonomies registered as `publicly_queryable` can be queried as taxonomy
archives.
If not provided explicitly, the value of `publicly_queryable` is inherited
from `public`.
Props Chouby.
Fixes #34491 .
Built from https://develop.svn.wordpress.org/trunk@36525
git-svn-id: http://core.svn.wordpress.org/trunk@36492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-13 03:51:26 +00:00
60cf073672
Improve `WP_Query` lazyloading logic, for better performance.
...
Lazyloading for comment meta and term meta, introduced into `WP_Query` in
4.4, used flags - `updated_term_meta_cache` and `updated_comment_meta_cache` -
in an attempt to prevent cache priming from happening more than once per query
object. This technique was mostly effective, but not entirely efficient, since
the flag didn't prevent the `lazyload_*_meta` callbacks from running. The
obvious solution - removing the filter callback after it'd be run once - was
dismissed for 4.4 because of concerns that `remove_filter()` could disable
lazyloading too generally in the context of nested queries, due to the way
`_wp_filter_build_unique_id()` doesn't always build sufficiently unique IDs for
similar objects. However, further testing shows that this concern is only valid
in a very small subset of cases, while the cost of keeping the query objects in
memory, via the `$wp_filter` global, is quite significant. As such, this
changeset removes the flags in favor of the `remove_filter()` technique.
See #35454 , #35816 .
Built from https://develop.svn.wordpress.org/trunk@36524
git-svn-id: http://core.svn.wordpress.org/trunk@36491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-13 03:05:27 +00:00
9343641855
Customize: Ensure that nav menu items can be shift-clicked to edit in secondary instances of the same nav menu.
...
When the same nav menu is shown multiple times on a page, only the first instance of the nav menu will include `id` attributes. Subsequent instances will have the `id` attributes omitted. However, in both cases the underlying nav menu item's post ID is available among the `class` names, so the post ID can be more reliably obtained from `class` instead of the `id` attribute.
Amends [36383].
Fixes #32681 .
Built from https://develop.svn.wordpress.org/trunk@36523
git-svn-id: http://core.svn.wordpress.org/trunk@36490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-13 00:12:25 +00:00
453ff22d7f
Customize: Hide widgets re-order button when no re-ordering is possible.
...
Hide the re-order button if there are no widgets in the sidebar, or if there is there is only one sidebar and there is only one widget in the sidebar.
Props rabmalin, westonruter.
Fixes #35533 .
Built from https://develop.svn.wordpress.org/trunk@36522
git-svn-id: http://core.svn.wordpress.org/trunk@36489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 23:52:27 +00:00
f99ec3db18
Comments: In the comments list table, only link rows inside the “Submitted On” column to the comment if it is publicly viewable.
...
The date within the comments list table “Submitted On” column will only be wrapped in `get_comment_link()` if the comment is approved and associated with a valid `comment_post_ID`.
Fixes #35279 .
Built from https://develop.svn.wordpress.org/trunk@36521
git-svn-id: http://core.svn.wordpress.org/trunk@36488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 21:43:26 +00:00
f846e08f2c
Make sure fixtures have empty `post_content` in search test.
...
The generator sequence was causing false positives when the search terms
('1' and '0') happened to match the current sequence number (eg,
'Post content 190').
Introduced in [36278].
See #31025 .
Built from https://develop.svn.wordpress.org/trunk@36520
git-svn-id: http://core.svn.wordpress.org/trunk@36487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 21:07:25 +00:00
c521ca706f
Improve Automated Feed Tests
...
Multiple improvements to the RSS2 automated tests along with the addition of Atom tests.
1. General whitespace cleanup (since the rss2 file serves as the base of the atom file).
2. Adds an author and category to the tests.
3. Since the content of the posts is the same, we don't need to test all of the post content.
4. Adds many posts so that the post count can be checked
Props stevenkword
Fixes #35160 .
Built from https://develop.svn.wordpress.org/trunk@36519
git-svn-id: http://core.svn.wordpress.org/trunk@36486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 19:03:26 +00:00
eee7f18225
Customizer: reduce the spinner re-painted area to the smallest possible one.
...
Also, changes the "customize container" and the theme installer preview
background from white to the default body `#f1f1f1` background.
Fixes #35649 .
Built from https://develop.svn.wordpress.org/trunk@36518
git-svn-id: http://core.svn.wordpress.org/trunk@36485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 18:35:25 +00:00
cf0288e291
Media: Fix inline docs typo inside `wp_calculate_image_srcset()` function.
...
mathces -> matches.
Props neoxx.
Fixes #35714 .
Built from https://develop.svn.wordpress.org/trunk@36517
git-svn-id: http://core.svn.wordpress.org/trunk@36484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 18:15:30 +00:00
0e27fdcc47
Bail from `get_term()` if a filter returns an object that is not a `WP_Term`.
...
This prevents fatal errors in certain cases.
Props tmuikku.
Fixes #35808 .
Built from https://develop.svn.wordpress.org/trunk@36516
git-svn-id: http://core.svn.wordpress.org/trunk@36483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 14:26:27 +00:00
58fe478fe1
Comments: Unit test for `wp_get_comment_fields_max_lengths().
...
This adds tests for the comment form field lengths returned by `wp_get_comment_fields_max_lengths()`. Replaces unit test removed in r36514.
See #10377 .
Built from https://develop.svn.wordpress.org/trunk@36515
git-svn-id: http://core.svn.wordpress.org/trunk@36482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 14:18:26 +00:00
8abd201a0b
Comments: Change `wp_get_comment_column_max_length()` function to `wp_get_comment_fields_max_lengths()` for consolidation and better fallbacks.
...
Instead of returning a value for each of the related table column lengths, return an array of all of the column lengths used in the comment form.
Better fallback handling, where each field falls back to the expected max_length instead of an arbitrary number.
Props azaozz.
Fixes #10377 .
Built from https://develop.svn.wordpress.org/trunk@36514
git-svn-id: http://core.svn.wordpress.org/trunk@36481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 13:55:28 +00:00
a2dddbf8f5
TinyMCE: fix removing a space before inline tags when applying formatting shortcuts.
...
Fixes #35798 .
Built from https://develop.svn.wordpress.org/trunk@36513
git-svn-id: http://core.svn.wordpress.org/trunk@36480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 04:23:26 +00:00
1877b8c726
Set the `$comment` global in `comment_form_title()`.
...
In [33963], `comment_form_title()` was refactored so that it no longer made
reference to the `$comment` global. This broke some functionality within the
comment form, as certain template would no longer be able to access the
"current" comment.
Props d4z_c0nf, WisdmLabs, boonebgorges.
Fixes #35624 .
Built from https://develop.svn.wordpress.org/trunk@36512
git-svn-id: http://core.svn.wordpress.org/trunk@36479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 04:10:25 +00:00
3e9c88d75a
In `delete_metadata()`, only invalidate cache for affected objects.
...
The `$delete_all` flag in `delete_metadata()` triggers cache invalidation for
multiple objects. Previously, invalidation took place for all objects matching
the `$meta_key` parameter, regardless of whether `$meta_value` was also set.
This resulted in overly aggressive invalidation.
Props rahal.aboulfeth.
Fixes #35797 .
Built from https://develop.svn.wordpress.org/trunk@36511
git-svn-id: http://core.svn.wordpress.org/trunk@36478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-12 02:47:26 +00:00
2bfc0f5218
Menus: Allow larger menus to be created in the Edit Menu screen.
...
In the Edit Menu screen, each menu item creates 11 form input elements. In menus with more than 71 menu items, often items after the 71st weren't saved. This was because PHP's runtime configuration `max_input_vars` default value is 1000. Large menus exceed this, so PHP didn't populate the `$_POST` superglobal for the latter menu items.
The entire form is now JSON-encoded into a single input which populates `$_POST` manually on form submission.
This was attempted previously in [36506] which was reverted in [36507]. Some form fields were not being slurped into the form's JSON representation, and it did not scale for a site with many posts. This approach fixes those problems.
Props ocean90, afercia.
See #14134 .
Built from https://develop.svn.wordpress.org/trunk@36510
git-svn-id: http://core.svn.wordpress.org/trunk@36477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-11 19:08:27 +00:00
1370d8b869
Don't double-unslash meta key when `update_metadata()` falls back on `add_metadata()`.
...
Props jdgrimes.
Fixes #35795 .
Built from https://develop.svn.wordpress.org/trunk@36509
git-svn-id: http://core.svn.wordpress.org/trunk@36476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-11 17:35:28 +00:00
dae31f7d95
Remove unused variable from `get_terms()`.
...
Unused since [31284].
Props TimothyBlynJacobs.
Fixes #35784 .
Built from https://develop.svn.wordpress.org/trunk@36508
git-svn-id: http://core.svn.wordpress.org/trunk@36475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-11 04:33:29 +00:00
a64dbc805b
Menus: Revert larger menu support in Edit Menus screen in [36506].
...
JSON encoding the form as it exists on the page will not scale.
See #14134 .
Built from https://develop.svn.wordpress.org/trunk@36507
git-svn-id: http://core.svn.wordpress.org/trunk@36474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-10 14:11:26 +00:00
48fdbf96de
Menus: Allow larger menus to be created in the Edit Menu screen.
...
In the Edit Menu screen, each menu item creates 11 form input elements. In menus with more than 71 menu items, often items after the 71st weren't saved. This was because PHP's runtime configuration `max_input_vars` default value is 1000. Large menus exceed this, so PHP didn't populate the `$_POST` superglobal for the latter menu items.
The entire form is now JSON-encoded into a single input which populates `$_POST` manually on form submission.
See #14134 .
Built from https://develop.svn.wordpress.org/trunk@36506
git-svn-id: http://core.svn.wordpress.org/trunk@36473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-10 03:32:25 +00:00
cbe5fc6fb8
Multisite: Don't show the database upgrade admin notice on the upgrade page itself.
...
Fixes #35782 .
Built from https://develop.svn.wordpress.org/trunk@36505
git-svn-id: http://core.svn.wordpress.org/trunk@36472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-09 14:30:28 +00:00
d9a5894c2e
Users: Display the new user email notice in user admin too.
...
Also, in `new_user_email_admin_notice()` use the global `$pagenow` and add a translators comment for the placeholder.
Fixes #35767 .
Built from https://develop.svn.wordpress.org/trunk@36504
git-svn-id: http://core.svn.wordpress.org/trunk@36471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 13:54:25 +00:00
0eb4f6ccfc
Users: Use `self_admin_url()` for the email change confirmation link.
...
Prevents sending users to wp-admin/profile.php if they only have access to wp-admin/user/profile.php.
Fixes #35766 .
Built from https://develop.svn.wordpress.org/trunk@36503
git-svn-id: http://core.svn.wordpress.org/trunk@36470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 13:26:27 +00:00
deeb5f1471
Themes: Pass information about the old theme in the form of a `WP_Theme` object when the `switch_theme` action is fired.
...
Props MikeHansenMe.
See #22401 .
Built from https://develop.svn.wordpress.org/trunk@36502
git-svn-id: http://core.svn.wordpress.org/trunk@36469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:26:25 +00:00
12bdf5a6da
Docs: Improove the DocBlock summary for `wp_signon()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36501
git-svn-id: http://core.svn.wordpress.org/trunk@36468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:11:25 +00:00
48988c505f
Docs: Make a couple of minor improvements to the DocBlock for `wp_get_raw_referer()`, introduced in [36266].
...
* Uses a third-person singular verb in the summary
* Makes the return types more specific with `string|false` vs `string|bool`.
See #27152 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36500
git-svn-id: http://core.svn.wordpress.org/trunk@36467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:09:25 +00:00
b45a6228d0
Docs: Add a changelog entry for the introduction of maxlength character limits for the 'author', 'email', and 'url' fields in `comment_form()`.
...
Introduced in [36272].
See #10377 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36499
git-svn-id: http://core.svn.wordpress.org/trunk@36466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:05:27 +00:00
c55f447ad4
Docs: Revert unintended changes in wp-includes/post.php, mistakenly included in [36497].
...
See #34988 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@36498
git-svn-id: http://core.svn.wordpress.org/trunk@36465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:46:25 +00:00
3785385ea2
Docs: Add a missing version to the file header for wp-admin/term.php, introduced in [36308].
...
See #34988 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@36497
git-svn-id: http://core.svn.wordpress.org/trunk@36464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:43:26 +00:00
f3aeb0def3
Docs: Update several function DocBlock summaries in wp-includes/nav-menu.php to use third-person singular verbs.
...
Also removes some unnecessary capitalizations.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36496
git-svn-id: http://core.svn.wordpress.org/trunk@36463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:18:26 +00:00
e2cec35437
Docs: Make some minor improvements to inline docs for `WP_Site`, introduced in [36393].
...
* Uses third-person singular verbs in method summaries
* Adds an `@static` tag to the `WP_Site::get_instance()` DocBlock
* Adjusts return types for `WP_Site::get_instance()` to the more explicit `WP_Site|false`
See #32450 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36495
git-svn-id: http://core.svn.wordpress.org/trunk@36462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:13:26 +00:00
3e7db642a6
Docs: Slightly simplify the DocBlock summaries for `home_url()`, `get_home_url()`, `site_url()`, and `get_site_url()`.
...
See #35238 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36494
git-svn-id: http://core.svn.wordpress.org/trunk@36461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:06:26 +00:00
b0ef4d14c5
Docs: Add an `@access` tag and fix a typo in the DocBlock for `wpdb::close()`.
...
See #34903 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36493
git-svn-id: http://core.svn.wordpress.org/trunk@36460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:03:26 +00:00
9daf7a88a3
Docs: Add a note to the DocBlock for `current_user_can()` to explain that it will always return true for super admins, unless specifically denied.
...
Props finnj.
Fixes #35551 .
Built from https://develop.svn.wordpress.org/trunk@36492
git-svn-id: http://core.svn.wordpress.org/trunk@36459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 01:27:26 +00:00
a06a5ecfe9
Docs: Fix two notations in the DocBlocks for `show_admin_bar()` and `is_admin_bar_showing()` to reflect use of the `$show_admin_bar` global rather than `$wp_admin_bar`.
...
Props Frozzare.
Fixes #35686 .
Built from https://develop.svn.wordpress.org/trunk@36491
git-svn-id: http://core.svn.wordpress.org/trunk@36458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 01:22:26 +00:00
b1127321ec
Docs: Fix one line of the DocBlock for the `JsonSerializable` compat interface to use a tab instead of spaces.
...
Props Frozzare.
Fixes #35699 .
Built from https://develop.svn.wordpress.org/trunk@36490
git-svn-id: http://core.svn.wordpress.org/trunk@36457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 01:18:27 +00:00
6a94d3e2e3
Docs: Use the correct parameter name in the DocBlock for `wp_kses_post_deep()`, introduced in [36429].
...
Props sebastianpisula.
Fixes #35700 . See #35316 .
Built from https://develop.svn.wordpress.org/trunk@36489
git-svn-id: http://core.svn.wordpress.org/trunk@36456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 00:18:26 +00:00
c1b837b47f
Docs: Add a missing type to the return description for `map_deep()`.
...
Props sebastianpisula.
See #35700 .
Built from https://develop.svn.wordpress.org/trunk@36488
git-svn-id: http://core.svn.wordpress.org/trunk@36455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 00:15:27 +00:00
6e60f8b6f8
Login: In `login_header()`, use correct separator for RTL locales.
...
Props ramiy.
Fixes #35737 .
Built from https://develop.svn.wordpress.org/trunk@36487
git-svn-id: http://core.svn.wordpress.org/trunk@36454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 22:56:27 +00:00
146320744f
Allow comments to be queried by 'any' `post_type` or `post_status`.
...
Props kouratoras.
Fixes #35512 .
Built from https://develop.svn.wordpress.org/trunk@36486
git-svn-id: http://core.svn.wordpress.org/trunk@36453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 04:51:25 +00:00
fe1dd15126
Allow `get_terms()` results to ordered by metadata.
...
The `$orderby` parameter of `get_terms()` now accepts the following values,
related to term meta:
* 'meta_value'
* 'meta_value_num'
* the value of the `$meta_key` parameter
* any key from the `$meta_query` array
This brings order-by-meta support for terms in line with post, comment, and
user queries.
As a byproduct of these improvements, `$meta_key` and `$meta_value` parameters
have been introduced to `get_terms()`. They interact with `$meta_query` in the
same way as in `WP_Query` and other query classes.
Props jadpm, eherman24.
Fixes #34996 .
Built from https://develop.svn.wordpress.org/trunk@36485
git-svn-id: http://core.svn.wordpress.org/trunk@36452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 04:42:26 +00:00
f1c0ed714a
`WP_Query` taxonomy query vars should be set to first of multiple taxonomies.
...
This provides better parity with `get_queried_object()`, which will return the
first taxonomy/term matched by the current query.
[29891] introduced the abnormal behavior for the 'taxonomy' and 'term'
query vars.
Props Chouby.
Fixes #35619 .
Built from https://develop.svn.wordpress.org/trunk@36484
git-svn-id: http://core.svn.wordpress.org/trunk@36451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 03:58:27 +00:00
3a2ef071d4
TinyMCE inline link:
...
- Fix not displaying anything when the URL is only a fragment. Show the whole URL.
- Fix editing a link when it is the very first word in the editor.
- Fix editing a link then some of the surrounding text or space is selected. Change the selection to only the link node.
- Add placeholder when adding new link.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36483
git-svn-id: http://core.svn.wordpress.org/trunk@36450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 00:51:27 +00:00
20c07afbd5
When updating a user, invalidate its 'userslugs' cache.
...
`user_nicename` can be changed via `wp_update_user()`, so we invalidate just
to be safe.
Props thebrandonallen.
Fixes #35750 .
Built from https://develop.svn.wordpress.org/trunk@36482
git-svn-id: http://core.svn.wordpress.org/trunk@36449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 19:03:26 +00:00
8db393ada6
Make the `$post` param optional in `get_post_field()`.
...
When `$post` is `null`, the current post object will be returned.
Props sebastian.pisula.
Fixes #35683 .
Built from https://develop.svn.wordpress.org/trunk@36481
git-svn-id: http://core.svn.wordpress.org/trunk@36448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:58:25 +00:00
b5d12e130c
Comments: Restore the ability to bypass post_id filter using 0 or '0'.
...
The changes introduced in [36381], while logical and clearly awesome, introduce
the potential for much breakage. Those who want to query for comments with a
null `comment_post_ID` should use `'post_in' => array( 0 )` instead.
Reverts [36381], [36387].
See #35090 .
Built from https://develop.svn.wordpress.org/trunk@36480
git-svn-id: http://core.svn.wordpress.org/trunk@36447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:50:25 +00:00
8e5cf1c2fe
Comments: Add 'parent__in' and 'parent__not_in' to query var defaults.
...
Query var defaults are used to calculate a cache key. The fact that these
params were not listed among the defaults was causing cache keys to be
insufficiently specific.
Props danielbachhuber.
Fixes #35677 .
Built from https://develop.svn.wordpress.org/trunk@36479
git-svn-id: http://core.svn.wordpress.org/trunk@36446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:36:28 +00:00
e42e8c6d72
Tests: Use the new `wpdb::close()` method for closing the DB connection.
...
Props markoheijnen.
Fixes #34903 .
Built from https://develop.svn.wordpress.org/trunk@36478
git-svn-id: http://core.svn.wordpress.org/trunk@36445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 01:06:28 +00:00
f75f20edb2
Accessibility: simplify the Plugins and Themes tables on the Updates screen.
...
Although it may seem counterintuitive at first, in very limited cases it's
better to remove improper semantics (this is not a tabular data table) in
order to reduce noise for screen reader users and simplify all the things.
Also improves headings to better separate sections.
Fixes #34780 .
Built from https://develop.svn.wordpress.org/trunk@36477
git-svn-id: http://core.svn.wordpress.org/trunk@36444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-04 19:19:27 +00:00
94fdeabe27
Docs: Document the `$args` parameter for `get_categories()` as a hash notation.
...
The only specific default for `get_categories()` is `$taxonomy` with a value of 'category', all the other arguments are documented separately in `get_terms()`.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36476
git-svn-id: http://core.svn.wordpress.org/trunk@36443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-04 14:50:26 +00:00
6bbb34818c
Docs: Reference `get_terms()` for arguments available in `get_categories()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36475
git-svn-id: http://core.svn.wordpress.org/trunk@36442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-04 14:38:28 +00:00
26bf8cda9b
Docs: Add more complete information to DocBlocks for private core functions `_wp_dashboard_control_callback()` and `_wp_dashboard_recent_comments_row()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36474
git-svn-id: http://core.svn.wordpress.org/trunk@36441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:20:26 +00:00
6995ec613e
Docs: Add private access notation to the DocBlock for the core `_wp_handle_upload()` function.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36473
git-svn-id: http://core.svn.wordpress.org/trunk@36440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:19:25 +00:00
d62a1bf1e9
Docs: Mark two private functions as such in wp-admin/ajax-actions.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36472
git-svn-id: http://core.svn.wordpress.org/trunk@36439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:17:26 +00:00
9351a7c9ff
Docs: Add a missing DocBlock for the private `_add_themes_utility_last()` function.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36471
git-svn-id: http://core.svn.wordpress.org/trunk@36438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:07:27 +00:00
72c6f7f86f
Suppress possible warnings in PHP < 5.3.3 by `parse_url()` in `wp_validate_redirect()`.
...
PHP 5.3.3 removed the E_WARNING that was emitted when URL parsing failed.
Built from https://develop.svn.wordpress.org/trunk@36446
git-svn-id: http://core.svn.wordpress.org/trunk@36413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:34:27 +00:00
5c4031dd84
Revert [35792]
...
This causes a regression and causes redirects to potentially fail.
See #5114 #34028
props ocean90
Built from https://develop.svn.wordpress.org/trunk@36445
git-svn-id: http://core.svn.wordpress.org/trunk@36412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:24:26 +00:00
361ed7a3d6
Better validation of the URL used in HTTP redirects.
...
Built from https://develop.svn.wordpress.org/trunk@36444
git-svn-id: http://core.svn.wordpress.org/trunk@36411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 15:11:28 +00:00
f65de8ec9f
HTTP: `0.1.2.3` is not a valid IP.
...
Built from https://develop.svn.wordpress.org/trunk@36435
git-svn-id: http://core.svn.wordpress.org/trunk@36402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 12:55:29 +00:00
e19a8796fd
Database: Allow loading when only the `mysqlnd` extension is loaded.
...
We do an early check for a mysql extension being loaded, but it fails if the `mysqlnd` extension is the only one present.
Props nexurium.
Fixes #33261 .
Built from https://develop.svn.wordpress.org/trunk@36434
git-svn-id: http://core.svn.wordpress.org/trunk@36401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 00:59:25 +00:00
5779ed9d8a
WPDB: Add a `close()` method to `wpdb`, for when the connection needs to be manually closed.
...
In the event that it was closed prematurely, `wpdb::query()` will re-open the connection automatically.
Fixes #34903 .
Built from https://develop.svn.wordpress.org/trunk@36433
git-svn-id: http://core.svn.wordpress.org/trunk@36400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 00:13:26 +00:00
9f7d608a6a
Customizer: Fix searching for available nav menu items by updating reference to nonce.
...
Fixes regression introduced in [36414] where the nonce for listing available nav menu items was updated to use the new centralized location at `wp.customize.settings.nonce`, but the nonce for search did not get updated.
See #35617 .
Built from https://develop.svn.wordpress.org/trunk@36432
git-svn-id: http://core.svn.wordpress.org/trunk@36399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 21:36:28 +00:00
cd892b86b4
Media: In `wp_read_image_metadata()` make sure that IPTC keywords are UTF8 encoded.
...
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.
Fixes #35316 .
Built from https://develop.svn.wordpress.org/trunk@36429
git-svn-id: http://core.svn.wordpress.org/trunk@36396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 14:53:27 +00:00
c9e5edd637
Menus: Avoid displaying two spinners when adding selected menu items.
...
Fixes #35682 .
Built from https://develop.svn.wordpress.org/trunk@36427
git-svn-id: http://core.svn.wordpress.org/trunk@36394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-31 18:06:27 +00:00
82f59fc6ef
Menus: after [36379] prevent "Quick Search" form submission when pressing Enter.
...
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36426
git-svn-id: http://core.svn.wordpress.org/trunk@36393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-31 14:03:27 +00:00
2573fa7ab8
Comments: Add back `$req` variable in `comments_template()`.
...
The variables in `comments_template()` should never be assumed to be unused. This function includes the `comments.php` template file from the active theme or falls back to `theme-compat/comments.php`. This is why including a file within a function only brings pain and sorrow.
Reverts r36322.
See #35473 .
Built from https://develop.svn.wordpress.org/trunk@36425
git-svn-id: http://core.svn.wordpress.org/trunk@36392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 22:13:26 +00:00
099b35933d
Comments: Add a back link to `wp_die()` comment form submission error display.
...
Fixes #4332 .
Props wonderboymusic, westonruter, shamess, rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@36424
git-svn-id: http://core.svn.wordpress.org/trunk@36391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 21:56:27 +00:00
98518bdd4d
Install: Improve the install page language chooser button style.
...
Fixes #34547 .
Built from https://develop.svn.wordpress.org/trunk@36423
git-svn-id: http://core.svn.wordpress.org/trunk@36390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 14:53:26 +00:00
62d8fda8dd
After [36171] remove all the occurrences of the old CSS clearfix.
...
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.
See #26396 .
Built from https://develop.svn.wordpress.org/trunk@36422
git-svn-id: http://core.svn.wordpress.org/trunk@36389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 13:46:27 +00:00
1abb98520b
Update Random_Compat to the latest version (1.1.6).
...
See #35665
Built from https://develop.svn.wordpress.org/trunk@36421
git-svn-id: http://core.svn.wordpress.org/trunk@36388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 00:57:28 +00:00
bb6a068e29
Simplify action placement in `update_metadata()`.
...
By combining a number of `foreach` loops, we make the code more readable and
potentially faster in the case where many metadata rows are being updated.
Props Shelob9.
Fixes #35652 .
Built from https://develop.svn.wordpress.org/trunk@36420
git-svn-id: http://core.svn.wordpress.org/trunk@36387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-29 04:52:28 +00:00
34b9af6efd
Menus: Remove a redundant and unused `0` parameter from the `Delete Menu` link on the nav menus admin screen.
...
Fixes #35641 .
Built from https://develop.svn.wordpress.org/trunk@36419
git-svn-id: http://core.svn.wordpress.org/trunk@36386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 06:14:25 +00:00
4b4978ecbd
Pass additional params to 'get_archive_links' filter.
...
Props sebastian.pisula.
Fixes #35573 .
Built from https://develop.svn.wordpress.org/trunk@36418
git-svn-id: http://core.svn.wordpress.org/trunk@36385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 04:46:26 +00:00
Pascal Birchler
Weston Ruter
Dominik Schilling
Boone Gorges
Sergey Biryukov
Drew Jaynes
Andrew Ozz
Ella Iseulde Van Dorpe
Andrea Fercia
Mike Schroder
Eric Lewis
Rachel Baker
Jeremy Felt
Dion Hulse
Ryan McCue
Aaron Jorbin
Gary Pendergast