Scott Taylor
5855cb0e60
When editing an image from the editor, and the image has a value for alignment (but not for `width` or `caption`), don't bail without first checking that the alignment's value is not `alignnone`. If so, add the `class` to the `<a>` before bailing.
...
See #21848 .
Built from https://develop.svn.wordpress.org/trunk@31958
git-svn-id: http://core.svn.wordpress.org/trunk@31937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:04:27 +00:00
Helen Hou-Sandí
af79adbdd4
wpLink: Enable smooth scrolling on iOS devices.
...
fixes #31612 .
Built from https://develop.svn.wordpress.org/trunk@31957
git-svn-id: http://core.svn.wordpress.org/trunk@31936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 15:34:26 +00:00
Sergey Biryukov
29cddbeda9
Add translator comments for placeholders in network-related strings.
...
props ramiy.
fixes #31834 .
Built from https://develop.svn.wordpress.org/trunk@31956
git-svn-id: http://core.svn.wordpress.org/trunk@31935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:26:28 +00:00
Dominik Schilling
a7ba89b027
Accessibility: Add landmark roles to WordPress admin areas.
...
props afercia, joedolson.
fixes #31450 .
Built from https://develop.svn.wordpress.org/trunk@31955
git-svn-id: http://core.svn.wordpress.org/trunk@31934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:17:27 +00:00
Dominik Schilling
8ab7c076d6
Customizer Theme Switcher: Switch the details/live preview buttons.
...
props celloexpressions, ocean90.
fixes #31791 .
Built from https://develop.svn.wordpress.org/trunk@31954
git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:36:26 +00:00
Gary Pendergast
a3bbadbbea
WPDB: Due to PHP 5.2's internal string handling, strings in Windows are encoded using UTF-16, instead of UTF-8. With the addition of the many character set tests in [30345], a couple of them were tripping up in PHP 5.2 under Windows, because of this behaviour.
...
This marks those tests as skipped.
See #31262 for more discussion.
Built from https://develop.svn.wordpress.org/trunk@31953
git-svn-id: http://core.svn.wordpress.org/trunk@31932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:34:27 +00:00
Dominik Schilling
43352a0759
Themes: Improve focus styling of add-new-theme link.
...
props celloexpressions, mrahmadawais.
fixes #31203 .
Built from https://develop.svn.wordpress.org/trunk@31952
git-svn-id: http://core.svn.wordpress.org/trunk@31931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:22:27 +00:00
Sergey Biryukov
6a297b848a
After [31941], use the decoupled strings from `WP_Customize_Manager::register_controls()` on the Menus screen.
...
see #28502 .
Built from https://develop.svn.wordpress.org/trunk@31951
git-svn-id: http://core.svn.wordpress.org/trunk@31930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 11:37:26 +00:00
Dominik Schilling
b95a8227d8
Customizer Theme Switcher: Fix invalid HTML markup when New Theme control is added.
...
see #31203 .
Built from https://develop.svn.wordpress.org/trunk@31950
git-svn-id: http://core.svn.wordpress.org/trunk@31929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 11:35:26 +00:00
Aaron Jorbin
8f99fbeb8d
Refine UI for FTP modal and shiny updates
...
Numerous changes to make the FTP modal experience a good one. These include:
* Update HTML used by both the form here and the form on the standalone screen
* Allow users to cancel FTP install
* Focus locking in the modal
* Focus on modal form on load
* ARIA Attributes
* Style Enhancements
* Add low screen height (such as phone and some tablets) friendly experience for entering credentials
Props ericlewis, afercia
Fixes #31608
Built from https://develop.svn.wordpress.org/trunk@31949
git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
Andrew Ozz
e053979219
Emoji:
...
- Enhance twemoji.js to support passing of additional attributes for the replacement images.
- Use that to add the needed attributes when replacing emoji inside the editor.
Fixes #31627 .
Built from https://develop.svn.wordpress.org/trunk@31948
git-svn-id: http://core.svn.wordpress.org/trunk@31927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:39:28 +00:00
Gary Pendergast
6a9d744b42
WPDB: When we check the character set of a column, and find that it's `utf8mb4`, we should also check that the current connection supports `utf8mb4`. It's possible that the environment may have changed since upgrading the DB, so we can fall back to `utf8` when that happens.
...
Fixes #31771 .
Built from https://develop.svn.wordpress.org/trunk@31947
git-svn-id: http://core.svn.wordpress.org/trunk@31926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:22:31 +00:00
Andrew Ozz
5fe7be9757
TinyMCE emoji: fix caret position after replacing emoji in Chrome on Windows 8.
...
See #31627 .
Built from https://develop.svn.wordpress.org/trunk@31946
git-svn-id: http://core.svn.wordpress.org/trunk@31925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 23:35:26 +00:00
Dominik Schilling
d775c933c7
Disable body scrolling when session expired log in modal is open.
...
Fixes also the missing close icon if screen width is less than 380px.
props adamsilverstein, ocean90.
fixes #31610 .
Built from https://develop.svn.wordpress.org/trunk@31945
git-svn-id: http://core.svn.wordpress.org/trunk@31924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 22:55:26 +00:00
Dominik Schilling
79a29b077e
Customizer: Defer rendering theme controls until the section is displayed.
...
see #31793 .
Built from https://develop.svn.wordpress.org/trunk@31944
git-svn-id: http://core.svn.wordpress.org/trunk@31923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 22:21:25 +00:00
Sergey Biryukov
efb2740e88
Themes: Add a filter to short-circuit `wp_prepare_themes_for_js()`.
...
props mattwiebe, DrewAPicture.
fixes #31789 .
Built from https://develop.svn.wordpress.org/trunk@31943
git-svn-id: http://core.svn.wordpress.org/trunk@31922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 20:04:25 +00:00
Sergey Biryukov
5fae37471a
Media Library: Add a label for attachment type select in list mode.
...
props afercia.
fixes #31795 .
Built from https://develop.svn.wordpress.org/trunk@31942
git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 19:57:26 +00:00
Sergey Biryukov
36643388ef
Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
...
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.
fixes #28502 .
Built from https://develop.svn.wordpress.org/trunk@31941
git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 18:45:28 +00:00
Gary Pendergast
563344c643
Emoji: Fix a unit test which was incorrectly failing after [31926] fixed emoji being incorrectly encoded.
...
Built from https://develop.svn.wordpress.org/trunk@31940
git-svn-id: http://core.svn.wordpress.org/trunk@31919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 09:37:26 +00:00
Gary Pendergast
2a8a5c963a
WPDB: When we're checking to see if the MySQL client library supports `utf8mb4`, we need a separate check for `mysqlnd` versions, which using different version numbering to `libmysqlclient`.
...
Props MattyRob.
Fixes #31644 .
Built from https://develop.svn.wordpress.org/trunk@31939
git-svn-id: http://core.svn.wordpress.org/trunk@31918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 09:18:27 +00:00
Gary Pendergast
486e80bdf5
Emoji: Change the emoji CDN to w.org, from wp.com.
...
See #31651 .
Built from https://develop.svn.wordpress.org/trunk@31938
git-svn-id: http://core.svn.wordpress.org/trunk@31917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 04:31:29 +00:00
Dion Hulse
47356fc7fc
Tests: Clean up the resulting /tmp/foo* files from the `tempnam` call.
...
Built from https://develop.svn.wordpress.org/trunk@31937
git-svn-id: http://core.svn.wordpress.org/trunk@31916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:52 +00:00
Dion Hulse
7e1e32909e
Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress.
...
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811
Built from https://develop.svn.wordpress.org/trunk@31936
git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:26 +00:00
Scott Taylor
a5478d7adb
Let us pray to the gods of backwards compatibility:
...
* The way that the JS modules for media are currently set up turns the existing global `wp.media` namespace into a read-only API, this is bad.
* For the existing module implementation to work with plugins, those looking to override or extend a class would have to modify their own plugin to use `browserify` - we can't expect this to happen
* Because the general way that plugins override media classes is via machete (resetting them to something else), we cannot use `require( 'module' )` in the internal code for media modules
We CAN continue to use `require( 'fun/js' )` in the manifests for media.
Future code/projects should carefully consider what is made to be public API. In 3.5, EVERYTHING was made public, so everything shall remain public.
See #31684 , #28510 .
Built from https://develop.svn.wordpress.org/trunk@31935
git-svn-id: http://core.svn.wordpress.org/trunk@31914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:03:29 +00:00
Lance Willett
57918dfc8f
Twenty Fifteen: adjust scroll behavior to make sure sidebar height is calculated during scroll events, not just resize events.
...
Fixes #31734 . Props jartes, lancewillett.
Built from https://develop.svn.wordpress.org/trunk@31934
git-svn-id: http://core.svn.wordpress.org/trunk@31913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 22:49:27 +00:00
Dominik Schilling
289db2d37b
Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother.
...
see #31782 .
Built from https://develop.svn.wordpress.org/trunk@31933
git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:22:26 +00:00
Lance Willett
b8e58b3352
Twenty Thirteen: make sure submenu links work correctly on small screens with touch events.
...
Fixes #31762 , props davidhamiltron.
Built from https://develop.svn.wordpress.org/trunk@31932
git-svn-id: http://core.svn.wordpress.org/trunk@31911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:20:27 +00:00
Andrew Ozz
b5643f9a13
TinyMCE wpView: add back the removal of selected views on inserting new content. Was removed when reverting the first fix for embedding of pasted URLs.
...
Props mattheu. Fixes #31796 .
Built from https://develop.svn.wordpress.org/trunk@31931
git-svn-id: http://core.svn.wordpress.org/trunk@31910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 18:22:27 +00:00
Sergey Biryukov
e70e4e74fa
Press This: Use the error message returned by `wp_update_post()` instead of a generic one.
...
props stephdau.
fixes #31808 .
Built from https://develop.svn.wordpress.org/trunk@31930
git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 14:39:26 +00:00
Sergey Biryukov
cd2e63700e
Use a more specific selector for comment moderation hotkeys after [31513].
...
props afercia.
fixes #31545 .
Built from https://develop.svn.wordpress.org/trunk@31929
git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Sergey Biryukov
43a99e0f1b
Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
...
props SergeyBiryukov, afercia, tyxla.
fixes #30766 .
Built from https://develop.svn.wordpress.org/trunk@31928
git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 12:50:29 +00:00
Sergey Biryukov
a1dbd97adb
Fix duplicate ID for Save Menu button on Menus screen.
...
props sagarjadhav.
fixes #31803 .
Built from https://develop.svn.wordpress.org/trunk@31927
git-svn-id: http://core.svn.wordpress.org/trunk@31906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 09:49:26 +00:00
Gary Pendergast
3ddbef69e3
Emoji: When encoding emoji into HTML entities, 0 was being incorrectly trimmed from the right side of the hex string, causing some characters to be encoded incorrectly.
...
Built from https://develop.svn.wordpress.org/trunk@31926
git-svn-id: http://core.svn.wordpress.org/trunk@31905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:27:31 +00:00
Andrew Ozz
6cd9c9645e
Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
...
Part props afercis, joedolson. Fixes #31575 .
Built from https://develop.svn.wordpress.org/trunk@31925
git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
Gary Pendergast
31db5d08fe
Emoji: When staticizing emoji into `<img>` tags, include an `alt` attribute of the original Emoji, to match both Smiley and Twemoji `<img>` tags.
...
Built from https://develop.svn.wordpress.org/trunk@31924
git-svn-id: http://core.svn.wordpress.org/trunk@31903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:26 +00:00
Andrew Ozz
8ff664171d
Remove unused vars. See #31627 .
...
Built from https://develop.svn.wordpress.org/trunk@31923
git-svn-id: http://core.svn.wordpress.org/trunk@31902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 02:50:27 +00:00
Andrew Ozz
f128f08c2c
TinyMCE emoji: catch the inserting of emoji chars with the Windows 8 onscreen keyboard and replace if needed.
...
Fixes #31627 .
Built from https://develop.svn.wordpress.org/trunk@31922
git-svn-id: http://core.svn.wordpress.org/trunk@31901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 02:39:28 +00:00
Dominik Schilling
7bc60fed4a
Customizer: Increase initial-scale viewport specification to 1.0.
...
see #31794 , #28784 .
Built from https://develop.svn.wordpress.org/trunk@31921
git-svn-id: http://core.svn.wordpress.org/trunk@31900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 12:23:27 +00:00
Dominik Schilling
b07e3e2de7
Customizer: Fix calculation of panel positions when accessing via deep-links.
...
Make sure that the parent `li` is shown before attempting to calculate its position.
Improve also the logic for focusing on a panel to prevent focusing hidden elements.
props westonruter.
fixes #31014 .
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31920
git-svn-id: http://core.svn.wordpress.org/trunk@31899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 11:17:28 +00:00
Andrew Ozz
71f48f45e0
Press This:
...
- When saving, replace emoji images with chars in the title text.
- Clean up the title text on paste.
See #31768 .
Built from https://develop.svn.wordpress.org/trunk@31919
git-svn-id: http://core.svn.wordpress.org/trunk@31898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 03:14:28 +00:00
Dominik Schilling
96b88a391b
Theme Switcher: Use the global panel back button instead of adding a new one.
...
This ensures the back button is visible on iOS devices. Same as in [29610].
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31918
git-svn-id: http://core.svn.wordpress.org/trunk@31897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 22:09:26 +00:00
Dominik Schilling
7875dd4853
Customizer: Increase size of search field and disable text size adjustment to prevent auto zooming.
...
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31917
git-svn-id: http://core.svn.wordpress.org/trunk@31896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 21:03:27 +00:00
Dominik Schilling
80972b7ecd
Customizer: Fix selector for container which includes the controls. Broken since [30102].
...
see #31794 , #31014 .
Built from https://develop.svn.wordpress.org/trunk@31916
git-svn-id: http://core.svn.wordpress.org/trunk@31895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 20:47:30 +00:00
Dominik Schilling
2c036f589e
Remove a stray > introduced in [31905].
...
see #31776 .
Built from https://develop.svn.wordpress.org/trunk@31915
git-svn-id: http://core.svn.wordpress.org/trunk@31894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 23:20:27 +00:00
Dominik Schilling
ee2829959a
Theme Switcher: Opening themes details modal shouldn't require two clicks on touch devices.
...
Inspired by [26838].
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31914
git-svn-id: http://core.svn.wordpress.org/trunk@31893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:54:29 +00:00
Dominik Schilling
d51fded34c
Customizer: Use responsive button styles if screen is max-width 640px.
...
see #31794 , #28784 .
Built from https://develop.svn.wordpress.org/trunk@31913
git-svn-id: http://core.svn.wordpress.org/trunk@31892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:17:30 +00:00
Dominik Schilling
2dfb835751
Theme Switcher: Don't hide action buttons on narrow screens.
...
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31912
git-svn-id: http://core.svn.wordpress.org/trunk@31891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 21:53:27 +00:00
Dominik Schilling
2e314d764e
Customizer: Use proper preview URL for Live Preview links.
...
props mattwiebe.
fixes #31782 .
Built from https://develop.svn.wordpress.org/trunk@31911
git-svn-id: http://core.svn.wordpress.org/trunk@31890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 20:36:27 +00:00
Helen Hou-Sandí
007665e7be
Admin menu: Revert [31720] for swipe open/closed.
...
This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.
see #31187 .
Built from https://develop.svn.wordpress.org/trunk@31910
git-svn-id: http://core.svn.wordpress.org/trunk@31889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 17:48:30 +00:00
Gary Pendergast
bfb9990548
Emoji: [31864] changed emoji image's inline style from `height` to `max-height`. Unfortunately, anything using `feedparser.py` (for example, NewsBlur) strips out `max-height`, which gives us massive emoji in feeds.
...
This re-adds `height`, and also reminds us why we can't have nice things.
See #31719 .
Built from https://develop.svn.wordpress.org/trunk@31909
git-svn-id: http://core.svn.wordpress.org/trunk@31888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 02:12:28 +00:00