Sergey Biryukov
5c094564a7
Test: Don't skip the tests intended for single site when running on Multisite, add them to the `ms-excluded` group instead.
...
See #39776 , #45747 .
Built from https://develop.svn.wordpress.org/trunk@46683
git-svn-id: http://core.svn.wordpress.org/trunk@46483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 03:46:02 +00:00
Sergey Biryukov
c8f6d05c64
Tests: Skip `test_readme()` if the HTTP request to `secure.php.net` or `dev.mysql.com` failed on timeout.
...
Move `skipTestOnTimeout()` to `WP_UnitTestCase_Base` to avoid duplication.
See #44613 .
Built from https://develop.svn.wordpress.org/trunk@46682
git-svn-id: http://core.svn.wordpress.org/trunk@46482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 03:38:00 +00:00
Sergey Biryukov
ba21b391f6
Docs: Correct some inconsistencies in comments with Dashicon class references in `wp-admin/css/customize-widgets.css`.
...
Prepend all class name references with `dashicons-` for clarity.
Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417 .
Built from https://develop.svn.wordpress.org/trunk@46681
git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 00:03:02 +00:00
Sergey Biryukov
15a4289c8d
Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations.
...
Props skithund.
Fixes #48422 .
Built from https://develop.svn.wordpress.org/trunk@46679
git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 22:56:02 +00:00
John Blackbourn
84a1922e18
Toolbar: Un-deprecate the `WP_Admin_Bar::add_menu()` method.
...
This is only a wrapper for the `add_node()` method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.
Props whyisjake
Fixes #19647
Built from https://develop.svn.wordpress.org/trunk@46678
git-svn-id: http://core.svn.wordpress.org/trunk@46478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 13:19:04 +00:00
Andrew Ozz
60c2966222
Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
...
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677
git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-07 18:51:02 +00:00
desrosj
24f21d628d
Bundled Themes: Standardize the Required PHP and Tested Up To headers.
...
This change makes several changes to ensure consistency and accuracy for default theme headers:
- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.
Props Otto42, afragen.
Fixes #48517 .
Built from https://develop.svn.wordpress.org/trunk@46676
git-svn-id: http://core.svn.wordpress.org/trunk@46476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-07 15:19:04 +00:00
Sergey Biryukov
9088bea749
Docs: Make `@param` tags in `mce_buttons` and related filters consistent with the variable names.
...
Props upadalavipul, isabel_brison.
Fixes #41456 .
Built from https://develop.svn.wordpress.org/trunk@46675
git-svn-id: http://core.svn.wordpress.org/trunk@46475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-07 07:12:06 +00:00
Sergey Biryukov
4a2dc1a1a2
Tests: Properly mark `test_submenu_helpers_priority()` as skipped for multisite, so it's not categorized as "risky".
...
See #39776 .
Built from https://develop.svn.wordpress.org/trunk@46674
git-svn-id: http://core.svn.wordpress.org/trunk@46474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-06 01:17:03 +00:00
Sergey Biryukov
46caa0bfe8
Coding Standards: Fix WPCS issues in [46670].
...
See #48145 .
Built from https://develop.svn.wordpress.org/trunk@46671
git-svn-id: http://core.svn.wordpress.org/trunk@46471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 23:18:02 +00:00
John Blackbourn
a02c91ca17
REST API: Use explicit dates in a post ordering test to avoid indeterminate ordering.
...
See #48145
Built from https://develop.svn.wordpress.org/trunk@46670
git-svn-id: http://core.svn.wordpress.org/trunk@46470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 22:41:01 +00:00
desrosj
ffbde837e0
Bundled Themes: Update Twenty Twenty.
...
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289
.
Props williampatton, poena, andersnoren.
See #48110 , #48386 , #48450 , #48293 .
Fixes #48505 .
Built from https://develop.svn.wordpress.org/trunk@46668
git-svn-id: http://core.svn.wordpress.org/trunk@46468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 22:22:01 +00:00
desrosj
b8a473c834
Emoji: Upgrade Twemoji to 12.1.3.
...
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.
Props matstars, desrosj, Otto42, pento.
Fixes #48293 .
Built from https://develop.svn.wordpress.org/trunk@46665
git-svn-id: http://core.svn.wordpress.org/trunk@46465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 22:04:02 +00:00
John Blackbourn
9716848c87
Block Editor: Revert [46663] which was itself an erroneous revert.
...
See #48502
Built from https://develop.svn.wordpress.org/trunk@46664
git-svn-id: http://core.svn.wordpress.org/trunk@46464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:59:03 +00:00
John Blackbourn
13f3142222
Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
...
Merges [46656] to the 5.3 branch.
Fixes #48502
Built from https://develop.svn.wordpress.org/trunk@46663
git-svn-id: http://core.svn.wordpress.org/trunk@46463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:53:03 +00:00
John Blackbourn
eda6a9e111
Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46662
git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:30:03 +00:00
John Blackbourn
9ac1d82f23
Docs: Further improve documentation of known return types, plus other docs fixes.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46661
git-svn-id: http://core.svn.wordpress.org/trunk@46461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:27:02 +00:00
John Blackbourn
f545bb3f63
Docs: Improve documentation of known return types, plus other docs fixes.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46660
git-svn-id: http://core.svn.wordpress.org/trunk@46460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:23:02 +00:00
Andrew Ozz
f9e81c83d5
Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image.
...
Props ianmjones, azaozz.
Fixes #48453 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46658
git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 20:53:03 +00:00
Sergey Biryukov
ee7ec873ce
REST API: Speed up pagination unit tests by creating less fixtures and reusing them where possible.
...
Includes minor documentation and code layout fixes for better readability.
See #30017 , #48145 .
Built from https://develop.svn.wordpress.org/trunk@46657
git-svn-id: http://core.svn.wordpress.org/trunk@46457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 20:43:04 +00:00
jorgefilipecosta
6cdb9d0a37
Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
...
The list of included fixes is:
https://github.com/WordPress/gutenberg/pull/18183
https://github.com/WordPress/gutenberg/pull/18194
https://github.com/WordPress/gutenberg/pull/18230
https://github.com/WordPress/gutenberg/pull/18275
https://github.com/WordPress/gutenberg/pull/18287
Updated packages:
- @wordpress/block-editor@3.2.4
- @wordpress/block-library@2.9.5
- @wordpress/edit-post@3.8.5
- @wordpress/editor@9.7.5
- @wordpress/format-library@1.9.4
Props @aduth, @mcsf, @youknowriad, @johnbillion.
Fixes #48502 .
Built from https://develop.svn.wordpress.org/trunk@46656
git-svn-id: http://core.svn.wordpress.org/trunk@46456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 19:36:07 +00:00
whyisjake
5b4fe55ee8
REST API: Fix for Yoda condition.
...
Little coding standards fix for the REST API.
Props mukesh27, spenserhale.
Fixes #48337 .
Built from https://develop.svn.wordpress.org/trunk@46654
git-svn-id: http://core.svn.wordpress.org/trunk@46454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 17:38:03 +00:00
John Blackbourn
2e22c8292d
Docs: Correct and improve the readability of some parameters of `WP_Term_Query`.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46652
git-svn-id: http://core.svn.wordpress.org/trunk@46452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 17:50:02 +00:00
Andrew Ozz
43ed67661a
Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it.
...
See #48472 .
Built from https://develop.svn.wordpress.org/trunk@46651
git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 17:07:03 +00:00
Sergey Biryukov
4ef6154be2
Login and Registration: Simplify the test for `wp_signon()` added in [46640].
...
Make sure it actually tests the change in behavior, previously it passed both before and after the patch.
Add `wp_unslash()` to the last remaining instance of `$_POST['user_login']` that didn't have it.
See #38744 .
Built from https://develop.svn.wordpress.org/trunk@46650
git-svn-id: http://core.svn.wordpress.org/trunk@46450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 15:06:02 +00:00
Sergey Biryukov
b5bf852dfe
Build/Test Tools: Adjust the test for `wp_redirect()` status codes added in [46641] per the documentation and coding standards.
...
Move the test to a more appropriate place for consistency with `wp_sanitize_redirect()` and `wp_validate_redirect()` tests.
See #44317 .
Built from https://develop.svn.wordpress.org/trunk@46649
git-svn-id: http://core.svn.wordpress.org/trunk@46449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 12:59:01 +00:00
Sergey Biryukov
8dc75b569c
REST API: Set `orderby` parameter in tax relation unit tests added in [46646].
...
The default value of `date` caused a race condition resulting in random test failures.
See #44326 .
Built from https://develop.svn.wordpress.org/trunk@46648
git-svn-id: http://core.svn.wordpress.org/trunk@46448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 12:36:04 +00:00
Sergey Biryukov
8b76312eb3
Docs: Correct some array hash notations added in [46644].
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46647
git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 09:37:02 +00:00
TimothyBlynJacobs
5124c542e1
REST API: Add tax relation parameter to posts collection.
...
The REST API supports filtering by terms across multiple taxonomies using an AND relation. This adds support for an OR relation by adding "tax_relation=OR" as a query parameter.
Props earnjam.
Fixes #44326 .
Built from https://develop.svn.wordpress.org/trunk@46646
git-svn-id: http://core.svn.wordpress.org/trunk@46446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 23:14:02 +00:00
Aaron Jorbin
a4687f9134
Remove Failing Tests added in r46641
...
The tests for good redirects send headers that we can't handle in the test suite, so let's just remove them.
Unprops Jorbin.
Fixes #44317 .
Built from https://develop.svn.wordpress.org/trunk@46645
git-svn-id: http://core.svn.wordpress.org/trunk@46445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:49:03 +00:00
John Blackbourn
b3d6acd6a4
Docs: Fix some incorrect return tags in docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46644
git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:23:01 +00:00
whyisjake
441a4d752e
Coding Standards: Clean up the tests around `test_that_you_can_login_with_an_email_that_has_apostrophe`.
...
Let's use the proper coding standards for the comments.
Fixes #38744 .
Props cafenoirdesign.
Built from https://develop.svn.wordpress.org/trunk@46643
git-svn-id: http://core.svn.wordpress.org/trunk@46443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:17:58 +00:00
whyisjake
5e7876622e
Toolbar: Use `add_node()` instead of `add_menu()` in core.
...
This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)
Fixes : #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46642
git-svn-id: http://core.svn.wordpress.org/trunk@46442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:14:01 +00:00
Aaron Jorbin
946217dcca
General: wp_safe_redirect() and wp_redirect() shouldn't allow non-3xx status codes
...
Redirects should use redirect status codes and if you attempt to call wp_safe_redirect or wp_redirect with a non redirect status it can lead to undesired behavior and head scratching.
Fixes #44317 .
Props spenserhale, johnbillion, mjnewman for initial patch.
Built from https://develop.svn.wordpress.org/trunk@46641
git-svn-id: http://core.svn.wordpress.org/trunk@46441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:10:02 +00:00
whyisjake
a87271af60
Login and Registration: Allow email logins to be more flexible.
...
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.
Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46640
git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 20:12:02 +00:00
desrosj
44db7e4f6f
External Libraries: Revert [46634-46635].
...
On further investigation, Plupload changed it’s license to a non-GPL compatible license. The newest, GPL compatible version is being used already in Core.
Unprops desrosj.
See #48277 .
Built from https://develop.svn.wordpress.org/trunk@46638
git-svn-id: http://core.svn.wordpress.org/trunk@46438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 17:09:02 +00:00
desrosj
583e49d95f
Customize: Formally deprecate unused Customizer classes.
...
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.
Props weston.ruter, matthias-reuter, jrf.
Fixes #42364 .
Built from https://develop.svn.wordpress.org/trunk@46637
git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 16:48:00 +00:00
desrosj
be164bf6f4
Add `svn:auto-props` for `eol-style` and `mime-type` to `trunk`.
...
`svn:eol-style` and `svn:mime-type` property default values are now provided for all file types currently in `trunk`.
This also reverts the `eol-style` change to `wp-config-sample.php` made in [46586].
Fixes #42594 .
Built from https://develop.svn.wordpress.org/trunk@46636
git-svn-id: http://core.svn.wordpress.org/trunk@46436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 16:21:03 +00:00
desrosj
df7a0f7879
Remove unintended change to `svn:ignore` in [46634].
...
Built from https://develop.svn.wordpress.org/trunk@46635
git-svn-id: http://core.svn.wordpress.org/trunk@46435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 15:34:00 +00:00
desrosj
d825155631
External Libraries: Update Plupload from 2.1.9 to 2.3.6.
...
This change also updates the MoxieJS dependency from 1.3.5 to 1.5.7, converts Plupload to a dependency in NPM, and integrates all relevant parts into the build process.
For a full list of upstream changes, see https://github.com/moxiecode/plupload/compare/v2.1.9...v2.3.6 .
Props desrosj, hareesh-pillai.
Fixes #48277 .
Built from https://develop.svn.wordpress.org/trunk@46634
git-svn-id: http://core.svn.wordpress.org/trunk@46434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 15:31:02 +00:00
Sergey Biryukov
265bc4fe74
General: Wrap the error message in `_deprecated_constructor()` in `<code>` tags instead of `<pre>`.
...
Props aftabmuni.
Fixes #48483 .
Built from https://develop.svn.wordpress.org/trunk@46633
git-svn-id: http://core.svn.wordpress.org/trunk@46433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 10:56:03 +00:00
Sergey Biryukov
24650cbd68
Code Modernization: Call PHP 5 constructors in methods extending `POMO_Reader`.
...
Follow-up to [46629].
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46632
git-svn-id: http://core.svn.wordpress.org/trunk@46432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:49:01 +00:00
Sergey Biryukov
6cd00d098e
Docs: Correct version number in `@deprecated` tags for PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
...
Follow-up to [46629].
Props jrf.
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46631
git-svn-id: http://core.svn.wordpress.org/trunk@46431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:30:01 +00:00
Sergey Biryukov
85db3b5090
Docs: Correct `@see` references for PHP 4 constructors in `wp-includes/class-json.php`.
...
See #48252 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@46630
git-svn-id: http://core.svn.wordpress.org/trunk@46430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:13:02 +00:00
Sergey Biryukov
a0e7056387
Docs: Add missing `@deprecated` tags to PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
...
Props jrf.
Fixes #48252 .
Built from https://develop.svn.wordpress.org/trunk@46629
git-svn-id: http://core.svn.wordpress.org/trunk@46429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:11:04 +00:00
Sergey Biryukov
8aae5cb572
Twenty Eleven: Add missing `@deprecated` tag to PHP 4 constructor in `Twenty_Eleven_Ephemera_Widget`.
...
Props jrf.
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46628
git-svn-id: http://core.svn.wordpress.org/trunk@46428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:08:00 +00:00
Sergey Biryukov
6be425959a
Docs: Add missing `@deprecated` tags to PHP 4 constructors in `WP_Widget` and `WP_Widget_Factory()`.
...
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].
Props jrf.
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46627
git-svn-id: http://core.svn.wordpress.org/trunk@46427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:06:03 +00:00
Dion Hulse
ff6948a643
Bump Akismet external to 4.1.3.
...
See #WP47269.
git-svn-id: http://core.svn.wordpress.org/trunk@46424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 15:31:32 +00:00
Sergey Biryukov
2651ff3ae8
Docs: Update URLs in some `@link` tags and switch them to HTTPS.
...
Props tsuyoring.
Fixes #48479 .
Built from https://develop.svn.wordpress.org/trunk@46626
git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-01 14:57:02 +00:00
Sergey Biryukov
979a526902
Code Modernization: Pass an appropriate error level to `trigger_error()` in `_doing_it_wrong()` and related functions:
...
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`
The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.
Props jrf.
Fixes #36561 .
Built from https://develop.svn.wordpress.org/trunk@46625
git-svn-id: http://core.svn.wordpress.org/trunk@46422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-01 00:41:01 +00:00