Commit Graph

33742 Commits

Author SHA1 Message Date
Pascal Birchler 5d6513f0bc Embeds: Adjust the iframe title attribute for improved accessibility.
Changes the title attribute from `Embedded WordPress Post` to `"Post name" — site title`.

Props ramiy.
Fixes #35804.
Built from https://develop.svn.wordpress.org/trunk@36873


git-svn-id: http://core.svn.wordpress.org/trunk@36840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 10:00:29 +00:00
Dion Hulse cbda43788b Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source.
Props diddledan.
Fixes #35290

Built from https://develop.svn.wordpress.org/trunk@36872


git-svn-id: http://core.svn.wordpress.org/trunk@36839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 06:32:29 +00:00
Dominik Schilling f4ef187c2c Dependencies: Improve group processing of script dependencies.
This is a follow-up to [36604].

When processing dependencies `$this->group` will be the minimum of the script's registered group and all preceding siblings. This is wrong because only a scripts ancestors in the dependency chain should affect where it is loaded. Effectively `$this->group` introduced a form of global state which potentially corrupted the group of dependencies. Sorting covers up this problem.
The issue in #35873 was that script were not moving their dependencies to a lower group when necessary.

The fix:
* In `WP_Dependencies::all_deps()` pass the new `$group` value to `WP_Dependencies::all_deps()`. Previously the wrong value was passed because the parent script could have moved with `WP_Scripts::set_group()`.
* In `WP_Scripts::all_deps()` pass the `$group` parameter to `WP_Dependencies::all_deps()` so it doesn't always use `false` for `$group`. Same for `WP_Styles::all_deps()`.

Props stephenharris, gitlost.
Fixes #35956.
Built from https://develop.svn.wordpress.org/trunk@36871


git-svn-id: http://core.svn.wordpress.org/trunk@36838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 19:50:27 +00:00
Pascal Birchler c73a812109 HTTP: Avoid an undefined index notice in `wp_http_validate_url()`.
Props perezlabs.
Fixes #34164.
Built from https://develop.svn.wordpress.org/trunk@36870


git-svn-id: http://core.svn.wordpress.org/trunk@36837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 15:55:26 +00:00
Andrea Fercia aaa040eee9 CSS: Rename the handle for `deprecated-media.css` after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.
Built from https://develop.svn.wordpress.org/trunk@36869


git-svn-id: http://core.svn.wordpress.org/trunk@36836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 15:38:28 +00:00
Sergey Biryukov b80a516549 Docs: Add `wp_add_dashboard_widget()` parameter descriptions.
Props meitar for initial patch.
Fixes #36092.
Built from https://develop.svn.wordpress.org/trunk@36868


git-svn-id: http://core.svn.wordpress.org/trunk@36835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 12:08:28 +00:00
Jeremy Felt 27e29666a8 Multisite: Handle redirect to a user's subdomain properly during login
`wp-login.php` uses `wp_safe_redirect()` for all redirects, even those that do not involve unsafe data from the request or referer.

When a user of a subdomain site attempts to login to a network site they do not have access to, the host in the redirect URL is treated as unsafe by `wp_safe_redirect()` as it has no immediate awareness as to which hosts are valid on the network. On a subdirectoy network, everything works as expected because the host is the same.

In this specific block of `wp-login.php`, all URLs are generated by WordPress and we can use `wp_redirect()` to handle the redirects. Users authenticating via other network sites will now be redirected properly. Hosts passed via the `redirect_to` query var will continue to be handled by `wp_safe_redirect()`.

Fixes #30598.

Built from https://develop.svn.wordpress.org/trunk@36867


git-svn-id: http://core.svn.wordpress.org/trunk@36834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 03:06:29 +00:00
Weston Ruter 40f6779665 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.

Built from https://develop.svn.wordpress.org/trunk@36866


git-svn-id: http://core.svn.wordpress.org/trunk@36833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 01:45:27 +00:00
Aaron Jorbin fe4a3452c3 Update grunt-contrib-cssmin ~0.14.0 → ~1.0.0
See #35104.

Built from https://develop.svn.wordpress.org/trunk@36865


git-svn-id: http://core.svn.wordpress.org/trunk@36832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:37:27 +00:00
Aaron Jorbin 796f7cd97d Update grunt-contrib-copy ~0.8.2 → ~1.0.0
See #35104.

Built from https://develop.svn.wordpress.org/trunk@36864


git-svn-id: http://core.svn.wordpress.org/trunk@36831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:35:27 +00:00
Aaron Jorbin ac2d660906 Update grunt-contrib-concat ~0.5.1 → ~1.0.0
see #35104

Built from https://develop.svn.wordpress.org/trunk@36863


git-svn-id: http://core.svn.wordpress.org/trunk@36830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:32:27 +00:00
Aaron Jorbin c6b12480a1 Update grunt-contrib-compress ~0.14.0 → ~1.1.0
See #35104

Built from https://develop.svn.wordpress.org/trunk@36862


git-svn-id: http://core.svn.wordpress.org/trunk@36829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:25:29 +00:00
Aaron Jorbin 06d9654602 Update grunt-contrib-clean from 0.6.0 → 1.0.0
see #35104

Built from https://develop.svn.wordpress.org/trunk@36861


git-svn-id: http://core.svn.wordpress.org/trunk@36828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:19:27 +00:00
Aaron Jorbin 241dfd09e8 Update Autoprefixer to 6.3.3
See #35104

Built from https://develop.svn.wordpress.org/trunk@36860


git-svn-id: http://core.svn.wordpress.org/trunk@36827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:16:32 +00:00
Aaron Jorbin d71a0600a6 Ensure Description is respected in post type archive menu items.
Tested scenarios include: using the default (which is the post type description), Setting a custom description for that individual menu item, and setting a custom description that is blank. Introduced in r35382.

Props Toro_Unit, mayukojpn, extendwings, jorbin.
Fixes #35324. See #16075.


Built from https://develop.svn.wordpress.org/trunk@36859


git-svn-id: http://core.svn.wordpress.org/trunk@36826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:57:26 +00:00
Dominik Schilling 30f8c75047 Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.
Built from https://develop.svn.wordpress.org/trunk@36858


git-svn-id: http://core.svn.wordpress.org/trunk@36825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:07:25 +00:00
Andrew Ozz b5cc1c7dfa TinyMCE:
- Fix the icon for the native dialogs close button.
- Highlight the button on :focus.

See #36035.
Built from https://develop.svn.wordpress.org/trunk@36857


git-svn-id: http://core.svn.wordpress.org/trunk@36824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:01:27 +00:00
Aaron Jorbin 265011b9b6 Fix License test
Broken in r36855

Fixes #35278


Built from https://develop.svn.wordpress.org/trunk@36856


git-svn-id: http://core.svn.wordpress.org/trunk@36823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 20:22:26 +00:00
Aaron Jorbin 5e7262847f Clarify Copyright year
Based on http://copyright.gov/title17/92chap4.html#401 and being more consistent with the rest of the document.

See also https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Fixes #35278

Built from https://develop.svn.wordpress.org/trunk@36855


git-svn-id: http://core.svn.wordpress.org/trunk@36822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 20:14:25 +00:00
Eric Lewis a749f90e73 Build/Test Tools: Document PHP unit test classes.
Props boonebgorges.
Fixes #35494.

Built from https://develop.svn.wordpress.org/trunk@36854


git-svn-id: http://core.svn.wordpress.org/trunk@36821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 19:48:28 +00:00
John Blackbourn 3184328ecb Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.
Fixes #35980

Built from https://develop.svn.wordpress.org/trunk@36853


git-svn-id: http://core.svn.wordpress.org/trunk@36820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 03:56:27 +00:00
Eric Lewis 0c1cca9961 Menus: Ensure theme location setting data is saved with a large menu.
[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.

Built from https://develop.svn.wordpress.org/trunk@36852


git-svn-id: http://core.svn.wordpress.org/trunk@36819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 00:47:26 +00:00
Weston Ruter a8ca958d43 Customize: Eliminate unnecessary `WP_Customize_Site_Logo_Control` in favor of re-using `WP_Customize_Image_Control`.
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096.

See #33755.
Fixes #35941.

Built from https://develop.svn.wordpress.org/trunk@36851


git-svn-id: http://core.svn.wordpress.org/trunk@36818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 23:47:26 +00:00
Dominik Schilling f11d47d9ba I18N: Fix an invalid placeholder added in [36844].
See #36048.
Built from https://develop.svn.wordpress.org/trunk@36850


git-svn-id: http://core.svn.wordpress.org/trunk@36817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 21:10:26 +00:00
Andrew Ozz 3bb9185496 TinyMCE, inline link: add styling for the dialog and UI Autocomplete to Press This.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36849


git-svn-id: http://core.svn.wordpress.org/trunk@36816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 20:31:26 +00:00
Andrew Ozz 9b2d44e5a1 Pres This:
- Change the newly added `press_this_save_post_content` filter to `press_this_save_post` and pass the $post_data array to it.
- Remove the newly added `press_this_useful_html_elements`. It only runs in compatibility mode when a URL is typed by the user.
- Remove the `press_this_suggested_content` filter. It is redundant as the suggested HTML for the editor is already filtered by `press_this_suggested_html`.
- Add some more inline docs and rename couple of vars to make the code more readable.

Fixes #34455.
Built from https://develop.svn.wordpress.org/trunk@36848


git-svn-id: http://core.svn.wordpress.org/trunk@36815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 18:56:26 +00:00
Drew Jaynes bbc3cde9b0 Docs: Improve DocBlock syntax and add a missing `@return` notation for `WP_Image_Editor_Imagick::strip_meta()`, introduced in [36700].
See: #33642, #30402, #28634. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36847


git-svn-id: http://core.svn.wordpress.org/trunk@36814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 17:37:27 +00:00
Drew Jaynes d8f8f68d42 Docs: Improve the hook doc summary for the `image_strip_meta` filter, introduced in [36700].
See: #33642, #30402, #28634. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36846


git-svn-id: http://core.svn.wordpress.org/trunk@36813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 17:33:26 +00:00
Sergey Biryukov ac2aab5b82 I18N: Move the `aria-label` text in `get_theme_update_available()` to a separate string for easier translation.
Add translator comments.

Props ramiy.
Fixes #36048.
Built from https://develop.svn.wordpress.org/trunk@36845


git-svn-id: http://core.svn.wordpress.org/trunk@36812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 11:12:26 +00:00
Sergey Biryukov 0ab23c217f I18N: Move the `aria-label` text in `wp_plugin_update_row()` and `wp_theme_update_row()` to a separate string for easier translation.
Add translator comments.

Props ramiy.
See #36048.
Built from https://develop.svn.wordpress.org/trunk@36844


git-svn-id: http://core.svn.wordpress.org/trunk@36811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 11:08:27 +00:00
Sergey Biryukov 7ef42ed781 Comment out some CSS files in `$_old_files` that were added back as a result of [36341].
Add a unit test to make sure the `$_old_files` array does not contain any current project files.

Props joemcgill, swissspidy.
Fixes #36083.
Built from https://develop.svn.wordpress.org/trunk@36843


git-svn-id: http://core.svn.wordpress.org/trunk@36810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 07:56:27 +00:00
Drew Jaynes 7696b79d0c Docs: Improve syntax and correct documentation throughout a variety of methods in `WP_Customize_Widgets`.
See #32246. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36842


git-svn-id: http://core.svn.wordpress.org/trunk@36809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 02:02:26 +00:00
Drew Jaynes 66ec5425ea Docs: Improve documentation for `WP_Customize_Widgets::customize_dynamic_partial_args()`, introduced in [36586].
See #27355. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36841


git-svn-id: http://core.svn.wordpress.org/trunk@36808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 01:45:26 +00:00
Drew Jaynes e842a7b2e0 Docs: Remove an errant period following the `@access` tag in the DocBlock for `wpdb::close()`, mistakenly introduced in [36493].
Props markoheijnen.
See #34903. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36840


git-svn-id: http://core.svn.wordpress.org/trunk@36807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 00:03:27 +00:00
Konstantin Obenland 0f9f8418f8 Customize: Don't show custom image sizes in the media modal.
Custom image sizes for logos should only be used for their intended purpose.

See #33755.

Built from https://develop.svn.wordpress.org/trunk@36839


git-svn-id: http://core.svn.wordpress.org/trunk@36806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 21:45:26 +00:00
Konstantin Obenland 1ef0d464d7 Customize: Rename custom logo classes after [36837].
Fixes #35945.

Built from https://develop.svn.wordpress.org/trunk@36838


git-svn-id: http://core.svn.wordpress.org/trunk@36805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 19:59:27 +00:00
Konstantin Obenland 147d6d7d6c Customize: Site logos are custom logos.
Brings the nomenclature closer to custom headers and backgrounds.

See https://wordpress.slack.com/archives/core/p1456955151003150
See #35945. 

Built from https://develop.svn.wordpress.org/trunk@36837


git-svn-id: http://core.svn.wordpress.org/trunk@36804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 19:56:26 +00:00
Drew Jaynes a9e4d9c7f4 Docs: Improve DocBlock syntax for `WP_Customize_Nav_Menus::customize_dynamic_partial_args()`, introduced in [36586].
See #27355. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36836


git-svn-id: http://core.svn.wordpress.org/trunk@36803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 16:07:26 +00:00
Drew Jaynes ee2e632774 Docs: Improve documentation for `WP_Customize_Nav_Menus::filter_nonces()`, introduced in [36414].
See #27355, #35617. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36835


git-svn-id: http://core.svn.wordpress.org/trunk@36802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 16:05:27 +00:00
Drew Jaynes 4a171993ed Docs: Standardize the changelog entry for the new `$author_url` argument, introduced in [36224].
See #35377. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36834


git-svn-id: http://core.svn.wordpress.org/trunk@36801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 16:02:27 +00:00
Drew Jaynes 2802e067a1 Docs: Improve the DocBlock summary and add a missing initial `@since` version for `WP_Admin_Bar::add_node()`.
See #32246. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36833


git-svn-id: http://core.svn.wordpress.org/trunk@36800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 15:58:27 +00:00
Sergey Biryukov dd82fc5ae5 Date/Time: Add a unit test for `mysql_to_rfc3339()`.
Props borgesbruno.
Fixes #36054.
Built from https://develop.svn.wordpress.org/trunk@36832


git-svn-id: http://core.svn.wordpress.org/trunk@36799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 13:17:28 +00:00
Joe Hoyle 73de4499fc REST API: Unit test for OPTIONS request should call rest_send_allow_header
In [36829] we moved this logic to rest_send_allow_header()

See #36829.

Built from https://develop.svn.wordpress.org/trunk@36831


git-svn-id: http://core.svn.wordpress.org/trunk@36798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 11:38:28 +00:00
Sergey Biryukov 9e8b3817fd Docs: Correct `$plugins` global type in `WP_Plugins_List_Table::prepare_items()`.
Props mt8.biz.
Fixes #36080.
Built from https://develop.svn.wordpress.org/trunk@36830


git-svn-id: http://core.svn.wordpress.org/trunk@36797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 10:01:25 +00:00
Joe Hoyle 09024dae88 OPTIONS requests to REST API should return Allow header.
An OPTIONS request was incorrectly returning an "Accept" header which
was a typo of "Allow". This meant Accept was showing "GET, POST" for example,
however it was also not running the permission checks on the endpoints.

Instead, the correct route needs to be set on the request object, which means
the normal handling for the Allow header will kick in. This technically
breaks backwards compatibility, however given the value of Accept was also wrong
then this should not be an issue.

Fixes #35975.

Built from https://develop.svn.wordpress.org/trunk@36829


git-svn-id: http://core.svn.wordpress.org/trunk@36796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 09:55:26 +00:00
Pascal Birchler 05c069272f Docs: Move the hook doc for the `all_plugins` filter in `WP_Plugins_List_Table::prepare_items()` to directly precede the `apply_filters()` line.
See #35986.
Built from https://develop.svn.wordpress.org/trunk@36828


git-svn-id: http://core.svn.wordpress.org/trunk@36795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 09:51:25 +00:00
Pascal Birchler 52c901d983 Docs: Improve documentation for the `update_welcome_user_email()` filter, introduced in [26538].
See #25598. See #35986.
Built from https://develop.svn.wordpress.org/trunk@36827


git-svn-id: http://core.svn.wordpress.org/trunk@36794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 09:12:27 +00:00
Drew Jaynes fc57bb7a04 Docs: Minorly improve the hook doc summary for the `pre_network_site_new_created_user` action, introduced in [35786].
See #33631. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36826


git-svn-id: http://core.svn.wordpress.org/trunk@36793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 09:03:25 +00:00
Drew Jaynes 56fb3cc08d Docs: Improve documentation for `upgrade_450()`, introduced in [36180].
See #27772, #35323. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36825


git-svn-id: http://core.svn.wordpress.org/trunk@36792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 09:01:26 +00:00
Drew Jaynes 9b531bb473 Docs: Minorly improve the hook doc summary for the `pre_uninstall_plugin` action, introduced in [36124].
See #34569. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36824


git-svn-id: http://core.svn.wordpress.org/trunk@36791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 08:58:26 +00:00