WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
41,503 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

15205 Commits

Author SHA1 Message Date
Sergey Biryukov 71dea21c5f Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency. 
Props donmhico, bcworkz, seanchayes, mikeschroder, garrett-eclipse, akhileshsabharwal, ScottSmith, nacin, jenmylo, afercia, swissspidy, felix-edelmann, helen, melchoyce, karmatosed.
Fixes #26769.
Built from https://develop.svn.wordpress.org/trunk@47600


git-svn-id: http://core.svn.wordpress.org/trunk@47375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-20 08:39:06 +00:00
Sergey Biryukov 30a35a4806 Upload: Better align file input and buttons in plugin/theme upload form. 
Follow-up to [47271].

Props seedsca, piyushmca.
Fixes #49914.
Built from https://develop.svn.wordpress.org/trunk@47599


git-svn-id: http://core.svn.wordpress.org/trunk@47374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-19 09:47:08 +00:00
Sergey Biryukov ee387b9181 Accessibility: Widgets: Prevent checkboxes in widget control forms from overlapping on smaller screens. 
Props jaz_on, milindmore22, passoniate, audrasjb, carriganvb, afercia, SergeyBiryukov.
Fixes #49228.
Built from https://develop.svn.wordpress.org/trunk@47598


git-svn-id: http://core.svn.wordpress.org/trunk@47373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-18 07:03:09 +00:00
Sergey Biryukov 61a2f62ffd Comments: Use `comment` instead of an empty string for the `comment_type` DB field value in comments table. 
This is the first step to bring support for custom comment types into WordPress.

Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time.

Props imath, aaroncampbell, jeremyfelt, dshanske.
Fixes #49236.
Built from https://develop.svn.wordpress.org/trunk@47597


git-svn-id: http://core.svn.wordpress.org/trunk@47372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 19:35:06 +00:00
Sergey Biryukov 012b134b23 Coding Standards: Fix WPCS indentation issue in `wp-admin/nav-menus.php`. 
This was causing a `PEAR.Functions.FunctionCallSignature.Indent` error if PHP_CodeSniffer 3.5.3 or newer is installed locally, despite the task passing on Travis.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47596


git-svn-id: http://core.svn.wordpress.org/trunk@47371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 18:55:09 +00:00
Sergey Biryukov af1a737b48 Coding Standards: Fix WPCS indentation issue in `wp-admin/includes/class-wp-links-list-table.php`. 
This was causing a `Generic.WhiteSpace.ScopeIndent.IncorrectExact` error if PHP_CodeSniffer 3.4.1 or newer is installed locally, despite the task passing on Travis.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47595


git-svn-id: http://core.svn.wordpress.org/trunk@47370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 18:31:07 +00:00
ianbelanger cf9b35eccd Bundled Themes: Twenty Twenty fix typo in readme.txt. 
Fixed TikTok was misspelled as Tik Tok in the readme.txt.

Props Asif2BD.
Fixes #49932.
Built from https://develop.svn.wordpress.org/trunk@47594


git-svn-id: http://core.svn.wordpress.org/trunk@47369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 15:47:08 +00:00
Sergey Biryukov fc7561ce11 Coding Standards: Format the markup of widget forms in a more consistent manner. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47593


git-svn-id: http://core.svn.wordpress.org/trunk@47368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 09:38:07 +00:00
Sergey Biryukov 900cfc4816 Administration: Remove the smiley from overly happy "No activity yet!" message on Dashboard. 
Props francoist, karmatosed, ibdz, estelaris, nrqsnchz, Presskopp.
Fixes #48387.
Built from https://develop.svn.wordpress.org/trunk@47592


git-svn-id: http://core.svn.wordpress.org/trunk@47367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 07:57:10 +00:00
ianbelanger d9c2537d87 Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken. 
Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.

Props kjellr, melchoyce.
Fixes #49699.
Built from https://develop.svn.wordpress.org/trunk@47591


git-svn-id: http://core.svn.wordpress.org/trunk@47366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 19:47:10 +00:00
ianbelanger c03b6040fe Bundled Themes: Twenty Twenty inline images in list blocks are not positioned correctly. 
Fixes the alignment of inline images in list blocks to match the way they look in the editor.

Props poena, mayankmajeji, JavierCasares.
Fixes #49793.
Built from https://develop.svn.wordpress.org/trunk@47590


git-svn-id: http://core.svn.wordpress.org/trunk@47365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 19:38:07 +00:00
ianbelanger 5116ed9ebb Bundled Themes: Twenty Twenty add TikTok to the social icon menu. 
This adds TikTok as an option in the social icon menu.

Props mislavjuric, poena, audrasjb.
Fixes #49893.
Built from https://develop.svn.wordpress.org/trunk@47589


git-svn-id: http://core.svn.wordpress.org/trunk@47364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 19:01:09 +00:00
Sergey Biryukov 4fbfbf5f61 Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing. 
Props roytanck, shooper.
Fixes #49916.
Built from https://develop.svn.wordpress.org/trunk@47588


git-svn-id: http://core.svn.wordpress.org/trunk@47363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 17:02:08 +00:00
ianbelanger b2f072b97e Bundled Themes: Twenty Nineteen editor style interferes with navigation menu block. 
Update editor styles to prepare for changes coming to the editor in 5.5. Currently the issue is only present when using the latest version of the Gutenberg plugin.

Props kjellr, Joen.
Fixes #49613.
Built from https://develop.svn.wordpress.org/trunk@47587


git-svn-id: http://core.svn.wordpress.org/trunk@47362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 14:56:16 +00:00
ianbelanger 90f5e0576b Bundled Themes: Twenty Nineteen decrease the font size for widget titles. 
Update styles to decrease the font size for widget titles.

Props kjellr, mukesh27.
Fixes #45865.
Built from https://develop.svn.wordpress.org/trunk@47586


git-svn-id: http://core.svn.wordpress.org/trunk@47361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 14:38:10 +00:00
Sergey Biryukov 92538d89ee Site Health: Detect an active PHP session as a possible reason for HTTP requests timing out. 
PHP sessions created by a `session_start()` function call may interfere with REST API and loopback requests.

An active session should be closed by `session_write_close()` before making any HTTP requests.

Props matthieumota, netweblogic, Clorith, afragen, vjik, SergeyBiryukov.
Fixes #47320.
Built from https://develop.svn.wordpress.org/trunk@47585


git-svn-id: http://core.svn.wordpress.org/trunk@47360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 08:20:09 +00:00
Sergey Biryukov 4e13efaf96 Code Modernization: Remove conditional use of `stream_get_contents()` PHP function. 
The function was introduced in PHP 5.0.0. Now that the minimum version of PHP required by WordPress is 5.6.20, these conditions are no longer needed.

Props jrf.
Fixes #48091.
Built from https://develop.svn.wordpress.org/trunk@47584


git-svn-id: http://core.svn.wordpress.org/trunk@47359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-15 11:54:08 +00:00
Sergey Biryukov bb2c0198ab Comments: Clarify that "Comment Moderation" and "Comment Blocklist" options in Discussion Settings also apply to browser's user agent string for submitted comments. 
Props zodiac1978.
Fixes #49902.
Built from https://develop.svn.wordpress.org/trunk@47583


git-svn-id: http://core.svn.wordpress.org/trunk@47358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-15 06:40:05 +00:00
Dominik Schilling 2d04c2e5c8 Posts, Post Types: Pass the post object to the `before_delete_post`, `delete_post`, `deleted_post`, and `after_delete_post` actions. 
Props jadpm.
Fixes #30940.
Built from https://develop.svn.wordpress.org/trunk@47582


git-svn-id: http://core.svn.wordpress.org/trunk@47357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 19:26:07 +00:00
Sergey Biryukov a4f6f2beae Mail: Make the check for empty post title in `wp-mail.php` more resilient. 
This addresses a regression in [47054], which caused posts sent via email to published with an empty title.

Props whyisjake, Otto42, MarkRH, MattyRob, mukesh27, afragen, pikamander2.
Fixes #49853.
Built from https://develop.svn.wordpress.org/trunk@47580


git-svn-id: http://core.svn.wordpress.org/trunk@47355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 11:32:06 +00:00
Sergey Biryukov a21b8a91c6 Docs: Add a `@since` note for un-deprecated `category_link` and `tag_link` filters. 
Follow-up to [47576].

See #49759.
Built from https://develop.svn.wordpress.org/trunk@47578


git-svn-id: http://core.svn.wordpress.org/trunk@47353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 08:15:19 +00:00
whyisjake 0a714eb26f Taxonomy: Un-depracate `category_link` and `tag_link` filters. 
Depracating these filter might have been an accident, so let's restore.

Props SergeyBiryukov, audrasjb, peterwilsoncc.
Fixes #49759. 

Built from https://develop.svn.wordpress.org/trunk@47576


git-svn-id: http://core.svn.wordpress.org/trunk@47351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 00:33:09 +00:00
Sergey Biryukov ae59482c80 Plugins: Simplify the logic of `validate_plugin_requirements()`, update documentation. 
This updates the function for consistency with `validate_theme_requirements()`.

Follow-up to [44978], [45546], [47573].

Fixes #43992.
Built from https://develop.svn.wordpress.org/trunk@47574


git-svn-id: http://core.svn.wordpress.org/trunk@47349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-13 15:31:05 +00:00
Sergey Biryukov d341f20fb1 Themes: Block theme activation if it requires a higher version of PHP or WordPress. 
Introduce `validate_theme_requirements()` for validating a theme's WordPress and PHP version requirements.

Follow-up to [44978] and [45546] for plugins.

Props afragen, audrasjb, SergeyBiryukov.
See #43992.
Built from https://develop.svn.wordpress.org/trunk@47573


git-svn-id: http://core.svn.wordpress.org/trunk@47348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-13 15:28:11 +00:00
Sergey Biryukov 87b3b38242 Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete. 
This adds a "Copied!" text near the "Copy this section to clipboard" button to provide direct feedback that the action was completed.

Props garrett-eclipse, nickylimjj, xkon, desrosj, birgire.
Fixes #44588.
Built from https://develop.svn.wordpress.org/trunk@47572


git-svn-id: http://core.svn.wordpress.org/trunk@47347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-12 14:26:11 +00:00
Sergey Biryukov 48225beffb Rewrite Rules: Use double quotes instead of backticks in `.htaccess` instructions about `# BEGIN/END` markers. 
Previously, the backticks resulted in extra markup being added when posted on support forums.

Props mayankmajeji, knutsp.
Fixes #49868.
Built from https://develop.svn.wordpress.org/trunk@47571


git-svn-id: http://core.svn.wordpress.org/trunk@47346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-11 15:09:11 +00:00
Sergey Biryukov 9f379bb930 Docs: Fix typo in `WP_Upgrader::__construct()` DocBlock. 
Props mattrad.
Fixes #49856.
Built from https://develop.svn.wordpress.org/trunk@47570


git-svn-id: http://core.svn.wordpress.org/trunk@47345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-10 09:48:17 +00:00
whyisjake 92636d716a Site Health instantiation prevents use of some hooks by plugins. 
As the WP_Site_Health class is instantiated prior to plugins being required and the `plugins_loaded` hook being fired, it prevents plugins from using the following hooks in the functions called by `maybe_create_scheduled_event()`.

Fixes #49824.
Props peterwilsoncc, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47568


git-svn-id: http://core.svn.wordpress.org/trunk@47343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-10 03:57:08 +00:00
whyisjake e42f45e667 Customize: Give the WordPress logo a white background for dark mode browsers. 
The favicon is transparent, which would normally look fine, but on a dark background it washes out.

Props DhrRob, audrasjb.
Fixes 49798.

Built from https://develop.svn.wordpress.org/trunk@47564


git-svn-id: http://core.svn.wordpress.org/trunk@47339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-10 02:50:07 +00:00
whyisjake a1bf993892 Privacy: Support additional elements (table, ol, ul) in privacy policy guide new styling 
The privacy policy guide supports a lot of HTML, include rules for lists, and ensure proper styling for the rest.

Props garrett-eclipse. 
Fixes #49772.

Built from https://develop.svn.wordpress.org/trunk@47560


git-svn-id: http://core.svn.wordpress.org/trunk@47335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 22:34:05 +00:00
K. Adam White 951b1d89db REST API: Handle parameter types consistently within set_param(). 
A request has multiple parameter types, including "query" and "json." Updating a parameter could previously modify a key's value in the wrong parameter type, leading to confusing and self-contradictory response objects.

Props mnelson4, TimothyBlynJacobs, vagios, jnylen0.
Fixes #40838.

Built from https://develop.svn.wordpress.org/trunk@47559


git-svn-id: http://core.svn.wordpress.org/trunk@47334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 19:30:07 +00:00
Andrea Fercia f927fdedb4 Accessibility: Fix the headings hierarchy on the Freedoms page. 
Props ryelle, afercia.
Fixes #49838.

Built from https://develop.svn.wordpress.org/trunk@47558


git-svn-id: http://core.svn.wordpress.org/trunk@47333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 16:09:11 +00:00
Sergey Biryukov 856e1a27b8 Coding Standards: Use strict type check for `in_array()` and `array_search()`. 
This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47557


git-svn-id: http://core.svn.wordpress.org/trunk@47332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 15:43:10 +00:00
Mike Schroder 7097f6cef0 Tests: Pass API key to distributed test reporter. 
Pass environment variable for test reporter API key to
`docker-compose` so that it can authenticate and submit results
to the hosting distributed tests.

Props SergeyBiryukov, mikeschroder.
Fixes #49846.
Built from https://develop.svn.wordpress.org/trunk@47556


git-svn-id: http://core.svn.wordpress.org/trunk@47331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 06:08:10 +00:00
Sergey Biryukov c18e44d6b1 Privacy: Make the deprecated `wp_get_user_request_data()` function available on front end. 
Previously, it was accidentally made available only in admin context.

Follow-up to [44606], [47245].

Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12.
Fixes #49802.
Built from https://develop.svn.wordpress.org/trunk@47555


git-svn-id: http://core.svn.wordpress.org/trunk@47330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-08 18:33:08 +00:00
Andrew Ozz 0e38f8ed26 Media: Enable lazy-loading of images by automatically adding the new `loading="lazy"` attribute to image tags on the front-end. 
- Introduces `wp_lazy_loading_enabled()`, `wp_filter_content_tags()`, `wp_img_tag_add_loading_attr()`, and `wp_img_tag_add_srcset_and_sizes_attr()` functions.
- Introduces `wp_lazy_loading_enabled`, `wp_img_tag_add_loading_attr`, and `wp_img_tag_add_srcset_and_sizes_attr` filters.

Props flixos90, addyosmani, mor10, swissspidy, pierlo, westonruter, spacedmonkey, mikeschroder, jonoaldersonwp, peterwilsoncc, narwen, jeffpaul, OptimizingMatters, futtta, mukeshpanchal27, azaozz.

Fixes #44427.
Built from https://develop.svn.wordpress.org/trunk@47554


git-svn-id: http://core.svn.wordpress.org/trunk@47329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-08 00:55:07 +00:00
Sergey Biryukov 195312ead2 Users: Pass the ID of the user that was logged out to the `wp_logout` action. 
Props donmhico, figureone, TimothyBlynJacobs, rebasaurus.
Fixes #49533.
Built from https://develop.svn.wordpress.org/trunk@47553


git-svn-id: http://core.svn.wordpress.org/trunk@47328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-07 16:14:10 +00:00
Sergey Biryukov 78e62aa3e4 Coding Standards: Whitelist `date_default_timezone_set()` usage in `wp-settings.php`. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47552


git-svn-id: http://core.svn.wordpress.org/trunk@47327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-06 09:06:12 +00:00
Sergey Biryukov 57b7f0bc22 Coding Standards: Switch `WordPress.PHP.YodaConditions.NotYoda` back to error level. 
This was marked as a warning in [45665] until all the issues associated with the sniff are addressed, so that linting on Travis could run across the entire codebase.

With all the instances now addressed, this override is no longer needed.

Follow-up to [47054], [47218], [47219].

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47551


git-svn-id: http://core.svn.wordpress.org/trunk@47326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-05 03:21:06 +00:00
Sergey Biryukov 38676936ba Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-05 03:02:11 +00:00
Andrew Ozz 10e3e44219 Media: Remove `display: none;` from the (visually hidden) `<input type="file">` button used in Plupload to select files for uploading. Fixes selecting files in Edge <= 44 and iOS Safari. 
Props treecutter, johnbillion, pbiron, isabel_brison, Ipstenu, azaozz.
Fixes #49753 for trunk.
Built from https://develop.svn.wordpress.org/trunk@47549


git-svn-id: http://core.svn.wordpress.org/trunk@47324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-04 22:54:09 +00:00
Sergey Biryukov 9f481cdf7a Tests: Remove `test_post_thumbnails_types_true()`. 
The test incorrectly describes the behavior of `current_theme_supports( 'post-thumbnails' )` and only passes by accident.

Follow-up to [30148].

Fixes #49801.
Built from https://develop.svn.wordpress.org/trunk@47548


git-svn-id: http://core.svn.wordpress.org/trunk@47323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-04 00:27:06 +00:00
K. Adam White 51619c00a4 REST API: Fix revisions controller get_item permission check. 
r45812 incorrectly introduced a delete_post permissions check into the get_item method, breaking some plugins which requested revisions when generating previews.

Props sorenbronsted, yohannp, TimothyBlynJacobs.
Fixes #49645.

Built from https://develop.svn.wordpress.org/trunk@47547


git-svn-id: http://core.svn.wordpress.org/trunk@47322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-03 19:40:08 +00:00
Sergey Biryukov 441001f29f Docs: Add documentation for the `$parent` parameter of `get_admin_page_parent()`. 
Props subrataemfluence.
Fixes #45849.
Built from https://develop.svn.wordpress.org/trunk@47546


git-svn-id: http://core.svn.wordpress.org/trunk@47321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-03 17:23:11 +00:00
Sergey Biryukov ca8463f4f4 Docs: Use third-person singular verbs for function descriptions in `wp-includes/category-template.php`, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47545


git-svn-id: http://core.svn.wordpress.org/trunk@47320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-02 15:51:08 +00:00
Sergey Biryukov 4ef14fd7af Build/Test Tools: Remove a starting empty line from `svn:ignore` property on `wp-includes`. 
Follow-up to [47352].

See #48154.
Built from https://develop.svn.wordpress.org/trunk@47544


git-svn-id: http://core.svn.wordpress.org/trunk@47319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-01 13:45:09 +00:00
desrosj 64b3c852bf Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4. 
Props ianbelanger, desrosj, SergeyBiryukov.
Fixes #49743.
Built from https://develop.svn.wordpress.org/trunk@47539


git-svn-id: http://core.svn.wordpress.org/trunk@47314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 19:11:07 +00:00
Sergey Biryukov 402193798e Twenty Nineteen: Update `style-editor.css` after [47327]. 
Props ianbelanger.
See #48526.
Built from https://develop.svn.wordpress.org/trunk@47537


git-svn-id: http://core.svn.wordpress.org/trunk@47312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 18:57:11 +00:00
Sergey Biryukov 116d909f58 Twenty Nineteen: Update `style-rtl.css` after [47339]. 
Props ianbelanger.
See #49410.
Built from https://develop.svn.wordpress.org/trunk@47536


git-svn-id: http://core.svn.wordpress.org/trunk@47311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 18:55:10 +00:00
Sergey Biryukov 042bf6dbd9 Administration: Make the height of dashboard widget headings consistent with that of post meta boxes on smaller screens. 
This also ensures that the toggle arrow for dashboard widgets is properly aligned.

Props chetan200891.
Fixes #49727.
Built from https://develop.svn.wordpress.org/trunk@47535


git-svn-id: http://core.svn.wordpress.org/trunk@47310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 02:52:07 +00:00
ianbelanger 2e7235f7ca Bundled Themes: Twenty Twenty Button block forces All Capital letters - revert [47531]. 
Reverts [47531] to add `text-transform: uppercase;` back to button blocks.

Props joyously.
Fixes #49710.
Built from https://develop.svn.wordpress.org/trunk@47534


git-svn-id: http://core.svn.wordpress.org/trunk@47309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 18:29:08 +00:00
Sergey Biryukov e38a57db0c Help/About: Use CDN URLs for 5.4 About page header images. 
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47532


git-svn-id: http://core.svn.wordpress.org/trunk@47307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 17:49:07 +00:00
ianbelanger 340216b5eb Bundled Themes: Twenty Twenty Button block forces All Capital letters. 
Removes `text-transform: uppercase;` from button blocks in order to give the user the option to have a button without All Capital letters.

Props mukesh27.
Fixes #49710.
Built from https://develop.svn.wordpress.org/trunk@47531


git-svn-id: http://core.svn.wordpress.org/trunk@47306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 15:20:07 +00:00
Sergey Biryukov 49d7b8c51f Filesystem API: Correct punctuation in `request_filesystem_credentials()` error message. 
Props mayankmajeji, kharisblank.
Fixes #49724.
Built from https://develop.svn.wordpress.org/trunk@47530


git-svn-id: http://core.svn.wordpress.org/trunk@47305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 01:32:07 +00:00
Sergey Biryukov c83710ccee Site Health: Remove paragraph tag from the actions container in issue template. 
Most of the tests pass content that is already wrapped in a paragraph or list tags, thus producing nested paragraphs or invalid markup.

Additionally, don't output an empty `<div>` tag if the test does not provide any actions.

Props maxpertici, afercia.
Fixes #48948.
Built from https://develop.svn.wordpress.org/trunk@47529


git-svn-id: http://core.svn.wordpress.org/trunk@47304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 01:25:11 +00:00
Sergey Biryukov 764a1761aa Site Health: Correct markup in `::get_test_php_extensions()` and `::get_test_background_updates()` description. 
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.

Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.

Props afercia.
See #48948.
Built from https://develop.svn.wordpress.org/trunk@47528


git-svn-id: http://core.svn.wordpress.org/trunk@47303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-29 03:46:06 +00:00
Sergey Biryukov d552e475fd Site Health: Add pretty links support information to debug data. 
Props valentinbora, afragen.
Fixes #49422.
Built from https://develop.svn.wordpress.org/trunk@47527


git-svn-id: http://core.svn.wordpress.org/trunk@47302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-28 21:20:06 +00:00
John Blackbourn 8f1eddef11 Comments: Ensure all elements in the array returned by `get_comment_count()` are integers. 
Previously elements would be a mixture of strings and integers depending on their numeric value.

Props progremzion, m.usama.masood

Fixes #48093
Built from https://develop.svn.wordpress.org/trunk@47526


git-svn-id: http://core.svn.wordpress.org/trunk@47301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-28 20:44:09 +00:00
Sergey Biryukov ce2dea9ef6 Help/About: Improve accessibility of the 5.4 About page: 
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.

Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47521


git-svn-id: http://core.svn.wordpress.org/trunk@47296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 23:41:06 +00:00
Sergey Biryukov a546a9c35c Coding Standards: Remove some extra tabs in `wp-admin/user-new.php`. 
Follow-up to [47516], [47519].

See #38665.
Built from https://develop.svn.wordpress.org/trunk@47520


git-svn-id: http://core.svn.wordpress.org/trunk@47295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 22:30:09 +00:00
Sergey Biryukov ee1bf5a911 Coding Standards: Fix WPCS issues in [47516]. 
See #38665.
Built from https://develop.svn.wordpress.org/trunk@47519


git-svn-id: http://core.svn.wordpress.org/trunk@47294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 22:25:08 +00:00
jorgefilipecosta 0a2dad400d Block Editor: Update WordPress Packages WordPress 5.4 RC 5 Take 2. 
The following package versions were changed:
@wordpress/edit-post: 3.13.8 -> 3.13.9
Includes PR https://github.com/WordPress/gutenberg/pull/21220

Props aduth, mapk, ItsJonQ.
Fixes: #49717.
Built from https://develop.svn.wordpress.org/trunk@47517


git-svn-id: http://core.svn.wordpress.org/trunk@47292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 22:08:24 +00:00
John Blackbourn 41ae74f7b4 Users: Add a user language preference option to the "Add New User" form. 
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.

Props barryceelen, johnbillion

Fixes #38665
Built from https://develop.svn.wordpress.org/trunk@47516


git-svn-id: http://core.svn.wordpress.org/trunk@47291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 21:58:05 +00:00
Sergey Biryukov 38e37b83df Site Health: Remove `esc_url()` used on "Debugging in WordPress" article URL in `WP_Fatal_Error_Handler::display_default_error_template()`. 
The function may not be available in some contexts, for example if a fatal error happens in `advanced-cache.php` drop-in.

Props rob006.
Fixes #49709.
Built from https://develop.svn.wordpress.org/trunk@47515


git-svn-id: http://core.svn.wordpress.org/trunk@47290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 18:22:06 +00:00
jorgefilipecosta b9ef707d7d Block Editor: Update WordPress Packages WordPress 5.4 RC 5. 
The following package versions were changed:
@wordpress/annotations: 1.12.2 -> 1.12.3
@wordpress/block-directory: 1.5.6 -> 1.5.7
@wordpress/block-editor: 3.7.6 -> 3.7.7
@wordpress/block-library: 2.14.6 -> 2.14.7
@wordpress/blocks: 6.12.2 -> 6.12.3
@wordpress/components: 9.2.5 -> 9.2.6
@wordpress/core-data: 2.12.2 -> 2.12.3
@wordpress/edit-post: 3.13.7 -> 3.13.8
@wordpress/editor: 9.12.6 -> 9.12.7
@wordpress/format-library: 1.14.6 -> 1.14.7
@wordpress/list-reusable-blocks: 1.13.5 -> 1.13.6
@wordpress/nux: 3.12.5 -> 3.12.6
@wordpress/server-side-render: 1.8.5 -> 1.8.6
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21210.

Props mcsf, aduth.
Fixes: #49716.
Built from https://develop.svn.wordpress.org/trunk@47513


git-svn-id: http://core.svn.wordpress.org/trunk@47288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 18:10:36 +00:00
Sergey Biryukov f4f1184deb Build/Test Tools: Update QUnit and Sinon to the latest versions. 
Update JS tests per the QUnit 2.x Upgrade Guide.

Fixes #37117.
Built from https://develop.svn.wordpress.org/trunk@47512


git-svn-id: http://core.svn.wordpress.org/trunk@47287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 00:18:22 +00:00
K. Adam White 58d5aad2a3 REST API: Fix _fields filtering of registered rest fields. 
Use rest_is_field_included when determining which additional fields to include to permit filtering by nested field properties.

Props Dudo, kadamwhite, TimothyBlynJacobs.
Fixes #49648.

Built from https://develop.svn.wordpress.org/trunk@47511


git-svn-id: http://core.svn.wordpress.org/trunk@47286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 17:52:16 +00:00
John Blackbourn 7dbad241cb Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area. 
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.

Props rebasaurus

Fixes #49268
Built from https://develop.svn.wordpress.org/trunk@47510


git-svn-id: http://core.svn.wordpress.org/trunk@47285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 17:50:15 +00:00
John Blackbourn 33d4f0573c Query: Introduce an action which gets fired when a 404 is triggered. 
Fixes #48061
Built from https://develop.svn.wordpress.org/trunk@47509


git-svn-id: http://core.svn.wordpress.org/trunk@47284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 17:43:07 +00:00
Sergey Biryukov b9869da157 Coding Standards: Fix WPCS issues in `wp-includes/class-wp-http-proxy.php`. 
Props thrijith, mukesh27.
Fixes #46784.
Built from https://develop.svn.wordpress.org/trunk@47508


git-svn-id: http://core.svn.wordpress.org/trunk@47283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 07:20:10 +00:00
Sergey Biryukov 2b030a1647 Docs: Add documentation for `WP_Comments_List_Table::floated_admin_avatar()`. 
Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov.
Fixes #41491.
Built from https://develop.svn.wordpress.org/trunk@47507


git-svn-id: http://core.svn.wordpress.org/trunk@47282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-25 14:43:11 +00:00
noisysocks b4e1e8f0d1 Comments: Fix title not updating when replying to a comment 
When replying to an existing comment, the comment form is moved to below the
existing comment with JS, but the form heading was not being updated. This
fixes the issue by introducing a new data-attribute to the reply link with the
correct heading string, and applying that string to the heading when the form
is moved.

Props isabel_brison, azaozz, peterwilsoncc.
Fixes #38009.

Built from https://develop.svn.wordpress.org/trunk@47506


git-svn-id: http://core.svn.wordpress.org/trunk@47281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-25 04:55:10 +00:00
Sergey Biryukov 55482506a3 Docs: Revert a type change for the `$value` parameter of `WP_Dependencies::add_data()` in [47170]. 
Although described as a string in several places, it's technically not limited to a particular type.

Props westonruter.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47502


git-svn-id: http://core.svn.wordpress.org/trunk@47277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 20:56:09 +00:00
jorgefilipecosta 26cc999d64 Help/About: Fix a typo on the about page and fix a link. 
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.

Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47500


git-svn-id: http://core.svn.wordpress.org/trunk@47275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 15:03:08 +00:00
Sergey Biryukov c4a852af51 Docs: Update inline comment in `Tests_DB::test_locale_floats()`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47498


git-svn-id: http://core.svn.wordpress.org/trunk@47273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 01:08:06 +00:00
Andrew Ozz e3b3b5c1b7 Build/Test Tools: Introduce Install-changed. It keeps a hash of `package.json` and compares it when run. If it has any changes, it runs `npm install`. 
This keeps `node_modules` always updated and is useful not only when the packages have been updated, but also when the working copy has been "reverted" to an earlier revision.

Fixes #49594.
Built from https://develop.svn.wordpress.org/trunk@47497


git-svn-id: http://core.svn.wordpress.org/trunk@47272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 01:06:34 +00:00
Andrew Ozz 6ea351bed7 Build/Test Tools: Fix PHPUnit bootstrap to install WP from `/build` when tests are run with `npm run test`, `grunt test`, `grunt` then `phpunit`, etc. 
Fixes #49663.
Built from https://develop.svn.wordpress.org/trunk@47496


git-svn-id: http://core.svn.wordpress.org/trunk@47271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 00:20:06 +00:00
jorgefilipecosta 61ddc8d582 Block Editor: Update WordPress Packages WordPress 5.4 RC 4. 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.
Built from https://develop.svn.wordpress.org/trunk@47495


git-svn-id: http://core.svn.wordpress.org/trunk@47270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-23 23:40:19 +00:00
Sergey Biryukov 3ec189f978 Docs: Add missing `@since` tags for `WP_User_Request` properties. 
Correct type for `$email`, `$confirmed_timestamp`, and `$completed_timestamp` properties.

Props pbiron, garrett-eclipse.
Fixes #49675.
Built from https://develop.svn.wordpress.org/trunk@47494


git-svn-id: http://core.svn.wordpress.org/trunk@47269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-23 20:20:09 +00:00
Sergey Biryukov 5ce4cc4930 Administration: Add `/` character to `<img>` tag in `WP_Plugin_Install_List_Table::display_rows()`. 
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Props adnan.limdi, Soean.
Fixes #41904.
Built from https://develop.svn.wordpress.org/trunk@47493


git-svn-id: http://core.svn.wordpress.org/trunk@47268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-23 03:03:07 +00:00
Sergey Biryukov 248a115c2b Upgrade/Install: Return a more appropriate HTTP response status code (`409 Conflict`) if the `wp-config.php` file already exists. 
Props linyows, ocean90.
Fixes #42466.
Built from https://develop.svn.wordpress.org/trunk@47478


git-svn-id: http://core.svn.wordpress.org/trunk@47267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-21 15:44:15 +00:00
Sergey Biryukov 77e32cff47 Coding Standards: Fix WPCS issue in [47475]. 
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47476


git-svn-id: http://core.svn.wordpress.org/trunk@47265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-20 17:33:07 +00:00
Sergey Biryukov 8f31a95982 Help/About: Add design for 5.4 About page. 
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47475


git-svn-id: http://core.svn.wordpress.org/trunk@47264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-20 17:13:10 +00:00
Sergey Biryukov 2fd80efe13 Administration: Escape admin title on output after the `admin_title` filter runs, not before. 
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921.
Built from https://develop.svn.wordpress.org/trunk@47474


git-svn-id: http://core.svn.wordpress.org/trunk@47261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-20 02:20:08 +00:00
Sergey Biryukov ed01dbb89b Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens. 
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570.
Built from https://develop.svn.wordpress.org/trunk@47473


git-svn-id: http://core.svn.wordpress.org/trunk@47260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-19 20:45:10 +00:00
Sergey Biryukov c6c8862b87 Post Formats: Pass post type to the `disable_formats_dropdown` filter in `WP_Posts_List_Table::formats_dropdown()`. 
Props MatheusFD, birgire.
Fixes #47959.
Built from https://develop.svn.wordpress.org/trunk@47472


git-svn-id: http://core.svn.wordpress.org/trunk@47259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-18 19:13:10 +00:00
Andrew Ozz e94cd4e1a0 Build Tools: Use the new `combinedOutputFile` setting for the updated DependencyExtractionWebpackPlugin and output `script-loader-packages.php` directly in `wp-includes/assets/`. 
Props gziolo, azaozz.
See: #48154.
Built from https://develop.svn.wordpress.org/trunk@47471


git-svn-id: http://core.svn.wordpress.org/trunk@47258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-18 04:50:10 +00:00
Sergey Biryukov dd12e83491 Docs: Correct the description of `$hard` parameter in `flush_rewrite_rules()`. 
Props david.binda.
Fixes #49660.
Built from https://develop.svn.wordpress.org/trunk@47468


git-svn-id: http://core.svn.wordpress.org/trunk@47255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-17 19:34:08 +00:00
jorgefilipecosta 7c8f8d776f Block Editor: Update WordPress Packages WordPress 5.4 RC 3. 
The following package versions were changed:
@wordpress/block-directory: 1.5.4 -> 1.5.5
@wordpress/block-editor: 3.7.4 -> 3.7.5
@wordpress/block-library: 2.14.4 -> 2.14.5
@wordpress/components: 9.2.3 -> 9.2.4
@wordpress/dependency-extraction-webpack-plugin: 2.3.0 -> 2.4.0
@wordpress/edit-post: 3.13.5 -> 3.13.6
@wordpress/editor: 9.12.4 -> 9.12.5
@wordpress/format-library: 1.14.4 -> 1.14.5
@wordpress/list-reusable-blocks: 1.13.3 -> 1.13.4
@wordpress/nux: 3.12.3 -> 3.12.4
@wordpress/server-side-render: 1.8.3 -> 1.8.4

Props aduth.
Fixes: #49657.
Built from https://develop.svn.wordpress.org/trunk@47462


git-svn-id: http://core.svn.wordpress.org/trunk@47249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 22:07:16 +00:00
John Blackbourn 7004afe4f4 Docs: Various docblock corrections and improvements. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@47461


git-svn-id: http://core.svn.wordpress.org/trunk@47248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 18:40:07 +00:00
Sergey Biryukov 0a08229a9b Tests: Use `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` environment variable instead of config setting. 
This is more consistent with the similar approach in Gutenberg Travis setup.

Follow-up to [47449].

See #49621.
Built from https://develop.svn.wordpress.org/trunk@47459


git-svn-id: http://core.svn.wordpress.org/trunk@47246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 12:24:09 +00:00
Sergey Biryukov 25333cc670 Menus: When adding a label for special pages in `wp_setup_nav_menu_item()` strip all HTML tags, as the label is escaped on output. 
Follow-up to [47211], [47213].

Props stiofansisland.
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47458


git-svn-id: http://core.svn.wordpress.org/trunk@47245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 01:32:05 +00:00
Sergey Biryukov 73ef224e64 Administration: When editing a plugin or theme file, close any active PHP session. 
This prevents HTTP requests from timing out when attempting to connect back to the site.

Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358.
Built from https://develop.svn.wordpress.org/trunk@47457


git-svn-id: http://core.svn.wordpress.org/trunk@47244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-15 19:45:07 +00:00
Sergey Biryukov cf75b95197 Site Health: Run the first scheduled site health check a day after the initial site setup. 
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.

Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577.
Built from https://develop.svn.wordpress.org/trunk@47456


git-svn-id: http://core.svn.wordpress.org/trunk@47243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-14 16:36:07 +00:00
Sergey Biryukov dacd7a55ea Toolbar: Move the logic for rendering the admin bar on `wp_footer` to `wp_admin_bar_render()`. 
Clarify in the function documentation that it is now called on `wp_body_open` action first, with `wp_footer` as a fallback.

Follow-up to [47221].

Fixes #47053.
Built from https://develop.svn.wordpress.org/trunk@47455


git-svn-id: http://core.svn.wordpress.org/trunk@47242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-14 16:01:08 +00:00
Sergey Biryukov d5f942d7ba General: Trim the input data in `maybe_unserialize()`, for consistency with `is_serialized()`. 
Props pbearne, mikeschroder.
Fixes #36416.
Built from https://develop.svn.wordpress.org/trunk@47454


git-svn-id: http://core.svn.wordpress.org/trunk@47241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-13 21:13:08 +00:00
Sergey Biryukov 0dc46c0ba5 General: Move `maybe_serialize()` to a more appropriate place in the file, before `maybe_unserialize()`. 
Rename the `$original` parameter of `maybe_unserialize()` to `$data`, for consistency with other serialization functions.

See #36416.
Built from https://develop.svn.wordpress.org/trunk@47453


git-svn-id: http://core.svn.wordpress.org/trunk@47240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-13 21:07:06 +00:00
Sergey Biryukov 045d4face1 Tests: Extract `is_serialized()` test cases into data providers; reuse them for `maybe_serialize()` and `maybe_unserialize()` tests. 
Props pbearne, mikeschroder, SergeyBiryukov.
See #36416.
Built from https://develop.svn.wordpress.org/trunk@47452


git-svn-id: http://core.svn.wordpress.org/trunk@47239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-13 20:41:07 +00:00
Sergey Biryukov c8cc78671b Database: Introduce `wpdb::db_server_info()` to retrieve full MySQL server information string as supplied by `mysqli_get_server_info()`. 
This complements `wpdb::db_version()`, which only returns a numeric version string and strips any additional information, e.g. vendor name.

Props clarinetlord, birgire, webaware, pento.
Fixes #40037. See #27703.
Built from https://develop.svn.wordpress.org/trunk@47451


git-svn-id: http://core.svn.wordpress.org/trunk@47238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-12 15:55:07 +00:00
TimothyBlynJacobs 1367b1175f REST API: Introduce "hex-color" JSON Schema format. 
Props spacedmonkey, chrisvanpatten.
Fixes #49270.

Built from https://develop.svn.wordpress.org/trunk@47450


git-svn-id: http://core.svn.wordpress.org/trunk@47237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-12 02:42:08 +00:00
Sergey Biryukov bcb8ee6dcf Tests: Download Chromium for e2e tests only. 
This reduces the chance of random failures due to network timeouts and avoids the overhead of unnecessarily downloading ~120 MB for PHP or JS tests.

Fixes #49621.
Built from https://develop.svn.wordpress.org/trunk@47449


git-svn-id: http://core.svn.wordpress.org/trunk@47236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-11 02:03:11 +00:00
Peter Wilson a88ac4f003 Media: Introduce preflight filter to `wp_delete_attachment()`. 
Introduces the filter `pre_delete_attachment` to allow developers to prevent or modify the deletion of attachments. This improves consistency with `wp_delete_post()` and `wp_trash_post()`.

Props joemcgill, peterwilsoncc.
Fixes #49597.

Built from https://develop.svn.wordpress.org/trunk@47448


git-svn-id: http://core.svn.wordpress.org/trunk@47235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 22:48:07 +00:00
Sergey Biryukov 9aa864f1a7 Bundled Themes: Update calendar widget styles for 5.4 markup to fix the alignment of a single month link. 
Follow-up to [47405].

Props sabernhardt.
Reviewed by ianbelanger, SergeyBiryukov.
Fixes #49549.
Built from https://develop.svn.wordpress.org/trunk@47444


git-svn-id: http://core.svn.wordpress.org/trunk@47231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 20:53:06 +00:00
Sergey Biryukov 70def7fc4a Help/About: Use consistent vertical whitespace between sections on Freedoms page. 
Props chetan200891.
Fixes #49619.
Built from https://develop.svn.wordpress.org/trunk@47443


git-svn-id: http://core.svn.wordpress.org/trunk@47230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 20:39:16 +00:00
jorgefilipecosta da43022d3f Block Editor: Update WordPress Packages WordPress 5.4 RC 2. 
The following package versions were changed:
@wordpress/block-directory: 1.5.3 -> 1.5.4
@wordpress/block-editor: 3.7.3 -> 3.7.4
@wordpress/block-library: 2.14.3 -> 2.14.4
@wordpress/edit-post: 3.13.4 -> 3.13.5
@wordpress/editor: 9.12.3 -> 9.12.4
@wordpress/format-library: 1.14.3 -> 1.14.4

Props aduth, gziolo, mapk.
Fixes: #49611.
Built from https://develop.svn.wordpress.org/trunk@47441


git-svn-id: http://core.svn.wordpress.org/trunk@47228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 14:53:18 +00:00
ianbelanger 4c1b25b5cc Bundled Themes: Twenty Twenty content font CSS selector is too important - updated. 
This adds more selectors for headings, tables, addresses, cite, figcaption, file and caption blocks to make the font-family match as before [47133].

Props alexandreb3, SergeyBiryukov.
Fixes #49318.
Built from https://develop.svn.wordpress.org/trunk@47439


git-svn-id: http://core.svn.wordpress.org/trunk@47226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-09 19:48:07 +00:00
Sergey Biryukov d8a0b6ef2c Help/About: Update and correct some strings for 5.4 About page. 
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47436


git-svn-id: http://core.svn.wordpress.org/trunk@47223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-09 00:11:04 +00:00
Sergey Biryukov 9448f5c95e Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens. 
Props sagarjadhav, valentinbora.
Fixes #31783.
Built from https://develop.svn.wordpress.org/trunk@47435


git-svn-id: http://core.svn.wordpress.org/trunk@47222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-08 01:52:05 +00:00
Sergey Biryukov cb5308b0ab Administration: Add missing description for "Page title" element of the admin menu array. 
Props ajoah, valentinbora, kaitlin414.
Fixes #42911.
Built from https://develop.svn.wordpress.org/trunk@47434


git-svn-id: http://core.svn.wordpress.org/trunk@47221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-08 00:18:05 +00:00
Sergey Biryukov 9fbd842eb2 Customize: Ensure color picker's Clear button is aligned properly. 
Props Cybr.
Fixes #49543.
Built from https://develop.svn.wordpress.org/trunk@47433


git-svn-id: http://core.svn.wordpress.org/trunk@47220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-07 01:13:06 +00:00
Sergey Biryukov d6178e1dcf REST API: Fix typo in `disable-custom-gradients` theme feature description. 
Props Ipstenu, tobifjellner, pixelverbieger.
Reviewed by ocean90, johnbillion, SergeyBiryukov.
Fixes #49585.
Built from https://develop.svn.wordpress.org/trunk@47432


git-svn-id: http://core.svn.wordpress.org/trunk@47219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-06 00:17:05 +00:00
Sergey Biryukov 6b1e845fca Tests: Remove unnecessary use of `wpdb_exposed_methods_for_testing` in `test_utf8mb3_post_saves_with_emoji()`. 
Props clarinetlord.
Fixes #39998.
Built from https://develop.svn.wordpress.org/trunk@47431


git-svn-id: http://core.svn.wordpress.org/trunk@47218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-05 11:55:05 +00:00
Sergey Biryukov 4b64d587a5 General: Ensure `get_tag_regex()` always returns a string, to match the documented value. 
Props subrataemfluence.
Fixes #45643.
Built from https://develop.svn.wordpress.org/trunk@47430


git-svn-id: http://core.svn.wordpress.org/trunk@47217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 12:05:05 +00:00
Sergey Biryukov eea1fd30c2 General: Correct the default value of the `$defaults` parameter in `wp_parse_args()` to match the documented type. 
Props subrataemfluence.
See #45643.
Built from https://develop.svn.wordpress.org/trunk@47429


git-svn-id: http://core.svn.wordpress.org/trunk@47216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 12:00:06 +00:00
Sergey Biryukov 4a00ea1127 Docs: Reorder `@throws` tags in `WP_Customize_Nav_Menu_Setting` and `WP_Customize_Nav_Menu_Item_Setting` for consistency with `WP_Customize_Custom_CSS_Setting`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47428


git-svn-id: http://core.svn.wordpress.org/trunk@47215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 11:36:06 +00:00
Sergey Biryukov 57e91eb89a Docs: Add missing `@throws` tag to `_wp_json_sanity_check()` DocBlock. 
Props subrataemfluence.
See #45643.
Built from https://develop.svn.wordpress.org/trunk@47427


git-svn-id: http://core.svn.wordpress.org/trunk@47214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 11:34:08 +00:00
Peter Wilson 8483056ea1 Trunk is now 5.5 alpha 
Built from https://develop.svn.wordpress.org/trunk@47426


git-svn-id: http://core.svn.wordpress.org/trunk@47213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 01:20:11 +00:00
jorgefilipecosta 3227238b36 Post WordPress 5.4 RC 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@47424


git-svn-id: http://core.svn.wordpress.org/trunk@47211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 22:02:05 +00:00
jorgefilipecosta 4510afa73e WordPress 5.4 RC 1. 
Built from https://develop.svn.wordpress.org/trunk@47423


git-svn-id: http://core.svn.wordpress.org/trunk@47210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 21:43:06 +00:00
Sergey Biryukov 293bc81bf6 Help/About: Add strings for 5.4 About page. 
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47422


git-svn-id: http://core.svn.wordpress.org/trunk@47209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 21:22:07 +00:00
jorgefilipecosta 86bafc002d Editor: Update WordPress packages to make editor full-screen by default. 
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.
Built from https://develop.svn.wordpress.org/trunk@47421


git-svn-id: http://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 20:45:08 +00:00
Sergey Biryukov 18e3aa433c Privacy: Prevent unexpected scrolling when clicking the "Copy this section to clipboard" button on Privacy Policy Guide screen. 
Props garrett-eclipse, birgire, davidbaumwald, pbiron.
Fixes #49540.
Built from https://develop.svn.wordpress.org/trunk@47420


git-svn-id: http://core.svn.wordpress.org/trunk@47207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 17:51:05 +00:00
Sergey Biryukov c30fd0b54d Media: Improve the appearance of image editor on small and medium screens. 
This prevents the main area of Edit Media screen from being pushed down too far.

Props sabernhardt, afercia, fierevere, sathyapulse, mikeschroder, johnbillion.
Fixes #48780. See #47136.
Built from https://develop.svn.wordpress.org/trunk@47418


git-svn-id: http://core.svn.wordpress.org/trunk@47205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 17:21:05 +00:00
jorgefilipecosta cf40905ada Scripts: Use core-js url as polyfill for window.URL. 
URL polyfill from the polyfill-library library is not spec-conformant, in a way which negatively impacts its usability for pending revisions to the block editor. Specifically, there were revisions to the implementation of the wp-url script to detect URL validity by relying on thrown errors from the URL constructor, but this specific behavior is not implemented in this version of the polyfill.
There was another issue in r47238, which is that the test used to check whether the polyfill should be included is not accurate. This commit uses a different check and fixes the issue.

Props aduth.
Fixes: #49360.
Built from https://develop.svn.wordpress.org/trunk@47416


git-svn-id: http://core.svn.wordpress.org/trunk@47203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 16:55:07 +00:00
Sergey Biryukov 62ef2d6719 Site Health: Fix typo in Site Health Status dashboard widget. 
Follow-up to [47063], [47413].

Props Clorith, dlh.
See #49562.
Built from https://develop.svn.wordpress.org/trunk@47415


git-svn-id: http://core.svn.wordpress.org/trunk@47202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 12:22:07 +00:00
Sergey Biryukov a9479f31d1 Docs: Correct formatting of some DocBlocks in `Plugin_Upgrader` and `Theme_Upgrader` per the documentation standards. 
See #49400.
Built from https://develop.svn.wordpress.org/trunk@47414


git-svn-id: http://core.svn.wordpress.org/trunk@47201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 11:39:08 +00:00
Sergey Biryukov ab854ce518 Site Health: Improve the strings in Site Health Status dashboard widget. 
Follow-up to [47063].

Props dlh.
Fixes #49562.
Built from https://develop.svn.wordpress.org/trunk@47413


git-svn-id: http://core.svn.wordpress.org/trunk@47200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 11:21:07 +00:00
John Blackbourn 24567bf775 Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens. 
Props Jurgen Oldenburg, garrett-eclipse

Fixes #49476
Built from https://develop.svn.wordpress.org/trunk@47412


git-svn-id: http://core.svn.wordpress.org/trunk@47199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:50:06 +00:00
John Blackbourn e12cca1ce8 Privacy: Reintroduce consistency to the styling of suggested privacy text from core and plugins. 
Props garrett-eclipse

Fixes #49282
Built from https://develop.svn.wordpress.org/trunk@47411


git-svn-id: http://core.svn.wordpress.org/trunk@47198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:42:06 +00:00
John Blackbourn da52485cf1 Editor: Revert a fix for incorrect usage of ID attributes on custom fields. 
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.

See #46964
Built from https://develop.svn.wordpress.org/trunk@47410


git-svn-id: http://core.svn.wordpress.org/trunk@47197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:37:06 +00:00
John Blackbourn 9860470360 Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality. 
Props bookdude13

See #49400
Built from https://develop.svn.wordpress.org/trunk@47409


git-svn-id: http://core.svn.wordpress.org/trunk@47196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:29:06 +00:00
jorgefilipecosta cc17fee089 Block Editor: Update WordPress Packages WordPress 5.4 RC 1. 
The following package versions were changed:
@wordpress/annotations: 1.12.0 -> 1.12.1
@wordpress/block-directory: 1.5.2 -> 1.5.3
@wordpress/block-editor: 3.7.2 -> 3.7.3
@wordpress/block-library: 2.14.2 -> 2.14.3
@wordpress/blocks: 6.12.0 -> 6.12.1
@wordpress/components: 9.2.2 -> 9.2.3
@wordpress/core-data: 2.12.0 -> 2.12.1
@wordpress/data: 4.14.0 -> 4.14.1
@wordpress/data-controls: 1.8.0 -> 1.8.1
@wordpress/edit-post: 3.13.2 -> 3.13.3
@wordpress/editor: 9.12.2 -> 9.12.3
@wordpress/format-library: 1.14.2 -> 1.14.3
@wordpress/keyboard-shortcuts: 1.1.0 -> 1.1.1
@wordpress/list-reusable-blocks: 1.13.2 -> 1.13.3
@wordpress/notices: 2.0.0 -> 2.0.1
@wordpress/nux: 3.12.2 -> 3.12.3
@wordpress/priority-queue: 1.5.0 -> 1.5.1
@wordpress/rich-text: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.2 -> 1.8.3
@wordpress/viewport: 2.13.0 -> 2.13.1

Props aduth.
Fixes: #49567.
Built from https://develop.svn.wordpress.org/trunk@47408


git-svn-id: http://core.svn.wordpress.org/trunk@47195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 23:21:15 +00:00
Andrew Ozz aa8d4257ea Build Tools: Exclude the `src/wp-includes/assets/` directory from copying when building. Its content is generated by Webpack and copied in another task. 
See #48154.
Built from https://develop.svn.wordpress.org/trunk@47407


git-svn-id: http://core.svn.wordpress.org/trunk@47194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 19:10:06 +00:00
John Blackbourn aed09845b2 Feeds: Remove an unreachable condition when generating archive feed links. 
Props donmhico, pbiron

Fixes #48427
Built from https://develop.svn.wordpress.org/trunk@47406


git-svn-id: http://core.svn.wordpress.org/trunk@47193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 18:52:04 +00:00
ianbelanger 27a52dec3e Bundled Themes: Update calendar widget styles for 5.4 markup. 
Fixes the alignment of month links in the calendar widget with the changes in version 5.4 for all Bundled Themes, except Twenty Thirteen, which was already fixed in #49546.

Props sabernhardt.
Fixes #49549.
Built from https://develop.svn.wordpress.org/trunk@47405


git-svn-id: http://core.svn.wordpress.org/trunk@47192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 16:55:08 +00:00
Sergey Biryukov 26e1072d65 Build/Test Tools: Bump devDependencies for WordPress 5.4. 
Props ayeshrajans, garrett-eclipse.
Fixes #49547.
Built from https://develop.svn.wordpress.org/trunk@47404


git-svn-id: http://core.svn.wordpress.org/trunk@47191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 01:54:13 +00:00
Sergey Biryukov b193d0a34b Tests: Add a unit test to ensure the "Supported Versions" section of GitHub Security Policy always includes the latest stable branch. 
See #48667, #48521.
Built from https://develop.svn.wordpress.org/trunk@47403


git-svn-id: http://core.svn.wordpress.org/trunk@47190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 01:13:03 +00:00
Sergey Biryukov e041a3a8f3 Docs: Use more specific type in parameter descriptions for `is_page()`, `is_single()`, `is_singular()`, and their `WP_Query` counterpart methods. 
Props marekdedic, shaharia.azam, shaampk1.
Fixes #48354. See #48303.
Built from https://develop.svn.wordpress.org/trunk@47402


git-svn-id: http://core.svn.wordpress.org/trunk@47189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 17:29:06 +00:00
Sergey Biryukov abce2d8d6c Docs: Synchronize parameter descriptions for conditional tags with their `WP_Query` counterpart methods. 
See #48354, #48303.
Built from https://develop.svn.wordpress.org/trunk@47401


git-svn-id: http://core.svn.wordpress.org/trunk@47188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 17:21:06 +00:00
Sergey Biryukov f82fd2c436 Docs: Use more specific type in parameter description for `wp_unslash()`. 
Props marekdedic.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47400


git-svn-id: http://core.svn.wordpress.org/trunk@47187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 16:26:05 +00:00
Sergey Biryukov 7ca7727ec0 Docs: Use more specific type in description for `_WP_Dependency::$deps`. 
Props marekdedic.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47399


git-svn-id: http://core.svn.wordpress.org/trunk@47186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 16:24:04 +00:00
John Blackbourn 251d77e1a1 Docs: Miscellaneous docs fixes and improvements. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47398


git-svn-id: http://core.svn.wordpress.org/trunk@47185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 10:40:07 +00:00
John Blackbourn 056dad9c2c Docs: Use more specific types in parameter descriptions in place of `mixed`. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47397


git-svn-id: http://core.svn.wordpress.org/trunk@47184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 10:38:07 +00:00
John Blackbourn bf8c4ee5c6 Docs: Correct the parameter documentation of the `request_filesystem_credentials` filter. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@47396


git-svn-id: http://core.svn.wordpress.org/trunk@47183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 10:33:04 +00:00
Sergey Biryukov fcff974c33 Privacy: Make the progress indicator for export and erasure visible even if not hovered over. 
Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.
Built from https://develop.svn.wordpress.org/trunk@47395


git-svn-id: http://core.svn.wordpress.org/trunk@47182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-29 23:45:07 +00:00
John Blackbourn 46674e2367 Docs: Correct and improve the docs for some media related functions. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@47394


git-svn-id: http://core.svn.wordpress.org/trunk@47181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-29 16:49:07 +00:00
ianbelanger 7f26b262b2 Bundled Themes: Twenty Twenty searchform.php error. 
Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.
Built from https://develop.svn.wordpress.org/trunk@47393


git-svn-id: http://core.svn.wordpress.org/trunk@47180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 20:56:06 +00:00
ianbelanger 3bfa7b9ef9 Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup. 
Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.
Built from https://develop.svn.wordpress.org/trunk@47392


git-svn-id: http://core.svn.wordpress.org/trunk@47179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 20:07:07 +00:00
Sergey Biryukov cbe5f9963a Docs: Improve documentation for `WP_REST_Attachments_Controller`. 
This adds a missing DocBlock for `::register_routes()` and parameter descriptions for `::post_process_item()`.

Includes minor documenation fixes in other REST API classes for consistency.

Props dkarfa, mukesh27, SergeyBiryukov.
Fixes #48841.
Built from https://develop.svn.wordpress.org/trunk@47391


git-svn-id: http://core.svn.wordpress.org/trunk@47178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 12:31:08 +00:00
Sergey Biryukov eb524c0b38 Docs: Improve documentation for various metadata functions. 
This adds a more specific description for accepted object types: `post`, `comment`, `term`, `user`, or any other object type with an associated meta table.

Props sheparddw, kraftbj, DrewAPicture, SergeyBiryukov.
Fixes #45464.
Built from https://develop.svn.wordpress.org/trunk@47390


git-svn-id: http://core.svn.wordpress.org/trunk@47177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 12:14:08 +00:00
Sergey Biryukov 32be7d6460 Coding Standards: Update PHPCS Composer plugin to v0.6.0. 
Release log: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.6.0

Props jrf.
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47389


git-svn-id: http://core.svn.wordpress.org/trunk@47176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 01:40:05 +00:00
Sergey Biryukov 19268546a5 Twenty Twenty: Replace quotation marks in starter content with HTML entities. 
Props fahimmurshed.
Fixes #49534.
Built from https://develop.svn.wordpress.org/trunk@47388


git-svn-id: http://core.svn.wordpress.org/trunk@47175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 22:00:07 +00:00
Sergey Biryukov 50afd0aa1b Docs: Add a reference to `WP_Customize_Panel::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_panel()`. 
Synchronize the documentation between two places, use `WP_Customize_Panel::__construct()` as the canonical source.

Props iaaxpage, marekdedic.
Fixes #48344.
Built from https://develop.svn.wordpress.org/trunk@47387


git-svn-id: http://core.svn.wordpress.org/trunk@47174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:36:07 +00:00
Sergey Biryukov 9043b9833f Docs: Add a reference to `WP_Customize_Section::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_section()`. 
Synchronize the documentation between two places, use `WP_Customize_Section::__construct()` as the canonical source.

Props amolv, marekdedic.
Fixes #48346.
Built from https://develop.svn.wordpress.org/trunk@47386


git-svn-id: http://core.svn.wordpress.org/trunk@47173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:29:06 +00:00
Sergey Biryukov 569319f553 Docs: Clarify the type of `theme_supports` argument in various Customizer classes. 
Props marekdedic.
See #48347.
Built from https://develop.svn.wordpress.org/trunk@47385


git-svn-id: http://core.svn.wordpress.org/trunk@47172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:23:06 +00:00
Sergey Biryukov 8c5a8f1811 Docs: Add a reference to `WP_Customize_Setting::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_setting()`. 
Synchronize the documentation between two places, use `WP_Customize_Setting::__construct()` as the canonical source.

Props tmanoilov, marekdedic.
Fixes #48347.
Built from https://develop.svn.wordpress.org/trunk@47384


git-svn-id: http://core.svn.wordpress.org/trunk@47171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:09:06 +00:00
Sergey Biryukov ac9b6fcef8 Docs: Use a consistent description for the `$manager` parameter in various Customizer class constructions. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47383


git-svn-id: http://core.svn.wordpress.org/trunk@47170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 15:33:05 +00:00
Sergey Biryukov 3d75b5bac5 Docs: Add a `@see` reference to `WP_Customize_Control::__construct()` in child class constructors. 
Follow-up to [47363], [47364].

See #48343, #48348.
Built from https://develop.svn.wordpress.org/trunk@47382


git-svn-id: http://core.svn.wordpress.org/trunk@47169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 13:30:08 +00:00
Sergey Biryukov 9bb8831642 Build/Test Tools: Remove redundant `Tests_Post_Types::register_post_type()` helper method, use `register_post_type()` directly. 
Props gh640, varunshanbhag.
Fixes #49365.
Built from https://develop.svn.wordpress.org/trunk@47381


git-svn-id: http://core.svn.wordpress.org/trunk@47168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 13:18:07 +00:00
Andrew Ozz c2bea683a2 Build Tools: Do not delete the (now committed) `script-loader-packages.php` file when running `clean:js` and copy it to /build. Fixes cases when running `grunt watch` or `-dev` where that file may be deleted and not recreated. 
See #48154.
Built from https://develop.svn.wordpress.org/trunk@47380


git-svn-id: http://core.svn.wordpress.org/trunk@47167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 05:15:09 +00:00
jorgefilipecosta 218cd5f4c2 Post WordPress 5.4 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@47379


git-svn-id: http://core.svn.wordpress.org/trunk@47166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 22:13:08 +00:00
jorgefilipecosta 3c8112e912 WordPress 5.4 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@47378


git-svn-id: http://core.svn.wordpress.org/trunk@47165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 21:56:07 +00:00
Sergey Biryukov 3adea27d1c Block Editor: Update `wp-includes/assets/script-loader-packages.php`. 
Follow-up to [47352], [47354].

Props aduth, ocean90, garrett-eclipse.
Fixes #49506.
Built from https://develop.svn.wordpress.org/trunk@47377


git-svn-id: http://core.svn.wordpress.org/trunk@47164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 21:45:06 +00:00
Sergey Biryukov ab0cf0aa51 Privacy: Switch buttons in Next Steps column of privacy request tables to `break-word` for better legibility on various screen sizes. 
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304.
Built from https://develop.svn.wordpress.org/trunk@47376


git-svn-id: http://core.svn.wordpress.org/trunk@47163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 21:01:06 +00:00
Sergey Biryukov 8136532954 Accessibility: Media: Hide the invisible "file upload button" on media views from assistive technologies. 
The button is visually hidden, but was announced by screen readers in workflows unrelated to file uploading, leading to confusion.

Props afercia, audrasjb, azaozz.
Fixes #47611.
Built from https://develop.svn.wordpress.org/trunk@47375


git-svn-id: http://core.svn.wordpress.org/trunk@47162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 20:44:06 +00:00
Sergey Biryukov 1a9b7f8737 General: Introduce HTML classes in `get_calendar()` for easier CSS targeting: 
* `.wp-calendar-table` for the `<table>` element.
* `.wp-calendar-nav` for the navigation wrapper.
* `.wp-calendar-nav-prev` for the previous month link.
* `.wp-calendar-nav-next` for the next month link.

Replace `#prev` and `#next` HTML IDs with `.wp-calendar-nav-prev` and `.wp-calendar-nav-next` classes.

Props sabernhardt, BackuPs, audrasjb, jorbin.
Fixes #39763.
Built from https://develop.svn.wordpress.org/trunk@47374


git-svn-id: http://core.svn.wordpress.org/trunk@47161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 20:30:07 +00:00
Sergey Biryukov 153eb7537e Docs: In `update_option()`, remove an inaccurate statement about the `$autoload` value for new options. 
If the option does not exist, it will be created with whatever was passed to the `$autoload` parameter, `'yes'` being only the default value.

Props leogermani.
Fixes #48357.
Built from https://develop.svn.wordpress.org/trunk@47373


git-svn-id: http://core.svn.wordpress.org/trunk@47160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 20:08:07 +00:00
Sergey Biryukov 3a333ef030 Coding Standards: Use strict comparison for `normalize_whitespace()` checks when comparing revisions or autosaves. 
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.
Built from https://develop.svn.wordpress.org/trunk@47372


git-svn-id: http://core.svn.wordpress.org/trunk@47159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 19:35:09 +00:00
Sergey Biryukov 8b0a0c44aa Widgets: Create a unique HTML ID for the `<ul>` element of Recent Comments widget if more than one instance is displayed on the page. 
Props peterwilsoncc, audrasjb, birgire, justinahinon, mbrailer, desrosj.
Fixes #46747.
Built from https://develop.svn.wordpress.org/trunk@47371


git-svn-id: http://core.svn.wordpress.org/trunk@47158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 19:29:06 +00:00
Sergey Biryukov 00f110740b Bootstrap/Load: In `wp_magic_quotes()`, revert the type change to string for `REQUEST_TIME` and `REQUEST_TIME_FLOAT` values, which should retain their proper type. 
Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.

Props jrf, Veraxus, Rarst.
See #48605.
Built from https://develop.svn.wordpress.org/trunk@47370


git-svn-id: http://core.svn.wordpress.org/trunk@47157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 18:33:06 +00:00
Sergey Biryukov 1e81c20ff5 Docs: In `wp_insert_user()`, correct `@type` for `rich_editing`, `syntax_highlighting`, `comment_shortcuts`, and `show_admin_bar_front` arguments. 
Follow-up to [47368].

See #49087.
Built from https://develop.svn.wordpress.org/trunk@47369


git-svn-id: http://core.svn.wordpress.org/trunk@47156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 18:20:06 +00:00
Sergey Biryukov 2cd5292def Docs: In `wp_insert_user()`, clarify that `rich_editing`, `syntax_highlighting`, `comment_shortcuts`, and `show_admin_bar_front` arguments accept `true` or `false` as a string literal, not boolean. 
Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087.
Built from https://develop.svn.wordpress.org/trunk@47368


git-svn-id: http://core.svn.wordpress.org/trunk@47155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 18:16:07 +00:00
Sergey Biryukov 89689e5ba9 Docs: Clarify in `WP_Customize_Manager::remove_*()` methods that removing a setting, panel, section, or control does not destroy the class instance or remove its filters. 
Props dlh, fgiannar, jon81, westonruter.
Fixes #48747.
Built from https://develop.svn.wordpress.org/trunk@47367


git-svn-id: http://core.svn.wordpress.org/trunk@47154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 17:50:05 +00:00
Sergey Biryukov 5308f570cb Comments: Restore the fourth parameter of `comments_number()` as `$post_id`, for consistency with `get_comments_number_text()`. 
The parameter was previously used as the number of comments, marked as deprecated in [5101].

Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.

Follow-up to [47276].

Fixes #48772.
Built from https://develop.svn.wordpress.org/trunk@47366


git-svn-id: http://core.svn.wordpress.org/trunk@47153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 17:34:08 +00:00
Sergey Biryukov b7c69ce058 Widgets: Avoid an overflow issue in widget controls that include `<select>` form fields. 
Props alexischenal, audrasjb, dkarfa.
Fixes #49401.
Built from https://develop.svn.wordpress.org/trunk@47365


git-svn-id: http://core.svn.wordpress.org/trunk@47152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 17:04:07 +00:00
Sergey Biryukov d51c720d2f Docs: Add a reference to `WP_Customize_Control::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_control()`. 
Synchronize the documentation between two places, use `WP_Customize_Control::__construct()` as the canonical source.

Props hAmpzter, marekdedic, SergeyBiryukov.
Fixes #48343.
Built from https://develop.svn.wordpress.org/trunk@47364


git-svn-id: http://core.svn.wordpress.org/trunk@47151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 16:41:07 +00:00
Sergey Biryukov cfc27d08ce Docs: Add a reference to `WP_Customize_Control::__construct()` for information on accepted arguments to override class property defaults in child classes. 
Props marcio-zebedeu, marekdedic.
Fixes #48348.
Built from https://develop.svn.wordpress.org/trunk@47363


git-svn-id: http://core.svn.wordpress.org/trunk@47150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 16:21:07 +00:00
K. Adam White 44e1bbef85 REST API: Correctly infer empty objects passed via query parameters. 
Permit passing an empty object as the string "?obj=". The type of the passed empty argument is inferred from the registered schema.

Props TimothyBlynJacobs, steffanhalv, schlessera, dd32.
Fixes #42961.

Built from https://develop.svn.wordpress.org/trunk@47362


git-svn-id: http://core.svn.wordpress.org/trunk@47149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 15:34:07 +00:00
K. Adam White a5f16272dd REST API: Permit access to the themes controller if user can edit any post type. 
Check a more exhaustive list of post type editing caps beyond "edit_post" to ensure custom user roles with access to to specific post types may still use block editor functionality depending on theme features.

Props miyauchi, TimothyBlynJacobs.
Fixes #46723.

Built from https://develop.svn.wordpress.org/trunk@47361


git-svn-id: http://core.svn.wordpress.org/trunk@47148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 15:20:08 +00:00
K. Adam White 8faf366ab9 REST API: Apply all relevant block rendering filters when rendering block previews. 
Several filters were introduced to the render_block method since the initial implementation of the block-renderer/ endpoints, causing the output of those endpoints to diverge from the rendered content of blocks on the frontend.

Props kadamwhite, TimothyBlynJacobs, miinasikk.
Fixes #49387.

Built from https://develop.svn.wordpress.org/trunk@47360


git-svn-id: http://core.svn.wordpress.org/trunk@47147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 15:05:06 +00:00
Sergey Biryukov 67a6527d51 Script Loader: Improve performance of `wp_script_is()` for scripts registered with complex dependencies. 
This switches `WP_Dependencies::recurse_deps()` from recursively checking the same handles over and over again to keep a flattened array of queued items and their dependencies for faster lookup in `WP_Dependencies::query()`.

Props superdav42.
Fixes #46469.
Built from https://develop.svn.wordpress.org/trunk@47359


git-svn-id: http://core.svn.wordpress.org/trunk@47146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 13:42:05 +00:00
Sergey Biryukov c60ea3261f Docs: Add a `@since` note for including `delete_posts` in default capabilities in `get_post_type_capabilities()`. 
Follow-up to [47357].

See #30991.
Built from https://develop.svn.wordpress.org/trunk@47358


git-svn-id: http://core.svn.wordpress.org/trunk@47145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 12:55:08 +00:00
Sergey Biryukov aaccfc063f Posts, Post Types: Ensure `delete_posts` is included in default post type capabilities regardless of `map_meta_cap` value. 
This resolves PHP notices in a few places in core where this capability is checked.

Props Mte90, johnbillion, dipesh.kakadiya, jipmoors, bamadesigner, dd32, johnjamesjacoby, xedin.unknown, flixos90, SergeyBiryukov.
Fixes #30991.
Built from https://develop.svn.wordpress.org/trunk@47357


git-svn-id: http://core.svn.wordpress.org/trunk@47144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 12:50:06 +00:00
Sergey Biryukov 1a090b3385 Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel. 
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830.
Built from https://develop.svn.wordpress.org/trunk@47356


git-svn-id: http://core.svn.wordpress.org/trunk@47143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 11:14:08 +00:00
Sergey Biryukov 556c6d80d8 Script Loader: Remove unnecessary reference sign from function definitions in script loader. 
This resolves PHP warnings when extensions like `php_uopz` or `php_tideways_xhprof` are in use.

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979.
Built from https://develop.svn.wordpress.org/trunk@47355


git-svn-id: http://core.svn.wordpress.org/trunk@47142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 00:59:06 +00:00
jorgefilipecosta f616ffb9c1 Block Editor: Update WordPress Packages WordPress 5.4 Beta 3. 
The following package versions were changed:
@wordpress/block-directory: 1.5.1 -> 1.5.2
@wordpress/block-editor: 3.7.1 -> 3.7.2
@wordpress/block-library: 2.14.1 -> 2.14.2
@wordpress/components: 9.2.1 -> 9.2.2
@wordpress/edit-post: 3.13.1 -> 3.13.2
@wordpress/editor: 9.12.1 -> 9.12.2
@wordpress/format-library: 1.14.1 -> 1.14.2
@wordpress/list-reusable-blocks: 1.13.1 -> 1.13.2
@wordpress/media-utils: 1.7.1 -> 1.7.2
@wordpress/nux: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.1 -> 1.8.2

Fixes #49506.
Built from https://develop.svn.wordpress.org/trunk@47354


git-svn-id: http://core.svn.wordpress.org/trunk@47141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 00:18:15 +00:00
Sergey Biryukov 3209729f5f Accessibility: Widgets: Restore missing string in script loader. 
The string was previously added in [42794] and accidentally removed in [44163].

Props garrett-eclipse, audrasjb.
Fixes #49505.
Built from https://develop.svn.wordpress.org/trunk@47353


git-svn-id: http://core.svn.wordpress.org/trunk@47140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 23:07:09 +00:00
Andrew Ozz 50be657d81 Build Tools: 
- Update the DependencyExtractionWebpackPlugin to 2.3.0 and set it to output a single assets file.
- Grunt: copy the assets file to both `SOURCE_DIR` and `BUILD_DIR` as `wp-includes/assets/script-loader-packages.php`.
- "Unignore" the `wp-includes/assets` directory. Its content will be committed similarly to `wp-includes/blocks`.
- Update `wp_default_packages_scripts()` to use the above file. This also removes the hard-coded lists of packages and packages with translations.

Props gziolo, pbearne, johnbillion, isabel_brison, ocean90, azaozz.
Fixes #48154.
Built from https://develop.svn.wordpress.org/trunk@47352


git-svn-id: http://core.svn.wordpress.org/trunk@47139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 21:22:08 +00:00
K. Adam White 480372b07c REST API: Fix namespace shadowing issue in route matching logic. 
Following [47260] a namespace such as "test-ns" prevents any namespace such as "test-ns/v1" from being found when matching routes.
While not best practice, this was an unintentional back-compat break; this patch restores the original behavior.

Props david.binda, TimothyBlynJacobs.
Fixes #48530.


Built from https://develop.svn.wordpress.org/trunk@47351


git-svn-id: http://core.svn.wordpress.org/trunk@47138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 18:07:08 +00:00
Sergey Biryukov 4aeebf03a5 Menus: Introduce `wp_nav_menu_item_custom_fields_customize_template` action that fires at the end of the form field template for nav menu items in the customizer. 
This brings parity with the `wp_nav_menu_item_custom_fields` action added in [47190] for the Menus screen.

Props celloexpressions.
Fixes #47056.
Built from https://develop.svn.wordpress.org/trunk@47350


git-svn-id: http://core.svn.wordpress.org/trunk@47137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 14:58:19 +00:00
Sergey Biryukov 735d31ffbb Coding Standards: Add missing braces to `if` conditions and use strict comparison in `js/_enqueues/wp/media/editor.js`. 
Props ankitmaru.
Fixes #49317.
Built from https://develop.svn.wordpress.org/trunk@47349


git-svn-id: http://core.svn.wordpress.org/trunk@47136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-23 08:58:05 +00:00
Sergey Biryukov 9f8f54bfbb Built/Test Tools: Ignore the `node_modules` folder in Twenty Nineteen when running `grunt jshint:themes`. 
Follow-up to [45060], [46352], [46450].

Fixes #49494. See #46706.
Built from https://develop.svn.wordpress.org/trunk@47348


git-svn-id: http://core.svn.wordpress.org/trunk@47135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-23 08:28:06 +00:00
Sergey Biryukov 5a23e3fabd Docs: Use third-person singular verbs for function descriptions in `wp-includes/option.php`, per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47347


git-svn-id: http://core.svn.wordpress.org/trunk@47134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-23 01:07:08 +00:00
Sergey Biryukov 30572ef8ed Docs: Add a `@staticvar` entry for `$transports` in `WP_Http::_dispatch_request()`. 
Props utsav72640.
Fixes #48774.
Built from https://develop.svn.wordpress.org/trunk@47346


git-svn-id: http://core.svn.wordpress.org/trunk@47133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-22 19:12:06 +00:00
Sergey Biryukov e0a2660719 I18N: Replace `.htaccess` with placeholders in the strings for Site Health custom rules check. 
Props ramiy.
Fixes #48864.
Built from https://develop.svn.wordpress.org/trunk@47345


git-svn-id: http://core.svn.wordpress.org/trunk@47132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-22 18:56:06 +00:00
Sergey Biryukov b4cea6ae93 I18N: Use a consistent wording for "Unable to write to file" strings. 
Props ramiy.
Fixes #48862.
Built from https://develop.svn.wordpress.org/trunk@47344


git-svn-id: http://core.svn.wordpress.org/trunk@47131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-22 18:33:08 +00:00
desrosj b92155f273 General: Introduce a pull request template. 
This ensures that contributors opening a pull request on GitHub for code review have proper guidance.

See https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/ and https://meta.trac.wordpress.org/ticket/4903.

Props noisysocks, desrosj.
Fixes #49489.
Built from https://develop.svn.wordpress.org/trunk@47342


git-svn-id: http://core.svn.wordpress.org/trunk@47129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 18:25:07 +00:00
Sergey Biryukov 92050d6499 Build/Test Tools: Remove unused `::assertPostHasTerms()` method from `tests/term.php`. 
The associated test was removed in [30241].

See #49485.
Built from https://develop.svn.wordpress.org/trunk@47341


git-svn-id: http://core.svn.wordpress.org/trunk@47128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 17:06:06 +00:00
Adam Silverstein 2c5ebcee68 Comments: improve styling on mobile for comments marked as spam. 
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam. 

Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814.


Built from https://develop.svn.wordpress.org/trunk@47340


git-svn-id: http://core.svn.wordpress.org/trunk@47127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 17:04:08 +00:00
ianbelanger 5a6decf95c Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied. 
Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.
Built from https://develop.svn.wordpress.org/trunk@47339


git-svn-id: http://core.svn.wordpress.org/trunk@47126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 14:59:09 +00:00
Sergey Biryukov f0dfe42216 I18N: Replace `upload_max_filesize`, `php.ini`, `MAX_FILE_SIZE` with placeholders in upload error strings. 
Props ramiy.
Fixes #48869.
Built from https://develop.svn.wordpress.org/trunk@47330


git-svn-id: http://core.svn.wordpress.org/trunk@47123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 17:18:06 +00:00
TimothyBlynJacobs 5031baa32b REST API: Don't assume all item schemas have properties. 
All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.

Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785.

Built from https://develop.svn.wordpress.org/trunk@47328


git-svn-id: http://core.svn.wordpress.org/trunk@47122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 16:58:06 +00:00
ianbelanger a5cfb704bd Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes. 
Fixes the margins in the block editor to address recent changes in block margins.

Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526.
Built from https://develop.svn.wordpress.org/trunk@47327


git-svn-id: http://core.svn.wordpress.org/trunk@47121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 16:40:06 +00:00
TimothyBlynJacobs 450d49183b REST API: Fix links format in OPTIONS requests for non-variable routes. 
Props nsundberg, johnwatkins0, birgire.
Fixes #49149.

Built from https://develop.svn.wordpress.org/trunk@47326


git-svn-id: http://core.svn.wordpress.org/trunk@47120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 00:55:05 +00:00
TimothyBlynJacobs 808768224d REST API: Warn if registering array settings without an items schema. 
The documentation for register_setting has also been clarified to include all of the supported types and the flexibility of the show_in_rest parameter.

Fixes #42875.
Props perrywagle, dshanske, kadamwhite.

Built from https://develop.svn.wordpress.org/trunk@47325


git-svn-id: http://core.svn.wordpress.org/trunk@47119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 22:56:07 +00:00
Sergey Biryukov c15cd5f5c4 Docs: Add missing quote to `{@see 'comment_$old_status_to_$new_status'}` hook reference in `wp_transition_comment_status()` DocBlock. 
Props coffee2code.
Fixes #49474.
Built from https://develop.svn.wordpress.org/trunk@47324


git-svn-id: http://core.svn.wordpress.org/trunk@47118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 13:45:07 +00:00
Sergey Biryukov 511a297fb4 Tests: Correct assertions in `test_site_dates_are_gmt()`. 
`assertSame()` doesn't have the `$delta` parameter, only `assertEquals()` does.

Follow-up to [47313].

See #40364.
Built from https://develop.svn.wordpress.org/trunk@47318


git-svn-id: http://core.svn.wordpress.org/trunk@47116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 04:40:05 +00:00
Sergey Biryukov e67b01895b Posts, Post Types: Discard `tags_input` parameter in `wp_update_post()` if it's the same as existing post tags. 
This ensures that `wp_update_post()` does not unintentionally modify post tags if the post has several tags with the same name but different slugs.

Tags should only be modified if `tags_input` parameter was explicitly provided, and is different from the existing tags.

Props kaggdesign, SergeyBiryukov.
Fixes #45121.
Built from https://develop.svn.wordpress.org/trunk@47317


git-svn-id: http://core.svn.wordpress.org/trunk@47115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 03:52:09 +00:00
Sergey Biryukov 548685b97d Tests: Use delta comparison in `test_site_dates_are_gmt()` to avoid race conditions. 
See #40364.
Built from https://develop.svn.wordpress.org/trunk@47313


git-svn-id: http://core.svn.wordpress.org/trunk@47113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 02:43:08 +00:00
Sergey Biryukov c4a5b98fa0 Build/Test Tools: Keep `wp-config.php` file in the `build` directory on rebuild, but still copy it over from `src` if it also exists there. 
Follow-up to [47303].

Props afercia, isabel_brison, SergeyBiryukov.
Fixes #49460.
Built from https://develop.svn.wordpress.org/trunk@47312


git-svn-id: http://core.svn.wordpress.org/trunk@47112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 01:50:05 +00:00
Sergey Biryukov 399c2bf8c6 Tests: Remove an irrelevant `tags_input` property assertion from `test_get_page_template_property()`. 
This appears to be a copy/paste from the `test_get_tags_input_property()` test above.

See #45121.
Built from https://develop.svn.wordpress.org/trunk@47311


git-svn-id: http://core.svn.wordpress.org/trunk@47111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 01:05:09 +00:00
Tammie Lister 152892b04c Bump version number to beta 2-47310 
Built from https://develop.svn.wordpress.org/trunk@47310


git-svn-id: http://core.svn.wordpress.org/trunk@47110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 21:29:05 +00:00
Tammie Lister d55eaec1f7 Bump version number to beta 2 
Built from https://develop.svn.wordpress.org/trunk@47309


git-svn-id: http://core.svn.wordpress.org/trunk@47109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 21:11:06 +00:00
desrosj 4cc82e180e Widgets: Revert [47307]. 
Even though the source URL for an attachment is stored in a variable, attachments should still be passed through the `wp_video_shortcode()` function.

Unprops desrosj, spacedmonkey.
See #46718.
Built from https://develop.svn.wordpress.org/trunk@47308


git-svn-id: http://core.svn.wordpress.org/trunk@47108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 18:19:06 +00:00
desrosj 520fe14f79 Widgets: Remove unnecessary redundant conditional. 
Props spacedmonkey.
Fixes #46718.
Built from https://develop.svn.wordpress.org/trunk@47307


git-svn-id: http://core.svn.wordpress.org/trunk@47107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 17:52:06 +00:00
desrosj 447536a0e6 Site Health: Display the REST API test error codes correctly. 
This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line.

This also clarifies the associated translator comments.

Props afercia, desrosj.
Fixes #49426.
Built from https://develop.svn.wordpress.org/trunk@47306


git-svn-id: http://core.svn.wordpress.org/trunk@47106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 16:48:06 +00:00
Sergey Biryukov 306d804d86 Theme Editor: Disable CodeMirror CSS linting. 
Being a good idea in theory, in practice it does not always work reliably, may not recognize newer CSS properties, and sometimes displays phantom errors with no particular error message.

A plugin can re-enable CSS linting via the `wp_code_editor_settings` filter.

Props skypressatx, ThemeZee, johnbillion, ianbelanger, ZanderZ, starvoters1, raoulunger, prashantvatsh, SergeyBiryukov.
Fixes #44471.
Built from https://develop.svn.wordpress.org/trunk@47305


git-svn-id: http://core.svn.wordpress.org/trunk@47105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 15:51:08 +00:00
Andrea Fercia d1054fcb48 Accessibility: Improve readability by removing unnecessary italic font style. 
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.

Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help

Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See #47327.

Built from https://develop.svn.wordpress.org/trunk@47304


git-svn-id: http://core.svn.wordpress.org/trunk@47104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 15:32:09 +00:00
Sergey Biryukov bb7880a7ea Build/Test Tools: Keep `wp-config.php` file in the `build` directory on rebuild. 
Props isabel_brison.
Fixes #49460.
Built from https://develop.svn.wordpress.org/trunk@47303


git-svn-id: http://core.svn.wordpress.org/trunk@47103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 09:27:09 +00:00
jorgefilipecosta b522d90421 Block Editor: Update WordPress Packages WordPress 5.4 beta 2. 
The following package versions were changed:
@wordpress/block-directory: 1.5.0 -> 1.5.1
@wordpress/block-editor: 3.7.0 -> 3.7.1
@wordpress/block-library: 2.14.0 -> 2.14.1
@wordpress/components: 9.2.0 -> 9.2.1
@wordpress/edit-post: 3.13.0 -> 3.13.1
@wordpress/editor: 9.12.0 -> 9.12.1
@wordpress/format-library: 1.14.0 -> 1.14.1
@wordpress/list-reusable-blocks: 1.13.0 -> 1.13.1
@wordpress/media-utils: 1.7.0 -> 1.7.1
@wordpress/nux: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.0 -> 1.8.1

Props gziolo, youknowriad, epiqueras, aduth.
Fixes #49458.
Built from https://develop.svn.wordpress.org/trunk@47302


git-svn-id: http://core.svn.wordpress.org/trunk@47102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 23:02:14 +00:00
jorgefilipecosta ce3cd1cd91 Block Editor: Add missing package to the default export array. 
Follow up on https://core.trac.wordpress.org/ticket/49358#comment:12.
We should add "warning" to the array of packages with default export to avoid the need for developers to use wp.warning.default.

Props gziolo, aduth.
Fixes #49436.
Built from https://develop.svn.wordpress.org/trunk@47301


git-svn-id: http://core.svn.wordpress.org/trunk@47101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 12:32:05 +00:00
Sergey Biryukov 9de7b1c35e Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now. 
Props Clorith, pbiron.
See #47606, #47085.
Built from https://develop.svn.wordpress.org/trunk@47300


git-svn-id: http://core.svn.wordpress.org/trunk@47100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 09:59:04 +00:00
Sergey Biryukov 61986acde9 Users: Limit the scope of admin files required in `WP_REST_Users_Controller`. 
This requires only `wp-admin/includes/user.php` for `get_editable_roles()`, instead of `wp-admin/includes/admin.php`.

Follow-up to [43589].

Props johnwatkins0.
Fixes #49450.
Built from https://develop.svn.wordpress.org/trunk@47299


git-svn-id: http://core.svn.wordpress.org/trunk@47099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 05:33:06 +00:00
Sergey Biryukov 8f877dc875 Docs: Improve inline comments for `require_once` calls in `WP_REST_Users_Controller` per the documentation standards. 
Follow-up to [47295].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47298


git-svn-id: http://core.svn.wordpress.org/trunk@47098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:56:06 +00:00
Sergey Biryukov 97380ec1ce Docs: Fix typo in a comment in `WP_REST_Attachments_Controller::create_item()`. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47297


git-svn-id: http://core.svn.wordpress.org/trunk@47097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:30:04 +00:00
Sergey Biryukov 1d5d5b3e87 REST API: Restore `wp-admin/includes/image.php` requirement in `WP_REST_Attachments_Controller::create_item()`. 
Although the file is already included via the `::insert_attachment()` method, this addresses an inconsistency and corrects a misleading comment.

It also reduces the possibility of a future error in case `::insert_attachment()` is no longer called earlier in `::create_item()` at some point.

Follow-up to [43850] and [44206].

Props luisrivera.
Fixes #49449.
Built from https://develop.svn.wordpress.org/trunk@47296


git-svn-id: http://core.svn.wordpress.org/trunk@47096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:24:07 +00:00
Sergey Biryukov 445e2859ab Docs: Improve inline comments for `require_once()` calls in `WP_REST_Attachments_Controller`. 
See #49449, #48303.
Built from https://develop.svn.wordpress.org/trunk@47295


git-svn-id: http://core.svn.wordpress.org/trunk@47095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:13:05 +00:00
Sergey Biryukov 5875ad981b Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing. 
Other inputs are already restored to their previous values in that case.

Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031.
Built from https://develop.svn.wordpress.org/trunk@47294


git-svn-id: http://core.svn.wordpress.org/trunk@47094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-16 06:27:08 +00:00
Sergey Biryukov 74b90a6b45 Themes: Correct the height of theme actions button container on various screen sizes. 
Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302.
Built from https://develop.svn.wordpress.org/trunk@47293


git-svn-id: http://core.svn.wordpress.org/trunk@47093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-15 05:08:05 +00:00
Sergey Biryukov f147a4003e Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden. 
Props audrasjb, fotisps, marcelo2605.
Fixes #48931.
Built from https://develop.svn.wordpress.org/trunk@47292


git-svn-id: http://core.svn.wordpress.org/trunk@47092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-15 02:50:08 +00:00
Sergey Biryukov a2b2f63b78 Administration: Allow `wp_update_link()` to update the `link_owner` field, for consistency with other link fields. 
Props pbiron, valentinbora, nikhilgupte.
Fixes #41687.
Built from https://develop.svn.wordpress.org/trunk@47291


git-svn-id: http://core.svn.wordpress.org/trunk@47091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-15 01:55:06 +00:00
Sergey Biryukov 19fd7a0da9 Administration: Correct alignment of form controls inside custom meta boxes. 
Props audrasjb, dontdream, valentinbora.
Fixes #49013.
Built from https://develop.svn.wordpress.org/trunk@47289


git-svn-id: http://core.svn.wordpress.org/trunk@47089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-14 00:52:06 +00:00
Sergey Biryukov e16d70a9d4 Tests: Rename `$d` variable in some date/time tests to `$format` for clarity. 
Follow-up to [47287].

See #49222.
Built from https://develop.svn.wordpress.org/trunk@47288


git-svn-id: http://core.svn.wordpress.org/trunk@47088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-14 00:12:11 +00:00
Sergey Biryukov 6b2c63031c Coding Standards: Rename `$d` parameter in various date/time functions to `$format` for clarity. 
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47287


git-svn-id: http://core.svn.wordpress.org/trunk@47087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-14 00:07:07 +00:00
Sergey Biryukov f7338b347d Docs: Update `@return` tag for `wp_allow_comment()` with `trash` as a possible return value. 
Props oakesjosh, jeremyfelt.
Fixes #49206.
Built from https://develop.svn.wordpress.org/trunk@47286


git-svn-id: http://core.svn.wordpress.org/trunk@47086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-13 17:50:05 +00:00
Sergey Biryukov 57ba9a2906 General: Update Michel Valdrighi's website in `license.txt`. 
Props sebastienserre.
Fixes #49130.
Built from https://develop.svn.wordpress.org/trunk@47285


git-svn-id: http://core.svn.wordpress.org/trunk@47085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-12 11:54:05 +00:00
Sergey Biryukov 534fcd7b0e Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list. 
Props chetan200891, xkon, garrett-eclipse.
Fixes #48431.
Built from https://develop.svn.wordpress.org/trunk@47284


git-svn-id: http://core.svn.wordpress.org/trunk@47084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-12 11:44:08 +00:00
Sergey Biryukov b2ecf2c2bc Privacy: Improve the appearance of privacy request email inputs on mobile. 
Props garrett-eclipse, xkon.
Fixes #48189.
Built from https://develop.svn.wordpress.org/trunk@47283


git-svn-id: http://core.svn.wordpress.org/trunk@47083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-12 11:29:10 +00:00
jorgefilipecosta 53f823e21e Post WordPress 5.4 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@47282


git-svn-id: http://core.svn.wordpress.org/trunk@47082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 22:46:09 +00:00
jorgefilipecosta b24a667b9a WordPress 5.4 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@47281


git-svn-id: http://core.svn.wordpress.org/trunk@47081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 22:20:10 +00:00
Sergey Biryukov 63ed0401a0 Privacy: Revert [47269] for now to address side effects on Multisite installations. 
See #44176.
Built from https://develop.svn.wordpress.org/trunk@47280


git-svn-id: http://core.svn.wordpress.org/trunk@47080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 21:48:06 +00:00
Sergey Biryukov 652966a2a5 Privacy: Introduce filters for the headers of all the privacy-related e-mails: 
* `wp_privacy_personal_data_email_headers`
* `user_request_confirmed_email_headers`
* `user_erasure_complete_email_headers`
* `user_request_action_email_headers`

Props xkon, garrett-eclipse, zaffarn, desrosj.
Fixes #44501.
Built from https://develop.svn.wordpress.org/trunk@47279


git-svn-id: http://core.svn.wordpress.org/trunk@47079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 21:43:07 +00:00
Sergey Biryukov e6d01e007c Privacy: Add a table of contents to Personal Data Export report for easier navigation. 
Props xkon, garrett-eclipse, birgire, karmatosed.
Fixes #46894.
Built from https://develop.svn.wordpress.org/trunk@47278


git-svn-id: http://core.svn.wordpress.org/trunk@47078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 21:28:05 +00:00
Sergey Biryukov cbaf9bf9d1 Coding Standards: Use a strict `in_array()` check for reserved names of user data items in `wp_user_personal_data_exporter()`. 
Props azaozz.
Fixes #47509.
Built from https://develop.svn.wordpress.org/trunk@47277


git-svn-id: http://core.svn.wordpress.org/trunk@47077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 20:55:07 +00:00
Sergey Biryukov 17e563cd9c Comments: Add a `$post_id` parameter to `get_comments_number_text()` and `comments_number()`. 
This allow for using these functions outside of the loop.

Props donmhico, garrett-eclipse, Hinjiriyo, imath.
Fixes #48772.
Built from https://develop.svn.wordpress.org/trunk@47276


git-svn-id: http://core.svn.wordpress.org/trunk@47076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 20:41:05 +00:00
desrosj be2ec734f2 Upgrade/Install: Enable maintenance mode when plugins are auto-updated. 
When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios:

- The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error.
- The WSOD protection could be triggered, sending a false alarm email to the site administrator.

By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided.

This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode.

Props desrosj, SergeyBiryukov.
Fixes #49400.
Built from https://develop.svn.wordpress.org/trunk@47275


git-svn-id: http://core.svn.wordpress.org/trunk@47075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 20:14:05 +00:00
Andrew Ozz a2accf4db7 Media: Pass through the `$unfiltered` param to `get_attached_file()` in `wp_get_original_image_path()`. 
Props ianmjones, joemcgill, azaozz.
Fixes #48421.
Built from https://develop.svn.wordpress.org/trunk@47274


git-svn-id: http://core.svn.wordpress.org/trunk@47074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:47:07 +00:00
ianbelanger 4489fb7b36 Bundled Themes: Twenty Sixteen text color setting in pullquote block not applied. 
Fixes the pullquote color setting by moving `color` from `blockquote p` to `blockquote`. Also adds the border-left to the front-end stylesheet to match the editor. Also adds styles for rtl pullquote.

Props kokkieh, desrosj, mukesh27, khushbu19, disillusia, aliveic, abrightclearweb, SergeyBiryukov.
Fixes #47019.
Built from https://develop.svn.wordpress.org/trunk@47273


git-svn-id: http://core.svn.wordpress.org/trunk@47073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:38:05 +00:00
Sergey Biryukov ae102b2487 Export: Use correct context for the `Posts` label on the Export screen. 
The string refers to the post type name specifically, not to a generic term to identify a publication on WordPress.

Props audrasjb, jdy68.
Fixes #49306.
Built from https://develop.svn.wordpress.org/trunk@47272


git-svn-id: http://core.svn.wordpress.org/trunk@47072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:35:06 +00:00
jorgefilipecosta 40046869f3 Upload: Fix Plugin and Theme upload form are misaligned. 
This commit makes sure that when uploading a plugin or theme file, the Install Now button is correctly aligned, and the button does not drops to the next line if filename is long.

Props seedsca, SergeyBiryukov, audrasjb.
Fixes #48859.
Built from https://develop.svn.wordpress.org/trunk@47271


git-svn-id: http://core.svn.wordpress.org/trunk@47071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:18:09 +00:00