Commit Graph

24708 Commits

Author SHA1 Message Date
Scott Taylor 678ef2b1e1 In `wpdb::db_connect()`, allow the loading of a custom database error template - this is already allowed in `dead_db()`.
In `dead_db()`, move the call to `wp_load_translations_early()` before the inclusion of the `db-error.php` file to allow translation in both locations before the template is loaded.

Props sbruner, kovshenin.
Fixes #25703.


Built from https://develop.svn.wordpress.org/trunk@27056


git-svn-id: http://core.svn.wordpress.org/trunk@26929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 05:28:12 +00:00
Scott Taylor ad211ca06a Add Unit Tests for `get_comment_pages_count()`. Fix a notice caused when `$wp_query->comments` is not set in that function.
Props mdbitz, markjaquith.
Fixes #20633.


Built from https://develop.svn.wordpress.org/trunk@27055


git-svn-id: http://core.svn.wordpress.org/trunk@26928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 05:17:12 +00:00
Scott Taylor 0347a8944e Update the versions of several `devDependencies` in `package.json`. `grunt-cssjanus` has been updated to `0.2.2`, we no longer need the fork. Run `npm install` to receive updates for `node_modules` in the project root.
Props yoavf, TobiasBg.
Fixes #26073.


Built from https://develop.svn.wordpress.org/trunk@27053


git-svn-id: http://core.svn.wordpress.org/trunk@26927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 04:43:30 +00:00
Andrew Ozz 6f25a990d0 TinyMCE: fix Ctrl + s shortcut (trigger autosave), see #24067.
Built from https://develop.svn.wordpress.org/trunk@27052


git-svn-id: http://core.svn.wordpress.org/trunk@26926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:29:12 +00:00
Scott Taylor e1759d668a For starters, [27050] is rad. This just cleans up some extra new lines that were littered about, updates *some* of the inline docs (needs more), moves `wp.media.controller.ImageDetails` closer to its parent class, and de-dupes some code in `media-template.php`.
See #24409.


Built from https://develop.svn.wordpress.org/trunk@27051


git-svn-id: http://core.svn.wordpress.org/trunk@26925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:21:13 +00:00
Andrew Ozz 33eedc570b Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409.
Built from https://develop.svn.wordpress.org/trunk@27050


git-svn-id: http://core.svn.wordpress.org/trunk@26924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 21:17:12 +00:00
Drew Jaynes 9172107539 Inline documentation for hooks in wp-includes/class-http.php.
Props kraftbj for the initial patches. Props kpdesign, DrewAPicture.
Fixes #26049.

Built from https://develop.svn.wordpress.org/trunk@27049


git-svn-id: http://core.svn.wordpress.org/trunk@26923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:25:11 +00:00
Drew Jaynes 0715a1d551 Inline documentation for hooks in wp-admin/includes/export.php.
Props cmmarslender, kpdesign.
Fixes #26894.

Built from https://develop.svn.wordpress.org/trunk@27048


git-svn-id: http://core.svn.wordpress.org/trunk@26922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:10:12 +00:00
Drew Jaynes b977d778b2 Inline documentation for hooks in wp-admin/includes/update-core.php.
Props JoshuaAbenazer, kpdesign.
Fixes #25998.

Built from https://develop.svn.wordpress.org/trunk@27047


git-svn-id: http://core.svn.wordpress.org/trunk@26921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:02:14 +00:00
Helen Hou-Sandí 291ed370b4 Autocomplete for the new site admin email. Better than trying to remember which email address you used.
fixes #25348.

Built from https://develop.svn.wordpress.org/trunk@27046


git-svn-id: http://core.svn.wordpress.org/trunk@26920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 23:10:12 +00:00
Andrew Nacin d39d60e841 Add wp_install and wp_upgrade hooks to the respective functions.
props Denis-de-Bernardy.
fixes #25762.

Built from https://develop.svn.wordpress.org/trunk@27045


git-svn-id: http://core.svn.wordpress.org/trunk@26919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 16:32:12 +00:00
Andrew Ozz 544116e76a TinyMCE: add dashicon for the "wp_page" button, see #24067.
Built from https://develop.svn.wordpress.org/trunk@27044


git-svn-id: http://core.svn.wordpress.org/trunk@26918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 15:06:32 +00:00
Dominik Schilling ea7f080573 Update help content for Dashboard. props kpdesign. fixes #26632.
Built from https://develop.svn.wordpress.org/trunk@27043


git-svn-id: http://core.svn.wordpress.org/trunk@26917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 14:47:12 +00:00
Andrew Nacin c4e119d530 Basic unit tests and additional documentation for wp_strip_all_tags().
props joehoyle.
fixes #25507.

Built from https://develop.svn.wordpress.org/trunk@27042


git-svn-id: http://core.svn.wordpress.org/trunk@26916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 03:16:11 +00:00
Andrew Ozz 398ae265bc DFW: remove unused #wp-fullscreen-title-prompt-text selectors. See #24067.
Built from https://develop.svn.wordpress.org/trunk@27039


git-svn-id: http://core.svn.wordpress.org/trunk@26915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 00:39:12 +00:00
Andrew Ozz 864ab9ae56 Autosave:
- Move the 'Saving post' and 'Draft saved at...' strings from autosaveL10n to postL10n as they are used only there.
- Use the custom jQuery events 'before-autosave' and 'after-autosave' to show these messages.
- Separate autosave.suspend() for local and server so local autosaves can continue while server autosaves are suspended.
- Remove the recently added autosave.server.disable() and use autosave.server.suspend() instead.
- Bring back .button.disabled, button-primary.disabled and use .disabled to prevent multiple form submissions.
See #25272.

Built from https://develop.svn.wordpress.org/trunk@27038


git-svn-id: http://core.svn.wordpress.org/trunk@26914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 00:28:13 +00:00
Andrew Ozz ced6e2a428 Remove one more valign, props neoxx, fixes #22712.
Built from https://develop.svn.wordpress.org/trunk@27037


git-svn-id: http://core.svn.wordpress.org/trunk@26913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:38:11 +00:00
Andrew Ozz 87589dd445 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
Built from https://develop.svn.wordpress.org/trunk@27036


git-svn-id: http://core.svn.wordpress.org/trunk@26912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:28:12 +00:00
Andrew Ozz 61540893f3 Fix tabbing order when opening/closing post status and visibility in the Publish postbox and cache some of the jQuery selectors. Part-props atimmer, fixes #25460.
Built from https://develop.svn.wordpress.org/trunk@27035


git-svn-id: http://core.svn.wordpress.org/trunk@26911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 03:07:16 +00:00
Andrew Ozz 07ae13e432 TinyMCE: do not run preventDefault() on the tab key when Ctrl, Alt or Command key is also pressed. Ctrl + Tab is used to switch between browser tabs. See #24067, fixes #17261.
Built from https://develop.svn.wordpress.org/trunk@27034


git-svn-id: http://core.svn.wordpress.org/trunk@26910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 00:29:12 +00:00
Dominik Schilling 496c05f1e9 Remove unused code. props nofearinc. fixes #26205.
Built from https://develop.svn.wordpress.org/trunk@27033


git-svn-id: http://core.svn.wordpress.org/trunk@26909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 00:12:11 +00:00
Scott Taylor 7ef7a7cb47 Add some inline docs to methods in `media-models.js` - particularly around `@param` and `@returns`.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@27032


git-svn-id: http://core.svn.wordpress.org/trunk@26908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 08:56:12 +00:00
Scott Taylor bf09d042eb Add some JSDoc annotations to `media-models.js` to disambiguate instance properties and static class properties/methods in the base media Models.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@27031


git-svn-id: http://core.svn.wordpress.org/trunk@26907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 07:39:11 +00:00
Andrew Ozz ed3145ec3d TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.
Built from https://develop.svn.wordpress.org/trunk@27030


git-svn-id: http://core.svn.wordpress.org/trunk@26906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 01:21:13 +00:00
Andrew Ozz eb1d21d782 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
Built from https://develop.svn.wordpress.org/trunk@27029


git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 19:06:15 +00:00
Dominik Schilling 2d9bf68585 Update to jQuery UI 1.10.4. fixes #26884.
Built from https://develop.svn.wordpress.org/trunk@27028


git-svn-id: http://core.svn.wordpress.org/trunk@26904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 17:44:12 +00:00
Dominik Schilling 91f7d8e1b7 Update to jQuery 1.11.0. fixes #26926.
Built from https://develop.svn.wordpress.org/trunk@27027


git-svn-id: http://core.svn.wordpress.org/trunk@26903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 17:40:13 +00:00
Andrew Nacin 1318242221 Docs fix: edit_comment_link() doesn't actually return anything.
props Corphi.
fixes #26436.

Built from https://develop.svn.wordpress.org/trunk@27026


git-svn-id: http://core.svn.wordpress.org/trunk@26902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 07:17:36 +00:00
Andrew Nacin ab733945b5 Properly detect line height of Quick Draft textarea.
props batmoo.
fixes #26915 for trunk.

Built from https://develop.svn.wordpress.org/trunk@27021


git-svn-id: http://core.svn.wordpress.org/trunk@26897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-23 18:03:12 +00:00
Sergey Biryukov d136519061 Fix typo in CSS. props ciantic, MikeHansenMe. fixes #26898.
Built from https://develop.svn.wordpress.org/trunk@27020


git-svn-id: http://core.svn.wordpress.org/trunk@26896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-23 12:22:11 +00:00
Scott Taylor d8db2e0cc7 Fix imperceptible whitespace cruff from [27017].
Built from https://develop.svn.wordpress.org/trunk@27018


git-svn-id: http://core.svn.wordpress.org/trunk@26895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 22:35:12 +00:00
Scott Taylor 580d8ab0db Fix a bit of whitespace from [27016].
Built from https://develop.svn.wordpress.org/trunk@27017


git-svn-id: http://core.svn.wordpress.org/trunk@26894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 22:34:12 +00:00
Scott Taylor a9c661c00e Let `is_attachment()` accept an $attachment parameter, similar to `is_page()` and `is_single()`. Adds Unit Tests for all 3.
Props alex-ye for the initial patch.
Fixes #24257.


Built from https://develop.svn.wordpress.org/trunk@27016


git-svn-id: http://core.svn.wordpress.org/trunk@26893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 22:31:12 +00:00
Andrew Ozz 4d531835a8 Autosave: don't set "submit" buttons to disabled right before submitting the form. They are not sent with the form data, see #25272.
Built from https://develop.svn.wordpress.org/trunk@27015


git-svn-id: http://core.svn.wordpress.org/trunk@26892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 21:26:10 +00:00
Andrew Nacin e18a013956 Themes screen: Add aria-describedby attributes to provide better information to screen readers.
props joedolson for initial patch.
fixes #26602 for trunk.

Built from https://develop.svn.wordpress.org/trunk@27012


git-svn-id: http://core.svn.wordpress.org/trunk@26889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 21:00:11 +00:00
Andrew Ozz 33c41db77a Improve keyboard accessibility for the admin menu when in responsive mode, props SergeyBiryukov, fixes #26639 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27011


git-svn-id: http://core.svn.wordpress.org/trunk@26888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 20:08:11 +00:00
Andrew Nacin c64266f38f Themes screen: Various IE8 adjustments and fixes.
props morganestes, matveb.
fixes #26541.

Built from https://develop.svn.wordpress.org/trunk@27007


git-svn-id: http://core.svn.wordpress.org/trunk@26884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:54:11 +00:00
Matt Thomas 7d002a5e84 Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.



Built from https://develop.svn.wordpress.org/trunk@27006


git-svn-id: http://core.svn.wordpress.org/trunk@26883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:24 +00:00
Scott Taylor f850ddd4f8 Add inline docs to each method of the namespaced objects in `media-editor.js`, explaining what each does. Add inline docs to params as well.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@27005


git-svn-id: http://core.svn.wordpress.org/trunk@26882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:11 +00:00
Andrew Ozz 167235a602 TinyMCE: fix initializing TinyMCE when the default editor in getUserSetting() is overridden from PHP by using the 'wp_default_editor' filter. See #24067.
Built from https://develop.svn.wordpress.org/trunk@27004


git-svn-id: http://core.svn.wordpress.org/trunk@26881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:17:12 +00:00
Andrew Ozz 97afd9c251 Autosave: don't disable the buttons on previewing a post, see #25272.
Built from https://develop.svn.wordpress.org/trunk@27003


git-svn-id: http://core.svn.wordpress.org/trunk@26880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 17:58:12 +00:00
Scott Taylor f6b1f2202a Add the `@namespace` annotation where appropriate in `media-editor.js`. Also indicate the default value of a few params via the [options={}] syntax.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@27000


git-svn-id: http://core.svn.wordpress.org/trunk@26877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 17:17:11 +00:00
Andrew Nacin 06efe8130d Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.
props mattheu.
see #26574 for trunk.

Built from https://develop.svn.wordpress.org/trunk@26999


git-svn-id: http://core.svn.wordpress.org/trunk@26876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 16:52:11 +00:00
Nikolay Bachiyski 74ace0517c Excplitcly globalized call to $wp later in wp-settings.php
Props xknown, fixes #26867.

Built from https://develop.svn.wordpress.org/trunk@26997


git-svn-id: http://core.svn.wordpress.org/trunk@26874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 14:48:11 +00:00
Nikolay Bachiyski 80af25060b Explicitly globalize some missing query globals in wp-settings.php
When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be.

Fixes #26867

Built from https://develop.svn.wordpress.org/trunk@26996


git-svn-id: http://core.svn.wordpress.org/trunk@26873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 08:25:12 +00:00
Andrew Ozz 335add2573 Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272.
Built from https://develop.svn.wordpress.org/trunk@26995


git-svn-id: http://core.svn.wordpress.org/trunk@26872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 04:56:16 +00:00
Andrew Ozz b4d76115cd TinyMCE: fix error trying to translate non-existent button "title" in the compat3x plugin. See #24067.
Built from https://develop.svn.wordpress.org/trunk@26994


git-svn-id: http://core.svn.wordpress.org/trunk@26871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 02:29:12 +00:00
Matt Thomas 9f4f560258 Eliminate the 1px padding adjustment on active buttons because it creates an un-clickable dead zone 1px high and spanning the entire width of the button. Modify the background color of active buttons for better contrast to make the active state more obvious.
See #26700, props johnbillion.


Built from https://develop.svn.wordpress.org/trunk@26993


git-svn-id: http://core.svn.wordpress.org/trunk@26870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 21:27:12 +00:00
Scott Taylor 18b8c717f2 Make some `@param` types more specific in `media-models.js`.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@26991


git-svn-id: http://core.svn.wordpress.org/trunk@26868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 17:37:12 +00:00
Scott Taylor 60986d43b4 Remove debug cruft.
Props nacin.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@26990


git-svn-id: http://core.svn.wordpress.org/trunk@26867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 16:31:11 +00:00