50646 Commits

Author SHA1 Message Date
audrasjb
737185823f Themes: Avoid double hashed value for background-color in custom backgrounds.
This changeset replaces the hardcoded hash symbol with running `maybe_hash_hex_color()` on the full `background-color` value provided via the custom background feature, so the hash is only added if it is needed. By doing so, if a theme developer sets a background color value that uses a hash (#), WordPress won't add an additional hash anymore when outputting the relevant CSS. Duplicate hash symbols (##) can break CSS background color declarations.

Props hovhanneshovakimyan, joyously, poena, 
Fixes #40057.



Built from https://develop.svn.wordpress.org/trunk@59813


git-svn-id: http://core.svn.wordpress.org/trunk@59155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 21:06:25 +00:00
Weston Ruter
08c4498647 HTML API: Stop counting no-op seek operations against the max seek count.
This allows `seek()` to be freely called when the current cursor at the provided bookmark.

Props dmsnell, jonsurrell, westonruter.
Fixes #62085.

Built from https://develop.svn.wordpress.org/trunk@59812


git-svn-id: http://core.svn.wordpress.org/trunk@59154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 20:04:23 +00:00
desrosj
5f79466650 Bundled Themes: Bump version of Twenty Twenty-Five to 1.1.
Fixes #62943.
Built from https://develop.svn.wordpress.org/trunk@59809


git-svn-id: http://core.svn.wordpress.org/trunk@59151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 16:56:24 +00:00
davidbaumwald
40d50ca185 General: Remove duplicate type="button" attribute from the "Change|Choose Site Icon" button.
Introduced in [57602].

Props kkmuffme, audrasjb.
Fixes #62942.
Built from https://develop.svn.wordpress.org/trunk@59806


git-svn-id: http://core.svn.wordpress.org/trunk@59148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 15:57:21 +00:00
Sergey Biryukov
0909a94115 Coding Standards: Correct default values in WP_Comment to match the documented type.
Follow-up to [33891], [48941].

See #62279.
Built from https://develop.svn.wordpress.org/trunk@59805


git-svn-id: http://core.svn.wordpress.org/trunk@59147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 13:40:30 +00:00
John Blackbourn
47fe3123b4 Security: Delete a test file that was missed in [59803].
Props swissspidy.

See #60638, #62815, #56017
Built from https://develop.svn.wordpress.org/trunk@59804


git-svn-id: http://core.svn.wordpress.org/trunk@59146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 12:18:23 +00:00
John Blackbourn
bb832dcfef Security: Explicitly require the hash PHP extension and add requirement checks during installation and upgrade.
This extension provides the `hash()` function and support for the SHA-256 algorithm, both of which are required for upcoming security related changes. This extension is almost universally enabled, however it is technically possible to disable it on PHP 7.2 and 7.3, hence the introduction of this requirement and the corresponding requirement checks prior to installing or upgrading WordPress.

Props peterwilsoncc, ayeshrajans, dd32, SergeyBiryukov, johnbillion.

Fixes #60638, #62815, #56017

See #21022
Built from https://develop.svn.wordpress.org/trunk@59803


git-svn-id: http://core.svn.wordpress.org/trunk@59145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-11 11:14:21 +00:00
Peter Wilson
9f83001243 Global Styles: Improve sanitization of block variation styles.
Fixes an issue where block style variations containing inner block type and element styles would have those inner styles stripped when the user attempting to save Global Styles does not have the `unfiltered_html` capability.

Props aaronrobertshaw, mukesh27, andrewserong.
Fixes #62372.

Built from https://develop.svn.wordpress.org/trunk@59802


git-svn-id: http://core.svn.wordpress.org/trunk@59144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 22:29:22 +00:00
Peter Wilson
d4822bd3c5 REST API: Add support for the ignore_sticky_posts argument.
Introduce `ignore_sticky` as a boolean argument for the posts endpoint for requests without the sticky posts being stuck. The new argument defaults to `false` with the value of the argument passed to `WP_Query`'s `ignore_sticky_posts` parameter.

Props audrasjb, danielbachhuber, joemcgill, johnbillion, jorbin, mamaduka, rmccue.
Fixes #35907.


Built from https://develop.svn.wordpress.org/trunk@59801


git-svn-id: http://core.svn.wordpress.org/trunk@59143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 22:23:23 +00:00
John Blackbourn
0ac2a96887 Administration: Correct the capitalisation of "site administrator" for consistency with other instances within WordPress.
Follow-up to [59799].

Props ocean90

Fixes #48879
Built from https://develop.svn.wordpress.org/trunk@59800


git-svn-id: http://core.svn.wordpress.org/trunk@59142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 17:06:23 +00:00
John Blackbourn
e1c2d3f420 Administration: Remove a potentially incorrect addressee and improve the phrasing used in the confirmation email when a user attempts to change the administration email address.
Props MadtownLems, ilovecats7, rehanali, iflairwebtechnologies, thehercules

Fixes #48879
Built from https://develop.svn.wordpress.org/trunk@59799


git-svn-id: http://core.svn.wordpress.org/trunk@59141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 15:31:22 +00:00
John Blackbourn
cf4686e4b6 Cron API: Clear the recovery_mode_clean_expired_keys cron event when converting a single site installation to Multisite.
This cron event is not used when Multisite is in use.

Props debarghyabanerjee, johnbillion, narenin

Fixes #61450
Built from https://develop.svn.wordpress.org/trunk@59798


git-svn-id: http://core.svn.wordpress.org/trunk@59140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 15:01:23 +00:00
desrosj
caaf76b11e Build/Test Tools: Remove matchdep as a dependency.
`matchdep` was introduced in [25243] to more easily manage `grunt-*` dependencies. The package has effectively been abandoned upstream, and the functionality can be replaced with a simple loop.

Props desrosj, spacedmonkey, swissspidy.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@59797


git-svn-id: http://core.svn.wordpress.org/trunk@59139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 14:30:26 +00:00
Sergey Biryukov
b87e7301ad Coding Standards: Use strict comparison in WP_Query::the_comment() and ::have_comments().
Follow-up to [4934].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59796


git-svn-id: http://core.svn.wordpress.org/trunk@59138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 10:51:25 +00:00
Peter Wilson
096c95390c Editor: Preload Global Styles REST requests based on user permissions.
For the Post Editor, preload '/wp/v2/global-styles/' . $global_styles_id with a context corresponding to user caps, that is, 'edit' for users that can edit global styles, and 'view' for everyone else.

Preloading the global styles endpoint according to role context means that admins and non admins, e.g., editors, avoid unnecessary client side requests.

Props ramonopoly.
Fixes #62322.


Built from https://develop.svn.wordpress.org/trunk@59795


git-svn-id: http://core.svn.wordpress.org/trunk@59137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 03:56:23 +00:00
Peter Wilson
e92abc0735 Site Editor: Redirect deprecated URLs to path based routing.
The site editor now uses path based routing rather than query string arguments. This redirects the legacy query string URLs to the new routing.

Props youknowriad, peterwilsoncc, joemcgill, mukesh27, poena.
Fixes #62585.

Built from https://develop.svn.wordpress.org/trunk@59794


git-svn-id: http://core.svn.wordpress.org/trunk@59136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-10 02:40:23 +00:00
Peter Wilson
c101e1b5b2 Editor: Update enqueued styles in the editor.
Updates the enqueued styles in various editors to remove target styles more precisely to where they are needed.

Removes the following stylesheets as dependencies of `wp-edit-blocks`:

* `wp-editor`
* `wp-reusable-blocks`
* `wp-patterns`

The `wp-editor` stylesheet is targeted to the items requiring the CSS:

* `edit-widgets`
* `customize-widgets`
* `edit-site`

Props ellatrix, youknowriad.
Fixes #62266, #62274.

Built from https://develop.svn.wordpress.org/trunk@59793


git-svn-id: http://core.svn.wordpress.org/trunk@59135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-09 22:34:23 +00:00
Sergey Biryukov
770eb818a4 Coding Standards: Use strict comparison in WP_Query::the_post() and ::have_posts().
Follow-up to [2716], [2741], [11464].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59792


git-svn-id: http://core.svn.wordpress.org/trunk@59134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-09 18:51:21 +00:00
audrasjb
fdb545356c Administration: Replace missed references of "Add New" in WP_Post_Type class.
Follow-up to [59784], [59786].

Fixes #61219.



Built from https://develop.svn.wordpress.org/trunk@59791


git-svn-id: http://core.svn.wordpress.org/trunk@59133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-09 11:09:21 +00:00
audrasjb
6309ca8f17 General: Error messages improvements in /wp-includes files.
This changeset improves a bunch of error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information.

Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson.
Fixes #43622.



Built from https://develop.svn.wordpress.org/trunk@59790


git-svn-id: http://core.svn.wordpress.org/trunk@59132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 16:00:19 +00:00
audrasjb
c5293a0be9 Administration: Error messages improvements in WP Admin.
This changeset improves a bunch of WP-Admin error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information.

Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson.
See #43622.



Built from https://develop.svn.wordpress.org/trunk@59789


git-svn-id: http://core.svn.wordpress.org/trunk@59131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 15:53:17 +00:00
Sergey Biryukov
d76c427a42 Coding Standards: Use strict comparison in WP_Query::is_page() and ::is_single().
Follow-up to [29039].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59788


git-svn-id: http://core.svn.wordpress.org/trunk@59130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 15:32:24 +00:00
audrasjb
342c3037df Docs: Fix Docblock parameters indentation for wp_determine_option_autoload_value(), as per WP Docs standards.
See #62281.



Built from https://develop.svn.wordpress.org/trunk@59787


git-svn-id: http://core.svn.wordpress.org/trunk@59129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 15:11:20 +00:00
audrasjb
22549e4550 Bundled Themes: Replace references to "Add New" theme screen in bundled themes readme files.
Follow-up to [59784].

Props jameskoster, audrasjb, ntsekouras, afercia, peterwilsoncc, youknowriad, joedolson, sukhendu2002, jdy68, beryldlg, fxbenard.
Fixes #61219.



Built from https://develop.svn.wordpress.org/trunk@59786


git-svn-id: http://core.svn.wordpress.org/trunk@59128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 12:14:19 +00:00
audrasjb
ad6af7aaa9 Docs: Various Docblock fixes in wp-includes/class-wp-customize-control.php, as per WP Docs standards;
See #62281.



Built from https://develop.svn.wordpress.org/trunk@59785


git-svn-id: http://core.svn.wordpress.org/trunk@59127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 12:00:19 +00:00
audrasjb
1498d000ba Administration: Replace "Add New {Item}" wording with "Add {Item}" across the administration.
This changeset replaces each occurrence of "Add New {Item}" label with "Add {Item}" in WordPress administration, to make the interface more consistent and simplify the translation effort.

Props jameskoster, audrasjb, ntsekouras, afercia, peterwilsoncc, youknowriad, joedolson, sukhendu2002, jdy68, beryldlg, fxbenard.
See #61219.



Built from https://develop.svn.wordpress.org/trunk@59784


git-svn-id: http://core.svn.wordpress.org/trunk@59126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-08 11:44:24 +00:00
desrosj
065a43f68d General: Introduce polyfills for new array related functions in PHP 8.4.
PHP 8.4 introduced four new functions to provide a common way to more easily perform common operations on arrays.

- `array_find()`: https://www.php.net/manual/en/function.array-find.php
- `array_find_key()`: https://www.php.net/manual/en/function.array-find-key.php
- `array_all()`: https://www.php.net/manual/en/function.array-all.php
- `array_any()`: https://www.php.net/manual/en/function.array-any.php

These functions are now polyfilled making them available on all supported versions of PHP (currently 7.2+).

Props Soean, swissspidy, TobiasBg, ayeshrajans, mukesh27, joemcgill.
Fixes #62558.
Built from https://develop.svn.wordpress.org/trunk@59783


git-svn-id: http://core.svn.wordpress.org/trunk@59125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-07 18:54:22 +00:00
Joe McGill
da8fd1d079 Editor: Add remaining query block file.
This is a follow-up to [59776] and [59775] to add yet another file that was missed in the original commit.

See #62887.

Built from https://develop.svn.wordpress.org/trunk@59777


git-svn-id: http://core.svn.wordpress.org/trunk@59119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-07 16:06:20 +00:00
Joe McGill
da78d523ec Editor: Add query-total block files.
This is a follow-up to [59775] to add new files that were missed in the original commit.

See #62887.

Built from https://develop.svn.wordpress.org/trunk@59776


git-svn-id: http://core.svn.wordpress.org/trunk@59118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-07 15:58:19 +00:00
Joe McGill
abb9c19aae Editor: Update packages for 6.8 pre-Betas.
Syncs @wordpress/* packages to the 'latest' npm tag.

Props mamaduka, joemcgill, youknowriad, swissspidy, sergiomdgomes, gziolo.
See #62887.

Built from https://develop.svn.wordpress.org/trunk@59775


git-svn-id: http://core.svn.wordpress.org/trunk@59117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-07 15:46:48 +00:00
Sergey Biryukov
aa804df692 Coding Standards: Use strict comparison in wp_get_archives().
Follow-up to [24], [114].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59774


git-svn-id: http://core.svn.wordpress.org/trunk@59116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-07 15:08:23 +00:00
Joe McGill
c7db6678d7 Post Thumbnails: Fix squashed featured image in wp-admin.
This updates the CSS for featured images in the classic editor that caused images to look skewed when auto-sizes are enabled.

Props maciejmackowiak, sainathpoojary, mukesh27, joemcgill.
Fixes #62597.

Built from https://develop.svn.wordpress.org/trunk@59773


git-svn-id: http://core.svn.wordpress.org/trunk@59115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-07 14:36:23 +00:00
joedolson
dd3d84dfbc General: Add styles for extender usage of do_accordion_section().
Follow up to [59224]. Add CSS to cover usage of the `do_accordion_section()` function when used in extender contexts outside of the existing WordPress core usage.

Props mboynes, jorbin, joemcgill, joedolson. 
Fixes #62907.
Built from https://develop.svn.wordpress.org/trunk@59772


git-svn-id: http://core.svn.wordpress.org/trunk@59114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 22:26:24 +00:00
Peter Wilson
55f06e4f34 Query: Add since annotation to WP_Query::$query_cache_key.
Follow up to [59766].

Props mukesh27.
See #59516.

Built from https://develop.svn.wordpress.org/trunk@59771


git-svn-id: http://core.svn.wordpress.org/trunk@59113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 20:58:23 +00:00
desrosj
16bc9210d6 External Libraries: Remove stray Unicode character in moxie.js
This fixes a `ReferenceError` caused by a stray Unicode character in the unminified version of moxie.js. This has long been fixed upstream but the library cannot be wholesale updated in WordPress because of an incompatible license change.

Because of this, a new version is being tagged, `1.3.5.1`, and the file header has been updated to make it more clear that the file is a maintained fork with a high level list of changes made.

Props kinggmobb, jorbin, q0rban, azaozz, desrosj, sukhendu2002.
Fixes #59329.
Built from https://develop.svn.wordpress.org/trunk@59770


git-svn-id: http://core.svn.wordpress.org/trunk@59112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 18:29:22 +00:00
desrosj
da65b76f52 Import: Remove Importer plugin related unit tests.
The WordPress Importer plugin has been maintained separately in a repository on GitHub since 2016. However, the unit tests were left in wordpress-develop due to the lack of a CI setup on GitHub.

With GitHub Actions set up for the plugin repository, these tests are now running in two locations. Because they are more relevant to the plugin itself, the tests have been synced, will run weekly through a `schedule` event, and are now being removed from wordpress-develop.

The only remaining test method in the `import` group covers `get_importers()`, which is a function maintained in WordPress Core itself.

Props frank-klein, netweb, dd32, peterwilsoncc, azaozz, desrosj, swissspidy.
Fixes #42668.
Built from https://develop.svn.wordpress.org/trunk@59769


git-svn-id: http://core.svn.wordpress.org/trunk@59111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 17:53:20 +00:00
desrosj
1da5ba567f Build/Test Tools: Configure UglifyJS to preserve previous behavior.
As of UglifyJS >= 3.18.0, the default behavior is to process input as an ES module. This updates the relevant configurations to ensure the build process continues to use the previous behavior to avoid JavaScript errors in the minified versions of files.

Follow up to [58563], [58586], and [59509].

Props siliconforks, nataliat2004, poena, mai21, SergeyBiryukov.
Fixes #62767. See #61519, #62220.
Built from https://develop.svn.wordpress.org/trunk@59768


git-svn-id: http://core.svn.wordpress.org/trunk@59110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 17:27:26 +00:00
Sergey Biryukov
f548f56548 Coding Standards: Use strict comparison in media_upload_library_form().
Includes bringing some consistency with a similar fragment in `WP_List_Table::months_dropdown()`.

Follow-up to [3724], [7062], [15491], [59755].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59767


git-svn-id: http://core.svn.wordpress.org/trunk@59109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 12:24:24 +00:00
Peter Wilson
38025026ac Query: Increase WP_Query cache hits for equivalent arguments.
Introduces normalization a number of arguments passed to `WP_Query` to increase cache hits for equivalent requests. For example `author__in => [ 1, 2 ]` and `author__in => [ 2, 1 ]` will now hit the same cache.

Prior to generating the SQL request and cache key, the following are sorted, made unique and type cast as appropriate.

* `post_type` when passed as an array
* `post_status` when passed as an array
* `term_query`s containing `terms`
* `cat`
* `category__in`
* `category__not_in`
* `category__and`
* `tag_slug__in`
* `tag__in`
* `tag__not_in`
* `tag__and`
* `tag_slug__in`
* `tag_slug__and`
* `post_parent__not_in`
* `author`
* `author__not_in`
* `author__in`

The following are sorted for the purposes of generating the cache key and SQL `WHERE` clause but unmodified for use in the `ORDER BY` SQL clause:

* `post_name__in`
* `post__in`
* `post_parent__in`

This commit includes changes to unrelated tests, assertions in  `Tests_Query_ParseQuery::test_parse_query_cat_array_mixed()` and `WP_Test_REST_Posts_Controller::test_get_items_not_sticky_with_exclude()` have been modified to account for the sorting of the items above.

Props thekt12, peterwilsoncc, spacedmonkey, joemcgill, flixos90, mukesh27, pbearne, swissspidy.
Fixes #59516.

Built from https://develop.svn.wordpress.org/trunk@59766


git-svn-id: http://core.svn.wordpress.org/trunk@59108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-06 05:04:24 +00:00
Sergey Biryukov
99ef157227 Docs: Update comments in wp-includes/formatting.php per the documentation standards.
Follow-up to [1345], [8662], [8786], [33624], [34761].

Props kapasias, ankitkumarshah, swissspidy, peterwilsoncc.
Fixes #62885.
Built from https://develop.svn.wordpress.org/trunk@59765


git-svn-id: http://core.svn.wordpress.org/trunk@59107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-05 23:53:25 +00:00
Mamaduka
5b8a20d134 Editor: Fix parents argument validation for Query block.
Allow passing zero (`0`) via the `parents` argument. It is a valid value for hierarchical post types, often used to display top-level items.

Props mamaduka, audrasjb, peterwilsoncc.
Fixes #62901.
Built from https://develop.svn.wordpress.org/trunk@59761


git-svn-id: http://core.svn.wordpress.org/trunk@59103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-04 09:01:17 +00:00
audrasjb
e1877c1c42 Editor: Add a fallback to WP_Block_Styles_Registry if the label is missing.
Both `name` and `label` properties are required when registering a block style. If the label is missing, assign `name` as the value for the `label`, to ensure the property is defined. This avoids a PHP warning in such case.

Props poena, Rahmohn, aaronrobertshaw, audrasjb, rinkalpagdar.
Fixes #52592.



Built from https://develop.svn.wordpress.org/trunk@59760


git-svn-id: http://core.svn.wordpress.org/trunk@59102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-04 08:42:25 +00:00
Sergey Biryukov
7975d2c6c3 Docs: Correct DocBlock formatting for the_password_form filter.
Follow-up to [59736], [59737].

See #62281.
Built from https://develop.svn.wordpress.org/trunk@59756


git-svn-id: http://core.svn.wordpress.org/trunk@59098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-04 00:32:23 +00:00
Sergey Biryukov
6e0285406d Coding Standards: Use a more meaningful variable name in WP_List_Table::months_dropdown().
As per the [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#naming-conventions Naming Conventions]:
> Don't abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.

Follow-up to [8646], [15491].

See #62279.
Built from https://develop.svn.wordpress.org/trunk@59755


git-svn-id: http://core.svn.wordpress.org/trunk@59097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-03 23:43:21 +00:00
John Blackbourn
b765f8b44c Security: Add the SensitiveParameter attribute to sensitive parameters.
Values passed to parameters with this attribute will be redacted if present in a stack trace when using PHP 8.2 or later. This reduces the chance that passwords and security keys get accidentally exposed in debug logs and bug reports.

Props petitphp, TobiasBg, jrf, johnbillion.

Fixes #57304
Built from https://develop.svn.wordpress.org/trunk@59754


git-svn-id: http://core.svn.wordpress.org/trunk@59096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-03 19:52:24 +00:00
John Blackbourn
ec037b17fa Posts, Post Types: Explicitly pass a redirect URL for the post permalink when submitting the post password form.
This allows the subsequent redirect to behave as expected if a site is using a strict referrer policy on the front end which prevents the full referrer from being sent.

Props zodiac1978, yogeshbhutkar, hbhalodia, mukesh27.

Fixes #62881
Built from https://develop.svn.wordpress.org/trunk@59753


git-svn-id: http://core.svn.wordpress.org/trunk@59095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-03 16:55:23 +00:00
John Blackbourn
b39c7d7b4b Build/Test Tools: Fix the source code path handling when installing the local development environment.
This ensures the correct code is used to run the installation depending on whether it should be running from the `src` or `build` directory.

Props swissspidy, johnbillion

See #62221
Built from https://develop.svn.wordpress.org/trunk@59752


git-svn-id: http://core.svn.wordpress.org/trunk@59094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-03 13:37:25 +00:00
Sergey Biryukov
d78ac132af Coding Standards: Use strict comparison in get_media_item().
Follow-up to [12081], [12351].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59751


git-svn-id: http://core.svn.wordpress.org/trunk@59093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-02 11:17:24 +00:00
Sergey Biryukov
6e26ca2648 Coding Standards: Use strict comparison in some legacy media functions.
Follow-up to [7062], [8653], [12188].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59750


git-svn-id: http://core.svn.wordpress.org/trunk@59092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-01 20:52:19 +00:00
John Blackbourn
fc294e0fed Build/Test Tools: Parallelise the performance tests.
This change introduces a job matrix for the "current", "before", and "base" performance tests to replace the current behaviour of running them sequentially in a single job. This speeds up the overall performance testing workflow and also reduces the chance of any given test interfering with another, for example by making a change to data in the database that affects a subsequent test.

Props johnbillion, swissspidy, dmsnell, joemcgill.

See #62221
Built from https://develop.svn.wordpress.org/trunk@59749


git-svn-id: http://core.svn.wordpress.org/trunk@59091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2025-02-01 20:17:22 +00:00