Jeremy Felt
7644e68119
Provide proper label associations and descriptions throughout the network admin
...
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.
Props cfoellmann, afercia, rianrietveld.
Fixes #38406 .
Built from https://develop.svn.wordpress.org/trunk@31517
git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:29:26 +00:00
Jeremy Felt
754636aaf1
Avoid clearing stored capabilities for a user when removing their built in role in multisite.
...
Previously, if “No role on this site” was assigned to a user AND that user did not have an empty role array stored for the site, the `$blog_prefix . ‘capabilities’` meta for that user would be deleted completely after changes to the user were saved. Any custom capabilities stored (i.e. `$user->add_role()`) would be removed as well.
This removes the code controlling the old WPMU handling of “no role” and allows custom stored capabilities to remain. Users with no role and custom capabilities will now appear in the users list table with “None” as the role.
In the process we’re able to better clarify the multisite specific pieces that do occur.
Props PeteMall, jeremyfelt.
Fixes #18934 .
Built from https://develop.svn.wordpress.org/trunk@31516
git-svn-id: http://core.svn.wordpress.org/trunk@31497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 01:34:24 +00:00
Boone Gorges
1b6bb2f183
Ensure that a request URL is always set in `WP_UnitTestCase::go_to()`.
...
Failure to set this variable meant that passing the home URL to `go_to()`
(without a trailing slash) resulted in a PHP notice, and failed to reset the
globals properly.
Props joostdevalk.
Fixes #31417 .
Built from https://develop.svn.wordpress.org/trunk@31515
git-svn-id: http://core.svn.wordpress.org/trunk@31496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 01:08:25 +00:00
Jeremy Felt
5ac75b3b0a
Use response code 200 when an existing network user joins a site via invitation.
...
Pass a response code of 200 to `wp_die()` when a user is successfully added to an individual site after using the `/newbloguser/` URL from an invite email. This is a user facing success message.
Props MikeHansenMe.
Fixes #31224 .
Built from https://develop.svn.wordpress.org/trunk@31514
git-svn-id: http://core.svn.wordpress.org/trunk@31495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 22:30:25 +00:00
Andrew Ozz
19dbf7b998
Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914 .
...
Built from https://develop.svn.wordpress.org/trunk@31513
git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:48:26 +00:00
Boone Gorges
0cd7554f75
Use PHP 5.2 compatible syntax in image tests.
...
T_PAAMAYIM_NEKUDOTAYIM, HAKUNA_MATATA, YOLO.
See [31510], #31124 .
Built from https://develop.svn.wordpress.org/trunk@31512
git-svn-id: http://core.svn.wordpress.org/trunk@31493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:42:24 +00:00
Jeremy Felt
678982ee7e
Do not activate plugins on initial installation in multisite.
...
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.
Props ianmjones.
Fixes #31327 .
Built from https://develop.svn.wordpress.org/trunk@31511
git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:30:25 +00:00
Boone Gorges
3ef981335d
Better image-type support checks in image unit tests.
...
PHP can be compiled without support for certain image types. Our unit tests
should be sensitive to these configurations.
Fixes #31124 .
Built from https://develop.svn.wordpress.org/trunk@31510
git-svn-id: http://core.svn.wordpress.org/trunk@31491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:07:25 +00:00
Sergey Biryukov
0231047071
Delegate `focusin` and `focusout` events for row actions to make sure the actions are always revealed on focus.
...
props afercia.
fixes #29765 .
Built from https://develop.svn.wordpress.org/trunk@31509
git-svn-id: http://core.svn.wordpress.org/trunk@31490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 20:14:25 +00:00
Sergey Biryukov
8eb25609e9
Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
...
props danielbachhuber.
fixes #29374 .
Built from https://develop.svn.wordpress.org/trunk@31508
git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:57:24 +00:00
Sergey Biryukov
93e5bb3702
Quick Edit: Make date fields a bit wider.
...
props Ravindra Pal Singh, janhenckens.
fixes #27912 .
Built from https://develop.svn.wordpress.org/trunk@31507
git-svn-id: http://core.svn.wordpress.org/trunk@31488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:24:25 +00:00
Sergey Biryukov
4b21c67738
Remove untranslatable period from a successful update message in `Bulk_Upgrader_Skin::add_strings()`.
...
props mako09, DrewAPicture.
fixes #30793 .
Built from https://develop.svn.wordpress.org/trunk@31506
git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:07:24 +00:00
Dominik Schilling
2b9a79db8e
Run Autoprefixer after [31504].
...
This removes media queries for Opera < 12 and `-ms-animation`/`@-ms-keyframes` which was never (dev versions excluded) supported by IE.
see #31337 .
Built from https://develop.svn.wordpress.org/trunk@31505
git-svn-id: http://core.svn.wordpress.org/trunk@31486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:00:24 +00:00
Dominik Schilling
8f83a2e48c
Update grunt-autoprefixer to 2.2.0
...
Upstream changes:
* grunt-autoprefixer: https://github.com/nDmitry/grunt-autoprefixer/compare/v1.0.1...v2.2.0
* autoprefixer-core: https://github.com/postcss/autoprefixer-core/compare/2.0.2...5.1.7
fixes #31337 .
Built from https://develop.svn.wordpress.org/trunk@31504
git-svn-id: http://core.svn.wordpress.org/trunk@31485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 16:54:33 +00:00
Sergey Biryukov
1ab9aa255e
Use correct closing tag for "Under the Hood" header on About screen.
...
props tyxla.
fixes #31402 .
Built from https://develop.svn.wordpress.org/trunk@31503
git-svn-id: http://core.svn.wordpress.org/trunk@31484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 16:44:25 +00:00
Dominik Schilling
bbbdee0e6d
Adjust our QUnit test suite to show the QUnit toolbar.
...
props iseulde.
fixes #31413 .
Built from https://develop.svn.wordpress.org/trunk@31502
git-svn-id: http://core.svn.wordpress.org/trunk@31483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 15:32:26 +00:00
Dominik Schilling
121d2ee4cb
Update POT file for Twenty Fourteen.
...
props SergeyBiryukov.
see #30972 , #30603 .
Built from https://develop.svn.wordpress.org/trunk@31501
git-svn-id: http://core.svn.wordpress.org/trunk@31482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 15:16:24 +00:00
Dominik Schilling
a748574c29
Revert [30790] and update POT file for Twenty Fifteen.
...
see #30972 , #30603 .
Built from https://develop.svn.wordpress.org/trunk@31500
git-svn-id: http://core.svn.wordpress.org/trunk@31481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 13:43:24 +00:00
Dominik Schilling
6f97715bea
i18n tools: Delete `data/not-gettexted-0-work.php`.
...
In NotGettextedTest this file is a copy of `data/not-gettexted-0.php` which will be removed after the test has finished.
Built from https://develop.svn.wordpress.org/trunk@31499
git-svn-id: http://core.svn.wordpress.org/trunk@31480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 12:56:25 +00:00
Dominik Schilling
a68ba4cd2d
i18n tools: Improve support for multi-line comments in StringExtractor.
...
props SergeyBiryukov.
fixes #30972 .
Built from https://develop.svn.wordpress.org/trunk@31498
git-svn-id: http://core.svn.wordpress.org/trunk@31479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 12:47:25 +00:00
Sergey Biryukov
f7df99549a
Themes: Add feedback for screen readers when search results are changed.
...
props obenland, joedolson.
see #26600 .
Built from https://develop.svn.wordpress.org/trunk@31497
git-svn-id: http://core.svn.wordpress.org/trunk@31478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 10:15:26 +00:00
Sergey Biryukov
224cb89878
Remove a stray single quote in `wp_insert_post()` documentation.
...
see #31359 .
Built from https://develop.svn.wordpress.org/trunk@31496
git-svn-id: http://core.svn.wordpress.org/trunk@31477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 09:50:25 +00:00
Sergey Biryukov
677d37753f
Themes: Update the theme count when searching for installed themes, like we do on Add Themes screen.
...
props afercia.
see #26600 .
Built from https://develop.svn.wordpress.org/trunk@31495
git-svn-id: http://core.svn.wordpress.org/trunk@31476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 09:41:24 +00:00
Scott Taylor
d5b80a2be2
Make sure the `grid` build does not load files from the `views` build.
...
Fix the errant back-compat assignment for `wp.media.view.Frame`.
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31494
git-svn-id: http://core.svn.wordpress.org/trunk@31475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 08:47:25 +00:00
Scott Taylor
7b8cdd61fd
Make sure the `audio-video` build does not load files from the `views` build.
...
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31493
git-svn-id: http://core.svn.wordpress.org/trunk@31474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 08:29:25 +00:00
Scott Taylor
d9a2e85bfe
Media JS files:
...
* specify globals in more files
* add missing `wp.media.*` namespace docs
* add doc blocks to files that had none
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31492
git-svn-id: http://core.svn.wordpress.org/trunk@31473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 07:25:27 +00:00
Scott Taylor
9737acc1a5
Specify globals in media JS files - it is important to denote where we are diverging from dependency injection.
...
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31491
git-svn-id: http://core.svn.wordpress.org/trunk@31472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 06:56:27 +00:00
Scott Taylor
8b54658f0c
After [30120], in media JS files, move from `@constructor` to `@class` annotations as per JSDoc preferred nomenclature: http://usejsdoc.org/tags-class.html
...
See #28510 , #30193 .
Built from https://develop.svn.wordpress.org/trunk@31490
git-svn-id: http://core.svn.wordpress.org/trunk@31471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 06:28:26 +00:00
Scott Taylor
117a0518fd
The `grid` build should not load `views/edit-image`, it already exists in the `views` build.
...
`views/edit-image.js` doesn't need to set a `render` method if it doesn't override its parent.
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31489
git-svn-id: http://core.svn.wordpress.org/trunk@31470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 06:21:25 +00:00
Scott Taylor
8babe839e3
JSHint after [31487].
...
Built from https://develop.svn.wordpress.org/trunk@31488
git-svn-id: http://core.svn.wordpress.org/trunk@31469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 05:57:28 +00:00
Scott Taylor
6848035d1a
Restore the changes I made in [31016] for chromeless Vimeo that were missed in [31373].
...
Make sure that the build file for `grid` doesn't load `views/media-details.js`, it already exists in the `audio-video` build.
See #29267 , #28510 .
Built from https://develop.svn.wordpress.org/trunk@31487
git-svn-id: http://core.svn.wordpress.org/trunk@31468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 05:38:27 +00:00
Drew Jaynes
1ffca1fcb6
Clarify and complete default argument documentation for `wp_insert_post()`.
...
Props atimmer, SergeyBiryukov.
Fixes #31359 .
Built from https://develop.svn.wordpress.org/trunk@31486
git-svn-id: http://core.svn.wordpress.org/trunk@31467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 00:56:29 +00:00
Andrew Ozz
0fa4845eec
TinyMCE wpView: don't insert nested paragraphs when inserting embeddable URLs. Props iseulde, fixes #29526 .
...
Built from https://develop.svn.wordpress.org/trunk@31485
git-svn-id: http://core.svn.wordpress.org/trunk@31466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 23:17:27 +00:00
Sergey Biryukov
3c64d94ba9
Fix typo in [30760].
...
props afercia.
fixes #31393 .
Built from https://develop.svn.wordpress.org/trunk@31484
git-svn-id: http://core.svn.wordpress.org/trunk@31465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 17:09:28 +00:00
Sergey Biryukov
109295cdd4
When creating a new user, pasting a password should update the password strength indicator.
...
props dipesh.kakadiya.
fixes #31226 .
Built from https://develop.svn.wordpress.org/trunk@31483
git-svn-id: http://core.svn.wordpress.org/trunk@31464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 13:05:27 +00:00
Drew Jaynes
64bc6934f1
Add an entry to the changelog for `twentyfourteen_post_thumbnail()` noting that it was made 'pluggable'.
...
Fixes #31374 .
Built from https://develop.svn.wordpress.org/trunk@31482
git-svn-id: http://core.svn.wordpress.org/trunk@31463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 10:35:28 +00:00
Lance Willett
5dc3b77be3
Twenty Fourteen: make `twentyfourteen_post_thumbnail()` pluggable.
...
Fixes #31374 , props wordpressorru.
Built from https://develop.svn.wordpress.org/trunk@31481
git-svn-id: http://core.svn.wordpress.org/trunk@31462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-19 19:43:28 +00:00
Sergey Biryukov
add5f9bdf2
Remove `src` from duplicate hook comments for `get_avatar` and `get_avatar_data`.
...
see #21195 .
Built from https://develop.svn.wordpress.org/trunk@31480
git-svn-id: http://core.svn.wordpress.org/trunk@31461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-19 14:59:26 +00:00
Sergey Biryukov
01bb8478ff
Fix a typo in duplicate hook comment.
...
see [31107], #21195 .
Built from https://develop.svn.wordpress.org/trunk@31479
git-svn-id: http://core.svn.wordpress.org/trunk@31460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-19 14:56:28 +00:00
Boone Gorges
ec8aef8233
Respect 'default_option_' filters during early sanity checks in `add_option()` and `update_option()`.
...
`add_option()` and `update_option()` both call `get_option()` to compare the
value passed to the function with any existing value for the given option name.
When a `'default_option_'` filter is in place to change the default value of
an option, `add_option()` and `update_option()` ought to check against the
filtered value, rather than a hardcoded `false`, in order to determine whether
a prior value exists.
Props GregLone, tyxla.
Fixes #31047 .
Built from https://develop.svn.wordpress.org/trunk@31473
git-svn-id: http://core.svn.wordpress.org/trunk@31454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-18 19:14:27 +00:00
Aaron Jorbin
911f8d952a
Restore PHP 5.2 to Travis CI
...
Travis restored PHP 5.2 support late last week.
upstream: https://github.com/travis-ci/travis-ci/issues/3152
Props netweb for the heads up
Fixes #31244
Built from https://develop.svn.wordpress.org/trunk@31472
git-svn-id: http://core.svn.wordpress.org/trunk@31453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-18 17:47:27 +00:00
Andrew Ozz
21225211d8
Add SVN eol-style = native where missing.
...
Built from https://develop.svn.wordpress.org/trunk@31471
git-svn-id: http://core.svn.wordpress.org/trunk@31452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-17 21:37:26 +00:00
Andrew Ozz
e054ee5f05
Add eol-style property and normalize EOLs.
...
Built from https://develop.svn.wordpress.org/trunk@31470
git-svn-id: http://core.svn.wordpress.org/trunk@31451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-17 19:34:27 +00:00
Boone Gorges
2686db917a
Improved handling of expectedDeprecated and expectedIncorrectUsage annotations in unit tests.
...
* Do the `expectedDeprecated()` check in `assertPostConditions()` instead of `tearDown()`. Previously, `fail`ing inside of `tearDown()` was causing the rest of the teardown process to be aborted, resulting in inter-test leakage.
* Collect all `expectedDeprecated` and `expectedIncorrectUsage` annotations in an entire method and display them all when `fail`ing, instead of showing only the first one.
Props jdgrimes.
Fixes #31362 .
Built from https://develop.svn.wordpress.org/trunk@31469
git-svn-id: http://core.svn.wordpress.org/trunk@31450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-17 16:12:28 +00:00
Boone Gorges
a224ff7d9b
Improve 'orderby' syntax for `WP_Comment_Query`.
...
Since [29027], `WP_Query` has supported an array of values for the `$orderby`
parameter, with field names as array keys and ASC/DESC as the array values.
This changeset introduces the same syntax to `WP_Comment_Query`.
We leverage the new support for multiple ORDER BY clauses to fix a bug that
causes comments to be queried in an indeterminate order when sorting by the
default `comment_date_gmt` and comments share the same value for
`comment_date_gmt`. By always including a `comment_ID` subclause at the end of
the ORDER BY statement, we ensure that comments always have a unique fallback
for sorting.
This changeset also includes improvements paralleling those introduced to
`WP_Query` in [31312] and [31340], which allow `$orderby` to accept array keys
from specific `$meta_query` clauses. This change lets devs sort by multiple
clauses of an associated meta query. See #31045 .
Fixes #30478 . See #31265 .
Built from https://develop.svn.wordpress.org/trunk@31467
git-svn-id: http://core.svn.wordpress.org/trunk@31448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-16 14:10:27 +00:00
Andrew Ozz
5715db82d4
TinyMCE wpView: fire `nodeChanged` when an embedded iframe is resized so we can adjust the editor height and other UI components. Props iseulde, fixes #30646 .
...
Built from https://develop.svn.wordpress.org/trunk@31466
git-svn-id: http://core.svn.wordpress.org/trunk@31447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-15 18:19:27 +00:00
Dominik Schilling
7bd3ea7da9
`grunt autoprefixer` for [31333].
...
see ##29820.
Built from https://develop.svn.wordpress.org/trunk@31465
git-svn-id: http://core.svn.wordpress.org/trunk@31446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-15 12:18:25 +00:00
Lance Willett
52e5bc2eee
Bundled themes: update CSS rules for `.screen-reader-text` to be consistent with current accessibility guidelines. Fixes #31279 .
...
Built from https://develop.svn.wordpress.org/trunk@31464
git-svn-id: http://core.svn.wordpress.org/trunk@31445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 17:29:29 +00:00
Drew Jaynes
c384ed989f
Add inline documentation to clarify the reasoning behind the various conditions that control how WP is loaded.
...
Props mattheweppelsheimer for the initial patch.
Fixes #30935 .
Built from https://develop.svn.wordpress.org/trunk@31463
git-svn-id: http://core.svn.wordpress.org/trunk@31444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 11:39:27 +00:00
Sergey Biryukov
19a43125cd
Don't try to read a non-existent Exif:Title tag in `wp_read_image_metadata()`, as it's not a part of the Exif standard.
...
props tyxla.
fixes #31043 .
Built from https://develop.svn.wordpress.org/trunk@31462
git-svn-id: http://core.svn.wordpress.org/trunk@31443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 09:14:28 +00:00