WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
31,787 Commits 49 Branches 747 Tags 953 MiB
Commit Graph

19022 Commits

Author SHA1 Message Date
Boone Gorges 18d6b3c8dc Force comment pagination on single posts. 
Previously, the 'page_comments' toggle allowed users to disable comment
pagination. This toggle was only superficial, however. Even with
'page_comments' turned on, `comments_template()` loaded all of a post's
comments into memory, and passed them to `wp_list_comments()` and
`Walker_Comment`, the latter of which produced markup for only the
current page of comments. In other words, it was possible to enable
'page_comments', thereby showing only a subset of a post's comments on a given
page, but all comments continued to be loaded in the background. This technique
scaled poorly. Posts with hundreds or thousands of comments would load slowly,
or not at all, even when the 'comments_per_page' setting was set to a
reasonable number.

Recent changesets have addressed this problem through more efficient tree-
walking, better descendant caching, and more selective queries for top-level
post comments. The current changeset completes the project by addressing the
root issue: that loading a post causes all of its comments to be loaded too.

Here's the breakdown:

* Comment pagination is now forced. Setting 'page_comments' to false leads to evil things when you have many comments. If you want to avoid pagination, set 'comments_per_page' to something high.
* The 'page_comments' setting has been expunged from options-discussion.php, and from places in the codebase where it was referenced. For plugins relying on 'page_comments', we now force the value to `true` with a `pre_option` filter.
* `comments_template()` now queries for an appropriately small number of comments. Usually, this means the `comments_per_page` value.
* To preserve the current (odd) behavior for comment pagination links, some unholy hacks have been inserted into `comments_template()`. The ugliness is insulated in this function for backward compatibility and to minimize collateral damage. A side-effect is that, for certain settings of 'default_comments_page', up to 2x the value of `comments_per_page` might be fetched at a time.
* In support of these changes, a `$format` parameter has been added to `WP_Comment::get_children()`. This param allows you to request a flattened array of comment children, suitable for feeding into `Walker_Comment`.
* `WP_Query` loops are now informed about total available comment counts and comment pages by the `WP_Comment_Query` (`found_comments`, `max_num_pages`), instead of by `Walker_Comment`.

Aside from radical performance improvements in the case of a post with many
comments, this changeset fixes a bug that caused the first page of comments to
be partial (`found_comments` % `comments_per_page`), rather than the last, as
you'd expect.

Props boonebgorges, wonderboymusic.
Fixes #8071.
Built from https://develop.svn.wordpress.org/trunk@34561


git-svn-id: http://core.svn.wordpress.org/trunk@34525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 20:40:25 +00:00
Drew Jaynes 66242cbc98 Docs: Improve the method docs for the `widget()`, `update()`, `form()`, and `__construct()` methods in the `WP_Widget` base class. 
See #34013. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34560


git-svn-id: http://core.svn.wordpress.org/trunk@34524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 20:31:24 +00:00
Scott Taylor 5ea01de963 XML-RPC: Introduce the concept of unit testing to `wp_xmlrpc_server::wp_newComment()`: 
* Don't allow comments to be created for posts that have `comment_status` set to `'closed'`
* Set some magic props on `WP_User` to vars before passing them to `wp_xmlrpc_server::escape()`

Props wonderboymusic, jesin.
Fixes #27471.

Built from https://develop.svn.wordpress.org/trunk@34559


git-svn-id: http://core.svn.wordpress.org/trunk@34523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 20:20:23 +00:00
Aaron Jorbin e6970878a0 Fix tabs vs spaces in .travis.yml 
Introduced in [34555] . Bad Jorbin.


Built from https://develop.svn.wordpress.org/trunk@34558


git-svn-id: http://core.svn.wordpress.org/trunk@34522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 20:13:24 +00:00
Weston Ruter 885944f79f Customizer: Fix usage of `jQuery.contains()` allowing `active` state changes to again animate control visibility. 
Aligns usage of `jQuery.contains()` in a control's `onChangeActive` method with the existing usage in the corresponding `onChangeActive` method for panels and sections.

Props nikeo.
Fixes #33509.

Built from https://develop.svn.wordpress.org/trunk@34557


git-svn-id: http://core.svn.wordpress.org/trunk@34521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:54:50 +00:00
Helen Hou-Sandí e3dd4b7f4f Shortlinks: Hide the Get Shortlink button by default. 
Shortlinks had their day in the popular usage sun before all these services moved to their own shorteners and running your own custom one became a lot easier. Shortlinks are still useful in some contexts, such as analytics or when links need to be shared verbally or copied down by hand.

If any filters are hooked onto `pre_get_shortlink` or `get_shortlink` and produce a non-empty value (with an exception described below), the button will magically reappear. This allows any custom shortlinks to keep the button without hiccups.

If you're in need of the default shortlinks, the fastest way to reenable them is `add_filter( 'pre_get_shortlink', '__return_false' )`. Note that it must return false in order to continue on to the rest of `wp_get_shortlink()`.

props grvrulz for the initial patch.
fixes #33495.

Built from https://develop.svn.wordpress.org/trunk@34556


git-svn-id: http://core.svn.wordpress.org/trunk@34520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:54:25 +00:00
Aaron Jorbin a6fecf0aa0 Add Travis Notifications to the #core channel on Slack 
This is hopefully the final attempt at adding notifications to the #core channel on Slack. By default, Travis spams the channel. In order to cut that down a bit, notifications are set as follows:
 - On Failure: Always (If the tests fail, the world needs to know)
 - On Success: Change (this means that the first green run after a red run aka, the world is happy again)
 - On Start: Never (Travis runs every time there is a commit. No need for a notification)

Props Netweb, samuelsidler
Fixes #30755


Built from https://develop.svn.wordpress.org/trunk@34555


git-svn-id: http://core.svn.wordpress.org/trunk@34519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:43:25 +00:00
Weston Ruter aedb4c3ee2 Customizer: Flesh out phpdoc description for `_wp_customize_include()`. 
Also add brackets around single-statement inline `if` statement.

Fixes #33488.

Built from https://develop.svn.wordpress.org/trunk@34554


git-svn-id: http://core.svn.wordpress.org/trunk@34518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:36:25 +00:00
Drew Jaynes 6f81ec0a2a Docs: Add a missing summary, version, and tag descriptions to the DocBlock for `WP_Widget_Text::widget()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34553


git-svn-id: http://core.svn.wordpress.org/trunk@34517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:24:24 +00:00
Drew Jaynes 54d5888688 Widgets: Pass `$this` to the `widget_text` filter to make targeting specific widget instances easier. 
Also fixes docs errors in the type and description for the `$instance` parameter, introduced in [27697].

Fixes #24605.

Built from https://develop.svn.wordpress.org/trunk@34552


git-svn-id: http://core.svn.wordpress.org/trunk@34516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:21:24 +00:00
John Blackbourn a729efa688 Implement 'Recently Active' functionality for network-wide plugins in the Network Admin. 
Fixes #20468
Thanks to WordCamp RI attendees for testing!

Built from https://develop.svn.wordpress.org/trunk@34551


git-svn-id: http://core.svn.wordpress.org/trunk@34515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 19:16:27 +00:00
Boone Gorges 6ebc79e80c Hierarchical comment query tests should be order-agnostic. 
Travis-CI and other test environments can create weird race conditions.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@34550


git-svn-id: http://core.svn.wordpress.org/trunk@34514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 15:29:23 +00:00
Boone Gorges 07dab62c98 Remove debug cruft, introduced in [34546]. 
Props ocean90.
See #8071.
Built from https://develop.svn.wordpress.org/trunk@34549


git-svn-id: http://core.svn.wordpress.org/trunk@34513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 15:26:25 +00:00
Boone Gorges d0185d4dde Normalize whitespace in `WP_Comment_Query` documentation. 
Built from https://develop.svn.wordpress.org/trunk@34548


git-svn-id: http://core.svn.wordpress.org/trunk@34512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 15:25:25 +00:00
Sergey Biryukov 105d99613a Plugin Editor: Don't split the strings with plugin file name and remove unnecessary context. 
Partially reverts [34341].

Fixes #31862.
Built from https://develop.svn.wordpress.org/trunk@34547


git-svn-id: http://core.svn.wordpress.org/trunk@34511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 15:19:24 +00:00
Boone Gorges fc854a837f Introduce hierarchical query support to `WP_Comment_Query`. 
Comments can be threaded. Now your query can be threaded too! Bonus: it's
not totally insane.

* The new `$hierarchical` parameter for `WP_Comment_Query` accepts three values:
  * `false` - Default value, and equivalent to current behavior. No descendants are fetched for matched comments.
  * `'flat'` - `WP_Comment_Query` will fetch the descendant tree for each comment matched by the query paramaters, and append them to the flat array of comments returned. Use this when you have a separate routine for constructing the tree - for example, when passing a list of comments to a `Walker` object.
  * `'threaded'` - `WP_Comment_Query` will fetch the descendant tree for each comment, and return it in a tree structure located in the `children` property of the `WP_Comment` objects.
* `WP_Comment` now has a few utility methods for fetching the descendant tree (`get_children()`), fetching a single direct descendant comment (`get_child()`), and adding anothing `WP_Comment` object as a direct descendant (`add_child()`). Note that `add_child()` only modifies the comment object - it does not touch the database.

Props boonebgorges, wonderboymusic.
See #8071.
Built from https://develop.svn.wordpress.org/trunk@34546


git-svn-id: http://core.svn.wordpress.org/trunk@34510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 15:13:24 +00:00
Boone Gorges 4c18ad595e Improve status checks when sending comment post author notification. 
[34537] hooked `wp_new_comment_notify_postauthor()` to the
'wp_set_comment_status' when a comment had been approved. When performing
multiple actions on a comment in the same request (as happens in
`Tests_Ajax_DeleteComment::test_ajax_trash_double_action()`, and may happen
sometimes in real life too), and when one of those actions involves deleting
the comment, the `$comment_ID` passed to `wp_new_comment_notify_postauthor()`
can correspond to an already-deleted comment. The `comment_status` check should
account for this possibility.

See #14078.
Built from https://develop.svn.wordpress.org/trunk@34545


git-svn-id: http://core.svn.wordpress.org/trunk@34509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 14:43:24 +00:00
Boone Gorges fea3051f54 Improve pagination internals in `WP_Comment_Query`. 
`WP_Comment_Query` will now report the total number of comments matching the
query params (`comments_found`), as well as the total number of pages required
to display these comments (`max_num_pages`). Because `SQL_CALC_FOUND_ROWS`
queries can introduce a lot of overhead in some cases, we disable the feature
by default. Pass `no_found_rows=false` to `WP_Comment_Query` to enable the
count. (We use the negative parameter name 'no_found_rows' for parity with
`WP_Query`.)

Props wonderboymusic, boonebgorges.
See #8071.
Built from https://develop.svn.wordpress.org/trunk@34544


git-svn-id: http://core.svn.wordpress.org/trunk@34508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 14:35:24 +00:00
John Blackbourn c69ec5a19a Introduce a `send_update_notification_email` which controls whether an update notification email is sent for background updates. This filter allows control over each of the update types (plugin, theme, translation) and compliments the `automatic_updates_send_debug_email` and `send_core_update_notification_email` filters. 
Fixes #33932
Props ronalfy

Built from https://develop.svn.wordpress.org/trunk@34543


git-svn-id: http://core.svn.wordpress.org/trunk@34507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 14:29:23 +00:00
Boone Gorges 4b467a2698 Store SQL clauses in `WP_Comment_Query` property. 
This small syntax change paves the way for some improvements related to #8071.
Built from https://develop.svn.wordpress.org/trunk@34542


git-svn-id: http://core.svn.wordpress.org/trunk@34506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 14:09:25 +00:00
Scott Taylor 8a8e6557d0 Revisions: add a `'wp_prepare_revision_for_js'` filter. 
Props jtsternberg, adamsilverstein.
Fixes #28627.

Built from https://develop.svn.wordpress.org/trunk@34541


git-svn-id: http://core.svn.wordpress.org/trunk@34505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 14:04:24 +00:00
Boone Gorges 1de01f31bc Don't run `get_page_of_comment()` cache test on Multisite. 
`get_page_of_comment()` uses `get_option()`, and WP_INSTALLING earlier in the
test suite causes `get_option()` to miss the cache. See #31130.

See #11334.
Built from https://develop.svn.wordpress.org/trunk@34540


git-svn-id: http://core.svn.wordpress.org/trunk@34504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 13:55:25 +00:00
Scott Taylor fa58223b49 Profile: when clicking "Generate Password", toggling visibility, then canceling, ensure that the UI resets properly for when the "Generate Password" button is clicked again. 
Props umesh.nevase.
Fixes #33897.

Built from https://develop.svn.wordpress.org/trunk@34539


git-svn-id: http://core.svn.wordpress.org/trunk@34503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 13:54:24 +00:00
Boone Gorges ff7df78e04 Bust term query cache when modifying term meta. 
The 'last_changed' incrementor is used to invalidate the `get_terms()` query
cache. Since `get_terms()` queries may reference 'meta_query', changing term
metadata could change the results of the queries. So we invalidate the cache
on add, delete, and update.

See #10142.
Built from https://develop.svn.wordpress.org/trunk@34538


git-svn-id: http://core.svn.wordpress.org/trunk@34502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 13:47:25 +00:00
Boone Gorges eaaabd4105 Send comment approval notification to post author via hook. 
This is part of the project of #33587.

Moving this particular message to the
'wp_set_comment_status' action has the added bonus that the notification is
sent after the comment status has been updated in the database. Previously, a
database error could lead to a case where an approval notification is sent,
but the comment status change fails for some reason.

Props mrmist, NickDuncan.
Fixes #14078.
Built from https://develop.svn.wordpress.org/trunk@34537


git-svn-id: http://core.svn.wordpress.org/trunk@34501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 05:37:25 +00:00
Boone Gorges cb586896c6 Introduce 'duplicate_comment_id' filter. 
`wp_allow_comment()` disallows a comment if it matches a comment on the same
post with the same content, author email, and parent. This new filter allows
developers to circumvent or modify this logic, making the duplicate check
more or less lenient, as they see fit.

Fixes #9775.
Built from https://develop.svn.wordpress.org/trunk@34536


git-svn-id: http://core.svn.wordpress.org/trunk@34500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 05:23:28 +00:00
Boone Gorges e2c57a9451 Use `WP_Comment_Query` in `get_page_of_comment()`. 
This change allows `get_page_of_comment()` to use `WP_Comment_Query`'s native
caching mechanisms.

Props boonebgorges, Viper007Bond, wmertens, jeremyfelt.
Fixes #11334.
Built from https://develop.svn.wordpress.org/trunk@34535


git-svn-id: http://core.svn.wordpress.org/trunk@34499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 05:11:25 +00:00
Boone Gorges fd946a9b5a Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@34534


git-svn-id: http://core.svn.wordpress.org/trunk@34498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 04:44:25 +00:00
Boone Gorges 2370a81286 Allow metadata to be attached to comment at time of creation. 
The new `$comment_meta` parameter of `wp_insert_comment()` allows an array of
key/value pairs to be passed when creating a comment. These pairs are then
stored as commentmeta when the comment has been created.

Props tellyworth, wonderboymusic.
Fixes #12431.
Built from https://develop.svn.wordpress.org/trunk@34533


git-svn-id: http://core.svn.wordpress.org/trunk@34497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 04:41:25 +00:00
Boone Gorges 7c0ff60cb8 After [34529], fix multisite site creation test. 
The test `Tests_Multisite_Site::test_created_site_details()` checks for tables
that should be empty on a newly created MS site. `termmeta` is now one of those
tables.

See #10142.
Built from https://develop.svn.wordpress.org/trunk@34532


git-svn-id: http://core.svn.wordpress.org/trunk@34496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 04:32:27 +00:00
Boone Gorges 37e4c2dbac Introduce 'paged' parameter for `WP_User_Query`. 
This is an alternative to using 'offset', and manually calculating pagination.
Note that 'paged' works only in conjunction with 'number', the latter of which
provides the per-page value.

Props sebastian.pisula.
Fixes #25145.
Built from https://develop.svn.wordpress.org/trunk@34531


git-svn-id: http://core.svn.wordpress.org/trunk@34495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 04:26:29 +00:00
Boone Gorges 563d70aa0d After [34529], normalize documentation for `get_terms()` and `wp_get_object_terms()`. 
See #10142.
Built from https://develop.svn.wordpress.org/trunk@34530


git-svn-id: http://core.svn.wordpress.org/trunk@34494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 04:05:24 +00:00
Boone Gorges 8b4a5d1ec0 Introduce metadata for taxonomy terms. 
Adds a new table to the database schema (`wp_termmeta`), and a set of
`*_term_meta()` API functions. `get_terms()` and `wp_get_object_terms()`
now also support 'meta_query' parameters, with syntax identical to other
uses of `WP_Meta_Query`.

When fetching terms via `get_terms()` or `wp_get_object_terms()`, metadata for
matched terms is preloaded into the cache by default. Disable this behavior
by setting the new `$update_term_meta_cache` paramater to `false`.

To maximize performance, within `WP_Query` loops, the termmeta cache is *not*
primed by default. Instead, we use a lazy-loading technique: metadata for all
terms belonging to posts in the loop is loaded into the cache the first time
that `get_term_meta()` is called within the loop.

Props boonebgorges, sirzooro.
See #10142.
Built from https://develop.svn.wordpress.org/trunk@34529


git-svn-id: http://core.svn.wordpress.org/trunk@34493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 03:59:27 +00:00
Scott Taylor 80974b0db6 Links: in `get_adjacent_post()`, add a `"get_{$adjacent}_post_excluded_terms"` filter. 
Props rmccue, Japh, MikeHansenMe.
Fixes #9571.

Built from https://develop.svn.wordpress.org/trunk@34528


git-svn-id: http://core.svn.wordpress.org/trunk@34492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 02:38:25 +00:00
Scott Taylor e87150fc06 Comments List Table: after [34179], scope the `<th>`s and `<td>`s as direct descendants of their parent row. 
Fixes #33943.

Built from https://develop.svn.wordpress.org/trunk@34527


git-svn-id: http://core.svn.wordpress.org/trunk@34491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 02:21:26 +00:00
John Blackbourn b27d9015e1 Update the oEmbed endpoint URL for Photobucket. 
Fixes #33783

Built from https://develop.svn.wordpress.org/trunk@34526


git-svn-id: http://core.svn.wordpress.org/trunk@34490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 22:03:25 +00:00
Scott Taylor 498b2d7e33 Comments: In `comment_form()`, move the comment textarea to the top for logged-out users when replying, improves keyboard/focus navigation. 
Rehabilitate errant tabbing and extra unnecessary `<?php ?>` toggling.

Props afercia, adamsilverstein.
Fixes #29974.

Built from https://develop.svn.wordpress.org/trunk@34525


git-svn-id: http://core.svn.wordpress.org/trunk@34489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 22:00:28 +00:00
Scott Taylor 59279c5f8b Comments: In `get_comment_statuses()`, also return `trash`. 
XML-RPC: In `wp_xmlrpc_server::wp_editComment()`, allow comments to be trashed.

Introduce unit tests for `wp_editComment` in `xmlrpc/*` #NeverForget

Props tyxla, wonderboymusic.
Fixes #30965.

Built from https://develop.svn.wordpress.org/trunk@34524


git-svn-id: http://core.svn.wordpress.org/trunk@34488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 21:48:27 +00:00
Scott Taylor 2c23ca7411 Comments: in `comment_form()`, add args for `cancel_reply_before` and `cancel_reply_after` to eradicate remaining hard-coded HTML bits. 
Props MikeHansenMe.
Fixes #23797.


Built from https://develop.svn.wordpress.org/trunk@34523


git-svn-id: http://core.svn.wordpress.org/trunk@34487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 21:33:26 +00:00
Scott Taylor 223a2d0f7b Comments: in `check_comment_flood_db()`, don't throttle moderators. If the commenter is logged in, check against their `user_id` instead of `comment_author_IP`. 
Throwback: "If you can edit comments on the post, 'Slow down Cowboy' shouldn't kick in."

Props garyc40, wonderboymusic.
Fixes #16219.

Built from https://develop.svn.wordpress.org/trunk@34522


git-svn-id: http://core.svn.wordpress.org/trunk@34486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 21:22:25 +00:00
Dominik Schilling df3098f36d Plugins: Don't use `_n()` for singular/plural strings which have no placeholder for a number. 
Fixes #33239.
See #28502.
Built from https://develop.svn.wordpress.org/trunk@34521


git-svn-id: http://core.svn.wordpress.org/trunk@34485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 21:07:25 +00:00
Scott Taylor 169db9dbb1 Comments: add a `'comment_excerpt_length'` filter to `get_comment_excerpt()`. 
Create the first ever unit tests for `get_comment_excerpt()`.

Props dannydehaan, wonderboymusic.
Fixes #27526.

Built from https://develop.svn.wordpress.org/trunk@34520


git-svn-id: http://core.svn.wordpress.org/trunk@34484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 21:05:25 +00:00
John Blackbourn 92fb281b71 Use `WP_TESTS_DOMAIN` where it should be used in tests in place of hard-coded uses of `example.org`. 
Also corrects a test value in the data provider for `Tests_Sanitize_Option::test_sanitize_option()` which was only consequentially passing.

Fixes #34000

Built from https://develop.svn.wordpress.org/trunk@34519


git-svn-id: http://core.svn.wordpress.org/trunk@34483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 21:02:26 +00:00
John Blackbourn ee04cc0638 Another missed file from [34172]. 
See #33877

Built from https://develop.svn.wordpress.org/trunk@34518


git-svn-id: http://core.svn.wordpress.org/trunk@34482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 20:33:26 +00:00
Scott Taylor 44822831fe Comments List Table JS: move the dynamic count functions into closure scope so that `setCommentsList` AND `commentReply` can access them. Update counts when replying inline. 
Fixes #33403.

Built from https://develop.svn.wordpress.org/trunk@34517


git-svn-id: http://core.svn.wordpress.org/trunk@34481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 20:16:49 +00:00
John Blackbourn bef8977ea1 Add a `@since` entry for the implementation of the `$public` argument in `register_taxonomy()`. 
See #21949

Built from https://develop.svn.wordpress.org/trunk@34516


git-svn-id: http://core.svn.wordpress.org/trunk@34480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 20:16:26 +00:00
Scott Taylor 79974ac413 Edit Post: in the logic determining whether to display the Comments meta box, check for the current post status in `get_post_stati( array( 'public' => true ) )` instead of just checking `publish` and `private`. Ensure that `private` is checked in both instances. 
Props Thaicloud, wonderboymusic.
Fixes #24486.

Built from https://develop.svn.wordpress.org/trunk@34515


git-svn-id: http://core.svn.wordpress.org/trunk@34479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 20:02:24 +00:00
Scott Taylor bf04b211a4 Widgets: use `input[type="number"]` for the `number` prop in the Recent Posts and Recent Comments widget forms. 
Props helen, obenland, mordauk.
Fixes #22965.

Built from https://develop.svn.wordpress.org/trunk@34514


git-svn-id: http://core.svn.wordpress.org/trunk@34478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 19:53:26 +00:00
John Blackbourn 949b6ee1df Convert the `$args` passed to `register_post_type()` into an array before passing them to the new `register_post_type_args` filter. 
Fixes #17447

Built from https://develop.svn.wordpress.org/trunk@34513


git-svn-id: http://core.svn.wordpress.org/trunk@34477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 19:39:25 +00:00
Drew Jaynes f84c653fad Docs: Clarify the summary and optional `$query` parameter description for `remove_query_arg()`. 
Props johnbillion.
Fixes #33912.

Built from https://develop.svn.wordpress.org/trunk@34512


git-svn-id: http://core.svn.wordpress.org/trunk@34476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 19:34:24 +00:00
Drew Jaynes 92574015aa Docs: Overhaul the DocBlock for `add_query_arg()` to attempt to better explain the various call signatures it accepts. 
Also adds a couple of in-DocBlock examples illustrating single key and value, and associative array usage. Retains the note about the unescaped return value.

Props johnbillion.
See #33912.

Built from https://develop.svn.wordpress.org/trunk@34511


git-svn-id: http://core.svn.wordpress.org/trunk@34475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 19:32:24 +00:00
Drew Jaynes a6c8b7aafa Docs: Convert the `$args` parameter description in the `register_taxonomy()` DocBlock to a hash notation. 
Also standardizes the DocBlock summary.

Props johnbillion.
Fixes #33991.

Built from https://develop.svn.wordpress.org/trunk@34510


git-svn-id: http://core.svn.wordpress.org/trunk@34474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 19:12:26 +00:00
Drew Jaynes 4c7a4bfb25 Docs: Improve the summary and description for the `pre_http_request` filter docs to better illustrate expected values. 
The filter explicitly expects one of three passed value types:

*  An array containing 'headers', 'body', 'response', 'cookies', and 'filename' elements
*  A `WP_Error` instance
*  Boolean false (to avoid short-circuiting the response)

Props johnbillion.
Fixes #33995.

Built from https://develop.svn.wordpress.org/trunk@34509


git-svn-id: http://core.svn.wordpress.org/trunk@34473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 18:52:25 +00:00
Andrea Fercia 6fdd384fe0 Comments List Table: fix the translators comment for all count after [34506]. 
See #17275.
Built from https://develop.svn.wordpress.org/trunk@34508


git-svn-id: http://core.svn.wordpress.org/trunk@34472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 18:40:24 +00:00
John Blackbourn cb740147be Add `$depth` as a parameter in the `nav_menu_item_args` filter. 
Fixes #29417

Built from https://develop.svn.wordpress.org/trunk@34507


git-svn-id: http://core.svn.wordpress.org/trunk@34471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 17:59:24 +00:00
Scott Taylor 4671e03766 Comments List Table: include count for "All". Dynamically update. 
Fixes #17275.

Built from https://develop.svn.wordpress.org/trunk@34506


git-svn-id: http://core.svn.wordpress.org/trunk@34470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 17:57:25 +00:00
John Blackbourn 41edf2bc22 Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it. 
Fixes #33310
Props prasad-nevase, metodiew

Built from https://develop.svn.wordpress.org/trunk@34505


git-svn-id: http://core.svn.wordpress.org/trunk@34469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 17:49:25 +00:00
Scott Taylor bc5eb3a623 Comments: add `date` column to `WP_Comments_List_Table` to allow sorting and to break out the date/time from the comment content column. 
Props jshreve.
Fixes #15520.

Built from https://develop.svn.wordpress.org/trunk@34504


git-svn-id: http://core.svn.wordpress.org/trunk@34468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 17:27:26 +00:00
Scott Taylor 595bad9f37 Comments: In `comments_template()`, set `$wp_query->comments_by_type` to empty array if not separating comments. The value becomes stale otherwise. Edge case. 
Props jakub.tyrcha.
Fixes #14809.

Built from https://develop.svn.wordpress.org/trunk@34503


git-svn-id: http://core.svn.wordpress.org/trunk@34467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 16:31:24 +00:00
Drew Jaynes b818747870 Docs: Add more explicit optional parameter types and return descriptions in the DocBlocks for `is_page()`, `is_single()`, `is_singular()`. 
Also adds explicit types and return descriptions to the corresponding `WP_Query` methods: `WP_Query::is_page()`, `WP_Query::is_single()`, and `WP_Query::is_singular()`.

Props Shelob9 for the initial patch.
Fixes #33907.

Built from https://develop.svn.wordpress.org/trunk@34502


git-svn-id: http://core.svn.wordpress.org/trunk@34466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 16:18:24 +00:00
Dominik Schilling 38b561e8df Twenty Fifteen: Add a missing comma in rtl.css. 
Props Toro_Unit.
Fixes #33985.
Built from https://develop.svn.wordpress.org/trunk@34501


git-svn-id: http://core.svn.wordpress.org/trunk@34465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 16:03:24 +00:00
Scott Taylor 5b9af35c4c Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget. 
Fixes #10422.

Built from https://develop.svn.wordpress.org/trunk@34500


git-svn-id: http://core.svn.wordpress.org/trunk@34464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 15:53:25 +00:00
Drew Jaynes 9dba452afc Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes. 
Standardizes summaries and tags for the following classes:

* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34499


git-svn-id: http://core.svn.wordpress.org/trunk@34463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:54:25 +00:00
Drew Jaynes dae68e1485 Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34498


git-svn-id: http://core.svn.wordpress.org/trunk@34462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:44:25 +00:00
Drew Jaynes 8c0a805273 Docs: Mark the optional `$upgrader` parameter as such and add a description in the DocBlock for `Language_Pack_Upgrader::async_upgrade()`. 
See [32655].

See #30989. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34497


git-svn-id: http://core.svn.wordpress.org/trunk@34461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:35:25 +00:00
Scott Taylor 9405b8b10e Canonical/Rewrite: After [34492], fix `rel="canonical"` URLs for paginated posts. 
Props wonderboymusic, joostdevalk.
See #11694.

Built from https://develop.svn.wordpress.org/trunk@34496


git-svn-id: http://core.svn.wordpress.org/trunk@34460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:30:24 +00:00
Drew Jaynes 0fc9bed46e Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for `WP_Filesystem_ftpsockets::get_contents()`. 
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34495


git-svn-id: http://core.svn.wordpress.org/trunk@34459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:22:24 +00:00
Scott Taylor b45178379b After [34492], no need to import the global instance when we are, in fact, currently, that instance. 
See #11694.

Built from https://develop.svn.wordpress.org/trunk@34494


git-svn-id: http://core.svn.wordpress.org/trunk@34458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:20:24 +00:00
Drew Jaynes fbb6ef1922 Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for `WP_Filesystem_FTPext::get_contents()`. 
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34493


git-svn-id: http://core.svn.wordpress.org/trunk@34457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:11:26 +00:00
Scott Taylor 175d476b0e Canonical/Rewrite: sanity check posts that are paged with `<!--nextpage-->`. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content. 
Awesome rewrite bug: the `page` query var was being set to `'/4'` in `$wp`. When cast to `int`, it returns `0` (Bless you, PHP). `WP_Query` calls `trim( $page, '/' )` when setting its own query var. The few places that were checking `page`	before posts were queried now have sanity checks, so that these changes work without flushing rewrites.	

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.

Built from https://develop.svn.wordpress.org/trunk@34492


git-svn-id: http://core.svn.wordpress.org/trunk@34456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 14:04:24 +00:00
Drew Jaynes f1532ccde8 Docs: Add a summary, version, and `@access` tag to the property DocBlock for `Custom_Image_Header->updated`. 
See [14907] for where the property was initially introduced.
See [30187] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34491


git-svn-id: http://core.svn.wordpress.org/trunk@34455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 13:39:25 +00:00
Drew Jaynes caf3df03bc Docs: Add a summary, version, and `@access` tag to the property DocBlock for `Custom_Background->updated`. 
See [13765] for where the property was initially introduced.
See [30186] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34490


git-svn-id: http://core.svn.wordpress.org/trunk@34454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 13:34:24 +00:00
Drew Jaynes de5e9d01a9 Docs: Add a summary, version, and `@access` tag to the property DocBlock for `WP_Locale->number_format`. 
See [5308] for where the property was initially introduced.
See [31083] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34489


git-svn-id: http://core.svn.wordpress.org/trunk@34453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 13:26:24 +00:00
Dominik Schilling 97146ee2cb Customizer: Update tests for [34487]. 
Fixes #33634.
Built from https://develop.svn.wordpress.org/trunk@34488


git-svn-id: http://core.svn.wordpress.org/trunk@34452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 11:32:26 +00:00
Dominik Schilling 833e92b7da Customizer: Use the plural label for available menu item types. 
Fixes #33634.
Built from https://develop.svn.wordpress.org/trunk@34487


git-svn-id: http://core.svn.wordpress.org/trunk@34451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 09:16:25 +00:00
Dominik Schilling 340b7a5289 Edit Post: Add missing periods. 
See #31858.
Built from https://develop.svn.wordpress.org/trunk@34486


git-svn-id: http://core.svn.wordpress.org/trunk@34450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 08:54:26 +00:00
Drew Jaynes e5e03e787c Docs: Link up a hook reference with an inline `@see` tag in the return description for `get_locale()`. 
Missed in [34484].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34485


git-svn-id: http://core.svn.wordpress.org/trunk@34449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 05:51:23 +00:00
Drew Jaynes 81e135955a Docs: Fix the summary for `get_locale()`. 
Also update the description to properly link up hook references with inline `@see` tags.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34484


git-svn-id: http://core.svn.wordpress.org/trunk@34448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 05:50:24 +00:00
Drew Jaynes 1c761505b6 Docs: Clarify the file header summary for wp-includes/l10n.php and add the version it was introduced. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34483


git-svn-id: http://core.svn.wordpress.org/trunk@34447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 05:47:24 +00:00
Drew Jaynes f64c19aa95 Docs: Split the DocBlock summary for `__()` into a summary and description. 
Also, notate the default value for the optional `$domain` parameter.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34482


git-svn-id: http://core.svn.wordpress.org/trunk@34446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 05:43:26 +00:00
Drew Jaynes 90f61eff52 Docs: Add a summary to the hook doc for the `nav_menu_item_args` filter, introduced in [34471]. 
Fixes #29417.

Built from https://develop.svn.wordpress.org/trunk@34481


git-svn-id: http://core.svn.wordpress.org/trunk@34445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 05:09:24 +00:00
Scott Taylor 4e9c1692b0 Post Thumbnails: In `get_the_post_thumbnail_url()`, return `false` instead of empty string when no URL is available. 
Fixes #33070.

Built from https://develop.svn.wordpress.org/trunk@34480


git-svn-id: http://core.svn.wordpress.org/trunk@34444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 04:38:25 +00:00
Scott Taylor 03d630d705 Unit Tests: after [34477], make `Tests_Link_GetPostCommentsFeedLink` more respectable. 
See #33693.

Built from https://develop.svn.wordpress.org/trunk@34479


git-svn-id: http://core.svn.wordpress.org/trunk@34443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 04:32:25 +00:00
Gary Pendergast 1b91141437 WPDB: When attempting to fall back to `ext/mysql` in `db_connect()`, return the result of the fall back. 
While it doesn't affect Core, we should also be passing the `$allow_bail` parameter, for anything that uses it differently.

Props markoheijnen, johnbillion.

Fixes #33105.


Built from https://develop.svn.wordpress.org/trunk@34478


git-svn-id: http://core.svn.wordpress.org/trunk@34442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 04:30:25 +00:00
Scott Taylor 43b7192e8e Feeds/Links: after [34336], use a different meat cleaver to fix Rewrite spillage across test cases. 
Fixes #33693.

Built from https://develop.svn.wordpress.org/trunk@34477


git-svn-id: http://core.svn.wordpress.org/trunk@34441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 04:20:25 +00:00
Scott Taylor 7a154ca666 WP: after [34443], calling `get_queried_object()` messes up unit tests. We can just clone the `$post` prop and call it a day. 
Fixes #20226.

Built from https://develop.svn.wordpress.org/trunk@34476


git-svn-id: http://core.svn.wordpress.org/trunk@34440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:54:24 +00:00
Scott Taylor b6e70baa04 Plugins: on the plugins admin screen, the "has been deleted" string needs a plural. 
Props jmayhak.
Fixes #33239.

Built from https://develop.svn.wordpress.org/trunk@34475


git-svn-id: http://core.svn.wordpress.org/trunk@34439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:42:25 +00:00
Scott Taylor ffb8ae1a63 Date/Time: Add unit tests for `the_date()`. 
Props jubstuff.
Fixes #33750.

Built from https://develop.svn.wordpress.org/trunk@34474


git-svn-id: http://core.svn.wordpress.org/trunk@34438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:34:24 +00:00
Scott Taylor d6155dd405 Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage. 
Props ramiy.
Fixes #31858.

Built from https://develop.svn.wordpress.org/trunk@34473


git-svn-id: http://core.svn.wordpress.org/trunk@34437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:28:24 +00:00
Scott Taylor 8cc5a142e4 Media Modal: move the translation strings for `insertIntoPost` and `uploadedToThisPost` to the `get_post_type_labels()` array as `insert_into_item` and `uploaded_to_this_item`. 
Props flixos90.
Fixes #33616.

Built from https://develop.svn.wordpress.org/trunk@34472


git-svn-id: http://core.svn.wordpress.org/trunk@34436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:22:24 +00:00
Scott Taylor 0c1f92e301 Nav Menus: Add a 'nav_menu_item_args' filter to `Walker_Nav_Menu::start_el()`. 
Props bjornjohansen.
Fixes #29417.

Built from https://develop.svn.wordpress.org/trunk@34471


git-svn-id: http://core.svn.wordpress.org/trunk@34435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:17:24 +00:00
Scott Taylor d165b25920 Include fourth array parameter in return value doc block for `wp_get_attachment_image_src()`. 
Props kadamwhite.
Fixes #33905.

Built from https://develop.svn.wordpress.org/trunk@34470


git-svn-id: http://core.svn.wordpress.org/trunk@34434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:14:24 +00:00
Scott Taylor 2071978a3f After [34341], add translation strings. 
Props ramiy.
Fixes #31862.

Built from https://develop.svn.wordpress.org/trunk@34469


git-svn-id: http://core.svn.wordpress.org/trunk@34433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:09:24 +00:00
Gary Pendergast 0f27ceae56 Tests: Remove a `var_dump()` added in [34373]. 
See #33070.


Built from https://develop.svn.wordpress.org/trunk@34468


git-svn-id: http://core.svn.wordpress.org/trunk@34432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 03:08:26 +00:00
Scott Taylor 25f206e01f List Tables: add JS code to dynamically toggle the `disabled` attribute of the Bulk Actions dropdown and Apply button. 
Props wonderboymusic, pareshradadiya.
Fixes #31634.

Built from https://develop.svn.wordpress.org/trunk@34467


git-svn-id: http://core.svn.wordpress.org/trunk@34431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 01:07:24 +00:00
Scott Taylor df9c242a5e Users: in `WP_User::__unset()`, don't reset the deprecated prop `id` to `ID`. Still throw the deprecated notice. 
Update unit test.

Fixes #20043.

Built from https://develop.svn.wordpress.org/trunk@34466


git-svn-id: http://core.svn.wordpress.org/trunk@34430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 00:49:25 +00:00
Scott Taylor 627e7a56d3 Widgets: when passing a string arg value to `dynamic_sidebar()`, don't reset `$index` when the arg's sanitized value matches the sanitized name of a sidebar. 
Adds unit test.

Props tyxla, fjarrett.
Fixes #23423.

Built from https://develop.svn.wordpress.org/trunk@34465


git-svn-id: http://core.svn.wordpress.org/trunk@34429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 00:30:24 +00:00
Scott Taylor ad2ddad259 Recent Posts Widget: remove HTML fragment caching. The cache currently doesn't work cross-scheme and causes mixed content issues for links. The widget was written pre-`$split_the_query`, after which post objects can be served from the cache. 
Fixes #27565.

Built from https://develop.svn.wordpress.org/trunk@34464


git-svn-id: http://core.svn.wordpress.org/trunk@34428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 00:17:24 +00:00
Scott Taylor a2914473cc Calendar Widget: remove the `title` attribute for days and replace with `aria-label`. Spruce up some of this nasty code. Delete unnecessary bits. 
Props wonderboymusic, elusiveunit, 5um17. 
Fixes #30297.

Built from https://develop.svn.wordpress.org/trunk@34463


git-svn-id: http://core.svn.wordpress.org/trunk@34427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 23:57:27 +00:00
John Blackbourn bdcf5717de Send a 500 HTTP response code when the server's PHP or MySQL checks fail. 
Fixes #33689
Props jeichorn

Built from https://develop.svn.wordpress.org/trunk@34462


git-svn-id: http://core.svn.wordpress.org/trunk@34426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 21:57:26 +00:00
Scott Taylor 652a3030e1 Comments: allow meta boxes for Discussion and Comments in extenuating circumstances. 
* Discussion: Post Type stops supporting comments, but comments and/or pings are open on a post. 
* Comments: Post is published or private, the post type has stopped supporting comments, but comments and/or pings are open on a post.

Currently, there is no way to toggle those settings off.

Props couturefreak, wonderboymusic, rachelbaker.
Fixes #28080.

Built from https://develop.svn.wordpress.org/trunk@34461


git-svn-id: http://core.svn.wordpress.org/trunk@34425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 19:49:26 +00:00
Boone Gorges 3c028a80d4 Allow `comment_exists()` to match based on GMT date. 
The `comment_date_gmt` field of the `wp_comments` table is indexed, which makes
`WHERE` matches against the field much faster than against the unindexed
`comment_date`. For bulk operations like data import, the speed difference can
be meaningful.

We continue to default to 'blog' for `$timezone`, to preserve compatibility
with existing uses.

Props apokalyptik.
Fixes #33871.
Built from https://develop.svn.wordpress.org/trunk@34460


git-svn-id: http://core.svn.wordpress.org/trunk@34424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 18:16:26 +00:00
John Blackbourn 13109ed129 Add an entry for Cloudup to the list of oEmbed providers. 
See #26278

Built from https://develop.svn.wordpress.org/trunk@34459


git-svn-id: http://core.svn.wordpress.org/trunk@34423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 16:00:25 +00:00
John Blackbourn af1517279e Avoid a PHP notice if the `last_updated` property isn't present in a plugin's data from the Plugins API. 
Fixes #33024
Props icetee

Built from https://develop.svn.wordpress.org/trunk@34458


git-svn-id: http://core.svn.wordpress.org/trunk@34422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 15:10:25 +00:00
Boone Gorges 6fd566d97b Fix `comment_exists()` unit test introduced in [34456]. 
See #33871.
Built from https://develop.svn.wordpress.org/trunk@34457


git-svn-id: http://core.svn.wordpress.org/trunk@34421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 14:47:26 +00:00
Boone Gorges e82de129f4 Add unit test for `comment_exists()`. 
See #33871.
Built from https://develop.svn.wordpress.org/trunk@34456


git-svn-id: http://core.svn.wordpress.org/trunk@34420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 14:35:26 +00:00
Boone Gorges 9d7a685a20 Multisite: Don't limit site titles to 50 chars. 
This restriction dates from ye olden times, ie https://mu.trac.wordpress.org/changeset/1140.
It is no longer relevant.

Props chriscct7, theode.
Fixes #33973.
Built from https://develop.svn.wordpress.org/trunk@34455


git-svn-id: http://core.svn.wordpress.org/trunk@34419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 14:24:24 +00:00
Boone Gorges a034a3394a Bail early when invalid ID is passed to `get_comment_class()`. 
This helps to avoid PHP notices later in the function.

Props walterebert, dipesh.kakadiya, DrewAPicture.
Fixes #33947.
Built from https://develop.svn.wordpress.org/trunk@34454


git-svn-id: http://core.svn.wordpress.org/trunk@34418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 14:09:26 +00:00
Boone Gorges 79c3a17060 Add a few simple tests for `get_comment_class()`. 
Props walterebert, dipesh.kakadiya.
See #33947.
Built from https://develop.svn.wordpress.org/trunk@34453


git-svn-id: http://core.svn.wordpress.org/trunk@34417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 14:05:27 +00:00
Scott Taylor 6dc400395c Links: the `esc_html()` additions in [34444] aren't very nice to screen reader `<span>`s. Revert those specific calls. 
See #14900.

Built from https://develop.svn.wordpress.org/trunk@34452


git-svn-id: http://core.svn.wordpress.org/trunk@34416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-23 04:26:27 +00:00
Sergey Biryukov 18d95526f6 Make the `'register_post_type_args'` filter introduced in [34242] available for built-in post types too. 
Props MikeSchinkel.
Fixes #17447.
Built from https://develop.svn.wordpress.org/trunk@34451


git-svn-id: http://core.svn.wordpress.org/trunk@34415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 22:32:24 +00:00
John Blackbourn 2d694c931a Add tests for some missing capabilities, including `do_not_allow`. 
See #32394.

Built from https://develop.svn.wordpress.org/trunk@34450


git-svn-id: http://core.svn.wordpress.org/trunk@34414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 22:18:25 +00:00
John Blackbourn 36adca9092 Correct a capability name in the roles and capabilities mapping. The `delete_others_pages` key was missing, and the `delete_others_posts` key was duplicated. 
Introduced in [32812].

See #32394.

Built from https://develop.svn.wordpress.org/trunk@34449


git-svn-id: http://core.svn.wordpress.org/trunk@34413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 22:16:26 +00:00
Aaron Jorbin 8494e6294a Add test image for test_exif_keywords test 
[34374] added a test that relies on a new test image. This test image wasn't included in the commit.  This fixes the broken Tests_Image_Meta::test_exif_keywords test.

Props swissspidy, SteveHoneyNZ.
Fixes #33772.


Built from https://develop.svn.wordpress.org/trunk@34448


git-svn-id: http://core.svn.wordpress.org/trunk@34412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 21:43:25 +00:00
John Blackbourn ca1c40abbc Implement a test for capabilities for a custom post type that uses `capability_type => page`. 
See #17253

Built from https://develop.svn.wordpress.org/trunk@34447


git-svn-id: http://core.svn.wordpress.org/trunk@34411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 21:01:24 +00:00
Scott Taylor 939d9b7395 Remove some unused globals and/or their docs. 
See ##33491.

Built from https://develop.svn.wordpress.org/trunk@34446


git-svn-id: http://core.svn.wordpress.org/trunk@34410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 20:27:25 +00:00
Scott Taylor d866a40d09 After [34444​], `wp_get_shortlink()` can call `get_queried_object_id()` instead of using the `$wp_query` global. 
See #14900.

Built from https://develop.svn.wordpress.org/trunk@34445


git-svn-id: http://core.svn.wordpress.org/trunk@34409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 20:09:23 +00:00
Scott Taylor 7cbd096c2b Links: use consistent late-escaping in some HTML link-generation functions: 
* `post_comments_feed_link()`
* `edit_post_link()`
* `edit_comment_link()`
* `edit_bookmark_link()`
* `rel_canonical()`

Props niallkennedy, wonderboymusic.
Fixes #14900.

Built from https://develop.svn.wordpress.org/trunk@34444


git-svn-id: http://core.svn.wordpress.org/trunk@34408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 20:06:24 +00:00
Scott Taylor 4cdd0b1688 PINGBACKS: After [34442], switch to `is_singular()` to check attachments and pages as well. 
See #20226.

Built from https://develop.svn.wordpress.org/trunk@34443


git-svn-id: http://core.svn.wordpress.org/trunk@34407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 19:10:29 +00:00
Scott Taylor 3bbd53c717 PINGBACKS: rather than sending the `X-Pingback` HTTP header on every single request for fun, perhaps only send it on single posts with pings open. 
See #20226.

Built from https://develop.svn.wordpress.org/trunk@34442


git-svn-id: http://core.svn.wordpress.org/trunk@34406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 18:47:25 +00:00
Drew Jaynes 32358bbcdd Docs: Actually, the subpackage for `Walker_Page` should be Template. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34441


git-svn-id: http://core.svn.wordpress.org/trunk@34405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 15:09:24 +00:00
Drew Jaynes 07cb271a45 Docs: Add a file header to wp-includes/widgets/class-wp-widget-text.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Text`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34440


git-svn-id: http://core.svn.wordpress.org/trunk@34404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 15:04:26 +00:00
Drew Jaynes 12196adb29 Docs: Add a file header to wp-includes/widgets/class-wp-widget-tag-cloud.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Tag_Cloud`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34439


git-svn-id: http://core.svn.wordpress.org/trunk@34403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 15:02:26 +00:00
Drew Jaynes 32118a94e5 Docs: Add a file header to wp-includes/widgets/class-wp-widget-search.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Search`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34438


git-svn-id: http://core.svn.wordpress.org/trunk@34402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 15:01:25 +00:00
Drew Jaynes 5cd5252964 Docs: Add a file header to wp-includes/widgets/class-wp-widget-rss.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_RSS`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34437


git-svn-id: http://core.svn.wordpress.org/trunk@34401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:57:26 +00:00
Drew Jaynes 0608fc8dea Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-posts.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Posts`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34436


git-svn-id: http://core.svn.wordpress.org/trunk@34400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:54:25 +00:00
Drew Jaynes c9ae3bf3e3 Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-comments.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Comments`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34435


git-svn-id: http://core.svn.wordpress.org/trunk@34399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:51:25 +00:00
Drew Jaynes 111144e3fe Docs: Add a file header to wp-includes/widgets/class-wp-widget-pages.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Pages`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34434


git-svn-id: http://core.svn.wordpress.org/trunk@34398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:49:24 +00:00
Drew Jaynes 42c2543175 Docs: Add a file header to wp-includes/widgets/class-wp-widget-meta.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Meta`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34433


git-svn-id: http://core.svn.wordpress.org/trunk@34397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:48:24 +00:00
Drew Jaynes 305ac5d661 Docs: Add a file header to wp-includes/widgets/class-wp-widget-links.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Links`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34432


git-svn-id: http://core.svn.wordpress.org/trunk@34396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:47:25 +00:00
Drew Jaynes d259fba59f Docs: Clarify the class DocBlock summary for `WP_Widget_Categories`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34431


git-svn-id: http://core.svn.wordpress.org/trunk@34395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:45:25 +00:00
Drew Jaynes 06ab88c2e0 Docs: Add a file header to wp-includes/widgets/class-wp-widget-calendar.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Calendar`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34430


git-svn-id: http://core.svn.wordpress.org/trunk@34394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:44:24 +00:00
Drew Jaynes 02084878f0 Docs: Add a missing file header to wp-includes/widgets/class-wp-widget-archives.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Archives`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34429


git-svn-id: http://core.svn.wordpress.org/trunk@34393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:43:24 +00:00
Drew Jaynes c829d1a9b0 Docs: Clarify the file header summary for wp-includes/widgets/class-wp-nav-menu-widget.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Nav_Menu_Widget`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34428


git-svn-id: http://core.svn.wordpress.org/trunk@34392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:41:25 +00:00
Drew Jaynes fc3ec39515 Docs: Clarify the file header summary for wp-admin/includes/template-functions.php, introduced in [34241]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34427


git-svn-id: http://core.svn.wordpress.org/trunk@34391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:37:25 +00:00
Drew Jaynes b168337aab Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241]. 
Also adds a missing class DocBlock to `WP_Internal_Pointers`. See [19388].

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34426


git-svn-id: http://core.svn.wordpress.org/trunk@34390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:35:25 +00:00
Drew Jaynes 2a37e00b92 Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241]. 
Also clarifies the class DocBlock summary for `Walker_Category_Checklist`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34425


git-svn-id: http://core.svn.wordpress.org/trunk@34389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:33:48 +00:00
Sergey Biryukov 8db1c75a7e Remove extra HTML from translatable strings in `WP_Comments_List_Table::get_views()`. 
Add a context and translator comments.

Props Tmeister for initial patch.
Fixes #31859.
Built from https://develop.svn.wordpress.org/trunk@34424


git-svn-id: http://core.svn.wordpress.org/trunk@34388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:33:25 +00:00
Drew Jaynes c7022a334d Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223]. 
Also clarifies the class DocBlock summary and tags for `WP_Post_Comments_List_Table`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34423


git-svn-id: http://core.svn.wordpress.org/trunk@34387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:31:24 +00:00
Drew Jaynes d7624168cd Docs: Clarify the class DocBlock summary for `WP_Screen`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34422


git-svn-id: http://core.svn.wordpress.org/trunk@34386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:28:24 +00:00
Drew Jaynes ee97475edb Docs: Add a file header to wp-admin/includes/nav-menus.php. 
See [34168]. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34421


git-svn-id: http://core.svn.wordpress.org/trunk@34385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:27:24 +00:00
Drew Jaynes 6e350ff16e Docs: Clarify the file header summary and version for wp-includes/category-template.php. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34420


git-svn-id: http://core.svn.wordpress.org/trunk@34384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:23:24 +00:00
Drew Jaynes 99420b41b5 Docs: Clarify the file header summary and subpackage for wp-includes/category-functions.php, introduced in [34110]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34419


git-svn-id: http://core.svn.wordpress.org/trunk@34383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:21:23 +00:00
Drew Jaynes d5c824beb7 Docs: Clarify the file header for wp-includes/category.php. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34418


git-svn-id: http://core.svn.wordpress.org/trunk@34382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:20:24 +00:00
Drew Jaynes 653702c408 Docs: Clarify the file header for wp-includes/class-walker-category-dropdown.php, introduced in [34110]. 
Also clarifies the class DocBlock and tags for `Walker_CategoryDropdown`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34417


git-svn-id: http://core.svn.wordpress.org/trunk@34381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:03:25 +00:00
Drew Jaynes f6b1952e9a Docs: Clarify the file header summary for wp-includes/class-walker-category.php, introduced in [34110]. 
Also clarifies the class DocBlock and tags for `Walker_Category`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34416


git-svn-id: http://core.svn.wordpress.org/trunk@34380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:01:25 +00:00
Drew Jaynes 2828e6cc06 Docs: Clarify the file header subpackage for wp-includes/class-walker-page-dropdown.php, introduced in [34109]. 
Also clarifies the class DocBlock summary and tags for `Walker_PageDropdown`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34415


git-svn-id: http://core.svn.wordpress.org/trunk@34379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:58:24 +00:00
Drew Jaynes 160ae95982 Docs: Clarify the file header summary for wp-includes/class-walker-page.php, introduced in [34109]. 
Also clarifies the class DocBlock summary for `Walker_Page`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34414


git-svn-id: http://core.svn.wordpress.org/trunk@34378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:54:24 +00:00
Drew Jaynes 58376954c2 Docs: The Widgets subpackage is plural. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34413


git-svn-id: http://core.svn.wordpress.org/trunk@34377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:48:25 +00:00
Drew Jaynes 4ddb22bd09 Docs: The Users subpackage is plural. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34412


git-svn-id: http://core.svn.wordpress.org/trunk@34376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:46:25 +00:00
Drew Jaynes 35977a06e7 Docs: The Comments subpackage is plural. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34411


git-svn-id: http://core.svn.wordpress.org/trunk@34375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:45:26 +00:00
Drew Jaynes 5f6cdc2c3b Docs: The Comment API is singular. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34410


git-svn-id: http://core.svn.wordpress.org/trunk@34374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:44:25 +00:00
Drew Jaynes 8df8fb6046 Docs: The Comment API is singular. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34409


git-svn-id: http://core.svn.wordpress.org/trunk@34373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:43:25 +00:00
Drew Jaynes f980e7b9bb Docs: Clarify the file header summary for wp-includes/default-widgets.php, the top-level file for bringing in the core widget classes. 
Also adds inline DocBlocks for the widget classes now brought in via `require_once()` as of [33843].

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34408


git-svn-id: http://core.svn.wordpress.org/trunk@34372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:36:25 +00:00
Drew Jaynes df81151f24 Docs: Clarify the file header summary for wp-includes/meta.php, the top-level file for the core Meta API. 
Also adds inline DocBlocks for files broken out in #33413 and now brought in via `require_once()`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34407


git-svn-id: http://core.svn.wordpress.org/trunk@34371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:30:24 +00:00
Drew Jaynes c0f2844618 Docs: Clarify the file header summary for wp-includes/meta-functions.php, introduced in [33761]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34406


git-svn-id: http://core.svn.wordpress.org/trunk@34370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:27:24 +00:00
Drew Jaynes 0d1dcaa832 Docs: Add a file header to wp-includes/class-wp-meta-query.php, introduced in [33761]. 
Also clarifies the class DocBlock summary for `WP_Meta_Query`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34405


git-svn-id: http://core.svn.wordpress.org/trunk@34369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:26:23 +00:00
Drew Jaynes 24180ac754 Docs: Clarify the file header summary for wp-includes/taxonomy.php, the top-level file for the core Taxonomy API. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34404


git-svn-id: http://core.svn.wordpress.org/trunk@34368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:23:25 +00:00
Drew Jaynes 4bcbeb129e Docs: Clarify the file header summary for wp-includes/taxonomy-functions.php, introduced in [33760]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34403


git-svn-id: http://core.svn.wordpress.org/trunk@34367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:20:27 +00:00
Drew Jaynes bbe7044030 Docs: Add a file header to wp-includes/class-wp-tax-query.php, introduced in [33760]. 
Also clarifies the class DocBlock summary and description for `WP_Tax_Query`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34402


git-svn-id: http://core.svn.wordpress.org/trunk@34366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:16:30 +00:00
Drew Jaynes 6069a4b2f6 Docs: Clarify the file header summary for wp-includes/post.php, the top-level file for the Post API. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34401


git-svn-id: http://core.svn.wordpress.org/trunk@34365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:13:26 +00:00
Drew Jaynes fc7fa6d2d9 Docs: Clarify the file header summary for wp-includes/post-functions.php, introduced in [33759]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34400


git-svn-id: http://core.svn.wordpress.org/trunk@34364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:12:24 +00:00
Drew Jaynes ac975e2b07 Docs: Add a file header to wp-includes/class-wp-post.php, introduced in [33759]. 
Also clarifies the class DocBlock for `WP_Post`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34399


git-svn-id: http://core.svn.wordpress.org/trunk@34363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:10:24 +00:00
Drew Jaynes b0749a1a06 Docs: Clarify the file header summary for wp-includes/capabilities.php, which was broken up into multiple files in [33752]. 
Also adds inline DocBlocks for files now brought in via `require_once()` from this file.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34398


git-svn-id: http://core.svn.wordpress.org/trunk@34362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:06:25 +00:00
Drew Jaynes 51b778fb03 Docs: The User API is singular. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34397


git-svn-id: http://core.svn.wordpress.org/trunk@34361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:03:24 +00:00
Drew Jaynes 3f48878c61 Docs: Clarify the file header summary for wp-includes/capabilities-functions.php, introduced in [33752]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34396


git-svn-id: http://core.svn.wordpress.org/trunk@34360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 13:01:25 +00:00
Drew Jaynes 521d39b629 Docs: Add a file header to wp-includes/class-wp-role.php, introduced in [33752]. 
Also adjusts the class DocBlock for `WP_Role`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34395


git-svn-id: http://core.svn.wordpress.org/trunk@34359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 12:59:24 +00:00
Drew Jaynes 4d9fa2d7d2 Docs: Add a file header to wp-includes/class-wp-roles.php, introduced in [33752]. 
Also adjusts the class DocBlock for `WP_Roles`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34394


git-svn-id: http://core.svn.wordpress.org/trunk@34358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 12:54:26 +00:00
Drew Jaynes 35246a957f Docs: The User API is singular. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34393


git-svn-id: http://core.svn.wordpress.org/trunk@34357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 12:31:26 +00:00
Drew Jaynes 783876bd1a Docs: The Widget API is singular. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34392


git-svn-id: http://core.svn.wordpress.org/trunk@34356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 12:28:27 +00:00
Drew Jaynes e845a6ed97 Docs: Update the file path in the duplicate hook comment for the `admin_xml_ns` hook in wp-admin/includes/template-functions.php. 
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].

Props dimadin.
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34391


git-svn-id: http://core.svn.wordpress.org/trunk@34355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 10:32:26 +00:00
Drew Jaynes 4e1ca6b1aa Docs: Add a missing access modifier to the declaration for the `WP_User::__unset()` magic method, introduced in [34380]. 
Also adds missing documentation to the DocBlock.

Fixes #20043.

Built from https://develop.svn.wordpress.org/trunk@34390


git-svn-id: http://core.svn.wordpress.org/trunk@34354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 10:07:23 +00:00
Drew Jaynes 48213a5842 Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the `WP_User::__get()` magic method. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34389


git-svn-id: http://core.svn.wordpress.org/trunk@34353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 10:02:24 +00:00
Drew Jaynes fd82198aad Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the `WP_User::__isset()` magic method. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34388


git-svn-id: http://core.svn.wordpress.org/trunk@34352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 09:59:24 +00:00
Drew Jaynes 16d8ed44a5 Docs: Add a file header to wp-includes/class-wp-user.php, created in [33752]. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34387


git-svn-id: http://core.svn.wordpress.org/trunk@34351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 09:56:25 +00:00
Drew Jaynes a88e3e9a1d Docs: Add a changelog entry to `WP_Widget_Categories` for non-category support, added in [34376]. 
See #21165. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34386


git-svn-id: http://core.svn.wordpress.org/trunk@34350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 09:50:25 +00:00
Drew Jaynes 89a1bb93e4 Docs: Add a file header to wp-includes/widgets/class-wp-widget-categories.php. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34385


git-svn-id: http://core.svn.wordpress.org/trunk@34349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 09:48:25 +00:00
Drew Jaynes c5fede78e0 Docs: Include 'wp-json' in the 4.4.0 changelog entry for the `subdirectory_reserved_names` filter. 
'wp-json' was appended to the reserved names list in [34375].

See #33789. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34384


git-svn-id: http://core.svn.wordpress.org/trunk@34348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 09:44:27 +00:00
Scott Taylor f9c2a88a8a List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 
Props wonderboymusic, Viper007Bond.
Fixes #21249.

Built from https://develop.svn.wordpress.org/trunk@34383


git-svn-id: http://core.svn.wordpress.org/trunk@34347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 06:06:25 +00:00
Scott Taylor 3c1e05f7c9 Dashboard: 2 submit buttons don't need names. 
Props garyc40, gizburdt.
Fixes #16345.

Built from https://develop.svn.wordpress.org/trunk@34382


git-svn-id: http://core.svn.wordpress.org/trunk@34346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 05:45:26 +00:00
Scott Taylor 51115a6816 Widgets: add a `static` property to `WP_Widget_Calendar` to ensure that the `id` attribute is only output once. 
Props MikeHansenMe, wonderboymusic.
Fixes #24604.

Built from https://develop.svn.wordpress.org/trunk@34381


git-svn-id: http://core.svn.wordpress.org/trunk@34345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 05:09:24 +00:00
Scott Taylor eb1e8f41a0 Users: add `__unset` to `WP_User`. 
Adds unit tests.

Props johnjamesjacoby, MikeHansenMe, wonderboymusic.
Fixes #20043.

Built from https://develop.svn.wordpress.org/trunk@34380


git-svn-id: http://core.svn.wordpress.org/trunk@34344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 05:00:24 +00:00
Scott Taylor d093242095 Users: clarify the docs for `WP_User::__set` to make it clear that it does save data in the database. 
Props johnpbloch.
Fixes #24255.

Built from https://develop.svn.wordpress.org/trunk@34379


git-svn-id: http://core.svn.wordpress.org/trunk@34343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:56:24 +00:00
Scott Taylor aa8c76258a After [34374], ensure that `$iptc` is defined. 
See #33772.

Built from https://develop.svn.wordpress.org/trunk@34378


git-svn-id: http://core.svn.wordpress.org/trunk@34342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:49:24 +00:00
Scott Taylor 3c66bd6cb6 Sanitization: when falling back to (wait for it...) `$fallback` in `sanitize_html_class()`, sanitize it as well. 
Props MikeHansenMe, wonderboymusic.
Fixes #30967.

Built from https://develop.svn.wordpress.org/trunk@34377


git-svn-id: http://core.svn.wordpress.org/trunk@34341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:31:25 +00:00
Scott Taylor 40c15af795 Widgets: Make the categories widget work with custom taxonomies. 
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.

Built from https://develop.svn.wordpress.org/trunk@34376


git-svn-id: http://core.svn.wordpress.org/trunk@34340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:25:24 +00:00
Scott Taylor c60b00fc20 Multisite: as a precaution, make `wp-json` a reserved subdirectory name. 
Props austinginder.
Fixes #33789.

Built from https://develop.svn.wordpress.org/trunk@34375


git-svn-id: http://core.svn.wordpress.org/trunk@34339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:21:25 +00:00
Scott Taylor 1d513fe737 Media: In `wp_read_image_metadata()`, include IPTC Keywords when available in `$meta`. 
Adds unit test.

Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772.

Built from https://develop.svn.wordpress.org/trunk@34374


git-svn-id: http://core.svn.wordpress.org/trunk@34338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:19:24 +00:00
Scott Taylor e3fcbf5d55 Media: Add new functions, `get_the_post_thumbnail_url()` and `the_post_thumbnail_url()`. 
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.

Built from https://develop.svn.wordpress.org/trunk@34373


git-svn-id: http://core.svn.wordpress.org/trunk@34337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:15:24 +00:00
Scott Taylor 2ddc1d2f3a Media: Add a new function, `wp_get_attachment_image_url()`, which is a shortcut for `wp_get_attachment_image_src()` - same function signature, but returns just the URL based on `$size`. 
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.

Built from https://develop.svn.wordpress.org/trunk@34372


git-svn-id: http://core.svn.wordpress.org/trunk@34336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 04:13:27 +00:00
Scott Taylor 39552b63ca Passwords: fix the markup on the Reset Password Form for `user-pass1` so the JavaScript operates properly. 
Props ldinclaux.
See #33892.
Fixes #33908.

Built from https://develop.svn.wordpress.org/trunk@34371


git-svn-id: http://core.svn.wordpress.org/trunk@34335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 03:57:24 +00:00
Scott Taylor 3ad78c4ec5 Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added. 
Fixes #33941.

Built from https://develop.svn.wordpress.org/trunk@34370


git-svn-id: http://core.svn.wordpress.org/trunk@34334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 03:37:25 +00:00
Scott Taylor 62a91851de HTTP: Add some new Cookie helper functions: 
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.

Built from https://develop.svn.wordpress.org/trunk@34369


git-svn-id: http://core.svn.wordpress.org/trunk@34333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 03:14:25 +00:00
Drew Jaynes 8241813825 Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765]. 
See #31443. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34368


git-svn-id: http://core.svn.wordpress.org/trunk@34332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 23:13:26 +00:00
Konstantin Obenland c5a684fc27 Introduce template functions for comment navigation: 
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.


Built from https://develop.svn.wordpress.org/trunk@34367


git-svn-id: http://core.svn.wordpress.org/trunk@34331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 16:32:26 +00:00
Scott Taylor e19e604a74 Docs: `is_main_query()`'s `_doing_it_wrong()` notice suggests using `WP_Query` statically (`WP_Query::is_main_query()`). Use an alternate syntax: `WP_Query->is_main_query()`, to not confuse. 
Props DrewAPicture, micahwave.
Fixes #25680.

Built from https://develop.svn.wordpress.org/trunk@34366


git-svn-id: http://core.svn.wordpress.org/trunk@34330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 15:31:26 +00:00
Helen Hou-Sandí dd08157024 Notices: Add styles for use against white backgrounds. 
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.

Built from https://develop.svn.wordpress.org/trunk@34365


git-svn-id: http://core.svn.wordpress.org/trunk@34329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 15:26:25 +00:00
Scott Taylor f4121923da Meta Boxes: In `post_categories_meta_box()`, convert some spaces to tabs. 
Props miyauchi.
Fixes #33945.

Built from https://develop.svn.wordpress.org/trunk@34364


git-svn-id: http://core.svn.wordpress.org/trunk@34328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 15:18:26 +00:00
Drew Jaynes b336035dac Docs: The `$post` parameter has been passed to the `preview_post_link` since 4.0.0. 
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.

Built from https://develop.svn.wordpress.org/trunk@34363


git-svn-id: http://core.svn.wordpress.org/trunk@34327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 13:17:26 +00:00
Drew Jaynes bbae198372 Docs: Add a more complete return description for the array of data (or false) returned by `image_downsize()`. 
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.

Built from https://develop.svn.wordpress.org/trunk@34362


git-svn-id: http://core.svn.wordpress.org/trunk@34326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 10:22:26 +00:00
Drew Jaynes e6764f3b19 Docs: Update the docs for `WP_User_Query->prepare_query()` for ordering by the value of the `include` argument, allowed since 4.1. 
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.

Built from https://develop.svn.wordpress.org/trunk@34361


git-svn-id: http://core.svn.wordpress.org/trunk@34325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 00:47:25 +00:00
John Blackbourn f38013229b Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors). 
Props linuxologos, wonderboymusic
Fixes #19609

Built from https://develop.svn.wordpress.org/trunk@34360


git-svn-id: http://core.svn.wordpress.org/trunk@34324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 17:28:24 +00:00
John Blackbourn 970752a351 Remove the ability to view the term editing screen for taxonomies with `show_ui` set to `false`. It is unexpected and unintended behaviour that this is allowed. 
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938

Built from https://develop.svn.wordpress.org/trunk@34359


git-svn-id: http://core.svn.wordpress.org/trunk@34323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 17:11:25 +00:00
John Blackbourn 86bb996446 Implement some more uses of `wp_login_url()` in places where wp-login.php is hard-coded. 
See #31495

Built from https://develop.svn.wordpress.org/trunk@34358


git-svn-id: http://core.svn.wordpress.org/trunk@34322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 16:54:24 +00:00
John Blackbourn 015349cd6e Revisions are an exception when it comes to the editing UI. The `revision` post type cannot have its `show_ui` argument set to true because this allows access to the post type listing, creation, and editing UI, but `get_edit_post_link()` needs to return a URL for the editing UI for revisions as that's how the revisions UI works. 
Fixes #33763

Built from https://develop.svn.wordpress.org/trunk@34357


git-svn-id: http://core.svn.wordpress.org/trunk@34321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 16:38:26 +00:00
Konstantin Obenland b548119d99 Multisite: Make site status classes available to other elements. 
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.


Built from https://develop.svn.wordpress.org/trunk@34356


git-svn-id: http://core.svn.wordpress.org/trunk@34320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 12:53:27 +00:00
Drew Jaynes b051f0f6c8 Docs: Add a description for the documented use of the `$wpdb` global in `_prime_comment_caches()`. 
See #8071. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34355


git-svn-id: http://core.svn.wordpress.org/trunk@34319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 09:39:23 +00:00
Dominik Schilling d2414cbd2f Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings. 
Props ramiy.
Fixes #31870.
Built from https://develop.svn.wordpress.org/trunk@34354


git-svn-id: http://core.svn.wordpress.org/trunk@34318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 09:11:24 +00:00
John Blackbourn 707f0d9108 Add `@since` docs for the `show_ui` argument in `register_post_type()`. 
See #33763

Built from https://develop.svn.wordpress.org/trunk@34353


git-svn-id: http://core.svn.wordpress.org/trunk@34317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 09:05:24 +00:00
Dominik Schilling ca3e65e20e Upgrader: Avoid using an HTML tag in a translation string, add translator comments. 
Props ramiy for initial patch. 
Fixes #31860.
Built from https://develop.svn.wordpress.org/trunk@34352


git-svn-id: http://core.svn.wordpress.org/trunk@34316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 08:59:24 +00:00
Dominik Schilling d5be34186c Theme Compat: Remove two strings from `comments-popup.php`. 
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.
Built from https://develop.svn.wordpress.org/trunk@34351


git-svn-id: http://core.svn.wordpress.org/trunk@34315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 08:49:27 +00:00
Sergey Biryukov d63bb56030 Pass the current post object to `'page_attributes_meta_box_template'` action added in [34340]. 
Props DrewAPicture.
Fixes #33625.
Built from https://develop.svn.wordpress.org/trunk@34350


git-svn-id: http://core.svn.wordpress.org/trunk@34314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 08:15:28 +00:00
Drew Jaynes 292243944f Docs: Use standardized vernacular in the hook doc summary for the `page_attributes_meta_box_template` filter, introduced in [34340]. 
See #33625.

Built from https://develop.svn.wordpress.org/trunk@34349


git-svn-id: http://core.svn.wordpress.org/trunk@34313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 06:38:25 +00:00
Scott Taylor 84da11d918 Pass `false` as the 2nd argument to `class_exists()` to disable autoloading and to not cause problems for those who define `__autoload()`. 
Fixes #20523.

Built from https://develop.svn.wordpress.org/trunk@34348


git-svn-id: http://core.svn.wordpress.org/trunk@34312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 03:52:25 +00:00
Scott Taylor 82709c30d9 The `'get_sample_permalink_html'` filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with `'get_sample_permalink'` filter added in [34309]. 
Props SergeyBiryukov.	
Fixes #33927.

Built from https://develop.svn.wordpress.org/trunk@34347


git-svn-id: http://core.svn.wordpress.org/trunk@34311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 03:26:25 +00:00
Scott Taylor b20e8dbf69 MediaElement, update `wp-mediaelement.js`: 
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.

Built from https://develop.svn.wordpress.org/trunk@34346


git-svn-id: http://core.svn.wordpress.org/trunk@34310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 03:17:24 +00:00
Scott Taylor cb54b8d5a7 WP Query: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31868.

Built from https://develop.svn.wordpress.org/trunk@34345


git-svn-id: http://core.svn.wordpress.org/trunk@34309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 03:04:24 +00:00
Scott Taylor d34b59a5d2 Plugins Admin: Avoid using HTML tags in translation strings, add translator strings. 
Props swissspidy, voldemortensen.	
Fixes #32269.

Built from https://develop.svn.wordpress.org/trunk@34344


git-svn-id: http://core.svn.wordpress.org/trunk@34308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 03:01:24 +00:00
Scott Taylor beb61ff909 WP Mail: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31871.

Built from https://develop.svn.wordpress.org/trunk@34343


git-svn-id: http://core.svn.wordpress.org/trunk@34307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 02:53:25 +00:00
Scott Taylor 630d3db338 Theme Compat: Avoid using HTML tags in translation strings. 
Props ramiy.	
Fixes #31867.

Built from https://develop.svn.wordpress.org/trunk@34342


git-svn-id: http://core.svn.wordpress.org/trunk@34306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 02:47:24 +00:00
Scott Taylor ebb01aae4c Plugin Editor: Avoid using HTML tags in translation strings and add context. 
Props ramiy.	
Fixes #31862.

Built from https://develop.svn.wordpress.org/trunk@34341


git-svn-id: http://core.svn.wordpress.org/trunk@34305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 02:42:25 +00:00
Scott Taylor 89a03563c9 In `page_attributes_meta_box()`, add an action, `'page_attributes_meta_box_template'` to allow callbacks to be performed and HTML to be inserted after the title of the Template section. 
Props sgrant.	
Fixes #33625.

Built from https://develop.svn.wordpress.org/trunk@34340


git-svn-id: http://core.svn.wordpress.org/trunk@34304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 02:40:24 +00:00
Scott Taylor d2578f84d1 MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface: 
ccba8d0b6a

Props bradyvercher.
Fixes #33798.

Built from https://develop.svn.wordpress.org/trunk@34339


git-svn-id: http://core.svn.wordpress.org/trunk@34303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 02:31:24 +00:00
Scott Taylor 693692af68 Login: apply the same margin to the top and bottom of the Back to {Blog} link. 
Props MikeHansenMe.
Fixes #29249.

Built from https://develop.svn.wordpress.org/trunk@34338


git-svn-id: http://core.svn.wordpress.org/trunk@34302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 01:41:25 +00:00
Drew Jaynes f93dcf9226 Docs: Add descriptions for `$wp_query` global phpDoc references in wp-includes/query.php, partially documented in [32620]. 
Fixes #32139.

Built from https://develop.svn.wordpress.org/trunk@34337


git-svn-id: http://core.svn.wordpress.org/trunk@34301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 00:05:26 +00:00
Scott Taylor 8d2abbffac Feeds/Links: fix feed links for unattached attachments. 
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.

Built from https://develop.svn.wordpress.org/trunk@34336


git-svn-id: http://core.svn.wordpress.org/trunk@34300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 20:10:24 +00:00
Scott Taylor 2b3c283040 After [34334], update unit tests. 
See #33930.

Built from https://develop.svn.wordpress.org/trunk@34335


git-svn-id: http://core.svn.wordpress.org/trunk@34299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 20:07:24 +00:00
Scott Taylor 518404a166 Site Icon: for consistency, make all 4 HTML tags in `wp_site_icon()` self-closing. 
Props Corphi.
Fixes #33930.

Built from https://develop.svn.wordpress.org/trunk@34334


git-svn-id: http://core.svn.wordpress.org/trunk@34298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 19:07:27 +00:00
Scott Taylor 864b54d46f Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors. 
Props westonruter.
Fixes #33732.

Built from https://develop.svn.wordpress.org/trunk@34333


git-svn-id: http://core.svn.wordpress.org/trunk@34297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 18:53:25 +00:00
Scott Taylor 2c4323fc1c Updates: in Theme list table, set `white-space` to `normal` for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens. 
Fixes #33831.

Built from https://develop.svn.wordpress.org/trunk@34332


git-svn-id: http://core.svn.wordpress.org/trunk@34296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 18:43:24 +00:00
Scott Taylor 47fead7a38 Post List Table: 'All' view should be selected when appropriate for paged responses. 
Props kraftbj, wonderboymusic.
Fixes #33923.

Built from https://develop.svn.wordpress.org/trunk@34331


git-svn-id: http://core.svn.wordpress.org/trunk@34295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 18:17:24 +00:00
Scott Taylor e4f350706c Add a `'menu_id'` argument to `wp_page_menu()` so that fallback menus have the same attributes as `wp_nav_menu()`. 
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.

Built from https://develop.svn.wordpress.org/trunk@34330


git-svn-id: http://core.svn.wordpress.org/trunk@34294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 18:07:26 +00:00
Scott Taylor fc8c624a61 Reinstate [34327]. minus the unit test deletion. 
Built from https://develop.svn.wordpress.org/trunk@34329


git-svn-id: http://core.svn.wordpress.org/trunk@34293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 17:49:24 +00:00
Scott Taylor 863fd80150 Revert [34327] to fix the accidental deletion of some unit tests. 
Built from https://develop.svn.wordpress.org/trunk@34328


git-svn-id: http://core.svn.wordpress.org/trunk@34292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 17:46:24 +00:00
Scott Taylor 003edb6ea7 Export: Add a filer, `'export_wp_filename'` to change the filename of the file to download when exporting. 
Props MikeHansenMe, wonderboymusic.
Fixes #29500.

Built from https://develop.svn.wordpress.org/trunk@34327


git-svn-id: http://core.svn.wordpress.org/trunk@34291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 17:44:24 +00:00
Scott Taylor 0fd01b9057 Export: allow Media to exported separately from other types. 
Props PhilipLakin.
Fixes #32230.

Built from https://develop.svn.wordpress.org/trunk@34326


git-svn-id: http://core.svn.wordpress.org/trunk@34290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 16:47:25 +00:00
Scott Taylor 28964445d4 Admin: when toggling select/deselect "all" via JS - `:visible` needs to be bound to not toggle disabled inputs. 
Props tywayne.
Fixes #32309.

Built from https://develop.svn.wordpress.org/trunk@34325


git-svn-id: http://core.svn.wordpress.org/trunk@34289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 16:41:24 +00:00
Scott Taylor e47963d1e7 Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link. 
Props wpdev101.
Fixes #33541.

Built from https://develop.svn.wordpress.org/trunk@34324


git-svn-id: http://core.svn.wordpress.org/trunk@34288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 16:32:24 +00:00
Scott Taylor 60fadd7bdc List Tables: Ensure that sorting indicators have layout when cell widths are being calculated. 
See #27743.

Built from https://develop.svn.wordpress.org/trunk@34323


git-svn-id: http://core.svn.wordpress.org/trunk@34287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 16:15:24 +00:00
Scott Taylor 6dc9ffc090 Update Core: In `list_plugin_updates()`, when listing plugin updates related to `$core_update_version`, don't skip the check for `$info->tested`. 
Props MikeHansenMe.
Fixes #27883.

Built from https://develop.svn.wordpress.org/trunk@34322


git-svn-id: http://core.svn.wordpress.org/trunk@34286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 16:10:26 +00:00
Konstantin Obenland 8d8252aa89 Menus: Remove whitespace between nav menu items. 
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.


Built from https://develop.svn.wordpress.org/trunk@34321


git-svn-id: http://core.svn.wordpress.org/trunk@34285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 11:40:26 +00:00
Weston Ruter 4ff29f822e Customize: Flesh out phpdoc for `WP_Customize_Manager`. 
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.

Built from https://develop.svn.wordpress.org/trunk@34320


git-svn-id: http://core.svn.wordpress.org/trunk@34284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 06:40:26 +00:00
Scott Taylor d28e914a06 When applying the `'editable_slug'` filter, add a second param that provides more context. 
Props MikeSchinkel, jesin.
Fixes #31568.

Built from https://develop.svn.wordpress.org/trunk@34319


git-svn-id: http://core.svn.wordpress.org/trunk@34283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 05:49:24 +00:00
Scott Taylor 170a2cc4be Add a `'clean_user_cache'` action at the end of `clean_user_cache()`. This is mighty similar to `clean_post_cache()`. 
Props elliott-stocks, wonderboymusic.
Fixes #31918.

Built from https://develop.svn.wordpress.org/trunk@34318


git-svn-id: http://core.svn.wordpress.org/trunk@34282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-19 05:41:26 +00:00
Andrew Ozz 1b24c98739 TinyMCE: remove `word-break: break-word;` from the default editor CSS to prevent irregular spaces when typing in RTL languages. 
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.
Built from https://develop.svn.wordpress.org/trunk@34317


git-svn-id: http://core.svn.wordpress.org/trunk@34281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 23:58:26 +00:00
Dominik Schilling 0891de90e0 Theme Compat: Remove commented out code. 
See #31867.
Built from https://develop.svn.wordpress.org/trunk@34316


git-svn-id: http://core.svn.wordpress.org/trunk@34280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 21:38:25 +00:00
Dominik Schilling 33127a3f59 Don't use `<code>` in translation strings in `wp-admin/options.php`. 
Props ramiy, wonderboymusic.
Fixes #31861.
Built from https://develop.svn.wordpress.org/trunk@34315


git-svn-id: http://core.svn.wordpress.org/trunk@34279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 20:43:25 +00:00
Dominik Schilling d1bdd59183 Don't use `<code>` in translation strings in `wp-admin/includes/plugin.php`. 
Props ramiy.
Fixes #31856.
Built from https://develop.svn.wordpress.org/trunk@34314


git-svn-id: http://core.svn.wordpress.org/trunk@34278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 20:29:26 +00:00
Dominik Schilling 622d4bd029 Use correct `@since` tag for `wp_ajax_generate_password()`. 
See #33450.
Built from https://develop.svn.wordpress.org/trunk@34313


git-svn-id: http://core.svn.wordpress.org/trunk@34277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 20:19:25 +00:00
Scott Taylor c43f72fbfb Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user. 
Props adamsilverstein, wonderboymusic.
Fixes #33450.

Built from https://develop.svn.wordpress.org/trunk@34312


git-svn-id: http://core.svn.wordpress.org/trunk@34276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 20:14:24 +00:00