7d70dabf59
Twenty Seventeen: Ensure functions in `customize-controls.js` don't count on Customizer sections always being present
...
Before, the code assumed the `theme_options` section is always present, but it can be removed by plugins. This way, if it is, no JavaScript errors occur.
Props westonruter.
Fixes #39335 .
Built from https://develop.svn.wordpress.org/trunk@39623
git-svn-id: http://core.svn.wordpress.org/trunk@39563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-20 22:17:40 +00:00
f7ba137f19
Customize: Fix visible edit shortcuts for `wp_nav_menu()` instances using the `menu` arg (such as in the Custom Menu widget) instead of the `theme_location` arg.
...
Also fix logic for `focus-control-for-setting` handler to focus on the first control (lowest `priority` value) associated with a given setting instead of the last control encountered when iterating over all controls, as this ensures the first control in a `nav_menu` section is focused rather than the last one.
Props westonruter, sirbrillig.
See #27403 .
Fixes #39101 .
Built from https://develop.svn.wordpress.org/trunk@39622
git-svn-id: http://core.svn.wordpress.org/trunk@39562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-20 22:05:43 +00:00
5b39869860
REST API: Improve the `rest_*_collection_params` filter docs and fix the terms filter.
...
The `rest_{$taxonomy}_collection_params` filter in 4.7 is incorrectly using
single quotes instead of double quotes, which means it is not working correctly
as a dynamic filter. This fixes the quotes around the filter name, and also
updates the docblocks for the other 3 similar filters for better conformance to
the documentation standards.
Props shazahm1hotmailcom, JPry, jnylen0.
Fixes #39300 .
Built from https://develop.svn.wordpress.org/trunk@39621
git-svn-id: http://core.svn.wordpress.org/trunk@39561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-20 01:37:40 +00:00
d515e20a1a
REST API: Fix PHP warnings when `get_theme_support( 'post-formats' )` is not an array.
...
If `add_theme_support( 'post-formats' )` is called with no additional
arguments, then `get_theme_support( 'post-formats' )` returns `true` rather
than an array of supported formats. Avoid generating PHP warnings in this
situation.
Props dreamon11, ChopinBach.
Fixes #39293 .
Built from https://develop.svn.wordpress.org/trunk@39620
git-svn-id: http://core.svn.wordpress.org/trunk@39560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-20 00:56:44 +00:00
c7988f1f03
Editor: Let the Add New link disappear in DFW mode.
...
The link was moved outside the heading in [38983].
Fixes #39313 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39619
git-svn-id: http://core.svn.wordpress.org/trunk@39559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-17 10:23:43 +00:00
7ad554f955
Twenty Seventeen: Improves code readability and code standards in files
...
Adds better DocBlock comments and fixes some spacing issues based on PHP_CodeSniffer WordPress coding standards.
Props sstoqnov.
Fixes #39152 .
Built from https://develop.svn.wordpress.org/trunk@39618
git-svn-id: http://core.svn.wordpress.org/trunk@39558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 22:08:47 +00:00
efb191c2ed
Media: Allow PDF fallbacks filter to process custom sizes.
...
This fixes an oversight in [39246], which added a hook for filtering
the array of sizes used for PDF thumbnails, but failed to provide a way
for sizes added through `add_image_size()` to be processed.
Props gitlost.
Fixes #39231 . See #38594 .
Built from https://develop.svn.wordpress.org/trunk@39617
git-svn-id: http://core.svn.wordpress.org/trunk@39557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 20:30:42 +00:00
15ddaa269e
Customize: Bump `wp_custom_css_cb` from running at `wp_head` priority 11 to 101 to ensure Custom CSS overrides other CSS.
...
Aligns `wp_head` action priority with Jetpack's Custom CSS.
Amends [38829].
See #35395 , #38672 .
Fixes #39270 .
Built from https://develop.svn.wordpress.org/trunk@39616
git-svn-id: http://core.svn.wordpress.org/trunk@39556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 07:29:42 +00:00
1d342fcdc6
Feeds: Replace the RSS2 `lastBuildDate` date field with the `r` date specifier.
...
See #39141 .
Built from https://develop.svn.wordpress.org/trunk@39614
git-svn-id: http://core.svn.wordpress.org/trunk@39554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 06:42:40 +00:00
f794939ed3
Feeds: Do not translate the `lastBuildDate` field in RSS feeds.
...
Props stevenkword, dd32.
Fixes #39141
Built from https://develop.svn.wordpress.org/trunk@39613
git-svn-id: http://core.svn.wordpress.org/trunk@39553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 06:39:41 +00:00
c92e916866
Media: Move a variable definition outside of conditionals to ensure it's always available.
...
This fixes cases where the URL to a PDF preview may be incorrectly calculated when no thumbnails were generated for the PDF (and avoids a PHP Notice at the same time).
Fixes #39250 .
Built from https://develop.svn.wordpress.org/trunk@39612
git-svn-id: http://core.svn.wordpress.org/trunk@39552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 06:21:41 +00:00
bc7a03a33b
WP-API: JavaScript client - fix setup of models used by wp.api.collections objects.
...
Correct setup for the `model` attribute of `wp.api.collections` objects. Set the collection model as a function that returns a new model of the underlying type, instead of setting it as the model prototype. Fixes an issue where models for fetched collections weren't set up properly and didn't have the expected mixin methods such as `getCategories` available.
Props jesseenterprises.
Fixes #39070 .
Built from https://develop.svn.wordpress.org/trunk@39603
git-svn-id: http://core.svn.wordpress.org/trunk@39543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-15 12:54:42 +00:00
4ec102c189
Editor: Remove target=_blank when unchecked in the link modal.
...
Fixes #39276 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39601
git-svn-id: http://core.svn.wordpress.org/trunk@39541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-14 20:30:44 +00:00
4548b08236
General: Use interpolation instead of concatenation for all dynamic hook names.
...
This fixes the rendering of the hook names on developer.wordpress.org.
Props keesiemeijer
Fixes #39148
Built from https://develop.svn.wordpress.org/trunk@39600
git-svn-id: http://core.svn.wordpress.org/trunk@39540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-14 04:18:42 +00:00
efa99585e3
Posts, Post Types: Ensure `is_page_template()` can only return true when viewing a singular post query.
...
Props natereist, dlh
Fixes #39211
Built from https://develop.svn.wordpress.org/trunk@39599
git-svn-id: http://core.svn.wordpress.org/trunk@39539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-14 03:43:43 +00:00
505e135f4c
REST API: Add support for filename search in media endpoint.
...
In [38625], the functionality to search for attachments by filename was added
via the `posts_clauses` filter and the `_filter_query_attachment_filenames()`
function. This moves `_filter_query_attachment_filenames()` from
`wp-admin/includes/post.php` to `wp-includes/post.php` so that it can be
applied in the same manner in the REST API media endpoint.
Props jblz, tyxla.
Fixes #39092 .
Built from https://develop.svn.wordpress.org/trunk@39598
git-svn-id: http://core.svn.wordpress.org/trunk@39538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 14:09:42 +00:00
7cc41e47ac
REST API: Allow sending an empty or no-op comment update.
...
In general, updates that don't actually change anything should succeed.
[39371] added tests for other object types, and this commit fixes empty updates
for comments and adds the missing test.
Fixes #38700 .
Built from https://develop.svn.wordpress.org/trunk@39597
git-svn-id: http://core.svn.wordpress.org/trunk@39537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 13:53:45 +00:00
7d9b5b14b5
Libraries: Update zxcvbn from version 1.0 to 4.4.1
...
This includes masses of bug fixes, as well as tweaks to how passwords are scored.
QUnit tests have been updated to reflect tha scoring changes.
Full changelog: https://github.com/dropbox/zxcvbn/compare/v1.0...v4.4.1
Fixes #31647 .
Built from https://develop.svn.wordpress.org/trunk@39596
git-svn-id: http://core.svn.wordpress.org/trunk@39536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 11:23:42 +00:00
d7ab7fdf5a
REST API: Do not include the `password` argument when getting media items
...
Currently, `attachment` is the only post type exposed via the REST API that
does not support password protection, but it's possible for other post types to
remove password support.
Fixes #38977 .
Built from https://develop.svn.wordpress.org/trunk@39595
git-svn-id: http://core.svn.wordpress.org/trunk@39535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 03:51:44 +00:00
0b599cce41
REST API: Do not error on empty JSON body
...
It's fairly common for clients to send `Content-Type: application/json` with an
empty body. While technically not valid JSON, we've historically supported
this behaviour, so it shouldn't cause an error.
Props JPry.
Fixes #39150 .
Built from https://develop.svn.wordpress.org/trunk@39594
git-svn-id: http://core.svn.wordpress.org/trunk@39534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 03:34:41 +00:00
aa644128d6
Taxonomy: Use `get_term_link()` instead of `get_category_link()` in `get_term_parents_list()`.
...
`get_category_link()` is a wrapper for `get_term_link()`. Using the
unwrapped function makes more sense semantically (it's taxonomy-
agnostic) and it's also more parsimonious (the `WP_Error` check in
`get_category_link()` is redundant with similar checks just before
in `get_term_link()`).
Props keesiemeijer.
Fixes #17069 .
Built from https://develop.svn.wordpress.org/trunk@39593
git-svn-id: http://core.svn.wordpress.org/trunk@39533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 02:57:41 +00:00
20aa5d7150
General: Correctly detect trailing newline when prepending.
...
We need to check that the final line is actually an artifact of explode(), not just an empty input string.
See #37082 .
Built from https://develop.svn.wordpress.org/trunk@39592
git-svn-id: http://core.svn.wordpress.org/trunk@39532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 02:48:41 +00:00
fbc00b31ef
General: Remove most uses of create_function()
...
create_function() is equivalent to eval(), and most of our uses can be refactored. This is simpler, more secure, and slightly more performant.
Props sgolemon.
Fixes #37082 .
Built from https://develop.svn.wordpress.org/trunk@39591
git-svn-id: http://core.svn.wordpress.org/trunk@39531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 01:49:39 +00:00
6e2d9af8b6
Tests: Use `wp_delete_user()` during teardown to delete a single site's user.
...
Fixes failing tests for `get_dashboard_url()`.
Fixes #39065 .
Built from https://develop.svn.wordpress.org/trunk@39590
git-svn-id: http://core.svn.wordpress.org/trunk@39530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 23:18:40 +00:00
d784b5552c
Multisite: Replace `is_super_admin()` with `manage_network` in `get_dashboard_url()`.
...
Unit tests for `get_dashboard_url()` have been added.
Props iaaxpage.
Fixes #39065 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39589
git-svn-id: http://core.svn.wordpress.org/trunk@39529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 22:41:39 +00:00
f704fc808a
Multisite: Handle capability check for removing oneself via `map_meta_cap()`.
...
Site administrators should not be able to remove themselves from a site. This moves the enforcement of this rule from `wp-admin/users.php` to `remove_user_from_blog()` via the `remove_user` capability, which furthermore allows us to get rid of two additional clauses and their `is_super_admin()` checks in `wp-admin/users.php`. A unit test for the new behavior has been added.
Fixes #39063 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39588
git-svn-id: http://core.svn.wordpress.org/trunk@39528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 21:42:42 +00:00
ee36cf9214
Themes: Add missing square bracket in jQuery selector.
...
Fixes a bug in Safari where the UI wasn't updated after deleting a theme due to
the incomplete selector.
Props Hristo Sg.
Fixes #39246 .
Built from https://develop.svn.wordpress.org/trunk@39586
git-svn-id: http://core.svn.wordpress.org/trunk@39526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 09:32:41 +00:00
c9b863fc40
Customize: Prevent navigation in preview when clicking on child elements of preview links that have non-previewable URLs.
...
Fixes #39098 .
Built from https://develop.svn.wordpress.org/trunk@39584
git-svn-id: http://core.svn.wordpress.org/trunk@39524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 08:09:41 +00:00
5edd9b03e7
Remove the WordPress version number from `readme.html`.
...
See #35554
Built from https://develop.svn.wordpress.org/trunk@39583
git-svn-id: http://core.svn.wordpress.org/trunk@39523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 08:01:39 +00:00
8a89a50c69
Customize: Prevent edit shortcut from losing event handler after selective refresh.
...
Props sirbrillig.
See #27403 .
Fixes #39100 .
Built from https://develop.svn.wordpress.org/trunk@39581
git-svn-id: http://core.svn.wordpress.org/trunk@39521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 07:52:43 +00:00
0a349c9641
PDF Images: Avoid a PHP Warning when attempting to process a file without an extension.
...
Props chandrapatel for initial patch.
Fixes #39195 .
Built from https://develop.svn.wordpress.org/trunk@39580
git-svn-id: http://core.svn.wordpress.org/trunk@39520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 06:19:41 +00:00
883689c816
Taxonomy: Restore the ability to use string-based `$args` in `wp_get_object_terms()`.
...
Props tyxla.
Fixes #39215
Built from https://develop.svn.wordpress.org/trunk@39578
git-svn-id: http://core.svn.wordpress.org/trunk@39518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 05:47:42 +00:00
826a0323a2
Build/Test Tools: Facilitate SVN and Git being co-located in the same directory.
...
Ignore .svn in .gitignore, and ignore .git in svn:ignore.
Fixes #39245 .
Built from https://develop.svn.wordpress.org/trunk@39577
git-svn-id: http://core.svn.wordpress.org/trunk@39517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 05:12:44 +00:00
bdf6087450
Bootstrap: Re-initialize any hooks added manually by `object-cache.php`.
...
Prior to 3.1 if a object cache dropin wanted to add actions, they needed to use `$wp_filter` directly.
Props jorbin.
Fixes #39132 .
Built from https://develop.svn.wordpress.org/trunk@39565
git-svn-id: http://core.svn.wordpress.org/trunk@39505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 01:29:42 +00:00
c21907ca1e
Options: Prevent unnecessary SQL updates by `update_option`.
...
Previously an option containing an object would trigger an SQL `UPDATE` on all calls to `update_option`, even if the old and new values were identical. This was due to the old and new values having differing resource IDs.
This change compares the old and new values as serialized data to remove the resource ID from the comparison.
Props salcode, bradyvercher, peterwilsoncc.
Fixes #38903 .
Built from https://develop.svn.wordpress.org/trunk@39564
git-svn-id: http://core.svn.wordpress.org/trunk@39504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-11 21:43:43 +00:00
d054b9afba
REST API: Allow schema sanitization_callback to be set to null to bypass fallback sanitization functions.
...
The logic in WP_REST_Request->sanitize_params() added in [39091] did not account for `null` or `false` being the sanitization_callback preventing overriding `rest_parse_request_arg()`. This fixes that oversight, allowing the built in sanitization function to be bypassed. See #38593 .
Props kkoppenhaver, rachelbaker, jnylen0.
Fixes #39042 .
Built from https://develop.svn.wordpress.org/trunk@39563
git-svn-id: http://core.svn.wordpress.org/trunk@39503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-11 21:26:43 +00:00
9669c60397
Customize: Fix ability to shift-click on placeholder/pre-saved nav menu items in preview to focus on corresponding control.
...
Fixes #39102 .
Built from https://develop.svn.wordpress.org/trunk@39562
git-svn-id: http://core.svn.wordpress.org/trunk@39502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 23:47:41 +00:00
57830bf2be
Customize: Deprecate `page_home` nav menu item starter content in favor of `home_link`; replace usage in Twenty Seventeen.
...
Props celloexpressions, westonruter.
Amends [38991].
See #38615 , #38114 .
Fixes #39104 .
Built from https://develop.svn.wordpress.org/trunk@39561
git-svn-id: http://core.svn.wordpress.org/trunk@39501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 23:39:43 +00:00
a366e58135
Customize: Trim whitespace for URLs supplied for `external_header_video` to prevent `esc_url_raw()` from making them invalid.
...
Props tyxla.
See #38172 .
Fixes #39125 .
Built from https://develop.svn.wordpress.org/trunk@39560
git-svn-id: http://core.svn.wordpress.org/trunk@39500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 07:00:45 +00:00
6527c24ab1
Customize: Prevent single quotes (apostrophes) in `custom_css` values from unexpectedly causing false positives for unbalanced character validation errors.
...
See #39218 , #35395 .
Fixes #39198 .
Built from https://develop.svn.wordpress.org/trunk@39559
git-svn-id: http://core.svn.wordpress.org/trunk@39499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 06:45:42 +00:00
1b96e389c0
Customize: Fix inability to delete nav menus by preventing `preview` filters from being added during `customize_save` admin ajax request.
...
Also prevent setting `nav_menu_locations[...]` values to `NaN` which gets sent as `null`.
Amends [38810].
See #30937 .
Fixes #39103 .
Built from https://develop.svn.wordpress.org/trunk@39558
git-svn-id: http://core.svn.wordpress.org/trunk@39498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 06:30:46 +00:00
f1c383454b
Customize: Prevent scrolling `custom_css` textarea to top when pressing tab.
...
Props tyxla, sstoqnov for testing, celloexpressions for testing.
See #38667 .
Fixes #39134 .
Built from https://develop.svn.wordpress.org/trunk@39557
git-svn-id: http://core.svn.wordpress.org/trunk@39497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 00:44:40 +00:00
5b15e8c11b
Build/Test Tools: Remove some more randomness.
...
See #37371
Built from https://develop.svn.wordpress.org/trunk@39556
git-svn-id: http://core.svn.wordpress.org/trunk@39496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 00:02:41 +00:00
da5255777a
Build/Test Tools: Reuse another fixture in the user capability tests.
...
See #38716
Built from https://develop.svn.wordpress.org/trunk@39555
git-svn-id: http://core.svn.wordpress.org/trunk@39495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 23:36:41 +00:00
b5f7ab46dd
Build/Test Tools: Remove commented out tests that have existed in an unimplemented state since the dawn of the test infrastructure.
...
See #38716
Built from https://develop.svn.wordpress.org/trunk@39554
git-svn-id: http://core.svn.wordpress.org/trunk@39494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 23:12:41 +00:00
10819d629f
Accessibility: Remove inappropriate content from the Edit Categories and Edit Tags screens headings.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39553
git-svn-id: http://core.svn.wordpress.org/trunk@39493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 20:50:41 +00:00
9d474c8206
Accessibility: Remove inappropriate content from the Edit Comments screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39552
git-svn-id: http://core.svn.wordpress.org/trunk@39492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 18:59:40 +00:00
c05f1dc805
Accessibility: Remove inappropriate content from the Network screens headings.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39551
git-svn-id: http://core.svn.wordpress.org/trunk@39491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 18:57:42 +00:00
97fd5ae77c
Docs: Correct param definition for `WP_Query::query()`.
...
Props Shelob9.
Fixes #38963 .
Built from https://develop.svn.wordpress.org/trunk@39550
git-svn-id: http://core.svn.wordpress.org/trunk@39490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 16:23:42 +00:00
74b6e1ba86
Taxonomy: Introduce `get_term_parents_list()`.
...
This new function is a taxonomy-agnostic version of `get_category_parents()`.
Props keesiemeijer, SergeyBiryukov, rafaehlers.
Fixes #17069 .
Built from https://develop.svn.wordpress.org/trunk@39549
git-svn-id: http://core.svn.wordpress.org/trunk@39489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 16:10:42 +00:00
David A. Kennedy
Weston Ruter
James Nylen
Ella Iseulde Van Dorpe
Joe McGill
Dion Hulse
Adam Silverstein
John Blackbourn
Gary Pendergast
Boone Gorges
Ryan McCue
Felix Arntz
Konstantin Obenland
Peter Wilson
Rachel Baker
Andrea Fercia