Nikolay Bachiyski
7da41242f9
Taxonomies: make sure taxonomy functions work correctly with taxonomy names with special characters
...
The codex says that taxonomy names "should only contain lowercase letters and the underscore character", but that's not enforced. It's too late to enforce it, since some plugins haven't been following it and the official phpdoc doesn't mention this restriction.
Merge of [37133] to the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@37136
git-svn-id: http://core.svn.wordpress.org/branches/4.3@37103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 17:23:24 +00:00
Jeremy Felt
8b8783a10f
Multisite: Improve escaping in network settings.
...
Merge of [37124] to the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@37126
git-svn-id: http://core.svn.wordpress.org/branches/4.3@37093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 16:02:23 +00:00
Dominik Schilling
9046c96d95
HTTP: Improve detection of valid IP addresses.
...
Merge of [37115] to the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@37117
git-svn-id: http://core.svn.wordpress.org/branches/4.3@37084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:51:47 +00:00
Dominik Schilling
fdedd97120
Multisite: Validate new email address confirmations.
...
Merge of [37103] to the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@37105
git-svn-id: http://core.svn.wordpress.org/branches/4.3@37072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 14:49:48 +00:00
Nikolay Bachiyski
9631f83b6f
Snoopy: use escapeshellarg instead of escapeshellcmd
...
We are escaping arguments, not commands, so we'd better use the semantically correct function, even though they are similar.
Built from https://develop.svn.wordpress.org/branches/4.3@37096
git-svn-id: http://core.svn.wordpress.org/branches/4.3@37063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 14:05:24 +00:00
Dominik Schilling
dd8b7de724
Bump 4.3 branch to 4.3.3.
...
Built from https://develop.svn.wordpress.org/branches/4.3@36456
git-svn-id: http://core.svn.wordpress.org/branches/4.3@36423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 17:28:22 +00:00
Dominik Schilling
eb0bd01048
Better validation of the URL used in HTTP redirects.
...
Merges [36444] to the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@36448
git-svn-id: http://core.svn.wordpress.org/branches/4.3@36415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:59:51 +00:00
Dominik Schilling
224efaf1e0
HTTP: `0.1.2.3` is not a valid IP.
...
Merges [36435] to the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@36437
git-svn-id: http://core.svn.wordpress.org/branches/4.3@36404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 13:03:51 +00:00
Dominik Schilling
f6115d3bfe
Bump 4.3 branch to 4.3.2.
...
Built from https://develop.svn.wordpress.org/branches/4.3@36197
git-svn-id: http://core.svn.wordpress.org/branches/4.3@36164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 18:48:22 +00:00
Aaron Jorbin
424c4d9a59
Theme: Escape error messages
...
[36185] for 4.3 branch
Built from https://develop.svn.wordpress.org/branches/4.3@36187
git-svn-id: http://core.svn.wordpress.org/branches/4.3@36154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 17:25:23 +00:00
Dion Hulse
a2cf26ef40
Background Updates: Remove the 7am/7pm background update check.
...
This changeset is a more basic version of [36180], clearing the extra now redundant schedule.
As the functionality for this was introduced in 3.9, [28129] has been backported to 3.7/3.8, allowing the API TTL to be respected by those versions.
See #27772 .
Fixes #35323 .
Built from https://develop.svn.wordpress.org/trunk@36184
git-svn-id: http://core.svn.wordpress.org/branches/4.3@36151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 13:24:33 +00:00
Dion Hulse
693913d6b0
Update Akismet externals
...
git-svn-id: http://core.svn.wordpress.org/branches/4.3@35107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 17:19:01 +00:00
Weston Ruter
04a2a43a09
Customizer: Reset horizontal scroll position when finished dragging a nav menu item.
...
Cherry-picks [34834].
Props karinedo, austinginder, adamsilverstein, tyxla.
Fixes #33367 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34835
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 20:48:24 +00:00
Weston Ruter
0e19241593
Customizer: Fix moving focus to available nav menu items search.
...
Fixes regression introduced in [34219].
Cherry-picks [34829].
Props tyxla.
See #33360 .
Fixes #34125 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34830
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 15:30:24 +00:00
Weston Ruter
20596916c3
Customize: Fix `nav_menu_item` CSS `classes` array being incorrectly presented in input field as comma-delimited list.
...
Instead of using `Array.toString()` to serialize an array with comma delimiters, explicitly `join` the array using spaces instead. Also ensure that `xfn` is handled properly if it ever gets stored as an array.
Cherry-picks [34788].
Props tyxla, westonruter.
Fixes #34111 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34789
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 00:20:25 +00:00
Weston Ruter
0b2de83d41
Customize: Fix live previewing of menu changes on subdirectory installs.
...
Merges [34278] from trunk.
Props adamsilverstein, westonruter.
Fixes #33916 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34279
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 05:50:25 +00:00
Dominik Schilling
286bf05ea7
The 4.3 branch is now 4.3.2-alpha.
...
Built from https://develop.svn.wordpress.org/branches/4.3@34267
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 16:21:25 +00:00
Weston Ruter
5e34f4344f
Customizer: Smooth animation for closing accordions in the available nav menu items pane.
...
Merges [34219] from `trunk`.
Props tyxla.
Fixes #33360 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34220
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:43:24 +00:00
Helen Hou-Sandí
cbcc1cbaa3
Finish bumping the 4.3 branch to 4.3.1.
...
Built from https://develop.svn.wordpress.org/branches/4.3@34189
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 14:49:29 +00:00
Helen Hou-Sandí
540e1f84bc
Bump 4.3 branch to 4.3.1.
...
Built from https://develop.svn.wordpress.org/branches/4.3@34181
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 14:26:39 +00:00
Sergey Biryukov
5bb3476a4a
Comments: When setting the `colspan` value for inline edit/reply, make sure it's actually a table and the value is not empty.
...
Merges [34179] to the 4.3 branch.
Props afercia.
See #33596 .
Built from https://develop.svn.wordpress.org/branches/4.3@34180
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:46:35 +00:00
Dominik Schilling
9c57f3a429
XMLRPC: Don't allow private posts to be sticky.
...
Merge of [34135] to the 4.3 branch.
See #20662 .
Built from https://develop.svn.wordpress.org/branches/4.3@34151
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:50:31 +00:00
Nikolay Bachiyski
f72b21af23
Shortcodes: don't allow unclosed HTML elements in attributes
...
Merges [34134] for 4.3 branch
Built from https://develop.svn.wordpress.org/branches/4.3@34144
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:47:23 +00:00
Nikolay Bachiyski
f91a5fd10e
List tables: escape user e-mails
...
Merges [34133] for 4.3 branch
Built from https://develop.svn.wordpress.org/branches/4.3@34137
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:40:23 +00:00
Dominik Schilling
5fe5a0eb07
Passwords: Trigger a `wp-check-valid-field` event when the password field is filled with a password by `generatePassword()`.
...
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
Merge of [34114] to the 4.3 branch.
Fixes #33406 .
Built from https://develop.svn.wordpress.org/branches/4.3@34120
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:09:23 +00:00
Dominik Schilling
12b08da9c2
Settings, password field: Fix placement of the error icon and removal of the error class.
...
Merge of [34068] to the 4.3 branch.
Props liljimmi, adamsilverstein.
See #33406 .
Built from https://develop.svn.wordpress.org/branches/4.3@34119
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:07:23 +00:00
Dominik Schilling
cca265971e
Passwords: Deprecate second parameter of `wp_new_user_notification()`.
...
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.
Adds unit tests.
Merge of [34116] to the 4.3 branch.
Props kraftbj, adamsilverstein, welcher, ocean90.
See #33654 .
Built from https://develop.svn.wordpress.org/branches/4.3@34118
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:03:24 +00:00
Helen Hou-Sandí
bf8ffcc14e
Comments: Fix inline edit/reply on small screens.
...
Merges [34094] to the 4.3 branch.
props ocean90, SergeyBiryukov.
see #33596 .
Built from https://develop.svn.wordpress.org/branches/4.3@34095
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:54:23 +00:00
Dominik Schilling
bff564ee35
Passwords: Refresh password fields when content is pasted into fields.
...
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Merge of [34060] to the 4.3 branch.
Props peterwilsoncc, adamsilverstein.
Fixes #33398 .
Built from https://develop.svn.wordpress.org/branches/4.3@34078
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 12:30:24 +00:00
Andrew Ozz
17ae4e9fb9
Settings: reassign the label when switching password fields so it always highlights the visible field.
...
Props umesh.nevase.
Fixes #33778 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34063
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:23:24 +00:00
Jeremy Felt
9f25a307f5
Multisite: Display content attribution drop down when deleting a user
...
The previous move from echo() to _e() left some of the output hanging. Introduced in [32333].
Merge of [34057] to the 4.3 branch.
Props figureone.
Fixes #33811 .
Built from https://develop.svn.wordpress.org/branches/4.3@34058
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:49:24 +00:00
Dominik Schilling
b04ce4a437
Site Icon: For preview fall back to `full` size URL when `thumbnail` size doesn't exist.
...
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Merge of [34056] to the 4.3 branch.
Props tyxla.
See #33417 .
Built from https://develop.svn.wordpress.org/branches/4.3@34057
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:16:48 +00:00
Dominik Schilling
2a95fc38b2
About: Remove period from placeholder.
...
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.
Merge of [34054] to the 4.3 branch.
Props extendwings, chriscct7.
See #33429 .
Built from https://develop.svn.wordpress.org/branches/4.3@34055
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 19:28:22 +00:00
Dominik Schilling
e52a25130a
Users: Import the global var `$wp_hasher` in `wp_new_user_notification()`.
...
Adds `@global` entries to the DocBlock.
Merge of [34052] to the 4.3 branch.
See #33826 .
Built from https://develop.svn.wordpress.org/branches/4.3@34053
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 19:18:23 +00:00
Andrew Ozz
a10c2ba8f3
TinyMCE: ensure the `wordpress` plugin is loaded before calling `_createToolbar()`.
...
Props hauvong, azaozz.
Fixes #33393 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34032
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 01:47:22 +00:00
Andrew Ozz
26093bdc3e
TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1 .
...
Fixes #33782 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34029
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 23:57:23 +00:00
Andrew Ozz
de170f4c55
Formatting: fix removing line break placeholders from HTML comments at the end of wpautop().
...
Props miqrogroove.
Fixes #33645 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34024
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 22:23:23 +00:00
Gary Pendergast
e1149c9ff1
WPDB: `get_table_from_query()` didn't find table names with hyphens in them.
...
Merge of [33718] to the 4.3 branch.
Props dustinbolton, pento.
See #33470 .
Built from https://develop.svn.wordpress.org/branches/4.3@33991
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 06:55:24 +00:00
Sergey Biryukov
516ee5f231
Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
...
Merges [33766] to the 4.3 branch.
Props peterwilsoncc.
Fixes #33419 for 4.3.1.
Built from https://develop.svn.wordpress.org/branches/4.3@33980
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 17:32:24 +00:00
Boone Gorges
8c51f55fdd
Pass the `$public_only` value to 'get_usernumposts' filter.
...
[32523] introduced the $public_only parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.
This changeset also fixes an incorrect variable name in the docblock for
the same filter, and includes clarification on the accepted values for
the `$post_type` parameter.
Merges [33710] and [33716] to the 4.3 branch.
Props swisspidy, tmatsuur, tyxla, DrewAPicture.
Fixes #33481 for 4.3.1.
Built from https://develop.svn.wordpress.org/branches/4.3@33953
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 20:58:22 +00:00
Scott Taylor
5b643782b6
When creating "Sample Page" on install, comments should be closed.
...
Props macmanx.
Cherry-picks [33693] onto 4.3 branch.
Fixes #33490 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@33950
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 19:05:22 +00:00
Boone Gorges
d8ab8aa97c
In `Walker_CategoryDropdown::start_el()`, cast values to strings before deciding whether to append 'selected' attribute.
...
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the 'selected'
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.
We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.
Merges [33681] to the 4.3 branch.
Fixes #33452 for 4.3.1.
Built from https://develop.svn.wordpress.org/branches/4.3@33949
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 19:04:23 +00:00
Weston Ruter
7e56cfc30a
Customizer: Prevent JS error during init when `nav_menus` panel is removed by plugin.
...
Cherry-picks [33753] onto 4.3 branch.
Fixes #33411 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@33943
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:28:22 +00:00
Weston Ruter
758d53b709
Customizer: Collapse any expanded panel/sections before expanding other panel/sections.
...
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Cherry-picks [33837] onto 4.3 branch.
Props celloexpressions, westonruter.
Fixes #33396 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@33942
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:20:23 +00:00
Weston Ruter
00342ece4a
Customizer: Ensure persistence of unchanged `active` state for controls, sections, and panels.
...
Cherry-picks [33754] onto 4.3 branch.
Props nikeo, westonruter.
Fixes #33428 for 4.3.
See also #33494 .
Built from https://develop.svn.wordpress.org/branches/4.3@33941
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:14:22 +00:00
Weston Ruter
23ef1979f6
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Cherry-picks [33939] on the 4.3 branch.
Fixes #33695 for 4.3
Built from https://develop.svn.wordpress.org/branches/4.3@33940
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:05:23 +00:00
Dion Hulse
e7bb78b884
WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
...
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.
Merges [33688] to the 4.3 branch.
Props jobst.
Fixes #33480 for 4.3
Built from https://develop.svn.wordpress.org/branches/4.3@33883
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 04:38:15 +00:00
Dion Hulse
7f29687a55
Revert [33845]
...
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:33:24 +00:00
Dion Hulse
f0706a0895
Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
...
Merges [33727] to the 4.3 branch
Props Otto42, dd32, peterwilsoncc
Fixes #33423 for trunk
Built from https://develop.svn.wordpress.org/branches/4.3@33877
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:31:17 +00:00
Dion Hulse
7cfe2d293f
Revert [33688] which removed all branches/4.3 files due to a sync script error.
...
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-24 22:14:43 +00:00