John Blackbourn
850532fb01
Cron API: Improvements to docblocks for the event scheduling functions.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42216
git-svn-id: http://core.svn.wordpress.org/trunk@42045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-22 15:16:47 +00:00
Dion Hulse
27116397c5
Upgrade: Fix updating plugins which include a numeric file/folder names.
...
The fix in [41821] caused numeric folder names to be reindexed to 0..n when in the root directory (for example, `my-plugin/24/`).
Props edo888.
See #41524 .
Fixes #42628 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42214
git-svn-id: http://core.svn.wordpress.org/trunk@42043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 04:15:47 +00:00
Boone Gorges
2322b40358
Introduce `meta_box_sanitize_cb` taxonomy argument.
...
The `meta_box_cb` argument was introduced in [25572] to allow plugin
authors to provide a custom callback for rendering their taxonomy's meta
box on the post edit screen. However, the routine used to handle the saving
of these custom taxonomy meta boxes was not customizable, but was instead
based simply on whether the taxonomy was hierarchicaly. See [13535].
The new `meta_box_sanitize_cb` argument defaults to the "tag" routine for
non-hierarchical taxonomies and the "category" routine for hierarchical ones,
thereby maintaining the current default behavior. Developers can override this
when the data passed from their `meta_box_cb` differs.
Props boonebgorges, ZaneMatthew, stephenharris.
Fixes #36514 .
Built from https://develop.svn.wordpress.org/trunk@42211
git-svn-id: http://core.svn.wordpress.org/trunk@42040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 03:15:50 +00:00
Felix Arntz
d14a2988e7
Multisite: Fix broken update `blog_versions` query after [41661].
...
Props Mista-Flo, lenasterg.
Fixes #42641 .
Built from https://develop.svn.wordpress.org/trunk@42210
git-svn-id: http://core.svn.wordpress.org/trunk@42039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 23:46:48 +00:00
Boone Gorges
d86fe35b7f
Improve data types returned from empty hierarchical term queries.
...
When querying for 'count', ensure that 0 is returned. Otherwise,
ensure that it's an array.
Props xParham, birgire.
Fixes #42327 .
Built from https://develop.svn.wordpress.org/trunk@42209
git-svn-id: http://core.svn.wordpress.org/trunk@42038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 22:46:47 +00:00
John Blackbourn
aed08a0f25
HTTP API: Add a `WP_Http` class constant for the HTTP status code `301`.
...
Fixes #42490
Built from https://develop.svn.wordpress.org/trunk@42208
git-svn-id: http://core.svn.wordpress.org/trunk@42037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 20:54:49 +00:00
John Blackbourn
6e39468def
HTTP API: Add support for a description for HTTP status code `103`.
...
Props Dhruvin
Fixes #42490
Built from https://develop.svn.wordpress.org/trunk@42207
git-svn-id: http://core.svn.wordpress.org/trunk@42036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 20:35:48 +00:00
John Blackbourn
bb5621a084
General: Pass on the return value from `wp_redirect()` for `wp_safe_redirect()`.
...
This brings the behaviour of the two functions in line with each other.
Props Drivingralle
Fixes 42108
Built from https://develop.svn.wordpress.org/trunk@42206
git-svn-id: http://core.svn.wordpress.org/trunk@42035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 20:24:48 +00:00
Dion Hulse
71bdb1635b
DB Repair: Only allow non-falsey values of `WP_ALLOW_REPAIR` to access the DB repair functionality.
...
This allows defining the constant as `false` to prevent access (rather than requiring the constant to be removed entirely).
Props tiagohillebrandt, munklefish.
See #11717 .
Fixes #42622 .
Built from https://develop.svn.wordpress.org/trunk@42205
git-svn-id: http://core.svn.wordpress.org/trunk@42034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 06:21:52 +00:00
John Blackbourn
4ef018df2b
Docs: Correct the `@since` property for the `page_attributes_misc_attributes` action.
...
Props jeremyescott, jfarthing84
Fixes #42607
Built from https://develop.svn.wordpress.org/trunk@42203
git-svn-id: http://core.svn.wordpress.org/trunk@42033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-19 11:52:52 +00:00
Felix Arntz
d9e4fc273d
Multisite: Do not show edit links in network users table for users that cannot be edited.
...
Props ocean90.
Fixes #42552 .
Built from https://develop.svn.wordpress.org/trunk@42202
git-svn-id: http://core.svn.wordpress.org/trunk@42032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-17 21:35:51 +00:00
Dion Hulse
24b1297fab
Remove the `svn:keywords` property from files that don't need it.
...
See #42594
Built from https://develop.svn.wordpress.org/trunk@42201
git-svn-id: http://core.svn.wordpress.org/trunk@42031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-17 03:01:47 +00:00
Dion Hulse
cf14a9432c
Remove the `svn:executable` property from files that don't need it.
...
See #42594
Built from https://develop.svn.wordpress.org/trunk@42200
git-svn-id: http://core.svn.wordpress.org/trunk@42030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-17 02:58:45 +00:00
Sergey Biryukov
1a5adcf722
Rewrite Rules: Correct the logic in `extract_from_markers()` after [41928].
...
Props stodorovic.
Fixes #42579 . See #39920 .
Built from https://develop.svn.wordpress.org/trunk@42199
git-svn-id: http://core.svn.wordpress.org/trunk@42029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-16 13:25:50 +00:00
Weston Ruter
5749295a59
Editor: Re-build `tinymce.min.js` after [42191].
...
See #42553 .
Built from https://develop.svn.wordpress.org/trunk@42193
git-svn-id: http://core.svn.wordpress.org/trunk@42023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 23:35:49 +00:00
Weston Ruter
5cab65edab
Editor: Disable `wp_keep_scroll_position` in IE11 since buggy; fix `matches` polyfill conflict with ME.js by doing runtime feature detection in context window.
...
Props westonruter, SergeyBiryukov, Clorith for testing.
See #41962 , #42029 .
Fixes #42553 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42191
git-svn-id: http://core.svn.wordpress.org/trunk@42021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:59:47 +00:00
Weston Ruter
f4e974057e
File Editor: Eliminate gap inserted between code editor and heading in IE11 when CodeMirror initializes.
...
Props afercia, melchoyce, Clorith for testing, SergeyBiryukov for testing.
See #12423 .
Fixes #42554 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42189
git-svn-id: http://core.svn.wordpress.org/trunk@42019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:29:46 +00:00
Weston Ruter
9fabdfb212
Customize: Prevent themes panel from auto-expanding in IE11.
...
In IE11 the `input` event erroneously gets triggered initially without any user input.
Amends [41648].
See #37661 .
Fixes #42556 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42187
git-svn-id: http://core.svn.wordpress.org/trunk@42017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:12:53 +00:00
Weston Ruter
ee126d2567
Widgets: Set global `$post` to current queried object instead of nullifying when `is_singular()` while applying filters (and shortcodes) in Text widget and (via plugin) Custom HTML widget.
...
Also prevent `[gallery]` shortcode from dumping out every attachment on the site when a containing Text widget is shown on an archive template.
Props westonruter, bobbingwide, joemcgill for testing.
See #10457 .
Fixes #42548 , #42547 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42185
git-svn-id: http://core.svn.wordpress.org/trunk@42015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 02:27:48 +00:00
Weston Ruter
9986ebdc0b
Editor: Improve scrolling behavior and prevent autosave logic from causing dirty state when just switching between Visual and Text tabs.
...
Props pento.
See #41962 , #42029 .
Fixes #42530 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42183
git-svn-id: http://core.svn.wordpress.org/trunk@42013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 00:21:48 +00:00
Weston Ruter
6c64136035
About Page: Fix issue with overlapping images and text on IE11 and Edge 15.
...
Props Clorith, ryelle, afercia, la-geek, SergeyBiryukov.
See #42514 .
Fixes #42545 .
Built from https://develop.svn.wordpress.org/trunk@42181
git-svn-id: http://core.svn.wordpress.org/trunk@42011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 23:02:48 +00:00
Peter Wilson
fc0f64e1ef
Editor: Cease adding paragraphs when switching editor tabs.
...
Fixes an error since [41783] in which extra paragraphs could be added to content when switching editor tabs.
Props pento, adamsilverstein, aduth.
Fixes #42531 .
Built from https://develop.svn.wordpress.org/trunk@42177
git-svn-id: http://core.svn.wordpress.org/trunk@42007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 05:24:47 +00:00
Gary Pendergast
5dab6b6e61
Editor: When switching Editor tabs, don't scroll unnecessarily.
...
- When switching to the Text view, wait until after the Visual editor element has been hidden, before focussing the `<textarea>`.
- When switching to the Visual view, only scroll if the cursor is not visible on the current screen.
Fixes #42530 .
Built from https://develop.svn.wordpress.org/trunk@42175
git-svn-id: http://core.svn.wordpress.org/trunk@42005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 05:19:49 +00:00
Weston Ruter
54a2c0dd1f
About: Fix jumping behavior for titles and columns when scrolling.
...
Props ryelle.
See #42087 .
Fixes #42514 , #42526 .
Built from https://develop.svn.wordpress.org/trunk@42173
git-svn-id: http://core.svn.wordpress.org/trunk@42003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:47:58 +00:00
Weston Ruter
e484b66335
Customize: Allow notifications for linting errors in code editor control (for Additional CSS) to be overridden to allow saving.
...
Implements the same override that was implemented in [41721] for the theme/plugin editors.
See #41897 , #41887 .
Fixes #42528 .
Built from https://develop.svn.wordpress.org/trunk@42171
git-svn-id: http://core.svn.wordpress.org/trunk@42001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:46:34 +00:00
Weston Ruter
609c0db668
Customize: Prevent PHP notice on theme-switch dashboard welcome link (and link to themes admin screen) when user cannot `customize`.
...
Props skostadinov, ocean90.
Amends [41699].
See #42050 .
Fixes #42525 .
Built from https://develop.svn.wordpress.org/trunk@42169
git-svn-id: http://core.svn.wordpress.org/trunk@41999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:45:11 +00:00
Boone Gorges
2f95f44008
Correct documentation for `status` param of `WP_Comment_Query`.
...
The `status` parameter accepts an array or string/comma-separated list.
Introduced in [30084].
Props pbiron.
Fixes #41338 .
Built from https://develop.svn.wordpress.org/trunk@42165
git-svn-id: http://core.svn.wordpress.org/trunk@41996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 16:26:47 +00:00
Weston Ruter
4e320fe008
I18N: Fix passing singular/plural strings to JS.
...
This is a temporary solution while waiting for full I18N support in JS.
Props ocean90, dd32, westonruter, Mirucon for testing.
Amends [41376], [41721], [41389],
See #20491 .
Fixes #42510 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42163
git-svn-id: http://core.svn.wordpress.org/trunk@41994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 07:08:47 +00:00
Weston Ruter
6d2bf4398c
About: Add vertical alignment for developer happiness sections.
...
Also run CSS autoprefixer to add `-ms-` prefixes for CSS grid identifiers for IE11.
Props Presskopp.
Amends [42121].
See #42087 .
Fixes #42524 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42161
git-svn-id: http://core.svn.wordpress.org/trunk@41992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:48:47 +00:00
Weston Ruter
41d60f59f8
About: Fix grammar typo with pluralization.
...
Props metodiew, westonruter.
Amends [42121].
See #42087 .
Fixes #42476 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42159
git-svn-id: http://core.svn.wordpress.org/trunk@41990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:19:50 +00:00
Weston Ruter
2bec203118
About: Synchronize 4.9 tagline across about pages for credits, freedoms, and privacy.
...
Props dave.pullig.
Amends [41943].
See #42087 .
Fixes #42518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42157
git-svn-id: http://core.svn.wordpress.org/trunk@41988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-12 19:59:53 +00:00
Weston Ruter
2aa2c686d4
Theme Editor: Fix styling of child theme notice.
...
Props westonruter, melchoyce, ndiego.
See #24048 .
Fixes #42491 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42155
git-svn-id: http://core.svn.wordpress.org/trunk@41986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-11 20:43:53 +00:00
Weston Ruter
826c589f11
Customize: Restore ability to add Custom Link nav menu items for jump links and other URLs that were previously allowed.
...
Simplify regular expression for checking URL validity to just do basic checks to confirm the value looks like a URL. Leave the complete validation to the server-side logic in `WP_Customize_Nav_Menu_Item_Setting::sanitize()` to avoid having to maintain two separate codebases for validating URLs.
Props westonruter, SergeyBiryukov for testing.
Amends [41697].
See #32816 .
Fixes #42506 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42153
git-svn-id: http://core.svn.wordpress.org/trunk@41984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:41:53 +00:00
Weston Ruter
e86536afc9
Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px.
...
Props obenland.
Amends [41817].
See #42157 .
Fixes #42492 .
Built from https://develop.svn.wordpress.org/trunk@42152
git-svn-id: http://core.svn.wordpress.org/trunk@41983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:01:48 +00:00
John Blackbourn
67c973f95e
Docs: Correct parameter type documentation for various `__call()` methods.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42151
git-svn-id: http://core.svn.wordpress.org/trunk@41982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:56:47 +00:00
Weston Ruter
6c6d112e74
Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed.
...
Amends [38810].
Props dlh.
Fixes #42497 .
Built from https://develop.svn.wordpress.org/trunk@42150
git-svn-id: http://core.svn.wordpress.org/trunk@41981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:51:46 +00:00
Weston Ruter
016a3f9ecd
Customize: Ensure customization drafts are published instead of trashed when scheduled changeset goes live while non-admin user is authenticated (such as during WP Cron).
...
Props designsimply for testing, dlh for testing, melchoyce for testing.
See #28721 , #34923 , #42220 .
Fixes #42489 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42148
git-svn-id: http://core.svn.wordpress.org/trunk@41979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:44:52 +00:00
Weston Ruter
10ac2ccd3a
Settings: Replace `count()` call with `empty()` in `get_settings_errors()` to prevent PHP 7.2 warnings when `$wp_settings_errors` is `null`.
...
Props pross, dd32, westonruter.
See #40109 .
Fixes #42498 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42146
git-svn-id: http://core.svn.wordpress.org/trunk@41977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:30:56 +00:00
Weston Ruter
9db496159e
Customize: Ensure autosave revision is dismissed immediately after implicit restoration notice dismissal as done with explicit notice dismissal.
...
Fixes issue where a drafted/scheduled changeset could inadvertently re-use the previous autosave revision in the preview while a user expects it to have been dismissed.
See #39896 , [41597].
Fixes #42502 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42144
git-svn-id: http://core.svn.wordpress.org/trunk@41975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 21:44:55 +00:00
John Blackbourn
3be5d4b4f0
Docs: Improve inline docs for the `wp_redirect()` and `wp_safe_redirect()` functions.
...
See #42505 , #42108
Built from https://develop.svn.wordpress.org/trunk@42143
git-svn-id: http://core.svn.wordpress.org/trunk@41974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 13:44:47 +00:00
Gary Pendergast
e8229a25d5
REST API: Add `permalink_structure` to the index endpoint.
...
This allows Gutenberg to implement permalink editing.
Props schlessera.
Fixes #42465 .
Built from https://develop.svn.wordpress.org/trunk@42142
git-svn-id: http://core.svn.wordpress.org/trunk@41973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 06:11:51 +00:00
Weston Ruter
4bf8081e64
Widgets: Style the Image Widget's link field as invalid when a bad URL is supplied.
...
Fixes issue where user may supply an invalid URL and be unable to save the widget on the Widgets admin screen without being told why.
Amends [41252].
See #41274 .
Fixes #42488 .
Built from https://develop.svn.wordpress.org/trunk@42140
git-svn-id: http://core.svn.wordpress.org/trunk@41971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 01:28:49 +00:00
Weston Ruter
1ee26acf95
Customize: Fix reliability of just-in-time publishing for changesets that miss their schedule when visiting `customize.php`.
...
When just doing `wp_publish_post()` for the changeset from `customize.php`, any option-based settings will fail to get saved because `WP_Customize_Manager` would have already been loaded with `settings_previewed`, resulting in `update_option()` calls being short-circuited. So an admin-ajax request to `customize_save` is used to work around this.
Props westonruter, jeremyfelt, dlh for testing, LittleBigThing for testing.
Amends [41626].
See #28721 , #39221 .
Fixes #42457 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42138
git-svn-id: http://core.svn.wordpress.org/trunk@41969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:44:47 +00:00
Weston Ruter
19ec50f92a
Customize: Ensure `autosaving` message gets sent to preview after initial change when `saved` state is first dirty.
...
Amends [41667].
Fixes #42475 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42136
git-svn-id: http://core.svn.wordpress.org/trunk@41967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:15:49 +00:00
Weston Ruter
6c00350575
Settings: Fix date/time format previewing.
...
Props afercia.
Amends [41857].
Fixes #41603 .
Built from https://develop.svn.wordpress.org/trunk@42134
git-svn-id: http://core.svn.wordpress.org/trunk@41965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 03:55:46 +00:00
Weston Ruter
3c6ce6751f
Customize: Restore search icon to available widgets pane incorrectly removed in [41893].
...
See #42215 .
Fixes #42472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42132
git-svn-id: http://core.svn.wordpress.org/trunk@41963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 01:02:47 +00:00
Gary Pendergast
39a3fe9180
Admin Bar: Fix another HTML error introduced in [42128].
...
Props Otto42.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42131
git-svn-id: http://core.svn.wordpress.org/trunk@41962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 23:13:46 +00:00
Dion Hulse
0a81bcf4ff
External Libraries: Update Random_Compat from 1.2.1 to 2.0.11.
...
Notably this fixes PHP7 parse errors of the files and removes the OpenSSL functionality.
Full Changes: https://github.com/paragonie/random_compat/compare/v1.2.1...v2.0.11
Props jrdelarosa.
See #42439 .
Built from https://develop.svn.wordpress.org/trunk@42130
git-svn-id: http://core.svn.wordpress.org/trunk@41961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 11:48:49 +00:00
Gary Pendergast
e822e4578a
Admin Bar: Fix a HTML error introduced in [42128].
...
Props swissspidy.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42129
git-svn-id: http://core.svn.wordpress.org/trunk@41960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 08:52:48 +00:00
Gary Pendergast
bde3b95936
Admin Bar: Reformat the render methods.
...
The admin bar render methods use some cute tricks which don't come close to the WordPress coding standards. So that we can more easily apply automated code fixing to the codebase, these tricks need to be removed.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42128
git-svn-id: http://core.svn.wordpress.org/trunk@41959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 08:35:51 +00:00