Sergey Biryukov
8dc75b569c
REST API: Set `orderby` parameter in tax relation unit tests added in [46646].
...
The default value of `date` caused a race condition resulting in random test failures.
See #44326 .
Built from https://develop.svn.wordpress.org/trunk@46648
git-svn-id: http://core.svn.wordpress.org/trunk@46448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 12:36:04 +00:00
Sergey Biryukov
8b76312eb3
Docs: Correct some array hash notations added in [46644].
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46647
git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 09:37:02 +00:00
TimothyBlynJacobs
5124c542e1
REST API: Add tax relation parameter to posts collection.
...
The REST API supports filtering by terms across multiple taxonomies using an AND relation. This adds support for an OR relation by adding "tax_relation=OR" as a query parameter.
Props earnjam.
Fixes #44326 .
Built from https://develop.svn.wordpress.org/trunk@46646
git-svn-id: http://core.svn.wordpress.org/trunk@46446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 23:14:02 +00:00
Aaron Jorbin
a4687f9134
Remove Failing Tests added in r46641
...
The tests for good redirects send headers that we can't handle in the test suite, so let's just remove them.
Unprops Jorbin.
Fixes #44317 .
Built from https://develop.svn.wordpress.org/trunk@46645
git-svn-id: http://core.svn.wordpress.org/trunk@46445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:49:03 +00:00
John Blackbourn
b3d6acd6a4
Docs: Fix some incorrect return tags in docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46644
git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:23:01 +00:00
whyisjake
441a4d752e
Coding Standards: Clean up the tests around `test_that_you_can_login_with_an_email_that_has_apostrophe`.
...
Let's use the proper coding standards for the comments.
Fixes #38744 .
Props cafenoirdesign.
Built from https://develop.svn.wordpress.org/trunk@46643
git-svn-id: http://core.svn.wordpress.org/trunk@46443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:17:58 +00:00
whyisjake
5e7876622e
Toolbar: Use `add_node()` instead of `add_menu()` in core.
...
This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)
Fixes : #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46642
git-svn-id: http://core.svn.wordpress.org/trunk@46442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:14:01 +00:00
Aaron Jorbin
946217dcca
General: wp_safe_redirect() and wp_redirect() shouldn't allow non-3xx status codes
...
Redirects should use redirect status codes and if you attempt to call wp_safe_redirect or wp_redirect with a non redirect status it can lead to undesired behavior and head scratching.
Fixes #44317 .
Props spenserhale, johnbillion, mjnewman for initial patch.
Built from https://develop.svn.wordpress.org/trunk@46641
git-svn-id: http://core.svn.wordpress.org/trunk@46441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:10:02 +00:00
whyisjake
a87271af60
Login and Registration: Allow email logins to be more flexible.
...
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.
Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46640
git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 20:12:02 +00:00
desrosj
44db7e4f6f
External Libraries: Revert [46634-46635].
...
On further investigation, Plupload changed it’s license to a non-GPL compatible license. The newest, GPL compatible version is being used already in Core.
Unprops desrosj.
See #48277 .
Built from https://develop.svn.wordpress.org/trunk@46638
git-svn-id: http://core.svn.wordpress.org/trunk@46438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 17:09:02 +00:00
desrosj
583e49d95f
Customize: Formally deprecate unused Customizer classes.
...
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.
Props weston.ruter, matthias-reuter, jrf.
Fixes #42364 .
Built from https://develop.svn.wordpress.org/trunk@46637
git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 16:48:00 +00:00
desrosj
be164bf6f4
Add `svn:auto-props` for `eol-style` and `mime-type` to `trunk`.
...
`svn:eol-style` and `svn:mime-type` property default values are now provided for all file types currently in `trunk`.
This also reverts the `eol-style` change to `wp-config-sample.php` made in [46586].
Fixes #42594 .
Built from https://develop.svn.wordpress.org/trunk@46636
git-svn-id: http://core.svn.wordpress.org/trunk@46436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 16:21:03 +00:00
desrosj
df7a0f7879
Remove unintended change to `svn:ignore` in [46634].
...
Built from https://develop.svn.wordpress.org/trunk@46635
git-svn-id: http://core.svn.wordpress.org/trunk@46435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 15:34:00 +00:00
desrosj
d825155631
External Libraries: Update Plupload from 2.1.9 to 2.3.6.
...
This change also updates the MoxieJS dependency from 1.3.5 to 1.5.7, converts Plupload to a dependency in NPM, and integrates all relevant parts into the build process.
For a full list of upstream changes, see https://github.com/moxiecode/plupload/compare/v2.1.9...v2.3.6 .
Props desrosj, hareesh-pillai.
Fixes #48277 .
Built from https://develop.svn.wordpress.org/trunk@46634
git-svn-id: http://core.svn.wordpress.org/trunk@46434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 15:31:02 +00:00
Sergey Biryukov
265bc4fe74
General: Wrap the error message in `_deprecated_constructor()` in `<code>` tags instead of `<pre>`.
...
Props aftabmuni.
Fixes #48483 .
Built from https://develop.svn.wordpress.org/trunk@46633
git-svn-id: http://core.svn.wordpress.org/trunk@46433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 10:56:03 +00:00
Sergey Biryukov
24650cbd68
Code Modernization: Call PHP 5 constructors in methods extending `POMO_Reader`.
...
Follow-up to [46629].
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46632
git-svn-id: http://core.svn.wordpress.org/trunk@46432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:49:01 +00:00
Sergey Biryukov
6cd00d098e
Docs: Correct version number in `@deprecated` tags for PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
...
Follow-up to [46629].
Props jrf.
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46631
git-svn-id: http://core.svn.wordpress.org/trunk@46431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:30:01 +00:00
Sergey Biryukov
85db3b5090
Docs: Correct `@see` references for PHP 4 constructors in `wp-includes/class-json.php`.
...
See #48252 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@46630
git-svn-id: http://core.svn.wordpress.org/trunk@46430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:13:02 +00:00
Sergey Biryukov
a0e7056387
Docs: Add missing `@deprecated` tags to PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
...
Props jrf.
Fixes #48252 .
Built from https://develop.svn.wordpress.org/trunk@46629
git-svn-id: http://core.svn.wordpress.org/trunk@46429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:11:04 +00:00
Sergey Biryukov
8aae5cb572
Twenty Eleven: Add missing `@deprecated` tag to PHP 4 constructor in `Twenty_Eleven_Ephemera_Widget`.
...
Props jrf.
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46628
git-svn-id: http://core.svn.wordpress.org/trunk@46428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:08:00 +00:00
Sergey Biryukov
6be425959a
Docs: Add missing `@deprecated` tags to PHP 4 constructors in `WP_Widget` and `WP_Widget_Factory()`.
...
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].
Props jrf.
See #48252 .
Built from https://develop.svn.wordpress.org/trunk@46627
git-svn-id: http://core.svn.wordpress.org/trunk@46427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 20:06:03 +00:00
Dion Hulse
ff6948a643
Bump Akismet external to 4.1.3.
...
See #WP47269.
git-svn-id: http://core.svn.wordpress.org/trunk@46424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-02 15:31:32 +00:00
Sergey Biryukov
2651ff3ae8
Docs: Update URLs in some `@link` tags and switch them to HTTPS.
...
Props tsuyoring.
Fixes #48479 .
Built from https://develop.svn.wordpress.org/trunk@46626
git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-01 14:57:02 +00:00
Sergey Biryukov
979a526902
Code Modernization: Pass an appropriate error level to `trigger_error()` in `_doing_it_wrong()` and related functions:
...
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`
The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.
Props jrf.
Fixes #36561 .
Built from https://develop.svn.wordpress.org/trunk@46625
git-svn-id: http://core.svn.wordpress.org/trunk@46422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-01 00:41:01 +00:00
John Blackbourn
be91e3e1b9
Docs: Correct some more invalid inline docs.
...
See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description
See #48303
Built from https://develop.svn.wordpress.org/trunk@46624
git-svn-id: http://core.svn.wordpress.org/trunk@46421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 21:20:02 +00:00
John Blackbourn
d1b23193dd
Docs: Correct some incorrect docblock tags.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46623
git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 17:51:01 +00:00
Sergey Biryukov
3d76b537d6
Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621].
...
See #48472 .
Built from https://develop.svn.wordpress.org/trunk@46622
git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 00:13:01 +00:00
Andrew Ozz
ed651b17a4
Upload:
...
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.
Fixes #48472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46621
git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-30 21:10:04 +00:00
Sergey Biryukov
e678d5bf28
Docs: Document `$error`, `$interim_login`, and `$action` globals in `login_header()` and `login_footer()`.
...
Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777 .
Built from https://develop.svn.wordpress.org/trunk@46620
git-svn-id: http://core.svn.wordpress.org/trunk@46417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-30 02:59:03 +00:00
desrosj
0b94025ba9
Help/About: Update the 5.3 About page for RC3.
...
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46616
git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 20:10:04 +00:00
desrosj
b5cc5b37f7
Bundled Themes: Update Twenty Twenty.
...
This brings trunk’s version of Twenty Twenty in-sync with GitHub.
For a complete list of changes since [46571], see 4549fd9...dea9290
.
Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450 .
Built from https://develop.svn.wordpress.org/trunk@46613
git-svn-id: http://core.svn.wordpress.org/trunk@46410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 14:55:05 +00:00
Sergey Biryukov
4935555c70
Build/Test Tools: Ignore EOL differences in tests using multiline string assertions.
...
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.
Fixes #31432 . See #42594 , #47411 .
Built from https://develop.svn.wordpress.org/trunk@46612
git-svn-id: http://core.svn.wordpress.org/trunk@46409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 14:28:06 +00:00
John Blackbourn
057f661ce3
Docs: Miscellaneous docblock corrections.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46610
git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:48:01 +00:00
John Blackbourn
c08dbe5236
Docs: Coding standards fix after [46608].
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46609
git-svn-id: http://core.svn.wordpress.org/trunk@46406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:35:07 +00:00
John Blackbourn
817807e5be
Docs: Remove some funky nested filters.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46608
git-svn-id: http://core.svn.wordpress.org/trunk@46405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:04:05 +00:00
Sergey Biryukov
3a257f4018
Docs: Restore correct placement for duplicate hook reference in `render_block_core_latest_comments()`.
...
Previously fixed in [46604], accidentally reverted in [46606].
See #48447 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@46607
git-svn-id: http://core.svn.wordpress.org/trunk@46404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 15:17:03 +00:00
youknowriad
6a713e53bc
Block Editor: Bug fixes targetted for WordPress 5.3 RC3.
...
The list of included fixes is:
- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102
Updated packages:
- @wordpress/api-fetch@3.6.4
- @wordpress/block-directory@1.0.4
- @wordpress/block-library@2.9.4
- @wordpress/core-data@2.7.4
- @wordpress/data-controls@1.3.4
- @wordpress/edit-post@3.8.4
- @wordpress/editor@9.7.4
- @wordpress/list-reusable-blocks@1.8.4
- @wordpress/media-utils@1.2.4
- @wordpress/server-side-render@1.3.4
Props desrosj.
See #48447 .
Built from https://develop.svn.wordpress.org/trunk@46606
git-svn-id: http://core.svn.wordpress.org/trunk@46403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 14:13:09 +00:00
whyisjake
7542543e26
Build/Test Tools: Don't hardcode the directory name of the repo
...
When Travis builds the directory, it was looking for a hardcoded `wordpress-develop` directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.
Fixes #48444 .
Props pento, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46605
git-svn-id: http://core.svn.wordpress.org/trunk@46402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 04:17:02 +00:00
John Blackbourn
f243cd573c
Docs: Correct invalid hook docblock placement.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46604
git-svn-id: http://core.svn.wordpress.org/trunk@46401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 19:35:01 +00:00
John Blackbourn
c8f91f77ac
Docs: Correct invalid hook docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46603
git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 19:11:02 +00:00
Sergey Biryukov
c283f8b1ed
Docs: Remove "private" designation from `_doing_it_wrong()` and related functions:
...
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`
Plugins and themes should be allowed to use these functions to throw appropriate error notices.
This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.
Props jrf.
Fixes #48251 .
Built from https://develop.svn.wordpress.org/trunk@46602
git-svn-id: http://core.svn.wordpress.org/trunk@46399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 14:21:03 +00:00
Sergey Biryukov
e015fbd8bb
Editor: Fix typo in an error message in `WP_Block_Styles_Registry::register()`.
...
Props man4toman, alishankhan, shaampk1.
Fixes #48437 .
Built from https://develop.svn.wordpress.org/trunk@46601
git-svn-id: http://core.svn.wordpress.org/trunk@46398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 14:09:02 +00:00
Sergey Biryukov
bb57520713
Docs: Improve DocBlock formatting in `WP_Block_Styles_Registry` per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46600
git-svn-id: http://core.svn.wordpress.org/trunk@46397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 14:07:02 +00:00
John Blackbourn
d599314349
Docs: Correct and improve inline docs for the file type functions.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46599
git-svn-id: http://core.svn.wordpress.org/trunk@46396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:49:03 +00:00
John Blackbourn
ac6bf7666c
Docs: Add missing docs for the `auth_cookie_bad_session_token` action.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46598
git-svn-id: http://core.svn.wordpress.org/trunk@46395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:46:00 +00:00
John Blackbourn
9e2b6902b3
Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46597
git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:16:04 +00:00
John Blackbourn
3caaa40fc6
Docs: Switch more docs over to typed array notation, plus some fixes.
...
See #48303 , #41756
Built from https://develop.svn.wordpress.org/trunk@46596
git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:09:04 +00:00
John Blackbourn
9890e68661
Docs: Switch to typed array notation for the docs for asset dependency functions.
...
Props marekdedic
See #48303
Built from https://develop.svn.wordpress.org/trunk@46595
git-svn-id: http://core.svn.wordpress.org/trunk@46392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:02:02 +00:00
John Blackbourn
7c2b9f2a2e
Docs: Miscellaneous docblock fixes and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46594
git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 20:43:04 +00:00
Sergey Biryukov
552852d887
Docs: Improve documentation for `esc_attr_e()`, `esc_html_e()`, `esc_attr_x()`, `esc_html_x()`.
...
Props atachibana.
Fixes #48383 .
Built from https://develop.svn.wordpress.org/trunk@46593
git-svn-id: http://core.svn.wordpress.org/trunk@46390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 17:30:03 +00:00