Jeremy Felt
947eef9468
Introduce get_main_network_id()
...
Expand on the logic previously available as part of `is_main_network()` and provide a way to obtain the ID of the main network. Most useful in multi-network configurations.
Props @johnjamesjacoby for the initial patch.
Fixes #30294 .
Built from https://develop.svn.wordpress.org/trunk@32775
git-svn-id: http://core.svn.wordpress.org/trunk@32746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 21:45:25 +00:00
Helen Hou-Sandí
e3ae4f9d7e
Multisite: Use an email input for new user email address.
...
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.
props earnjam.
fixes #32643 .
Built from https://develop.svn.wordpress.org/trunk@32774
git-svn-id: http://core.svn.wordpress.org/trunk@32745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:41:27 +00:00
Andrew Nacin
a0f4e8e086
Media: Support title fields to be removed from attachments.
...
props antpb.
fixes #23932 .
Built from https://develop.svn.wordpress.org/trunk@32773
git-svn-id: http://core.svn.wordpress.org/trunk@32744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:33:26 +00:00
Helen Hou-Sandí
ed46512c20
Reduce form spacing on narrower screens.
...
props liljimmi.
fixes #32489 , #32484 .
Built from https://develop.svn.wordpress.org/trunk@32772
git-svn-id: http://core.svn.wordpress.org/trunk@32743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:12:26 +00:00
Andrew Nacin
748b3763cb
Add add_user_role and remove_user_role actions for WP_User::add_role() and remove_role().
...
props shooper.
fixes #32060 .
Built from https://develop.svn.wordpress.org/trunk@32771
git-svn-id: http://core.svn.wordpress.org/trunk@32742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 19:26:25 +00:00
Aaron Jorbin
38d59c0828
Improve dbDelta unit tests
...
Add new tests for more parts of dbDelta. This was cleaned up and prepared for commit at #wcphilly contributor day.
Props jdgrimes, tryon, jtsternberg, ebinnion, JPry, avnarun, kevkoeh, jorbin, salcode.
Fixes #29020 .
Built from https://develop.svn.wordpress.org/trunk@32770
git-svn-id: http://core.svn.wordpress.org/trunk@32741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 19:23:26 +00:00
Andrew Nacin
7080c8e24b
Update comment caches in WP_Comment_Query, rather than comments template.
...
props dd32.
fixes #31081 .
Built from https://develop.svn.wordpress.org/trunk@32769
git-svn-id: http://core.svn.wordpress.org/trunk@32740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 19:21:25 +00:00
Andrew Nacin
e7f618d86e
Tweak the first post/page content to get with the times.
...
props chriscct7.
fixes #22474 .
Built from https://develop.svn.wordpress.org/trunk@32768
git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:50 +00:00
Aaron Jorbin
36e593a46c
Restore [32732] as it wasn't the actual cause of test failures as those failures where fixed separately.
...
See #32732
Built from https://develop.svn.wordpress.org/trunk@32767
git-svn-id: http://core.svn.wordpress.org/trunk@32738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:26 +00:00
Aaron Jorbin
3d2f8542ac
Revert [32732] since it is causing the tests to break
...
See #32732
Built from https://develop.svn.wordpress.org/trunk@32766
git-svn-id: http://core.svn.wordpress.org/trunk@32737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:43:25 +00:00
Aaron Jorbin
cbb6f91a29
Improve lastBuildDate timestamp in rss feeds
...
RSS feed timestamps should reflect the actual timestamps for those RSS feeds rather than the generic timestamp for all posts and all comments.
Props stevenkword.
Fixes #4575 .
Built from https://develop.svn.wordpress.org/trunk@32765
git-svn-id: http://core.svn.wordpress.org/trunk@32736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:37:24 +00:00
Dominik Schilling
df11970e18
Nav menus: Introduce a `wp_get_nav_menu_object` filter in `wp_get_nav_menu_object()` to filter the retrieved nav_menu term.
...
props westonruter.
fixes #32629 .
Built from https://develop.svn.wordpress.org/trunk@32764
git-svn-id: http://core.svn.wordpress.org/trunk@32735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 17:37:25 +00:00
Dominik Schilling
8dcd236ba3
Nav menus: Reset the `fallback_cb` default argument in `wp_nav_menu` in case of a Customizer preview.
...
props westonruter.
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32763
git-svn-id: http://core.svn.wordpress.org/trunk@32734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 17:14:24 +00:00
Dominik Schilling
55f3b68c75
Nav Menus: Update `wp_setup_nav_menu_item()` to stop overriding empty properties from supplied `$menu_item`.
...
Update docs for `WP_Post` constructor to indicate that `WP_Post|object` can be the supplied param, as opposed to just `WP_Post`.
props westonruter.
fixes #32632 .
Built from https://develop.svn.wordpress.org/trunk@32762
git-svn-id: http://core.svn.wordpress.org/trunk@32733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 10:53:25 +00:00
Jeremy Felt
8daec04557
Remove a now unused `switch_to_blog()` and `restore_current_blog()` in site-info.php
...
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.
See #32503 .
Built from https://develop.svn.wordpress.org/trunk@32761
git-svn-id: http://core.svn.wordpress.org/trunk@32732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 08:23:26 +00:00
Jeremy Felt
da35c25fb7
Remove the "Update siteurl and home as well" checkbox when editing a site
...
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.
Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.
Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503 , see #22383 .
Built from https://develop.svn.wordpress.org/trunk@32760
git-svn-id: http://core.svn.wordpress.org/trunk@32731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:52:24 +00:00
Jeremy Felt
186c37a325
Capture domain and path when editing sites on a subdomain network
...
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.
This takes a step or two toward #32503 .
Props @scribu, @ericlewis, @jeremyfelt.
See #22383 .
Built from https://develop.svn.wordpress.org/trunk@32759
git-svn-id: http://core.svn.wordpress.org/trunk@32730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:09:25 +00:00
Jeremy Felt
f996e163b8
Improve code readability in site-info.php
...
In advance of some other work here, clean up some braces and spaces.
See #22383 .
Built from https://develop.svn.wordpress.org/trunk@32758
git-svn-id: http://core.svn.wordpress.org/trunk@32729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 05:01:28 +00:00
Scott Taylor
4348074f3a
In `WP_MS_Users_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32757
git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 17:11:26 +00:00
Scott Taylor
3855cfbffd
In `WP_MS_Themes_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32756
git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:54:26 +00:00
Scott Taylor
2bdcc71bc0
In `WP_MS_Sites_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32755
git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:23:25 +00:00
Scott Taylor
ba8cfcab71
In `WP_Media_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32754
git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:57:27 +00:00
Scott Taylor
a56576edfe
In `WP_Links_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32753
git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:33:25 +00:00
Scott Taylor
b8eb353590
In `WP_Posts_List_Table`, move the `<th>` markup out of `->column_cb()`.
...
See #29881 , [32740].
Built from https://develop.svn.wordpress.org/trunk@32752
git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:14:24 +00:00
Scott Taylor
18827ed337
In `wp_ajax_hidden_columns()`, don't `explode()` on an empty string.
...
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.
This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.
Props afercia, wonderboymusic.
Fixes #32466 .
Built from https://develop.svn.wordpress.org/trunk@32751
git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
Dominik Schilling
5ec278f585
Toolbar: Remove a duplicate CSS selector.
...
props deconf.
fixes #32634 .
Built from https://develop.svn.wordpress.org/trunk@32750
git-svn-id: http://core.svn.wordpress.org/trunk@32721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:54:25 +00:00
Scott Taylor
da0400e273
In `WP_Posts_List_Table::column_title()`, use `is_post_type_hierarchical()` instead of `$this->hierarchical_display` in the logic to determine whether `the_excerpt()` should be called.
...
Fixes #32187 .
Built from https://develop.svn.wordpress.org/trunk@32749
git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:42:26 +00:00
Dominik Schilling
792295d077
Nav menus: Apply the `wp_get_nav_menu_items` filter also on an empty list of menu items.
...
props westonruter.
fixes #32631 .
Built from https://develop.svn.wordpress.org/trunk@32748
git-svn-id: http://core.svn.wordpress.org/trunk@32719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:38:25 +00:00
Scott Taylor
144a28a5c2
Add an `abort` class method to the Promise instance returned by `wp.ajax.send()`.
...
Props westonruter.
Fixes #32628 .
Built from https://develop.svn.wordpress.org/trunk@32747
git-svn-id: http://core.svn.wordpress.org/trunk@32718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:30:26 +00:00
Dominik Schilling
33c1c76001
Nav menu: Introduce a `has_nav_menu` filter in `has_nav_menu()` to filter whether a nav menu is assigned to a specified location.
...
props westonruter.
fixes #32630 .
Built from https://develop.svn.wordpress.org/trunk@32746
git-svn-id: http://core.svn.wordpress.org/trunk@32717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:15:25 +00:00
Dominik Schilling
fe31ed1e5f
Nav menu: Allow the sortable items selector in `wpNavMenu` to be overridden.
...
props adamsilverstein.
fixes #32633 .
Built from https://develop.svn.wordpress.org/trunk@32745
git-svn-id: http://core.svn.wordpress.org/trunk@32716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:03:25 +00:00
Weston Ruter
489db97ea3
Customizer: Allow sections and panels to be exported to JS.
...
Also fix param docs for `customize_dynamic_setting_class` filter, and use `require_once` for `class-wp-customize-manager.php` in bootstrap function `_wp_customize_include()`.
See #30737 , #32576 .
Built from https://develop.svn.wordpress.org/trunk@32744
git-svn-id: http://core.svn.wordpress.org/trunk@32715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 22:54:25 +00:00
Weston Ruter
40ad21b58b
Fix regressions from [32649] wrt Customizer `expanded` and `active` state changes for sections.
...
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.
See #31336 .
Built from https://develop.svn.wordpress.org/trunk@32743
git-svn-id: http://core.svn.wordpress.org/trunk@32714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 22:28:25 +00:00
Scott Taylor
c11e433858
After [32740], in `WP_Posts_List_Table::single_row()` - `$lock_holder` is checked but unused, so the call to `get_userdata()` is unnecessary.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32742
git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:48:26 +00:00
Scott Taylor
c1c7a7c14c
After [32740], correct doc block typo.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32741
git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:29:26 +00:00
Scott Taylor
3f4cadf4aa
Override `->single_row_columns()` in `WP_Posts_List_Table`.
...
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.
This list table class is now easier to subclass.
Props joehoyle, wonderboymusic.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32740
git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:18:24 +00:00
Scott Taylor
d0aa8e4a6e
In `WP_Terms_List_Table::display_rows_or_placeholder()`:
...
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32739
git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:55:25 +00:00
Scott Taylor
da4c3d0fe4
In `WP_Posts_List_Table::single_row()`:
...
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32738
git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:50:25 +00:00
Scott Taylor
4835310a18
In `WP_Media_List_Table::display_rows()`, `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32737
git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:45:25 +00:00
Scott Taylor
f88b42be94
In `WP_Comments_List_Table::column_comment()`, `$post` and `$the_comment_status` are unused, as is the `$comment_status` global.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32736
git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:39:25 +00:00
Scott Taylor
55b3ec92f4
Fix some malformed doc blocks in `Custom_Image_Header`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32735
git-svn-id: http://core.svn.wordpress.org/trunk@32706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:35:26 +00:00
Scott Taylor
ab66fc95bc
Fix some malformed doc blocks in `Custom_Background`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32734
git-svn-id: http://core.svn.wordpress.org/trunk@32705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:25:25 +00:00
Scott Taylor
f888767c73
`$status` shouldn't be loosely compared to `true` in `wp_xmlrpc_server::wp_deleteComment()`.
...
`$initial` shouldn't be loosely compared to `true` in `get_calendar()`.
`current_user_can()` shouldn't be loosely compared to `false` in `kses_init()`
`$get_all` shouldn't be loosely compared to `true` in `get_blog_details()`.
`is_array()` and `in_array()` shouldn't be loosely compared in `wpmu_validate_user_signup()`.
`$result` should by strictly compared in `check_ajax_referer()`.
`wp_verify_nonce()` should by strictly compared in `_show_post_preview()`.
`is_user_logged_in()` should not be loosly compared against `false` in `wp-signup.php`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32733
git-svn-id: http://core.svn.wordpress.org/trunk@32704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:48:26 +00:00
Scott Taylor
740b92853d
`WP_Customize_Setting::is_current_blog_previewed()` should only return `false`, not `false` or `void`. The one invocation of the method only loosely checks the return value.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32732
git-svn-id: http://core.svn.wordpress.org/trunk@32703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:29:26 +00:00
Scott Taylor
3b1e434c3b
Add the proper access modifier to `_init_caps()` in `WP_User`. Add `__call()` for BC.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32731
git-svn-id: http://core.svn.wordpress.org/trunk@32702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:26:25 +00:00
Scott Taylor
d2a00338f6
Don't loosely compare functions that return `bool` against a literal `bool`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32730
git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:19:27 +00:00
Scott Taylor
107d5b088d
`page_template` should be annotated as `@property`, not `@property-read` in `WP_Post`. The property is set on an instance in `wp_insert_post()`
...
Props morganestes.
Fixes #32515 .
Built from https://develop.svn.wordpress.org/trunk@32729
git-svn-id: http://core.svn.wordpress.org/trunk@32700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:01:24 +00:00
Scott Taylor
05682bdaa8
After [32596] and [32597], ensure that `wp_scripts|styles()` is called to ensure an instance is created of `WP_Scripts|Styles()` before calling `->do_items()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32728
git-svn-id: http://core.svn.wordpress.org/trunk@32699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 16:54:24 +00:00
Boone Gorges
2459cbd20f
Introduce `class` argument to `wp_dropdown_pages()`.
...
This new argument allows devs to specify the 'class' attribute of the select
element.
Props ramiy, voldemortensen.
Fixes #30082 .
Built from https://develop.svn.wordpress.org/trunk@32727
git-svn-id: http://core.svn.wordpress.org/trunk@32698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 13:05:27 +00:00
Dion Hulse
a676eda395
Update Akismet external to 3.1.2 in trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@32697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 08:39:02 +00:00