Scott Taylor
18827ed337
In `wp_ajax_hidden_columns()`, don't `explode()` on an empty string.
...
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.
This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.
Props afercia, wonderboymusic.
Fixes #32466 .
Built from https://develop.svn.wordpress.org/trunk@32751
git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
Dominik Schilling
fe31ed1e5f
Nav menu: Allow the sortable items selector in `wpNavMenu` to be overridden.
...
props adamsilverstein.
fixes #32633 .
Built from https://develop.svn.wordpress.org/trunk@32745
git-svn-id: http://core.svn.wordpress.org/trunk@32716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:03:25 +00:00
Weston Ruter
40ad21b58b
Fix regressions from [32649] wrt Customizer `expanded` and `active` state changes for sections.
...
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.
See #31336 .
Built from https://develop.svn.wordpress.org/trunk@32743
git-svn-id: http://core.svn.wordpress.org/trunk@32714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 22:28:25 +00:00
Helen Hou-Sandí
c87224eaf6
List tables: Use a class instead of inline styles for hidden columns.
...
fixes #32608 .
Built from https://develop.svn.wordpress.org/trunk@32724
git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
Konstantin Obenland
bafb008be1
When inline editing a post, reset password field to be editable by default.
...
The Quick Edit form is cloned and then populated with post-specific data. If the
previous post was private, the password field would continue to be disabled for
the next post.
Props afercia.
Fixes #32259 .
Built from https://develop.svn.wordpress.org/trunk@32716
git-svn-id: http://core.svn.wordpress.org/trunk@32686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:02:27 +00:00
Helen Hou-Sandí
9d0ab29bc4
Nav menus: Provide visual feedback when attempting to add an empty custom link.
...
props pragunbhutani for the initial patch.
fixes #18517 .
Built from https://develop.svn.wordpress.org/trunk@32690
git-svn-id: http://core.svn.wordpress.org/trunk@32660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:31:26 +00:00
John Blackbourn
acec5066f6
Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets.
...
Props jkudish, MikeHansenMe.
Fixes #20791
Built from https://develop.svn.wordpress.org/trunk@32689
git-svn-id: http://core.svn.wordpress.org/trunk@32659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 22:59:25 +00:00
Dominik Schilling
974ca19e36
Customizer: Improve JS templates for Panels and Sections added in [32658].
...
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.
Includes QUnit tests.
Props celloexpressions, westonruter, ocean90.
Fixes #30737 .
Built from https://develop.svn.wordpress.org/trunk@32681
git-svn-id: http://core.svn.wordpress.org/trunk@32651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 22:47:25 +00:00
Andrew Ozz
02f5020d52
Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
...
Fixes #31655 .
Built from https://develop.svn.wordpress.org/trunk@32680
git-svn-id: http://core.svn.wordpress.org/trunk@32650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 19:02:25 +00:00
Andrew Ozz
b3d04247b7
Editor:
...
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949 .
Built from https://develop.svn.wordpress.org/trunk@32677
git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
Sergey Biryukov
ecf0bcc9fc
Revert a part of [32673] that caused a fatal error with `SCRIPT_DEBUG` disabled.
...
see #19257 .
Built from https://develop.svn.wordpress.org/trunk@32676
git-svn-id: http://core.svn.wordpress.org/trunk@32646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 04:14:25 +00:00
John Blackbourn
02192cb53f
Introduce `featured_image`, `set_featured_image`, `remove_featured_image`, and `use_featured_image` post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
...
Props johnbillion, mordauk, valendesigns.
Fixes #19257 .
Built from https://develop.svn.wordpress.org/trunk@32673
git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
Weston Ruter
98b03d376e
Add JS templates for Customizer Panels and Sections.
...
This extends the approach taken for Customizer Controls in #29572 .
Props celloexpressions, westonruter, ocean90.
See #30737 .
Built from https://develop.svn.wordpress.org/trunk@32658
git-svn-id: http://core.svn.wordpress.org/trunk@32628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-30 00:03:30 +00:00
Dominik Schilling
fccc19b510
Customizer: Replace accordion behavior of sections with a slide-in navigation.
...
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.
props valendesigns, celloexpressions.
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@32649
git-svn-id: http://core.svn.wordpress.org/trunk@32619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 13:57:26 +00:00
Helen Hou-Sandí
fbb83441cb
After [32644], sanity for a pile of selectors.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32645
git-svn-id: http://core.svn.wordpress.org/trunk@32615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 03:00:26 +00:00
Andrew Ozz
8cbfdfa51b
Fix dragging to the bottom of the screen on the Dashboard.
...
Props eltobiano. See #32094 .
Built from https://develop.svn.wordpress.org/trunk@32505
git-svn-id: http://core.svn.wordpress.org/trunk@32475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 23:50:28 +00:00
Andrew Ozz
fe427017a5
Fix comments postbox:
...
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349 .
Built from https://develop.svn.wordpress.org/trunk@32495
git-svn-id: http://core.svn.wordpress.org/trunk@32465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 01:22:25 +00:00
Andrew Ozz
999ae33a2e
Widgets:
...
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32480
git-svn-id: http://core.svn.wordpress.org/trunk@32450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 00:32:31 +00:00
Andrew Ozz
a5cee54aea
Emoji: rename the exclude class to wp-exclude-emoji.
...
Props Clorith. See #32197 .
Built from https://develop.svn.wordpress.org/trunk@32337
git-svn-id: http://core.svn.wordpress.org/trunk@32308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 00:05:28 +00:00
Andrew Ozz
8eb93bc838
Emoji: add an exclude class to wp-emoji checked when monitoring for changes with mutationObserver. Use it for the hidden div used for resizing the Text editor.
...
See #32197 .
Built from https://develop.svn.wordpress.org/trunk@32336
git-svn-id: http://core.svn.wordpress.org/trunk@32307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 20:18:26 +00:00
Dominik Schilling
aea00880f1
Don't try to focus disabled input fields in the request filesystem credentials form.
...
fixes #32064 .
Built from https://develop.svn.wordpress.org/trunk@32267
git-svn-id: http://core.svn.wordpress.org/trunk@32238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:57:26 +00:00
Helen Hou-Sandí
f861754016
Customizer: Better experience for widget filtering in desktop and iOS Safari.
...
Previously, the search field did not appear at all in desktop Safari, and the auto-focus keyboard fly-up in iOS rendered widget adding frustrating at best.
props dsmart, ocean90.
fixes #31987 .
Built from https://develop.svn.wordpress.org/trunk@32243
git-svn-id: http://core.svn.wordpress.org/trunk@32214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:15:26 +00:00
Gary Pendergast
e3f1f8fed1
Ensure post titles are correctly escaped on the Dashboard.
...
Props helen, ocean90, dd32, pento.
Built from https://develop.svn.wordpress.org/trunk@32175
git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
Aaron Jorbin
ee9adc354a
Move wp-plugin-update-success event to after lock is released
...
Fixes #31978
See #31819
Props DavidAnderson
Built from https://develop.svn.wordpress.org/trunk@32133
git-svn-id: http://core.svn.wordpress.org/trunk@32112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 14:37:27 +00:00
Aaron Jorbin
a07e9e127f
Use named function instead of anonymous function
...
The named function is testable and replaceable.
Fixes #31964
Props DavidAnderson, adamsilverstein, jorbin
Built from https://develop.svn.wordpress.org/trunk@32126
git-svn-id: http://core.svn.wordpress.org/trunk@32105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 16:42:26 +00:00
Dominik Schilling
7b24017cdb
Customizer Theme Switcher: Don't re-render a theme control if it has already been rendered.
...
Move initialization of `$customizeSidebar` to `api.ThemesSection.initialize()` to prevent cases where the result can be undefined.
props westonruter, ocean90.
fixes #31793 .
Built from https://develop.svn.wordpress.org/trunk@32119
git-svn-id: http://core.svn.wordpress.org/trunk@32098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-13 22:10:29 +00:00
Andrew Ozz
ad475b3c69
Press This: check the bookmarklet version and add the update notice from PHP.
...
Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32106
git-svn-id: http://core.svn.wordpress.org/trunk@32085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-10 21:08:29 +00:00
Andrew Ozz
923ca312e4
Press This:
...
- Fix focusing the Standard Editor link after saving draft, if the user has not focused another element.
- Reset the Save Draft button on node change in the editor.
See #31923 .
Built from https://develop.svn.wordpress.org/trunk@32098
git-svn-id: http://core.svn.wordpress.org/trunk@32077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 19:07:28 +00:00
Andrew Ozz
33a0022773
Press This:
...
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923 .
Built from https://develop.svn.wordpress.org/trunk@32092
git-svn-id: http://core.svn.wordpress.org/trunk@32071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:14:28 +00:00
Dominik Schilling
d43d1503f7
Customize Headers: Improve handling of the initial header model.
...
Headers are currently keyed by the basename of the image, see #31786 . When two images have the same key only one image will be listed and the current image can be empty in the header control.
To prevent this we now fall back to the raw current header image if the image isn't in `_wpCustomizeHeader.uploads`.
props sirbrillig.
fixes #31742 .
Built from https://develop.svn.wordpress.org/trunk@32091
git-svn-id: http://core.svn.wordpress.org/trunk@32070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 22:28:27 +00:00
Dominik Schilling
755d44736a
Customizer Theme Switcher: Lazy load theme screenshots.
...
props westonruter, ocean90.
fixes #31793 .
Built from https://develop.svn.wordpress.org/trunk@32088
git-svn-id: http://core.svn.wordpress.org/trunk@32067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 20:52:29 +00:00
Dominik Schilling
15f24a7730
Customizer Theme Switcher: Fix tabbing order if section is open.
...
see #31289 .
Built from https://develop.svn.wordpress.org/trunk@32087
git-svn-id: http://core.svn.wordpress.org/trunk@32066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 19:03:25 +00:00
Dominik Schilling
79eee23a29
Customizer Theme Switcher: Don't deactivate section on empty search results.
...
props westonruter.
fixes #31889 .
Built from https://develop.svn.wordpress.org/trunk@32083
git-svn-id: http://core.svn.wordpress.org/trunk@32062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:53:28 +00:00
Aaron Jorbin
0402c0b877
Disable shiny updates from modal based on parent window
...
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal. Instead, let's use the parent window's location.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32082
git-svn-id: http://core.svn.wordpress.org/trunk@32061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:38:27 +00:00
Aaron Jorbin
7aeea37d47
Fix logic for details based shiny updates.
...
This fixes two problems. TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward. Also fixes logic error.
See #31739
Built from https://develop.svn.wordpress.org/trunk@32080
git-svn-id: http://core.svn.wordpress.org/trunk@32059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:27:26 +00:00
Aaron Jorbin
55cebbeeb6
Disable modal initiated shiny updates on wp-admin/update-core.php
...
We don't have links to update a single plugin on wp-admin/update-core.php so we can't initiate a shiny update there.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32067
git-svn-id: http://core.svn.wordpress.org/trunk@32046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 04:48:26 +00:00
Aaron Jorbin
1facff5425
Use dashes instead of dots as separator for jQuery events in shiny updates
...
`.` is used for namespaces, so better to use dashes.
see #31819
props iseulde
Built from https://develop.svn.wordpress.org/trunk@32063
git-svn-id: http://core.svn.wordpress.org/trunk@32042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:12:26 +00:00
Aaron Jorbin
99d6c67148
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32062
git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
Aaron Jorbin
1985d00886
Trigger events upon the completion of a shiny update
...
Plugins need to be able to do actions when a shiny update completes. While we don't have complete javascript actions and filters, we do have jQuery events that we can fire to assist plugin authors.
See #31819
Built from https://develop.svn.wordpress.org/trunk@32061
git-svn-id: http://core.svn.wordpress.org/trunk@32040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 02:32:26 +00:00
Dominik Schilling
6d2c70aa0d
Customizer: Refresh nonces when a session expires and the user logs in again.
...
This was broken since 4.0 and the introduction of user session tokens. The nonces are now tied to session tokens as opposed to user IDs, and thus they change with each re-login.
Custom nonces can be added through the `customize_refresh_nonces` filter. On a successful refresh request the JavaScript API will trigger a `nonce-refresh` event. See widget's update nonce as an example.
props westonruter for initial patch.
fixes #31294 .
Built from https://develop.svn.wordpress.org/trunk@32054
git-svn-id: http://core.svn.wordpress.org/trunk@32033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 15:10:27 +00:00
Aaron Jorbin
dd5b92a2fe
Remove Shiny Bulk Updates
...
Bulk updates don't need to be ajaxified so let's revert.
See #31770 , #29820 ,
Built from https://develop.svn.wordpress.org/trunk@32053
git-svn-id: http://core.svn.wordpress.org/trunk@32032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:21:26 +00:00
Aaron Jorbin
2c42b8f0b2
Conditionally add AYS to leaving shiny updates
...
When a shiny update is happening or pending, we should make sure users don't accidentally leave the page. This simple notification should help prevent users from accidentally not updating when they want to update.
See #31769
Props ericlewis and adamsilverstein for initial patch
Built from https://develop.svn.wordpress.org/trunk@32052
git-svn-id: http://core.svn.wordpress.org/trunk@32031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:00:26 +00:00
Helen Hou-Sandí
bfda508c18
Update more instances of default admin blues and grays.
...
props hugobaeta.
fixes #31234 .
Built from https://develop.svn.wordpress.org/trunk@32051
git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Dominik Schilling
4f3fb2315d
Customize Widgets: Improve sync logic for select[multiple] inputs.
...
The current logic doesn't account for the special case of `select[multiple]` inputs which lack a single value to synchronize: The value to synchronize is an array of zero or more values.
This change replaces `_getInputStatePropertyName()` with `_getInputState()`, which returns the state for an input depending on its type, and `_setInputState()`, which updates an input's state based on its type.
props westonruter.
fixes #31885 .
Built from https://develop.svn.wordpress.org/trunk@32012
git-svn-id: http://core.svn.wordpress.org/trunk@31991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:34:26 +00:00
Dominik Schilling
59c586e5ad
Customizer Theme Switcher: Remove "Add New" reference from customize-controls.js.
...
see #31837 .
Built from https://develop.svn.wordpress.org/trunk@32004
git-svn-id: http://core.svn.wordpress.org/trunk@31983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:14:26 +00:00
Helen Hou-Sandí
3ac1a19529
Spinners: Toggle a class instead of show/hide.
...
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.
props cdog, MikeHansenMe, valendesigns.
fixes #22839 . see #31875 , #30725 .
Built from https://develop.svn.wordpress.org/trunk@31996
git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Andrew Ozz
52db6356a1
Themes screen: remove extra debounce when searching.
...
Props evansolomon. Fixes #31812 .
Built from https://develop.svn.wordpress.org/trunk@31995
git-svn-id: http://core.svn.wordpress.org/trunk@31974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:37:32 +00:00
Andrew Ozz
2d36b8ff4a
Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
...
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600 .
Built from https://develop.svn.wordpress.org/trunk@31994
git-svn-id: http://core.svn.wordpress.org/trunk@31973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:32:28 +00:00
Andrew Ozz
05a549723c
Press This:
...
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875 .
Built from https://develop.svn.wordpress.org/trunk@31992
git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:34:26 +00:00
Andrew Ozz
b98ba09e5b
Press This: prevent pasting of HTML in the title H2. Insert the clipboard text instead.
...
Fixes #31768 .
Built from https://develop.svn.wordpress.org/trunk@31987
git-svn-id: http://core.svn.wordpress.org/trunk@31966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 21:11:30 +00:00