WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
32,578 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

19807 Commits

Author SHA1 Message Date
Scott Taylor e7c2544a89 Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests. 
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.

Built from https://develop.svn.wordpress.org/trunk@35100


git-svn-id: http://core.svn.wordpress.org/trunk@35065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:13:24 +00:00
Scott Taylor a31d7e37dc Color Picker: when opening and closing, toggle a `wp-picker-active` class on the wrapper. 
Props norcross.
Fixes #29471.

Built from https://develop.svn.wordpress.org/trunk@35099


git-svn-id: http://core.svn.wordpress.org/trunk@35064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:08:25 +00:00
Drew Jaynes 48811702cd Feeds: Simplify logic for checking if the `do_feed_{$feed}` action is hooked to any callbacks. 
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.

Built from https://develop.svn.wordpress.org/trunk@35098


git-svn-id: http://core.svn.wordpress.org/trunk@35063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:07:25 +00:00
Drew Jaynes b234b5d896 Feeds: Adjust the `do_feed_{$feed}` hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that. 
Props johnbillion.
Fixes #34264.

Built from https://develop.svn.wordpress.org/trunk@35097


git-svn-id: http://core.svn.wordpress.org/trunk@35062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:03:25 +00:00
Sergey Biryukov b30dcc3f62 Format the number of comments in `wp-includes/embed-template.php` for the locale. 
Props johnbillion.
Fixes #34276.
Built from https://develop.svn.wordpress.org/trunk@35096


git-svn-id: http://core.svn.wordpress.org/trunk@35061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:02:25 +00:00
Scott Taylor 8941648ead XML-RPC: Add a filter, `xmlrpc_memory_limit`, to allow the value of `$xmlrpc_memory_limit` to be increased. 
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35095


git-svn-id: http://core.svn.wordpress.org/trunk@35060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:01:24 +00:00
Drew Jaynes bcc7f8d079 Plugins: Introduce the `delete_plugin` transactional hook, which fires immediately after a plugin deletion attempt occurs. 
Props Veraxus for the initial patch.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35094


git-svn-id: http://core.svn.wordpress.org/trunk@35059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 00:57:25 +00:00
Drew Jaynes ad6a1303dc Login: Pass the username and `WP_User` object to the `retrieve_password_title` filter. 
Adding these parameters creates parity with the `retrieve_password_message` filter, used for modifying the message body of the same password reset email.

Props sudar.
Fixes #34252.

Built from https://develop.svn.wordpress.org/trunk@35093


git-svn-id: http://core.svn.wordpress.org/trunk@35058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 00:51:24 +00:00
Sergey Biryukov 7ef095171a In `number_format_i18n()`, check if `$wp_locale` is set before using it. 
Props pauldewouters.
Fixes #31553.
Built from https://develop.svn.wordpress.org/trunk@35092


git-svn-id: http://core.svn.wordpress.org/trunk@35057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 00:30:24 +00:00
Sergey Biryukov e6987f3c31 Correct the `post_date` format in `WP_Date_Query` tests. 
It should be `'Y-m-d H:i:s'` in order to match the regex in `get_gmt_from_date()` if `'timezone_string'` option is not set.

Props pbearne.
Fixes #34277.
Built from https://develop.svn.wordpress.org/trunk@35091


git-svn-id: http://core.svn.wordpress.org/trunk@35056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 23:40:24 +00:00
John Blackbourn 00388a1dbf Add missing `@since` params and update the docs for `site_icon_url()` and `has_site_icon()`. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@35090


git-svn-id: http://core.svn.wordpress.org/trunk@35055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 23:28:24 +00:00
John Blackbourn 76b77ff4d1 Remove another unnecessary `function_exists()` call. 
See [35087]
See #32522

Built from https://develop.svn.wordpress.org/trunk@35089


git-svn-id: http://core.svn.wordpress.org/trunk@35054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 23:20:24 +00:00
Drew Jaynes cffce78d35 Version bump. 
Built from https://develop.svn.wordpress.org/trunk@35088


git-svn-id: http://core.svn.wordpress.org/trunk@35053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:59:25 +00:00
John Blackbourn 993d5c1c4b Remove an unnecessary `function_exists()` call which was included in the oEmbed feature plugin for compatibility with WordPress < 4.3. 
See #32522

Built from https://develop.svn.wordpress.org/trunk@35087


git-svn-id: http://core.svn.wordpress.org/trunk@35052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:54:24 +00:00
John Blackbourn 1a04fde012 Correct two escaping functions used in `wp-includes/embed-template.php`. 
See #32522

Built from https://develop.svn.wordpress.org/trunk@35086


git-svn-id: http://core.svn.wordpress.org/trunk@35051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:52:24 +00:00
John Blackbourn 7cb0dcc9a6 Add missing `@since` docs for the filters in `wp-includes/embed-template.php` 
See #32522, #32246

Built from https://develop.svn.wordpress.org/trunk@35085


git-svn-id: http://core.svn.wordpress.org/trunk@35050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:51:24 +00:00
John Blackbourn 2dd5ad6327 Correct the `@since` doc for `WP_Query::is_embed()`. 
See #32522

Built from https://develop.svn.wordpress.org/trunk@35084


git-svn-id: http://core.svn.wordpress.org/trunk@35049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:13:25 +00:00
Scott Taylor 75426585fb oEmbed: add fallback icons (not used yet) for older browsers. 
Props melchoyce.
See #34204.

Built from https://develop.svn.wordpress.org/trunk@35083


git-svn-id: http://core.svn.wordpress.org/trunk@35048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 21:17:25 +00:00
John Blackbourn a2609c13fa Add `$transient` as a parameter to the `set_transient_{transient}` action. 
Props SergeyBiryukov
Fixes #34269

Built from https://develop.svn.wordpress.org/trunk@35082


git-svn-id: http://core.svn.wordpress.org/trunk@35047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 21:02:25 +00:00
Scott Taylor affe1ab5ad Media: avoid "divide by zero" in `wp_get_attachment_image_srcset_array()`. 
Fixes #34238.

Built from https://develop.svn.wordpress.org/trunk@35081


git-svn-id: http://core.svn.wordpress.org/trunk@35046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 21:00:26 +00:00
Drew Jaynes 8b49acdd0e Docs: Specify the default image size in the `$size` parameter description for the `image_send_to_editor` hook. 
See #34257. See #32246. See [35058].

Built from https://develop.svn.wordpress.org/trunk@35080


git-svn-id: http://core.svn.wordpress.org/trunk@35045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:18:24 +00:00
Drew Jaynes f7e92fc346 Docs: Normalize spacing in the DocBlock for `get_image_send_to_editor()` following [35056]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35079


git-svn-id: http://core.svn.wordpress.org/trunk@35044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:16:24 +00:00
Drew Jaynes 2d677edb1f Docs: The `$size` parameter for the `get_image_tag` hook also accepts an array. 
See #34257. See [35038].

Built from https://develop.svn.wordpress.org/trunk@35078


git-svn-id: http://core.svn.wordpress.org/trunk@35043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:11:24 +00:00
Drew Jaynes 36ef44735d Docs: The `$size` parameter for the `get_image_tag_class` hook also accepts an array. 
See #34257. See [35037].

Built from https://develop.svn.wordpress.org/trunk@35077


git-svn-id: http://core.svn.wordpress.org/trunk@35042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:09:25 +00:00
Drew Jaynes bc631019d0 Docs: Adjust documentation for the `$size` parameter in `the_post_thumbnail_url()` to clarify the required order of width and height values when passing an array. 
Fixes #34257. Whew!

Built from https://develop.svn.wordpress.org/trunk@35076


git-svn-id: http://core.svn.wordpress.org/trunk@35041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:00:26 +00:00
Drew Jaynes 5e67b71443 Docs: The `post_thumbnail_size` hook can also accept an array (already supported). 
See #34257. See [35069].

Built from https://develop.svn.wordpress.org/trunk@35075


git-svn-id: http://core.svn.wordpress.org/trunk@35040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:57:24 +00:00
Drew Jaynes 03a39f75b3 Docs: The `$size` parameters in the `begin_fetch_post_thumbnail_html` and `end_fetch_post_thumbnail_html` hooks can also accept an array (already supported). 
See #34257. See #32246. See [35070] and [35071].

Built from https://develop.svn.wordpress.org/trunk@35074


git-svn-id: http://core.svn.wordpress.org/trunk@35039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:56:24 +00:00
Drew Jaynes dcb18faab8 Docs: Normalize spacing in the `post_thumbnail_html` hook doc following [35072]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35073


git-svn-id: http://core.svn.wordpress.org/trunk@35038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:53:24 +00:00
Drew Jaynes 476655b0e0 Docs: Adjust documentation for the `$size` parameter in the `post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35072


git-svn-id: http://core.svn.wordpress.org/trunk@35037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:52:24 +00:00
Drew Jaynes 1564eb43b4 Docs: Adjust documentation for the `$size` parameter in the `end_fetch_post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35071


git-svn-id: http://core.svn.wordpress.org/trunk@35036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:50:25 +00:00
Drew Jaynes 91d5909507 Docs: Adjust documentation for the `$size` parameter in the `begin_fetch_post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35070


git-svn-id: http://core.svn.wordpress.org/trunk@35035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:49:24 +00:00
Drew Jaynes fe0d59a061 Docs: Adjust documentation for the `$size` parameter in the `post_thumbnail_size` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35069


git-svn-id: http://core.svn.wordpress.org/trunk@35034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:48:25 +00:00
Drew Jaynes 2091ff358d Docs: Adjust documentation for the `$size` parameter in `get_the_post_thumbnail()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35068


git-svn-id: http://core.svn.wordpress.org/trunk@35033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:47:25 +00:00
Drew Jaynes 2519b20959 Docs: Adjust documentation for the `$size` parameter in `the_post_thumbnail()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35067


git-svn-id: http://core.svn.wordpress.org/trunk@35032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:46:24 +00:00
Drew Jaynes 8544d69d35 Docs: Normalize spacing in the `wp_get_attachment_link` hook doc following [35065]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35066


git-svn-id: http://core.svn.wordpress.org/trunk@35031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:44:24 +00:00
Drew Jaynes ad628c7165 Docs: Adjust documentation for the `$size` parameter in the `wp_get_attachment_link` hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35065


git-svn-id: http://core.svn.wordpress.org/trunk@35030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:42:23 +00:00
Drew Jaynes 61115eac58 Docs: Improve documentation for `get_site_icon_url()`, introduced in [32994]. 
Adds a missing `@since` version, fixes optional parameter syntax, adds default values, and fixes the return description.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35064


git-svn-id: http://core.svn.wordpress.org/trunk@35029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:38:24 +00:00
Drew Jaynes b1b3fc5deb Docs: Re-clarify the `$sizes[ $size ]` section of the hash notations for `WP_Image_Editor_GD::multi_resize()` and `WP_Image_Editor_Imagick::multi_resize()` as not fully-optional. 
The `$width` value is optional if `$height` is specified, and vice versa. The `$crop` value is always optional and defaults to false.

Props dh-shredder.
See #32246. See [35061] and [35062].

Built from https://develop.svn.wordpress.org/trunk@35063


git-svn-id: http://core.svn.wordpress.org/trunk@35028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:34:23 +00:00
Drew Jaynes 041e3dd285 Docs: Fix hash notation syntax for the `$sizes[ $size ]` section in the DocBlock for `WP_Image_Editor_Imagick::multi_resize()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35062


git-svn-id: http://core.svn.wordpress.org/trunk@35027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:27:24 +00:00
Drew Jaynes 243f66836f Docs: Fix hash notation syntax for the `$sizes[ $size ]` section in the DocBlock for `WP_Image_Editor_GD::multi_resize()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35061


git-svn-id: http://core.svn.wordpress.org/trunk@35026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:26:24 +00:00
Drew Jaynes ee544e44d5 Docs: Adjust documentation for the `$size` parameter in the `admin_post_thumbnail_size` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257. See #28512.

Built from https://develop.svn.wordpress.org/trunk@35060


git-svn-id: http://core.svn.wordpress.org/trunk@35025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:22:25 +00:00
Drew Jaynes 9f5d887934 Docs: Normalize spacing in the `image_send_to_editor` hook doc following [35058]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35059


git-svn-id: http://core.svn.wordpress.org/trunk@35024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:19:23 +00:00
Drew Jaynes c12f0caefd Docs: Adjust documentation for the `$size` parameter in the `image_send_to_editor` hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35058


git-svn-id: http://core.svn.wordpress.org/trunk@35023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:17:24 +00:00
Drew Jaynes 4534f13149 Docs: Fix the syntax for marking parameters optional and add defaults in the DocBlock for `wp_get_attachment_link()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35057


git-svn-id: http://core.svn.wordpress.org/trunk@35022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:15:24 +00:00
Drew Jaynes 4aea111b29 Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for `get_image_send_to_editor()`. 
Also fixes the return description, and adds the `$size` default value, missed in [35055].

See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35056


git-svn-id: http://core.svn.wordpress.org/trunk@35021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:11:24 +00:00
Drew Jaynes 16738bf325 Docs: Adjust documentation for the `$size` parameter in `get_image_send_to_editor()` to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35055


git-svn-id: http://core.svn.wordpress.org/trunk@35020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:08:25 +00:00
Drew Jaynes d4fe129e1a Docs: Adjust the order of 'width' and 'height' (for consistency) for the `$crop` parameter documentation in `image_make_intermediate_size()`. 
Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35054


git-svn-id: http://core.svn.wordpress.org/trunk@35019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:06:24 +00:00
Drew Jaynes 8b26e5debc Docs: Adjust the order of 'width' and 'height' (for consistency) for the `$crop` parameter documentation in `image_resize_dimensions()`. 
Also similarly adjusts the `$crop` parameter description in the corresponding `image_resize_dimensions` hook doc.

Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35053


git-svn-id: http://core.svn.wordpress.org/trunk@35018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:02:24 +00:00
Drew Jaynes e0529ebdb5 Docs: Adjust the order of 'width' and 'height' (for consistency) for the `$crop` parameter documentation in `set_post_thumbnail_size()`. 
Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35052


git-svn-id: http://core.svn.wordpress.org/trunk@35017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:00:26 +00:00
Drew Jaynes 771248a1f3 Docs: Adjust the order of 'width' and 'height' (for consistency) for the `$crop` parameter documentation in `add_image_size()`. 
Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35051


git-svn-id: http://core.svn.wordpress.org/trunk@35016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:59:25 +00:00
Drew Jaynes 69a3c2d8d7 Docs: Adjust documentation for the `$size` parameter in `wp_get_attachment_link()` to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35050


git-svn-id: http://core.svn.wordpress.org/trunk@35015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:56:24 +00:00
Drew Jaynes d0a392a34c Docs: Adjust documentation for the `$size` parameter in `adjacent_image_link()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35049


git-svn-id: http://core.svn.wordpress.org/trunk@35014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:53:25 +00:00
Drew Jaynes 81f67bae13 Docs: Adjust documentation for the `$size` parameter in `next_image_link()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35048


git-svn-id: http://core.svn.wordpress.org/trunk@35013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:50:24 +00:00
Drew Jaynes 141b096f6d Docs: Adjust documentation for the `$size` parameter in `previous_image_link()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35047


git-svn-id: http://core.svn.wordpress.org/trunk@35012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:48:25 +00:00
Drew Jaynes 1571907571 Docs: Normalize spacing in the `$attr` hash notation for `gallery_shortcode()` following [35045]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35046


git-svn-id: http://core.svn.wordpress.org/trunk@35011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:46:24 +00:00
Drew Jaynes e4f9e334ea Docs: Adjust documentation for the `$size` argument in `gallery_shortcode` to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the argument documentation.

Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35045


git-svn-id: http://core.svn.wordpress.org/trunk@35010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:43:25 +00:00
Drew Jaynes 9d5d27c26d Docs: Adjust documentation for the `$size` parameter in `wp_get_attachment_image_url()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35044


git-svn-id: http://core.svn.wordpress.org/trunk@35009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:39:25 +00:00
Drew Jaynes 987fe676a9 Docs: Adjust documentation for the `$size` parameter in the `wp_get_attachment_image_attributes` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35043


git-svn-id: http://core.svn.wordpress.org/trunk@35008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:38:24 +00:00
Drew Jaynes 5631df0151 Docs: Adjust documentation for the `$size` parameter in `wp_get_attachment_image()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35042


git-svn-id: http://core.svn.wordpress.org/trunk@35007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:36:24 +00:00
Drew Jaynes c02b132fcc Docs: Adjust documentation for the `$size` parameter in the `wp_get_attachment_image_src` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35041


git-svn-id: http://core.svn.wordpress.org/trunk@35006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:34:24 +00:00
Drew Jaynes 8f3f5dba35 Docs: Adjust documentation for the `$size` parameter in `wp_get_attachment_image_src()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35040


git-svn-id: http://core.svn.wordpress.org/trunk@35005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:31:24 +00:00
Drew Jaynes 50fd2488f4 Docs: Adjust documentation for the `$size` parameter in `image_get_intermediate_size()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35039


git-svn-id: http://core.svn.wordpress.org/trunk@35004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:29:24 +00:00
Drew Jaynes 5a0eaa17de Docs: Adjust documentation for the `$size` parameter in the `get_image_tag` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35038


git-svn-id: http://core.svn.wordpress.org/trunk@35003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:27:25 +00:00
Drew Jaynes 698b5f6880 Docs: Adjust documentation for the `$size` parameter in the `get_image_tag_class` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35037


git-svn-id: http://core.svn.wordpress.org/trunk@35002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:26:25 +00:00
Drew Jaynes 71932de1f5 Docs: Adjust documentation for the `$size` parameter in `get_image_tag()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35036


git-svn-id: http://core.svn.wordpress.org/trunk@35001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:21:25 +00:00
Drew Jaynes 3f8aaf753a Docs: Adjust documentation for the `$size` parameter in the `image_downside` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35035


git-svn-id: http://core.svn.wordpress.org/trunk@35000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:20:23 +00:00
Drew Jaynes 45174a8996 Docs: Adjust documentation for the `$size` parameter in `image_downsize()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35034


git-svn-id: http://core.svn.wordpress.org/trunk@34999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:18:24 +00:00
Drew Jaynes 7c25ad0613 Docs: Adjust documentation for the `$size` parameter in `image_constrain_size_for_editor()` to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35033


git-svn-id: http://core.svn.wordpress.org/trunk@34998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:16:24 +00:00
Boone Gorges 499d1b74ba Don't cache `WP_Term` objects in `wp_get_object_cache()`. 
The data stored in the cache should be raw database query results, not
`WP_Term` objects (which may be modified by plugins, and may contain additional
properties that shouldn't be cached).

If term relationships caches were handled in `wp_get_object_terms()` - where
a database query takes place - it would be straightforward to cache raw data.
See #34239. Since, in fact, `get_the_terms()` caches the value it gets from
`wp_get_object_terms()`, we need a technique that allows us to get raw data
from a `WP_Term` object. Mirroring `WP_User`, we introduce a `data` property
on term objects, which `get_the_terms()` uses to fetch cacheable term info.

Fixes #34262.
Built from https://develop.svn.wordpress.org/trunk@35032


git-svn-id: http://core.svn.wordpress.org/trunk@34997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:13:48 +00:00
Boone Gorges 6912d6fe64 Be stricter about sanitizing values coming out of `WP_Term`. 
Data passed into `get_instance()` should be run through `sanitize_term()`
before being used.

See #34262.
Built from https://develop.svn.wordpress.org/trunk@35031


git-svn-id: http://core.svn.wordpress.org/trunk@34996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:13:24 +00:00
Boone Gorges 2e4877d80c Fix incorrect setup in 'tag' query var test. 
The test, introduced in [33724], was intended to demonstrate the behavior of
`example.com?tag=foo` routing. But an error in the test setup meant that a
URL-encoded tag object was being set as the value of 'tag'. Due to a quirk in
the way that `parse_request()` parses query vars, an object value for 'tag'
would inadvertently produce correct results in certain cases. But it's not a
usage we actively support, and it's not what was meant to be tested.

See #33532, #34262.
Built from https://develop.svn.wordpress.org/trunk@35030


git-svn-id: http://core.svn.wordpress.org/trunk@34995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:04:26 +00:00
Boone Gorges 58aee33cd9 After [35028], normalize `get_term_field()` doc formatting. 
Fixes #34245.
Built from https://develop.svn.wordpress.org/trunk@35029


git-svn-id: http://core.svn.wordpress.org/trunk@34994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 04:14:48 +00:00
Boone Gorges 1a87ade436 Don't require a `$taxonomy` to be specified in `get_term_field()`. 
After [34997], the `$taxonomy` parameter of `get_term()` is optional. This
changeset brings `get_term_field()` in line with the new usage.

Adds unit tests for `get_term_field()`.

Props DrewAPicture.
See #34245.
Built from https://develop.svn.wordpress.org/trunk@35028


git-svn-id: http://core.svn.wordpress.org/trunk@34993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 04:14:24 +00:00
Drew Jaynes f60bd8d827 Docs: Wrap a couple of hook name references in inline `@see` tags in the hook docs for `custom_menu_order` and `menu_order`. 
Inline `@see` tags in the context of hooks are parsed as links to hook pages in the Code Reference.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35027


git-svn-id: http://core.svn.wordpress.org/trunk@34992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 03:39:26 +00:00
Jeremy Felt 270d3f422c MS: Reflect falsy values for `upload_space_check_disabled` in UI. 
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.

Props stephenharris.
Fixes #33986.

Built from https://develop.svn.wordpress.org/trunk@35026


git-svn-id: http://core.svn.wordpress.org/trunk@34991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 00:01:24 +00:00
Jeremy Felt 364e63b83b MS: Reject truthy, non-numeric network ids in `_network_option()`. 
A valid `$network_id` or `null`/`false` is expected as the first parameter for `_network_option()`. If something other than that is passed, we immediately return `false` rather than attempting to guess what network was intended.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@35025


git-svn-id: http://core.svn.wordpress.org/trunk@34990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 23:30:24 +00:00
Jeremy Felt 092478579a MS: Adjust `_network_option()` parameter order, `$network_id` is first. 
This better aligns with expectations and matches the structure used by `_blog_option()`. The `_site_option()` functions remain as an appropriate method for working with the current network.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@35024


git-svn-id: http://core.svn.wordpress.org/trunk@34989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 22:44:27 +00:00
Drew Jaynes 2c6e416159 Media: Remove logic for unnecessarily overloading the `$content_width` global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box. 
Updates documentation for the `$size` parameter in `admin_post_thumbnail_size` filter doc.

See #28512.

Built from https://develop.svn.wordpress.org/trunk@35023


git-svn-id: http://core.svn.wordpress.org/trunk@34988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 17:10:25 +00:00
Drew Jaynes 889a89c2a2 Media: Introduce the `admin_post_thumbnail_size` filter, which enables manipulation of the image size used to display the post thumbnail in the 'Featured Image' meta box. 
This filter has no effect on the image size used to display post thumbnails on the front-end.

Props dboulet, DrewAPicture.
Fixes #28512.

Built from https://develop.svn.wordpress.org/trunk@35022


git-svn-id: http://core.svn.wordpress.org/trunk@34987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 16:54:26 +00:00
Drew Jaynes fb2a4bf9fb Docs: Fix some syntactical issues in property DocBlocks for `WP_List_Table`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35021


git-svn-id: http://core.svn.wordpress.org/trunk@34986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 03:34:26 +00:00
Andrew Ozz 85285d1701 Fix inconsistency in src/wp-includes/js/media/views/uploader/editor.js. 
See #34251.

Built from https://develop.svn.wordpress.org/trunk@35020


git-svn-id: http://core.svn.wordpress.org/trunk@34985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 00:09:24 +00:00
Andrew Ozz 8dd2a31c38 Plupload: update to 2.1.8. Changelog: https://github.com/moxiecode/plupload/releases. 
Hide the editor uploader overlay on all drop events in the window, not only when dropping on the editor uploader element.


Fixes #34251, #22403.
Built from https://develop.svn.wordpress.org/trunk@35019


git-svn-id: http://core.svn.wordpress.org/trunk@34984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:50:25 +00:00
Sergey Biryukov 11def634f6 Customizer: `WP_Customize_Cropped_Image_Control` should extend `WP_Customize_Image_Control`, since Site Icon can only an image. 
Props paulwilde.
Fixes #34250.
Built from https://develop.svn.wordpress.org/trunk@35018


git-svn-id: http://core.svn.wordpress.org/trunk@34983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:25:24 +00:00
Jeremy Felt 3b42b801f8 MS: Handle the possibility of 0 when checking a user's upload quota. 
Upload space of 0 is now more possible via r35016 and should be respected rather than modified to a default of 10MB.

Fixes #34037.

Built from https://develop.svn.wordpress.org/trunk@35017


git-svn-id: http://core.svn.wordpress.org/trunk@34982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:17:25 +00:00
Jeremy Felt 49ce208880 MS: Allow for a `blog_upload_space` setting of 0 to restrict uploads. 
Previously, an value matching `empty()` would have been bypassed in favor of the default setting for 100MB.

Related #19538, r19639, r19652, where we saw the bug, fixed the bug, and then unfixed the bug so that it was not a surprise in a point release.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@35016


git-svn-id: http://core.svn.wordpress.org/trunk@34981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:15:26 +00:00
Andrea Fercia 6b449abadc Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy. 
Props mrahmadawais, afercia.
Fixes #33659.
Built from https://develop.svn.wordpress.org/trunk@35015


git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 16:34:25 +00:00
Scott Taylor 5fdf928bcf Admin JS: after [34977], avoid variable names conflicts with `e`. 
Props afercia.
Fixes #18590.

Built from https://develop.svn.wordpress.org/trunk@35014


git-svn-id: http://core.svn.wordpress.org/trunk@34979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:50:24 +00:00
Scott Taylor 00ade45fd1 Docs: some `@global object` vernaculars should be converted to the actual object type. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@35013


git-svn-id: http://core.svn.wordpress.org/trunk@34978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:45:25 +00:00
Scott Taylor 57c2ef2655 Users List Table: after [35011], just use `wp_roles()`, no global import. #winning 
See #22959.

Built from https://develop.svn.wordpress.org/trunk@35012


git-svn-id: http://core.svn.wordpress.org/trunk@34977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:36:26 +00:00
Scott Taylor ab2905da84 Users List Table: after [34963], remove unused code/add doc for global import. 
See #22959.

Built from https://develop.svn.wordpress.org/trunk@35011


git-svn-id: http://core.svn.wordpress.org/trunk@34976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:26:24 +00:00
Scott Taylor d021cb8bc0 WP Screen: after [34991], avoid unnecessary nesting levels and remove unused global import. 
See #33646.

Built from https://develop.svn.wordpress.org/trunk@35010


git-svn-id: http://core.svn.wordpress.org/trunk@34975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:20:24 +00:00
Andrea Fercia 6ec8174ca1 Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy. 
Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35009


git-svn-id: http://core.svn.wordpress.org/trunk@34974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:17:26 +00:00
Sergey Biryukov a5c1f545c4 Users: Remove redundant error message when password is only entered once. 
"Please enter the same password in both password fields" should cover all the scenarios.

Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101.
Built from https://develop.svn.wordpress.org/trunk@35008


git-svn-id: http://core.svn.wordpress.org/trunk@34973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 13:22:26 +00:00
Weston Ruter 1fe64b1c65 Customizer: Fix scalability performance problem for previewing multidimensional settings. 
As the number of multidimensional settings (serialized options and theme mods) increase for a given ID base (e.g. a widget of a certain type), the number of calls to the `multidimensional` methods on `WP_Customize_Setting` increase exponentially, and the time for the preview to refresh grows in time exponentially as well.

To improve performance, this change reduces the number of filters needed to preview the settings off of a multidimensional root from N to 1. This improves performance from `O(n^2)` to `O(n)`, but the linear increase is so low that the performance is essentially `O(1)` in comparison. This is achieved by introducing the concept of an "aggregated multidimensional" setting, where the root value of the multidimensional serialized setting value gets cached in a static array variable shared across all settings.

Also improves performance by only adding preview filters if there is actually a need to do so: there is no need to add a filter if there is an initial value and if there is no posted value for a given setting (if it is not dirty).

Fixes #32103.

Built from https://develop.svn.wordpress.org/trunk@35007


git-svn-id: http://core.svn.wordpress.org/trunk@34972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 09:06:25 +00:00
Sergey Biryukov ac9a85a45e Use `wp_star_rating()` on Add Themes screen: 
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible

Fixes #34080.
Built from https://develop.svn.wordpress.org/trunk@35006


git-svn-id: http://core.svn.wordpress.org/trunk@34971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:51:24 +00:00
Sergey Biryukov 24219160f1 Add `echo` parameter for `wp_star_rating()`. 
See #34080.
Built from https://develop.svn.wordpress.org/trunk@35005


git-svn-id: http://core.svn.wordpress.org/trunk@34970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:43:24 +00:00
Drew Jaynes c6bffb6264 Docs: Fix some minor formatting in the `$query_args` parameter description for the `` filter doc. 
See #8243. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35004


git-svn-id: http://core.svn.wordpress.org/trunk@34969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:39:24 +00:00
Drew Jaynes 504ff07656 Dashboard: Introduce the `dashboard_recent_drafts_query_args` filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget. 
Props iamfriendly.
Fixes #8243.

Built from https://develop.svn.wordpress.org/trunk@35003


git-svn-id: http://core.svn.wordpress.org/trunk@34968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:33:25 +00:00
Drew Jaynes 69c828b77b Template: Pass the `$post` parameter to the `the_permalink` filter. 
Props chriscct7.
Fixes #34234. See #23882.

Built from https://develop.svn.wordpress.org/trunk@35002


git-svn-id: http://core.svn.wordpress.org/trunk@34967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 05:46:24 +00:00
Drew Jaynes c2b5aeebb0 Template: Rename the `$id` parameters in `the_permalink()`, `get_the_permalink()`, and `get_permalink()` to `$post`. 
In all three cases, the functions can accept a post ID, a `WP_Post` object, or a falsey value, which defaults to the value of the global `$post`. Switching to `$post` in this context allows the parameters to better self-document and removes ambiguity in the code they are subsequently used in.

Props chriscct7 for the initial patch.
See #34234.

Built from https://develop.svn.wordpress.org/trunk@35001


git-svn-id: http://core.svn.wordpress.org/trunk@34966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 05:41:29 +00:00
Sergey Biryukov 5399881b18 Merge two database update strings for consistency. 
Props pavelevap.
Fixes #33514.
Built from https://develop.svn.wordpress.org/trunk@35000


git-svn-id: http://core.svn.wordpress.org/trunk@34965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 05:14:23 +00:00
Boone Gorges 636464857e Return `WP_Post` objects from `wp_get_object_terms()`. 
A side effect of this change is that terms stored in the cache no longer have
an `object_id` associated with them. Previously, `object_id` had always been
cached when the term cache was populated via `wp_get_object_terms()`, a
strategy that was mostly harmless but still incorrect.

See #14162.
Built from https://develop.svn.wordpress.org/trunk@34999


git-svn-id: http://core.svn.wordpress.org/trunk@34964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 03:39:26 +00:00
Boone Gorges 71429da5b4 Return `WP_Term` objects from `get_terms()`. 
Props boonebgorges, flixos90, DrewAPicture.
See #14162.
Built from https://develop.svn.wordpress.org/trunk@34998


git-svn-id: http://core.svn.wordpress.org/trunk@34963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 02:13:28 +00:00
Boone Gorges 623e467712 Introduce `WP_Term`. 
`get_term()` now returns a `WP_Term` object, instead of a `stdClass` object.
Cache support and sanitization filters for individual terms are now more
centralized. For example, `get_term_by()` is able to cast results of its query
to a `WP_Term` object by passing it through `get_term()`.

The `$taxonomy` parameter for `get_term()` is now optional, as terms ought to
be unique to a taxonomy (ie, shared terms no longer exist). In cases where
`get_term()` detects that the term matching the specified term_id is from the
wrong taxonomy, it checks to see if you've requested a shared term, and if so,
it splits the term. This is used only for fallback purposes.

The elimination of shared terms allows the caching strategy for terms to be
simplified. Individual terms are now cached in a single 'terms' bucket.

Props flixos90, boonebgorges, scribu, dipesh.kakadiya.
See #14162.
Built from https://develop.svn.wordpress.org/trunk@34997


git-svn-id: http://core.svn.wordpress.org/trunk@34962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 01:59:29 +00:00
Jeremy Felt f8a05879e8 MS: Show an error if a new site slug conflicts with an existing username. 
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804.

Built from https://develop.svn.wordpress.org/trunk@34996


git-svn-id: http://core.svn.wordpress.org/trunk@34961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 01:42:26 +00:00
Drew Jaynes 1b1e18027d Template: Make it possible to both ''add'' and ''remove'' items from the page templates list using the `theme_page_templates` filter. 
The `theme_page_templates` hook was originally added in [27297] as `page_templates`, and later renamed in [27470]. Previously, it was only possible to remove or rename page templates via this hook.

Fixes #13265. Fixes #25879.

Built from https://develop.svn.wordpress.org/trunk@34995


git-svn-id: http://core.svn.wordpress.org/trunk@34960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:51:25 +00:00
Sergey Biryukov 662ad721ec Remove stray closing tag in `wp-admin/themes.php`. 
Props tfrommen.
Fixes #34237.
Built from https://develop.svn.wordpress.org/trunk@34994


git-svn-id: http://core.svn.wordpress.org/trunk@34959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:17:25 +00:00
Drew Jaynes e89737ccfb Docs: Fix wrapping and syntax for a multi-comment in `Walker_Comment::display_element()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34993


git-svn-id: http://core.svn.wordpress.org/trunk@34958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:03:25 +00:00
Drew Jaynes e38a6edc61 Docs: Indent an example comment tree in the DocBlock for `Walker_Comment::display_element()` so it can be properly parsed in Markdown for the Code Reference. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34992


git-svn-id: http://core.svn.wordpress.org/trunk@34957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:00:27 +00:00
Andrea Fercia 42b33e1645 Administration: Convert H5 usage in Screen Options to use fieldsets and legends. 
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.

Props joedolson, afercia.
Fixes #33646.
Built from https://develop.svn.wordpress.org/trunk@34991


git-svn-id: http://core.svn.wordpress.org/trunk@34956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 18:05:24 +00:00
Helen Hou-Sandí 681573e80a Notices: Update one more instance of white-on-white. 
Because the media modal can be used on the front-end, the CSS needs to be added here rather than using the notice classes.

props paulwilde.
fixes #32244.

Built from https://develop.svn.wordpress.org/trunk@34990


git-svn-id: http://core.svn.wordpress.org/trunk@34955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 17:47:25 +00:00
Boone Gorges a19d63b7a5 Ensure that `WP_Date_Query` accepts a value of `0` for 'hour'. 
Props jim912.
Fixes #34228.
Built from https://develop.svn.wordpress.org/trunk@34989


git-svn-id: http://core.svn.wordpress.org/trunk@34954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 16:33:25 +00:00
Sergey Biryukov b40e362711 Fix typo in `get_avatar()` and `get_avatar_data()` docs. 
Props johnjamesjacoby.
Fixes #34232.
Built from https://develop.svn.wordpress.org/trunk@34988


git-svn-id: http://core.svn.wordpress.org/trunk@34953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 15:52:24 +00:00
Drew Jaynes 7e26ee2e3c Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions. 
The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because `localhost` is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.

Props ankit-k-gupta, iamfriendly.
Fixes #30317.

Built from https://develop.svn.wordpress.org/trunk@34987


git-svn-id: http://core.svn.wordpress.org/trunk@34952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 15:43:27 +00:00
Sergey Biryukov 072cdf116a Fix typo in `wp_rand()` docs. 
See #28633.
Built from https://develop.svn.wordpress.org/trunk@34986


git-svn-id: http://core.svn.wordpress.org/trunk@34951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 05:20:23 +00:00
Sergey Biryukov 0d7c5569f5 In `do_robots()`, allow crawling for `admin-ajax.php`, since it's often used on front-end. 
Props dmchale, joostdevalk.
Fixes #33156.
Built from https://develop.svn.wordpress.org/trunk@34985


git-svn-id: http://core.svn.wordpress.org/trunk@34950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 05:16:23 +00:00
Sergey Biryukov 95da3826b9 Media: Return early from `media_sideload_image()` if `$file` didn't match the pattern for images. 
Props MikeHansenMe, serpent7776.
Fixes #32755.
Built from https://develop.svn.wordpress.org/trunk@34984


git-svn-id: http://core.svn.wordpress.org/trunk@34949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:46:24 +00:00
Drew Jaynes d8811d591b Tests: Add basic DocBlocks for four helper methods in general/template.php used to assist testing the Site Icon feature. 
All four helpers were introduced in the feature merge for 4.3.

See #33968.

Built from https://develop.svn.wordpress.org/trunk@34983


git-svn-id: http://core.svn.wordpress.org/trunk@34948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:35:24 +00:00
Sergey Biryukov 3012b862af Add `$id` parameter to `the_permalink()`, for consistency with `get_permalink()`. 
Props johnjamesjacoby, chriscct7.
Fixes #23882.
Built from https://develop.svn.wordpress.org/trunk@34982


git-svn-id: http://core.svn.wordpress.org/trunk@34947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:34:24 +00:00
Dion Hulse 4852cbf14b Use PHP7's `random_int()` CSPRNG functionality in `wp_rand()` with a fallback to the `random_compat` library for PHP 5.x. 
`random_compat` offers a set of compatible functions for older versions of PHP, filling in the gap by using other PHP extensions when available.
We still include our existing `wp_rand()` functionality as a fallback for when no proper CSPRNG exists on the system.

Take Two, this was previously committed in [34922] but had an issue on PHP 5.2 which sarciszewski has now resolved.

Props sarciszewski
See #28633

Built from https://develop.svn.wordpress.org/trunk@34981


git-svn-id: http://core.svn.wordpress.org/trunk@34946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:28:24 +00:00
Sergey Biryukov dfc4654172 Dashboard: Display year in Activity widget if the post date year is not the same as the current one. 
Props GaryJ, chriscct7.
Fixes #26502.
Built from https://develop.svn.wordpress.org/trunk@34980


git-svn-id: http://core.svn.wordpress.org/trunk@34945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:26:24 +00:00
Sergey Biryukov 6595b1b080 My Sites: Make "Create a New Site" link consistent with other "Add New" links. 
Props JeffMatson.
Fixes #34179.
Built from https://develop.svn.wordpress.org/trunk@34979


git-svn-id: http://core.svn.wordpress.org/trunk@34944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 03:50:24 +00:00
Sergey Biryukov 3c7b7f7133 After [34529], if a compatible `termmeta` table is found on database upgrade, convert it to `utf8mb4` collation. 
Props dboulet.
Fixes #34224.
Built from https://develop.svn.wordpress.org/trunk@34978


git-svn-id: http://core.svn.wordpress.org/trunk@34943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 02:07:25 +00:00
Andrew Ozz a6cf0b41a6 JS: in event callbacks replace the very outdated `return false` with `preventDefault()`. 
Props adamsilverstein.
Fixes #18590.
Built from https://develop.svn.wordpress.org/trunk@34977


git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 01:27:27 +00:00
Helen Hou-Sandí b23005d7c1 Revisions: Update slider handle styling. 
This brings them in line with updated buttons as done in [34948] for #31459. It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.

props hugobaeta.
fixes #34220.

Built from https://develop.svn.wordpress.org/trunk@34976


git-svn-id: http://core.svn.wordpress.org/trunk@34941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 00:25:25 +00:00
Drew Jaynes c67853a6da Docs: Add a missing `@since` version to the hook doc for the `the_excerpt_embed` filter, introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34975


git-svn-id: http://core.svn.wordpress.org/trunk@34940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:25:24 +00:00
Drew Jaynes 9cbb68a4af Embeds: Rename the `$return` parameter in `wp_filter_oembed_result()` to `$result` to provide better context on what is being filtered. 
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34974


git-svn-id: http://core.svn.wordpress.org/trunk@34939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:22:24 +00:00
John Blackbourn 44da78be26 Remove HTML escaping for the plugin name and author fields that are displayed when deleting a plugin. 
While it might seem counter-intuitive to remove HTML escaping, these fields are already safe (they originate in `_get_plugin_data_markup_translate()` which handles sanitization and escaping), and the AuthorName field actually allows some HTML. This change prevents escaped HTML from appearing here.

Fixes #25422

Built from https://develop.svn.wordpress.org/trunk@34973


git-svn-id: http://core.svn.wordpress.org/trunk@34938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:13:24 +00:00
Drew Jaynes 2f700ddbf2 Embeds: Combine the `oembed_minwidth` and `oembed_maxwidth` filters into one, similar to how the existing `oembed_defaults` works for width and height. 
See #32522. See #34227.

Built from https://develop.svn.wordpress.org/trunk@34972


git-svn-id: http://core.svn.wordpress.org/trunk@34937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:09:23 +00:00
Drew Jaynes 60f86d2865 Docs: Add missing `@since` versions for the `oembed_minwidth` and `oembed_maxwidth` filters, introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34971


git-svn-id: http://core.svn.wordpress.org/trunk@34936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:55:25 +00:00
Drew Jaynes 8c35f77cdb Docs: Adjust third-person singular verbs in DocBlock summaries for oEmbed functions introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34970


git-svn-id: http://core.svn.wordpress.org/trunk@34935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:50:25 +00:00
Drew Jaynes fa3b23dc0d Embeds: Fix syntax on instantiating a new `WP_oEmbed_Controller` instance and cross-reference in the DocBlock for `wp_oembed_parse_query()`. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34969


git-svn-id: http://core.svn.wordpress.org/trunk@34934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:40:24 +00:00
Drew Jaynes f21439cc64 Docs: Adjust the summary for the `oembed_discovery_links` hook doc to mention that the filter is for HTML output. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34968


git-svn-id: http://core.svn.wordpress.org/trunk@34933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:39:24 +00:00
Drew Jaynes e4164932dd Docs: Clarify the file header summary for wp-includes/embed-functions.php, and add missing parameter information for `wp_oembed_parse_query()`, introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34967


git-svn-id: http://core.svn.wordpress.org/trunk@34932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:38:25 +00:00
Drew Jaynes 77314454a5 Embeds: If we're adding a boatload of new items to default-filters.php, might as well make them readable. 
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34966


git-svn-id: http://core.svn.wordpress.org/trunk@34931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:31:24 +00:00
John Blackbourn b62e798c17 Introduce the ability to filter the Users admin listing screen by users with no role, if such users exist. 
Fixes #22993
Props spmlucas, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34965


git-svn-id: http://core.svn.wordpress.org/trunk@34930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:07:47 +00:00
Drew Jaynes cc4c59a1fa Docs: Add a couple of strategically-placed spaces in `WP_Rewrite`. 
Fixes #34218.

Built from https://develop.svn.wordpress.org/trunk@34964


git-svn-id: http://core.svn.wordpress.org/trunk@34929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:07:24 +00:00
John Blackbourn 1451ebc0d1 On the Users list table, show all the roles of a user in a comma-separated list if they have more than one role. This prevents role obfuscation in situations where a user has had more than one role programmatically assigned to them. 
Fixes #22959
Props scribu, JustinSainton, DrewAPicture, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34963


git-svn-id: http://core.svn.wordpress.org/trunk@34928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:59:25 +00:00
Drew Jaynes aab0da2e17 Docs: Mark the optional parameters for `WP_Rewrite::generate_rewrite_rules()` as such, and improve overall formatting. 
Also brings in the list of acceptable constants for the `$ep_mask` parameter.

See #34218.

Built from https://develop.svn.wordpress.org/trunk@34962


git-svn-id: http://core.svn.wordpress.org/trunk@34927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:49:26 +00:00
Jeremy Felt 554b1425ed Make `$blog_id` explicitly global. 
`$blog_id` is used in both single and multisite configurations as a global variable, though has never been explicitly marked as such in the global scope. This can cause confusion depending on how core is loaded.

Fixes #34217.

Built from https://develop.svn.wordpress.org/trunk@34961


git-svn-id: http://core.svn.wordpress.org/trunk@34926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:45:25 +00:00
Drew Jaynes e147ba60b0 Docs: Convert the description for the optional `$args` parameter in `WP_Rewrite::add_permastruct()` into a hash notation. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34960


git-svn-id: http://core.svn.wordpress.org/trunk@34925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:35:26 +00:00
Boone Gorges c758468faf `WP_User_Query` role improvement redux. 
It's back, and it's better than ever: an overhaul of role-related arguments
in `WP_User_Query`. This updated version of the previously-reverted [34875]
includes support for the use of `$blog_id` without specifying a `$role`, for
a 99.7% reduced chance of breaking wordpress.org and other large sites.

Props boonebgorges, swissspidy.
Fixes #22212.
Built from https://develop.svn.wordpress.org/trunk@34959


git-svn-id: http://core.svn.wordpress.org/trunk@34924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:28:24 +00:00
Drew Jaynes 9f4d5731e9 Docs: Improve more formatting and syntax for inline comments in `WP_Rewrite`. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34958


git-svn-id: http://core.svn.wordpress.org/trunk@34923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:24:24 +00:00
Drew Jaynes 17010f97c7 Docs: Add saner formatting and make readability improvements to a variety of inline comments in `WP_Rewrite` and `WP_Rewrite::generate_rewrite_rules()`. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34957


git-svn-id: http://core.svn.wordpress.org/trunk@34922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:18:25 +00:00
Boone Gorges 99421d1799 Store SQL query string as a property on `WP_User_Query`. 
In addition to better parity with other WP query classes, this also allows
testing of SQL strings, should anyone want to do something so foolish.

See #22212.
Built from https://develop.svn.wordpress.org/trunk@34956


git-svn-id: http://core.svn.wordpress.org/trunk@34921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:06:23 +00:00
Sergey Biryukov 0b13fdf2fc Docs: Fix typo in [34944]. 
See #34218.
Built from https://develop.svn.wordpress.org/trunk@34955


git-svn-id: http://core.svn.wordpress.org/trunk@34920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:00:26 +00:00
Scott Taylor dae5923c1d After [34953], unbreak WordPress. 
See [34930], #33982.

Built from https://develop.svn.wordpress.org/trunk@34954


git-svn-id: http://core.svn.wordpress.org/trunk@34919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:29:25 +00:00
Scott Taylor c756465146 HTTP/REST API: move `WP_HTTP_Response` to `wp-includes/` with the rest (ha!) of the HTTP classes. This is PHP 5.2, so this class is global, and as per @rmccue, unrelated to REST specifically. 
See [34930], #33982.

Built from https://develop.svn.wordpress.org/trunk@34953


git-svn-id: http://core.svn.wordpress.org/trunk@34918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:27:28 +00:00
Drew Jaynes a07cd8b386 Docs: Normalize documentation spacing in the DocBlocks for `add_meta_box()` and `remove_meta_box()` following [34951]. 
Fixes #15000.

Built from https://develop.svn.wordpress.org/trunk@34952


git-svn-id: http://core.svn.wordpress.org/trunk@34917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:13:24 +00:00
Drew Jaynes 6e4268e6fa Administration: Add the ability to pass an array of screen IDs to `add_meta_box()` and `remove_meta_box()`. 
The `$screen` parameter in both functions can now accept a single screen ID, `WP_Screen` object, or an array of screen IDs.

Adds tests.

Props coffee2code, iamfriendly, madalinungureanu, mordauk, igmoweb, meloniq, DrewAPicture.
See #15000.

Built from https://develop.svn.wordpress.org/trunk@34951


git-svn-id: http://core.svn.wordpress.org/trunk@34916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:07:24 +00:00
Konstantin Obenland b5be742e1f Template: Add fallback for empty containers. 
Since [14031] the container can be omitted in `wp_nav_menu()`. It can not
however in `wp_page_menu()`, which creates a conflict if it is set as
the fallback, Let's make sure there is always a valid container tag.

Fixes #33974.


Built from https://develop.svn.wordpress.org/trunk@34950


git-svn-id: http://core.svn.wordpress.org/trunk@34915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 18:27:25 +00:00
Sergey Biryukov 45bda3af69 REST API: Add some missing documentation. 
Props swissspidy.
Fixes #34215.
Built from https://develop.svn.wordpress.org/trunk@34949


git-svn-id: http://core.svn.wordpress.org/trunk@34914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 18:01:25 +00:00
Helen Hou-Sandí 5b40bd827c Buttons: Update styles and colors. 
* Aligns with the color standards. See https://make.wordpress.org/design/handbook/foundations/colors/
* Creates a consistent interaction experience between states.
* Improves contrast and accessibility.

props hugobaeta, afercia, melchoyce, michael-arestad.
fixes #31459.

Built from https://develop.svn.wordpress.org/trunk@34948


git-svn-id: http://core.svn.wordpress.org/trunk@34913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:31:24 +00:00
Boone Gorges 48493cdf3a Allow a null `id` to do a `name` lookup in `wp_set_current_user()`. 
Previously, the `name` fallback was failing in the case where the current user
was 0, due to a loose comparison between 0 (the current user) and `null` (the
value that is used to trigger the `name` fallback).

Props bobbingwide.
Fixes #20845.
Built from https://develop.svn.wordpress.org/trunk@34947


git-svn-id: http://core.svn.wordpress.org/trunk@34912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:29:24 +00:00
John Blackbourn db4f4c5538 Improve the parameter names and inline documentation for `add_rewrite_rule()`, `WP_Rewrite::add_rule()`, and `WP_Rewrite::add_external_rule()`. 
Fixes #34197

Built from https://develop.svn.wordpress.org/trunk@34946


git-svn-id: http://core.svn.wordpress.org/trunk@34911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:28:25 +00:00
Boone Gorges 77ae65acdb Add tests for current behavior of `wp_set_current_user()`. 
See #20845.
Built from https://develop.svn.wordpress.org/trunk@34945


git-svn-id: http://core.svn.wordpress.org/trunk@34910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:19:24 +00:00
Drew Jaynes 305ae14461 Docs: Fix third-person singular verbs in DocBlock summaries throughout `WP_Rewrite`. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34944


git-svn-id: http://core.svn.wordpress.org/trunk@34909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:12:24 +00:00
Sergey Biryukov 639371de09 Add `wp_load_translations_early()` to `wpdb::check_connection()`. 
Fixes #29306. See #34216.
Built from https://develop.svn.wordpress.org/trunk@34943


git-svn-id: http://core.svn.wordpress.org/trunk@34908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:11:24 +00:00
Sergey Biryukov 50e6ef8bd7 Split database error messages into separate strings to remove unnecessary HTML tags from translations. 
Add translator comments for placeholders.

Fixes #34216.
Built from https://develop.svn.wordpress.org/trunk@34942


git-svn-id: http://core.svn.wordpress.org/trunk@34907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:52:24 +00:00
Drew Jaynes d2dee54669 Docs: Relocate some more DocBlock-level `@see` tags and add some missing `@access` tags in `WP_Rewrite`. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34941


git-svn-id: http://core.svn.wordpress.org/trunk@34906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:51:24 +00:00
Drew Jaynes 1e6f1c9a9b Docs: Relocate some DocBlock-level `@see` tags in `WP_Rewrite`. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34940


git-svn-id: http://core.svn.wordpress.org/trunk@34905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:49:24 +00:00
Drew Jaynes 02645d5711 Docs: Remove invalid inline `@link` tags from a variety of DocBlocks in `WP_Rewrite`. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34939


git-svn-id: http://core.svn.wordpress.org/trunk@34904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:47:25 +00:00
Drew Jaynes d1fd329ea2 Docs: Add a file header to wp-includes/class-wp-rewrite.php. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34938


git-svn-id: http://core.svn.wordpress.org/trunk@34903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:41:26 +00:00
Dominik Schilling c50acdcb4c Embeds: Update `$wp_db_version` to flush rewrite rules for [34903]. 
Fixes #34209.
Built from https://develop.svn.wordpress.org/trunk@34937


git-svn-id: http://core.svn.wordpress.org/trunk@34902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 11:12:28 +00:00
Dominik Schilling f8c467e07a Term Meta: Prevent a "Multiple primary key defined" error during database upgrades. 
You must have two spaces between the words `PRIMARY KEY` and the definition of your primary key. Yes, seriously.

See [34529].
Fixes #34210.
Built from https://develop.svn.wordpress.org/trunk@34936


git-svn-id: http://core.svn.wordpress.org/trunk@34901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 11:09:26 +00:00
Gary Pendergast 24128dfc90 Posts: Add the `pre_get_lastpostmodified` filter to `get_lastpostmodified()`. 
This allows `get_lastpostmodified()` to be short circuited when the site wants to avoid running the occasionally slow queries in `_get_last_post_time()`.

Fixes #34205.


Built from https://develop.svn.wordpress.org/trunk@34935


git-svn-id: http://core.svn.wordpress.org/trunk@34900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 05:57:25 +00:00
Boone Gorges c2a0d593ac Allow excluded keywords when searching posts. 
Pass a keyword with a leading hyphen to exclude posts containing that keyword.
For example, 'taco -onions' will return posts that contain the word 'taco' but
do not contain the word 'onions'.

Props akibjorklund.
Fixes #33988.
Built from https://develop.svn.wordpress.org/trunk@34934


git-svn-id: http://core.svn.wordpress.org/trunk@34899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:18:24 +00:00
John Blackbourn 7b230cafab Abstract the shortcode attribute parsing regex into its own function, update the JavaScript counterpart, and introduce a test to ensure they do not diverge again. 
Fixes #34191
Props miqrogroove, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34933


git-svn-id: http://core.svn.wordpress.org/trunk@34898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:12:24 +00:00
John Blackbourn d2416ca93a Correctly set the `secure` flag on the post password cookie based on the scheme of the referring URL, if it's available, instead of the home URL. 
Fixes #29641

Built from https://develop.svn.wordpress.org/trunk@34932


git-svn-id: http://core.svn.wordpress.org/trunk@34897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:09:24 +00:00
John Blackbourn 95045d629b Correctly set the `secure` flag for the test cookie based on the login URL scheme, and the same for the user settings cookies based on the admin URL scheme. 
Fixes #34159

Built from https://develop.svn.wordpress.org/trunk@34931


git-svn-id: http://core.svn.wordpress.org/trunk@34896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:05:25 +00:00
Ryan McCue a998ea45e2 REST API: Add missing reference to WP_HTTP_Response 
See #33982

Built from https://develop.svn.wordpress.org/trunk@34930


git-svn-id: http://core.svn.wordpress.org/trunk@34895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:40:24 +00:00
Ryan McCue a70d18a10d REST API: Unbreak everything. 
Obviously, it wouldn't have been a good commit unless I botched it.

See #33982.

Built from https://develop.svn.wordpress.org/trunk@34929


git-svn-id: http://core.svn.wordpress.org/trunk@34894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:34:24 +00:00
Ryan McCue 94e2352956 REST API: Introduce baby API to the world. 
Baby API was born at 2.8KLOC on October 8th at 2:30 UTC. API has lots
of growing to do, so wish it the best of luck.

Thanks to everyone who helped along the way:

Props rmccue, rachelbaker, danielbachhuber, joehoyle, drewapicture,
adamsilverstein, netweb, tlovett1, shelob9, kadamwhite, pento,
westonruter, nikv, tobych, redsweater, alecuf, pollyplummer, hurtige,
bpetty, oso96_2000, ericlewis, wonderboymusic, joshkadis, mordauk,
jdgrimes, johnbillion, jeremyfelt, thiago-negri, jdolan, pkevan,
iseulde, thenbrent, maxcutler, kwight, markoheijnen, phh, natewr,
jjeaton, shprink, mattheu, quasel, jmusal, codebykat, hubdotcom,
tapsboy, QWp6t, pushred, jaredcobb, justinsainton, japh, matrixik,
jorbin, frozzare, codfish, michael-arestad, kellbot, ironpaperweight,
simonlampen, alisspers, eliorivero, davidbhayes, JohnDittmar, dimadin,
traversal, cmmarslender, Toddses, kokarn, welcher, and ericpedia.

Fixes #33982.

Built from https://develop.svn.wordpress.org/trunk@34928


git-svn-id: http://core.svn.wordpress.org/trunk@34893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:31:25 +00:00
Ryan McCue b3051048be REST API: Add wp_is_numeric_array helper function 
The API uses this to do special operations on list responses (used
for collections), so we need to detect whether an array is
associative or numeric-indexed.

After much discussion, the bikeshed is to be painted green and gold.

See #33982.

Built from https://develop.svn.wordpress.org/trunk@34927


git-svn-id: http://core.svn.wordpress.org/trunk@34892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:14:25 +00:00
Ryan McCue 4bac3c3f14 REST API: Add JsonSerializable compatibility to wp_json_encode 
Following on from r34845, the JsonSerializable shim needs support
on the encoding side too. _wp_json_prepare_data handles this when
we've loaded the shim.

Props chriscct7.

See #33982. 

Built from https://develop.svn.wordpress.org/trunk@34926


git-svn-id: http://core.svn.wordpress.org/trunk@34891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 01:30:25 +00:00
John Blackbourn 0e1ecdcbf3 Revert [34917] until the broken test is fixed. 
See #13382

Built from https://develop.svn.wordpress.org/trunk@34925


git-svn-id: http://core.svn.wordpress.org/trunk@34890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 01:04:25 +00:00
Dion Hulse bb8ba86ed1 Revert [34922] pending PHP 5.2 compatibility. 
See #28633

Built from https://develop.svn.wordpress.org/trunk@34924


git-svn-id: http://core.svn.wordpress.org/trunk@34889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 00:17:24 +00:00
Sergey Biryukov 399c1f3c83 Reset Password: Move the code for creating password reset key into a new function, `get_password_reset_key()`, and use it in `retrieve_password()`. 
Previously: [25231].

Props DH-Shredder.
Fixes #34180.
Built from https://develop.svn.wordpress.org/trunk@34923


git-svn-id: http://core.svn.wordpress.org/trunk@34888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 00:11:24 +00:00
Dion Hulse 0e322469a6 Use PHP7's `random_int()` CSPRNG functionality in `wp_rand()` with a fallback to the `random_compat` library for PHP 5.x. 
`random_compat` offers a set of compatible functions for older versions of PHP, filling in the gap by using other PHP extensions when available.
We still include our existing `wp_rand()` functionality as a fallback for when no proper CSPRNG exists on the system.

Props sarciszewski
See #28633

Built from https://develop.svn.wordpress.org/trunk@34922


git-svn-id: http://core.svn.wordpress.org/trunk@34887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 00:02:24 +00:00
Sergey Biryukov 047501800d Customizer: Replace context for two strings added in [30306] with a translator comment. 
Fixes #34203.
Built from https://develop.svn.wordpress.org/trunk@34921


git-svn-id: http://core.svn.wordpress.org/trunk@34886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 23:54:24 +00:00
John Blackbourn 6d21ed0d99 Avoid stripping square brackets from URLs, and instead correctly encode them. Square brackets must be encoded in the path, path parameters, query parameters, and fragment, but must not be encoded in anything up to the domain and port. 
Adds tests.

Fixes #16859

Built from https://develop.svn.wordpress.org/trunk@34920


git-svn-id: http://core.svn.wordpress.org/trunk@34885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 23:39:23 +00:00
Boone Gorges 846510ea6f Handle `WP_User` objects properly in `update_user_caches()`. 
We should not be storing the `WP_User` object in the cache, as it may contain
usermeta and other data that's cache elsewhere.

Props dd32.
See #24635.
Built from https://develop.svn.wordpress.org/trunk@34919


git-svn-id: http://core.svn.wordpress.org/trunk@34884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 22:42:25 +00:00
Boone Gorges b0e0323337 Add tests for `update_user_caches()`. 
See #24635.
Built from https://develop.svn.wordpress.org/trunk@34918


git-svn-id: http://core.svn.wordpress.org/trunk@34883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 22:35:26 +00:00
John Blackbourn 9daa848297 Correctly set the scheme of the `home` and `siteurl` options when creating a new site on multisite that uses some combination of HTTPS in the admin area or on the front end. 
Fixes #33620
Props tryon, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34916


git-svn-id: http://core.svn.wordpress.org/trunk@34881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 21:46:25 +00:00
John Blackbourn 45230b5fc7 Correctly encode the `url` parameter that gets passed to WordPress' own oEmbed endpoint URL. 
Fixes #34193
Props ocean90

Built from https://develop.svn.wordpress.org/trunk@34915


git-svn-id: http://core.svn.wordpress.org/trunk@34880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 21:43:25 +00:00
John Blackbourn c83a66cbf3 Add an optional `$description` parameter to `status_header()` so custom HTTP status descriptions can be provided. 
Fixes #21472
Props nbachiyski, iamfriendly

Built from https://develop.svn.wordpress.org/trunk@34914


git-svn-id: http://core.svn.wordpress.org/trunk@34879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 21:26:25 +00:00
Andrea Fercia 17f53091ed Bump H3 headings to H2 on the Network Admin > Sites > Edit Site screens. 
The navigation tabs appear in an `<h3>` heading immediately following the main `<h1>` and need to have a proper hierarchy.
Also, fix the tabs focus style and introduce a new `.nav-tab-small` CSS class.

Fixes #34079.
Built from https://develop.svn.wordpress.org/trunk@34913


git-svn-id: http://core.svn.wordpress.org/trunk@34878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 17:35:24 +00:00
Jeremy Felt 9926983b66 Revert [34778], continue using `_site_option()` for the current network. 
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@34912


git-svn-id: http://core.svn.wordpress.org/trunk@34877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 17:11:25 +00:00
Drew Jaynes feb2267a13 Docs: Improve documentation for `post_submit_meta_box()`, which serves as the display callback for the 'Publish' meta box. 
* `$post` is now correctly defined as being of the `WP_Post` type
* Adds a hash notation for the `$args` array
* Other minor fixes.

Props drebbitsweb.
Fixes #34171.

Built from https://develop.svn.wordpress.org/trunk@34911


git-svn-id: http://core.svn.wordpress.org/trunk@34876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 16:34:24 +00:00
John Blackbourn 471752f59a Prevent a PHP notice when POSTing to `wp-login.php?action=register` without a `user_login` or `user_email` field in the POST request. 
Fixes #34192

Built from https://develop.svn.wordpress.org/trunk@34910


git-svn-id: http://core.svn.wordpress.org/trunk@34875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 14:43:25 +00:00
John Blackbourn 2d745fabe3 Prevent a PHP notice from appearing on `wp-login.php?action=postpass` when there's no `$_POST['post_password']` parameter. Redirects to the referer if there is one (if there isn't one it'll just exit with a blank screen; no need for a user-friendly error message here). 
Fixes #34160
Props iamfriendly

Built from https://develop.svn.wordpress.org/trunk@34909


git-svn-id: http://core.svn.wordpress.org/trunk@34874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 14:30:25 +00:00
Dominik Schilling 3baa1336ec Embeds: Autoprefixer for [34903]. 
See #32522.
Built from https://develop.svn.wordpress.org/trunk@34908


git-svn-id: http://core.svn.wordpress.org/trunk@34873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 14:07:25 +00:00
John Blackbourn 35f613833e Update the explanatory text which accompanies the list of whitelisted oEmbed providers, following the change to the default value of the `discover` argument in `WP_oEmbed::get_provider()`. 
See #32522

Built from https://develop.svn.wordpress.org/trunk@34907


git-svn-id: http://core.svn.wordpress.org/trunk@34872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 13:05:25 +00:00
Gary Pendergast c317248d13 Build: Fix a filename typo in [34903]. 
Props peterwilsoncc.

See #32522.


Built from https://develop.svn.wordpress.org/trunk@34906


git-svn-id: http://core.svn.wordpress.org/trunk@34871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 12:05:26 +00:00
Gary Pendergast 8c0e2bb4e8 Tests: Exclude the `oembed/headers.php` test file, which was marked as PHP >= 5.3.0 in [34904]. 
See #32522.


Built from https://develop.svn.wordpress.org/trunk@34905


git-svn-id: http://core.svn.wordpress.org/trunk@34870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 12:01:25 +00:00
Gary Pendergast 6a18efb313 Embeds: After [34903], remove an accidentally included text domain, and exclude a test failing in PHP 5.2. 
Built from https://develop.svn.wordpress.org/trunk@34904


git-svn-id: http://core.svn.wordpress.org/trunk@34869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 11:01:25 +00:00
Gary Pendergast 83c3e3e00e Embeds: Add oEmbed provider support. 
For the past 6 years, WordPress has operated as an oEmbed consumer, allowing users to easily embed content from other sites. By adding oEmbed provider support, this allows any oEmbed consumer to embed posts from WordPress sites.

In addition to creating an oEmbed provider, WordPress' oEmbed consumer code has been enhanced to work with any site that provides oEmbed data (as long as it matches some strict security rules), and provides a preview from within the post editor.

For security, embeds appear within a sandboxed iframe - the iframe content is a template that can be styled or replaced entirely by the theme on the provider site.

Props swissspidy, pento, melchoyce, netweb, pfefferle, johnbillion, extendwings, davidbinda, danielbachhuber, SergeyBiryukov, afercia

Fixes #32522.


Built from https://develop.svn.wordpress.org/trunk@34903


git-svn-id: http://core.svn.wordpress.org/trunk@34868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 10:36:25 +00:00
Jeremy Felt 31b29fccbd Tests: Remove static capture of space used and space allowed. 
Originally introduced in [34601], this was necessary to avoid test pollution. Now that things have been separated and written to play nicely, we can remove this.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@34902


git-svn-id: http://core.svn.wordpress.org/trunk@34867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 07:25:24 +00:00
Jeremy Felt 297148d985 Tests: Improve tests for `upload_is_user_over_quota()`. 
* Move all tests to a new 'multisite/uploadIsUserOverQuota.php'
* Use `get_space_allowed` and `pre_get_space_used` filters to help avoid test pollution.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@34901


git-svn-id: http://core.svn.wordpress.org/trunk@34866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 07:21:24 +00:00
Jeremy Felt 7b3fa2221a Tests: Account for non-numeric strings in tests for `get_space_allowed()`. 
Provides a specific test for a case where a non-numeric strings are assigned to `blog_upload_space` at both the site and network levels.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@34900


git-svn-id: http://core.svn.wordpress.org/trunk@34865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 06:17:24 +00:00
Jeremy Felt 7f2f3d614e Tests: Improve tests for `is_upload_space_available()`. 
* Move all tests to a new 'multisite/isUploadSpaceAvailable.php'
* Store original `blog_upload_space` values before the class is loaded.
* Restore these values after each test tear down to avoid pollution.

Commit to testing `is_upload_space_available()` itself by always filtering the amount of space used through `pre_get_space_used`. This allows us to sanely test without worrying about the local environment. In the future, we may be able to remove some of these tests as `get_upload_space_available()` tests are built out and reliable.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@34899


git-svn-id: http://core.svn.wordpress.org/trunk@34864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 06:15:25 +00:00
Jeremy Felt daea4ff02f Tests: Improve tests for `get_space_allowed()`. 
* Move all tests to a new `multisite/getSpaceAllowed.php`
* Store original `blog_upload_space` values before the class is loaded.
* Restore these values after each test tear down to avoid pollution.
* Add a comprehensive set of expectations and results via data provider.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@34898


git-svn-id: http://core.svn.wordpress.org/trunk@34863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 04:58:24 +00:00
Scott Taylor a1ead3c7e3 List Tables: in `_WP_List_Table_Compat::get_column_info()`, also return `$primary`, which is expected since [33016]. 
Props tyxla.
Fixes #34148.

Built from https://develop.svn.wordpress.org/trunk@34897


git-svn-id: http://core.svn.wordpress.org/trunk@34862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 03:12:24 +00:00
Boone Gorges 226bb29ff0 Move `wp_installing()` to load.php. 
Various functions in load.php need to check whether WP is in installation mode.
Let's let them.

Props adamsilverstein.
See #31130.
Built from https://develop.svn.wordpress.org/trunk@34896


git-svn-id: http://core.svn.wordpress.org/trunk@34861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 03:02:23 +00:00
Scott Taylor ae813883f5 Meta Boxes: add an action, `post_submitbox_minor_actions`. `post_submitbox_misc_actions` already exists. Pass `$post` to both for context - avoids having to check for a global post. 
Props jonathanbardo, chriscct7, DrewAPicture.
Fixes #26267.

Built from https://develop.svn.wordpress.org/trunk@34895


git-svn-id: http://core.svn.wordpress.org/trunk@34860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 02:45:25 +00:00
Scott Taylor 4d3223b28e Introduce `wp_get_server_protocol()` to DRY protocol parsing logic and make adding more protocols, like `HTTP/2`, easier. 
Props johnbillion, wonderboymusic.
Fixes #34131.

Built from https://develop.svn.wordpress.org/trunk@34894


git-svn-id: http://core.svn.wordpress.org/trunk@34859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 02:35:26 +00:00
Scott Taylor 2783773775 Meta Boxes: reboot some of the code in `postbox.js` to support `aria-expanded` attribute toggling and to properly reference static class properties. 
Props afercia, wonderboymusic.
Fixes #33754.

Built from https://develop.svn.wordpress.org/trunk@34893


git-svn-id: http://core.svn.wordpress.org/trunk@34858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 01:58:25 +00:00
Scott Taylor a3ec4d45f3 List Tables: after [34276], decrease horizontal padding for sorted column headers (causing weirdness in the Count column of tax list tables) - the vertical padding change suffices in fixing the original issue. 
Fixes #27945.

Built from https://develop.svn.wordpress.org/trunk@34892


git-svn-id: http://core.svn.wordpress.org/trunk@34857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 01:40:24 +00:00
Scott Taylor 0c2b2a0e3d List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 
These additions are based on an audit and recommendations by the Accessibility team. #a11y'all

Props afercia.
Fixes #32147.

Built from https://develop.svn.wordpress.org/trunk@34891


git-svn-id: http://core.svn.wordpress.org/trunk@34856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 01:28:25 +00:00
Scott Taylor b3a07ab8ea Rewrite/Permalinks/Canonical: in `url_to_postid()`, call `set_url_scheme()` on the URL to combat mixed content issues and find posts cross-scheme. 
Adds unit tests.

Props swissspidy.
Fixes #34144.

Built from https://develop.svn.wordpress.org/trunk@34890


git-svn-id: http://core.svn.wordpress.org/trunk@34855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 01:07:24 +00:00
Scott Taylor 7547dc5125 Posts List Table: ensure that "All" gets the "current" CSS class when applicable. 
Props afercia.
Fixes #19609.

Built from https://develop.svn.wordpress.org/trunk@34889


git-svn-id: http://core.svn.wordpress.org/trunk@34854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 00:09:24 +00:00
Scott Taylor 27fd5b762b Build Tools: upgrade `grunt-browserify` to `~4.0.0` and remove the `watch` task for `browserify`, which has its own internal watcher. Run `npm install` to update. 
Props iseulde.
Fixes #31911.

Built from https://develop.svn.wordpress.org/trunk@34888


git-svn-id: http://core.svn.wordpress.org/trunk@34853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 00:00:43 +00:00
Sergey Biryukov 987ec5e6ad Remove closing PHP tag from `wp-includes/class-phpass.php`. 
Previously: [19712], [28678].

Props iamfriendly, amandato.
Fixes #30534.
Built from https://develop.svn.wordpress.org/trunk@34887


git-svn-id: http://core.svn.wordpress.org/trunk@34852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 23:45:25 +00:00
Drew Jaynes 51a5e818da Docs: Only document `get_posts()` argument defaults that differ from, or aren't present in the defaults offered by `WP_Query::parse_query()`. 
Props johnbillion.
Fixes #34156.

Built from https://develop.svn.wordpress.org/trunk@34886


git-svn-id: http://core.svn.wordpress.org/trunk@34851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 23:19:24 +00:00
Drew Jaynes fa4fed0f80 Login: Pass the `$errors` object as a parameter to the `lostpassword_post` hook. 
Props iamfriendly.
Fixes #32116.

Built from https://develop.svn.wordpress.org/trunk@34885


git-svn-id: http://core.svn.wordpress.org/trunk@34850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 23:00:25 +00:00
Drew Jaynes 6079c4c6d2 Docs: `_pad_term_counts()` takes an array of objects passed by reference, not term IDs. 
Props wpsmith.
Fixes #34174.

Built from https://develop.svn.wordpress.org/trunk@34884


git-svn-id: http://core.svn.wordpress.org/trunk@34849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 22:39:23 +00:00
Weston Ruter aa044b054e Customizer: Ensure that `wp.customize.Widgets.savedWidgetIds` is defined up front. 
In 4.3 the widget controls were fully initialized up front along with the sidebar controls. The sidebar control depended (unnecessarily) on the widget control to ensure that `wp.customize.Widgets.savedWidgetIds` was defined. So after [34563] there could be a situation where the widgets are added/removed from a sidebar before their controls are initialized (if the sidebar section is never expanded), resulting in an error attempting to get a property off of an undefined value. So this change does the right thing and defines `savedWidgetIds` up front.

Also changes the `savedWidgetIds` variable type from an array to an object, to match how it is used as a dictionary lookup.

See #33901.

Built from https://develop.svn.wordpress.org/trunk@34883


git-svn-id: http://core.svn.wordpress.org/trunk@34848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 21:59:25 +00:00
Jeremy Felt 8286a4f214 Registration: Remove the last remaining `Lucida Grande` from WordPress. 
Defer to default styling provided by the theme (and browser) in `wp-activate.php` and remove the `font-family` and `color` from the provided internal stylesheet.

Previously, [17327] and [18406].

Fixes #34145.

Built from https://develop.svn.wordpress.org/trunk@34882


git-svn-id: http://core.svn.wordpress.org/trunk@34847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 21:56:24 +00:00
Konstantin Obenland 442c393599 Posts: Add post class for password protected posts. 
Up until now password protected posts would only get a identifying class when
the password was still required. This adds a class for the case when that
requirement has been met.

For the other visibility types we already have `status-publish`
and `status-private`.

Props mdgl, F4rkie, wonderboymusic for initial patches.
Fixes #21899.


Built from https://develop.svn.wordpress.org/trunk@34881


git-svn-id: http://core.svn.wordpress.org/trunk@34846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 21:54:24 +00:00
Aaron Jorbin a93ec5244d Revert [34875] due to unintentional breaking change 
WordPress.org was taken down due to as Otto42 describes:

The previous version of this function added the query piece for the meta key = blog_id.capabilities, regardless of whether or not a role was requested. This limits the users returned to those with some defined role on this particular multisite instance.

See #22212



Built from https://develop.svn.wordpress.org/trunk@34880


git-svn-id: http://core.svn.wordpress.org/trunk@34845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 20:58:24 +00:00
Aaron Jorbin 2ac3027a58 Add message with status info to temperamental assertion. 
The ajax delete comment tests are intermittently failing. Many of the assertions make it hard to tell why they are failing. This adds a message to one of those assertions that contains some info on what is being asserted with the goal that it helps developers understand why the failure is failing.

See #33968


Built from https://develop.svn.wordpress.org/trunk@34879


git-svn-id: http://core.svn.wordpress.org/trunk@34844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 19:56:24 +00:00
Sergey Biryukov 2702fd12cf Transients: Clarify the `expiration_of_site_transient_$transient` filter description. 
See #21330.
Built from https://develop.svn.wordpress.org/trunk@34878


git-svn-id: http://core.svn.wordpress.org/trunk@34843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 18:11:24 +00:00
Dominik Schilling e237e59172 Transients: Rename filters added in [34865]. 
* `expiration_pre_set_transient_$transient` => `expiration_of_transient_$transient`
* `expiration_pre_set_site_transient_$transient` => `expiration_of_site_transient_$transient`

Fix hook docs.

Props chriscct7.
Fixes #21330.
Built from https://develop.svn.wordpress.org/trunk@34877


git-svn-id: http://core.svn.wordpress.org/trunk@34842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:59:25 +00:00
Drew Jaynes 1e2caf6712 Docs: Update an inline comment in `wp_get_attachment_image_sizes()`, which came in as part of the Responsive Images merge in [34855]. 
Props joemcgill.
See #33641.

Built from https://develop.svn.wordpress.org/trunk@34876


git-svn-id: http://core.svn.wordpress.org/trunk@34841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:47:24 +00:00
Boone Gorges f233b37d07 Improve role-related arguments in `WP_User_Query`. 
* 'role' now accepts an array or comma-separated list of role names. When passing multiple values for 'role', `WP_User_Query` will only match users that have all of the specified roles.
* 'role__in' accepts an array of role names, and allow the filtering of matched users to those with at least one of the specified roles.
* 'role__not_in' accepts an array of role names, and allows the filtering of matched users to those who have none of the specified roles.

Props swissspidy, mordauk, barrykooij, sirbrillig.
Fixes #22212.
Built from https://develop.svn.wordpress.org/trunk@34875


git-svn-id: http://core.svn.wordpress.org/trunk@34840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:40:47 +00:00
Aaron Jorbin 0978abe76c Adjust detection of stream timeouts in maybe skip tests for https tests 
This is a follow up to [34848].

See #33968.


Built from https://develop.svn.wordpress.org/trunk@34874


git-svn-id: http://core.svn.wordpress.org/trunk@34839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:40:24 +00:00
Dominik Schilling 0bc1d84fc7 MS Themes List Table: Fix inverted logic for displaying the "No items" message. 
Fixes #25464.
Built from https://develop.svn.wordpress.org/trunk@34873


git-svn-id: http://core.svn.wordpress.org/trunk@34838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:35:23 +00:00
Sergey Biryukov 551b904985 Fix typo in [34848]. 
See #33968.
Built from https://develop.svn.wordpress.org/trunk@34872


git-svn-id: http://core.svn.wordpress.org/trunk@34837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:28:24 +00:00
Drew Jaynes 5df204fab4 Template: Introduce a new `class_form` argument in `comment_form()`, allowing customization of the form class attribute. 
The static 'comment-form' class was originally added to `comment_form()` in [24525]. This new argument should provide needed flexibility in styling the comment form further.

Props flixos90.
Fixes #34170. See #23851.

Built from https://develop.svn.wordpress.org/trunk@34871


git-svn-id: http://core.svn.wordpress.org/trunk@34836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 17:17:24 +00:00
Drew Jaynes f7bf281978 Tests: Update `Tests_Rewrite_AddRewriteRule->setUp()` to use the new `set_permalink_structure()` helper. 
See #33968.

Built from https://develop.svn.wordpress.org/trunk@34870


git-svn-id: http://core.svn.wordpress.org/trunk@34835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 16:02:25 +00:00
Dominik Schilling 273cae2573 Script Loader: Update version of `json2.js` after [34863]. 
See #26913.
Built from https://develop.svn.wordpress.org/trunk@34869


git-svn-id: http://core.svn.wordpress.org/trunk@34834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 15:52:26 +00:00
Helen Hou-Sandí cd3367d942 Shortcodes: Pass the name as context for `shortcode_atts_{$shortcode}`. 
props mattheu.
fixes #34167.

Built from https://develop.svn.wordpress.org/trunk@34868


git-svn-id: http://core.svn.wordpress.org/trunk@34833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 14:34:24 +00:00
Scott Taylor 2d1fff2c75 Setup/Config: some `dirname( ABSPATH )` file lookups should have errors suppressed due to possibility of `open_basedir` restrictions on hosts. 
Props chriscct7, misterunknown.
Fixes #29680.

Built from https://develop.svn.wordpress.org/trunk@34867


git-svn-id: http://core.svn.wordpress.org/trunk@34832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 14:20:25 +00:00
Scott Taylor ddbd67a22e Media: in `wp_read_video|audio_metadata()`, set `GETID3_TEMP_DIR` to `get_temp_dir()` if it is not defined. This is a workaround for when `safe_mode` is enabled pre-PHP 5.3. 
Props chriscct7, tomsommer.
Fixes #26265.

Built from https://develop.svn.wordpress.org/trunk@34866


git-svn-id: http://core.svn.wordpress.org/trunk@34831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 14:14:25 +00:00
Scott Taylor 1dcc6e1b51 Transients, add filters for `$expiration`: 
* `'expiration_pre_set_site_transient_' . $transient`
* `'expiration_pre_set_transient_' . $transient`
 
Props chriscct7, wpsmith, nacin.
Fixes #21330.

Built from https://develop.svn.wordpress.org/trunk@34865


git-svn-id: http://core.svn.wordpress.org/trunk@34830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 14:10:25 +00:00
Scott Taylor 53060a8987 WP Mail: replace logic that was mimicking `strtotime()` with `strtotime()`. Without this, the date parsing wasn't accounting for half-hour and quarter-hour timezones. 
Props neoscrib, solarissmoke.
Fixes #16993.

Built from https://develop.svn.wordpress.org/trunk@34864


git-svn-id: http://core.svn.wordpress.org/trunk@34829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 14:07:24 +00:00
Scott Taylor c32357a900 External Libraries: update `json2.js` to the `2015-05-03` version. Crockford does not tag releases: https://github.com/douglascrockford/JSON-js/commits/master 
Props mgibbs189, chriscct7.
Fixes #26913.

Built from https://develop.svn.wordpress.org/trunk@34863


git-svn-id: http://core.svn.wordpress.org/trunk@34828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 14:02:25 +00:00
Scott Taylor a3e36194fd Scripts: in `WP_Scripts::set_group()`, the `args` prop of the `_WP_Dependency` instance defaults to `null` - check that it is set before comparing. 
Props tivnet, chriscct7.
Fixes #25462.

Built from https://develop.svn.wordpress.org/trunk@34862


git-svn-id: http://core.svn.wordpress.org/trunk@34827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 13:54:25 +00:00
Scott Taylor c5475fbfc2 Admin Menu: remove duplicated separators, and use `strpos()` (instead of `strcmp()`) when determining if the separator CSS class is present. 
Props rilwis, chriscct7.
Fixes #24104.

Built from https://develop.svn.wordpress.org/trunk@34861


git-svn-id: http://core.svn.wordpress.org/trunk@34826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 13:46:25 +00:00
Scott Taylor 8c256a3357 XML-RPC: allow `wp_xmlrpc_server::wp_getPosts()` to receive `s` as a filter. 
Props chriscct7.
Fixes #25406.

Built from https://develop.svn.wordpress.org/trunk@34860


git-svn-id: http://core.svn.wordpress.org/trunk@34825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 13:41:26 +00:00
Drew Jaynes eeb76b6e56 Users: Don't typo `assertTrue()` in a the uppercase letters `validate_username()` test. 
See #24618.

Built from https://develop.svn.wordpress.org/trunk@34859


git-svn-id: http://core.svn.wordpress.org/trunk@34824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 07:10:25 +00:00
Drew Jaynes 33150c45d9 Users: Add a separate test for checking the validity of a username containing uppercase characters in the scope of single vs multisite. 
'JohnDoe' in single site: valid
'JohnDoe' in multisite: invalid

See #24618.

Built from https://develop.svn.wordpress.org/trunk@34858


git-svn-id: http://core.svn.wordpress.org/trunk@34823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 07:02:24 +00:00
Gary Pendergast 74aef3b75d Tests: Dequeue the styles and scripts enqueued by `Test_WP_Customize_Nav_Menus::test_enqueue_scripts()`. 
Fixes #34163.


Built from https://develop.svn.wordpress.org/trunk@34857


git-svn-id: http://core.svn.wordpress.org/trunk@34822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 05:48:24 +00:00
Drew Jaynes 7b82d75ec8 Users: Empty sanitized usernames should be considered invalid when passed through `validate_username()`. 
Adds tests.

Props gwinhlopez for the initial patch.
Props mordauk, chriscct7.
Fixes #24618.

Built from https://develop.svn.wordpress.org/trunk@34856


git-svn-id: http://core.svn.wordpress.org/trunk@34821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 05:35:25 +00:00
Scott Taylor 99be7beda0 Merge the Responsive Images feature plugin into core, initial commit. See: https://github.com/ResponsiveImagesCG/wp-tevko-responsive-images/ 
New functions in `media.php`:
* `wp_get_attachment_image_srcset_array()` - Returns an array of image candidate string data used to build a `srcset` value for an attachment given an `$attachement_id` and `$size`.
* `wp_get_attachment_image_srcset()` - Returns the `srcset` value for an attachment given an `$attachement_id` and `$size`.
* `wp_get_attachment_image_sizes()` - Returns the `sizes` value for an attachment given an `$attachement_id` and `$size` and optional arguments used to alter its output.
* `wp_make_content_images_responsive()` - A display filter for adding `srcset` and `sizes` to images embedded in content.
* `wp_img_add_srcset_and_sizes()` - A utility function used by `wp_make_content_images_responsive()` to add `srcset` and `sizes` to a single `<img>` element.

Modifies existing core functions:
* Modify `wp_get_attachment_image()` so the HTML returned for an image includes `srcset` and `sizes`.
* Modify `get_media_embedded_in_content()` (sup, 3.6 leftover) by adding `<img>` to the list of accepted tags that can be matched in content. This is used in `wp_make_content_images_responsive()` to find all of the images embedded in content before passing them off to `wp_img_add_srcset_and_sizes()`.

Tests:
* Add a new factory method to `WP_UnitTest_Factory_For_Attachment` named `create_upload_object()`
* Adds unit tests
* Updates unit tests

Props joemcgill, tevko, jaspermdegroot, mdmcginn, barryceelen, peterwilsoncc, fsylum, wonderboymusic, chriscoyier, benjaminpick, jrfnl, #12kingkool68, janhenckens, ryanmarkel, side777, ryelle, wturrell, micahmills, mattbagwell, coliff, DrewAPicture.
See #33641.

Built from https://develop.svn.wordpress.org/trunk@34855


git-svn-id: http://core.svn.wordpress.org/trunk@34820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 04:59:24 +00:00
Drew Jaynes 65133a89c1 Multisite: Introduce `get_subdirectory_reserved_names()`, which returns a filterable list of reserved subdirectory site names. 
The function encapsulates the existing `subdirectory_reserved_names` filter and reduces the maintenance burden of keeping the value of (currently) two instances of the same hook in sync.

See #33615.

Built from https://develop.svn.wordpress.org/trunk@34854


git-svn-id: http://core.svn.wordpress.org/trunk@34819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 04:35:25 +00:00
Scott Taylor 2003bc15ba Multisite: in `wpmu_validate_blog_signup()`, pass `embed` to the array passed to `subdirectory_reserved_names`. 
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34853


git-svn-id: http://core.svn.wordpress.org/trunk@34818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 04:05:24 +00:00
Gary Pendergast 7938e3c1bf Tests: Make the Attachment Slashes tests clean up after itself. 
Fixes #34162.


Built from https://develop.svn.wordpress.org/trunk@34852


git-svn-id: http://core.svn.wordpress.org/trunk@34817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 04:01:24 +00:00
Scott Taylor d96fb9def9 Embeds: move some functions from `media.php` to a new file, `embed-functions.php`, via `svn cp` 
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34851


git-svn-id: http://core.svn.wordpress.org/trunk@34816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 03:59:24 +00:00
Scott Taylor 3ef27f7929 oEmbed: add `embed` to `$subdirectory_reserved_names`. 
Props jeremyfelt.
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34850


git-svn-id: http://core.svn.wordpress.org/trunk@34815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 03:45:25 +00:00
Aaron Jorbin fb624b32ac Fix whitespace issues introduced in [34848] 
Bad Jorbin.

See #33968

Built from https://develop.svn.wordpress.org/trunk@34849


git-svn-id: http://core.svn.wordpress.org/trunk@34814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 03:41:24 +00:00
Aaron Jorbin 55f4da677f HTTP timeouts should cause some tests to be skipped, not failed 
A number of the HTTP external tests can inconstantly fail. As the HTTP API is one that doesn't change often, this failure creates noise. With the goal of increasing the signal from the unit tests, these tests are now skipped if they timeout. A notice is added when running the external http tests so that the developer knows what skipped tests may mean here.

See #33968


Built from https://develop.svn.wordpress.org/trunk@34848


git-svn-id: http://core.svn.wordpress.org/trunk@34813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 03:37:25 +00:00
Scott Taylor 0726babf36 Rewrite: add tests for `add_rewrite_rule()`. 
Props DrewAPicture.
See #16840.

Built from https://develop.svn.wordpress.org/trunk@34847


git-svn-id: http://core.svn.wordpress.org/trunk@34812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 03:36:25 +00:00
Scott Taylor 0c6ee34d00 REST API: add a utility function, `mysql_to_rfc3339()` to `functions.php` 
Background:
6d0ad766ca

Props rmmcue.
See #33982.

Built from https://develop.svn.wordpress.org/trunk@34846


git-svn-id: http://core.svn.wordpress.org/trunk@34811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 03:19:25 +00:00
Scott Taylor f8c3aca01c REST API: add `JsonSerializable()` compatibility interface for PHP <5.4 to `compat.php` 
Props rmmcue.
See #33982.

Built from https://develop.svn.wordpress.org/trunk@34845


git-svn-id: http://core.svn.wordpress.org/trunk@34810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 02:56:24 +00:00
Scott Taylor 5a357a452f REST API: add `json_last_error_msg()` compatibility function for PHP <5.5 to `compat.php` 
Props rmmcue.
See #33982.

Built from https://develop.svn.wordpress.org/trunk@34844


git-svn-id: http://core.svn.wordpress.org/trunk@34809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 02:45:26 +00:00
Drew Jaynes 22ab774617 Docs: Adjust the line wrap indentation on the `$link` parameter description for the `wp_post_revision_title_expanded` hook, introduced in [34842]. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34843


git-svn-id: http://core.svn.wordpress.org/trunk@34808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 01:30:25 +00:00
Helen Hou-Sandí 780926c161 Revisions: Add a `wp_post_revision_title_expanded` filter. 
This allows for content to be added to revision lists, such as in the revisions metabox.

fixes #9681.

Built from https://develop.svn.wordpress.org/trunk@34842


git-svn-id: http://core.svn.wordpress.org/trunk@34807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-06 00:59:27 +00:00
Dominik Schilling 93a5af5753 Image Editor: Merge two error strings. 
Props pavelevap.
See #22623.
Built from https://develop.svn.wordpress.org/trunk@34841


git-svn-id: http://core.svn.wordpress.org/trunk@34806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 22:40:25 +00:00
Jeremy Felt ab5ea42aa2 MS: Pass context to `get_header()` and `get_footer()` in activation/signup. 
Fixes #21712.

Built from https://develop.svn.wordpress.org/trunk@34840


git-svn-id: http://core.svn.wordpress.org/trunk@34805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 22:36:24 +00:00
Dominik Schilling fcc36d1adf Media List Table: Remove the date display in `column_parent()`. 
It should be the time at which the post was written, but it was never because of the missing `$parent` argument.

Fixes #33238.
Built from https://develop.svn.wordpress.org/trunk@34839


git-svn-id: http://core.svn.wordpress.org/trunk@34804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 22:25:26 +00:00
Weston Ruter 0b93819465 Customizer: Ensure `WP_Customize_Setting::update()` returns boolean value. 
Adds unit tests for `WP_Customize_Setting::save()` (and `WP_Customize_Setting::update()`), along with the actions `customize_update_{$type}`, and `customize_save_{$id_base}` which they trigger.

Fixes #34140.

Built from https://develop.svn.wordpress.org/trunk@34838


git-svn-id: http://core.svn.wordpress.org/trunk@34803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 21:58:24 +00:00
John Blackbourn 1e90e58da3 Correct pagination when viewing the 'Mine' link on the post listing screen. 
Fixes #19609
Props ocean90

Built from https://develop.svn.wordpress.org/trunk@34837


git-svn-id: http://core.svn.wordpress.org/trunk@34802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 21:36:25 +00:00
John Blackbourn ab413e89bf Include `post__in` as a value available to the `orderby` parameter in the docs for `WP_Query::parse_query()`. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@34836


git-svn-id: http://core.svn.wordpress.org/trunk@34801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 20:58:29 +00:00
Weston Ruter 31a394fcf7 Customizer: Reset horizontal scroll position when finished dragging a nav menu item. 
Props karinedo, austinginder, adamsilverstein, tyxla.
Fixes #33367.

Built from https://develop.svn.wordpress.org/trunk@34834


git-svn-id: http://core.svn.wordpress.org/trunk@34799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 20:46:27 +00:00
Helen Hou-Sandí 60431ae239 Permalinks: Slightly lengthen the truncated slug for display. 
This brings it closer to the width of the input so there is less jumping around of buttons. We can afford the space now that other buttons in the space are typically no longer there.

fixes #18306.

Built from https://develop.svn.wordpress.org/trunk@34833


git-svn-id: http://core.svn.wordpress.org/trunk@34798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 19:29:24 +00:00
Drew Jaynes 3f747a6395 Revisions: Also pass the `$revision` post object to the `wp_prepare_revision_for_js` filter, introduced in [34541]. 
Props helen.
Fixes #28627.

Built from https://develop.svn.wordpress.org/trunk@34832


git-svn-id: http://core.svn.wordpress.org/trunk@34797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 18:33:28 +00:00
Drew Jaynes a134491455 Docs: Document the `$revision_data` parameter passed to the `wp_prepare_revision_for_js` filter with a hash notation. 
The hook was introduced in [34541].

See #28627.

Built from https://develop.svn.wordpress.org/trunk@34831


git-svn-id: http://core.svn.wordpress.org/trunk@34796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 18:03:26 +00:00
Weston Ruter 31d02887b6 Customizer: Fix moving focus to available nav menu items search. 
Fixes regression introduced in [34219].

Props tyxla.
See #33360.
Fixes #34125 for trunk.

Built from https://develop.svn.wordpress.org/trunk@34829


git-svn-id: http://core.svn.wordpress.org/trunk@34794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 15:27:24 +00:00
Boone Gorges 0e7c1d3b14 Use `wp_installing()` instead of `WP_INSTALLING` constant. 
The `WP_INSTALLING` constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.

A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available.  However, it is possible - notably, during `wpmu_create_blog()` -
for the "installing" flag to be set after WP has already loaded. In these
cases, `WP_INSTALLING` would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where `WP_INSTALLING`
was set the first time a site was created, and remained set for the rest of the
suite.

The new `wp_installing()` function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean `true` or `false`). Use of
the `WP_INSTALLING` constant is still supported; `wp_installing()` will default
to `true` if the constant is defined during the bootstrap.

Props boonebgorges, jeremyfelt.
See #31130.
Built from https://develop.svn.wordpress.org/trunk@34828


git-svn-id: http://core.svn.wordpress.org/trunk@34793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 15:06:28 +00:00
Drew Jaynes aa6fbdaa92 Docs: Add a missing DocBlock summary for `wp_list_widget_controls_dynamic_sidebar()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34827


git-svn-id: http://core.svn.wordpress.org/trunk@34792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 03:06:24 +00:00
Drew Jaynes b1b2ec30e2 Docs: Add missing DocBlock summaries for five functions in wp-admin/includes/template-functions.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34826


git-svn-id: http://core.svn.wordpress.org/trunk@34791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 03:03:25 +00:00
Drew Jaynes 0b332f6d7a Docs: Add missing DocBlock summaries to three functions in wp-admin/includes/plugin.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34825


git-svn-id: http://core.svn.wordpress.org/trunk@34790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 02:55:24 +00:00
Drew Jaynes 4c2203b370 Docs: Add missing summaries for functions in wp-admin/includes/misc.php. 
Also restructures the summary for `update_home_siteurl()`.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34824


git-svn-id: http://core.svn.wordpress.org/trunk@34789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 02:52:24 +00:00
Drew Jaynes 2de4cc7149 Docs: Add missing DocBlock summaries for a multitude of functions in wp-admin/includes/media.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34823


git-svn-id: http://core.svn.wordpress.org/trunk@34788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 02:44:25 +00:00
Drew Jaynes 3866a8cf58 Docs: Add missing method summaries for the deprecated `WP_User_Search` class, including `prepare_query()`, `query()`, `prepare_vars_for_template_usage()`, `do_paging()`, and `get_results()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34822


git-svn-id: http://core.svn.wordpress.org/trunk@34787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 02:35:25 +00:00
Drew Jaynes 1f1c2335ad Docs: Add missing summaries for three deprecated admin functions: `dropdown_categories()`, `dropdown_link_categories()`, and `wp_dropdown_cats()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34821


git-svn-id: http://core.svn.wordpress.org/trunk@34786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 02:29:26 +00:00
Sergey Biryukov a285a1cf22 Use `home_url()` instead of `get_option( 'siteurl' )` in notifications that are sent when a user's email address or password is changed. 
Props tyxla, ramay.
Fixes #34071.
Built from https://develop.svn.wordpress.org/trunk@34820


git-svn-id: http://core.svn.wordpress.org/trunk@34785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-04 23:03:26 +00:00
Jeremy Felt a8771a3914 MS: Populate `site_name` property in a new `WP_Network`. 
This allows us to reduce some extra handling in `ms-settings.php`. Requires [34777].

Props johnjamesjacoby for the initial patch.
See #31985.

Built from https://develop.svn.wordpress.org/trunk@34819


git-svn-id: http://core.svn.wordpress.org/trunk@34784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-04 20:51:25 +00:00
Drew Jaynes 6650dfea4f Docs: Document the plugin data array returned by `get_plugin_data()` with a hash-notation. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34818


git-svn-id: http://core.svn.wordpress.org/trunk@34783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-04 19:06:27 +00:00
Drew Jaynes f6948c38fa Widgets: Add more tests for registering and unregistering sidebars with 1) no ID, 2) a string ID, 3) a numeric ID. 
See #17078.

Built from https://develop.svn.wordpress.org/trunk@34817


git-svn-id: http://core.svn.wordpress.org/trunk@34782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-04 05:23:24 +00:00
Drew Jaynes a0c6f8cca2 Widgets: Add tests for `dynamic_sidebar()` where sidebars were registered with 1) no supplied ID, 2) a numeric ID, 3) a string ID. 
See #17078.

Built from https://develop.svn.wordpress.org/trunk@34816


git-svn-id: http://core.svn.wordpress.org/trunk@34781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-04 04:44:27 +00:00
Boone Gorges 1438ad7bb8 Rechristen the `get_page_of_comment` filter. 
See [34808].

Props DrewAPicture, SergeyBiryukov.
Fixes #13939.
Built from https://develop.svn.wordpress.org/trunk@34815


git-svn-id: http://core.svn.wordpress.org/trunk@34780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 22:43:27 +00:00
Jeremy Felt 908b1f0b7d MS: Align HTML structure in `wp-signup.php` and `wp-activate.php`. 
Assigns the `wp-activate-container` and `wp-signup-container` to the container inside `#signup-container` on each. This container already existed in `wp-signup.php` and is new in `wp-activate.php`.

Props ocean90.
Fixes #25478.

Built from https://develop.svn.wordpress.org/trunk@34814


git-svn-id: http://core.svn.wordpress.org/trunk@34779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 21:51:25 +00:00
Drew Jaynes b453c9e976 Users: Don't pass the current `WP_Users_List_Table` or `WP_MS_Users_List_Table` instance to the `users_list_table_query_args` filter after all. 
After some discussion, it was decided that Multisite vs single site context can just as easily be derived using available functions like `is_network_admin()`, `get_current_screen()`, etc., rendering the second parameter moot. The hook was introduced in [34796].

Fixes #25360.

Built from https://develop.svn.wordpress.org/trunk@34813


git-svn-id: http://core.svn.wordpress.org/trunk@34778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 21:49:24 +00:00
Boone Gorges f08e5c2d80 Update the taxonomy relationship cache in `is_object_in_term()`. 
This function attempts to read from the relationship cache, and uses any data
it finds. If it finds no data, it does a query for the data it needs. Since we
are going to the trouble to query for the relationships, and since we are
already using cached data when available, let's go ahead and cache it for
later use.

Props joehoyle, boonebgorges.
Fixes #32044.
Built from https://develop.svn.wordpress.org/trunk@34812


git-svn-id: http://core.svn.wordpress.org/trunk@34777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 21:19:23 +00:00
Boone Gorges 5be41d618f Don't prime term meta cache in `is_object_in_term()`. 
Term meta is not necessary in this case, so priming the cache wastes a query.

See #10142, #32044.
Built from https://develop.svn.wordpress.org/trunk@34811


git-svn-id: http://core.svn.wordpress.org/trunk@34776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 21:07:24 +00:00
Drew Jaynes c1fc5e79c8 Tests: Permalink Structures Phase II: DRY up logic for setting permalink structures in test methods. 
Renames `reset_permalinks()` to `set_permalink_structure()` (mimicking `$wp_rewrite->set_permalink_structure()`) and allows it to accept an optional permalink structure. In this way, we can double dip using it to both set and reset the permalink structure from anywhere.

Removes alot of duplicated code from tests.

See #33968.

Built from https://develop.svn.wordpress.org/trunk@34810


git-svn-id: http://core.svn.wordpress.org/trunk@34775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 20:55:24 +00:00
Boone Gorges 28625bfc38 When creating terms, avoid false dupe checks due to accented characters. 
`wp_insert_term()` doesn't allow the creation of a term when the term `name`
is the same as another term in the same hierarchy level of the same taxonomy.
Previously, this duplicate check used `get_term_by( 'name' )`, which uses the
database collation to determine sameness. But common collations do not
distinguish between accented and non-accented versions of a character. As a
result, it was impossible to create a term 'Foo' if a sibling term with an
accented character existed.

We address this problem by using `get_terms()` to do the duplicate check. This
query returns all potentially matching terms. We then do a stricter check
for equivalence in PHP, before determining whether one of the matches is
indeed a duplicate.

Props boonebgorges, tyxla, geza.miklo, mehulkaklotar.
Fixes #33864.
Built from https://develop.svn.wordpress.org/trunk@34809


git-svn-id: http://core.svn.wordpress.org/trunk@34774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 20:25:26 +00:00
Boone Gorges 32dda547c1 Introduce 'page_of_comment' filter. 
This filter allows developers to modify the output of `get_page_of_comment()`.

As a side effect of this new filter, comment page numbers will always be
returned as integers. Previously, they would sometimes be returned as floats -
eg `float(2.0)` instead of `int(2)`.

Props laceous.
See #13939.
Built from https://develop.svn.wordpress.org/trunk@34808


git-svn-id: http://core.svn.wordpress.org/trunk@34773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 19:39:25 +00:00
Drew Jaynes 6f2d3fea3b Tests: Last try: It's redundant to reset permalinks on `tearDown()` if we're already doing it on every `setUp()`. 
Removes the restoration logic, which leveraged a static property initialized with `get_option()`.

See #33968.

Built from https://develop.svn.wordpress.org/trunk@34807


git-svn-id: http://core.svn.wordpress.org/trunk@34772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 19:27:26 +00:00
Boone Gorges 25e7ad64cf Use 'comments_per_page' option as fallback in `get_page_of_comment()`. 
The function now uses the following order of precedence when calculating
comment pagination: 1. the 'per_page' value passed in the `$args` array,
2. the 'comments_per_page' query var in `$wp_query`, and 3. the
'comments_per_page' setting from options-discussion.php. This change allows
`get_page_of_comment()` to return an accurate value before the main query
has been run.

Props laceous.
See #13939.
Built from https://develop.svn.wordpress.org/trunk@34806


git-svn-id: http://core.svn.wordpress.org/trunk@34771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 19:26:24 +00:00
Boone Gorges cd5cd380e8 Only count top-level comments when calculating threaded pagination. 
The change in [34535] did not properly account for threading.

See #13939, #11334.
Built from https://develop.svn.wordpress.org/trunk@34805


git-svn-id: http://core.svn.wordpress.org/trunk@34770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 19:16:24 +00:00
Boone Gorges 198dee542d Ensure that `WP_User_Query` vars are filled after 'pre_get_users'. 
This prevents notices from being thrown when a 'pre_get_users' callback
removes required values from the list of `query_vars`.

For backward compatibility with previous uses of 'pre_get_users', default
values are parsed both before and after the action is fired.

Fixes #33449.
Built from https://develop.svn.wordpress.org/trunk@34804


git-svn-id: http://core.svn.wordpress.org/trunk@34769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 18:45:25 +00:00
Drew Jaynes 86f8dedf68 Tests: Move the global permalinks reset routine to only fire when running core tests. 
Should fix intermittent mysqli response errors in the AJAX tests.

See #33968.

Built from https://develop.svn.wordpress.org/trunk@34803


git-svn-id: http://core.svn.wordpress.org/trunk@34768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 18:36:26 +00:00
Drew Jaynes a127d95c89 Tests: Introduce `WP_UnitTestCase::reset_permalinks()`, an attempt to DRY up logic for resetting and restoring default permalinks on `setUp()` and `tearDown()`. 
See #33968.

Built from https://develop.svn.wordpress.org/trunk@34802


git-svn-id: http://core.svn.wordpress.org/trunk@34767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 17:15:24 +00:00
Sergey Biryukov 4f709678fb Add missing unit tests from [34799]. 
Props johnbillion.
See #34059.
Built from https://develop.svn.wordpress.org/trunk@34801


git-svn-id: http://core.svn.wordpress.org/trunk@34766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 15:10:25 +00:00
Sergey Biryukov 3792591dfb Add `single-{post_type}-{post_name}.php` to the top of the template hierarchy for single posts. 
This is consistent with page and taxonomy templates, which support slugs as well.

Props ericjuden, johnbillion.
Fixes #18859.
Built from https://develop.svn.wordpress.org/trunk@34800


git-svn-id: http://core.svn.wordpress.org/trunk@34765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 15:00:25 +00:00
Sergey Biryukov 9dc1a858f8 Abstract functionality from `wp-comments-post.php` into a function, `wp_handle_comment_submission()`. 
Add unit tests.

Props johnbillion.
Fixes #34059.
Built from https://develop.svn.wordpress.org/trunk@34799


git-svn-id: http://core.svn.wordpress.org/trunk@34764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 14:47:26 +00:00
Sergey Biryukov 0aacea6535 Merge some strings with the same meaning in `wp-includes/class-wp-xmlrpc-server.php`. 
Props pavelevap.
Fixes #33644.
Built from https://develop.svn.wordpress.org/trunk@34798


git-svn-id: http://core.svn.wordpress.org/trunk@34763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 14:09:43 +00:00
Sergey Biryukov 6b71b2304b Merge some strings in `wp-admin/upload.php` with existing strings with the same meaning. 
Props pavelevap.
Fixes #31727.
Built from https://develop.svn.wordpress.org/trunk@34797


git-svn-id: http://core.svn.wordpress.org/trunk@34762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 13:57:27 +00:00
Drew Jaynes b38569a5fc Users: Introduce the `users_list_table_query_args` filter, for modifying the `WP_User_Query` arguments used within the `prepare_items()` methods in the users list tables. 
The current list table is passed as a second parameter, `$this`, and can take the form of either a `WP_Users_List_Table` or `WP_MS_Users_List_Table` instance depending on the context in which the filter was evaluated.

Props juliobox for the initial patch.
Fixes #25360.

Built from https://develop.svn.wordpress.org/trunk@34796


git-svn-id: http://core.svn.wordpress.org/trunk@34761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 07:24:25 +00:00
Boone Gorges f6b2797bd3 Remove `search_terms` from `WP_Query` doc block. 
It's not actually a query param.

Introduced in [28887].
Built from https://develop.svn.wordpress.org/trunk@34795


git-svn-id: http://core.svn.wordpress.org/trunk@34760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 04:36:27 +00:00
Sergey Biryukov d6865505d5 Respect the `force_delete` parameter of `get_delete_post_link()`. 
Previously, it only worked if `EMPTY_TRASH_DAYS` was disabled.

Props johnbillion, chriscct7.
Fixes #26832.
Built from https://develop.svn.wordpress.org/trunk@34794


git-svn-id: http://core.svn.wordpress.org/trunk@34759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 01:50:25 +00:00
John Blackbourn 5e98b20e84 Adjust `_default_wp_die_handler()` formatting so it doesn't confuse Sublime Text's parsing and syntax highlighting. 
Fixes #34135

Built from https://develop.svn.wordpress.org/trunk@34793


git-svn-id: http://core.svn.wordpress.org/trunk@34758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 01:32:24 +00:00
Boone Gorges ca86a8a404 Remove dead code added to `get_comment_link()` in [34735]. 
See #34073.
Built from https://develop.svn.wordpress.org/trunk@34792


git-svn-id: http://core.svn.wordpress.org/trunk@34757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 01:27:24 +00:00
Sergey Biryukov 1137b70ef3 Twenty Fifteen: Document the `'twentyfifteen_color_schemes'` filter. 
Props DrewAPicture.
Fixes #34119.
Built from https://develop.svn.wordpress.org/trunk@34791


git-svn-id: http://core.svn.wordpress.org/trunk@34756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 01:10:26 +00:00
John Blackbourn cf5ac0b6bf Use `wp_login_url()` for login links when signing up for a new blog or activating a new blog on Multisite. 
Fixes #31495
Props GregLone for the intial patch

Built from https://develop.svn.wordpress.org/trunk@34790


git-svn-id: http://core.svn.wordpress.org/trunk@34755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 00:34:25 +00:00
Weston Ruter d9cca27386 Customize: Fix `nav_menu_item` CSS `classes` array being incorrectly presented in input field as comma-delimited list. 
Instead of using `Array.toString()` to serialize an array with comma delimiters, explicitly `join` the array using spaces instead. Also ensure that `xfn` is handled properly if it ever gets stored as an array. 

Props tyxla, westonruter.
Fixes #34111.

Built from https://develop.svn.wordpress.org/trunk@34788


git-svn-id: http://core.svn.wordpress.org/trunk@34753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-03 00:15:24 +00:00
John Blackbourn 27dbbdfba4 Introduce a `register_taxonomy_args` filter for filtering the arguments passed when calling `register_taxonomy()`. This is the taxonomy equivalent of the newly introduced `register_post_type_args` filter. 
Fixes #33990
Props tyxla for initial patch

Built from https://develop.svn.wordpress.org/trunk@34787


git-svn-id: http://core.svn.wordpress.org/trunk@34752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 23:57:25 +00:00
John Blackbourn 9bc54c9442 Remove the unnecessary dynamic prefix used in the `plugin_action_links` filter name, and in those of its brethren. This way, `network_admin_plugin_action_links` gets listed as a separate filter. 
Fixes #34117

Built from https://develop.svn.wordpress.org/trunk@34786


git-svn-id: http://core.svn.wordpress.org/trunk@34751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 23:44:26 +00:00
John Blackbourn 9d7d1508e2 Add VideoPress as a trusted oEmbed provider. 
Fixes #34031
Props kraftbj

Built from https://develop.svn.wordpress.org/trunk@34785


git-svn-id: http://core.svn.wordpress.org/trunk@34750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 23:20:28 +00:00
John Blackbourn 939ef7887e `shttp` is not a protocol. 
See #27115

Built from https://develop.svn.wordpress.org/trunk@34784


git-svn-id: http://core.svn.wordpress.org/trunk@34749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 22:48:26 +00:00
John Blackbourn 815635548a Switch the remaining user-facing links to wordpress.org over to HTTPS. 
Fixes #27115

Built from https://develop.svn.wordpress.org/trunk@34783


git-svn-id: http://core.svn.wordpress.org/trunk@34748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 22:46:28 +00:00
Drew Jaynes 6f7a298c18 Docs: Fix the placement and ordering of some `@since` tags following [34780]. 
See #12133. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34782


git-svn-id: http://core.svn.wordpress.org/trunk@34747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 20:50:25 +00:00
Drew Jaynes bfa2a5295e Docs: Improve a variety of inline docs in wp-includes/l10n.php. 
* Corrects phrasing used in the descriptions for and filters in `_n()` and `_nx()`, particularly with regard to the use of 'singular' instead of 'single' or '1', and 'plural' instead of 'not 1'.
* Adds example usage to `_n()`, `_nx()`, `_nx_noop()`, and `translate_nooped_plural()`.
* Adds hash notation `@return` doc for `_n_noop()` and `_nx_noop()`.
* Adds missing default values for the optional `$domain` parameter in several places.

Props johnbillion.
Fixes #34127.

Built from https://develop.svn.wordpress.org/trunk@34781


git-svn-id: http://core.svn.wordpress.org/trunk@34746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 20:45:24 +00:00
John Blackbourn 7707dbf862 Introduce support for array format field names in `WP_Widget::get_field_name()` and `WP_Widget::get_field_id()`. 
Fixes #12133
Props ch1902, welcher

Built from https://develop.svn.wordpress.org/trunk@34780


git-svn-id: http://core.svn.wordpress.org/trunk@34745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 20:24:24 +00:00
Jeremy Felt dba5a73119 Docs: Add deprecation note for `$use_cache` in `get_site_option()`. 
Props johnbillion.
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34779


git-svn-id: http://core.svn.wordpress.org/trunk@34744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 19:32:30 +00:00
Jeremy Felt 54512d64cb MS: Use `*_network_option()` functions throughout core. 
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34778


git-svn-id: http://core.svn.wordpress.org/trunk@34743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 19:08:26 +00:00
Jeremy Felt 3c2273ef45 MS: Introduce `*_network_option` functions. 
Introduces `add_network_option()`, `update_network_option()`, `get_network_option()`, and `delete_network_option()`, which use the internals previously found in the `*_site_option()` functions and allow for a network ID to enable cross network storage and retrieval of network options.

* `*_site_option()` functions are now wrappers for `*_network_option()` and will interact with options for the current network in a multisite environment.
* All will continue to fallback to `*_option()` for non-multisite uses.
* Adds basic tests for cross network storage and retrieval.
* Existing tests for `*_site_option()` functions provide coverage for storage and retrieval of current network options.

Props spacedmonkey, DrewAPicture, jeremyfelt.
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34777


git-svn-id: http://core.svn.wordpress.org/trunk@34742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 18:01:27 +00:00
Aaron Jorbin 0da3150609 Add PHP Nightlies to the test suite 
PHP branched master for 7, which means that nightly builds are now technically 7.1. The difference is minimal at the moment, but it's a good idea for us to test against the nightly build in part so that regressions can be reported upstream. Nightlies are allowed failure so that the build doesn't go red due to unstable versions. Additionally, nightlies are not officially supported by WordPress Core.

See #33410

Built from https://develop.svn.wordpress.org/trunk@34776


git-svn-id: http://core.svn.wordpress.org/trunk@34741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 16:51:28 +00:00
Boone Gorges d3dd6a93e8 More explicit tests for `image_get_intermediate_size()`. 
After [33807], `Tests_Image_Intermediate_Size::test_get_intermediate_sizes_by_array_zero_width()`
was failing intermittently. This failure was due to the use of a random number
for the image height. When the height was sufficiently large - $height >= 202 -
to change the aspect ratio of the cropped image (based on WP's threshold of a
1px difference), the test passed. And when the height was exactly 200, the
medium image size was hit exactly. The failure occurred only with a height of
201, which is close enough to 200 so that WP determined that the aspect ratio
of the potential crop was close enough to match.

The current changeset splits the test into two, in order to demonstrate the
failure.

See #17626. Fixes #34087.
Built from https://develop.svn.wordpress.org/trunk@34775


git-svn-id: http://core.svn.wordpress.org/trunk@34740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 14:14:24 +00:00
Boone Gorges 1b91e135a1 Pinking shears in shortcode test file. 
Built from https://develop.svn.wordpress.org/trunk@34774


git-svn-id: http://core.svn.wordpress.org/trunk@34739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 13:52:14 +00:00
Boone Gorges 334fe04832 Improvements to PCRE benchmarking tests. 
* Add test file accidentally omitted from [34761].
* Bail properly from benchmarker when a `preg_last_error()` is found.

Props miqrogroove.
See #34121.
Built from https://develop.svn.wordpress.org/trunk@34773


git-svn-id: http://core.svn.wordpress.org/trunk@34738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 13:51:50 +00:00
Boone Gorges 4265fa897a Fix `preg_match_all()` syntax in PCRE benchmark test util. 
In versions of PHP earlier than 5.4, the `$matches` parameter was required.
Excluding it here meant that PCRE benchmarking tests were erroring on older
versions of PHP without cleaning up the PCRE ini settings, causing various
problems on later tests.

Props miqrogroove, dd32, boonebgorges.

And to the cosmic forces that cause bugs like this. The best part of waking up
is diagnosing leakage between automated tests.

See #34121.
Built from https://develop.svn.wordpress.org/trunk@34772


git-svn-id: http://core.svn.wordpress.org/trunk@34737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 13:51:26 +00:00
Dion Hulse 19ee18ccc2 Skip two `wp_json_encode()` tests when mbstring is unavailable. 
Built from https://develop.svn.wordpress.org/trunk@34771


git-svn-id: http://core.svn.wordpress.org/trunk@34736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 08:55:26 +00:00
Drew Jaynes c6bbcdb256 Docs: Remove documentation for a phantom parameter not actually passed to the `is_email` filter. 
The documentation error was introduced in [26485].

Props chrisvendiadvertisingcom.
Fixes #34097.

Built from https://develop.svn.wordpress.org/trunk@34770


git-svn-id: http://core.svn.wordpress.org/trunk@34735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 07:03:25 +00:00
Drew Jaynes a3ead57e90 Introduce the `wp_add_nav_menu_item` action, fired immediately after a new nav menu item has been added. 
This hook can be leveraged both for the legacy menus interface and the menus integration in the Customizer, as both use the containing function, `wp_update_nav_menu_item()`.

Props MikeHansenMe, tyxla.
Fixes #30983.

Built from https://develop.svn.wordpress.org/trunk@34769


git-svn-id: http://core.svn.wordpress.org/trunk@34734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 06:46:24 +00:00
Drew Jaynes e6da469a20 Docs: Fix a few syntatical issues with inline documentation in wp-includes/post-template.php. 
Props welcher.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@34768


git-svn-id: http://core.svn.wordpress.org/trunk@34733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 06:38:26 +00:00
Scott Taylor 08ab8bad4b Unit Tests: when `wp_using_ext_object_cache()`, mark some transient tests as skipped. 
Props ocean90.
See #31491.

Built from https://develop.svn.wordpress.org/trunk@34767


git-svn-id: http://core.svn.wordpress.org/trunk@34732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 05:10:25 +00:00
Scott Taylor 8d1161392a Unit Tests: tests that want to flush the cache should use their instance method instead of calling `wp_cache_flush()` - more properties need to be wiped out in between tests. 
Props ocean90.
See #31491.

Built from https://develop.svn.wordpress.org/trunk@34766


git-svn-id: http://core.svn.wordpress.org/trunk@34731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 05:09:25 +00:00
Scott Taylor 51cdca0906 Unit Tests: in `Tests_Cache::test_wp_cache_init()`, when `wp_using_ext_object_cache()`, just check that the global is an instance of `WP_Object_Cache`. External object cache instances of `WP_Object_Cache` will contain resources as props that will always have differing internal IDs, so strict comparison won't work. 
See #31491.

Built from https://develop.svn.wordpress.org/trunk@34765


git-svn-id: http://core.svn.wordpress.org/trunk@34730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 05:06:24 +00:00
Drew Jaynes 769ad80521 Docs: Also clarify the expected element types depending on the value of `$action` in the hook doc for the `plugins_api` filter. 
See [34763] for context.

See #34035.

Built from https://develop.svn.wordpress.org/trunk@34764


git-svn-id: http://core.svn.wordpress.org/trunk@34729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 04:52:25 +00:00
Drew Jaynes 8478a1341b Docs: Clarify the expected replacement element type if replacing the object or array in `plugins_api()` via the `plugins_api` hook. 
If the `$action` type is 'query_plugins' or 'plugin_information', the API will return an object, thus an object should be passed if replacing it. For 'hot_tags' and 'hot_categories', the same logic applies, but with arrays instead.

See #34035.

Built from https://develop.svn.wordpress.org/trunk@34763


git-svn-id: http://core.svn.wordpress.org/trunk@34728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 04:48:25 +00:00
Scott Taylor 5c6c4e3713 Posts: In `wp_insert_post()`, don't set `post_date` to current time if it can be derived from a passed value for `post_date_gmt`. 
Adds unit tests.

Props oso96_2000, kawauso.
Fixes #15946.

Built from https://develop.svn.wordpress.org/trunk@34762


git-svn-id: http://core.svn.wordpress.org/trunk@34727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 04:36:24 +00:00
Scott Taylor 7a0f8602f3 Shortcodes/Formatting: Add PCRE Performance Testing 
* Move pattern from `wptexturize()` into a separate function.
* Move pattern from `wp_html_split()` into a separate function.
* Beautify code for `wp_html_split()`.
* Remove unnecessary instances of `/s` modifier in patterns that don't use dots.
* Add `tests/phpunit/data/formatting/whole-posts.php` for testing larger strings.
* Add function `benchmark_pcre_backtracking()`.
* Add tests for `wp_html_split()`.
* Add tests for `wptexturize()`.
* Add tests for `get_shortcode_regex()`.

Props miqrogroove.
Fixes #34121.

Built from https://develop.svn.wordpress.org/trunk@34761


git-svn-id: http://core.svn.wordpress.org/trunk@34726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 04:26:25 +00:00
Scott Taylor da1c938a5c Plugins: on the Install page, move the name of each plugin into the `<h4>` to accommodate screen readers. 
Props afercia, ChrisMKindred.
Fixes #32400.

Built from https://develop.svn.wordpress.org/trunk@34760


git-svn-id: http://core.svn.wordpress.org/trunk@34725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 04:16:27 +00:00
Jeremy Felt ddc1670e90 Tests: Clarify site option tests storing and retrieving serialized data. 
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34759


git-svn-id: http://core.svn.wordpress.org/trunk@34724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 02:06:26 +00:00
Jeremy Felt 8908480594 Tests: Split `test_default_filter()` Site Option test into multiple tests. 
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34758


git-svn-id: http://core.svn.wordpress.org/trunk@34723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 01:56:26 +00:00
Jeremy Felt a7a239b39b Tests: Split `test_the_basics()` Site Option test into many tests. 
Many assertions in one test are now many tests with one assertion.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@34757


git-svn-id: http://core.svn.wordpress.org/trunk@34722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 01:33:50 +00:00
Jeremy Felt e2c6216b21 MS: Remove `@todo` for `ms_protect_special_option()` from `delete_site_option()`. 
This todo has been in place since the original merge of MU. At the time of merge, `wpmu_protect_special_option()` protected an empty array, and there has been no noticeable need since. As we introduce `_network_option()`, let's leave this behind. A new ticket can be opened if necessary.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@34756


git-svn-id: http://core.svn.wordpress.org/trunk@34721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 22:46:28 +00:00
John Blackbourn ea28454867 Deprecate `get_admin_users_for_domain()`. This function has never been used in core. 
Fixes #34122

Built from https://develop.svn.wordpress.org/trunk@34755


git-svn-id: http://core.svn.wordpress.org/trunk@34720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 22:27:24 +00:00
John Blackbourn f33c6a6650 This function is blessed. 
Built from https://develop.svn.wordpress.org/trunk@34754


git-svn-id: http://core.svn.wordpress.org/trunk@34719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 22:24:24 +00:00
John Blackbourn d0d9e4c8d8 Deprecate `create_empty_blog()`. This function has never been used in core. 
Fixes #34120

Built from https://develop.svn.wordpress.org/trunk@34753


git-svn-id: http://core.svn.wordpress.org/trunk@34718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 22:10:26 +00:00
Dominik Schilling 25b1dd594a Install: Replace the "Privacy" setting with the "Search Engine Visibility" setting from Reading Settings. 
Props Clorith, ocean90.
Fixes #27628.
See #16416.
Built from https://develop.svn.wordpress.org/trunk@34752


git-svn-id: http://core.svn.wordpress.org/trunk@34717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 21:35:25 +00:00
Dominik Schilling 18413f3e81 Upgrader: Clear plugin/theme caches directly after a plugin/theme has been installed. 
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.

Fixes #34029.
Built from https://develop.svn.wordpress.org/trunk@34751


git-svn-id: http://core.svn.wordpress.org/trunk@34716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 21:21:25 +00:00
Jeremy Felt 7c7eee01ef MS: Remove registration of ID column in Sites and Users list tables. 
Reverts a portion of [34289] and leaves the render for the column behind. A plugin can register these fields for display via filter.

Fixes #18661.

Built from https://develop.svn.wordpress.org/trunk@34750


git-svn-id: http://core.svn.wordpress.org/trunk@34715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 20:58:24 +00:00
Jeremy Felt f69396c229 MS: Provide better UI when a main site's `/blog` prefix is changed. 
The main site on a new network is forced by default into using `/blog` as the prefix for its permalink structure. This can be changed easily through the network admin, though the `options-permalink.php` screen is then unusable to make further changes to the structure.

Now, if `/blog/` is not at the beginning of the `permalink_structure` option, we do not force `/blog` as a prefix in the UI.

Fixes #12002.

Built from https://develop.svn.wordpress.org/trunk@34749


git-svn-id: http://core.svn.wordpress.org/trunk@34714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 20:39:24 +00:00
Dominik Schilling 113a9d4517 Language Upgrader: Re-use the automatic upgrader skin if the parent upgrader is using it. 
Prevents broken Ajax responses when `Language_Pack_Upgrader::async_upgrade()` gets triggered during a shiny update.

Fixes #34048.
Built from https://develop.svn.wordpress.org/trunk@34748


git-svn-id: http://core.svn.wordpress.org/trunk@34713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 20:25:26 +00:00
Scott Taylor 99347fd96e Shortcodes: Fix PCRE performance bugs in `get_shortcode_regexp()` and related to `wptexturize()`, `do_shortcode()`, and `strip_shortcodes()` 
Alters unit tests.

Props miqrogroove.
Fixes #33517.

Built from https://develop.svn.wordpress.org/trunk@34747


git-svn-id: http://core.svn.wordpress.org/trunk@34712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 18:05:25 +00:00
Drew Jaynes a985977856 Docs: Update the argument descriptions for `$child_of` and `$hierarchical` in `get_pages()` to more closely reflect expected behavior. 
See #18701. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34746


git-svn-id: http://core.svn.wordpress.org/trunk@34711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 17:40:25 +00:00
Scott Taylor d8179a2a1f Shortcodes: prevent registration of invalid shortcode names. 
Adds unit tests.

Props miqrogroove.
Fixes #34090.

Built from https://develop.svn.wordpress.org/trunk@34745


git-svn-id: http://core.svn.wordpress.org/trunk@34710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 17:34:24 +00:00
Scott Taylor 82f244414e Shortcodes: clarify the `@return` docs for `shortcode_parse_atts()`. 
Props miqrogroove.
See #23307.

Built from https://develop.svn.wordpress.org/trunk@34744


git-svn-id: http://core.svn.wordpress.org/trunk@34709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 17:32:26 +00:00
Andrea Fercia 0acededa82 In `wp_comment_reply()` change the H5 headings in fieldset legends for better accessibility. 
Also, add a "Edit Comment" legend before the Quick Edit form to pair it with "Reply to Comment" and "Add new Comment" and move the Name, Email, and URL fields after the Comment textarea.

Props joedolson, afercia.

Fixes #33757.
Built from https://develop.svn.wordpress.org/trunk@34743


git-svn-id: http://core.svn.wordpress.org/trunk@34708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 14:52:25 +00:00
Andrea Fercia 5a2627d38a Bump H3 headings to H2 on the Network Site Users screen for better accessibility. 
Fixes #34081.
Built from https://develop.svn.wordpress.org/trunk@34742


git-svn-id: http://core.svn.wordpress.org/trunk@34707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 14:33:26 +00:00
Boone Gorges 8be90670f3 Make sure permastruct is set in `comments_template()` tests. 
After [34735].
Built from https://develop.svn.wordpress.org/trunk@34741


git-svn-id: http://core.svn.wordpress.org/trunk@34706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 12:27:29 +00:00
Dion Hulse dc9203d753 Rewrite `insert_with_markers()` to use `flock()` when available, significant cleanup of the function too. 
The call to `flock()` is an exclusive advisory lock, which in my testing only PHP respects (apache continues to read it).
Not all filesystems support locking (remote NFS mounts for example) so this offers minimal benefit to those platforms, but offers much better protection against file corruption on systems which do support it.
The call is blocking, so a second process will wait for the first to complete before writing if supported.

See #31767

Built from https://develop.svn.wordpress.org/trunk@34740


git-svn-id: http://core.svn.wordpress.org/trunk@34704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 07:46:27 +00:00
Dion Hulse a4c41f6ee4 Updates: SSH2 Transport: Add a connection error when the SFTP subsystem cannot be initialized. 
Fixes #33478

Built from https://develop.svn.wordpress.org/trunk@34739


git-svn-id: http://core.svn.wordpress.org/trunk@34703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:43:25 +00:00
Dion Hulse d8aaf01b97 Updates: SSH2 Transport: Use a work around to avoid a bug where PHP's SSH2 extension fails to list the contents of the `/` directory. 
This fixes issues where SSH2 with chrooted environments runs into a `Unable to locate WordPress Content directory (wp-content).` error.

The workaround is to simply list the contents of the `/./` directory instead of `/`.

Fixes #33919

Built from https://develop.svn.wordpress.org/trunk@34738


git-svn-id: http://core.svn.wordpress.org/trunk@34702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:40:25 +00:00
Gary Pendergast 3942226c90 WPDB: Allow `null` values in the CRUD functions. 
Specifically, `::insert()`, `::replace()`, `::update()`, and `::delete()` can now set a column to `NULL`, or add the `IS NULL` condition to the `WHERE` clause.

This is based on [backpress 279].

Props pento, nbachiyski, sorich87.

Fixes #15158.


Built from https://develop.svn.wordpress.org/trunk@34737


git-svn-id: http://core.svn.wordpress.org/trunk@34701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:37:26 +00:00
Dion Hulse 9caa7c4ba7 Press This: Make the regular expressions for matching images easier to read by not requiring escaping. 
Fixes #32878

Built from https://develop.svn.wordpress.org/trunk@34736


git-svn-id: http://core.svn.wordpress.org/trunk@34700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:16:25 +00:00
Boone Gorges b23fdba5a2 Ensure that comment permalinks reflect pagination. 
After [34561], `wp_list_comments()` no longer passed all of a post's comments
to `Walker_Comments`. As a result, calls to `get_comment_link()` occurring
inside the comment loop had insufficient context to determine the proper
'cpage' value to use when generating comment permalinks. This, in turn, caused
comment permalinks to behave erratically.

The current changeset addresses the problem as follows:

* `get_comment_link()` now accepts a 'cpage' parameter. When present, 'cpage' will be used to build the comment permalink - no automatic calculation will take place.
* When called within the main loop, `wp_list_comments()` calculates the proper 'cpage' value for comments in the loop, and passes it down to `get_comment_link()`.
* `cpage` and `comment-page-x` query vars are generally required in comment permalinks (see #34068), but an exception is made when 'default_comment_page=oldest': the bare post permalink will always be the same as `cpage=1`, so `cpage` is excluded in this case.

Props peterwilsoncc for assiduous spreadsheeting.
Fixes #34073.
Built from https://develop.svn.wordpress.org/trunk@34735


git-svn-id: http://core.svn.wordpress.org/trunk@34699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:13:25 +00:00
Scott Taylor b97dd529fa Canonical: remove unused code (commented-out) from `redirect_canonical()`. 
Props hakre, chriscct7.
Fixes #16934.

Built from https://develop.svn.wordpress.org/trunk@34734


git-svn-id: http://core.svn.wordpress.org/trunk@34698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:09:50 +00:00
Dion Hulse 731b51ee7f Updates: Try a more compatible method to detect if a file exists when using the FTP Extension. 
This change causes it to list the parent directories files, and assets that the node exists within the returned listing, this is a little more compatible than relying upon the FTP server to correctly filter the returned resultset to the specific file/node being requested.
Fixes #28013

Built from https://develop.svn.wordpress.org/trunk@34733


git-svn-id: http://core.svn.wordpress.org/trunk@34697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 05:09:25 +00:00
Boone Gorges 51ddf2ca9c Correct some `WP_Query` metadata lazyloading docs. 
Props dlh.
Fixes #34047.
Built from https://develop.svn.wordpress.org/trunk@34732


git-svn-id: http://core.svn.wordpress.org/trunk@34696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 04:01:48 +00:00
Boone Gorges 80654eb17a s/`add_action()`/`add_filter()` in `WP_Query` metadata lazyloading. 
Props dlh.
See #34047.
Built from https://develop.svn.wordpress.org/trunk@34731


git-svn-id: http://core.svn.wordpress.org/trunk@34695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 04:01:24 +00:00
Boone Gorges b2f253fc8e Prevent extra db queries in `WP_Comment::get_children()`. 
`WP_Comment_Query::fill_descendants()` queries for a comment tree in a way that
minimizes database overhead, and places the located descendants with their
proper parents. However, it doesn't touch leaf nodes - comments with no
children - so future calls to `get_children()` on those comment objects
result in unnecessary database queries. To prevent this, `fill_descendants()`
now sets a `populated_children` flag on all located `WP_Comment` objects.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@34730


git-svn-id: http://core.svn.wordpress.org/trunk@34694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 03:58:23 +00:00
Boone Gorges dd9709d179 Simplify pagination logic in `comments_template()`. 
[34561] "fixed" the problem of newest-first comments showing fewer than
'per_page' comments on the post permalink when the total number of comments
was not divisible by 'per_page'. See #29462. But this fix caused numerous
other problems. First, comment pages reported by `get_page_of_comment()`
(which expects comment pages to be filled oldest-first) were no longer correct.
Second, and more seriously, the new logic caused comments to be shifted
between pages, making their permalinks non-permanent.

The current changeset reverts the changed behavior. In order to preserve the
performance improvements introduced in [34561], an additional query must be
performed when 'default_comments_page=newest' and 'cpage=0' (ie, you're viewing
the post permalink). A nice side effect of this revert is that we no longer
need the hacks required to determine proper comment pagination, introduced in
[34561].

See #8071. See #34073.
Built from https://develop.svn.wordpress.org/trunk@34729


git-svn-id: http://core.svn.wordpress.org/trunk@34693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 03:11:30 +00:00
Scott Taylor 594a208753 Post List Table: Ensure that `edit.php` with no query string produces the proper markup and links in the `date` column header. 
Add 2 methods to `WP_List_Table`, `->get_orderby()` and `->get_order()`. Override the methods in `WP_Posts_List_Table`.

`WP_Posts_List_Table` calls `wp_edit_posts_query()` in `->prepare_items()` which is a wrapper for `wp()`. As such, we can obtain `orderby` and `order` via `get_query_var()`, instead of the URL.

Fixes #25493.


Built from https://develop.svn.wordpress.org/trunk@34728


git-svn-id: http://core.svn.wordpress.org/trunk@34692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 02:10:25 +00:00
Drew Jaynes ec9ec3138e Formatting: Rename the `$richedit` parameter in `format_to_edit()` to `$rich_text`. 
Previously, it was necessary to explain in a double-negative that `$richedit` being false would prevent `$content` from being passed through `esc_textarea()`. The updated `$rich_edit` name and documentation now better reflects the intent of the parameter.

Fixes #21613.

Built from https://develop.svn.wordpress.org/trunk@34727


git-svn-id: http://core.svn.wordpress.org/trunk@34691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 02:01:26 +00:00
Helen Hou-Sandí 1bacb00c01 Comments: Trash blacklisted comments by default. 
If trash is disabled, they wil continue to go into spam like they do now.

props wonderboymusic, solarissmoke, MikeHansenMe.
fixes #7051.

Built from https://develop.svn.wordpress.org/trunk@34726


git-svn-id: http://core.svn.wordpress.org/trunk@34690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 01:49:25 +00:00
Drew Jaynes 3d6f53da06 Docs: Document declaration of the `$submenu_file` global in wp-admin/menu-header.php. 
See #24531. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34725


git-svn-id: http://core.svn.wordpress.org/trunk@34689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 01:48:25 +00:00
Drew Jaynes 2a0a841a13 Declare the `$submenu_file` global to avoid a notice generated by passing it as a parameter to the `submenu_file` hook, introduced in [34722]. 
Fixes #24531.

Built from https://develop.svn.wordpress.org/trunk@34724


git-svn-id: http://core.svn.wordpress.org/trunk@34688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 01:23:25 +00:00
Helen Hou-Sandí 7365e0ebbb Don't show the "Add New" link on `post-new.php`. 
Using the same `$post_new_file` global variable name in `wp-admin/menu.php` in [33723] was unintentional, but we're already unsetting other variables that are in global scope so we can just unset this one as well. Someday the admin menu won't be a big pile of sad and cryptic globals. Maybe.

props johnjamesjacoby, norcross.
fixes #34045.

Built from https://develop.svn.wordpress.org/trunk@34723


git-svn-id: http://core.svn.wordpress.org/trunk@34687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 00:48:25 +00:00
Sergey Biryukov 145deeeada Add `'submenu_file'` filter for the file of an admin menu sub-menu item. 
This complements the `'parent_file'` filter added in [12712].

Props swissspidy, kraftbj.
Fixes #24531.
Built from https://develop.svn.wordpress.org/trunk@34722


git-svn-id: http://core.svn.wordpress.org/trunk@34686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-01 00:23:28 +00:00
Weston Ruter 35631aeeeb Customize: Style the nav menu "Add Items" button as disabled when reordering. 
Fixes CSS selector to match what is being used for the "Add Widget" button in the customizer.

Props umesh.nevase.
Fixes #34102.

Built from https://develop.svn.wordpress.org/trunk@34721


git-svn-id: http://core.svn.wordpress.org/trunk@34685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 22:55:26 +00:00
Boone Gorges d6a1a9655c Fix db_version juggling during non-multisite tests. 
Continuing with the "code is poetry" theme after [34719], we need to continue
to update the option in the database on non-multisite in this
`wp_insert_term()` test.

See #31130.
Built from https://develop.svn.wordpress.org/trunk@34720


git-svn-id: http://core.svn.wordpress.org/trunk@34684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 13:28:26 +00:00
Boone Gorges a09e95214a Prevent Multisite term tests from hitting database for 'db_version'. 
[34718] introduced a 'db_version' check to term meta functions, to ensure that
they don't run when the term meta schema is not yet in place. This call to
`get_option()` causes a database hit during Multisite tests, due to the
presence of the `WP_INSTALLING` constant. See #31130. The extra database
queries are causing cache tests to fail.

In similar cases, we have `markTestSkipped()` when `is_multisite()`. Because
the term meta API is so extensive - term meta caches can be primed anywhere a
`WP_Query` loop is fired up - we implement a more generous workaround in this
case. To prevent `get_option( 'db_version' )` from hitting the database during
multisite unit tests, we use a 'pre_option_' filter.

Heaven help us.

See #34091.
Built from https://develop.svn.wordpress.org/trunk@34719


git-svn-id: http://core.svn.wordpress.org/trunk@34683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 13:09:27 +00:00
Boone Gorges dac1de24f7 Bail out of termmeta functions if schema is not up-to-date. 
Termmeta cache priming was throwing database errors on installations that had
not yet gone through the database update routine. To avoid errors in all cases,
the check has been added to all termmeta functions. These checks will be
removed in a future version of WordPress. (Hang on to your hats!)

Fixes #34091.
Built from https://develop.svn.wordpress.org/trunk@34718


git-svn-id: http://core.svn.wordpress.org/trunk@34682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 04:53:25 +00:00
Drew Jaynes 8b4c499664 Docs: There are quite alot of typos in core inline comments. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34717


git-svn-id: http://core.svn.wordpress.org/trunk@34681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 04:13:48 +00:00
Boone Gorges 5dcced2d13 Use array hash notation for `get_comment_link()` `$args`. 
See #34068, #34073.
Built from https://develop.svn.wordpress.org/trunk@34716


git-svn-id: http://core.svn.wordpress.org/trunk@34680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 04:13:25 +00:00
Drew Jaynes 85eafd7632 Themes: Introduce three new arguments for `get_the_post_navigation()`, `in_same_term`, `excluded_terms`, and `taxonomy`. 
The addition of these new arguments brings `get_the_post_navigation()` into argument parity with `get_previous_post_link()` and `get_next_post_link()`, both of which it wraps, and will allow for more flexibility in configuring the next and previous post links for simultaneous display in themes.

Props ChaseWiseman.
Fixes #32618.

Built from https://develop.svn.wordpress.org/trunk@34715


git-svn-id: http://core.svn.wordpress.org/trunk@34679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 03:41:26 +00:00
Drew Jaynes 5ec1077a38 Widgets: Introduce a `delete_widget` action, which fires after a widget has been marked for deletion. 
Props afercia for the initial patch.
Fixes #27444.

Built from https://develop.svn.wordpress.org/trunk@34714


git-svn-id: http://core.svn.wordpress.org/trunk@34678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 03:21:26 +00:00
Boone Gorges 67077ce72a Fix logical errors in some comment pagination tests. 
The tests included in [34669] contained a couple of problems:

* Comments were not always created in the expected order, due to the incorrect use of 'comment_date_gmt'.
* 'asc'/'desc' and 'older'/'newer' were confused.
* 'default_comments_page=newest' ('last') didn't properly account for the cpage=1 offset.

The code itself powering this pagination was correct; it's only the tests that
were wrong.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@34713


git-svn-id: http://core.svn.wordpress.org/trunk@34677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 03:07:26 +00:00
Drew Jaynes d25ac6bfec Docs: Mark a few optional parameters as such in wp-includes/rewrite-functions.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34712


git-svn-id: http://core.svn.wordpress.org/trunk@34676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 02:42:26 +00:00
Boone Gorges 654eeb3785 Improve lazyloading of comment meta in `WP_Query` loops. 
Lazy-loading logic is moved to a method on `WP_Query`. This makes it possible
for comment feeds to take advantage of metadata lazyloading, in addition to
comments loaded via `comments_template()`.

This new technique parallels the termmeta lazyloading technique introduced in
[34704].

Fixes #34047.
Built from https://develop.svn.wordpress.org/trunk@34711


git-svn-id: http://core.svn.wordpress.org/trunk@34675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:35:26 +00:00
Scott Taylor 21752923f0 List Tables: `.column-date` needs to become wider at smaller screen sizes, bump it from `10%` to `14%` at the breakpoint to prevent wrapping. 
Fixes #32691.

Built from https://develop.svn.wordpress.org/trunk@34710


git-svn-id: http://core.svn.wordpress.org/trunk@34674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:25:25 +00:00
Scott Taylor 41bc0aee88 Revert [34083], I was willing to try this out for the greater good. The good was not greater. There is too much baggage associated with this specific change as pertains to BC and expected layout. 
See #32691.

Built from https://develop.svn.wordpress.org/trunk@34709


git-svn-id: http://core.svn.wordpress.org/trunk@34673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:19:24 +00:00
Scott Taylor 619063b4e2 Rewrite: allow `add_rewrite_rule|WP_Rewrite::add_rule()` to accept an associative array for the value of `$redirect` instead of requiring a query string. 
Adds unit tests.

Props scribu, DrewAPicture.
Fixes #16840.

Built from https://develop.svn.wordpress.org/trunk@34708


git-svn-id: http://core.svn.wordpress.org/trunk@34672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:11:25 +00:00
Scott Taylor 882c34d555 List Tables: only hide bulk actions when there are no items, don't hide all of the extra table nav. 
Fixes #33824.

Built from https://develop.svn.wordpress.org/trunk@34707


git-svn-id: http://core.svn.wordpress.org/trunk@34671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 00:47:27 +00:00
Drew Jaynes 471a507dfd Docs: Add an `@see` reference for the "use-instead-of" function in the DocBlock for `force_ssl_login()`, deprecated in [34700]. 
See #34011. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34706


git-svn-id: http://core.svn.wordpress.org/trunk@34670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 22:46:25 +00:00
Drew Jaynes 492c11508a Users: Add the default arguments array as a second parameter to the `wp_dropdown_users_args` filter, introduced in [34692]. 
Adjust hook doc descriptions accordingly.

See #19867.

Built from https://develop.svn.wordpress.org/trunk@34705


git-svn-id: http://core.svn.wordpress.org/trunk@34669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 22:39:25 +00:00
Boone Gorges db880777f4 Improve lazyloading of term metadata in `WP_Query` loops. 
[34529] introduced lazyloading for the metadata belonging to terms matching
posts in the main `WP_Query`. The current changeset improves this technique
in the following ways:

* Term meta lazyloading is now performed on the results of all `WP_Query` queries, not just the main query.
* Fewer global variable touches and greater encapsulation.
* The logic for looping through posts to identify terms is now only performed once per `WP_Query`.

Props dlh, boonebgorges.
See #34047.
Built from https://develop.svn.wordpress.org/trunk@34704


git-svn-id: http://core.svn.wordpress.org/trunk@34668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 22:00:24 +00:00
John Blackbourn ae5f825093 `force_ssl_login()` has been functionally identical to `force_ssl_admin()` since 4.0 (#10267), so its test assertions can be removed as the function has been deprecated in [34700]. The remaining assertions suitably cover `force_ssl_admin()`. 
See #34011

Built from https://develop.svn.wordpress.org/trunk@34703


git-svn-id: http://core.svn.wordpress.org/trunk@34667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:44:33 +00:00
Scott Taylor addb8fe492 Customizer: make "Current header" clickable in the same way that "Background Image" is - will open the media modal. 
Props umesh.nevase.
Fixes #33586.

Built from https://develop.svn.wordpress.org/trunk@34702


git-svn-id: http://core.svn.wordpress.org/trunk@34666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:40:24 +00:00
Scott Taylor 84dbb036d1 Network Upgrade: switch `<h3>` to `<h2>`. 
Props afercia.
Fixes #34082.

Built from https://develop.svn.wordpress.org/trunk@34701


git-svn-id: http://core.svn.wordpress.org/trunk@34665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:29:13 +00:00
John Blackbourn a8728b987f Deprecate `force_ssl_login()`, which is simply a wrapper for `force_ssl_admin()` and is not used in core. 
Fixes #34011

Built from https://develop.svn.wordpress.org/trunk@34700


git-svn-id: http://core.svn.wordpress.org/trunk@34664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:28:50 +00:00
Drew Jaynes 25f5bf2389 Tests: Add two tests for the current behavior of the 'hierarchical' and 'child_of' arguments in `get_pages()`. 
See #18701.

Built from https://develop.svn.wordpress.org/trunk@34699


git-svn-id: http://core.svn.wordpress.org/trunk@34663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:28:26 +00:00
Drew Jaynes 504ff681d4 Tests: Add two tests for the current 'hierarchical' argument behavior in `get_pages()`. 
See #18701.

Built from https://develop.svn.wordpress.org/trunk@34698


git-svn-id: http://core.svn.wordpress.org/trunk@34662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 20:50:26 +00:00
Boone Gorges c36d4fb8a9 `WP_Query` should not ignore an offset of `0`. 
Props mazurstas.
Fixes #34060.
Built from https://develop.svn.wordpress.org/trunk@34697


git-svn-id: http://core.svn.wordpress.org/trunk@34661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 19:37:23 +00:00
Boone Gorges 5b32e27a00 Fix 'exclude_tree' in `wp_list_categories()`. 
The 'exclude_tree' parameter must be compatible with 'hierarchical';
previously, 'hierarchical' canceled it out. This changeset also makes it so
that 'exclude_tree' is compatible with 'exclude'. When both are passed, and
'hierarchical' is true, the descendant trees of terms in both parameters will
be excluded from matched terms.

Props tott, webord, MikeHansenMe.
Fixes #12981.
Built from https://develop.svn.wordpress.org/trunk@34696


git-svn-id: http://core.svn.wordpress.org/trunk@34660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 19:12:27 +00:00
Andrea Fercia 9bb09f0e08 Bump H3 headings to H2 on the Network Settings screen for better accessibility. 
Fixes #34078.
Built from https://develop.svn.wordpress.org/trunk@34695


git-svn-id: http://core.svn.wordpress.org/trunk@34659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 18:52:26 +00:00
Aaron Jorbin 0209b32d67 Cleanup image size in unit tests 
This helps prevent test leakage that can cause Tests_Media::test_add_image_size to break.

See #33968


Built from https://develop.svn.wordpress.org/trunk@34694


git-svn-id: http://core.svn.wordpress.org/trunk@34658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 17:48:26 +00:00
John Blackbourn 27646b7ee0 Revert the introduction of validation of the comment author's email address when sanity checking input in `wp-comments-post.php` (introduced in r34274). This allows a problematic email address to fall through to the correct validation routine and show the "Please enter a valid email address" as expected. 
Fixes #23416

Built from https://develop.svn.wordpress.org/trunk@34693


git-svn-id: http://core.svn.wordpress.org/trunk@34657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 17:27:26 +00:00
Drew Jaynes 7866772449 Users: Introduce the `wp_dropdown_users_args` filter, making it possible to filter the arguments for `wp_dropdown_users()` before the query is run. 
The 'name' argument (or the `WP_Screen` object if in the admin) can be used to help target specific instances of `wp_dropdown_users()` via this hook.

Props norcross.
See #19867.

Built from https://develop.svn.wordpress.org/trunk@34692


git-svn-id: http://core.svn.wordpress.org/trunk@34656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 15:40:27 +00:00
John Blackbourn 4d377dd4a1 On the Permalink Settings screen, add a link to the Nginx documentation when the current site is running Nginx. This is in lieu of showing actual Nginx configuration like we do for mod_rewrite or IIS. 
Fixes #18852

Built from https://develop.svn.wordpress.org/trunk@34691


git-svn-id: http://core.svn.wordpress.org/trunk@34655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 11:15:26 +00:00
Gary Pendergast cf173408cd Permalinks: Add pretty permalinks for unattached attachments. 
Previously, unattached attachments would have unsightly `/?attachment_id=1` URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.

We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.

Props SergeyBiryukov, wonderboymusic, pento.

Fixes #1914.


Built from https://develop.svn.wordpress.org/trunk@34690


git-svn-id: http://core.svn.wordpress.org/trunk@34654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 09:42:26 +00:00
Drew Jaynes 1d86c9c1ed Docs: Move the hook doc to once again directly precede the hook line for the `getarchives_where` filter following [34686]. 
See #21596.

Built from https://develop.svn.wordpress.org/trunk@34689


git-svn-id: http://core.svn.wordpress.org/trunk@34653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 06:39:25 +00:00
Drew Jaynes b69ef84a77 Tests: Relocate tests for general-template.php to a more logically-placed (and named) file, tests/general/template.php. 
See #34070.

Built from https://develop.svn.wordpress.org/trunk@34688


git-svn-id: http://core.svn.wordpress.org/trunk@34652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 05:52:26 +00:00
Drew Jaynes d38e2fe848 Tests: Consolidate author-template tests into a single, more logically-placed file, tests/user/author.php. 
See #34070.

Built from https://develop.svn.wordpress.org/trunk@34687


git-svn-id: http://core.svn.wordpress.org/trunk@34651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 05:37:24 +00:00
Scott Taylor eeb539e90f Allow `wp_get_archives()` to accept `post_type` as an arg. 
Adds unit test.

Fixes #21596.

Built from https://develop.svn.wordpress.org/trunk@34686


git-svn-id: http://core.svn.wordpress.org/trunk@34650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 05:11:24 +00:00
Gary Pendergast 1db89dd3bf Rewrite: Redirect attachment URLs when their slug changes. 
Using the same logic that we use to redirect posts when their slug changes, we can provide the same functionality for attachments. Attachment pages are posts, too.

Props swissspdy.

Fixes #34043.


Built from https://develop.svn.wordpress.org/trunk@34685


git-svn-id: http://core.svn.wordpress.org/trunk@34649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:58:25 +00:00
Scott Taylor 7efab8df3f Edit Media: wrap long filenames in the Publish meta box. 
Fixes #34069.

Built from https://develop.svn.wordpress.org/trunk@34684


git-svn-id: http://core.svn.wordpress.org/trunk@34648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:51:25 +00:00
Scott Taylor f77499ed22 RSS Widget: add a class, `rss-widget-icon`, to the RSS icon to allow devs to hide it. Not going to remove to not break visual BC. 
Fixes #22010.

Built from https://develop.svn.wordpress.org/trunk@34683


git-svn-id: http://core.svn.wordpress.org/trunk@34647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:32:25 +00:00
Scott Taylor f2bd17193d XML-RPC: add a unit test for `mw.editPost`. 
See #16980.

Built from https://develop.svn.wordpress.org/trunk@34682


git-svn-id: http://core.svn.wordpress.org/trunk@34646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:28:25 +00:00
Scott Taylor 111c05ba47 XML-RPC: calculate the proper offset for GMT in `wp.newPost`, `mw.newPost`, and `mw.editPost` when `post_date` is set, `wp.editComment` when `comment_date` is set. `post|comment_date` is assumed to be GMT. This is only true if the timezone string for the site matches GMT. 
Adds unit tests for each.

Props smerriman, justdaiv, wonderboymusic.
Fixes #30429.

Built from https://develop.svn.wordpress.org/trunk@34681


git-svn-id: http://core.svn.wordpress.org/trunk@34645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:05:24 +00:00
Boone Gorges f584a3debb Add unit tests for `post_exists()`. 
Props MikeHansenMe.
See #34012.
Built from https://develop.svn.wordpress.org/trunk@34680


git-svn-id: http://core.svn.wordpress.org/trunk@34644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:02:24 +00:00
Boone Gorges 061c536031 Don't require explicit taxonomy when getting terms by term_taxonomy_id. 
Props wonderboymusic.
Fixes #30620.
Built from https://develop.svn.wordpress.org/trunk@34679


git-svn-id: http://core.svn.wordpress.org/trunk@34643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 03:52:25 +00:00
Drew Jaynes e9cfe211bc Tests: Flush rewrite rules between tests in an attempt to avoid permalinks pollution in `Tests_Author_Template`. 
See #30355.

Built from https://develop.svn.wordpress.org/trunk@34678


git-svn-id: http://core.svn.wordpress.org/trunk@34642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 02:19:26 +00:00
Drew Jaynes d242d5bbfb Introduce `get_the_author_posts_link()`, which returns the HTML link to the author page for the current post's author. 
`the_author_posts_link()` has in-turn been converted into a wrapper, with most of its logic moved to the new function.

Adds tests for the new function.

Props chipbennett, zrothauser, wonderboymusic, DrewAPicture.
Fixes #30355.

Built from https://develop.svn.wordpress.org/trunk@34677


git-svn-id: http://core.svn.wordpress.org/trunk@34641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 01:49:25 +00:00
Jeremy Felt d5b2929dbb Docs: Clarify `$user` parameter documentation in `wpmu_validate_blog_signup`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34676


git-svn-id: http://core.svn.wordpress.org/trunk@34640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 01:33:27 +00:00
John Blackbourn 5f09357c21 Revert r34674 due to failures on PHP < 5.4. 
See #16859

Built from https://develop.svn.wordpress.org/trunk@34675


git-svn-id: http://core.svn.wordpress.org/trunk@34639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 01:01:24 +00:00
John Blackbourn eb352accc4 Avoid stripping square brackets from URLs, and instead correctly encode them. 
Square brackets must be encoded in the path, path parameters, query parameters, and fragment, but must not be encoded in anything up to the domain and port.

Adds a bunch of tests, including square brackets in query parameters, IPv6 URLs, and several other permutations.

See #16859

Built from https://develop.svn.wordpress.org/trunk@34674


git-svn-id: http://core.svn.wordpress.org/trunk@34638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 00:41:24 +00:00
Jeremy Felt ea03ecbe66 Fixes #33816. 
MS: Adjust formatting of code in `site-new.php` to improve readability.

Fixes #34066.

Built from https://develop.svn.wordpress.org/trunk@34673


git-svn-id: http://core.svn.wordpress.org/trunk@34637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 23:30:24 +00:00
Jeremy Felt 5397416276 MS: Delete `rewrite_rules` when updating a switched site's URL. 
Previously, rewrite rules could be flushed and regenerated in the context of another site. Deleting the rules when in a switched state allows for them to be generated properly on the next page view.

Fixes #33816.

Built from https://develop.svn.wordpress.org/trunk@34672


git-svn-id: http://core.svn.wordpress.org/trunk@34636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 23:24:27 +00:00
Helen Hou-Sandí 02703fae19 Sample permalink: Buttons still need the `.button` class. 
Also fixes unit tests post-[34670]. The test methods have been slightly renamed because it is no longer a button. Hopefully this name will be more future-proof.

see #18306.

Built from https://develop.svn.wordpress.org/trunk@34671


git-svn-id: http://core.svn.wordpress.org/trunk@34635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 22:07:25 +00:00
Helen Hou-Sandí e976f9b503 Edit: Remove the redundant "View Post" button-link and link the sample permalink. 
Previously there were two persistent "View Post" links on an edit screen: next to the permalink and in the toolbar. This would then become three links after a post was published or updated, as a link is also included in the admin notice. This is a lot of redundancy and visual noise for a flow that is not your primary action upon starting to edit a post. The "View Post" link next to the sample permalink was particularly bad because it is styled like a button, but unlike a button, does not keep you on the current screen.

Because the permalink is now linked, there is no highlighted slug that you can click to edit, but rather just the "Edit" button.

props scribu, lessbloat, sabreuse, SergeyBiryukov, DrewAPicture, helen.
see #18306.

Built from https://develop.svn.wordpress.org/trunk@34670


git-svn-id: http://core.svn.wordpress.org/trunk@34634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 20:10:26 +00:00
Boone Gorges f7f4fb01ab Fix comment_order for single page comment threads. 
The old comment pagination logic had a separate block for comment threads that
appeared on a single page. After the refactoring in [34561], all comment
pagination logic is unified.

This change ensures that 'comment_order' is respected in all scenarios.

Fixes #8071.
Built from https://develop.svn.wordpress.org/trunk@34669


git-svn-id: http://core.svn.wordpress.org/trunk@34633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 19:30:26 +00:00
John Blackbourn 5bfa878fee Correctly slash post fields when trashing and untrashing posts. 
Fixes #27550
Props dmenard, Denis-de-Bernardy

Built from https://develop.svn.wordpress.org/trunk@34668


git-svn-id: http://core.svn.wordpress.org/trunk@34632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 19:26:25 +00:00
John Blackbourn 2571b6dcec Correct the logic used when determining whether to display the 'Mine' link on post list tables. It should only be shown when the count for the user's posts differs for the total count of posts. `is_multi_author()` cannot be used because it only considers Posts. 
Fixes #19609

Built from https://develop.svn.wordpress.org/trunk@34667


git-svn-id: http://core.svn.wordpress.org/trunk@34631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 19:15:24 +00:00
John Blackbourn 51667f882a Add a `nav_menu_item_title` filter for filtering nav menu item titles. 
Fixes #33447
Props paulwilde

Built from https://develop.svn.wordpress.org/trunk@34666


git-svn-id: http://core.svn.wordpress.org/trunk@34630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 18:41:26 +00:00
John Blackbourn 8d362918a8 Add a missing `@param` doc for `confirm_another_blog_signup()`. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@34665


git-svn-id: http://core.svn.wordpress.org/trunk@34629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 17:58:26 +00:00
John Blackbourn b14f6467dc Avoid using `assertNotFalse()` which is only available in phpunit >= 4.0.0 
See #33070

Built from https://develop.svn.wordpress.org/trunk@34664


git-svn-id: http://core.svn.wordpress.org/trunk@34628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 16:28:26 +00:00
John Blackbourn 2a8abfef81 Update `get_the_post_thumbnail_url()` so it returns false on failure, to bring it inline with `wp_get_attachment_image_url()`. Correct and introduce new tests. 
Fixes #33070

Built from https://develop.svn.wordpress.org/trunk@34663


git-svn-id: http://core.svn.wordpress.org/trunk@34627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 15:34:25 +00:00
Drew Jaynes 14c9ea88ea Widgets: Pass `$instance` to the `widget_nav_menu_args` filter in the Custom Menu widget. 
Props walterbarcelos for the initial patch.
Fixes #33944.

Built from https://develop.svn.wordpress.org/trunk@34662


git-svn-id: http://core.svn.wordpress.org/trunk@34626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 15:31:25 +00:00
Boone Gorges 90544d66f2 In `get_page_of_comment()`, use a true `COUNT` query. 
This improves memory usage by not compiling a list of comment IDs.

See #34057.
Built from https://develop.svn.wordpress.org/trunk@34661


git-svn-id: http://core.svn.wordpress.org/trunk@34625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 15:10:50 +00:00
Boone Gorges ae60606ff8 Use correct 'page_id' parameter in `get_page_of_comment()`. 
See #34057.
Built from https://develop.svn.wordpress.org/trunk@34660


git-svn-id: http://core.svn.wordpress.org/trunk@34624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 15:10:27 +00:00
Gary Pendergast 635d3bb34e Rewrite: When redirecting old slugs, include URL endpoints. 
Historically, `wp_old_slug_redirect()` has only ever redirected the old slug of posts, it hasn't included URL endpoints, or worked with comment feed URLs. By adding support for these, we ensure a greater range of URLs aren't killed when the slug changes.

Props swissspdy.

Fixes #33920.


Built from https://develop.svn.wordpress.org/trunk@34659


git-svn-id: http://core.svn.wordpress.org/trunk@34623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 06:57:26 +00:00
Scott Taylor 8bb4c2c2e9 Theme Editor: ensure that files named `index.php` in theme subfolders are not labeled as "Main Index Template" 
Props MikeHansenMe, wonderboymusic, bravokeyl, Shelob9.
Fixes #27201.

Built from https://develop.svn.wordpress.org/trunk@34658


git-svn-id: http://core.svn.wordpress.org/trunk@34622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 03:11:24 +00:00
Scott Taylor 6cde1a05cb After [34629], use `$size_class` instead of `$size`. 
See #32093.

Built from https://develop.svn.wordpress.org/trunk@34657


git-svn-id: http://core.svn.wordpress.org/trunk@34621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 02:50:24 +00:00
Aaron Jorbin ce6d084900 Exclude external HTTP tests from multisite run 
In [30298] the unit tests default confirguration was modified to exclude external-http tests.  This change was never migrated to the multisite XML configuration. The external HTTP code doesn't follow different logic in multisite, so the logic to exclude the tests then ( The external-http tests are very slow, and Wp_Http functionality is fairly isolated ) holds true here as well.

See #33968

Built from https://develop.svn.wordpress.org/trunk@34656


git-svn-id: http://core.svn.wordpress.org/trunk@34620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 02:37:25 +00:00
Gary Pendergast 9347f1af71 WPDB: Make sure we don't run sanity checks on DB dropins. 
Previously, we'd run the sanity checks if `is_mysql` was not set to `false`. This caused problems for DB drop-ins that didn't define `is_mysql` at all. Instead, we can just check if `is_mysql` is `empty()`.

Also fix some unit tests that accidently ran correctly because of the strict `false ===` comparison.

Fixes #33501.


Built from https://develop.svn.wordpress.org/trunk@34655


git-svn-id: http://core.svn.wordpress.org/trunk@34619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 01:17:24 +00:00
Drew Jaynes 6b07e4a325 Tests: Add a test for the 'before' and 'after' arguments in `wp_page_menu()` when used as a fallback for `wp_nav_menu()`. 
When `wp_page_menu()` is used as a fallback for `wp_nav_menu()`, the `before` and `after` arguments should be set and output as `<ul>` and `</ul>`, respectively.

See #11095. See [34653].

Built from https://develop.svn.wordpress.org/trunk@34654


git-svn-id: http://core.svn.wordpress.org/trunk@34618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 00:47:25 +00:00
Scott Taylor b4ed533e66 After [34200], force 'before' and 'after' to `<ul>` and `</ul>` when `wp_nav_menu()` falls back to `wp_page_menu()`. 
See #11095.

Built from https://develop.svn.wordpress.org/trunk@34653


git-svn-id: http://core.svn.wordpress.org/trunk@34617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 23:39:27 +00:00
Drew Jaynes a908b87996 Docs: Improve the hook documentation for the `plugins_api_args` filter. 
Standardizes the hook doc summary and expands on the expected type for the `$args` parameter.

See #34035. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34652


git-svn-id: http://core.svn.wordpress.org/trunk@34616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 23:03:24 +00:00
Drew Jaynes 9c46e6605e Docs: Improve the hook documentation for the `themes_api` filter. 
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.

Also updates the expected types on the `$override` parameter.

See #34036. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34651


git-svn-id: http://core.svn.wordpress.org/trunk@34615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 23:01:24 +00:00
Drew Jaynes 0d447249c3 Docs: Normalize the data table spacing in the `themes_api()` DocBlock following a typo fix in [34649]. 
See #34036.

Built from https://develop.svn.wordpress.org/trunk@34650


git-svn-id: http://core.svn.wordpress.org/trunk@34614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:49:24 +00:00
Drew Jaynes ad33a92b6b Docs: Fix two typos in the DocBlock description for `themes_api()`: 
* The fourth `$action` type is 'feature_list'
* The first `$action` type in the data table should be 'query_themes'

See #34036.

Built from https://develop.svn.wordpress.org/trunk@34649


git-svn-id: http://core.svn.wordpress.org/trunk@34613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:47:25 +00:00
Drew Jaynes b27d14ccf3 Docs: Adjust the `themes_api()` DocBlock description to clarify the "second" available hook, `themes_api`, and add new information for the "third" hook, `themes_api_result`. 
See #34036.

Built from https://develop.svn.wordpress.org/trunk@34648


git-svn-id: http://core.svn.wordpress.org/trunk@34612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:45:25 +00:00
Drew Jaynes ed719e4d32 Docs: Improve the hook documentation for the `plugins_api` filter. 
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.

See #34035. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34647


git-svn-id: http://core.svn.wordpress.org/trunk@34611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:29:24 +00:00
John Blackbourn e177565b03 Switch several assertions to `assertNotWPError()` so more context is provided when the assertion fails. 
Built from https://develop.svn.wordpress.org/trunk@34646


git-svn-id: http://core.svn.wordpress.org/trunk@34610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:27:24 +00:00
Drew Jaynes e7294234b9 Docs: Adjust the `plugins_api()` DocBlock description to clarify the "second" available hook, `plugins_api`, and add new information for the "third" hook, `plugins_api_result`. 
See #34035.

Built from https://develop.svn.wordpress.org/trunk@34645


git-svn-id: http://core.svn.wordpress.org/trunk@34609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:23:24 +00:00
Drew Jaynes 6e47f2a1ee Docs: Slightly improve the readability of the data table in the DocBlock description for the `oembed_providers` hook by centering the HTTPS column. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34644


git-svn-id: http://core.svn.wordpress.org/trunk@34608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:11:48 +00:00
Scott Taylor 8cd1db9c9c Canonical: after [34272], don't redirect rewrite endpoints on attachment URLs when pretty permalinks are enabled. 
Fixes #19918.

Built from https://develop.svn.wordpress.org/trunk@34643


git-svn-id: http://core.svn.wordpress.org/trunk@34607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:11:25 +00:00
Drew Jaynes 61196c4862 Docs: Update the DocBlock summary for `plugins_api()` to reflect the "WordPress.org" Plugins API. 
See #34035.

Built from https://develop.svn.wordpress.org/trunk@34642


git-svn-id: http://core.svn.wordpress.org/trunk@34606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:07:24 +00:00
Drew Jaynes 5b07b691f7 Docs: Further improve documentation for `plugins_api()`. 
* Adds a matrix-like data table demonstrating which arguments are available for the different `$action` types
* Adjusts the return types to accommodate an `array` for the 'hot_tags' `$action` choice

Props ocean90.
See #34035.

Built from https://develop.svn.wordpress.org/trunk@34641


git-svn-id: http://core.svn.wordpress.org/trunk@34605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 22:00:25 +00:00
Drew Jaynes b6de1478fd Docs: Vastly improve documentation for `themes_api()`. 
Adds:
* A hash notation with descriptions for all accepted arguments
* A matrix-like data table demonstrating which arguments are available for the different `$action` types
* A better summary and description with linked hooks
* An improved return description with a link to external information

Props ocean90.
See #34036.

Built from https://develop.svn.wordpress.org/trunk@34640


git-svn-id: http://core.svn.wordpress.org/trunk@34604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 21:52:25 +00:00
John Blackbourn 702e4e8ea7 Don't set `CURLOPT_CAINFO` when `sslverify` is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled. 
This fixes issues with local HTTPS requests (eg. WP Cron) on OS X where cURL is using SecureTransport instead of OpenSSL.

Fixes #33978

Built from https://develop.svn.wordpress.org/trunk@34639


git-svn-id: http://core.svn.wordpress.org/trunk@34603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 21:37:24 +00:00
John Blackbourn cbdd8e5494 Introduce `WP_UnitTestCase::assertNotWPError()` for when a test needs to assert that something is, well, not a `WP_Error`. 
See #33978

Built from https://develop.svn.wordpress.org/trunk@34638


git-svn-id: http://core.svn.wordpress.org/trunk@34602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 21:29:26 +00:00
Helen Hou-Sandí 9cfddb6c3b Autoprefixer for [34634]. 
Normally when there are multiple comma-separated values in CSS, each one would go on its own indented line. However, Autoprefixer appears to be tripping up on gradients at the moment, so it's going to stay on one line until we investigate upstream.

see #33299.

Built from https://develop.svn.wordpress.org/trunk@34637


git-svn-id: http://core.svn.wordpress.org/trunk@34601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 19:17:25 +00:00
Scott Taylor f78170934a Users List Table: show the "Change role to" dropdown on the top and bottom. Currently only shows on top. 
See #27743.

Built from https://develop.svn.wordpress.org/trunk@34636


git-svn-id: http://core.svn.wordpress.org/trunk@34600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 19:11:26 +00:00
Drew Jaynes 9c46736476 Docs: Fix some syntatical issues in the DocBlock for `WP::send_headers()` following [34632]. 
See #20226. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34635


git-svn-id: http://core.svn.wordpress.org/trunk@34599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 18:49:29 +00:00
Scott Taylor 1c74c7108f Feature Image: Improve the preview for transparent background images by using CSS3 to show a checkered background. 
Props metodiew.
Fixes #33299.

Built from https://develop.svn.wordpress.org/trunk@34634


git-svn-id: http://core.svn.wordpress.org/trunk@34598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 18:41:25 +00:00
Scott Taylor 7bc7ea0076 After [34629], update unit tests to reflect this change. 
See #32093.

Built from https://develop.svn.wordpress.org/trunk@34633


git-svn-id: http://core.svn.wordpress.org/trunk@34597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 18:30:24 +00:00
Scott Taylor 8272a839cd Update the docs in `WP` to explain the need to do [34476]. 
Fixes #20226.

Built from https://develop.svn.wordpress.org/trunk@34632


git-svn-id: http://core.svn.wordpress.org/trunk@34596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 18:28:24 +00:00
Drew Jaynes ccef2fc743 Docs: Add documentation for the `$browse`, `$user`, `$search`, `$author`, `$tag`, `$installed_plugins`, and `$page` parameters in `plugins_api()`. 
Props ocean90.
Fixes #34035.

Built from https://develop.svn.wordpress.org/trunk@34631


git-svn-id: http://core.svn.wordpress.org/trunk@34595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 18:13:48 +00:00
Scott Taylor d6774f0f6d Nav Menus: in `wp_nav_menu()`, `$container` is already bound to a list of allowed tags. PHP, being its whimsical self, while return `true` if someone sets `$container` to `true` via `in_array( true, [ 'div', 'nav' ] )`. Check that `$container` is a string before the `in_array()` check. `'true'` does not pass. 
Props shedonist for the original patch.
Fixes #32464.

Built from https://develop.svn.wordpress.org/trunk@34630


git-svn-id: http://core.svn.wordpress.org/trunk@34594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 18:13:24 +00:00
Scott Taylor 1b6ed5cbb7 Add `size-$size` class to `<img>` in `wp_get_attachment_image()`. 
Fixes #32093.

Built from https://develop.svn.wordpress.org/trunk@34629


git-svn-id: http://core.svn.wordpress.org/trunk@34593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 17:54:27 +00:00
Boone Gorges b581489e93 Add test for `get_term_by( 'slug' )` behavior with accented chars. 
When passing a value of 'slug' to `wp_insert_term()` that contains non-ASCII
characters, WordPress converts accented characters to non-accented versions.
(See `sanitize_title()` and `remove_accents()`.) The same conversion happens
when fetching when fetching a term using a slug. In this way, it's possible to
create a term and fetch it using the same accented string, even though the slug
is actually stored with non-accented characters.

See #16282.
Built from https://develop.svn.wordpress.org/trunk@34628


git-svn-id: http://core.svn.wordpress.org/trunk@34592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 16:32:26 +00:00
Boone Gorges 03870781b1 Move `get_term_by()` tests to their own file. 
Built from https://develop.svn.wordpress.org/trunk@34627


git-svn-id: http://core.svn.wordpress.org/trunk@34591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 16:10:26 +00:00
Boone Gorges 320b12ac96 Add unit test verifying that 60 char `user_login` is valid. 
Props ruudjoyo.
Fixes #33793.
Built from https://develop.svn.wordpress.org/trunk@34626


git-svn-id: http://core.svn.wordpress.org/trunk@34590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 15:42:27 +00:00
Boone Gorges c243d7070e Introduce `'the_category_list'` filter. 
Used to filter categories as structured data, before building markup in
`get_the_category_list()`.

We use this filter in addition to upstream filters (such as
'get_the_categories'`) because those upstream filters are used in numerous
contexts, while `'the_category_list'` is always used for generating markup
for display.

Props KevinB, ericlewis, SergeyBiryukov, DrewAPicture.
Fixes #9227.
Built from https://develop.svn.wordpress.org/trunk@34625


git-svn-id: http://core.svn.wordpress.org/trunk@34589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 02:22:24 +00:00
Boone Gorges 1ae565455b Pass the post ID to the `get_the_categories` filter. 
Props SergeyBiryukov.
See #9227.
Built from https://develop.svn.wordpress.org/trunk@34624


git-svn-id: http://core.svn.wordpress.org/trunk@34588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 02:17:25 +00:00
Boone Gorges 1573a8a1b7 `WP_Comment::get_children()` test should be order-agnostic. 
See #8071.
Built from https://develop.svn.wordpress.org/trunk@34623


git-svn-id: http://core.svn.wordpress.org/trunk@34587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 02:01:25 +00:00
Drew Jaynes c3a83b5726 Restore and deprecate the `WP_Widget_Recent_Comments::flush_widget_cache()` method, removed in [34580]. 
Fixes #25556.

Built from https://develop.svn.wordpress.org/trunk@34622


git-svn-id: http://core.svn.wordpress.org/trunk@34586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 01:40:26 +00:00
Drew Jaynes ad089ffe15 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Nav_Menu_Widget`. 
Props leemon.
Fixes #34015. Fixes #34013.

Built from https://develop.svn.wordpress.org/trunk@34621


git-svn-id: http://core.svn.wordpress.org/trunk@34585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 01:16:24 +00:00
Drew Jaynes c1796c55c3 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Archives`. 
Props leemon.
Fixes #34016. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34620


git-svn-id: http://core.svn.wordpress.org/trunk@34584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 01:11:25 +00:00
Drew Jaynes a05eb043c3 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Calendar`. 
Props leemon.
Fixes #34017. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34619


git-svn-id: http://core.svn.wordpress.org/trunk@34583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 01:07:25 +00:00
Drew Jaynes e0d024b355 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, `form()`, and `_get_current_taxonomy()` methods in `WP_Widget_Categories`. 
Props leemon.
Fixes #34018. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34618


git-svn-id: http://core.svn.wordpress.org/trunk@34582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 01:04:25 +00:00
Drew Jaynes 192e7f8c61 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Links`. 
Props leemon.
Fixes #34019. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34617


git-svn-id: http://core.svn.wordpress.org/trunk@34581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 01:00:24 +00:00
Drew Jaynes 233ecbfdb8 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Meta`. 
Props leemon.
Fixes #34020. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34616


git-svn-id: http://core.svn.wordpress.org/trunk@34580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:58:24 +00:00
Drew Jaynes 033c9b8d7f Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Pages`. 
Props leemon.
Fixes #34021. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34615


git-svn-id: http://core.svn.wordpress.org/trunk@34579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:54:24 +00:00
Drew Jaynes 5ab3821730 Docs: Improve documentation for the `__construct()`, `recent_comments_style()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Recent_Comments`. 
Also fixes a typo in the class DocBlock.

Props leemon.
Fixes #34022. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34614


git-svn-id: http://core.svn.wordpress.org/trunk@34578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:51:24 +00:00
Drew Jaynes e76083ce6e Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Recent_Posts`. 
Also fixes a typo in the class DocBlock.

Props leemon.
Fixes #34023. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34613


git-svn-id: http://core.svn.wordpress.org/trunk@34577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:46:25 +00:00
Drew Jaynes 4f8f817865 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_RSS`. 
Props leemon.
Fixes #34024. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34612


git-svn-id: http://core.svn.wordpress.org/trunk@34576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:42:24 +00:00
Drew Jaynes 80a32b4bc8 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Search`. 
Props leemon.
Fixes #34025. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34611


git-svn-id: http://core.svn.wordpress.org/trunk@34575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:37:24 +00:00
Drew Jaynes 08277293e5 Docs: Improve the documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Tag_Cloud`. 
Props leemon.
Fixes #34026. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34610


git-svn-id: http://core.svn.wordpress.org/trunk@34574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:32:24 +00:00
Drew Jaynes 83da7624e6 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Text`. 
(first!) Props leemon.
Fixes #34027.

Built from https://develop.svn.wordpress.org/trunk@34609


git-svn-id: http://core.svn.wordpress.org/trunk@34573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:27:26 +00:00
John Blackbourn bc4b983f89 Add function signature tests for the pluggable functions in wp-admin/includes/schema.php and wp-admin/includes/upgrade.php. 
See #33867

Built from https://develop.svn.wordpress.org/trunk@34608


git-svn-id: http://core.svn.wordpress.org/trunk@34572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 22:04:24 +00:00
John Blackbourn 336ac6e5d9 Add function signature tests for the pluggable functions in `wp-includes/cache.php`. 
See #33867

Built from https://develop.svn.wordpress.org/trunk@34607


git-svn-id: http://core.svn.wordpress.org/trunk@34571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 22:03:25 +00:00
Aaron Jorbin d09f7b6c1d Revert change from true to false in multisite upload test 
This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0.  Essentially, 0 means 100.  WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10.  This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0.

See #34037
Props jorbin, boonebgorges


Built from https://develop.svn.wordpress.org/trunk@34606


git-svn-id: http://core.svn.wordpress.org/trunk@34570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 20:59:24 +00:00
Weston Ruter 7493641f86 Customize: Prevent showing "Front Page" and "Posts Page" states for pages in list table when `show_on_front` is not "page". 
Changing the `show_on_front` option back to "posts" also resets the `page_on_front` and `page_for_posts` options when updating via the Reading settings page. In the Customizer, however, this is not the case as these other options remain unchanged. This change accounts for this difference in behavior.

Fixes #34004.

Built from https://develop.svn.wordpress.org/trunk@34605


git-svn-id: http://core.svn.wordpress.org/trunk@34569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 20:54:25 +00:00
Boone Gorges cc8df8ecb6 Remove failing xmlrpc upload test. 
This test was added [34577], but shouldn't have been, because the bug it
describes has not been fixed.

See #21292.
Built from https://develop.svn.wordpress.org/trunk@34604


git-svn-id: http://core.svn.wordpress.org/trunk@34568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 20:32:25 +00:00
Scott Taylor 2c30a11518 After [34577], alter `wp_xmlrpc_server::mw_newMediaObject()` to check upload space in multisite. 
See #21292.

Built from https://develop.svn.wordpress.org/trunk@34603


git-svn-id: http://core.svn.wordpress.org/trunk@34567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 19:49:25 +00:00
Scott Taylor 685ff76514 After [34601], some more cleanup. 
Built from https://develop.svn.wordpress.org/trunk@34602


git-svn-id: http://core.svn.wordpress.org/trunk@34566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 19:29:26 +00:00
Scott Taylor 982edbb061 After [34577] (not because of), uncover and fix some horrifying anomalies in `Tests_Multisite_Site`. 
Built from https://develop.svn.wordpress.org/trunk@34601


git-svn-id: http://core.svn.wordpress.org/trunk@34565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 19:11:24 +00:00
Aaron Jorbin 6856803922 Use an http URL rather then an https URL for tests 
Travis doesn't properly support SSL on older versions of PHP. Since we don't test for SSL support in all of the tests, this can cause these tests to fail.  This changes a URL introduced in [34568]

See #33968


Built from https://develop.svn.wordpress.org/trunk@34600


git-svn-id: http://core.svn.wordpress.org/trunk@34564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 17:48:33 +00:00
Boone Gorges 9f36a943b5 Improve post field lazyloading for comments. 
[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:

* `WP_Comment` magic methods `__isset()` and `__get()` should only load the post when a post field is being requested.
* The new `update_comment_post_cache` argument for `WP_Comment_Query` allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.

Fixes #27571.
Built from https://develop.svn.wordpress.org/trunk@34599


git-svn-id: http://core.svn.wordpress.org/trunk@34563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 16:02:25 +00:00
Dominik Schilling 7b33ad2a99 Plugins: Don't request all fields via `plugins_api( 'plugin_information' )` for plugin installs and update checks. 
The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.

Fixes #34030.
Built from https://develop.svn.wordpress.org/trunk@34598


git-svn-id: http://core.svn.wordpress.org/trunk@34562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 15:50:25 +00:00
John Blackbourn 2079755bd8 Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@34597


git-svn-id: http://core.svn.wordpress.org/trunk@34561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 15:17:24 +00:00