Pascal Birchler
ac940d0587
Ensure `wp_list_pluck()` throws a warning when not being passed an array.
...
We should not paper over the code and hide warnings from developers by casting values to an array.
See #35087 .
Built from https://develop.svn.wordpress.org/trunk@35949
git-svn-id: http://core.svn.wordpress.org/trunk@35913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 18:29:29 +00:00
Rachel Baker
719239ca1e
Comments: Use an integer as the default value for `comment_post_ID` in `wp_insert_comment` to match database column.
...
Props MikeHansenMe, juanfra, rabmalin.
Fixes #34956
Built from https://develop.svn.wordpress.org/trunk@35948
git-svn-id: http://core.svn.wordpress.org/trunk@35912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 15:13:27 +00:00
Andrea Fercia
282e7c36eb
Accessibility: Add an ARIA role `button` to links that behave like buttons when JavaScript is on.
...
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.
Patch prepared during WordCamp US 2015 Contributor Day.
Props mcapybara, garusky, takayukister.
See #26504 .
Fixes #34867 .
Built from https://develop.svn.wordpress.org/trunk@35947
git-svn-id: http://core.svn.wordpress.org/trunk@35911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 13:25:28 +00:00
Dion Hulse
8db5455eea
Filesystem: Avoid PHP warnings when using the FTP Sockets class.
...
See #35026
Built from https://develop.svn.wordpress.org/trunk@35946
git-svn-id: http://core.svn.wordpress.org/trunk@35910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 03:12:26 +00:00
Dion Hulse
bda1b2ace9
Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
...
See #28013
Fixes #34976 for trunk
Fixes #34976 for trunk
Built from https://develop.svn.wordpress.org/trunk@35944
git-svn-id: http://core.svn.wordpress.org/trunk@35908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 02:36:28 +00:00
Weston Ruter
3fdb8bafc4
Customize: Ensure that "Change" button appears when there are only 2 themes.
...
Fixes defect introduced in [35535].
Props igmoweb.
See #34549 .
Fixes #35081 .
Built from https://develop.svn.wordpress.org/trunk@35943
git-svn-id: http://core.svn.wordpress.org/trunk@35907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 01:21:26 +00:00
Dion Hulse
060476a1f2
Filesystem API: Cast the port to an int in the FTPSockets class. PemFTP requires that the port be specified as an integer, not a numeric string.
...
Fixes #35088
Built from https://develop.svn.wordpress.org/trunk@35942
git-svn-id: http://core.svn.wordpress.org/trunk@35906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 00:29:26 +00:00
Drew Jaynes
10367a4692
Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Rewrite::iis7_url_rewrite_rules()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35941
git-svn-id: http://core.svn.wordpress.org/trunk@35905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:58:27 +00:00
Drew Jaynes
af5f4a0d9c
Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Streams::test()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35940
git-svn-id: http://core.svn.wordpress.org/trunk@35904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:54:26 +00:00
Drew Jaynes
338b618fc0
Docs: Remove an extra 'arguments' introduced in [35938].
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35939
git-svn-id: http://core.svn.wordpress.org/trunk@35903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:52:25 +00:00
Drew Jaynes
edb1dc0f36
Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Curl::test()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35938
git-svn-id: http://core.svn.wordpress.org/trunk@35902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:43:26 +00:00
Drew Jaynes
64ea48f76a
Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Http_Curl::stream_body()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35937
git-svn-id: http://core.svn.wordpress.org/trunk@35901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:41:26 +00:00
Drew Jaynes
8d884c25a3
Docs: Clarify documentation for `WP_Role::has_cap()` to more clearing indicate that the method checks for capabilities against the role rather than the user.
...
Also updates syntax in the DocBlock summary and description.
Props GunGeekATX for the initial patch.
Fixes #35080 .
Built from https://develop.svn.wordpress.org/trunk@35935
git-svn-id: http://core.svn.wordpress.org/trunk@35899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 20:05:27 +00:00
Boone Gorges
3bc0e35684
Omit `cpage` query var in comment link if comment pagination is disabled.
...
WP 4.4 changed the way comment pagination is calculated. See #8071 . In the
context of `get_comment_link()`, these changes introduced a regression that
causes `cpage` (or its pretty-permalink correlate `comment-page-x`) to appear
in comment links when comment pagination is disabled. The current changeset
fixes the regression.
Fixes #34946 .
Built from https://develop.svn.wordpress.org/trunk@35933
git-svn-id: http://core.svn.wordpress.org/trunk@35897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:46:46 +00:00
Boone Gorges
b6dbe1cea9
Don't use `array_merge()` when building comment children arrays.
...
`array_merge()` is much slower than building the combined array using a
`foreach` loop. The performance difference was causing a speed regression with
the `get_children()` functionality introduced in 4.4.
Props rogerhub.
Fixes #35025 .
Built from https://develop.svn.wordpress.org/trunk@35931
git-svn-id: http://core.svn.wordpress.org/trunk@35895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:37:43 +00:00
Drew Jaynes
0c59fd02bb
Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Http_Curl::stream_headers()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35930
git-svn-id: http://core.svn.wordpress.org/trunk@35894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:21:35 +00:00
Drew Jaynes
f32fba3dab
Docs: Add more complete property and method documentation for `Walker_Page`.
...
* Adds missing DocBlock summaries
* Adds missing `@param` descriptions
* Marks some optional parameters as such
* Reorders some DocBlock tags
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35929
git-svn-id: http://core.svn.wordpress.org/trunk@35893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 18:06:31 +00:00
Drew Jaynes
fc9fa08592
Docs: Add a missing description for the `$id` parameter in the DocBlock for `Walker_PageDropdown::start_el()`, which is implemented by `Walker` but unused by the subclass method.
...
Also marks the other optional parameters as such.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35928
git-svn-id: http://core.svn.wordpress.org/trunk@35892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:54:27 +00:00
Drew Jaynes
0fbe903434
Docs: Document the `$id` parameter for `Walker_Comment::start_el()`, which is implemented by `Walker` but unused in the subclass method.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35927
git-svn-id: http://core.svn.wordpress.org/trunk@35891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:50:26 +00:00
Drew Jaynes
5817eea3c9
Docs: Document the `$id` parameter for `Walker_CategoryDropdown::start_el()`, which is implemented by `Walker` but unused in the subclass method.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35926
git-svn-id: http://core.svn.wordpress.org/trunk@35890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:47:30 +00:00
Andrea Fercia
b5f5dff136
Authentication modal dialog: the spinner should disappear when loading is done.
...
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311 .
Fixes #34951 .
Built from https://develop.svn.wordpress.org/trunk@35925
git-svn-id: http://core.svn.wordpress.org/trunk@35889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:40:27 +00:00
Andrea Fercia
0faf2dd57b
Accessibility: Remove title attributes from the Network Themes list table.
...
Title attributes in the "Themes" screen and in the "Edit Site" screen Themes tab
are now replaced with `aria-label` attributes. Also, replaces string
concatenation with `add_query_arg()` and `sprintf()` to allow translator
comments to be properly parsed and for better code readability.
Props SergeyBiryukov, afercia.
Fixes #35051 .
Built from https://develop.svn.wordpress.org/trunk@35924
git-svn-id: http://core.svn.wordpress.org/trunk@35888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:07:39 +00:00
Sergey Biryukov
d0b7dd489e
I18N: Remove `<strong>` tags from translatable strings in `WP_Customize_Manager::register_controls()` and `WP_Customize_Header_Image_Control::render_content()`.
...
Add translator comments.
See #35039 .
Built from https://develop.svn.wordpress.org/trunk@35923
git-svn-id: http://core.svn.wordpress.org/trunk@35887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 12:54:27 +00:00
Dion Hulse
ca7a95df36
Update random_compat to latest master (~1.1.5)
...
Changes:
* Checks `disable_classes` for `COM()` before using to avoid PHP Warnings
* Uses `stream_set_chunk_size()` to avoid reading 8KiB from `/dev/urandom` unintentionally.
See #34948
Built from https://develop.svn.wordpress.org/trunk@35922
git-svn-id: http://core.svn.wordpress.org/trunk@35886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 07:46:28 +00:00
Sergey Biryukov
36e8fa050f
Docs: Capitalize 'URL' correctly in `the_guid()` DocBlock. Fix a typo.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35920
git-svn-id: http://core.svn.wordpress.org/trunk@35884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 05:21:26 +00:00
Dion Hulse
e8b2a769ee
HTTP: Partially revert [34283] which removed the 1024bit certificates from our trust store.
...
Most browsers no longer trust 1024bit certificates, or certificates signed by them, instead verifying them by a trusted intermediate or a cross-sign from another trusted certificate.
Unfortunately, as it turns out, OpenSSL prior to 1.0.1g cannot correctly handle certificates chains such as this, even if one of the intermediates is trusted.
The solution is that we need to continue to trust the 1024bit legacy root certificates forthe foreseeable future
This adds the following certificates back into our trust store:
{{{
GTE CyberTrust Global Root
Thawte Server CA
Thawte Premium Server CA
Verisign Class 3 Public Primary Certification Authority
Verisign Class 3 Public Primary Certification Authority - G2
ValiCert Class 1 VA
ValiCert Class 2 VA
RSA Root Certificate 1
Entrust.net Secure Server CA
Equifax Secure Global eBusiness CA
Equifax Secure eBusiness CA 1
America Online Root Certification Authority 1
America Online Root Certification Authority 2
NetLock Business (Class B) Root
NetLock Express (Class C) Root
Verisign Class 3 Public Primary Certification Authority
}}}
Props rmccue
Fixes #34935 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35919
git-svn-id: http://core.svn.wordpress.org/trunk@35883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 05:20:28 +00:00
John Blackbourn
4836d6c700
Correct the position of the `$alt` parameter's `@param` doc in `image_add_caption()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35918
git-svn-id: http://core.svn.wordpress.org/trunk@35882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 03:01:25 +00:00
Jeremy Felt
72c6868fae
MS: Fix pagination in MS Sites List Table when entering a page number.
...
When a page number is manually entered in the sites list table and no bulk action is selected, add `paged` as a query argument to the redirect.
Fixes #32982 .
Built from https://develop.svn.wordpress.org/trunk@35917
git-svn-id: http://core.svn.wordpress.org/trunk@35881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:59:27 +00:00
John Blackbourn
aace0e33c1
Correct some `@param` doc names in the `WP_Tax_Query` and `WP_User_Query` classes.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35916
git-svn-id: http://core.svn.wordpress.org/trunk@35880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:50:27 +00:00
John Blackbourn
3f38dfa688
Correct a parameter name in the `@param` docs for `get_home_url()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35915
git-svn-id: http://core.svn.wordpress.org/trunk@35879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:45:27 +00:00
John Blackbourn
593cc9abbd
Add missing `@param` docs to `wp_safe_redirect()` and `wp_sanitize_redirect()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35914
git-svn-id: http://core.svn.wordpress.org/trunk@35878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:43:25 +00:00
John Blackbourn
9f7165d522
Add missing `@param` doc to `wp_hash()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35913
git-svn-id: http://core.svn.wordpress.org/trunk@35877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:39:26 +00:00
John Blackbourn
c2248060fe
Add missing variadic markers to the optional parameters of `do_action()` and `apply_filters()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35912
git-svn-id: http://core.svn.wordpress.org/trunk@35876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:36:25 +00:00
John Blackbourn
2984cdf457
Revert [35910].
...
Built from https://develop.svn.wordpress.org/trunk@35911
git-svn-id: http://core.svn.wordpress.org/trunk@35875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:35:26 +00:00
John Blackbourn
de7ccd262a
Built from https://develop.svn.wordpress.org/trunk@35910
...
git-svn-id: http://core.svn.wordpress.org/trunk@35874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:33:25 +00:00
John Blackbourn
48380c58a5
Add missing `@param` doc to `wp_check_password()` and update the `check_password` filter docs.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35909
git-svn-id: http://core.svn.wordpress.org/trunk@35873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:30:26 +00:00
John Blackbourn
b2e373d64d
Correct the name of the `@param` doc for `WP_Query::parse_tax_query()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35908
git-svn-id: http://core.svn.wordpress.org/trunk@35872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:08:26 +00:00
John Blackbourn
6bb33fb2f4
Add a missing `@param` doc to `wp_update_term_count()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35907
git-svn-id: http://core.svn.wordpress.org/trunk@35871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:04:26 +00:00
John Blackbourn
e059193943
Remove a redundant `@param` tag from `the_taxonomies()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35906
git-svn-id: http://core.svn.wordpress.org/trunk@35870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:02:27 +00:00
Andrea Fercia
fa80eb011f
Accessibility: remove title attributes from the available headers in the (no more used) `custom-header.php` screen.
...
Fixes #35062 .
Built from https://develop.svn.wordpress.org/trunk@35905
git-svn-id: http://core.svn.wordpress.org/trunk@35869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 00:09:27 +00:00
Pascal Birchler
47306630ca
Docs: Improve documentation for `format_for_editor()` and the `'the_editor_content'` filter it is hooked to.
...
Props AramZS for initial patch.
Fixes #34866 .
Built from https://develop.svn.wordpress.org/trunk@35904
git-svn-id: http://core.svn.wordpress.org/trunk@35868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:22:26 +00:00
Sergey Biryukov
d5d5d64e3d
I18N: Use better context for post statuses.
...
See #35054 .
Built from https://develop.svn.wordpress.org/trunk@35903
git-svn-id: http://core.svn.wordpress.org/trunk@35867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:18:26 +00:00
Sergey Biryukov
fe131bacd1
I18N: Use better context for comment statuses.
...
See #35054 .
Built from https://develop.svn.wordpress.org/trunk@35902
git-svn-id: http://core.svn.wordpress.org/trunk@35866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:11:26 +00:00
Sergey Biryukov
5b29dbbf09
I18N: Add missing context for 'Trash' strings.
...
Fixes #35054 .
Built from https://develop.svn.wordpress.org/trunk@35901
git-svn-id: http://core.svn.wordpress.org/trunk@35865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:03:26 +00:00
Sergey Biryukov
34ce39c782
List tables: After [34006], remove unnecessary context from 'View' string, for consistency with other strings in the same context.
...
Props MikeHansenMe, subharanjan.
Fixes #34914 .
Built from https://develop.svn.wordpress.org/trunk@35900
git-svn-id: http://core.svn.wordpress.org/trunk@35864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 18:37:26 +00:00
Sergey Biryukov
346cce3c48
Customizer: Change "Display Header Text" checkbox label to "Display Site Title and Tagline", to make it clearer that it affects both settings.
...
Props juanfra, vlad.olaru.
Fixes #31829 .
Built from https://develop.svn.wordpress.org/trunk@35899
git-svn-id: http://core.svn.wordpress.org/trunk@35863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 17:50:28 +00:00
Sergey Biryukov
bff39f181e
Credits: After [26354], replace another instance of the "Contributing to WordPress" Codex link with http://make.wordpress.org/ .
...
Remove redundant translator comments, add comments for placeholders instead.
See #25806 .
Built from https://develop.svn.wordpress.org/trunk@35898
git-svn-id: http://core.svn.wordpress.org/trunk@35862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 15:24:27 +00:00
Pascal Birchler
2981d66990
Login: After [34213], use the `login_post` scheme again for login forms.
...
See #34925 .
Built from https://develop.svn.wordpress.org/trunk@35897
git-svn-id: http://core.svn.wordpress.org/trunk@35861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 14:03:26 +00:00
Pascal Birchler
b804b26269
Admin: After [35128], make the 'Configure' link work again for dashboard widgets.
...
See #34987 .
Built from https://develop.svn.wordpress.org/trunk@35896
git-svn-id: http://core.svn.wordpress.org/trunk@35860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 13:57:26 +00:00
Sergey Biryukov
8ad27a1405
Docs: Improve documentation for `wp_count_terms()`.
...
Props bordoni, swissspidy.
Fixes #34861 .
Built from https://develop.svn.wordpress.org/trunk@35895
git-svn-id: http://core.svn.wordpress.org/trunk@35859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 12:11:27 +00:00