WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
34,177 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

34177 Commits

Author SHA1 Message Date
Drew Jaynes b1804afeaf Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs. 
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.

Built from https://develop.svn.wordpress.org/trunk@37431


git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 18:41:31 +00:00
Ryan McCue 1e40ba291e HTTP API: Fix compatibility with cURL <7.22 
Ensure connections are closed after usage to fix an issue with WP.com URLs used in the tests.

Resynched from GitHub at 95518ce.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37430


git-svn-id: http://core.svn.wordpress.org/trunk@37396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 11:15:29 +00:00
Ryan McCue dee1d583a7 HTTP API: Add browser compatibility hook for 3xx redirects. 
WordPress erroneously follows browser-style behaviour with 3xx redirects, where a POST to 302 becomes a GET. Requests instead follows the specification and keeps the same method. Requests also exposes a hook to allow changing the behaviour.

[37428] used the wrong method of adding this hook, now corrected.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37429


git-svn-id: http://core.svn.wordpress.org/trunk@37395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 05:11:27 +00:00
Ryan McCue 37f6e6813a HTTP API: Replace internals with Requests library. 
Requests is a library very similar to WP_HTTP, with a high level of unit test coverage, and has a common lineage and development team. It also supports parallel requests.

See #33055.

Built from https://develop.svn.wordpress.org/trunk@37428


git-svn-id: http://core.svn.wordpress.org/trunk@37394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 04:42:28 +00:00
Dominik Schilling 65f5fe6fb2 Widgets: Create `WP_Widget_Mock` as a mock of `WP_Widget` which can be used for widget tests. 
You cannot instantiate an abstract class. Not even in WordPress world.

See #35981.
Built from https://develop.svn.wordpress.org/trunk@37427


git-svn-id: http://core.svn.wordpress.org/trunk@37393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 21:25:27 +00:00
Weston Ruter b036bf1012 Customize: Clean up media control CSS. 
Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors.

Props celloexpressions.
Fixes #30618.

Built from https://develop.svn.wordpress.org/trunk@37426


git-svn-id: http://core.svn.wordpress.org/trunk@37392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 20:23:54 +00:00
Dominik Schilling 97fc82a879 Widgets: Make `WP_Widget` a real abstract class. 
This removes the `die()` call from `WP_Widget::widget()` and converts it to an abstract method.
`WP_Widgets` (later renamed to `WP_Widget`) was introduced in [10764] where the minimum PHP requirement was 4.3, thus no `abstract` was available.

Props johnbillion.
Fixes #35981.
Built from https://develop.svn.wordpress.org/trunk@37425


git-svn-id: http://core.svn.wordpress.org/trunk@37391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 20:23:28 +00:00
Dominik Schilling 7f1abd441f Posts: Fire a `post_action_{$action}` action for a custom post action request. 
Props jfarthing84, Mte90, brianvan, sudar, DrewAPicture.
Fixes #27056.
Built from https://develop.svn.wordpress.org/trunk@37424


git-svn-id: http://core.svn.wordpress.org/trunk@37390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:44:28 +00:00
Rachel Baker 00adb457d2 Comments: Add `$data` parameter to include the comment data in the `edit_comment` action. 
Props dshanske.

Fixes #36427.


Built from https://develop.svn.wordpress.org/trunk@37423


git-svn-id: http://core.svn.wordpress.org/trunk@37389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:37:27 +00:00
Dominik Schilling 251274abf6 List Tables: Pass the `$which` parameter to `restrict_manage_posts` and `restrict_manage_users`. 
`$which` contains the location of the extra table nav markup: 'top' or 'bottom'.

Props martin.krcho.
Fixes #35307.
Built from https://develop.svn.wordpress.org/trunk@37422


git-svn-id: http://core.svn.wordpress.org/trunk@37388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 15:13:27 +00:00
Dominik Schilling 546b031453 Filesystem API: Don't add `'.'` to the list of directories which need to be checked/created when extracting a file. 
Prevents a PHP warning by `WP_Filesystem_Direct::mkdir()` when installing a language pack which doesn't have subdirectories.

Props tfrommen.
Fixes #36570.
Built from https://develop.svn.wordpress.org/trunk@37421


git-svn-id: http://core.svn.wordpress.org/trunk@37387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 12:40:28 +00:00
Helen Hou-Sandí a726a9f51f Admin font: Remove a redundant `sans-serif` declaration. 
props samantha-miller.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37419


git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-12 02:14:28 +00:00
Jeremy Felt 283c367df7 Tests: Set `public` to `1` in the default blog factory 
When no `$meta` arguments are passed to `wpmu_create_blog()`, `public` is set to `0` in the database for new sites. This is fine, but also does not match the default implied when most sites are created via `site-new.php`.

The only current use of the `$meta` argument in the tests is to (re)mark `public` as `0`. All existing tests pass with this change. Tests for `WP_Site_Query` can now rely on better default expectations.

See #36566.

Built from https://develop.svn.wordpress.org/trunk@37418


git-svn-id: http://core.svn.wordpress.org/trunk@37384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-11 19:22:27 +00:00
Weston Ruter b074113016 Customize: Remove use of reserved word `default` in Underscore template which breaks IE8. 
Fixes regression introduced in r30712.

Props adamsilverstein.
Fixes #36793.

Built from https://develop.svn.wordpress.org/trunk@37417


git-svn-id: http://core.svn.wordpress.org/trunk@37383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-11 19:07:30 +00:00
Pascal Birchler 64fb1a9e90 I18N: Add changes missed in [37415]. 
See #34114.
Built from https://develop.svn.wordpress.org/trunk@37416


git-svn-id: http://core.svn.wordpress.org/trunk@37382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 20:31:27 +00:00
Pascal Birchler 751234a580 I18N: Remove the requirement to call `load_plugin_textdomain()` / `load_theme_textdomain()`. 
By initially scanning the `wp-content/languages` directory and loading available MO files just-in-time, plugins and themes do not need to manually load text domains anymore.

Props swissspidy, ocean90.
Fixes #34114
Built from https://develop.svn.wordpress.org/trunk@37415


git-svn-id: http://core.svn.wordpress.org/trunk@37381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 20:05:29 +00:00
Pascal Birchler 3f6966907b I18N: Reverse the order of loading plugin and theme translations. 
`load_theme_textdomain()`, `load_plugin_textdomain()` and `load_muplugin_textdomain()` now try to load the .mo file from the `wp-content/languages` directory first. After the introduction of language packs, translation files are more likely to be located there.

Props swissspidy, sebastian.pisula.
Fixes #34213.
Built from https://develop.svn.wordpress.org/trunk@37414


git-svn-id: http://core.svn.wordpress.org/trunk@37380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 18:50:27 +00:00
Dominik Schilling 1564bd2c1f Upgrader: Remove debug cruft. 
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37413


git-svn-id: http://core.svn.wordpress.org/trunk@37379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 18:32:28 +00:00
Dominik Schilling a8525b1109 Upgrader: After [37409] move the hook docs for `upgrader_process_complete` to `WP_Upgrader::run()`. 
Add changelog entry for [23912].

Part 7/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37412


git-svn-id: http://core.svn.wordpress.org/trunk@37378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 12:20:27 +00:00
Dominik Schilling 5844c585f6 Upgrader: Update `wp-admin/includes/class-wp-upgrader.php` to `require_once` the new files added in [37406] and [37409]. 
Part 6/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37411


git-svn-id: http://core.svn.wordpress.org/trunk@37377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:59:27 +00:00
Dominik Schilling 23e2a486ae Upgrader: Update file headers for new files added in [37409]. 
Part 5/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37410


git-svn-id: http://core.svn.wordpress.org/trunk@37376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:52:28 +00:00
Dominik Schilling 14e5d77132 Upgrader: Copy `WP_Upgrader` subclasses into one file per class. 
Part 4/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37409


git-svn-id: http://core.svn.wordpress.org/trunk@37375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:45:42 +00:00
Dominik Schilling 5f1ac9c96d Upgrader: Update `wp-admin/includes/class-wp-upgrader-skins.php` to `require_once` the new files added in [37406]. 
Part 3/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37408


git-svn-id: http://core.svn.wordpress.org/trunk@37374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:42:26 +00:00
Dominik Schilling 4b846677ba Upgrader: Update file headers and class DocBlocks for new files added in [37406]. 
Part 2/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37407


git-svn-id: http://core.svn.wordpress.org/trunk@37373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:31:28 +00:00
Dominik Schilling bbecb1a485 Upgrader: Copy `WP_Upgrader_Skin` and its subclasses into one file per class. 
Part 1/8.
See #36618.
Built from https://develop.svn.wordpress.org/trunk@37406


git-svn-id: http://core.svn.wordpress.org/trunk@37372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 11:11:30 +00:00
Weston Ruter 574be8f2a8 Customize: Ensure that `wp_setup_nav_menu_item` filter applies consistently on `nav_menu_item` setting values. 
The filter was being applied in `WP_Customize_Nav_Menu_Item_Setting::value()` but not in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`.

Props celloexpressions, westonruter.
Fixes #35203.

Built from https://develop.svn.wordpress.org/trunk@37405


git-svn-id: http://core.svn.wordpress.org/trunk@37371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-10 06:41:29 +00:00
Dominik Schilling 096d0ccd63 Tests: Don't create unused users in `Tests_Ajax_DeleteComment`. 
Fixes #36616.
Built from https://develop.svn.wordpress.org/trunk@37404


git-svn-id: http://core.svn.wordpress.org/trunk@37370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-09 19:17:29 +00:00
Sergey Biryukov ff37a3b730 Docs: Fix typo in a comment in `check_and_publish_future_post()`. 
See #32246.
Built from https://develop.svn.wordpress.org/trunk@37403


git-svn-id: http://core.svn.wordpress.org/trunk@37369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-08 12:46:29 +00:00
Dominik Schilling b5718124c3 External Libraries: Replace `split()` with `explode()` in the deprecated Atom and MagpieRSS files. 
Before PHP7 `split()` was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.

Props achbed.
Fixes #20673.
Built from https://develop.svn.wordpress.org/trunk@37402


git-svn-id: http://core.svn.wordpress.org/trunk@37368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-07 15:59:29 +00:00
Nikolay Bachiyski c33e975f46 External Libraries: Update plupload from upstream 
Built from https://develop.svn.wordpress.org/trunk@37383


git-svn-id: http://core.svn.wordpress.org/trunk@37349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-06 18:02:26 +00:00
Dominik Schilling a493dc0ab5 External Libraries: Update MediaElement.js from upstream. 
Built from https://develop.svn.wordpress.org/trunk@37370


git-svn-id: http://core.svn.wordpress.org/trunk@37336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-06 17:51:36 +00:00
Sergey Biryukov b65cbd6003 Options: After [33738], consistently pass option name as the second parameter to the `'default_option_' . $option` filter in `add_option()` and `update_option()`. 
Props dlh.
Fixes #36761.
Built from https://develop.svn.wordpress.org/trunk@37367


git-svn-id: http://core.svn.wordpress.org/trunk@37333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 20:24:29 +00:00
Drew Jaynes 2459e4e880 Docs: Remove backticks from the DocBlock summary for `WP::$request`, added in [37356]. 
Markdown formatting is not supported in DocBlock summaries, per the inline documentation standards for PHP :-)

See #32246. See #36674.

Built from https://develop.svn.wordpress.org/trunk@37366


git-svn-id: http://core.svn.wordpress.org/trunk@37332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 20:03:27 +00:00
Jeremy Felt ced66ed4e7 Multisite: Use the admin-multisite Dashicon for sites 
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37365


git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 17:13:26 +00:00
Jeremy Felt db3d5a6bea Revert [37362], which incorrectly changed Dashicons CSS 
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.

Built from https://develop.svn.wordpress.org/trunk@37364


git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 15:29:27 +00:00
Helen Hou-Sandí 610215ceb1 Revive `grunt-rtlcss`, which does not appear to enjoy syntax errors. 
props netweb.
see #36753, #29792.

Built from https://develop.svn.wordpress.org/trunk@37363


git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 15:22:27 +00:00
Jeremy Felt 172af4e0ce Multisite: Use the admin-multisite Dashicon in the admin menu and bar 
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37362


git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-05 04:29:26 +00:00
Helen Hou-Sandí a800cf654b Drop Open Sans in the admin in favor of system fonts. 
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37361


git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 22:07:37 +00:00
Boone Gorges 2d37a0ee17 Users: The 'who' parameter should not interfere with 'meta_key' + 'meta_value' in `WP_User_Query`. 
Props adrianosilvaferreira.
Fixes #36724.
Built from https://develop.svn.wordpress.org/trunk@37360


git-svn-id: http://core.svn.wordpress.org/trunk@37326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 18:57:28 +00:00
Boone Gorges 3c70037d46 Tests: Correct 'meta_query' syntax in test related to `WP_User_Query` 'who' param. 
The test, introduced in [32207], used the incorrect syntax for 'meta_query' -
one fewer level of array-nesting than what `WP_Meta_Query` requires. This
slip uncovered a bug introduced into `WP_User_Query` in [30094], whereby
an incorrectly formatted 'meta_query' parameter would be properly parsed by
`WP_User_Query` when passed alongside `who=authors`.

We need to fix the inconsistent syntax in order to resolve #36724.

See #36724, #32019, #23849, #27026.
Built from https://develop.svn.wordpress.org/trunk@37359


git-svn-id: http://core.svn.wordpress.org/trunk@37325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 18:49:29 +00:00
Boone Gorges 4f4a45ca1c Tests: Introduce `reset_phpmailer_instance()` function. 
This function provides a more convenient method for resetting the
PHPMailer instance than the previous technique of reaching into the global.

Props welcher.
Fixes #36658.
Built from https://develop.svn.wordpress.org/trunk@37358


git-svn-id: http://core.svn.wordpress.org/trunk@37324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 03:49:26 +00:00
Boone Gorges 0469f12d7b Add tests for `is_serialized_string()`. 
Props borgesbruno.
Fixes #35952.
Built from https://develop.svn.wordpress.org/trunk@37357


git-svn-id: http://core.svn.wordpress.org/trunk@37323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-04 03:30:27 +00:00
Eric Lewis 98d5d4919c Rewrite Rules: Add self-describing variables to rewrite matcher. 
The rewrite rule matching code in WP::parse_request() used an unclear variable `$request` to represent the requested path (e.g. "2016/05/03") as well as a deceptively named variable `$request_uri`, which actually represents the requested file when an install used PATHINFO links. 

Those variables are replaced with `$requested_path` and `$requested_file` respectively for clarity.

Fixes #36674.

Built from https://develop.svn.wordpress.org/trunk@37356


git-svn-id: http://core.svn.wordpress.org/trunk@37322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-03 19:36:28 +00:00
Drew Jaynes c7a2b7683b Docs: Add a missing hook doc for the `parse_comment_query` hook, added in [31793]. 
Props flixos90.
See #24826. Fixes #36740.

Built from https://develop.svn.wordpress.org/trunk@37355


git-svn-id: http://core.svn.wordpress.org/trunk@37321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-03 16:22:27 +00:00
Boone Gorges 2f66998e3f `date_query` should be a property on `WP_Comment_Query` objects. 
Instead of a local variable.

Props flixos90.
Fixes #36741.
Built from https://develop.svn.wordpress.org/trunk@37354


git-svn-id: http://core.svn.wordpress.org/trunk@37320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-03 16:15:29 +00:00
Drew Jaynes ebfc1467bb Links: Rename the `$link_id` parameter in `get_link_to_edit()` to `$link` to better reflect that it can accept a link ID or object. 
Props tloureiro for the initial patch.
Fixes #36736.

Built from https://develop.svn.wordpress.org/trunk@37353


git-svn-id: http://core.svn.wordpress.org/trunk@37319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:43:27 +00:00
Weston Ruter 4113ccfc47 Customize: Handle filtering `sidebars_widgets` when the underlying option is non-existent. 
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`. 

See [37166].
See #36389.
Fixes #36660.

Built from https://develop.svn.wordpress.org/trunk@37352


git-svn-id: http://core.svn.wordpress.org/trunk@37318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:42:28 +00:00
Drew Jaynes 3470faa683 Links: Clarify documentation for the `$link_id` parameter to mention that it accepts either an integer or object. 
Props tloureiro.
See #36736.

Built from https://develop.svn.wordpress.org/trunk@37351


git-svn-id: http://core.svn.wordpress.org/trunk@37317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 23:40:27 +00:00
Weston Ruter f98a2ed41d Customize: Pass `WP_Customize_Setting` instance as second argument to `customize_value_{$id_base}` filter. 
Adds parity with setting instance being passed as second argument to `customize_sanitize_{$id}` and `customize_sanitize_js_{$id}`. Allows the actual ID of the (multidimensional) setting value being filtered to be inspected.

Props celloexpressions, westonruter.
Fixes #36452.

Built from https://develop.svn.wordpress.org/trunk@37350


git-svn-id: http://core.svn.wordpress.org/trunk@37316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 22:42:26 +00:00
Drew Jaynes 5f62db2f21 Comments: Realign parameter documentation in the DocBlocks for `comment_author_email_link()` and `get_comment_author_email_link()` following [37348]. 
Also adds a missing return description for `get_comment_author_email_link()`.

Props flixos90 for the initial patch.
Fixes #36571.

Built from https://develop.svn.wordpress.org/trunk@37349


git-svn-id: http://core.svn.wordpress.org/trunk@37315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-02 20:04:28 +00:00