Sergey Biryukov
89f24e9c61
Code Modernization: Rename parameters that use reserved keywords in bundled themes.
...
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.
This commit:
* Renames the `$class` parameter to `$css_class` in:
* `twentysixteen_excerpt()`
* `twentynineteen_post_classes()`
* Renames the `$echo` parameter to `$display` in:
* `twentythirteen_entry_date()`
* `twentytwenty_generate_css()`
* `twentytwenty_site_logo()`
* `twentytwenty_site_description()`
* `twenty_twenty_one_generate_css()`
Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232].
Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327 .
Built from https://develop.svn.wordpress.org/trunk@53236
git-svn-id: http://core.svn.wordpress.org/trunk@52825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-20 14:24:12 +00:00
audrasjb
30a77d5fa4
i18n: Define List item separator as a WP_Locale property.
...
The list item separator is a locale property, and it doesn't make much sense to translate it separately in multiple projects. This changeset implements the following modifications:
- Define list item separator as a new WP_Locale property
- Add `wp_get_list_item_separator()` as a wrapper for `WP_Locale::get_list_item_separator`
- Replace `$wp_locale->get_list_item_separator()` calls with `wp_get_list_item_separator()`
- Added a compatibility layer for bundled themes
Props SergeyBiryukov, swissspidy, rsiddharth, johnbillion, audrasjb.
Fixes #39733 .
Built from https://develop.svn.wordpress.org/trunk@52929
git-svn-id: http://core.svn.wordpress.org/trunk@52518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-03-13 20:03:01 +00:00
desrosj
a2323a0c63
Twenty Nineteen: Apply coding standards fix from running `composer format`.
...
Follow up to [52149].
See #54392 .
Built from https://develop.svn.wordpress.org/trunk@52182
git-svn-id: http://core.svn.wordpress.org/trunk@51774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-16 15:03:00 +00:00
joedolson
8b53b4960d
Bundled Theme: Display required text field in core themes.
...
Fix Twenty Nineteen and Twenty Twenty-One setting the `logged_in_as` parameter to null, which also eliminated the required field text. See #16206 .
Props sabernhardt, poena.
Fixes #54392 .
Built from https://develop.svn.wordpress.org/trunk@52149
git-svn-id: http://core.svn.wordpress.org/trunk@51741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-12 22:46:59 +00:00
Sergey Biryukov
a2a8b77806
Docs: Synchronize documentation for `wp_get_attachment_image_attributes` filter callbacks in bundled themes:
...
* Twenty Sixteen: Correct the `$attachment` parameter type, use typed array notation.
* Twenty Seventeen: Correct the `$attachment` parameter type, use typed array notation.
* Twenty Nineteen: Correct the `@return` value type, use typed array notation.
* Twenty Twenty-One: Add missing `@return` value description, use typed array notation.
Follow-up to [29836], [47249], [49021], [49597].
Props ankitmaru, mukesh27, SergeyBiryukov.
Fixes #53878 .
Built from https://develop.svn.wordpress.org/trunk@51607
git-svn-id: http://core.svn.wordpress.org/trunk@51218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-12 19:30:57 +00:00
Sergey Biryukov
9c0611e9c0
Bundled Themes: Correct `@since` tags for block patterns.
...
Follow-up to [49347], [49348], [49583], [49584], [49763], [51103].
See #52628 , #53461 .
Built from https://develop.svn.wordpress.org/trunk@51323
git-svn-id: http://core.svn.wordpress.org/trunk@50932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-07-03 09:41:58 +00:00
Sergey Biryukov
aed608b98c
Coding Standards: Remove a one-time `$message` variable in WordPress version requirement notices for bundled themes.
...
This makes the formatting of these messages more consistent.
Follow-up to [23816], [51154].
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@51155
git-svn-id: http://core.svn.wordpress.org/trunk@50764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-15 15:24:58 +00:00
Sergey Biryukov
b618452411
Twenty Nineteen: Remove unnecessary references to some variables in `twentynineteen_hsl_hex()` before they are defined.
...
Props ankitmaru, sabernhardt.
Fixes #49052 .
Built from https://develop.svn.wordpress.org/trunk@49602
git-svn-id: http://core.svn.wordpress.org/trunk@49340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 12:16:09 +00:00
Helen Hou-Sandí
bf02276a17
Bundled Themes: Introduce block patterns for Twenty Nineteen.
...
Including some props I missed on the commit for Twenty Twenty, I am sorry.
Props: kjellr, beafialho, melchoyce, ryelle, jffng, bridgetwillard.
Fixes #51099 .
Built from https://develop.svn.wordpress.org/trunk@49348
git-svn-id: http://core.svn.wordpress.org/trunk@49108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 21:15:12 +00:00
John Blackbourn
c16ae60deb
Docs: Fix and upgrade various `object` docblock notations.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49183
git-svn-id: http://core.svn.wordpress.org/trunk@48945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-17 16:05:09 +00:00
Sergey Biryukov
1f85e7484f
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48782
git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
Sergey Biryukov
3fb623cf76
Docs: Use a hyphen with the "non" prefix in a more consistent way.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48106
git-svn-id: http://core.svn.wordpress.org/trunk@47875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:16:10 +00:00
Sergey Biryukov
58bda42fc8
Docs: Synchronize and correct the documentation for `wp_nav_menu()` arguments in bundled themes.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48103
git-svn-id: http://core.svn.wordpress.org/trunk@47872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 11:22:10 +00:00
Sergey Biryukov
a576a13246
Docs: Remove an empty line between `@param` and `@return` tags, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48102
git-svn-id: http://core.svn.wordpress.org/trunk@47871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 11:18:09 +00:00
John Blackbourn
afe406b82e
Docs: Fix some documentation errors in bundled themes.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48101
git-svn-id: http://core.svn.wordpress.org/trunk@47870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 07:24:06 +00:00
Sergey Biryukov
30b61fc9e8
Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
...
Some themes already had these checks in place as a result of [41756], but not others.
Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860 .
Built from https://develop.svn.wordpress.org/trunk@47886
git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 17:05:13 +00:00
Sergey Biryukov
38676936ba
Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov
762140cc6b
Twenty Nineteen: Add the missing `inc/helper-functions.php` file.
...
Follow-up to [47214].
Props kjellr, jffng.
Fixes #45984 .
Built from https://develop.svn.wordpress.org/trunk@47242
git-svn-id: http://core.svn.wordpress.org/trunk@47042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 19:07:06 +00:00
Sergey Biryukov
297aa098ae
Twenty Nineteen: Improve code organization in `template-functions.php` by moving helper functions into their own file.
...
These functions are moved to `inc/helper-functions.php`:
* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`
Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.
Props akshayar, allancole, grapplerulrich.
Fixes #45984 .
Built from https://develop.svn.wordpress.org/trunk@47214
git-svn-id: http://core.svn.wordpress.org/trunk@47014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-08 13:01:06 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov
6677070a13
Bundled Themes: Correct `@since` tags to refer to the theme version instead of WordPress version.
...
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46827
git-svn-id: http://core.svn.wordpress.org/trunk@46627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 13:56:06 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov
83187125e4
Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting.
...
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981 .
Built from https://develop.svn.wordpress.org/trunk@45768
git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Gary Pendergast
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Sergey Biryukov
abe3ec288b
Twenty Nineteen: Fix markup errors in `twentynineteen_add_ellipses_to_nav()`:
...
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.
Props afercia, chetan200891, ianbelanger.
Fixes #47067 .
Built from https://develop.svn.wordpress.org/trunk@45596
git-svn-id: http://core.svn.wordpress.org/trunk@45407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:23:55 +00:00
Sergey Biryukov
d1815a5c91
Twenty Nineteen: Adjust markup in `twentynineteen_add_ellipses_to_nav()` for better readability.
...
See #47067 .
Built from https://develop.svn.wordpress.org/trunk@45595
git-svn-id: http://core.svn.wordpress.org/trunk@45406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:15:58 +00:00
Sergey Biryukov
aaa3e181a0
Twenty Nineteen: Correct function name in a `function_exists()` check for `twentynineteen_get_user_avatar_markup()`.
...
Props mukesh27, diego-la-monica.
Fixes #46410 .
Built from https://develop.svn.wordpress.org/trunk@45383
git-svn-id: http://core.svn.wordpress.org/trunk@45194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 01:31:54 +00:00
Adam Silverstein
18ccaf962e
Bundled Theme: add a `wp_body_open` shim for older WordPress versions.
...
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.
Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679 .
Built from https://develop.svn.wordpress.org/trunk@45256
git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
laurelfulford
fd8a3db97b
Twenty Nineteen: Update the quote block styles.
...
Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.
Props @kjellr.
Fixes #46239 .
Built from https://develop.svn.wordpress.org/trunk@44739
git-svn-id: http://core.svn.wordpress.org/trunk@44571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-13 18:40:49 +00:00
laurelfulford
dfeda2fb94
Bundled Themes: Bump script and style version numbers.
...
When existing scripts or styles are updated in default themes, the version numbers in the enqueues should also be bumped to make sure the old files don't cache. This update bumps version numbers for changes since version 5.0, for themes Twenty Eleven through Twenty Nineteen.
Fixes #45679 .
Built from https://develop.svn.wordpress.org/trunk@44382
git-svn-id: http://core.svn.wordpress.org/trunk@44212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-02 18:04:50 +00:00
laurelfulford
fcc423097c
Twenty Nineteen: Improve menu semantics and keyboard navigation.
...
The menu's original markup included some non-semantic tags and an unnecessary `tabindex` attribute that made it difficult to navigate via keyboard.
Props allancole, anevins, kjellr.
Fixes #45713 .
Built from https://develop.svn.wordpress.org/trunk@44376
git-svn-id: http://core.svn.wordpress.org/trunk@44206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-31 17:49:50 +00:00
desrosj
a2845863e5
Twenty Nineteen: Fixes and improvements.
...
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.
- Fix the gallery caption link color. https://github.com/WordPress/twentynineteen/pull/687
- Remove left padding from pullquote blocks. https://github.com/WordPress/twentynineteen/pull/690
- Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github
.com/WordPress/twentynineteen/pull/47
- Fix and improve some strings with placeholders. https://github.com/WordPress/twentynineteen/pull/217
- Fixes some minor code quality issues. https://github.com/WordPress/twentynineteen/pull/237
- Fix PHP Warning: Parameter must be an array or an object that implements Countable. https://github
.com/WordPress/twentynineteen/pull/661
- Add missing text domain and escaping to comment author text. https://github.com/WordPress/twentynineteen/pull/274
- Remove hyphens rule for cover image text. https://github.com/WordPress/twentynineteen/pull/691
- Fix left/right-aligned pullquote spacing. https://github.com/WordPress/twentynineteen/pull/695
- Improve `readme.txt` to follow the correct standards for themes. https://github.com/WordPress/twentynineteen/issues/689
Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj.
Merges [44196], [44199], and [44201-44202] into trunk.
Fixes #45424 .
Built from https://develop.svn.wordpress.org/trunk@44305
git-svn-id: http://core.svn.wordpress.org/trunk@44135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-19 03:24:11 +00:00
desrosj
01029daf49
Updating Twenty Nineteen, the new default theme for 2019.
...
This update changes the following:
- Properly sets the primary color hue theme option. See https://github.com/WordPress/twentynineteen/pull/683 .
- Add proper frontend styles for center aligned archive and category blocks. See https://github.com/WordPress/twentynineteen/pull/684 .
- Fix `image_filter` theme option conditional function. See https://github.com/WordPress/twentynineteen/pull/680 .
- Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See https://github.com/WordPress/twentynineteen/pull/686 .
Props richtabor, kjellr, allancole.
Merges [44192] and [44193] to trunk.
See #45424 .
Built from https://develop.svn.wordpress.org/trunk@44302
git-svn-id: http://core.svn.wordpress.org/trunk@44132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-19 03:21:42 +00:00
desrosj
110aae8048
Twenty Nineteen: Code Quality Improvements.
...
This change adds general code quality and documentation improvements.
More info here: https://github.com/WordPress/twentynineteen/pull/546
Props grapplerulrich, iCaleb, allancole.
Merges [44187] to trunk.
See #45424 .
Built from https://develop.svn.wordpress.org/trunk@44298
git-svn-id: http://core.svn.wordpress.org/trunk@44128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-19 03:18:26 +00:00
Gary Pendergast
9c8a29c889
General: Fix some code formatting issues.
...
A handful of code formatting issues were introduced in recent commits, runs the auto-fixer on them.
Built from https://develop.svn.wordpress.org/trunk@44155
git-svn-id: http://core.svn.wordpress.org/trunk@43985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-14 03:25:40 +00:00
Gary Pendergast
5432b8e055
Default Themes: Import Twenty Nineteen from the 5.0 branch.
...
Merges [43808,43821,43842,43860,43892,43904,43909,43926-43929,43956,43961-43963] from the 5.0 branch to trunk.
Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, jorbin, netweb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins, peterwilsoncc, dannycooper, iCaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, grapplerulrich, ocean90, joshfeck, frankew, AbdulWahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, nao, mayukojpn, enodekciw, ketuchetan, atanasangelovdev, poena, sharaz, artisticasad, mukesh27, burhandodhy, crunnells, aprakasa, themeroots, imonly_ik, tlxo, youthkee, brentswisher, smyoon315, mrahmadawais, desideveloper, Kau-Boy, mor10, mikeyarce, dingo_bastard, xkon, twoabove.
Fixes #45424 .
Built from https://develop.svn.wordpress.org/trunk@44149
git-svn-id: http://core.svn.wordpress.org/trunk@43979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-14 02:33:41 +00:00