Sergey Biryukov
b2411e9e3f
Administration: Make sure `wp.updates.addAdminNotice` is displayed after the page header and does not unexpectedly push down "Add New" and other buttons.
...
Props shivapoudel.
Fixes #41221 .
Built from https://develop.svn.wordpress.org/trunk@42700
git-svn-id: http://core.svn.wordpress.org/trunk@42528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 17:28:30 +00:00
Sergey Biryukov
e1e041271e
Docs: Fix typo in `term_exists()` DocBlock.
...
Props milana_cap, danieltj.
Fixes #43268 .
Built from https://develop.svn.wordpress.org/trunk@42699
git-svn-id: http://core.svn.wordpress.org/trunk@42527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 17:16:29 +00:00
Sergey Biryukov
4a55ea5e68
Networks and Sites: In `get_site_by_path()`, use single `domain` and `path` parameters if there's only one item to look for.
...
This should increase the chances of `WP_Site_Query::get_sites()` hitting an existing cache.
Props spacedmonkey.
Fixes #42299 .
Built from https://develop.svn.wordpress.org/trunk@42698
git-svn-id: http://core.svn.wordpress.org/trunk@42526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 17:09:31 +00:00
Sergey Biryukov
f88dddcab5
Media: Add `aac` to the list of allowed file types.
...
Props desrosj.
Fixes #42919 .
Built from https://develop.svn.wordpress.org/trunk@42697
git-svn-id: http://core.svn.wordpress.org/trunk@42525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 16:40:31 +00:00
Sergey Biryukov
3de0634199
Docs: Fix typo in `wp_audio_extensions` and `wp_video_extensions` filter descriptions.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42696
git-svn-id: http://core.svn.wordpress.org/trunk@42524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 16:29:30 +00:00
Sergey Biryukov
e6322d0afe
Media: In `WP_Image_Editor::make_image()`, close previously opened output buffer if the file could not be created.
...
Props dhanendran, gnif.
Fixes #43255 .
Built from https://develop.svn.wordpress.org/trunk@42695
git-svn-id: http://core.svn.wordpress.org/trunk@42523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 16:25:31 +00:00
Sergey Biryukov
beeafbc7ec
Media: After [42693], update HTML4 markup in `img_caption_shortcode()` to avoid an empty ID attribute as well.
...
Add a unit test for `aria-describedby` in `img_caption_shortcode()`.
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42694
git-svn-id: http://core.svn.wordpress.org/trunk@42522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 15:40:30 +00:00
Sergey Biryukov
0f2b559d05
Media: Only add `aria-describedby` in `img_caption_shortcode()` if a non-empty attachment ID attribute was provided.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42693
git-svn-id: http://core.svn.wordpress.org/trunk@42521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 15:20:30 +00:00
Sergey Biryukov
dffe5deb97
Media: Make sure `$caption_id` does not depend on an undefined variable.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42692
git-svn-id: http://core.svn.wordpress.org/trunk@42520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 14:53:30 +00:00
Sergey Biryukov
3e19b66f40
Media: Add `aria-describedby` to `img_caption_shortcode()` output to improve image/caption relationship.
...
Props joedolson.
Fixes #34595 .
Built from https://develop.svn.wordpress.org/trunk@42691
git-svn-id: http://core.svn.wordpress.org/trunk@42519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 14:44:30 +00:00
Sergey Biryukov
8df00f0354
Media: Convert concatenation in `img_caption_shortcode()` to `sprintf()` for clarity.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42690
git-svn-id: http://core.svn.wordpress.org/trunk@42518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 14:17:30 +00:00
Sergey Biryukov
7a8e4bcb1b
Administration: Remove erroneous `transition-delay` values from CSS files.
...
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.
Props chetan200891, manuel_84, GaryJ.
Fixes #43195 .
Built from https://develop.svn.wordpress.org/trunk@42689
git-svn-id: http://core.svn.wordpress.org/trunk@42517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 12:55:30 +00:00
Sergey Biryukov
e97d2c0407
Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed.
...
Props dilipbheda.
Fixes #43106 . See #16470 .
Built from https://develop.svn.wordpress.org/trunk@42688
git-svn-id: http://core.svn.wordpress.org/trunk@42516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 12:23:31 +00:00
Sergey Biryukov
12f854b6e8
Build/Test Tools: Update prefixed CSS properties in `about.css`.
...
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.
Props netweb, afercia.
Fixes #43190 .
Built from https://develop.svn.wordpress.org/trunk@42687
git-svn-id: http://core.svn.wordpress.org/trunk@42515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 23:47:31 +00:00
Sergey Biryukov
903224cce4
Plugins: Use correct variable name in `install_plugin_information()`.
...
Props afragen.
Fixes #43282 . See #43192 , #29274 .
Built from https://develop.svn.wordpress.org/trunk@42686
git-svn-id: http://core.svn.wordpress.org/trunk@42514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 22:08:30 +00:00
Sergey Biryukov
b1f48870d7
Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity.
...
Props xkon, karmatosed.
Fixes #43072 .
Built from https://develop.svn.wordpress.org/trunk@42685
git-svn-id: http://core.svn.wordpress.org/trunk@42513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 08:43:32 +00:00
John Blackbourn
ee24b48106
Comments: Add a "Mine" link to the list of filters on the comment listing screen.
...
This filter shows comments made by the current user, and copies the same filter functionality that's available on the post listing screens.
Props Iceable
Fixes #42379
Built from https://develop.svn.wordpress.org/trunk@42684
git-svn-id: http://core.svn.wordpress.org/trunk@42512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:46:31 +00:00
Drew Jaynes
1ae9491548
Docs: Fix a copy paste error in the DocBlock summary for `wp_ssl_constants()`, see [13062].
...
Props terriann.
Fixes #43272 .
Built from https://develop.svn.wordpress.org/trunk@42683
git-svn-id: http://core.svn.wordpress.org/trunk@42511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:21:31 +00:00
John Blackbourn
b1ed10ab9a
HTTP API: Add the URL as a paramter to various HTTP related filters.
...
Props paulschreiber, purnendu
Fixes #42186
Built from https://develop.svn.wordpress.org/trunk@42682
git-svn-id: http://core.svn.wordpress.org/trunk@42510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:11:30 +00:00
John Blackbourn
427ae1692d
Docs: Un-correct an incorrection correction.
...
See [42680]
See #42505
Built from https://develop.svn.wordpress.org/trunk@42681
git-svn-id: http://core.svn.wordpress.org/trunk@42509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:57:30 +00:00
John Blackbourn
763f34d117
Docs: Correct some secondary documentation for the `https_local_ssl_verify` and `https_ssl_verify` filters.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42680
git-svn-id: http://core.svn.wordpress.org/trunk@42508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:48:29 +00:00
John Blackbourn
fc6ba86b80
Docs: First pass at switching some array parameter documentation to typed notation.
...
Props janak007
See #41756
Built from https://develop.svn.wordpress.org/trunk@42679
git-svn-id: http://core.svn.wordpress.org/trunk@42507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:26:31 +00:00
John Blackbourn
91464bce65
Docs: Add missing code formatting to various `@since` entries.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42678
git-svn-id: http://core.svn.wordpress.org/trunk@42506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 16:55:31 +00:00
John Blackbourn
823cac40df
Docs: Update the hook docs for `update_bulk_theme_complete_actions`.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42677
git-svn-id: http://core.svn.wordpress.org/trunk@42505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 16:22:45 +00:00
John Blackbourn
332b9844a9
Posts, Post Types: Add a new `add_inline_data` action which allows extra fields to be added to the inline editing fields.
...
Props mensmaximus, NathanAtmoz
Fixes #36085
Built from https://develop.svn.wordpress.org/trunk@42676
git-svn-id: http://core.svn.wordpress.org/trunk@42504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 15:55:32 +00:00
atimmer
8ad4538d0f
Docs: Improve JSDoc for `media/views/spinner.js`.
...
Props avillegasn.
Fixes #43230 .
Built from https://develop.svn.wordpress.org/trunk@42675
git-svn-id: http://core.svn.wordpress.org/trunk@42503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 14:32:33 +00:00
Sergey Biryukov
b9944def27
Posts, Post Types: Remove extra tabs around `page_attributes_meta_box_template` action in `page_attributes_meta_box()`.
...
Props chetan200891.
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42674
git-svn-id: http://core.svn.wordpress.org/trunk@42502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 11:24:32 +00:00
Sergey Biryukov
ef4f47d00f
Customize: Avoid extra tabs in a textarea in `WP_Customize_Control::render_content()`.
...
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42673
git-svn-id: http://core.svn.wordpress.org/trunk@42501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:59:30 +00:00
Sergey Biryukov
a5958a289b
Upgrade/Install: Avoid extra line breaks in a textarea in `wp-admin/setup-config.php`.
...
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42672
git-svn-id: http://core.svn.wordpress.org/trunk@42500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:59:00 +00:00
Sergey Biryukov
a65ce4e34b
Options: Avoid extra tabs in a textarea in `wp-admin/options.php`.
...
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42671
git-svn-id: http://core.svn.wordpress.org/trunk@42499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:58:31 +00:00
Sergey Biryukov
cceab04984
Comments: Avoid extra tabs in a textarea in `WP_Comments_List_Table::column_comment()`.
...
Props chetan200891, jrf.
Fixes #43252 .
Built from https://develop.svn.wordpress.org/trunk@42670
git-svn-id: http://core.svn.wordpress.org/trunk@42498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:57:32 +00:00
Helen Hou-Sandí
aaa28bba15
Options: Use strings in the test suite that follow community guidelines.
...
Also somewhat explain to future maintainers why this pairing of strings was chosen, besides this committer's musical preferences. Social opinions on cancer are fairly clear, as are commonly accepted definitions of profanity and family-friendly language.
Shout out to the close contender, which would have been particularly appropriate here: "You could be the king // But watch the queen conquer".
see #43207 , #38176
Built from https://develop.svn.wordpress.org/trunk@42667
git-svn-id: http://core.svn.wordpress.org/trunk@42495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 22:42:31 +00:00
John Blackbourn
1c2ef0f475
Build/Test Tools: Allow code coverage reports to be generated.
...
This corrects the attribute needed to allow PHPUnit to generate coverage reports, and also adds a blacklist of files and directories that are excluded from coverage reports.
Props schlessera, jipmoors
Fixes #43067 , #43240
Built from https://develop.svn.wordpress.org/trunk@42665
git-svn-id: http://core.svn.wordpress.org/trunk@42494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 22:21:30 +00:00
John Blackbourn
f7224ea635
Docs: Copy a helpful inline doc into the function header for visibility.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42664
git-svn-id: http://core.svn.wordpress.org/trunk@42493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 22:13:30 +00:00
Aaron Jorbin
17589837d2
Options: Use most appropriate language in the test suite.
...
The test suite's opinion of cancer should be clear.
Reverts r42659.
See #43207 , #38176
Built from https://develop.svn.wordpress.org/trunk@42663
git-svn-id: http://core.svn.wordpress.org/trunk@42492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 20:59:31 +00:00
Boone Gorges
355b6e80da
Improve parameter description for 'allow_empty_comments'.
...
Introduced in [42661].
Props swissspidy.
See #16979 .
Built from https://develop.svn.wordpress.org/trunk@42662
git-svn-id: http://core.svn.wordpress.org/trunk@42491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 20:50:30 +00:00
Boone Gorges
6c11ac0c16
Comments: Introduce 'allow_empty_comment' filter.
...
This filter allows plugin authors to allow empty comments on a selective
basis during comment submission.
Props jpurdy647.
Fixes #16979 .
Built from https://develop.svn.wordpress.org/trunk@42661
git-svn-id: http://core.svn.wordpress.org/trunk@42490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 20:09:30 +00:00
Drew Jaynes
39ce01d83a
Docs: Fix a typo in the DocBlock description for `get_bloginfo()` illustrating the URL structure for RDF feeds.
...
Props ibachal.
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42660
git-svn-id: http://core.svn.wordpress.org/trunk@42489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 19:42:30 +00:00
John Blackbourn
982791db31
Options: Use more appropriate language in the test suite.
...
See #43207 , #38176
Built from https://develop.svn.wordpress.org/trunk@42659
git-svn-id: http://core.svn.wordpress.org/trunk@42488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 18:52:31 +00:00
Drew Jaynes
9dd9913ecd
Docs: Document default arguments for `wp_tag_cloud()` in a hash notation, noting that full lists of additionally-supported arguments are already documented in `get_terms()` and `wp_generate_tag_cloud()`.
...
Props birgire, johnbillion.
Fixes #42019 .
Built from https://develop.svn.wordpress.org/trunk@42658
git-svn-id: http://core.svn.wordpress.org/trunk@42487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 15:22:34 +00:00
Felix Arntz
f3eaddd2dc
Options: Unhook default option filter when setting is unregistered.
...
Fixes #43207 .
Built from https://develop.svn.wordpress.org/trunk@42655
git-svn-id: http://core.svn.wordpress.org/trunk@42484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-06 14:49:32 +00:00
Dion Hulse
3517dc0b8b
Updates: Partially revert [42584], as this branch of code should always be run after a core update check.
...
This code branch is responsible for running all autoupdates, including plugins and themes - which should run regardless of if there's a core autoupdate available.
This revert does not revert the `$timeout` changes, as these should still use cached data if it's available.
Ideally this should be decoupled from the core update check to allow background updates to operate even when the core update check is disabled or running more often than twice daily.
See #43103 .
Built from https://develop.svn.wordpress.org/trunk@42653
git-svn-id: http://core.svn.wordpress.org/trunk@42482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-06 11:04:34 +00:00
Dion Hulse
0eb9e0c8d0
XML-RPC: Add default values to IXR_Message for PHP 7.2 compatibility to avoid PHP Warnings.
...
Fixes #43216 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42652
git-svn-id: http://core.svn.wordpress.org/trunk@42481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-06 02:56:32 +00:00
Peter Wilson
8f0ab2efb8
Taxonomy: Stop warming term meta cache unnecessarily.
...
Prevent several core function calls to `get_terms()` from warming the term meta cache.
Props peterwilsoncc, boonebgorges, jrf.
Fixes #43142 .
Built from https://develop.svn.wordpress.org/trunk@42649
git-svn-id: http://core.svn.wordpress.org/trunk@42478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-05 04:10:30 +00:00
Peter Wilson
0d39b35c11
General: Replace `Cheatin’ uh?` with friendlier error messages.
...
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.
Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332 .
Built from https://develop.svn.wordpress.org/trunk@42648
git-svn-id: http://core.svn.wordpress.org/trunk@42477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-05 02:30:34 +00:00
John Blackbourn
a1eb261cd1
Canonical: Add `$x_redirect_by` parameter to `wp_safe_redirect()`.
...
See [42633] and [42408].
Fixes #42313 .
Built from https://develop.svn.wordpress.org/trunk@42647
git-svn-id: http://core.svn.wordpress.org/trunk@42476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-04 16:05:32 +00:00
Drew Jaynes
f3ca5b5f47
Tests: Simplify `@covers` annotations for `WP_Error` test coverage. Also fix a typo in a test method name.
...
See #42742 .
Built from https://develop.svn.wordpress.org/trunk@42646
git-svn-id: http://core.svn.wordpress.org/trunk@42475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 17:38:30 +00:00
Drew Jaynes
3544e0151d
Tests: Fix two typos introduced for a get_term_field() test in [35270].
...
See #33968 .
Built from https://develop.svn.wordpress.org/trunk@42645
git-svn-id: http://core.svn.wordpress.org/trunk@42474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 17:11:30 +00:00
Andrea Fercia
8a664edcab
Administration: Make the Screen Options available on small screens.
...
Previously, the Screen Options toggle and the related panel content
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.
Props chetan200891.
Fixes #40985 .
Built from https://develop.svn.wordpress.org/trunk@42644
git-svn-id: http://core.svn.wordpress.org/trunk@42473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 16:58:30 +00:00
Sergey Biryukov
430a724a03
Help/About: Correct outdated media icons reference in help text on Edit Post screen.
...
Props thrijith, transl8or.
Fixes #42378 .
Built from https://develop.svn.wordpress.org/trunk@42643
git-svn-id: http://core.svn.wordpress.org/trunk@42472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 13:58:30 +00:00