Boone Gorges
b5d12e130c
Comments: Restore the ability to bypass post_id filter using 0 or '0'.
...
The changes introduced in [36381], while logical and clearly awesome, introduce
the potential for much breakage. Those who want to query for comments with a
null `comment_post_ID` should use `'post_in' => array( 0 )` instead.
Reverts [36381], [36387].
See #35090 .
Built from https://develop.svn.wordpress.org/trunk@36480
git-svn-id: http://core.svn.wordpress.org/trunk@36447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:50:25 +00:00
Drew Jaynes
26bf8cda9b
Docs: Add more complete information to DocBlocks for private core functions `_wp_dashboard_control_callback()` and `_wp_dashboard_recent_comments_row()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36474
git-svn-id: http://core.svn.wordpress.org/trunk@36441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:20:26 +00:00
Drew Jaynes
6995ec613e
Docs: Add private access notation to the DocBlock for the core `_wp_handle_upload()` function.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36473
git-svn-id: http://core.svn.wordpress.org/trunk@36440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:19:25 +00:00
Drew Jaynes
d62a1bf1e9
Docs: Mark two private functions as such in wp-admin/ajax-actions.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36472
git-svn-id: http://core.svn.wordpress.org/trunk@36439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:17:26 +00:00
Dominik Schilling
cd892b86b4
Media: In `wp_read_image_metadata()` make sure that IPTC keywords are UTF8 encoded.
...
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.
Fixes #35316 .
Built from https://develop.svn.wordpress.org/trunk@36429
git-svn-id: http://core.svn.wordpress.org/trunk@36396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 14:53:27 +00:00
Andrea Fercia
62d8fda8dd
After [36171] remove all the occurrences of the old CSS clearfix.
...
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.
See #26396 .
Built from https://develop.svn.wordpress.org/trunk@36422
git-svn-id: http://core.svn.wordpress.org/trunk@36389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 13:46:27 +00:00
Eric Lewis
22467e840f
Networks and sites: Replace "blog" usage with "site" in docs.
...
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.
See #35417 .
Built from https://develop.svn.wordpress.org/trunk@36416
git-svn-id: http://core.svn.wordpress.org/trunk@36383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-28 03:35:27 +00:00
Eric Lewis
d01e8db4ad
Plugins: Clarify that mu-plugins can't be "active" in docs.
...
Plugins installed in the plugins/ folder can be activated by users. This puts the plugin in an "active" state. Plugins in the mu-folder/ are "must-use" plugins that are always loaded. They can't be activated, and thereby can't be "active." Because of this, using the `is_plugin_active()` or `is_plugin_active_for_network()` returns false when checking for these plugins. This clarifies that behavior in the functions' docs.
Built from https://develop.svn.wordpress.org/trunk@36397
git-svn-id: http://core.svn.wordpress.org/trunk@36364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 00:32:27 +00:00
Konstantin Obenland
d28ce2a1e4
Pass data consistently on plugin, network plugin, and network theme screens.
...
List tables on these three screens look similar but come with unexpected caveats.
The network themes screen in particular has been neglected, using a `.plugin`
class to inherit its sibling's styles and not providing classes and data
attributes that the other two offer. This will provide some more consistency.
Fixes #35335 .
Built from https://develop.svn.wordpress.org/trunk@36394
git-svn-id: http://core.svn.wordpress.org/trunk@36361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-25 22:55:25 +00:00
Boone Gorges
00cf77999d
In comments list table, `$post_id` should default to `false` rather than 0.
...
After [36381], the default value of `0` was causing the list table at
edit-comments.php to be empty. `false` prevents this.
This fix is likely temporary, while more research is done into the backward
compatibility concerns tied to [36381].
See #35090 .
Built from https://develop.svn.wordpress.org/trunk@36387
git-svn-id: http://core.svn.wordpress.org/trunk@36354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 22:16:26 +00:00
Ella Iseulde Van Dorpe
3663a5bca5
TinyMCE: add inline link dialog
...
First run.
Links the advanced button to the "old" dialog for now.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36384
git-svn-id: http://core.svn.wordpress.org/trunk@36351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 00:08:26 +00:00
Andrea Fercia
450cbb3e81
Accessibility: Remove title attributes from the Menus screen.
...
Also, adds missing labels and improves the existing ones.
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36379
git-svn-id: http://core.svn.wordpress.org/trunk@36346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 14:26:27 +00:00
Sergey Biryukov
7afa923067
Media: In `_wp_handle_upload()`, move ending brace to a new line.
...
Props georgestephanis.
Fixes #35565 .
Built from https://develop.svn.wordpress.org/trunk@36373
git-svn-id: http://core.svn.wordpress.org/trunk@36340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 20:27:26 +00:00
Dion Hulse
65182e4dc8
Upgrade: Switch the locking mechanism to using static methods so that it can be accessed from other upgrade-classes.
...
Fixes #34878
Built from https://develop.svn.wordpress.org/trunk@36370
git-svn-id: http://core.svn.wordpress.org/trunk@36337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 01:22:25 +00:00
Dion Hulse
006ae74d4c
Core Upgrader: Add a locking mechanism to avoid two concurrent updates of WordPress occuring.
...
Fixes #34878
Built from https://develop.svn.wordpress.org/trunk@36349
git-svn-id: http://core.svn.wordpress.org/trunk@36316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-19 05:07:26 +00:00
Rachel Baker
9065794462
List Tables: Use the $GLOBALS array when unsetting the global post and comment in `WP_Comments_List_Table::single_row()`.
...
In r35674 only the local variables were unset, when using `unset()` with a global variable the `$GLOBALS` array must be used.
Fixes #35506 .
Built from https://develop.svn.wordpress.org/trunk@36339
git-svn-id: http://core.svn.wordpress.org/trunk@36306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-18 02:50:27 +00:00
Andrea Fercia
82c596594b
After [36333] correctly use `esc_attr()` instead of `esc_attr__()`.
...
See #35313 .
Built from https://develop.svn.wordpress.org/trunk@36334
git-svn-id: http://core.svn.wordpress.org/trunk@36301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 16:03:25 +00:00
Andrea Fercia
497de1d658
Accessibility: Remove title attributes from the Posts list table.
...
Fixes #35313 .
Built from https://develop.svn.wordpress.org/trunk@36333
git-svn-id: http://core.svn.wordpress.org/trunk@36300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 15:47:26 +00:00
Andrea Fercia
1183b06bc5
Accessibility: Remove title attributes from the Media Library list table.
...
Fixes #35136 .
Built from https://develop.svn.wordpress.org/trunk@36331
git-svn-id: http://core.svn.wordpress.org/trunk@36298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-17 14:46:29 +00:00
Dominik Schilling
3b3ded01a0
Media: Update some attach/detach strings in the columns view.
...
* Show a "Media attachment reattached."/"Media attachment detached." message when only one attachment was attached/detached.
* Use the string placeholder as `number_format_i18n()` returns a string.
* Add translator comments.
* Update help text to refer to the new dropdown menus.
* Add a more generic title to the attach modal.
Fixes #33237 .
Built from https://develop.svn.wordpress.org/trunk@36328
git-svn-id: http://core.svn.wordpress.org/trunk@36295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-15 22:29:25 +00:00
Pascal Birchler
aaa11d6207
Allow searching for `0` throughout the admin.
...
Fixes #31025 .
Built from https://develop.svn.wordpress.org/trunk@36302
git-svn-id: http://core.svn.wordpress.org/trunk@36269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 20:06:25 +00:00
Pascal Birchler
d4b30f47bf
Plugins: Prevent a warning when searching in the plugins list table.
...
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.
Fixes #35461 .
Built from https://develop.svn.wordpress.org/trunk@36301
git-svn-id: http://core.svn.wordpress.org/trunk@36268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 20:00:29 +00:00
Andrea Fercia
2d76f3cb83
Accessibility: Remove title attributes from the Comments screen.
...
Fixes #35304 .
Built from https://develop.svn.wordpress.org/trunk@36298
git-svn-id: http://core.svn.wordpress.org/trunk@36265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 16:04:27 +00:00
Pascal Birchler
ded3a1d72f
Plugins: Make sure the 'Beta testing' tab is first in the plugin installer.
...
This makes feature plugins more discoverable for people running development builds.
Fixes #29631 .
Built from https://develop.svn.wordpress.org/trunk@36297
git-svn-id: http://core.svn.wordpress.org/trunk@36264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 09:07:26 +00:00
Dominik Schilling
0a6f311922
Plugins: In `_get_plugin_data_markup_translate()` remove the fallback to the "default" textdomain for Akismet.
...
Akismet has its own language files since WordPress 3.9.
Props jrf.
Fixes #35436 .
Built from https://develop.svn.wordpress.org/trunk@36283
git-svn-id: http://core.svn.wordpress.org/trunk@36250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 13:56:26 +00:00
Dominik Schilling
a51129c2a6
Plugins: In `_get_plugin_data_markup_translate()` don't reload translations if they're already loaded.
...
Props jrf.
Fixes #35439 .
Built from https://develop.svn.wordpress.org/trunk@36282
git-svn-id: http://core.svn.wordpress.org/trunk@36249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 13:04:27 +00:00
Andrea Fercia
5bd888497d
Accessibility: Remove title attributes from the Terms list table.
...
Fixes #35187 .
Built from https://develop.svn.wordpress.org/trunk@36265
git-svn-id: http://core.svn.wordpress.org/trunk@36232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 23:30:26 +00:00
Andrea Fercia
057ec3cec0
Accessibility: Remove title attributes from the General Settings screen.
...
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.
Props afercia, perezlabs.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36263
git-svn-id: http://core.svn.wordpress.org/trunk@36230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 22:54:28 +00:00
Pascal Birchler
d63ae29fac
After [36254], commit all the necessary files and not just the unit test.
...
Built from https://develop.svn.wordpress.org/trunk@36255
git-svn-id: http://core.svn.wordpress.org/trunk@36222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 19:07:26 +00:00
John Blackbourn
a4facedfee
Docs: Various docblock corrections.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36250
git-svn-id: http://core.svn.wordpress.org/trunk@36217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:26:25 +00:00
John Blackbourn
f63dc802cb
Comments: Correct the docblocks for various methods in the comment list table class.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36248
git-svn-id: http://core.svn.wordpress.org/trunk@36215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 00:52:25 +00:00
John Blackbourn
a5d44337b2
Docs: `@param` fixes for a variety of docblocks.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36232
git-svn-id: http://core.svn.wordpress.org/trunk@36199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:45:26 +00:00
John Blackbourn
7718e07129
Docs: Correct the parameter docs for various Heartbeat filters and functions.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36231
git-svn-id: http://core.svn.wordpress.org/trunk@36198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:37:26 +00:00
Andrea Fercia
ae1575bd80
Media: make the Image Editor usable with a keyboard.
...
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.
Fixes #28864 .
Built from https://develop.svn.wordpress.org/trunk@36223
git-svn-id: http://core.svn.wordpress.org/trunk@36190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:13:26 +00:00
Konstantin Obenland
c252e77ce3
Plugins: Use plugin file rather than slug as identifier
...
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.
See [36205].
Fixes #35350 .
Built from https://develop.svn.wordpress.org/trunk@36221
git-svn-id: http://core.svn.wordpress.org/trunk@36188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 17:48:28 +00:00
Konstantin Obenland
0b9f825e29
Plugins: Avoid ID attribute collisions in plugins list table.
...
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.
Props khag7.
Fixes #18974 .
Built from https://develop.svn.wordpress.org/trunk@36205
git-svn-id: http://core.svn.wordpress.org/trunk@36172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:40:26 +00:00
Dion Hulse
06a3f799e7
Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place.
...
See #27772 , #35323 .
Built from https://develop.svn.wordpress.org/trunk@36180
git-svn-id: http://core.svn.wordpress.org/trunk@36147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 06:12:26 +00:00
Andrea Fercia
b4cc1cfc48
Accessibility: Remove title attributes from the Admin Dashboard.
...
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.
Fixes #35049 .
Built from https://develop.svn.wordpress.org/trunk@36172
git-svn-id: http://core.svn.wordpress.org/trunk@36139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 14:19:28 +00:00
Dominik Schilling
ef3442a2fe
Docs: Remove indentation from the `hidden_columns` changelog entry.
...
Added in [36154].
See #35057 .
Built from https://develop.svn.wordpress.org/trunk@36156
git-svn-id: http://core.svn.wordpress.org/trunk@36122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 15:16:28 +00:00
Dion Hulse
f802d26f10
List Tables: When a user has hidden all columns, do not override that with the `default_hidden_columns` filter.
...
Props Compute, jorbin, voldemortensen.
Fixes #35057
Built from https://develop.svn.wordpress.org/trunk@36154
git-svn-id: http://core.svn.wordpress.org/trunk@36120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 04:44:27 +00:00
Andrea Fercia
f13881d4e3
Admin: Restore the "Show advanced menu properties" checkboxes IDs.
...
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.
Fixes #35112 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36137
git-svn-id: http://core.svn.wordpress.org/trunk@36103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:52:26 +00:00
Pascal Birchler
7e516f5cf8
Plugins: Add a new `pre_uninstall_plugin` action that runs right before uninstalling a plugin.
...
Fixes #34569 .
Built from https://develop.svn.wordpress.org/trunk@36124
git-svn-id: http://core.svn.wordpress.org/trunk@36090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 22:38:26 +00:00
Sergey Biryukov
5540c0b8db
Import: Add a missing space to `post_exists()`.
...
The lack of space resulted in SQL error when searching for posts by content.
Props yetAnotherDaniel, johnbillion.
Fixes #35246 .
Built from https://develop.svn.wordpress.org/trunk@36113
git-svn-id: http://core.svn.wordpress.org/trunk@36078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 19:07:28 +00:00
Dion Hulse
1d19b930fc
Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive.
...
Props kucrut.
Fixes #34449 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36095
git-svn-id: http://core.svn.wordpress.org/trunk@36060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:05:25 +00:00
Sergey Biryukov
7270205975
Remove redundant title attribute from `wp_star_rating()`. Hide the visible number of ratings from assistive technologies.
...
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.
Props afercia.
Fixes #35141 .
Built from https://develop.svn.wordpress.org/trunk@36092
git-svn-id: http://core.svn.wordpress.org/trunk@36057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:48:27 +00:00
Aaron Jorbin
94aac7055c
Help Tab Order should be based on the Priority Argument
...
[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.
Props meitar, swissspidy, jorbin
Fixes #35215 . See #33941 .
Built from https://develop.svn.wordpress.org/trunk@36089
git-svn-id: http://core.svn.wordpress.org/trunk@36054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 22:44:27 +00:00
Sergey Biryukov
2328667dc9
Theme Editor: Break `$wp_file_descriptions` array into sections and reorder for consistency and readability.
...
Props ramiy.
Fixes #35223 .
Built from https://develop.svn.wordpress.org/trunk@36088
git-svn-id: http://core.svn.wordpress.org/trunk@36053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 21:12:26 +00:00
Sergey Biryukov
11b89a88a9
Theme Editor: Add `taxonomy.php`, `home.php`, `front-page.php`, `date.php`, and `singular.php` to file descriptions.
...
Props ramiy.
See #35223 .
Built from https://develop.svn.wordpress.org/trunk@36087
git-svn-id: http://core.svn.wordpress.org/trunk@36052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-25 21:05:25 +00:00
Drew Jaynes
5a69733045
Docs: Properly mark the optional `$redirect`, `$network_wide`, and `$silent` parameters as such in the DocBlock for `activate_plugin()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36072
git-svn-id: http://core.svn.wordpress.org/trunk@36037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 07:00:27 +00:00
Drew Jaynes
0a314eed32
Docs: Add missing `@since` and properly mark the optional `$type` parameter as such in the DocBlock for the deprecated `get_others_unpublished_posts()` function.
...
Introduced in [5707].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36071
git-svn-id: http://core.svn.wordpress.org/trunk@36036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 06:58:25 +00:00