WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
40,339 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

40339 Commits

Author SHA1 Message Date
whyisjake b6f7c0cbc4 Administration: Ensure visual consistency with large titles in the sidebar. 
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46332


git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 21:51:57 +00:00
Andrea Fercia 66dd6814e7 Media: Restore the original Image Editor columns layout after [46326]. 
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46331


git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:37:57 +00:00
whyisjake c034f5b4c3 Menus: Replace http with https in placeholders. 
Encourage the use of https with the placeholder text in menus.

Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.

Built from https://develop.svn.wordpress.org/trunk@46330


git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:32:55 +00:00
Sergey Biryukov 1d334b273e Tests: Correct `::assertArrayHasKey()` capitalization in [46252]. 
Props dkarfa, david.binda.
Fixes #48155.
Built from https://develop.svn.wordpress.org/trunk@46329


git-svn-id: http://core.svn.wordpress.org/trunk@46128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:31:58 +00:00
John Blackbourn f73a22a98a Themes: Add a test to ensure `get_template_part()` does not return a value. 
This function must not be modified to return anything due to existing themes which output the return value, for example via `echo get_template_part( ... )`.

See #40969

Built from https://develop.svn.wordpress.org/trunk@46328


git-svn-id: http://core.svn.wordpress.org/trunk@46127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:26:59 +00:00
whyisjake 3c0f10e397 Themes: Docblock cleanup for `get_theme_root_uri()` 
In the function docblock of `get_theme_root_uri()`, the argument types of `$stylesheet_or_template` and `$theme_root` do not match. Default values of arguments are boolean but in function doc they are stated as strings.

Props subrataemfluence, williampatton, garrett-eclipse.
Fixes #44397.

Built from https://develop.svn.wordpress.org/trunk@46327


git-svn-id: http://core.svn.wordpress.org/trunk@46126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:21:58 +00:00
Andrea Fercia 93dd6d907a Accessibility: Media: Make the Image Editor buttons text visible. 
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46326


git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 17:16:57 +00:00
desrosj 8affbd6404 Docs: Correct typos introduced in [46324] 
Props TimothyBlynJacobs.
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46325


git-svn-id: http://core.svn.wordpress.org/trunk@46124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 16:32:58 +00:00
desrosj 1e8ed99eca Site Health: Consolidate documentation for the `admin_email_check_interval` filter. 
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46324


git-svn-id: http://core.svn.wordpress.org/trunk@46123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 15:45:58 +00:00
desrosj 0f99e345fa Site Health: Allow the capability required for the site admin email verification screen to be filtered. 
Props desrosj, Clorith.
Fixes #48153.
Built from https://develop.svn.wordpress.org/trunk@46323


git-svn-id: http://core.svn.wordpress.org/trunk@46122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 15:41:57 +00:00
Sergey Biryukov 8bb8e77ace Code Modernisation: Introduce the spread operator in `do_action()`. 
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46322


git-svn-id: http://core.svn.wordpress.org/trunk@46121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 13:53:58 +00:00
Andrea Fercia abb00ee8a4 Media: Fix JavaScript TypeError after [45376]. 
Props desrosj, afercia.
Fixes #48021.

Built from https://develop.svn.wordpress.org/trunk@46321


git-svn-id: http://core.svn.wordpress.org/trunk@46120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 13:06:56 +00:00
Gary Pendergast 2a8854ca9d Build Tools: Pass the current uid/gid to Docker containers. 
This prepares for an upcoming change to the Docker images, which improves file permission handling.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@46320


git-svn-id: http://core.svn.wordpress.org/trunk@46119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 04:58:58 +00:00
Sergey Biryukov 0a5cd17f98 Login and Registration: Standardize on `6 * MONTH_IN_SECONDS` over `180 * DAY_IN_SECONDS` for `admin_email_check_interval` filter. 
[45788] changed the first instance, but not the second.

Props tmatsuur.
Fixes #48144.
Built from https://develop.svn.wordpress.org/trunk@46319


git-svn-id: http://core.svn.wordpress.org/trunk@46118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 02:29:58 +00:00
Sergey Biryukov 8ef4150dc6 REST API: Use delta comparison for floating date test added in [46279] to avoid race conditions. 
See #48113.
Built from https://develop.svn.wordpress.org/trunk@46318


git-svn-id: http://core.svn.wordpress.org/trunk@46117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:40:58 +00:00
Sergey Biryukov da8ebc6fc9 Coding Standards: Remove inline assignment in `test_wp_delete_term_should_invalidate_cache()`. 
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46317


git-svn-id: http://core.svn.wordpress.org/trunk@46116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:34:58 +00:00
Sergey Biryukov 6e8f550770 General: Correct strict comparison in `WP_Links_List_Table::column_categories()` introduced in [46313]. 
`$cat_id` is a string, `$category` is an integer.

See #48142.
Built from https://develop.svn.wordpress.org/trunk@46316


git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:24:56 +00:00
Sergey Biryukov 148322a970 Docs: Improve documentation for `_post_states()` and `get_post_states()`. 
Add documentation for `_media_states()`.

See #47110.
Built from https://develop.svn.wordpress.org/trunk@46315


git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 00:57:58 +00:00
whyisjake a351243928 General: Further phpcs cleanup. 
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.

Props: whyisjake, garrett-eclipse, desrosj

Built from https://develop.svn.wordpress.org/trunk@46314


git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 00:37:58 +00:00
whyisjake d53b773a47 General: Further phpcs cleanup. 
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.
Props whyisjake, garrett-eclipse.

Built from https://develop.svn.wordpress.org/trunk@46313


git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 23:38:57 +00:00
whyisjake 38dc032e66 General: Linter cleanup 
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.

Fixes #48142
Props whyisjake

Built from https://develop.svn.wordpress.org/trunk@46312


git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:53:58 +00:00
Peter Wilson 22cba90dea Docs: Fix typo in `wp_print_scripts()`' reference to `WP_Scripts::do_item()`. 
Fixes #48141.

Built from https://develop.svn.wordpress.org/trunk@46311


git-svn-id: http://core.svn.wordpress.org/trunk@46110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:23:55 +00:00
whyisjake 2822281c57 Themes: Fix javascript regression that linter found. 
Tests were failing from line length optimizations and double quotes. 

Fixes #37536

Built from https://develop.svn.wordpress.org/trunk@46310


git-svn-id: http://core.svn.wordpress.org/trunk@46109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:12:57 +00:00
whyisjake b4ab6b7e14 Menus: Duplicate Page Entry in View All Pages when generating a Menu 
Simplifies the interface in menu creation.

Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks


Built from https://develop.svn.wordpress.org/trunk@46309


git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 21:51:58 +00:00
whyisjake 0acc444279 Themes: Improve Twenty Fifteen sticky sidebar logic 
The current logic in TwentyFifteen (#30366) for making the sidebar sticky while still allowing to scroll through it when the sidebar height is larger than the viewport height is flawed and massively overcomplicated.
This can be mitigated by removing the admin bar specific logic and leaving most of the heavy lifting up to the browser.

Fixes #37536

Props DvanKooten, lukecavanagh, karmatosed, ianbelanger, davidbaumwald


Built from https://develop.svn.wordpress.org/trunk@46308


git-svn-id: http://core.svn.wordpress.org/trunk@46107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 21:38:58 +00:00
desrosj 285ae90032 Build/Test Tools: Remove stray `+` introduced in [45979]. 
Props david.binda.
Fixes #48127.
Built from https://develop.svn.wordpress.org/trunk@46294


git-svn-id: http://core.svn.wordpress.org/trunk@46106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 19:55:58 +00:00
Andrea Fercia f8a25a89c9 Accessibility: Implement the new focus styles on the login screen after [46247]. 
Props @kjellr.
See #47153.

Built from https://develop.svn.wordpress.org/trunk@46293


git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 16:40:00 +00:00
Sergey Biryukov 547be72c3b Pings/Trackbacks: Use correct variable in a `foreach()` loop in `do_all_pings()`. 
Props itowhid06.
Fixes #48094. See #36824.
Built from https://develop.svn.wordpress.org/trunk@46292


git-svn-id: http://core.svn.wordpress.org/trunk@46104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 15:50:58 +00:00
desrosj 6ff7ff50cd Build/Test Tools: Move Composer script command line directives to the PHPCS ruleset. 
Also, move all arguments up to the top of the custom ruleset to make it easier to understand the conditions the ruleset is run under.

Props desrosj, jrf.
See #46152.
Built from https://develop.svn.wordpress.org/trunk@46291


git-svn-id: http://core.svn.wordpress.org/trunk@46103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 14:02:57 +00:00
desrosj 894e133d0c Build/Test Tools: Introduce automated PHP compatibility checking. 
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).

The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.

Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152.
Built from https://develop.svn.wordpress.org/trunk@46290


git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 13:47:58 +00:00
gziolo bd344c19ea Block Editor: Align the version of React with the one used in Gutenberg plugin 
Gutenberg 6.5 works with react and react-dom set to v16.9.0. This change aligns both.

Props youknowriad.
Fixes #48121.



Built from https://develop.svn.wordpress.org/trunk@46289


git-svn-id: http://core.svn.wordpress.org/trunk@46101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 08:20:57 +00:00
Sergey Biryukov c7f4cbc62c Docs: Improve consistency in `@since` tags for parameters that were made optional. 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@46288


git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 12:54:57 +00:00
Sergey Biryukov b35c5b9746 Script Loader: Add `function_exists()` checks for `is_admin()` and `current_theme_supports()`, to accomodate for using `WP_Dependencies` as a standalone class. 
Remove `<![CDATA[` when outputting HTML5 script tags. 

Props azaozz.
Fixes #42804.
Built from https://develop.svn.wordpress.org/trunk@46287


git-svn-id: http://core.svn.wordpress.org/trunk@46099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 02:56:57 +00:00
desrosj c00074e6aa Post WordPress 5.3 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46286


git-svn-id: http://core.svn.wordpress.org/trunk@46098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 00:17:56 +00:00
desrosj 3bd737c1b7 WordPress 5.3 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@46285


git-svn-id: http://core.svn.wordpress.org/trunk@46097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:54:56 +00:00
Sergey Biryukov a943fd64bc Coding Standards: Fix WPCS issue in [46283]. 
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46284


git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:24:57 +00:00
Sergey Biryukov 75ca249558 Twenty Twenty: Rename widget areas to `sidebar-1` and `sidebar-2`. 
This ensures that widgets are mapped correctly and is consistent with the previous default themes.

See https://github.com/WordPress/twentytwenty/issues/481.

Reverts [46282].

Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46283


git-svn-id: http://core.svn.wordpress.org/trunk@46095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:17:58 +00:00
Sergey Biryukov aaa3db74d8 Tests: Correct sidebar names for Twenty Twenty. 
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46282


git-svn-id: http://core.svn.wordpress.org/trunk@46094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 22:04:59 +00:00
Sergey Biryukov b95b6f2c73 Site Health: Move "The folder ... was detected as being under version control" message from failure to warning. 
Props afragen, davidbaumwald.
Fixes #47982.
Built from https://develop.svn.wordpress.org/trunk@46281


git-svn-id: http://core.svn.wordpress.org/trunk@46093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:24:56 +00:00
Sergey Biryukov 3c6ce558f9 REST API: Use delta comparison for floating date tests added in [46252] to avoid race conditions. 
See #39953.
Built from https://develop.svn.wordpress.org/trunk@46280


git-svn-id: http://core.svn.wordpress.org/trunk@46092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:18:58 +00:00
K. Adam White 81ed396972 Posts, Post Types: Build list of "date floating" post stati dynamically when inserting post. 
Completes work begun in #39953 to expose "date floating" status information to frontend clients via the REST API.

Props TimothyBlynJacobs.
Fixes #48113.

Built from https://develop.svn.wordpress.org/trunk@46279


git-svn-id: http://core.svn.wordpress.org/trunk@46091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:02:56 +00:00
desrosj 098455b06f Bundled Themes: Make Twenty Twenty the new default theme. 
After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress.

See #48110.
Props desrosj, ocean90.
Built from https://develop.svn.wordpress.org/trunk@46278


git-svn-id: http://core.svn.wordpress.org/trunk@46090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:00:58 +00:00
desrosj 1a961be653 Bundled Themes: Fix failing tests for Twenty Twenty. 
Follow up of [46271].

See #48110.
Built from https://develop.svn.wordpress.org/trunk@46277


git-svn-id: http://core.svn.wordpress.org/trunk@46089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:54:57 +00:00
Sergey Biryukov c117b9957f Site Health: Use `WP_Automatic_Updater::is_disabled()` to check whether automatic updates are disabled. 
The previous check for `DISALLOW_FILE_MODS` and `AUTOMATIC_UPDATER_DISABLED` constants didn't always provide accurate results.

Props Clorith, kraftner, afragen.
Fixes #47869.
Built from https://develop.svn.wordpress.org/trunk@46276


git-svn-id: http://core.svn.wordpress.org/trunk@46088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:52:56 +00:00
K. Adam White a86fe08b1d Coding Standards: Fix WPCS issue in [46274]. 
See #39953.

Built from https://develop.svn.wordpress.org/trunk@46275


git-svn-id: http://core.svn.wordpress.org/trunk@46087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:48:57 +00:00
K. Adam White a418a8a427 REST API: Mark "pending" status as date_floating. 
See: https://github.com/WordPress/gutenberg/issues/13176

Props TimothyBlynJacobs.
Fixes #39953.

Built from https://develop.svn.wordpress.org/trunk@46274


git-svn-id: http://core.svn.wordpress.org/trunk@46086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:34:57 +00:00
Sergey Biryukov 406021dba8 Site Health: Include simple debug data in fatal error protection email. 
Introduce `recovery_email_debug_info` filter for the debug information included in the email.

Props Clorith, TimothyBlynJacobs.
Fixes #48090.
Built from https://develop.svn.wordpress.org/trunk@46273


git-svn-id: http://core.svn.wordpress.org/trunk@46085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:27:56 +00:00
K. Adam White 10772e8499 REST API: Introduce WP_Post_Type::get_rest_controller() caching method to prevent unnecessary REST controller construction. 
Cache REST controller references on their associated post type object to prevent unnecessary controller re-instantiation, which previously caused "rest_prepare_{$post_type}" and "rest_{$post_type}_query" to run twice per request.

Props TimothyBlynJacobs, patrelentlesstechnologycom.
Fixes #45677.

Built from https://develop.svn.wordpress.org/trunk@46272


git-svn-id: http://core.svn.wordpress.org/trunk@46084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:25:57 +00:00
desrosj 43b86a246c Bundled Themes: Import Twenty Twenty, the new default theme for WordPress 5.3. 
Welcome to the bundled themes family!

Theme development to this point has taken place on GitHub. See: https://github.com/WordPress/twentytwenty/.

Props anlino, ianbelanger, audrasjb, nielslange, fabiankaegy, mukesh27, poena, joyously, emiluzelac, williampatton, dingo-d, dkarfa, acosmin, rabmalin, kafleg, jeffpaul, hareesh-pillai, burhandodhy, afercia, juanfra, soean, presskopp, justinahinon, jrf, netweb, garyj, pento, flixos90, vbaimas, zebulan, byalextran, mor10, kjellr, allancole, tdh, karmatosed, mapk, matt, andrewtaylor-1, ismailelkorchi, garrett-eclipse, gsayed786, dianeco, celloexpressions, aristath, nadir, cbravobernal, intimez, hometowntrailers, collet, littlebigthing, tobifjellner, kevinkovadia, jarretc.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46271


git-svn-id: http://core.svn.wordpress.org/trunk@46083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:16:00 +00:00
Sergey Biryukov d363d85cce Themes: After [46164], make sure `$type_attr` is always defined in `_custom_background_cb()`. 
Props davidbaumwald.
Fixes #48112.
Built from https://develop.svn.wordpress.org/trunk@46270


git-svn-id: http://core.svn.wordpress.org/trunk@46082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 20:09:57 +00:00