Commit Graph

32721 Commits

Author SHA1 Message Date
Drew Jaynes 8f603650f4 Menus: Prevent display conflicts in the screen options for Menus when a post type and taxonomy share the same slug.
Prior to this change, both taxonomies and post types added meta boxes to the Menus UI (which in-turn registered screen options) using the same ID formula: `add-{$id}`. This caused a conflict between the two elements, resulting in the rendering of a screen option for only the taxonomy or post type but not both. Moving to a new meta box ID for post types, `add-post-type-{$id}`, removes that conflict.

Note: This change in meta box IDs for post types effectively resets current user settings for the visibility of post types in the Menus UI.

Fixes #33925.

Built from https://develop.svn.wordpress.org/trunk@35450


git-svn-id: http://core.svn.wordpress.org/trunk@35414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 05:47:24 +00:00
Drew Jaynes e6d50be991 Multisite: Restore display of the Toolbar on wp-activate.php while logged-in.
Just as with wp-signup.php, display of the Toolbar on wp-activate.php was broken in [23512] due to a hook change for the `_wp_admin_bar_init()` callback. wp-signup.php was fixed in [35423] for #34418.

See [35423] for more in-depth background and reasoning behind restoring display of the Toolbar on wp-activate.php and wp-signup.php.

Fixes #34496. See #34418.

Built from https://develop.svn.wordpress.org/trunk@35449


git-svn-id: http://core.svn.wordpress.org/trunk@35413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 04:24:23 +00:00
Gary Pendergast cad430161c Buttons: Add some vendor prefixes missed in [35422].
See #31459.


Built from https://develop.svn.wordpress.org/trunk@35448


git-svn-id: http://core.svn.wordpress.org/trunk@35412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 03:13:25 +00:00
Sergey Biryukov 044901e783 Don't use `<strong>` in translatable strings in `wp-signup.php`.
Add translator commments.

Props ramiy.
Fixes #34502.
Built from https://develop.svn.wordpress.org/trunk@35447


git-svn-id: http://core.svn.wordpress.org/trunk@35411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 02:09:24 +00:00
John Blackbourn 8cbd79e3dc Ensure that the scheme used in the URL returned by `get_blogaddress_by_id()` always reflects the blog's URL, instead of using `http`.
Props thomaswm
Fixes #14867

Built from https://develop.svn.wordpress.org/trunk@35446


git-svn-id: http://core.svn.wordpress.org/trunk@35410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 02:02:24 +00:00
Sergey Biryukov 746ba4c9c4 Replace a second instance of `<code>` in translatable string left in [35440].
Props ramiy.
See #34498.
Built from https://develop.svn.wordpress.org/trunk@35445


git-svn-id: http://core.svn.wordpress.org/trunk@35409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:56:25 +00:00
Sergey Biryukov 2920285225 Don't use `<strong>` in translatable string in `wp-admin/includes/nav-menu.php`.
Add translator commment.

Props ramiy.
Fixes #34500.
Built from https://develop.svn.wordpress.org/trunk@35444


git-svn-id: http://core.svn.wordpress.org/trunk@35408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:37:24 +00:00
Sergey Biryukov bfbd9e3ec3 Don't use `<a>` in translatable strings in `wp-admin/includes/dashboard.php'.
Add translator commments.

Props ramiy.
Fixes #34501.
Built from https://develop.svn.wordpress.org/trunk@35443


git-svn-id: http://core.svn.wordpress.org/trunk@35407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:33:25 +00:00
Sergey Biryukov a83a250ee0 Don't use `<strong>` in translatable string in `wp-admin/includes/nav-menu.php`.
Add translator commment.

Props ramiy.
Fixes #34500.
Built from https://develop.svn.wordpress.org/trunk@35442


git-svn-id: http://core.svn.wordpress.org/trunk@35406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:17:26 +00:00
Sergey Biryukov 87105cdf24 Add `<code>` tag missed in [35440].
See #34498.
Built from https://develop.svn.wordpress.org/trunk@35441


git-svn-id: http://core.svn.wordpress.org/trunk@35405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:12:24 +00:00
Sergey Biryukov 58db99b512 Don't use `<code>` in translatable strings in `wp-admin/includes/class-wp-plugins-list-table.php`.
Add translator commments.

Props ramiy.
Fixes #34498.
Built from https://develop.svn.wordpress.org/trunk@35440


git-svn-id: http://core.svn.wordpress.org/trunk@35404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:08:25 +00:00
Sergey Biryukov 1c21783283 Don't use `<code>` in translatable string in `wp-admin/includes/media.php`.
Add translator commment.

Props ramiy.
Fixes #34499.
Built from https://develop.svn.wordpress.org/trunk@35439


git-svn-id: http://core.svn.wordpress.org/trunk@35403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 00:58:24 +00:00
Sergey Biryukov e51f9061c5 Don't use `<code>` in translatable strings in `options-general.php`.
Add translator commments.

Props ramiy.
Fixes #34497.
Built from https://develop.svn.wordpress.org/trunk@35438


git-svn-id: http://core.svn.wordpress.org/trunk@35402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 00:52:26 +00:00
Gary Pendergast 368e5f9fc3 Embeds: Provide a cached text fallback.
Sometimes, embedded sites might suffer from less than 100% uptime. Instead of leaving the embedding site with a big blank space where the embed should be, let's fall back to a link to the embedded post, so there's at least some context for the post.

Fixes #34462.


Built from https://develop.svn.wordpress.org/trunk@35437


git-svn-id: http://core.svn.wordpress.org/trunk@35401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 23:11:24 +00:00
Gary Pendergast 8be4a22f82 Embeds: Who put this REST API infrastructure in my WordPress?
Well, while it's here, we probably should make use of it. The oEmbed endpoint now uses the REST API infrastructure, instead of providing its own.

Props swissspidy.

Fixes #34207.


Built from https://develop.svn.wordpress.org/trunk@35436


git-svn-id: http://core.svn.wordpress.org/trunk@35400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 22:51:24 +00:00
John Blackbourn c68c3804fa Correctly populate the `user_id` field for comments when a user submits a comment while logged in.
Props imath
Fixes #34493

Built from https://develop.svn.wordpress.org/trunk@35435


git-svn-id: http://core.svn.wordpress.org/trunk@35399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 21:29:24 +00:00
Sergey Biryukov 5d9dc4b8bf REST API: Use correct version in `_doing_it_wrong()` call.
Props TobiasBg.
Fixes #34490.
Built from https://develop.svn.wordpress.org/trunk@35434


git-svn-id: http://core.svn.wordpress.org/trunk@35398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 20:12:24 +00:00
Sergey Biryukov e7082e31dd REST API: Add missing translator comments for deprecated function and argument strings.
Props akirk.
Fixes #34486.
Built from https://develop.svn.wordpress.org/trunk@35433


git-svn-id: http://core.svn.wordpress.org/trunk@35397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 19:04:26 +00:00
Sergey Biryukov a3aaa0f951 Embeds: Include post name in "Continue reading" links to provide a readable link for screenreaders.
Props swissspidy.
Fixes #34481.
Built from https://develop.svn.wordpress.org/trunk@35432


git-svn-id: http://core.svn.wordpress.org/trunk@35396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 13:21:26 +00:00
Sergey Biryukov 1b0bc28579 Rename internal variable in `set_transient()`.
The previous name was inadvertently changing the dynamic part of `set_transient_{transient}` action and the transient name passed to the action since [35082].

Props GregLone.
Fixes #34470.
Built from https://develop.svn.wordpress.org/trunk@35431


git-svn-id: http://core.svn.wordpress.org/trunk@35395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 11:52:28 +00:00
Gary Pendergast 85c273818c Embeds: Tweak a string added in [35429], and add a translator comment.
See #32522.


Built from https://develop.svn.wordpress.org/trunk@35430


git-svn-id: http://core.svn.wordpress.org/trunk@35394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 11:42:25 +00:00
Gary Pendergast 59b1c9823a Embeds: Tweak the "embed not found" message, based on the Twenty Sixteen 404 template.
See #32522.


Built from https://develop.svn.wordpress.org/trunk@35429


git-svn-id: http://core.svn.wordpress.org/trunk@35393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 11:10:25 +00:00
Gary Pendergast 44fb83dc0b Shortcodes: Tweak the error messages added in [34745].
See #34090.


Built from https://develop.svn.wordpress.org/trunk@35428


git-svn-id: http://core.svn.wordpress.org/trunk@35392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-29 10:32:26 +00:00
Andrea Fercia db8b09c40d Media: Improve the headings hierarchy in the Media Views for better accessibility.
Fixes #34273.
Built from https://develop.svn.wordpress.org/trunk@35427


git-svn-id: http://core.svn.wordpress.org/trunk@35391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 23:08:24 +00:00
Andrew Ozz d7da5970fa Responsive images: add inline docs for private functions.
Props swissspidy.
See #34430.
Built from https://develop.svn.wordpress.org/trunk@35426


git-svn-id: http://core.svn.wordpress.org/trunk@35390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 21:55:24 +00:00
Scott Taylor ce23a01aa8 Bump 4.4 Beta 2.
Built from https://develop.svn.wordpress.org/trunk@35425


git-svn-id: http://core.svn.wordpress.org/trunk@35389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:48:25 +00:00
Scott Taylor 5f6bdd9d60 4.4-beta2
Built from https://develop.svn.wordpress.org/trunk@35424


git-svn-id: http://core.svn.wordpress.org/trunk@35388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:32:24 +00:00
Drew Jaynes 33d9b8e4d0 Multisite: Restore displaying the Toolbar on wp-signup.php while logged-in.
Prior to [23512], the Toolbar was still displayed on wp-signup.php while logged-in because it was hooked to the `init` action. When `_wp_admin_bar_init()` was moved to instead fire on `template_redirect` for the front-end and `admin_init` on the back-end, the visibility was lost because `template_redirect` isn't fired on wp-signup.php due to `WP_USE_THEMES` not being defined.

In order to maintain expected display results, a default filter has been added to hook `_wp_admin_bar_init()` to the `before_signup_header` action. This approach has the added benefit of allowing `_wp_admin_bar_init()` to be fired prior to the `wp_head` action where `_admin_bar_bump_cb()` is called (or the callback defined when 'admin-bar' theme support is added).

Fixes #34418.

Built from https://develop.svn.wordpress.org/trunk@35423


git-svn-id: http://core.svn.wordpress.org/trunk@35387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:30:25 +00:00
Helen Hou-Sandí 68951bd30c Buttons: Screen Options/Help shouldn't have active styling.
see #31459.

Built from https://develop.svn.wordpress.org/trunk@35422


git-svn-id: http://core.svn.wordpress.org/trunk@35386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:26:24 +00:00
Helen Hou-Sandí 831f3d4105 Buttons: More consistent focus styling.
props afercia.
fixes #32915.

Built from https://develop.svn.wordpress.org/trunk@35421


git-svn-id: http://core.svn.wordpress.org/trunk@35385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:17:27 +00:00
Scott Taylor fc440ef0f0 Dashboard: cleanup after [35414].
Props afercia.
Fixes #33558.

Built from https://develop.svn.wordpress.org/trunk@35420


git-svn-id: http://core.svn.wordpress.org/trunk@35384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:08:25 +00:00
Andrew Ozz fd11ef9c45 Responsive images:
- Check if wp_get_attachment_metadata() has returned an array to prevent errors when using SVGs.
- Only add the srcset attribute if there will be a sizes attribute.
- Better filter names.
- Some more inline docs fixes.

Props jaspermdegroot.
See #34430.
Built from https://develop.svn.wordpress.org/trunk@35419


git-svn-id: http://core.svn.wordpress.org/trunk@35383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:01:26 +00:00
Scott Taylor f507751a40 Thickbox: spinner should disappear when loading is done.
Props niklasbr, afercia.
Fixes #33311.

Built from https://develop.svn.wordpress.org/trunk@35418


git-svn-id: http://core.svn.wordpress.org/trunk@35382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 18:19:26 +00:00
Boone Gorges 91c191f5d7 Don't specify an `offset` default in `get_posts()`.
The default value should be a null offset. A `0` default overrides any value
of `paged` passed to `get_posts()`. See [34697].

Fixes #34060.
Built from https://develop.svn.wordpress.org/trunk@35417


git-svn-id: http://core.svn.wordpress.org/trunk@35381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 18:18:24 +00:00
Scott Taylor 70689237f3 Admin Menu: after [34861], prevent adjacent separators.
Props johnjamesjacoby.
Fixes #24104.

Built from https://develop.svn.wordpress.org/trunk@35416


git-svn-id: http://core.svn.wordpress.org/trunk@35380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 18:06:24 +00:00
Scott Taylor 34a9b6e428 Mail: in `wp_notify_postauthor()` and `wp_notify_moderator()`, ensure that special chars aren't HTML-encoded in the email message body.
Props solarissmoke, leemon.
Fixes #12584.

Built from https://develop.svn.wordpress.org/trunk@35415


git-svn-id: http://core.svn.wordpress.org/trunk@35379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 18:03:24 +00:00
Scott Taylor 843d1c003b Dashboard: make tags used for headings more semantic.
Props Cheffheid, afercia.
Fixes #33558.

Built from https://develop.svn.wordpress.org/trunk@35414


git-svn-id: http://core.svn.wordpress.org/trunk@35378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 17:57:25 +00:00
John Blackbourn ef6abd3891 List the possible values for the dynamic portion of the `{type}_template` hook.
See #14310, #32246

Built from https://develop.svn.wordpress.org/trunk@35413


git-svn-id: http://core.svn.wordpress.org/trunk@35377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 14:06:27 +00:00
Andrew Ozz 61d21cc0d9 Responsive images:
- Introduce `wp_calculate_image_srcset()` that replaces `wp_get_attachment_image_srcset_array()` and is used as lower level function for retrieving the srcset data as array.
- Use the new function when generating `srcset` and `sizes` on the front-end. This is faster as no (other) image API functions are used.
- Change the `wp_get_attachment_image_srcset()`. Now it is meant for use in templates and is no longer used in core.
- A few logic fixes and improvements.
- Some names changed to be (hopefully) more descriptive.
- Fixed/updated tests.

Props joemcgill, jaspermdegroot, azaozz.
See #34430.
Built from https://develop.svn.wordpress.org/trunk@35412


git-svn-id: http://core.svn.wordpress.org/trunk@35376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 05:41:24 +00:00
Sergey Biryukov 8d0f76bc11 Settings: Don't display Site Address field description if `WP_HOME` is defined and the field is disabled.
Props dipesh.kakadiya.
Fixes #33354.
Built from https://develop.svn.wordpress.org/trunk@35411


git-svn-id: http://core.svn.wordpress.org/trunk@35375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 04:54:26 +00:00
Dion Hulse 82d034a386 Update Random_Compat to master.
This update mostly concerns OpenSSL being unusable on PHP 5.3~5.3.3.
See #28633, #34409

Built from https://develop.svn.wordpress.org/trunk@35410


git-svn-id: http://core.svn.wordpress.org/trunk@35374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 01:12:24 +00:00
Dominik Schilling 3def1c5014 Embeds: Provide a site icon via `srcset` for HiDPI screens.
Fixes #34433.
Built from https://develop.svn.wordpress.org/trunk@35409


git-svn-id: http://core.svn.wordpress.org/trunk@35373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-27 21:00:24 +00:00
Dominik Schilling 80116f2136 Embeds: Replace hardcoded error messages with `get_status_header_desc( $http_code )`.
Fixes #34275.
Built from https://develop.svn.wordpress.org/trunk@35408


git-svn-id: http://core.svn.wordpress.org/trunk@35372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-27 20:44:23 +00:00
Drew Jaynes 887dca222c Docs: Standardize the file header for wp-admin/includes/ms-deprecated.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35407


git-svn-id: http://core.svn.wordpress.org/trunk@35371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-27 20:08:27 +00:00
Gary Pendergast 1f8e6268d3 Embeds: Add a CDATA and HTML comment wrapper around the JavaScript included in the embed HTML. This ensures that user agents which naively strip unwanted tags, without also stripping the content within those tages (for example, Slack), don't show the embed as a mess of JavaScript.
Props peterwilsoncc.

Fixes #34429.


Built from https://develop.svn.wordpress.org/trunk@35406


git-svn-id: http://core.svn.wordpress.org/trunk@35370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 23:55:26 +00:00
Sergey Biryukov 1acf9e9e49 After [35402], don't unnecessary run `wp_get_attachment_metadata()`, `wp_get_attachment_image_srcset()`, and `wp_get_attachment_image_sizes()` in `wp_img_add_srcset_and_sizes()`.
See #34379.
Built from https://develop.svn.wordpress.org/trunk@35405


git-svn-id: http://core.svn.wordpress.org/trunk@35369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 18:42:24 +00:00
Sergey Biryukov 1e59e53dd2 After [35402], don't unnecessary run `wp_get_attachment_image_srcset()` and `wp_get_attachment_image_sizes()` in `wp_get_attachment_image()` if `srcset` is passed as an argument.
See #34379.
Built from https://develop.svn.wordpress.org/trunk@35404


git-svn-id: http://core.svn.wordpress.org/trunk@35368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 18:40:24 +00:00
Drew Jaynes e3989c6194 Docs: Add a `@subpackage` tag to the file header for wp-admin/includes/ms-admin-filters.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35403


git-svn-id: http://core.svn.wordpress.org/trunk@35367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 18:06:26 +00:00
Sergey Biryukov f5d0260e4d Remove assignments from conditions in `wp_get_attachment_image()` and `wp_img_add_srcset_and_sizes()`.
See #34379.
Built from https://develop.svn.wordpress.org/trunk@35402


git-svn-id: http://core.svn.wordpress.org/trunk@35366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 16:29:26 +00:00
Sergey Biryukov 64a79eeffa Docs: After [34453], correct inline comments in `wp_get_attachment_image_sizes()`.
Props jaspermdegroot.
Fixes #34453.
Built from https://develop.svn.wordpress.org/trunk@35401


git-svn-id: http://core.svn.wordpress.org/trunk@35365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 16:17:25 +00:00