c3a292dc76
Customize: Separate preview and actions in the site icon control.
...
Reverts [37456] to allow users to remove/change a site icon even if the attachment has corrupt/missing data about sizes.
Merge of [37724] to the 4.5 branch.
See #36749 .
Built from https://develop.svn.wordpress.org/branches/4.5@37725
git-svn-id: http://core.svn.wordpress.org/branches/4.5@37691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 09:53:28 +00:00
946b2cc8a2
Customize: Remove use of reserved word `default` in Underscore template which breaks IE8.
...
Fixes regression introduced in [36769].
Merge of [37417] to the 4.5 branch.
Props adamsilverstein.
Fixes #36793 .
Built from https://develop.svn.wordpress.org/branches/4.5@37450
git-svn-id: http://core.svn.wordpress.org/branches/4.5@37418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:29:30 +00:00
a311bea6d1
Customize: Fix toggle of title attribute field visibility on nav menus admin page.
...
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].
See #35273 .
Props sidati, westonruter.
Fixes #36353 .
Built from https://develop.svn.wordpress.org/trunk@37153
git-svn-id: http://core.svn.wordpress.org/trunk@37119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:55:27 +00:00
1a9fda07a4
Customize: Put focus on change button instead of remove button in media control.
...
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.
Props adamsilverstein, westonruter.
Fixes #36337 .
Built from https://develop.svn.wordpress.org/trunk@37152
git-svn-id: http://core.svn.wordpress.org/trunk@37118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:41:26 +00:00
c4eab31668
Docs: Use a third-person singular verb in the DocBlock summary for `WP_Customize_Site_Icon_Control::content_template()`, introduced in [36698].
...
Also adds a missing `@access` notation.
See #33755 . See #35986 .
Built from https://develop.svn.wordpress.org/trunk@37012
git-svn-id: http://core.svn.wordpress.org/trunk@36979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 16:41:27 +00:00
7add7e84f5
Docs: Add a missing version and access information to the DocBlock for the `WP_Customize_Selective_Refresh->$manager` property, introduced in [36586].
...
See #27355 . See #35986 .
Built from https://develop.svn.wordpress.org/trunk@37011
git-svn-id: http://core.svn.wordpress.org/trunk@36978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 16:39:26 +00:00
3bdf4f1524
Docs: Standardize the file header and class summarries for the file containing `WP_Customize_Selective_Refresh`, introduced in [36586].
...
See #27355 . See #35986 .
Built from https://develop.svn.wordpress.org/trunk@37010
git-svn-id: http://core.svn.wordpress.org/trunk@36977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 16:29:26 +00:00
b23a2750aa
Docs: Standardize the file header and class summaries for the file containing `WP_Customize_Partial`, introduced in [36586].
...
See #27355 . See #35986 .
Built from https://develop.svn.wordpress.org/trunk@37009
git-svn-id: http://core.svn.wordpress.org/trunk@36976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 16:24:27 +00:00
d21d537280
Customize: Use full URL to image to prevent breakage if moved.
...
See https://core.trac.wordpress.org/ticket/33755#comment:103
See #33755 .
Built from https://develop.svn.wordpress.org/trunk@36948
git-svn-id: http://core.svn.wordpress.org/trunk@36916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 18:53:25 +00:00
7441acafaf
Customize: Fix persistence of toggles for displayed nav menu item properties.
...
* Eliminates need to click more than one checkbox to have preferences saved.
* Adds debouncing to saving user-selected menu item properties.
* Also removes discrepancies between available nav menu item properties on admin page vs Customizer.
Fixes #35273 .
Props afercia, westonruter.
Built from https://develop.svn.wordpress.org/trunk@36908
git-svn-id: http://core.svn.wordpress.org/trunk@36876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 21:41:28 +00:00
f39d1e4fcc
Customize: Reduce vertical space of site icon control.
...
Makes the control easier to find, reduces visual clutter, and is more
consistent with Customizer UI conventions.
Props celloexpressions.
Fixes #35943 .
Built from https://develop.svn.wordpress.org/trunk@36907
git-svn-id: http://core.svn.wordpress.org/trunk@36875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 21:19:27 +00:00
d27ae61355
Customize: Remove selective refresh error message from appearing inline within the preview.
...
The error message will still be available in the developer console.
Removes part of [36586].
See #27355 .
Fixes #36164 .
Built from https://develop.svn.wordpress.org/trunk@36890
git-svn-id: http://core.svn.wordpress.org/trunk@36857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 04:37:28 +00:00
a8ca958d43
Customize: Eliminate unnecessary `WP_Customize_Site_Logo_Control` in favor of re-using `WP_Customize_Image_Control`.
...
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096 .
See #33755 .
Fixes #35941 .
Built from https://develop.svn.wordpress.org/trunk@36851
git-svn-id: http://core.svn.wordpress.org/trunk@36818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 23:47:26 +00:00
1ef0d464d7
Customize: Rename custom logo classes after [36837].
...
Fixes #35945 .
Built from https://develop.svn.wordpress.org/trunk@36838
git-svn-id: http://core.svn.wordpress.org/trunk@36805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 19:59:27 +00:00
147d6d7d6c
Customize: Site logos are custom logos.
...
Brings the nomenclature closer to custom headers and backgrounds.
See https://wordpress.slack.com/archives/core/p1456955151003150
See #35945 .
Built from https://develop.svn.wordpress.org/trunk@36837
git-svn-id: http://core.svn.wordpress.org/trunk@36804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 19:56:26 +00:00
447b284107
Customizer: Merge two translator comments.
...
Built from https://develop.svn.wordpress.org/trunk@36809
git-svn-id: http://core.svn.wordpress.org/trunk@36776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-02 23:10:26 +00:00
b757de7da9
Customize: Define params on `WP_Customize_Partial::render_callback()` for the sake of subclasses overriding this method.
...
Fixes a strict standards notice regarding the method signature needing to be compatible.
See #27355 .
Built from https://develop.svn.wordpress.org/trunk@36801
git-svn-id: http://core.svn.wordpress.org/trunk@36768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-02 06:09:26 +00:00
0e5bb06cb8
Customize: Allow `button_labels` to be overridden in `$args` passed to `WP_Customize_Media_Control` and `WP_Customize_Image_Control`.
...
Props chetanchauhan, celloexpressions.
See #33755 .
Fixes #35542 .
Built from https://develop.svn.wordpress.org/trunk@36769
git-svn-id: http://core.svn.wordpress.org/trunk@36736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-29 00:40:26 +00:00
e0cd5f9dba
Docs: Add a missing summary, `@access` tag, and parameter documentation to the DocBlock for `WP_Customize_Filter_Setting::update()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36745
git-svn-id: http://core.svn.wordpress.org/trunk@36712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-27 21:17:25 +00:00
e5ea82d81a
Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
...
Props obrienlabs, thewanderingbrit.
Fixes #34887 .
Built from https://develop.svn.wordpress.org/trunk@36709
git-svn-id: http://core.svn.wordpress.org/trunk@36676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-25 12:53:27 +00:00
237f6a0e58
Customize: Introduce Logo support for themes.
...
Allows a common theme feature to have a common implementation provided by core and available in a consistent location for users.
See https://make.wordpress.org/core/2016/02/24/theme-logo-support/
Props kwight, enejb, jeherve, bhubbard, samhotchkiss, zinigor, eliorivero, adamsilverstein, melchoyce, ryan, mikeschroder, westonruter, pento, karmatosed, celloexpressions, obenland.
See #33755 .
Built from https://develop.svn.wordpress.org/trunk@36698
git-svn-id: http://core.svn.wordpress.org/trunk@36665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-24 22:10:26 +00:00
2214f69e43
Customize: Allow controls to be registered without any associated settings.
...
* Improves parity between partials and controls. A partial or control can be settingless if instantiated with `settings` param as empty array (otherwise, if null, then the partial/control ID is used).
* Eliminate need to create dummy settings that serve no purpose except to place a control in the UI.
* Removes dummy settings for `create_new_menu` and `new_menu_name`.
* Introduces `WP_Customize_Control::$capability` and `WP_Customize_Partial::$capability`, and if set checks them in the respective `check_capabilities()` methods.
* Prevents PHP fatal error from happening when non-existing settings are provided to control: "Call to a member function `check_capabilities()` on a non-object".
* Fixes issue where nav menu items and widgets were no longer working with selective refresh because cap check was failing.
See #27355 .
Fixes #35926 .
Built from https://develop.svn.wordpress.org/trunk@36689
git-svn-id: http://core.svn.wordpress.org/trunk@36656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-24 18:28:28 +00:00
aa2db425d8
Customize: Skip exporting partials to client and handling rendering requests if user can't modify associated settings.
...
Introduces `WP_Customize_Partial::check_capabilities()` for parity with `WP_Customize_Control::check_capabilities()`.
See #27355 .
Fixes #35914 .
Built from https://develop.svn.wordpress.org/trunk@36643
git-svn-id: http://core.svn.wordpress.org/trunk@36610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 18:14:26 +00:00
53e0315242
Customize: Let `WP_Customize_Selective_Refresh` class be `final` to match manager and other component classes.
...
This class is not intended to be extended.
See #27355 .
Built from https://develop.svn.wordpress.org/trunk@36624
git-svn-id: http://core.svn.wordpress.org/trunk@36591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 01:28:25 +00:00
aa9ef96a52
Customize: Prevent dropping backslashes from input on general settings and settings for nav menus and some widgets.
...
Ensures that intentional backslashes (e.g. "\o/") can be used in:
* Site title
* Site description
* Nav menu name
* Custom Menu widget title
* Tag Cloud widget title
* Text widget body if can't `unfiltered_html`
The latter three are also fixed on the widgets admin page.
Fixes #35898 .
Built from https://develop.svn.wordpress.org/trunk@36622
git-svn-id: http://core.svn.wordpress.org/trunk@36589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-23 01:02:26 +00:00
b206327acb
Customize: Fix previewing and updating of nav menu items containing slashed/slashable characters.
...
Prevents slashes from being added when a user without `unfiltered_html` previews a nav menu item containing an apostrophe or some other slashable character, and prevents the loss of an intentional slash (e.g. "\o/") when saving a nav menu item, regardless of capability.
Fixes #35869 .
Built from https://develop.svn.wordpress.org/trunk@36608
git-svn-id: http://core.svn.wordpress.org/trunk@36575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 00:14:25 +00:00
6b775d4afe
Customize: Add selective refresh framework with implementation for widgets and re-implementation for nav menus.
...
See https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/ .
Props westonruter, valendesigns, DrewAPicture, ocean90.
Fixes #27355 .
Built from https://develop.svn.wordpress.org/trunk@36586
git-svn-id: http://core.svn.wordpress.org/trunk@36553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:41:28 +00:00
3fdb8bafc4
Customize: Ensure that "Change" button appears when there are only 2 themes.
...
Fixes defect introduced in [35535].
Props igmoweb.
See #34549 .
Fixes #35081 .
Built from https://develop.svn.wordpress.org/trunk@35943
git-svn-id: http://core.svn.wordpress.org/trunk@35907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 01:21:26 +00:00
d0b7dd489e
I18N: Remove `<strong>` tags from translatable strings in `WP_Customize_Manager::register_controls()` and `WP_Customize_Header_Image_Control::render_content()`.
...
Add translator comments.
See #35039 .
Built from https://develop.svn.wordpress.org/trunk@35923
git-svn-id: http://core.svn.wordpress.org/trunk@35887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 12:54:27 +00:00
5dae1386aa
Customize: Ensure that a setting (especially a multidimensional one) can still be previewed when the post value to preview is set after `preview()` is invoked.
...
* Introduce `customize_post_value_set_{$setting_id}` and `customize_post_value_set` actions which are done when `WP_Customize_Manager::set_post_value()` is called.
* Clear the `preview_applied` flag for aggregated multidimensional settings when a post value is set. This ensures the new value is used instead of a previously-cached previewed value.
* Move `$is_preview` property from subclasses to `WP_Customize_Setting` parent class.
* Deferred preview: Ensure that when `preview()` short-circuits due to not being applicable that it will be called again later when the post value is set.
* Populate post value for updated-widget with the (unsanitized) JS-value in `WP_Customize_Widgets::call_widget_update()` so that value will be properly sanitized when accessed in `WP_Customize_Manager::post_value()`.
Includes unit tests with assertions to check the reported issues and validate the fixes.
Fixes defect introduced in [35007].
See #32103 .
Fixes #34738 .
Built from https://develop.svn.wordpress.org/trunk@35724
git-svn-id: http://core.svn.wordpress.org/trunk@35688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-21 02:52:27 +00:00
17af54fc7c
Customizer: Use correct context and translator comments for menu location strings.
...
See #33431 .
Built from https://develop.svn.wordpress.org/trunk@35722
git-svn-id: http://core.svn.wordpress.org/trunk@35686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 17:46:25 +00:00
d1805c9da8
Customizer: Merge two similar strings.
...
Remove also `{{ data.menu_name }}` since it doesn't print anything.
Fixes #33630 .
Built from https://develop.svn.wordpress.org/trunk@35695
git-svn-id: http://core.svn.wordpress.org/trunk@35659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:25:25 +00:00
a9fb6e9ae0
Customizer i18n: provide translator context for current menu name and location.
...
Props ryankienstra.
Fixes #33431 .
Built from https://develop.svn.wordpress.org/trunk@35676
git-svn-id: http://core.svn.wordpress.org/trunk@35640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:21:28 +00:00
ae9e173082
Buttons: Standardize on `.button-link` for link-like buttons.
...
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.
props paulwilde for the initial patch.
fixes #34242 .
Built from https://develop.svn.wordpress.org/trunk@35636
git-svn-id: http://core.svn.wordpress.org/trunk@35600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 15:47:27 +00:00
c470b872bd
Customize: Improve alignment of `WP_Customize_Nav_Menu_Item_Setting::sanitize()` behavior with `wp_update_nav_menu_item()`.
...
* Apply `title_save_pre`, `excerpt_save_pre`, and `content_save_pre` filters on a nav menu item's `title`, `attr_title`, and `description` properties respectively. This ensures that arbitrary markup can be supplied if the user has `unfiltered_html` cap, and for these fields to have markup stripped if not.
* Ensure a nav menu item's `post_status` is sanitized as `publish` or `draft` using the same conditions as `wp_update_nav_menu_item()`.
* Align `WP_Customize_Nav_Menu_Item_Setting::sanitize()` behavior for sanitizing `position` to be the same as `wp_update_nav_menu_item()`.
* Also apply `nav_menu_attr_title` and `nav_menu_description` filters in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()` to ensure that previewing markup entered into menu item description will preview the same way as when the nav menu item is saved.
* Add unit tests.
Fixes #32812 .
Built from https://develop.svn.wordpress.org/trunk@35580
git-svn-id: http://core.svn.wordpress.org/trunk@35544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 00:48:26 +00:00
e649fabb6a
Accessibility: add missing `alt` attributes to a gaggle of `<img>`s.
...
Props afercia.
Fixes #34583 .
Built from https://develop.svn.wordpress.org/trunk@35567
git-svn-id: http://core.svn.wordpress.org/trunk@35531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:12:27 +00:00
1a55cbe59d
Customize: Hide "Change" button in themes section if there are fewer than two available themes.
...
Props danielbachhuber, westonruter.
Fixes #34549 .
Built from https://develop.svn.wordpress.org/trunk@35535
git-svn-id: http://core.svn.wordpress.org/trunk@35499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 01:26:25 +00:00
77e365efbf
Customize: Add support for `post_type_archive` nav menu items.
...
Props celloexpressions, westonruter.
Fixes #16075 .
Built from https://develop.svn.wordpress.org/trunk@35500
git-svn-id: http://core.svn.wordpress.org/trunk@35464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 04:30:26 +00:00
be620e6da6
Customizer: Remove the no more used `add-menu-item-loading` spinner.
...
Also makes more room for longer translations.
Props dipali.dhole27@gmail.com .
Fixes #34342 .
Built from https://develop.svn.wordpress.org/trunk@35396
git-svn-id: http://core.svn.wordpress.org/trunk@35360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 13:59:26 +00:00
2f42bf0a73
Docs: Add missing DocBlocks for the `$type` and `$sidebar_id` properties, and summaries for the `to_json()` and `render_content()` methods in `WP_Widget_Area_Customize_Control`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35393
git-svn-id: http://core.svn.wordpress.org/trunk@35357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-25 19:58:26 +00:00
68526a8bf1
Customize: move `WP_Customize_Control` subclasses to `wp-includes/customize`, they load in the exact same place.
...
See #34432 .
Built from https://develop.svn.wordpress.org/trunk@35389
git-svn-id: http://core.svn.wordpress.org/trunk@35353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 18:57:25 +00:00
61aefacd2c
Customize: move `WP_Customize_Panel` subclass to `wp-includes/customize`, it loads in the exact same place.
...
See #34432 .
Built from https://develop.svn.wordpress.org/trunk@35386
git-svn-id: http://core.svn.wordpress.org/trunk@35350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 18:25:24 +00:00
574f53399c
Customize: move `WP_Customize_Section` subclasses to `wp-includes/customize`, they load in the exact same place.
...
See #34432 .
Built from https://develop.svn.wordpress.org/trunk@35385
git-svn-id: http://core.svn.wordpress.org/trunk@35349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 18:21:25 +00:00
21d74f5b1d
Customize: move `WP_Customize_Setting` subclasses to `wp-includes/customize`, they load in the exact same place.
...
See #34432 .
Built from https://develop.svn.wordpress.org/trunk@35383
git-svn-id: http://core.svn.wordpress.org/trunk@35347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 18:11:24 +00:00
Dominik Schilling
Weston Ruter
Drew Jaynes
Konstantin Obenland
Sergey Biryukov
Scott Taylor
Helen Hou-Sandí
Andrea Fercia