f424977028
Menus: Restore checkboxes in post type search which were lost in [38584].
...
The `$args` variable was being overridden instead of extended, therefore causing the `walker` to be dropped.
Fixes #33742 .
Built from https://develop.svn.wordpress.org/trunk@38702
git-svn-id: http://core.svn.wordpress.org/trunk@38645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-03 02:35:28 +00:00
eeefec932f
Administration: Improve the usage of the button CSS classes.
...
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.
- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items
Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314 , #37138 , #37448 .
Built from https://develop.svn.wordpress.org/trunk@38672
git-svn-id: http://core.svn.wordpress.org/trunk@38615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-28 19:54:28 +00:00
84f9592f88
Menus: Prevent non-published posts/pages from being returned in search results for adding as nav menu items.
...
Re-use the same query vars in searching as when listing posts. Aligns with behavior of nav menus in customizer.
Fixes #33742 .
Props welcher, westonruter.
Built from https://develop.svn.wordpress.org/trunk@38584
git-svn-id: http://core.svn.wordpress.org/trunk@38527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-09 04:59:31 +00:00
a3ffebce30
Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38470
git-svn-id: http://core.svn.wordpress.org/trunk@38411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:31:29 +00:00
390ceba6c7
Bootstrap: after r38409 and r38410, revert r38402 which reverted r38399.
...
This fixes the paths in `wp-vendor/` that were including `src`. I want to drop this in so we can find out what else will break.
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38411
git-svn-id: http://core.svn.wordpress.org/trunk@38352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 22:32:37 +00:00
0e31a46161
Bootstrap: Revert [38399] as it's broken `/build/` and subsequently core.svn.wordpress.org.
...
The generated classmaps reference `/src/` files and operates in the assumption that the base directory is one level above `wp-settings.php`, which it isn't after our build processes are run.
See #36335
Built from https://develop.svn.wordpress.org/trunk@38402
git-svn-id: http://core.svn.wordpress.org/trunk@38343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 14:37:32 +00:00
6a529648cf
Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader.
...
* `wp-admin` and `wp-includes` are scanned for classes to autoload
* Several 3rd-party and Ryan McCue-shaped libraries are excluded when the classmap is generated, see `composer.json`: `autoload.exclude-from-classmap`
* `wp-vendor/autoload_52.php` is included at the top of `wp-settings.php` - no changes need to be made to unit tests to include the autoloader
* An avalanche of `require()` and `require_once()` calls that loaded class files have been removed from the codebase.
The following files have been added to `svn:ignore` - they are not 5.2-compatible and fail during pre-commit:
* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php
We favor these files instead:
* src/wp-vendor/autoload_52.php
* src/wp-vendor/composer/autoload_real_52.php
* src/wp-vendor/composer/ClassLoader52.php
When new PHP classes are added to the codebase, simply run `composer install` or `composer update` from the project root to update the autoloader.
The future is now.
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38399
git-svn-id: http://core.svn.wordpress.org/trunk@38340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 09:15:29 +00:00
5025f72fd3
Nav Menus: remove unnecessary variable assignment in `wp_nav_menu_item_post_type_meta_box()`.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38311
git-svn-id: http://core.svn.wordpress.org/trunk@38252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 20:58:28 +00:00
995dc513a4
Docs: Update the description of the `$box` argument of `wp_nav_menu_item_taxonomy_meta_box()` for consistency with [38129].
...
Missed in [38130].
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38142
git-svn-id: http://core.svn.wordpress.org/trunk@38083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 16:50:28 +00:00
0a9bfead1c
Docs: In meta box functions, clarify that "Meta box ID" refers to the `id` attribute of the meta box and not a numeric ID.
...
Fixes #37211 .
Built from https://develop.svn.wordpress.org/trunk@38131
git-svn-id: http://core.svn.wordpress.org/trunk@38072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 19:24:28 +00:00
97fd7d829f
Menus: In `wp_nav_menu_item_taxonomy_meta_box()`:
...
* Rename the `$taxonomy` parameter to `$box` for clarity and consistency with other meta box functions.
* Make the docs more consistent with `post_categories_meta_box()` and other meta box functions.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38130
git-svn-id: http://core.svn.wordpress.org/trunk@38071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 19:21:28 +00:00
5fd308db50
Menus: In `wp_nav_menu_item_post_type_meta_box()`:
...
* Rename the `$post_type` parameter to `$box` for clarity and consistency with other meta box functions.
* Make the docs more consistent with `post_format_meta_box()` and other meta box functions.
* Correct type and description for the third argument of `nav_menu_items_{$post_type_name}_recent` filter.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38129
git-svn-id: http://core.svn.wordpress.org/trunk@38070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 19:19:29 +00:00
550bc85e06
Docs: Correct and expand the docs for the `$taxonomy` argument of `wp_nav_menu_item_taxonomy_meta_box()`.
...
Props mehulkaklotar for initial patch.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38128
git-svn-id: http://core.svn.wordpress.org/trunk@38069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 18:01:29 +00:00
6bcbeb858d
Docs: Correct and expand the docs for the `$post_type` argument of `wp_nav_menu_item_post_type_meta_box()`.
...
Props mehulkaklotar for initial patch.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38127
git-svn-id: http://core.svn.wordpress.org/trunk@38068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 18:00:32 +00:00
60de6917fb
Docs: Add and clarify changelog entries for elements that can now accept, use, or return `WP_Post_Type` objects.
...
Also adds a missing initial `@since` version for `wp_xmlrpc_server::_prepare_post_type()`.
See [37890]. See #36217 .
Built from https://develop.svn.wordpress.org/trunk@38051
git-svn-id: http://core.svn.wordpress.org/trunk@37992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-13 15:24:28 +00:00
31f150080a
Docs: Standardize references to "meta box" or "meta boxes" as two distinct words throughout core documentation per the core spelling guide.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@38029
git-svn-id: http://core.svn.wordpress.org/trunk@37970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-10 00:56:28 +00:00
60dc856d64
Posts: Introduce `WP_Post_Type` and use it in `register_post_type()` and `unregister_post_type()`.
...
This changes the global `$wp_post_types` to an array of `WP_Post_Type` objects. `WP_Post_Type` includes methods to handle post type supports, rewrite rules, meta boxes, hooks, and taxonomies.
Each post type argument becomes a property of `WP_Post_Type`.
Props swissspidy, flixos90.
Fixes #36217 .
Built from https://develop.svn.wordpress.org/trunk@37890
git-svn-id: http://core.svn.wordpress.org/trunk@37831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-28 16:41:35 +00:00
f5bf3676b1
Nav Menus: Use `WP_Query` for quick searches.
...
`the_post()` sets the `$in_the_loop` property to true which is unexpected in the admin if you're using filters which should only affect real loops.
Props ruud@joyo.
Fixes #27042 .
Built from https://develop.svn.wordpress.org/trunk@37881
git-svn-id: http://core.svn.wordpress.org/trunk@37822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-27 11:51:30 +00:00
542e462d9d
Menus: Support nested array variables in POST data when saving menus.
...
[36510] allowed larger menus to be created in the Edit Menu screen by JSON-encoding the entire form into a single input field. However, it did not correctly handle nested arrays.
This introduces a new `_wp_expand_nav_menu_post_data()` helper function to handle this POST data which uses `array_replace_recursive()` internally. Since the latter is only available on PHP 5.3+, we add a compatibility function to ensure PHP 5.2 support.
Props ericlewis, neverything, swissspidy.
Fixes #36590 for trunk. See #14134 .
Built from https://develop.svn.wordpress.org/trunk@37748
git-svn-id: http://core.svn.wordpress.org/trunk@37713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-19 12:25:28 +00:00
e5dd89ae57
Menus: Use new colors for error/info notices.
...
Props barryceelen.
Fixes #36857 .
Built from https://develop.svn.wordpress.org/trunk@37529
git-svn-id: http://core.svn.wordpress.org/trunk@37497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 09:40:28 +00:00
c3055cc190
Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
...
See #36913 .
Built from https://develop.svn.wordpress.org/trunk@37488
git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:01:30 +00:00
a311bea6d1
Customize: Fix toggle of title attribute field visibility on nav menus admin page.
...
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].
See #35273 .
Props sidati, westonruter.
Fixes #36353 .
Built from https://develop.svn.wordpress.org/trunk@37153
git-svn-id: http://core.svn.wordpress.org/trunk@37119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:55:27 +00:00
7441acafaf
Customize: Fix persistence of toggles for displayed nav menu item properties.
...
* Eliminates need to click more than one checkbox to have preferences saved.
* Adds debouncing to saving user-selected menu item properties.
* Also removes discrepancies between available nav menu item properties on admin page vs Customizer.
Fixes #35273 .
Props afercia, westonruter.
Built from https://develop.svn.wordpress.org/trunk@36908
git-svn-id: http://core.svn.wordpress.org/trunk@36876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 21:41:28 +00:00
62d8fda8dd
After [36171] remove all the occurrences of the old CSS clearfix.
...
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.
See #26396 .
Built from https://develop.svn.wordpress.org/trunk@36422
git-svn-id: http://core.svn.wordpress.org/trunk@36389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 13:46:27 +00:00
450cbb3e81
Accessibility: Remove title attributes from the Menus screen.
...
Also, adds missing labels and improves the existing ones.
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36379
git-svn-id: http://core.svn.wordpress.org/trunk@36346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 14:26:27 +00:00
54b8c3e53b
Docs: Fix some minor DocBlock alignment issues.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35885
git-svn-id: http://core.svn.wordpress.org/trunk@35849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:37:28 +00:00
1a43f0b290
Do not pass FALSE as second parameter in variable class_exists() checks
...
Because these are generally plugin-provided, we want plugins to be
able to use autoloaders.
fixes #20523
Built from https://develop.svn.wordpress.org/trunk@35749
git-svn-id: http://core.svn.wordpress.org/trunk@35713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-30 04:15:27 +00:00
18852f07f2
Menus: After [35450], use correct IDs in `$initial_meta_boxes`.
...
Props swissspidy.
Fixes #33925 .
Built from https://develop.svn.wordpress.org/trunk@35502
git-svn-id: http://core.svn.wordpress.org/trunk@35466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 10:56:26 +00:00
8f603650f4
Menus: Prevent display conflicts in the screen options for Menus when a post type and taxonomy share the same slug.
...
Prior to this change, both taxonomies and post types added meta boxes to the Menus UI (which in-turn registered screen options) using the same ID formula: `add-{$id}`. This caused a conflict between the two elements, resulting in the rendering of a screen option for only the taxonomy or post type but not both. Moving to a new meta box ID for post types, `add-post-type-{$id}`, removes that conflict.
Note: This change in meta box IDs for post types effectively resets current user settings for the visibility of post types in the Menus UI.
Fixes #33925 .
Built from https://develop.svn.wordpress.org/trunk@35450
git-svn-id: http://core.svn.wordpress.org/trunk@35414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 05:47:24 +00:00
2920285225
Don't use `<strong>` in translatable string in `wp-admin/includes/nav-menu.php`.
...
Add translator commment.
Props ramiy.
Fixes #34500 .
Built from https://develop.svn.wordpress.org/trunk@35444
git-svn-id: http://core.svn.wordpress.org/trunk@35408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:37:24 +00:00
a83a250ee0
Don't use `<strong>` in translatable string in `wp-admin/includes/nav-menu.php`.
...
Add translator commment.
Props ramiy.
Fixes #34500 .
Built from https://develop.svn.wordpress.org/trunk@35442
git-svn-id: http://core.svn.wordpress.org/trunk@35406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:17:26 +00:00
dc1e85a540
Nav Menus: show custom post type Archive item at the top of the `View All` tab for the post type on the legacy Nav Menu screen.
...
Props aaroncampbell, DrewAPicture, seanchayes, hlashbrooke, paulwilde, ericlewis, raulillana
See #16075 .
Built from https://develop.svn.wordpress.org/trunk@35382
git-svn-id: http://core.svn.wordpress.org/trunk@35346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 17:46:25 +00:00
217b661703
Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35170
git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:44:25 +00:00
ee97475edb
Docs: Add a file header to wp-admin/includes/nav-menus.php.
...
See [34168]. See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34421
git-svn-id: http://core.svn.wordpress.org/trunk@34385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:27:24 +00:00
84da11d918
Pass `false` as the 2nd argument to `class_exists()` to disable autoloading and to not cause problems for those who define `__autoload()`.
...
Fixes #20523 .
Built from https://develop.svn.wordpress.org/trunk@34348
git-svn-id: http://core.svn.wordpress.org/trunk@34312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:52:25 +00:00
fde014e85e
Move the admin Nav Menu Walker subclasses into their own files. Load in `nav-menu.php` to remain BC.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34168
git-svn-id: http://core.svn.wordpress.org/trunk@34136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:02:25 +00:00
f9e7fb306c
Merge two similar strings.
...
Props dipesh.kakadiya.
Fixes #33777 .
Built from https://develop.svn.wordpress.org/trunk@33998
git-svn-id: http://core.svn.wordpress.org/trunk@33967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 10:59:27 +00:00
ef87172270
`foreach` is a statement, not a function.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33734
git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 20:28:22 +00:00
f9194e361c
Add a description for the dynamic portion of the `nav_menu_items_{$post_type_name}_recent` filter added in 4.3.
...
See [32833]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33211
git-svn-id: http://core.svn.wordpress.org/trunk@33183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 19:51:24 +00:00
92d67bf395
Use valid markup in `Walker_Nav_Menu_Edit::start_el()` - replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`.
...
Props sagarjadhav.
Fixes #31817 .
Built from https://develop.svn.wordpress.org/trunk@32879
git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:22:26 +00:00
d872f38c31
Show the posts meta box by default in Appearance > Menus.
...
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.
Props bcole808.
Fixes #32440 .
Built from https://develop.svn.wordpress.org/trunk@32842
git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:04:26 +00:00
c9e1e2be9b
Make posts in the 'Most recent' tab of post type meta boxes filterable.
...
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.
Props jpyper, chriscct7.
Fixes #19365 .
Built from https://develop.svn.wordpress.org/trunk@32833
git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:35:28 +00:00
5c6b63d3a6
`if` is a statment, not a function.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32800
git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
0e77b693ac
Nav menus: hide the title attribute field by default for new users and installs.
...
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.
props paulwilde.
fixes #32218 .
Built from https://develop.svn.wordpress.org/trunk@32691
git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:38:25 +00:00
b3e0cfd25d
Add (more) missing doc blocks to `wp-admin/includes/*`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32655
git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
a51dfa3971
In the style of #30947 and `default-filters.php`, add 2 new files to `wp-admin/includes`:
...
`admin-filters.php`
`ms-admin-filters.php`
There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.
See #32529 .
Built from https://develop.svn.wordpress.org/trunk@32653
git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
b56b9b3e5c
Add `@global` annotations for `wp-admin/*`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32642
git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
af7a017f46
When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32545
git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
d85f8fe326
Admin notices: Make (most) core notices dismissible.
...
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.
props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233 . see #23367 .
Built from https://develop.svn.wordpress.org/trunk@31973
git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
296dba2804
Nav menus: Return to calling links "Custom Links".
...
It was like this before 3.6 and got a bit lost during that development cycle. Also uses the terminology more consistently in the nav menu UI.
props tyxla.
fixes #31344 .
Built from https://develop.svn.wordpress.org/trunk@31748
git-svn-id: http://core.svn.wordpress.org/trunk@31729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 06:15:27 +00:00
5567d03278
Nav menus: Better JS performance on initial load of edit screen.
...
The accessibility helpers previously processed all items when editing a menu, which was quite slow to the point of being unresponsive for large menus. They now only process items when they are expanded or a user comes near them in some way, such as hover or focus.
Also simplifies a redundant set of click event handlers down to one, which further enhances performance.
props atimmer, sevenspark.
fixes #25698 .
Built from https://develop.svn.wordpress.org/trunk@31604
git-svn-id: http://core.svn.wordpress.org/trunk@31585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:14:25 +00:00
5eb5afac34
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30982
git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
78bb3e5ff5
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
...
Also adds a few inline `@see` cross-references as they apply.
Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30648
git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
3699ea4155
Use the correct type (integer) for the `$menu_id` parameter in the `wp_get_nav_menu_to_edit()` DocBlock.
...
Also properly mark the parameter as optional and specify the default value.
Props jaimieolmstead for the initial patch.
Fixes #30540 .
Built from https://develop.svn.wordpress.org/trunk@30627
git-svn-id: http://core.svn.wordpress.org/trunk@30617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 04:25:23 +00:00
f8657d5890
Remove redundant and erroneous `@uses` tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
007ec52958
Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8.
...
Change all core calls from `json_encode()` to `wp_json_encode()`.
Fixes #28786 .
Built from https://develop.svn.wordpress.org/trunk@30055
git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:35:19 +00:00
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
2f513d3320
Fix some `hackificator` odds and ends in `wp-admin`:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
e57fa7300d
In `wp-admin/includes/nav-menu.php`, remove dead code:
...
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it.
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28300
git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:55:14 +00:00
029dd247be
Ensure the `wp_edit_nav_menu_walker` filter is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28213
git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:50:15 +00:00
a9b74e2088
Ensure the `nav_menu_meta_box_object` filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28207
git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:14:15 +00:00
cb8951b0b3
Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
...
See #27200 .
Built from https://develop.svn.wordpress.org/trunk@27262
git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
95ff70fcc0
Remove redundant translation function calls.
...
props markoheijnen.
see #26187 .
Built from https://develop.svn.wordpress.org/trunk@26349
git-svn-id: http://core.svn.wordpress.org/trunk@26250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 12:42:09 +00:00
df6010446a
Don't use esc_attr_e() function for a non-translatable context.
...
props yoavf, mattheu.
fixes #26187 .
Built from https://develop.svn.wordpress.org/trunk@26347
git-svn-id: http://core.svn.wordpress.org/trunk@26248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 12:04:09 +00:00
94a3ee8d68
Inline documentation for hooks in wp-admin/includes/nav-menu.php.
...
Props Faison.
Fixes #25474 .
Built from https://develop.svn.wordpress.org/trunk@25935
git-svn-id: http://core.svn.wordpress.org/trunk@25894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 17:48:11 +00:00
5361a8abca
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
74488bdcb0
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
75eb364ced
Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410 .
...
Built from https://develop.svn.wordpress.org/trunk@25741
git-svn-id: http://core.svn.wordpress.org/trunk@25654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 18:47:09 +00:00
39d7e0df8a
Improve inline documentation for `Walker_Nav_Menu`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`.
...
Includes previously undocumented parameters.
See #23406 .
Built from https://develop.svn.wordpress.org/trunk@25643
git-svn-id: http://core.svn.wordpress.org/trunk@25560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 21:02:09 +00:00
a4841da471
Use `get_the_title()` when dealing with `post_type`-like items in the admin.
...
Props nacin, DrewAPicture.
Fixes #14975 .
Built from https://develop.svn.wordpress.org/trunk@25285
git-svn-id: http://core.svn.wordpress.org/trunk@25249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:08:08 +00:00
eccd3e42df
Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942 .
...
Built from https://develop.svn.wordpress.org/trunk@25209
git-svn-id: http://core.svn.wordpress.org/trunk@25181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 11:26:09 +00:00
61e5d3e5c1
Remove unused variable. props jeremyfelt. fixes #25121 .
...
Built from https://develop.svn.wordpress.org/trunk@25098
git-svn-id: http://core.svn.wordpress.org/trunk@25080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-23 00:19:09 +00:00
84c50056b7
Reinstate 'label' property of nav menu items. Fixes a regression from [22234].
...
Fixes #24840 . Props johnbillion.
git-svn-id: http://core.svn.wordpress.org/trunk@24798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-27 06:50:59 +00:00
99973e4738
Nav Menus: Hide the rearrange section in no-js. see #14045 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-13 16:38:14 +00:00
4b13a1ffa4
Fix E_STRICT notices in walkers. props dvarga. see #24356 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
58e02a1530
Remove unnecessary parenthetical that should have been "e.g." instead of "i.e." anyway.
...
see #23119
git-svn-id: http://core.svn.wordpress.org/trunk@24356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-25 16:52:26 +00:00
4b174612ab
Prevent menu items with '0' label from being removed on menu saving. props MikeHansenMe, kovshenin. fixes #23051 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 18:03:09 +00:00
415a5c60da
* Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually.
...
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.
props solarissmoke, bpetty, SergeyBiryukov. fixes #11446 .
git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 00:22:02 +00:00
e2dde2765c
Update the instructions on Edit Menus screen. props DrewAPicture. fixes #24261 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 14:55:14 +00:00
10d898ecbb
Remove _wp_delete_nav_menu(). wp_delete_nav_menu() should instead remove the menu from theme locations, which was the only difference between the functions. see #23119 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 04:28:12 +00:00
271030746c
RTL for Nav Menu tweaks. see #23641 . see #23645 . props lessbloat
...
git-svn-id: http://core.svn.wordpress.org/trunk@23808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 08:53:26 +00:00
9bd740f616
Accessibility revamp for nav menus.
...
props lessbloat. fixes #14045
git-svn-id: http://core.svn.wordpress.org/trunk@23727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 04:47:19 +00:00
63dfa74c9f
Remove unused variables. props GaryJ. fixes #23789 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 17:08:04 +00:00
83bb916b81
Turn the Nav Menu meta boxes into an accordion. Less sprawling and overwhelming.
...
* Registration stays the same — they're meta boxes
* Call `do_accordion_sections()` instead of `do_meta_boxes()` and they render as an accordion
props DrewAPicture, lessbloat, jkudish. fixes #23450 . see #23449
git-svn-id: http://core.svn.wordpress.org/trunk@23707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 13:16:38 +00:00
52c46736df
Improve the UX of the Nav Menus screen. Kill the tabs, and change to a
...
dropdown, unless you have zero or one menus (which is the most common),
in which case you jump right into editing your sole menu.
Do assignment to location using checkboxes in the main menu editing
section instead of the backwards menu => location assignment in a
random meta box.
More to come, but this gets us started.
props lessbloat, DrewAPicture, jkudish. see #23119
git-svn-id: http://core.svn.wordpress.org/trunk@23441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 04:53:59 +00:00
cbd737470c
Kill use of colons in class names, props SergeyBiryukov, fixes #21152
...
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
26445266d4
In nav menus, avoid firing the magic WP_Post getter for potentially non-existent properties, which results in a metadata cache hit. see #22189 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-15 14:19:45 +00:00
1acd8b556f
New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
...
Be on the lookout for weirdness.
props lessbloat. see #21456 .
git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
557d9313a7
Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 05:26:19 +00:00
c1b0670c2d
Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
f3b63e4537
Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
010396ab1a
Remove use of nonexistent include_last_update_time arg from get_terms() call. See #19953 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-15 16:48:27 +00:00
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
616c35e71c
One newline is enough.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
340e93324c
Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
31e3ff3fb1
Avoid 'Only variables should be passed by reference' warnings. Props SergeyBiryukov. see #18975
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-28 15:48:44 +00:00
43eae59235
Translated strings in attributes require esc_attr(). s/_e/esc_attr_e/g
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-20 15:04:46 +00:00
67661f7181
Avoid 'Only variables should be passed by reference' warnings. Reverts [18110]. see #18975
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 20:44:39 +00:00
48d20c1839
Hide nav menu item order arrows when JS is available and correct expanded nav menu item CSS bug.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-22 22:33:27 +00:00
Weston Ruter
Andrea Fercia
Scott Taylor
Dion Hulse
Sergey Biryukov
Drew Jaynes
Dominik Schilling
Pascal Birchler
Mark Jaquith
Konstantin Obenland
Helen Hou-Sandí
Gary Pendergast
Andrew Nacin
Andrew Ozz
azaozz
duck_
ryan
nacin
koopersmith