Commit Graph

2460 Commits

Author SHA1 Message Date
Scott Taylor 149346ff6e MCE View sandboxes:
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.

Built from https://develop.svn.wordpress.org/trunk@29615


git-svn-id: http://core.svn.wordpress.org/trunk@29389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:46:15 +00:00
Scott Taylor 80bda02c0f Media Modal:
* the Image Details frame does not have a menu, indicate that by setting `menu: false` when adding states.
* mimic the default router rendering by toggling a `hide-menu` class on the frame when the region for menu is `null`
* remove the dead render code for the Image Details frame

See #29339.

Built from https://develop.svn.wordpress.org/trunk@29613


git-svn-id: http://core.svn.wordpress.org/trunk@29387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:22:16 +00:00
Helen Hou-Sandí 60c6399d1c Media Grid: Show upload errors above the grid rather than as a popup.
props pento, stephdau, helen. fixes #29141.

Built from https://develop.svn.wordpress.org/trunk@29612


git-svn-id: http://core.svn.wordpress.org/trunk@29386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:18:17 +00:00
Andrew Ozz 04e28b468c Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
Built from https://develop.svn.wordpress.org/trunk@29609


git-svn-id: http://core.svn.wordpress.org/trunk@29383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 22:45:16 +00:00
Andrew Ozz a2ad27c03e TinyMCE wpView: exclude more non-printable keyCodes in isSpecialKey(), fixes #29115
Built from https://develop.svn.wordpress.org/trunk@29606


git-svn-id: http://core.svn.wordpress.org/trunk@29380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 20:41:16 +00:00
Andrew Ozz d0a76f284f Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173
Built from https://develop.svn.wordpress.org/trunk@29603


git-svn-id: http://core.svn.wordpress.org/trunk@29377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 19:37:16 +00:00
Scott Taylor d869fe0603 Media: cleanup recent changes to `media.view.FocusManager`.
* Adjusts the focus method to target the menu for the current modal
* Refactor the FocusManager so that the method names and the functionality matches more closely with how it currently works. The changes in 4.0 to the FocusManager change the purpose of the focus manager entirely — instead of being a way to save and restore focus state, the new FocusManager is about constraining keyboard navigation via the tab key to inside the modal. 

Props gcorne.
See #23560.

Built from https://develop.svn.wordpress.org/trunk@29602


git-svn-id: http://core.svn.wordpress.org/trunk@29376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:23:16 +00:00
Scott Taylor db0b4c5b4d Media: when activating a mode after [29056], don't trigger the `{mode}:activate` event twice in a row.
See #29366.

Built from https://develop.svn.wordpress.org/trunk@29601


git-svn-id: http://core.svn.wordpress.org/trunk@29375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:07:15 +00:00
Scott Taylor 32e896f5b8 Media Grid: exit selection mode when Esc is pressed.
Fixes #29366.

Built from https://develop.svn.wordpress.org/trunk@29600


git-svn-id: http://core.svn.wordpress.org/trunk@29374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 17:45:17 +00:00
Scott Taylor 1335ff3e40 Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
Props adamsilverstein.
See #28822.

Built from https://develop.svn.wordpress.org/trunk@29585


git-svn-id: http://core.svn.wordpress.org/trunk@29359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:55:15 +00:00
Scott Taylor d5d0b37c35 Media Grid: restore focus to the selected item when shift-tab away from the attachment details sidebar.
Fixes #29303.

Built from https://develop.svn.wordpress.org/trunk@29584


git-svn-id: http://core.svn.wordpress.org/trunk@29358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:43:16 +00:00
Helen Hou-Sandí 8a545bf05e Media: Only fire keyboard events for the Attachments view once.
Firing them twice was breaking arrow key navigation in media attachment grids.

props gcorne.
fixes #29304.

Built from https://develop.svn.wordpress.org/trunk@29582


git-svn-id: http://core.svn.wordpress.org/trunk@29356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:17:16 +00:00
Andrew Ozz 61292620c5 Editor scrolling:
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29579


git-svn-id: http://core.svn.wordpress.org/trunk@29353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 05:11:16 +00:00
Andrew Ozz 42258a6d89 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268.
Built from https://develop.svn.wordpress.org/trunk@29577


git-svn-id: http://core.svn.wordpress.org/trunk@29351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 18:55:15 +00:00
Andrew Ozz f2c881cf3b TinyMCE: update to 4.1.4-20140822. Changes:
- Fixed bug where sometimes the resize rectangles wouldn't properly render on images on WebKit/Blink. 9a2d01cc14
- Fixed nodeChanged selection issue where the image selection wouldn't be removed if you clicked right after/before it. dd729c67e0
- Fixed bug in list plugin where delete/backspace would merge empty LI elements in lists incorrectly. caadfb05dd
See #29310
Built from https://develop.svn.wordpress.org/trunk@29576


git-svn-id: http://core.svn.wordpress.org/trunk@29350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 17:44:16 +00:00
Andrew Ozz 3d60d9f875 Autosave: prevent setting multiple stale `wp-saving-post-*` cookies when the browser disregards "session cookies" expiration on quit:
- Add expiration time of 24 hours for these cookies.
- Rename them to `wp-saving-post` (no post_id) so there is never more than one cookie per domain.
Fixes #29294.
Built from https://develop.svn.wordpress.org/trunk@29572


git-svn-id: http://core.svn.wordpress.org/trunk@29346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 00:25:16 +00:00
Andrew Ozz 5545f24b4f TinyMCE wpView: prevent errors when pasting multiple non-embeddable URLs, props avryl, fixes #29268
Built from https://develop.svn.wordpress.org/trunk@29571


git-svn-id: http://core.svn.wordpress.org/trunk@29345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 00:14:17 +00:00
Andrew Ozz c3c20549c5 TinyMCE: update to 4.1.4. Changelog: http://www.tinymce.com/develop/changelog/?type=tinymce. Fixes #29310
Built from https://develop.svn.wordpress.org/trunk@29570


git-svn-id: http://core.svn.wordpress.org/trunk@29344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 23:53:18 +00:00
Scott Taylor 31e599943d Media Grid: after [29566], account for Trash and Delete.
See #28842.

Built from https://develop.svn.wordpress.org/trunk@29568


git-svn-id: http://core.svn.wordpress.org/trunk@29342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:42:16 +00:00
Scott Taylor 7029af94e7 Media Grid: after completing a Bulk action, switch from `select` to `edit` mode.
Fixes #28842.

Built from https://develop.svn.wordpress.org/trunk@29566


git-svn-id: http://core.svn.wordpress.org/trunk@29340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:20:16 +00:00
Scott Taylor ca180e2544 Media Grid: don't auto-select attachments upon upload.
Props ocean90.
See #28842.

Built from https://develop.svn.wordpress.org/trunk@29565


git-svn-id: http://core.svn.wordpress.org/trunk@29339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:54:14 +00:00
Scott Taylor d6213d64a5 After [29543], the iframe sandboxes for media need to load Open Sans. Playlists look aggressively bad without it. Adds font styles for the body.
See #29048.

Built from https://develop.svn.wordpress.org/trunk@29564


git-svn-id: http://core.svn.wordpress.org/trunk@29338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:36:16 +00:00
Scott Taylor 8f810cbaa4 `media.view.Attachment`: set all of the view attributes in the same hash.
See [29299], #23560.

Built from https://develop.svn.wordpress.org/trunk@29562


git-svn-id: http://core.svn.wordpress.org/trunk@29337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:53:14 +00:00
Scott Taylor 6352d703a0 Media Grid/Modal Keyboard navigation improvements:
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading. 
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press

Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560.

Built from https://develop.svn.wordpress.org/trunk@29560


git-svn-id: http://core.svn.wordpress.org/trunk@29335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:35:17 +00:00
Scott Taylor 557861446f Cleanup after [29220]:
`media.controller.Library` is State/Backbone Model and should not touch views.

See #23560.

Built from https://develop.svn.wordpress.org/trunk@29558


git-svn-id: http://core.svn.wordpress.org/trunk@29333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 20:00:16 +00:00
Scott Taylor a43cfb4f96 Cleanup after [29220]:
* `media.view.Attachment` should not reach outside itself with global jQuery selectors
* `media.view.Attachment.Details` will re-render when `media.view.Attachment`'s single status changes. Add a `ready` callback to apply initial input focus

See #23560.

Built from https://develop.svn.wordpress.org/trunk@29556


git-svn-id: http://core.svn.wordpress.org/trunk@29331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:29:17 +00:00
Scott Taylor 31bb46d0fc Initial cleanup after [29220]:
* Alter/remove some jQuery global selectors, views should only manage themselves
* Trigger an event for attachments when arrow keys are pressed: `attachment:keydown:arrow`
* `media.view.Attachments` should listen for `attachment:keydown:arrow`
* Favor scoped selectors over globals

See #23560.

Built from https://develop.svn.wordpress.org/trunk@29555


git-svn-id: http://core.svn.wordpress.org/trunk@29330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:14:15 +00:00
Dominik Schilling 9f91625fb6 Insert Media: Don't select a model if it's already selected.
props avryl, adamsilverstein.
fixes #29152.

Built from https://develop.svn.wordpress.org/trunk@29553


git-svn-id: http://core.svn.wordpress.org/trunk@29328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:20:15 +00:00
Scott Taylor 2808d5c523 Media Grid: Cleanup toggling of Next/Previous in Edit modal.
Fixes #29264.

Built from https://develop.svn.wordpress.org/trunk@29551


git-svn-id: http://core.svn.wordpress.org/trunk@29327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:11:15 +00:00
Dominik Schilling 6e0ab38b9e Media Library: Set max value of columns to 12.
fixes #29275.
Built from https://develop.svn.wordpress.org/trunk@29547


git-svn-id: http://core.svn.wordpress.org/trunk@29323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 16:17:19 +00:00
Andrew Ozz 342a8ce6a6 TinyMCE wpView: scale iframes to 100% width and ensure they have transparent background. See #29048.
Built from https://develop.svn.wordpress.org/trunk@29545


git-svn-id: http://core.svn.wordpress.org/trunk@29321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 22:43:16 +00:00
Andrew Ozz 51b307bcd3 TinyMCE wpView: add sandbox iframe body styling to get proper height when resizing the iframe, fixes #29270.
Built from https://develop.svn.wordpress.org/trunk@29544


git-svn-id: http://core.svn.wordpress.org/trunk@29320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 22:20:15 +00:00
Andrew Ozz afdb25bd56 TinyMCE wpView sandbox iframes:
- Make them transparent.
- Don't load tons of unrelated styles that can break them. This could result in minimal styling mismatch to the front-end, but keeps the views working well and looking good.
Props avryl, fixes #29048.
Built from https://develop.svn.wordpress.org/trunk@29543


git-svn-id: http://core.svn.wordpress.org/trunk@29319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 21:53:15 +00:00
Andrew Ozz 228c77ca2f TinyMCE: fix the keycode check when removing the Edit/Delete toolbar from images on keydown, see #28705
Built from https://develop.svn.wordpress.org/trunk@29541


git-svn-id: http://core.svn.wordpress.org/trunk@29317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 19:14:16 +00:00
Andrew Ozz 28bcbcb972 Fix typo in the 'wpeditimage' plugin, see #28705
Built from https://develop.svn.wordpress.org/trunk@29540


git-svn-id: http://core.svn.wordpress.org/trunk@29316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 18:43:20 +00:00
Andrew Ozz 542e56ac3f TinyMCE wpView: remove CSS transition for the fake caret. Can have very annoying side effect: the whole page shifts a bit. See #28595.
Built from https://develop.svn.wordpress.org/trunk@29536


git-svn-id: http://core.svn.wordpress.org/trunk@29312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 03:57:17 +00:00
Andrew Ozz 74f6ddc816 TinyMCE wpView: ignore more keys when the caret is around a view. Part props avryl, fixes #29115.
Built from https://develop.svn.wordpress.org/trunk@29535


git-svn-id: http://core.svn.wordpress.org/trunk@29311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 03:27:17 +00:00
Andrew Ozz c0fef55a47 DFW: revert applying the Visual editor body color and background-color for now. Set the color to #333 and the background to transparent. Fixes #28330.
Built from https://develop.svn.wordpress.org/trunk@29533


git-svn-id: http://core.svn.wordpress.org/trunk@29309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 18:23:16 +00:00
Dominik Schilling a28bc71819 Media Modal: Restore to the previous filter and search error message.
fixes #28963.
Built from https://develop.svn.wordpress.org/trunk@29532


git-svn-id: http://core.svn.wordpress.org/trunk@29308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 16:28:19 +00:00
Scott Taylor a0f2fe6599 After [29507], move unreachable code from `_requery()` to `Query.get()`.
Built from https://develop.svn.wordpress.org/trunk@29531


git-svn-id: http://core.svn.wordpress.org/trunk@29307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 04:08:15 +00:00
Scott Taylor 36e4e9917b wpviews: whenever a view is updated or inserted, don't refresh ALL of the views.
Props avryl.
Fixes #28788.

Built from https://develop.svn.wordpress.org/trunk@29530


git-svn-id: http://core.svn.wordpress.org/trunk@29306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 03:59:17 +00:00
Scott Taylor 29a73daa74 Media Grid: Don't show attachment details in the "sidebar" for errors.
Props ocean90.
Fixes #29037.

Built from https://develop.svn.wordpress.org/trunk@29527


git-svn-id: http://core.svn.wordpress.org/trunk@29303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:26:16 +00:00
Scott Taylor 6d342e812f Media Grid: improve the design of upload errors.
Props celloexpressions.
See #29141.

Built from https://develop.svn.wordpress.org/trunk@29526


git-svn-id: http://core.svn.wordpress.org/trunk@29302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:22:17 +00:00
Scott Taylor 5aee14e9a1 Media Grid: on page load with `?item=` in the URL, if the model is not in the library: fetch it. Defer the triggering of `edit:attachment` until the model has been fetched.
Fixes #29052.

Built from https://develop.svn.wordpress.org/trunk@29525


git-svn-id: http://core.svn.wordpress.org/trunk@29301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:13:16 +00:00
Andrew Ozz aff2892646 TinyMCE: fix the edit image and wpview buttons on touch screen PCs, fixes #29235.
Built from https://develop.svn.wordpress.org/trunk@29521


git-svn-id: http://core.svn.wordpress.org/trunk@29297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 20:11:15 +00:00
Dominik Schilling 4dc4277a60 Media Grid: Improve position of fixed toolbar at small-screen sizes.
see #28842.
Built from https://develop.svn.wordpress.org/trunk@29517


git-svn-id: http://core.svn.wordpress.org/trunk@29293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 14:03:14 +00:00
Andrew Ozz ac463e5c71 TinyMCE wpView: add small delay before inserting wpview sandbox iframes into the DOM. Fixes a problem in Firefox that may prevent rendering them. Fixes #29241.
Built from https://develop.svn.wordpress.org/trunk@29513


git-svn-id: http://core.svn.wordpress.org/trunk@29290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 03:43:18 +00:00
Scott Taylor 4d20246173 Media Grid: `$.when` expects a splat. Disambiguation: change `cache` to `refresh` as the arg name for `_requery()`.
See [29490], #29145.

Built from https://develop.svn.wordpress.org/trunk@29507


git-svn-id: http://core.svn.wordpress.org/trunk@29284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 19:00:16 +00:00
Andrew Ozz 81815c4d03 Some pre-commit cleanup of media-grid.js and media-views.js
Built from https://develop.svn.wordpress.org/trunk@29494


git-svn-id: http://core.svn.wordpress.org/trunk@29272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 01:13:16 +00:00
Scott Taylor b0c782bf08 Media Grid, support `MEDIA_TRASH`: add AYS to bulk actions.
See #29145.

Built from https://develop.svn.wordpress.org/trunk@29492


git-svn-id: http://core.svn.wordpress.org/trunk@29270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 19:08:14 +00:00
Scott Taylor df4cc86671 Media Grid, support `MEDIA_TRASH`:
* Only use the special `trashAttachment` logic when in `edit-metadata` mode.
* Don't support the `trash` filter in the Add Media modal for now.
* Properly toggle trash/untrash logic in the Attachment Details sidebar

See #29145.

Built from https://develop.svn.wordpress.org/trunk@29491


git-svn-id: http://core.svn.wordpress.org/trunk@29269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:51:19 +00:00
Scott Taylor 571111022e Media Grid, support `MEDIA_TRASH`:
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.

Props koop for the knowledge sharing and thought partnership.
See #29145.

Built from https://develop.svn.wordpress.org/trunk@29490


git-svn-id: http://core.svn.wordpress.org/trunk@29268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:31:19 +00:00
Helen Hou-Sandí 5fc736f49e Media grid bulk selection styling:
* Fade content within each attachment item so that focus styling is still clear.
* Less jarring toolbar pinning.
* Tighten up the fade in/out transition.

see #28842.

Built from https://develop.svn.wordpress.org/trunk@29489


git-svn-id: http://core.svn.wordpress.org/trunk@29267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 07:18:15 +00:00
Scott Taylor b5922001b4 Remove debug line from [29484].
See #28842.


Built from https://develop.svn.wordpress.org/trunk@29485


git-svn-id: http://core.svn.wordpress.org/trunk@29263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 00:37:15 +00:00
Scott Taylor 9c08ad236a Media Grid: add Bulk Selection mode for deleting attachments.
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.

See #28842.

Built from https://develop.svn.wordpress.org/trunk@29484


git-svn-id: http://core.svn.wordpress.org/trunk@29262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 22:45:15 +00:00
Scott Taylor 99a10a450e Media Grid: treat Edit Image like a `mode`, which it is, instead of a `state`, which it is not.
Fixes #29206.

Built from https://develop.svn.wordpress.org/trunk@29483


git-svn-id: http://core.svn.wordpress.org/trunk@29261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 19:26:16 +00:00
Scott Taylor ca03604712 In the Edit Attachment frame, when in Edit Image mode, add a key event for Escape. There are conflicting `keydown` handlers that don't propagate the event to the modal properly.
Fixes #29121.

Built from https://develop.svn.wordpress.org/trunk@29481


git-svn-id: http://core.svn.wordpress.org/trunk@29259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 18:15:18 +00:00
Drew Jaynes d33c807723 Fix some documentation typos in various core files.
Props vlajos.
Fixes #29199.

Built from https://develop.svn.wordpress.org/trunk@29479


git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 03:56:17 +00:00
Andrew Ozz 8f2b4fbe9e Fix the `wp-settings-*` cookies used in getUserSetting()/setUserSetting(). They should be set without `COOKIE_DOMAIN` to work properly for sub-domains. Fixes #29095.
Built from https://develop.svn.wordpress.org/trunk@29478


git-svn-id: http://core.svn.wordpress.org/trunk@29256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 02:47:16 +00:00
Andrew Ozz ce14155edf Media modal: make sure the Close button is focused after attempting to close the onscreen keyboard on touch devices. Props celloexpressions, fixes #29166.
Built from https://develop.svn.wordpress.org/trunk@29473


git-svn-id: http://core.svn.wordpress.org/trunk@29251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 21:58:15 +00:00
Andrew Ozz 2f4bd918b2 TinyMCE: fix the 'editimage' plugin for touch devices. Better attempt to hide the onscreen keyboard when the media modal opens and TinyMCE is in focus. See #28595, #29166
Built from https://develop.svn.wordpress.org/trunk@29471


git-svn-id: http://core.svn.wordpress.org/trunk@29249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 04:27:18 +00:00
Andrew Ozz e75033f21b TinyMCE: update wpview and editimage plugins for 4.1.3. Add show/hide of the Edit and Delete buttons on views and images on 'touchend'. See #28595, #29166
Built from https://develop.svn.wordpress.org/trunk@29463


git-svn-id: http://core.svn.wordpress.org/trunk@29241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-10 04:22:15 +00:00
Andrew Ozz efd52cb860 TinyMCE: update to 4.1.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt, fixes #29166
Built from https://develop.svn.wordpress.org/trunk@29458


git-svn-id: http://core.svn.wordpress.org/trunk@29236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 20:56:15 +00:00
Scott Taylor 1c93f05e2a Upgrade MediaElement to 2.15.0:
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273

All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master

See #29110.

Built from https://develop.svn.wordpress.org/trunk@29457


git-svn-id: http://core.svn.wordpress.org/trunk@29235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 20:44:17 +00:00
Scott Taylor 28c22db07d Video:
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal

See #29110.

Built from https://develop.svn.wordpress.org/trunk@29456


git-svn-id: http://core.svn.wordpress.org/trunk@29234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 19:39:15 +00:00
Andrew Ozz d11bb9bc50 Media at small screens:
- Show the image details/settings as an overlay.
- Better styling for the frame drop-down.
- Remove the multi-select by default on the Insert frame.
See #27423
Built from https://develop.svn.wordpress.org/trunk@29452


git-svn-id: http://core.svn.wordpress.org/trunk@29230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 05:09:16 +00:00
Scott Taylor 5cab03ab29 Add some docs to Customizer JS.
Props ericlewis.
See #29157.

Built from https://develop.svn.wordpress.org/trunk@29451


git-svn-id: http://core.svn.wordpress.org/trunk@29229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 23:31:15 +00:00
Scott Taylor c6ebc35a00 Add some docs to Customizer JS.
Props ericlewis.
See #29157.

Built from https://develop.svn.wordpress.org/trunk@29450


git-svn-id: http://core.svn.wordpress.org/trunk@29228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 22:10:15 +00:00
Andrew Ozz 13aee01e2b TinyMCE: don't access the parent window when opening the (iframe based) Help/Keyboard Shortcuts modal. Fixes #20094.
Built from https://develop.svn.wordpress.org/trunk@29449


git-svn-id: http://core.svn.wordpress.org/trunk@29227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 21:18:16 +00:00
Andrew Ozz b8198ecf64 Media: improve the media modal at small screen sizes and make it usable on phones, first run. Part-props gcorne, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29446


git-svn-id: http://core.svn.wordpress.org/trunk@29224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 03:46:17 +00:00
Scott Taylor ed5d17ab77 Media Grid: remove Router code that doesn't actually ever run.
See #29121.

Built from https://develop.svn.wordpress.org/trunk@29444


git-svn-id: http://core.svn.wordpress.org/trunk@29222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 22:37:16 +00:00
Scott Taylor 1217efe905 Media Grid: remove Router code that doesn't actually ever run.
See #29121.

Built from https://develop.svn.wordpress.org/trunk@29443


git-svn-id: http://core.svn.wordpress.org/trunk@29221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 22:33:15 +00:00
Scott Taylor 34e3377d42 JSHint after [29437].
Built from https://develop.svn.wordpress.org/trunk@29439


git-svn-id: http://core.svn.wordpress.org/trunk@29217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:21:16 +00:00
Scott Taylor 8c96874742 Media Grid:
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.

Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29438


git-svn-id: http://core.svn.wordpress.org/trunk@29216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:01:15 +00:00
Scott Taylor ccd0499d96 Media Grid: use a `media.view.Label` instance in the toolbar for the screen reader text for Search.
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29437


git-svn-id: http://core.svn.wordpress.org/trunk@29215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:54:15 +00:00
Helen Hou-Sandí 485229bc64 Revert styling changes to the Attachment Details modal from [29289]. fixes #28844.
Built from https://develop.svn.wordpress.org/trunk@29436


git-svn-id: http://core.svn.wordpress.org/trunk@29214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:32:16 +00:00
Scott Taylor 8593f7b5e9 Media Grid: add screen reader text in a subview on the toolbar, a `media.view.Label` instance before `media.view.DateFilter`.
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29435


git-svn-id: http://core.svn.wordpress.org/trunk@29213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:25:16 +00:00
Scott Taylor 3f17e7040e Create a new Backbone view, `media.view.Label`, which can be used as a subview in things like toolbars, which need screen reader text.
Make an initial instance of it for the label for Bulk Actions in Media Grid.

See #29026.

Built from https://develop.svn.wordpress.org/trunk@29434


git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:09:17 +00:00
Scott Taylor c5dff42d51 Revert [29428] to avoid errors with Add Media for now.
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29432


git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 19:40:15 +00:00
Scott Taylor afb0b3e4ef Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
Props afercia.
Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29428


git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
Scott Taylor f0f4174ed8 Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].
See #28819.

Built from https://develop.svn.wordpress.org/trunk@29427


git-svn-id: http://core.svn.wordpress.org/trunk@29205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:03:17 +00:00
Scott Taylor 8ed123c97f In `media.view.AttachmentFilters.All`, make `uploaded` conditional upon `media.view.settings.post.id` and include a new filter: `unattached`.
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead. 

Props ocean90, wonderboymusic.
Fixes #29065.

Built from https://develop.svn.wordpress.org/trunk@29426


git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00
Scott Taylor 935f10413e Media Grid: expose the `$.Deffered()` object in `media.view.AttachmentsBrowser.updateContent()` so the grid can call `Backbone.history.start()` when models actually exist.
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.

Built from https://develop.svn.wordpress.org/trunk@29420


git-svn-id: http://core.svn.wordpress.org/trunk@29198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 21:44:17 +00:00
Scott Taylor a58a4da852 Media Grid: display upload errors in a dismissable sidebar.
See #29037.

Built from https://develop.svn.wordpress.org/trunk@29415


git-svn-id: http://core.svn.wordpress.org/trunk@29193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 19:13:15 +00:00
Scott Taylor 27b0d4cd20 In `media.view.BulkSelectionActionButton.click()`, do not assume that `delete` is the only possible bulk action.
Fixes #29101.

Built from https://develop.svn.wordpress.org/trunk@29403


git-svn-id: http://core.svn.wordpress.org/trunk@29181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:24:19 +00:00
Andrew Ozz b61903f2bb TinyMCE: add support for `class` attribute on the caption shortcode. Part props knutsp, kadamwhite, fixes #28951.
Built from https://develop.svn.wordpress.org/trunk@29380


git-svn-id: http://core.svn.wordpress.org/trunk@29158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 00:58:16 +00:00
Andrew Ozz 8fc01225ac Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29379


git-svn-id: http://core.svn.wordpress.org/trunk@29157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 19:37:15 +00:00
Andrew Ozz e6b0d0c9ee Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29376


git-svn-id: http://core.svn.wordpress.org/trunk@29154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 05:20:18 +00:00
Andrew Ozz 666fec5144 TinyMCE: fix alignment buttons when used on image with caption. Remove old/unneeded code. Fixes #28705.
Built from https://develop.svn.wordpress.org/trunk@29370


git-svn-id: http://core.svn.wordpress.org/trunk@29148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 00:52:17 +00:00
Andrew Ozz 42c8135fac Mobile: hide the onscreen keyboard when the media modal opens, fixes #28549.
Built from https://develop.svn.wordpress.org/trunk@29369


git-svn-id: http://core.svn.wordpress.org/trunk@29147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 22:34:16 +00:00
Scott Taylor 27890cc734 Media Grid: don't blow away the Attachment Details modal every time a new model is loaded.
Props ericlewis.
Fixes #29104.

Built from https://develop.svn.wordpress.org/trunk@29368


git-svn-id: http://core.svn.wordpress.org/trunk@29146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:40:17 +00:00
Scott Taylor 696c12bc55 Media Grid: don't select `body` with jQuery when instantiating `media.view.UploaderWindow`.
Props ericlewis.
See #28965.

Built from https://develop.svn.wordpress.org/trunk@29367


git-svn-id: http://core.svn.wordpress.org/trunk@29145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:37:19 +00:00
Dominik Schilling e6513fe33b Media Modal: Restore uploader view, when no items are found.
see #28963.
Built from https://develop.svn.wordpress.org/trunk@29364


git-svn-id: http://core.svn.wordpress.org/trunk@29140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:47:16 +00:00
Andrew Ozz 9662554bfb Add blog_id to the `wp-settings-*` cookie (used for storing user state) to prevent it being overloaded on sub-domain sites. Fixes #29095.
Built from https://develop.svn.wordpress.org/trunk@29362


git-svn-id: http://core.svn.wordpress.org/trunk@29138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:09:16 +00:00
Dominik Schilling fb9084eed3 Disable background page scrolling when modals are open.
props celloexpressions.
fixes #29074.
Built from https://develop.svn.wordpress.org/trunk@29346


git-svn-id: http://core.svn.wordpress.org/trunk@29124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:15:15 +00:00
Mark Jaquith 61a0551529 Match background color in DFW and adapt the dashed outline color.
fixes #28330. props avryl, ipstenu.
Built from https://develop.svn.wordpress.org/trunk@29340


git-svn-id: http://core.svn.wordpress.org/trunk@29120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 18:10:16 +00:00
Andrew Ozz b9886e92e3 Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.
Built from https://develop.svn.wordpress.org/trunk@29336


git-svn-id: http://core.svn.wordpress.org/trunk@29116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 02:43:17 +00:00
Andrew Ozz 2dda137191 wpLink: add custom open and close events, props bradyvercher, fixes #28095.
Built from https://develop.svn.wordpress.org/trunk@29335


git-svn-id: http://core.svn.wordpress.org/trunk@29115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 02:04:17 +00:00
Andrew Ozz d15f9617f9 wpLink:
- Fix adding a link on pressing Enter.
- Don't auto-focus the URL field after selecting a local link.
- Don't auto-focus the URL field when opening on touch devices. Toggle focus/blur on it to close the onscreen keyboard so the modal is positioned properly.
See #28897.
Built from https://develop.svn.wordpress.org/trunk@29333


git-svn-id: http://core.svn.wordpress.org/trunk@29113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-31 23:28:19 +00:00
Andrew Ozz 4bff4ff2d6 Use node.nodeName instead of tagName for better consistency/compatibility, see #28704.
Built from https://develop.svn.wordpress.org/trunk@29332


git-svn-id: http://core.svn.wordpress.org/trunk@29112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-30 17:49:16 +00:00