Commit Graph

33970 Commits

Author SHA1 Message Date
Drew Jaynes 745ae9915f Docs: Improve the DocBlock summary for `WP::remove_query_var()`, introduced in [36177].
See #35234. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36900


git-svn-id: http://core.svn.wordpress.org/trunk@36868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 17:05:29 +00:00
Drew Jaynes feb3c20d12 Docs: Standardize file header summary for wp-includes/class-wp-metadata-lazyloader.php.
See [36897]. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36899


git-svn-id: http://core.svn.wordpress.org/trunk@36867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 16:59:27 +00:00
Drew Jaynes e7bea9ba6e Docs: Improve inline documentation syntax throughout `WP_Metadata_Lazyloader`, introduced in [36566].
See #35816. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36898


git-svn-id: http://core.svn.wordpress.org/trunk@36866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 16:55:26 +00:00
Drew Jaynes a1b18a3ae6 Docs: Add a missing file header to wp-includes/class-wp-metadata-lazyloader.php, introduced in [36566].
See #35816. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36897


git-svn-id: http://core.svn.wordpress.org/trunk@36865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 16:52:27 +00:00
Boone Gorges e032560e6b Correct `@return` annotation for `wp_set_object_terms()` and related functions.
The return value is an array of term taxonomy IDs, not term IDs.

Fixes #36182.
Built from https://develop.svn.wordpress.org/trunk@36896


git-svn-id: http://core.svn.wordpress.org/trunk@36864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 16:17:28 +00:00
Dion Hulse d074af672c Bump akismet external
git-svn-id: http://core.svn.wordpress.org/trunk@36863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 08:10:38 +00:00
Jeremy Felt f917022d6f Docs: Update the return type for `get_active_blog_for_user()`
This is now a `WP_Site` object.

See #32450.

Built from https://develop.svn.wordpress.org/trunk@36895


git-svn-id: http://core.svn.wordpress.org/trunk@36862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 07:50:26 +00:00
Jeremy Felt ba65ad94f2 Docs: Update param/return types for `WP_Site` in `ms-blogs.php`
* `get_blog_details()` now returns a `WP_Site` object.
* `clean_blog_cache()` is now called with a `WP_Site` object.

See #32450.

Built from https://develop.svn.wordpress.org/trunk@36894


git-svn-id: http://core.svn.wordpress.org/trunk@36861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 07:42:26 +00:00
Jeremy Felt 80dd53519d Docs: Update the return type for `get_current_site()`
This is now a `WP_Network` object.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36893


git-svn-id: http://core.svn.wordpress.org/trunk@36860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 07:28:26 +00:00
Weston Ruter 8c9c4b2698 Customize: Remove unused JS variable to fix jshint error introduced in [36890].
See #36164.

Built from https://develop.svn.wordpress.org/trunk@36892


git-svn-id: http://core.svn.wordpress.org/trunk@36859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 05:05:27 +00:00
Mike Schroder 1e120a01ec Media: Progressive enhancement for Imagick; add profiles to whitelist.
- Progressive enhancement for optional compression improvements and stripping meta.
- Whitelist IPTC and XMP profiles to maintain Copyright and Rights Usage Terms.
- Whitelist EXIF profile to maintain orientation information. If handled on upload in the future, it can be stripped as well.

Fixes #33642. See #28634.
Props joemcgill, juliobox, ahockley, markoheijnen, adamsilverstein, wonderboymusic, mikeschroder.
Built from https://develop.svn.wordpress.org/trunk@36891


git-svn-id: http://core.svn.wordpress.org/trunk@36858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 04:44:26 +00:00
Weston Ruter d27ae61355 Customize: Remove selective refresh error message from appearing inline within the preview.
The error message will still be available in the developer console.

Removes part of [36586].
See #27355.
Fixes #36164.

Built from https://develop.svn.wordpress.org/trunk@36890


git-svn-id: http://core.svn.wordpress.org/trunk@36857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 04:37:28 +00:00
Weston Ruter e11fd98ec6 Customize: Fix regressions and harden implementation of selective refresh for nav menus.
* Request full refresh if there are nav menu instances that lack partials for a changed setting.
* Restore `WP_Customize_Nav_Menus::$preview_nav_menu_instance_args` and `WP_Customize_Nav_Menus::export_preview_data()` from 4.3, and keeping a tally of all `wp_nav_menu()` calls regardless of whether they can use selective refresh.
* Ensure that all instances of `wp_nav_menu()` are tallied, regardless of whether they are made during the initial preview call or during subsequent partial renderings. Export `nav_menu_instance_args` with each partial rendering response just as they are returned when rendering the preview as a whole.
* Fix issues with Custom Menu widget where nav menu items would fail to render when switching between menus when a menu lacked items to begin with.
* Make sure the fallback behavior is invoked when the partial is no longer associated with a menu.
* Do fallback behavior to refresh preview when all menu items are removed from a menu.

Follows [36586].
See #27355.
Fixes #35362.

Built from https://develop.svn.wordpress.org/trunk@36889


git-svn-id: http://core.svn.wordpress.org/trunk@36856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 00:09:26 +00:00
Drew Jaynes f64b97c597 Menus: Avoid a notice when outputting a description for an existing archive menu item for a post type that doesn't.
Props bradyvercher.
See [36859]. Fixes #35324.

Built from https://develop.svn.wordpress.org/trunk@36888


git-svn-id: http://core.svn.wordpress.org/trunk@36855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 18:25:26 +00:00
Dominik Schilling 7e8e3429e1 Media: Change wording for media files which aren't attached.
The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.
Built from https://develop.svn.wordpress.org/trunk@36887


git-svn-id: http://core.svn.wordpress.org/trunk@36854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 17:43:25 +00:00
Dominik Schilling 67475a943f Update Random_Compat from 1.1.6 to 1.2.1.
Changes: https://github.com/paragonie/random_compat/compare/1.1.6...v1.2.1

See #35665.
Built from https://develop.svn.wordpress.org/trunk@36886


git-svn-id: http://core.svn.wordpress.org/trunk@36853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 17:15:27 +00:00
Dominik Schilling 75c2005a49 Tests: Remove `test_new_files_are_not_in_old_files_array()` from [36843].
The test assumes that if a CSS file was added to `$_old_files` all three files (.css, .min.css, -rtl.min.css; it's actually missing the fourth case, -rtl.css) don't exist anymore. But this isn't always the case. The test is also incredible slow because it does three `file_exists()` checks for each file — the global contains 646 files currently.

It's important what we have in the /build directory and that's covered by `test_new_files_are_not_in_old_files_array_compiled()`.

Fixes #36083.
Built from https://develop.svn.wordpress.org/trunk@36885


git-svn-id: http://core.svn.wordpress.org/trunk@36852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 16:45:27 +00:00
Dominik Schilling d3f222e3b9 Script Loader: Enqueue the minified version of farbtastic if `SCRIPT_DEBUG` is false.
The files are available since [36341].

See #36083, #35229.
Built from https://develop.svn.wordpress.org/trunk@36884


git-svn-id: http://core.svn.wordpress.org/trunk@36851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 16:04:29 +00:00
Dion Hulse 0d60e585e6 Tests: Remove debug from [36882].
Built from https://develop.svn.wordpress.org/trunk@36883


git-svn-id: http://core.svn.wordpress.org/trunk@36850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 07:08:26 +00:00
Dion Hulse 227254aa74 Tests: Merge the two different `wp_normalize_path()` tests.
See #35996, [36881].

Built from https://develop.svn.wordpress.org/trunk@36882


git-svn-id: http://core.svn.wordpress.org/trunk@36849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 07:07:28 +00:00
Dion Hulse 6a23a0ddd5 Filesystem: Support Windows shares/DFS roots in `wp_normalize_path()`.
Props rilwis for initial patch.
Fixes #35996.

Built from https://develop.svn.wordpress.org/trunk@36881


git-svn-id: http://core.svn.wordpress.org/trunk@36848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 06:00:26 +00:00
Dion Hulse 68eb6c1593 oEmbed: During discovery, only request the first 150kb of linked content to avoid timouts requesting larger documents.
Fixes #35979.

Built from https://develop.svn.wordpress.org/trunk@36880


git-svn-id: http://core.svn.wordpress.org/trunk@36847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 05:58:26 +00:00
Andrea Fercia 34ab7ae5ac Accessibility: Remove the title attributes from the old Media UI.
Also, adds better indication and attributes for the required form fields.
Moves some styles to `deprecated-media.css`.

Props andg, afercia.
Fixes #34944.
Built from https://develop.svn.wordpress.org/trunk@36879


git-svn-id: http://core.svn.wordpress.org/trunk@36846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:29:26 +00:00
Drew Jaynes d59fdfd951 Docs: Add a missing `@since` version to the DocBlock for `wp_add_dashboard_widget()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36878


git-svn-id: http://core.svn.wordpress.org/trunk@36845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:17:26 +00:00
Andrea Fercia 5bd8219816 Customizer: Improve the collapsed view when switching to the responsive view.
Props rittesh.patel, afercia.

Fixes #35220.
Built from https://develop.svn.wordpress.org/trunk@36877


git-svn-id: http://core.svn.wordpress.org/trunk@36844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:05:27 +00:00
Pascal Birchler dc2f39b7f0 Embeds: Add support for embeds in the theme template hierarchy.
This allows themes to directly override the default template. The order in which the template is retrieved is as follows: `embed-$post_type-$post_format.php` -> `embed-$post_type.php` -> `embed.php`.

The `embed_template` filter gets replaced by the dynamic `{$type}_template` filter in `get_query_template()`.

Props ChriCo, swissspidy.
See #34561. Fixes #34278.
Built from https://develop.svn.wordpress.org/trunk@36876


git-svn-id: http://core.svn.wordpress.org/trunk@36843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 19:33:26 +00:00
Konstantin Obenland c13130918a Bundled Themes: Prevent elements within fieldsets from overflowing in Webkit.
Fixes #35421.

Built from https://develop.svn.wordpress.org/trunk@36875


git-svn-id: http://core.svn.wordpress.org/trunk@36842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 19:15:30 +00:00
Pascal Birchler 033044a872 Taxonomy: Improve backward compatibility on the `wp-admin/term.php` page.
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.
Built from https://develop.svn.wordpress.org/trunk@36874


git-svn-id: http://core.svn.wordpress.org/trunk@36841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 12:56:28 +00:00
Pascal Birchler 5d6513f0bc Embeds: Adjust the iframe title attribute for improved accessibility.
Changes the title attribute from `Embedded WordPress Post` to `"Post name" — site title`.

Props ramiy.
Fixes #35804.
Built from https://develop.svn.wordpress.org/trunk@36873


git-svn-id: http://core.svn.wordpress.org/trunk@36840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 10:00:29 +00:00
Dion Hulse cbda43788b Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source.
Props diddledan.
Fixes #35290

Built from https://develop.svn.wordpress.org/trunk@36872


git-svn-id: http://core.svn.wordpress.org/trunk@36839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 06:32:29 +00:00
Dominik Schilling f4ef187c2c Dependencies: Improve group processing of script dependencies.
This is a follow-up to [36604].

When processing dependencies `$this->group` will be the minimum of the script's registered group and all preceding siblings. This is wrong because only a scripts ancestors in the dependency chain should affect where it is loaded. Effectively `$this->group` introduced a form of global state which potentially corrupted the group of dependencies. Sorting covers up this problem.
The issue in #35873 was that script were not moving their dependencies to a lower group when necessary.

The fix:
* In `WP_Dependencies::all_deps()` pass the new `$group` value to `WP_Dependencies::all_deps()`. Previously the wrong value was passed because the parent script could have moved with `WP_Scripts::set_group()`.
* In `WP_Scripts::all_deps()` pass the `$group` parameter to `WP_Dependencies::all_deps()` so it doesn't always use `false` for `$group`. Same for `WP_Styles::all_deps()`.

Props stephenharris, gitlost.
Fixes #35956.
Built from https://develop.svn.wordpress.org/trunk@36871


git-svn-id: http://core.svn.wordpress.org/trunk@36838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 19:50:27 +00:00
Pascal Birchler c73a812109 HTTP: Avoid an undefined index notice in `wp_http_validate_url()`.
Props perezlabs.
Fixes #34164.
Built from https://develop.svn.wordpress.org/trunk@36870


git-svn-id: http://core.svn.wordpress.org/trunk@36837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 15:55:26 +00:00
Andrea Fercia aaa040eee9 CSS: Rename the handle for `deprecated-media.css` after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.
Built from https://develop.svn.wordpress.org/trunk@36869


git-svn-id: http://core.svn.wordpress.org/trunk@36836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 15:38:28 +00:00
Sergey Biryukov b80a516549 Docs: Add `wp_add_dashboard_widget()` parameter descriptions.
Props meitar for initial patch.
Fixes #36092.
Built from https://develop.svn.wordpress.org/trunk@36868


git-svn-id: http://core.svn.wordpress.org/trunk@36835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 12:08:28 +00:00
Jeremy Felt 27e29666a8 Multisite: Handle redirect to a user's subdomain properly during login
`wp-login.php` uses `wp_safe_redirect()` for all redirects, even those that do not involve unsafe data from the request or referer.

When a user of a subdomain site attempts to login to a network site they do not have access to, the host in the redirect URL is treated as unsafe by `wp_safe_redirect()` as it has no immediate awareness as to which hosts are valid on the network. On a subdirectoy network, everything works as expected because the host is the same.

In this specific block of `wp-login.php`, all URLs are generated by WordPress and we can use `wp_redirect()` to handle the redirects. Users authenticating via other network sites will now be redirected properly. Hosts passed via the `redirect_to` query var will continue to be handled by `wp_safe_redirect()`.

Fixes #30598.

Built from https://develop.svn.wordpress.org/trunk@36867


git-svn-id: http://core.svn.wordpress.org/trunk@36834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 03:06:29 +00:00
Weston Ruter 40f6779665 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.

Built from https://develop.svn.wordpress.org/trunk@36866


git-svn-id: http://core.svn.wordpress.org/trunk@36833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 01:45:27 +00:00
Aaron Jorbin fe4a3452c3 Update grunt-contrib-cssmin ~0.14.0 → ~1.0.0
See #35104.

Built from https://develop.svn.wordpress.org/trunk@36865


git-svn-id: http://core.svn.wordpress.org/trunk@36832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:37:27 +00:00
Aaron Jorbin 796f7cd97d Update grunt-contrib-copy ~0.8.2 → ~1.0.0
See #35104.

Built from https://develop.svn.wordpress.org/trunk@36864


git-svn-id: http://core.svn.wordpress.org/trunk@36831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:35:27 +00:00
Aaron Jorbin ac2d660906 Update grunt-contrib-concat ~0.5.1 → ~1.0.0
see #35104

Built from https://develop.svn.wordpress.org/trunk@36863


git-svn-id: http://core.svn.wordpress.org/trunk@36830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:32:27 +00:00
Aaron Jorbin c6b12480a1 Update grunt-contrib-compress ~0.14.0 → ~1.1.0
See #35104

Built from https://develop.svn.wordpress.org/trunk@36862


git-svn-id: http://core.svn.wordpress.org/trunk@36829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:25:29 +00:00
Aaron Jorbin 06d9654602 Update grunt-contrib-clean from 0.6.0 → 1.0.0
see #35104

Built from https://develop.svn.wordpress.org/trunk@36861


git-svn-id: http://core.svn.wordpress.org/trunk@36828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:19:27 +00:00
Aaron Jorbin 241dfd09e8 Update Autoprefixer to 6.3.3
See #35104

Built from https://develop.svn.wordpress.org/trunk@36860


git-svn-id: http://core.svn.wordpress.org/trunk@36827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 23:16:32 +00:00
Aaron Jorbin d71a0600a6 Ensure Description is respected in post type archive menu items.
Tested scenarios include: using the default (which is the post type description), Setting a custom description for that individual menu item, and setting a custom description that is blank. Introduced in r35382.

Props Toro_Unit, mayukojpn, extendwings, jorbin.
Fixes #35324. See #16075.


Built from https://develop.svn.wordpress.org/trunk@36859


git-svn-id: http://core.svn.wordpress.org/trunk@36826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:57:26 +00:00
Dominik Schilling 30f8c75047 Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.
Built from https://develop.svn.wordpress.org/trunk@36858


git-svn-id: http://core.svn.wordpress.org/trunk@36825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:07:25 +00:00
Andrew Ozz b5cc1c7dfa TinyMCE:
- Fix the icon for the native dialogs close button.
- Highlight the button on :focus.

See #36035.
Built from https://develop.svn.wordpress.org/trunk@36857


git-svn-id: http://core.svn.wordpress.org/trunk@36824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:01:27 +00:00
Aaron Jorbin 265011b9b6 Fix License test
Broken in r36855

Fixes #35278


Built from https://develop.svn.wordpress.org/trunk@36856


git-svn-id: http://core.svn.wordpress.org/trunk@36823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 20:22:26 +00:00
Aaron Jorbin 5e7262847f Clarify Copyright year
Based on http://copyright.gov/title17/92chap4.html#401 and being more consistent with the rest of the document.

See also https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Fixes #35278

Built from https://develop.svn.wordpress.org/trunk@36855


git-svn-id: http://core.svn.wordpress.org/trunk@36822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 20:14:25 +00:00
Eric Lewis a749f90e73 Build/Test Tools: Document PHP unit test classes.
Props boonebgorges.
Fixes #35494.

Built from https://develop.svn.wordpress.org/trunk@36854


git-svn-id: http://core.svn.wordpress.org/trunk@36821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 19:48:28 +00:00
John Blackbourn 3184328ecb Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.
Fixes #35980

Built from https://develop.svn.wordpress.org/trunk@36853


git-svn-id: http://core.svn.wordpress.org/trunk@36820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 03:56:27 +00:00
Eric Lewis 0c1cca9961 Menus: Ensure theme location setting data is saved with a large menu.
[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.

Built from https://develop.svn.wordpress.org/trunk@36852


git-svn-id: http://core.svn.wordpress.org/trunk@36819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 00:47:26 +00:00