Commit Graph

33970 Commits

Author SHA1 Message Date
Andrew Ozz c353544c47 Customizer: fix cropping of small images when setting header image, site icon or logo.
Props obenland.
Fixes #36412.
Built from https://develop.svn.wordpress.org/trunk@37167


git-svn-id: http://core.svn.wordpress.org/trunk@37134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-08 01:23:29 +00:00
Dominik Schilling 9363b592e3 Customize: Harden assignment of Customizer settings transports for selective refreshable widgets
Theme support for `customize-selective-refresh-widgets` can be added _after_ the logic for registering the settings for incoming widgets that have been changed. This is due to themes adding the theme support in `after_setup_theme` which is also the action where `WP_Customize_Widgets::register_settings()` is called. If these both happen at priority 10, which one is called first depends on which one was added first. The other issue is that at the time that `WP_Customize_Widgets::register_settings()` is called at `after_setup_theme`, it is called before `widgets_init` and thus no widgets are yet registered. This means that any settings registered at this point will always have a `refresh` transport even if the theme supports `customize-selective-refresh-widgets`, since the `WP_Widget` instance is not visible yet to see if it supports selective refresh.

The fix: Defer `WP_Customize_Widgets::register_settings()` from `after_setup_theme` to `widgets_init` at priority 95 when the widget objects have all been registered. Also, ensure that the preview filter for `sidebars_widgets` is added before the sidebars are iterated for adding the controls.

Props westonruter.
Fixes #36389.
Built from https://develop.svn.wordpress.org/trunk@37166


git-svn-id: http://core.svn.wordpress.org/trunk@37133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-07 20:59:29 +00:00
Boone Gorges cfab9716e3 Use `__trashed` suffix rather than `-%trashed%` for trashed post slugs.
Percent signs are reserved characters in URIs. As such, it was impossible for
plugins to route requests to trashed posts, as happens in bbPress. The new
`__trashed` suffix should be sufficiently unique.

Also adds a test that demonstrates that the `__trashed` suffix can be
appended to slugs that contain the suffix somewhere other than the end of
the string.

Props netweb, ericlewis.
Fixes #11863.
Built from https://develop.svn.wordpress.org/trunk@37165


git-svn-id: http://core.svn.wordpress.org/trunk@37132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-07 19:22:28 +00:00
Aaron Jorbin 1c1daa7ba4 External Libraries: Update jQuery to 1.12.3.
Sing it with me: jQuery fixed two issues, now you can get them with WP 4.5.

Release Post: http://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.2...1.12.3

Fixes #35380.
Props ocean90.


Built from https://develop.svn.wordpress.org/trunk@37164


git-svn-id: http://core.svn.wordpress.org/trunk@37131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 22:45:27 +00:00
Mark Jaquith 31152de134 REST API: Deliver parameters unadulterated instead of slashed.
We goofed, and parameters accessed through the REST API's methods
were slashed (inconsistently, even). This unslashes the data, so
you get the un-messed-with data that was sent.

Props joehoyle.
Fixes #36419.
Built from https://develop.svn.wordpress.org/trunk@37163


git-svn-id: http://core.svn.wordpress.org/trunk@37130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 21:02:28 +00:00
Dominik Schilling b3b22fa1c6 I18N: On the Updates screen simplify plugin's version details link.
Replace the use of a `.screen-reader-text` element with an `aria-label` attribute to make the text easier to translate.

Props dimadin, ocean90.
See #35001.
Fixes #36410.
Built from https://develop.svn.wordpress.org/trunk@37162


git-svn-id: http://core.svn.wordpress.org/trunk@37129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 12:52:30 +00:00
Helen Hou-Sandí c35af62afd Update Akismet external to 3.1.10 in trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@37128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 00:46:13 +00:00
Aaron Jorbin 6c24223def Make Moderate Comment Screen Great Again by showing links
You know what's wrong with the Moderate Comment Screen? It doesn't win anymore. Well, I'm going make the Moderate Comment screen win. It's going to win by showing the urls that are linked to from every anchor. It's going to win by having those urls be a lighter shade of gray than the surrounding text. Spammy links aren't going to be able to hide in commas. Spammy links aren't going to win.  The Moderate Comment Screen is going to win and we are going to make the Moderate Comment Screen Great Again.

Fixes #36380
Props rachelbaker, mikeschroder, adamsilverstein, boonebgorges, melchoyce, ocean90, jorbin, pento

Built from https://develop.svn.wordpress.org/trunk@37161


git-svn-id: http://core.svn.wordpress.org/trunk@37127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 00:35:27 +00:00
Andrea Fercia 1bb3dd0ee7 Accessibility: improvements for the Editor wpLink modal form fields.
Adds `aria-describedby` attributes to the modal form fields after it
was partly restored in [37154].

Fixes #33301.
Built from https://develop.svn.wordpress.org/trunk@37160


git-svn-id: http://core.svn.wordpress.org/trunk@37126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-05 22:24:27 +00:00
Dominik Schilling f5c3c658a4 Editor: Remove trailing space from a help text string.
Props dimadin.
Fixes #36407.
Built from https://develop.svn.wordpress.org/trunk@37159


git-svn-id: http://core.svn.wordpress.org/trunk@37125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-05 10:54:29 +00:00
John Blackbourn 32b262fa1c Comments: Wrap the formatted comment text on the comment moderation screen in `comment_text()` so paragraphs and texturisation are applied.
Fixes #34133

Built from https://develop.svn.wordpress.org/trunk@37158


git-svn-id: http://core.svn.wordpress.org/trunk@37124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-04 23:33:27 +00:00
John Blackbourn 217b3b6487 Role/Capability: Add `create_sites` and `delete_sites` to the list of capabilities that are checked as part of the comporehensive roles and capabilities tests.
See #32394, #36413

Built from https://develop.svn.wordpress.org/trunk@37157


git-svn-id: http://core.svn.wordpress.org/trunk@37123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-04 22:30:28 +00:00
Dominik Schilling 3067561bd7 Plugins: Use correct placeholder for the number of reviews.
`number_format_i18n()` returns a string, not an integer.

See #35111.
Fixes #36395.
Built from https://develop.svn.wordpress.org/trunk@37156


git-svn-id: http://core.svn.wordpress.org/trunk@37122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-02 11:17:26 +00:00
Dominik Schilling 72a544168a I18N: Clarify translator comment for an a11y label added in [36618].
Props TacoVerdo.
See #35111.
Fixes #36396.
Built from https://develop.svn.wordpress.org/trunk@37155


git-svn-id: http://core.svn.wordpress.org/trunk@37121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-02 11:12:26 +00:00
Andrew Ozz 2618ccf64d Editor, wpLink:
- Restore the bottom half of the modal.
- Make it always expanded and remove the toggle. It is used as advanced link options now, no need to have simple mode.

Props iseulde, adamsilverstein, azaozz.
Fixes #36359.
Built from https://develop.svn.wordpress.org/trunk@37154


git-svn-id: http://core.svn.wordpress.org/trunk@37120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-01 21:13:29 +00:00
Weston Ruter a311bea6d1 Customize: Fix toggle of title attribute field visibility on nav menus admin page.
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.

Built from https://develop.svn.wordpress.org/trunk@37153


git-svn-id: http://core.svn.wordpress.org/trunk@37119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:55:27 +00:00
Weston Ruter 1a9fda07a4 Customize: Put focus on change button instead of remove button in media control.
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.

Props adamsilverstein, westonruter.
Fixes #36337.

Built from https://develop.svn.wordpress.org/trunk@37152


git-svn-id: http://core.svn.wordpress.org/trunk@37118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:41:26 +00:00
Aaron Jorbin 328b4aff92 Adjust unit tests to account for change in [37144]
Built from https://develop.svn.wordpress.org/trunk@37150


git-svn-id: http://core.svn.wordpress.org/trunk@37117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 19:53:25 +00:00
Aaron Jorbin 4e3df608dc Remove Debugging code introduced in [37145]
Built from https://develop.svn.wordpress.org/trunk@37148


git-svn-id: http://core.svn.wordpress.org/trunk@37115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:58:26 +00:00
Aaron Jorbin bd7ffca854 Add Nonce to updating wporg_favorites user meta field
Built from https://develop.svn.wordpress.org/trunk@37145


git-svn-id: http://core.svn.wordpress.org/trunk@37112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:36:26 +00:00
Nikolay Bachiyski 9b7a775413 Add nonce to AJAX action for script compression setting
Built from https://develop.svn.wordpress.org/trunk@37143


git-svn-id: http://core.svn.wordpress.org/trunk@37110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:21:25 +00:00
Konstantin Obenland db47a4913c Template: Remove `$size` reference from `get_custom_logo()`.
Argument was removed in [37077] in favor of `with` and `height` arguments.

Props ocean90.
Fixes #36327.


Built from https://develop.svn.wordpress.org/trunk@37135


git-svn-id: http://core.svn.wordpress.org/trunk@37102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 17:20:27 +00:00
Nikolay Bachiyski b4d97cc8a7 Taxonomies: make sure taxonomy functions work correctly with taxonomy names with special characters
The codex says that taxonomy names "should only contain lowercase letters and the underscore character", but that's not enforced. It's too late to enforce it, since some plugins haven't been following it and the official phpdoc doesn't mention this restriction.

Built from https://develop.svn.wordpress.org/trunk@37133


git-svn-id: http://core.svn.wordpress.org/trunk@37100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 17:13:28 +00:00
Jeremy Felt cb2b3ed3c7 Multisite: Improve escaping in network settings.
Built from https://develop.svn.wordpress.org/trunk@37124


git-svn-id: http://core.svn.wordpress.org/trunk@37091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:59:26 +00:00
Dominik Schilling af9f052087 HTTP: Improve detection of valid IP addresses.
Built from https://develop.svn.wordpress.org/trunk@37115


git-svn-id: http://core.svn.wordpress.org/trunk@37082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:38:26 +00:00
Drew Jaynes 9e4415bc5f Docs: Ignore `_wp_upload_dir_baseurl()` from parsing for the Code Reference.
See #36371.

Built from https://develop.svn.wordpress.org/trunk@37114


git-svn-id: http://core.svn.wordpress.org/trunk@37081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:29:26 +00:00
Konstantin Obenland 1edaf1c357 Customize: Respect aspect ratio on cropped images.
Takes into account whether the control supports `flex_width` and/or
`flex_height` and adjusts destination measurements accordingly.

Fixes #36318.


Built from https://develop.svn.wordpress.org/trunk@37113


git-svn-id: http://core.svn.wordpress.org/trunk@37080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:14:27 +00:00
Andrew Ozz bfd19e92f5 Add deprecated notice and removal warning to `_wp_upload_dir_baseurl()`.
Props DrewAPicture, azaozz.
Fixes #36371.
Built from https://develop.svn.wordpress.org/trunk@37112


git-svn-id: http://core.svn.wordpress.org/trunk@37079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:10:27 +00:00
Dominik Schilling 6a3acea8b5 Multisite: Validate new email address confirmations.
Built from https://develop.svn.wordpress.org/trunk@37103


git-svn-id: http://core.svn.wordpress.org/trunk@37070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 14:44:26 +00:00
Nikolay Bachiyski b15e4d2775 Snoopy: use escapeshellarg instead of escapeshellcmd
We are escaping arguments, not commands, so we'd better use the semantically correct function, even though they are similar.

Built from https://develop.svn.wordpress.org/trunk@37094


git-svn-id: http://core.svn.wordpress.org/trunk@37061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 13:58:28 +00:00
Aaron Jorbin c1d684383c Prevent PHP Warnings when using Custom Logo with no params
The parsing of defaults assumes that $args will be an array. This solves it for Custom Logo the same way it is solved for custom-header and custom-background.

Props obenland.
Fixes #36332.


Built from https://develop.svn.wordpress.org/trunk@37092


git-svn-id: http://core.svn.wordpress.org/trunk@37059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 02:22:26 +00:00
Dominik Schilling 9a16bfb5dc Editor: Make the tooltip for the 'apply' button in the inline link dialog translatable.
Props SergeyBiryukov.
Fixes #36366.
Built from https://develop.svn.wordpress.org/trunk@37091


git-svn-id: http://core.svn.wordpress.org/trunk@37058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-29 21:11:28 +00:00
Drew Jaynes 0e53ff6692 Docs: Standardize file headers for two embed templates introduced in [36693] for #34561.
Props flixos90.
Also missed props for flixos90 on [37087].

See #35986. See #36352.

Built from https://develop.svn.wordpress.org/trunk@37088


git-svn-id: http://core.svn.wordpress.org/trunk@37055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-28 18:27:26 +00:00
Drew Jaynes 0405289c03 Docs: Reference the correct embed templates and template parts filenames in headers for embed files introduced or changed in 4.5.
See [36693], #34561. See #35986. Fixes #36352.

Built from https://develop.svn.wordpress.org/trunk@37087


git-svn-id: http://core.svn.wordpress.org/trunk@37054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-28 18:24:27 +00:00
Drew Jaynes b6d1626613 Docs: Following [37085], properly indent the markdown-formatted examples in the DocBlock for `wpdb::esc_like()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37086


git-svn-id: http://core.svn.wordpress.org/trunk@37053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-27 18:27:26 +00:00
Drew Jaynes 60b9a5a48f Docs: Add missing quotes around a specifier in a query example in the DocBlock for `wpdb::esc_like()`.
Props madvic.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@37085


git-svn-id: http://core.svn.wordpress.org/trunk@37052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-27 18:25:26 +00:00
Pascal Birchler b204d3ead2 Taxonomy: After [36874], run the correct `load-edit-tags.php` hook on the new term edit page.
When not misspelled, this hook is useful (and needed) for backward compatibility.

Unprops swissspidy.
Fixes #34988.
Built from https://develop.svn.wordpress.org/trunk@37084


git-svn-id: http://core.svn.wordpress.org/trunk@37051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-27 15:16:29 +00:00
Drew Jaynes cb457da489 Docs: Improve the DocBlocks for `get_header_textcolor()` and `header_textcolor()` to mention that they both retrieve color values in the HEX format.
Props theMikeD.
Fixes #36336.

Built from https://develop.svn.wordpress.org/trunk@37083


git-svn-id: http://core.svn.wordpress.org/trunk@37050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-25 23:06:27 +00:00
Ella Iseulde Van Dorpe 3a151191e4 Editor: wptextpattern: add back inline tests
See [37024].
See #33300.

Built from https://develop.svn.wordpress.org/trunk@37080


git-svn-id: http://core.svn.wordpress.org/trunk@37047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-25 13:31:40 +00:00
Mike Schroder 40455626f0 Post 4.5-RC1 version bump.
Built from https://develop.svn.wordpress.org/trunk@37079


git-svn-id: http://core.svn.wordpress.org/trunk@37046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-24 03:58:27 +00:00
Mike Schroder cff715c6f6 4.5-RC1
Built from https://develop.svn.wordpress.org/trunk@37078


git-svn-id: http://core.svn.wordpress.org/trunk@37045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-24 03:32:26 +00:00
Konstantin Obenland cbbf361c03 Customize: Bring custom-logo args closer to custom-header.
Allows themes to specify the desired width and height of logos, and whether
that is flexible or not. Has the benefit of not having to generate a logo-sized
file for every image uploaded.

Props westonruter, celloexpressions.
Fixes #36255.


Built from https://develop.svn.wordpress.org/trunk@37077


git-svn-id: http://core.svn.wordpress.org/trunk@37044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-24 02:02:27 +00:00
Ella Iseulde Van Dorpe f8a66d7bf2 Update TinyMCE and jQuery UI button styles
Part props liljimmi.
Fixes #35571.


Built from https://develop.svn.wordpress.org/trunk@37076


git-svn-id: http://core.svn.wordpress.org/trunk@37043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-24 00:57:28 +00:00
Sergey Biryukov 4a5dea0d62 Canonical / Query: Restore the `is_404()` check in `wp_old_slug_redirect()` which was removed in [34659].
This reverts part of [34659] due to excessive canonical problems it's caused in 4.4.x.

Remove the unit tests which are no longer supported.
This also removes the `is_feed()` code to avoid confusion - only pages & embeds will be redirected.

Merges [36280] and [36281] to trunk.

Props dd32.
See #21602, #35344.
Built from https://develop.svn.wordpress.org/trunk@37075


git-svn-id: http://core.svn.wordpress.org/trunk@37042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 21:54:26 +00:00
Andrew Ozz a97d39785a TinyMCE: include the upstream fix for inserting `<hr>` while the caret is in an inline element: b1618d1adb.
Fixes #36165.
Built from https://develop.svn.wordpress.org/trunk@37074


git-svn-id: http://core.svn.wordpress.org/trunk@37041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 21:45:28 +00:00
Dominik Schilling a2d62ccf32 Common CSS: Reset bottom padding for `.nav-tab-wrapper`.
Props ericdaams.
Fixes #35960.
Built from https://develop.svn.wordpress.org/trunk@37073


git-svn-id: http://core.svn.wordpress.org/trunk@37040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 20:14:26 +00:00
Dominik Schilling 7c42afee11 External Libraries: Update jQuery Migrate to 1.4.0.
Changes: https://github.com/jquery/jquery-migrate/compare/1.3.0...1.4.0

Fixes #35380.
Built from https://develop.svn.wordpress.org/trunk@37072


git-svn-id: http://core.svn.wordpress.org/trunk@37039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 19:44:26 +00:00
Boone Gorges a1d7934406 Tests: Ensure that the default `wp_die()` handler can handle a `WP_Error` object.
Props dd32, utkarshpatel.
Fixes #36166.
Built from https://develop.svn.wordpress.org/trunk@37071


git-svn-id: http://core.svn.wordpress.org/trunk@37038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 19:01:26 +00:00
Dominik Schilling 51e6a98040 External Libraries: Update jQuery to 1.12.2.
Release post: http://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.1...1.12.2

See #35380.
Built from https://develop.svn.wordpress.org/trunk@37070


git-svn-id: http://core.svn.wordpress.org/trunk@37037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 18:47:26 +00:00
Drew Jaynes 9f48d46be3 Docs: Properly mark `$args` parameters in two `WP_oEmbed` methods as optional.
Also clarify that the `$args` parameters can accept a string (the default) in addition to an array.

Props ramiy.
See #36296.

Built from https://develop.svn.wordpress.org/trunk@37069


git-svn-id: http://core.svn.wordpress.org/trunk@37036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 17:08:27 +00:00