ca70683001
Database: `WP_Network`, `WP_Network_Query`, and `WP_Site_Query` call `wpdb::_escape()`, thus requiring it to be `public`. It previously had no access modifier. `_` at the beginning of a method, believe it or not, does not enforce visibility constraints.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38314
git-svn-id: http://core.svn.wordpress.org/trunk@38255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 21:10:28 +00:00
dcb0261664
Comments: in `wp_handle_comment_submission()`, `$_wp_unfiltered_html_comment` is passed as part of `$comment_data`, but is not used locally.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38313
git-svn-id: http://core.svn.wordpress.org/trunk@38254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 21:04:28 +00:00
3755823702
Taxonomy: remove unnecessary `break` in `WP_Term::__get()`.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38312
git-svn-id: http://core.svn.wordpress.org/trunk@38253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 21:00:30 +00:00
5025f72fd3
Nav Menus: remove unnecessary variable assignment in `wp_nav_menu_item_post_type_meta_box()`.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38311
git-svn-id: http://core.svn.wordpress.org/trunk@38252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 20:58:28 +00:00
778d794e4f
REST API: remove unnecessary variable assignments in `rest_handle_options_request()`.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38310
git-svn-id: http://core.svn.wordpress.org/trunk@38251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 20:56:28 +00:00
a017516291
Media: remove unnecessary variable assignment in `gallery_shortcode()`.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38309
git-svn-id: http://core.svn.wordpress.org/trunk@38250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 20:53:29 +00:00
7b30193bb7
General: remove variable set needlessly in `wp_check_jsonp_callback()`.
...
See #37771 .
Built from https://develop.svn.wordpress.org/trunk@38308
git-svn-id: http://core.svn.wordpress.org/trunk@38249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 20:51:30 +00:00
22adda2aa0
Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.
...
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.
Props ramiy.
See #37748 .
Built from https://develop.svn.wordpress.org/trunk@38307
git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 18:25:31 +00:00
02939c03e5
Common CSS: Allow for `.nav-tab-wrapper` class to be used on elements other than `h3` to increase flexibility for custom settings pages.
...
Props ramiy, afercia.
Fixes #37257 .
Built from https://develop.svn.wordpress.org/trunk@38306
git-svn-id: http://core.svn.wordpress.org/trunk@38247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 16:33:30 +00:00
26d7a5607b
Multisite: Fix copy/paste issue in `id` attribute for a dismissible message on Sites screen.
...
Props imath.
Fixes #37764 .
Built from https://develop.svn.wordpress.org/trunk@38305
git-svn-id: http://core.svn.wordpress.org/trunk@38246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 14:22:31 +00:00
cd6d2bae92
Login: `retrieve_password()` does not need to import 2 globals that it does not use.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38304
git-svn-id: http://core.svn.wordpress.org/trunk@38245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 04:48:28 +00:00
d31456b615
Media: add a function, `wp_get_additional_image_sizes()`, that wraps the retrieval of the global `$_wp_additional_image_sizes`. Removes 6 global imports.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38303
git-svn-id: http://core.svn.wordpress.org/trunk@38244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 04:37:28 +00:00
b34dea908f
Media: fix unit test after [38296].
...
https://en.wikipedia.org/wiki/Coupling_(computer_programming)#Disadvantages
Fixes #36246 .
Built from https://develop.svn.wordpress.org/trunk@38302
git-svn-id: http://core.svn.wordpress.org/trunk@38243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 04:17:34 +00:00
ee44093211
Customize: Ensure a newly-added custom link nav menu item has the appropriate CSS class names.
...
For nav menu items of the `custom` type, their `object` should also be set to `custom`, so that the `menu-item-custom` class name will be added.
Props vishalkakadiya.
Fixes #37575 .
Built from https://develop.svn.wordpress.org/trunk@38301
git-svn-id: http://core.svn.wordpress.org/trunk@38242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 03:12:32 +00:00
57740f3c91
Docs: Update jsdoc in `customize-nav-menus.js` to remove references to Menu Customizer plugin.
...
Also fix `@param` for `updateAssignedLocationsInSectionTitle`.
Props gma992, westonruter.
Fixes #37520 .
Built from https://develop.svn.wordpress.org/trunk@38300
git-svn-id: http://core.svn.wordpress.org/trunk@38241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 00:56:27 +00:00
44c499329a
Docs: Update outdated phpdoc for `WP_Customize_Manager::validate_setting_values()` to reflect changes in [37942].
...
Props dlh.
See #37247 .
Fixes #37759 .
Built from https://develop.svn.wordpress.org/trunk@38299
git-svn-id: http://core.svn.wordpress.org/trunk@38240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 00:41:31 +00:00
4bdd4edb77
Comments: in `WP_Comment_Query::fill_descendants()`, `continue` if there is an empty array in the loop.
...
See #37416 , [38297].
Built from https://develop.svn.wordpress.org/trunk@38298
git-svn-id: http://core.svn.wordpress.org/trunk@38239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-21 06:43:29 +00:00
f02f4ac762
Comments: in `WP_Comment_Query::fill_descendants()`, compute `count()` in the first `for` expression so that it does not run on each iteration.
...
Props vishalkakadiya, deremohan.
Fixes #37416 .
Built from https://develop.svn.wordpress.org/trunk@38297
git-svn-id: http://core.svn.wordpress.org/trunk@38238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-21 06:25:29 +00:00
b8bfcb0d64
Media: use `wp_get_attachment_metadata()` instead of `get_post_meta()` where appropriate.
...
Adds unit test.
Props JorritSchippers.
Fixes #36246 .
Built from https://develop.svn.wordpress.org/trunk@38296
git-svn-id: http://core.svn.wordpress.org/trunk@38237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-21 06:15:30 +00:00
76540c6010
Media: `wp_get_attachment_link()` fails to output text for non-images if the attachment post doesn't have a title and `$text` (argument #5 ) was not passed to the func. In this case, use the filename.
...
Props Jonnyauk, henry.wright.
Fixes #37343 .
Built from https://develop.svn.wordpress.org/trunk@38295
git-svn-id: http://core.svn.wordpress.org/trunk@38236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 23:45:28 +00:00
7ac88c02fa
Media: when calling `pathinfo()`, also pass a `PATHINFO_*` constant to avoid array notices for unset keys.
...
Props JaworskiMatt.
Fixes #37608 .
Built from https://develop.svn.wordpress.org/trunk@38294
git-svn-id: http://core.svn.wordpress.org/trunk@38235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 23:36:28 +00:00
d73964aab6
Media: Add some docs to `media-gallery.js` RIP.
...
Props jipmoors.
Fixes #37717 .
Built from https://develop.svn.wordpress.org/trunk@38293
git-svn-id: http://core.svn.wordpress.org/trunk@38234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 22:59:29 +00:00
344c88d39f
Allow attachment taxonomies to be fetched as objects.
...
By adding the `$output` parameter to `get_attachment_taxonomies()`, the
function signature matches that of `get_object_taxonomies()`. The change
also allows for more consistent behavior when passing `output=objects`
to `get_object_taxonomies()` for the 'attachment' object type, since
the `$output` parameter is now passed through the function stack.
Props codemovement.pk.
See #37368 .
Built from https://develop.svn.wordpress.org/trunk@38292
git-svn-id: http://core.svn.wordpress.org/trunk@38233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 17:35:31 +00:00
188c568204
Introduce tests for `get_attachment_taxonomies()`.
...
See #37368 .
Built from https://develop.svn.wordpress.org/trunk@38291
git-svn-id: http://core.svn.wordpress.org/trunk@38232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 17:25:30 +00:00
ece461fbc3
Introduce tests for `get_object_taxonomies()`.
...
See #37368 .
Built from https://develop.svn.wordpress.org/trunk@38290
git-svn-id: http://core.svn.wordpress.org/trunk@38231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 17:01:31 +00:00
597c067b67
Docs: Correct usage examples for `wpdb::prepare()`, which should not be called statically.
...
Props TJNowell.
Fixes #37744 .
Built from https://develop.svn.wordpress.org/trunk@38289
git-svn-id: http://core.svn.wordpress.org/trunk@38230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 13:17:30 +00:00
d30a6a988a
Query: Non-scalar and negative values for 'p' should always result in a 404.
...
Previously, the 'p' query var was being run through `absint()`, which
caused unexpected results.
Props Akeif, kouratoras.
Fixes #33372 .
Built from https://develop.svn.wordpress.org/trunk@38288
git-svn-id: http://core.svn.wordpress.org/trunk@38229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 02:32:30 +00:00
54fe38c7cc
Mail: Don't set Sender field when setting From.
...
[38058] changed `wp_mail()` so that it used PHPMailer's `setFrom()`
method rather than setting the From and FromName headers directly. See
behavior of setting the `Sender` field. This causes `mail` to be
called with the `-f` flag, which causes outgoing email to fail on some
server environments.
Props Clorith, iandunn, DrewAPicture.
Fixes #37736 .
Built from https://develop.svn.wordpress.org/trunk@38286
git-svn-id: http://core.svn.wordpress.org/trunk@38227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-20 02:17:38 +00:00
53ef9de125
Tests: Move some utility classes to their own files.
...
Props Frank Klein.
Fixes #37523 .
Built from https://develop.svn.wordpress.org/trunk@38285
git-svn-id: http://core.svn.wordpress.org/trunk@38226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-19 15:45:29 +00:00
83bed74a2f
Docs: Fix typo in `load_plugin_textdomain()` parameter description.
...
Props tivnet.
See #37318 .
Built from https://develop.svn.wordpress.org/trunk@38284
git-svn-id: http://core.svn.wordpress.org/trunk@38225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-19 14:29:30 +00:00
0da0aae4b0
Add wordpress-importer tests demonstrating slashed data behavior.
...
See #21007 .
Built from https://develop.svn.wordpress.org/trunk@38283
git-svn-id: http://core.svn.wordpress.org/trunk@38224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-19 13:27:30 +00:00
a138374ec8
Bootstrap/Load: Include Plugin API via `require_once`
...
Currently, auto-prepended files need to directly modify the globals in order to add filters and actions. This is a bad idea. Globals are bad. You should never directly interact with the Plugin globals.
Fixes #37707 .
Built from https://develop.svn.wordpress.org/trunk@38282
git-svn-id: http://core.svn.wordpress.org/trunk@38223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-19 04:10:30 +00:00
18f14ad752
Fix jshint of Gruntfile.js
...
Introduced in [38276]
See #37720 .
Built from https://develop.svn.wordpress.org/trunk@38281
git-svn-id: http://core.svn.wordpress.org/trunk@38222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 20:05:30 +00:00
3357ca23e6
Query: use composition for `$db` in `WP_Date_Query`, removes need to import `global $wpdb` in multiple methods.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38280
git-svn-id: http://core.svn.wordpress.org/trunk@38221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 19:48:34 +00:00
9b393cea42
Query: use composition for `$db` in `WP_Query`, removes need to import `global $wpdb` in multiple methods.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38279
git-svn-id: http://core.svn.wordpress.org/trunk@38220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 19:39:29 +00:00
c606046d73
Unit Tests: skip checking the value in `Tests_User:test_user_properties` for `db`. Casting to `array` is not the most elegant thing here, and various versions of PHP key protected/private fields differently when objects are cast.
...
See [38275], #37699 .
Built from https://develop.svn.wordpress.org/trunk@38278
git-svn-id: http://core.svn.wordpress.org/trunk@38219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 19:38:29 +00:00
2b7d7f4833
In `is_object_in_term()`, return error object rather than caching it.
...
This change prevents an error object from being stored in the cache,
and prevents notices from being thrown when plucking term IDs to put
into the relationship cache.
See #32044 , #36814 .
Props rpayne7264.
Fixes #37721 .
Built from https://develop.svn.wordpress.org/trunk@38277
git-svn-id: http://core.svn.wordpress.org/trunk@38218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 19:15:32 +00:00
6836de32d1
External Libraries: Update Minified version of jquery.masonry.js
...
WordPress maintains the minified version of jquery.masonry.js since there is no official build, however it has been excluded from grunt's minification process. This adds a minification task to grunt, adds it to the precommit hook for JS, minifies the file, and bumps the version on jquery.masonry.min.js. The change to the non minified version was introduced in [38261].
Fixes #37720 . See #37666 .
Built from https://develop.svn.wordpress.org/trunk@38276
git-svn-id: http://core.svn.wordpress.org/trunk@38217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 18:55:30 +00:00
e7ffad7fac
Query: add a `protected` field, `$db`, (composition, as it were) to `WP_*_Query` classes to hold the value for the database abstraction, instead of importing the `global $wpdb` into every method that uses it. Reduces the number of global imports by 32.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38275
git-svn-id: http://core.svn.wordpress.org/trunk@38216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 18:21:31 +00:00
1dd3ed4bd5
Requests: Update to Requests master (fb5b517) which corrects a logic inversion in the cURL transport checks.
...
Previously if a host had only disabled one of `curl_init()` or `curl_exec()` it wouldn't get detected correctly by Requests, which caused cURL warnings for users on an affecte dhost.
Fixes #37700 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38274
git-svn-id: http://core.svn.wordpress.org/trunk@38215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 03:48:31 +00:00
2bd32687b3
Build/Test Tools: Ensure PHP 7.1 is tested on Travis.
...
PHP 7.1 is the next version of PHP and WordPress should support it with the first major version after 7.1 launches. This will facilitate testing. Failures on 7.1 won't necessitate builds failing while 7.1 is still in beta.
Fixes #37625 .
Built from https://develop.svn.wordpress.org/trunk@38273
git-svn-id: http://core.svn.wordpress.org/trunk@38214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-17 20:47:30 +00:00
594b88661a
Permalinks: Correct the documentation for the `get_sample_permalink` filter, and improve the documentation for the `get_sample_permalink()` function.
...
Props sebastian.pisula for the original patch
Fixes #37682
Built from https://develop.svn.wordpress.org/trunk@38272
git-svn-id: http://core.svn.wordpress.org/trunk@38213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-17 18:30:30 +00:00
14cbd0e730
About Page: Add release video and move images to CDN.
...
Props jerrysarcastic, rosso99, petya, hugobaeta, jerrysarcastic.
See #37246 .
Built from https://develop.svn.wordpress.org/trunk@38267
git-svn-id: http://core.svn.wordpress.org/trunk@38208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-16 17:58:30 +00:00
75d4429926
Post Thumbnails: Restore thumbnail support for media files.
...
* Allow to add/remove a featured image to `attachment:audio` and `attachment:video` post types, see [27657].
* Change conditionals to check for theme OR post type support.
* Add tests for #12922 .
Broken in [37658].
Props flixos90, joemcgill, DrewAPicture, wonderboymusic.
See #12922 .
Fixes #37658 .
Built from https://develop.svn.wordpress.org/trunk@38263
git-svn-id: http://core.svn.wordpress.org/trunk@38204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-15 19:16:31 +00:00
9c526c8a24
External Libraries: Update Masonry shim to prevent error using isAnimated option
...
The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].
Reported upstream: https://github.com/desandro/masonry-v2-3-shim/pull/1
Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666 , #32802 .
Built from https://develop.svn.wordpress.org/trunk@38261
git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-15 18:20:30 +00:00
2ccd9b46dd
About Page: Enhance responsive images.
...
* Add `srcset` and `sizes` to the mobile image for streamlined updates.
* Modify the order of image candidate strings in each `srcset` to address a bug in iOS8 where the first candidate will always be selected when using `w` descriptors, see #35030 .
Props joemcgill.
Fixes #37246 .
Built from https://develop.svn.wordpress.org/trunk@38257
git-svn-id: http://core.svn.wordpress.org/trunk@38198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-13 19:28:29 +00:00
25338b6f02
Script Loader: Fix protocol-relative URLs for the `preconnect` relation type.
...
`wp_resource_hints()` parses the URL for the `preconnect` and `dns-prefetch` relation types to ensure correct values for both. While protocol-relative URLs are supported for `dns-prefetch`, the double slash was lost for `preconnect`.
Props swissspidy, peterwilsoncc.
Props azaozz for review.
Fixes #37652 .
Built from https://develop.svn.wordpress.org/trunk@38255
git-svn-id: http://core.svn.wordpress.org/trunk@38196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-13 18:35:30 +00:00
1691196110
Docs: Add a period missed in an argument description in [38253] for #36338 .
...
Built from https://develop.svn.wordpress.org/trunk@38254
git-svn-id: http://core.svn.wordpress.org/trunk@38195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-13 17:44:28 +00:00
51810b926a
Docs: Add documentation for all arguments accepted by `export_wp()`.
...
Props theMikeD for the initial patch.
Fixes #36338 .
Built from https://develop.svn.wordpress.org/trunk@38253
git-svn-id: http://core.svn.wordpress.org/trunk@38194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-13 17:43:28 +00:00
7e14c27bb9
Bootstrap/Load: Revert Plugin Global restoration around `advance-cache.php`.
...
First added in [37588] and later modified in [38224], the idea was to ensure that filters/actions added before `advance-cache.php` would not disappear if `advance-cache.php` overloaded the filters/actions with code such as `$wp_filter = array()`. This is an edge case and one that there is no documented case of existing.
This restores the behavior from WordPress 4.5 and before. It is strongly encouraged that developers using `advance-cache.php` to use the Plugins API that is available before the loading of `advance-cache.php` rather than directly interacting with any of the globals.
Props azaozz, jorbin, dd32 for review, pento for review, westi for investigation, ipstenu for research.
See #36819 .
Built from https://develop.svn.wordpress.org/trunk@38251
git-svn-id: http://core.svn.wordpress.org/trunk@38192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-13 16:00:33 +00:00
Scott Taylor
Drew Jaynes
Sergey Biryukov
Weston Ruter
Boone Gorges
Aaron Jorbin
Dion Hulse
John Blackbourn
Dominik Schilling