Commit Graph

17072 Commits

Author SHA1 Message Date
desrosj 15db443250 PHP 7.3 Compatibility: Fix compact related notices.
In PHP 7.3, the `compact()` function has been changed to issue an `E_NOTICE` level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: https://wiki.php.net/rfc/compact.

See #44416.
Fixes #45483.
Built from https://develop.svn.wordpress.org/branches/5.0@44185


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-15 11:01:25 +00:00
Jeremy Felt ccfd64c423 Bump 5.0 branch to version 5.0.1.
Built from https://develop.svn.wordpress.org/branches/5.0@44077


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-13 02:11:45 +00:00
Peter Wilson 1f5919e631 Multisite: Validate activation links.
Merges [44048] to the 5.0 branch.

Built from https://develop.svn.wordpress.org/branches/5.0@44050


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-13 01:30:45 +00:00
Gary Pendergast 8d463ab37f Editor: Remove unwanted fields before saving posts.
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.


Built from https://develop.svn.wordpress.org/branches/5.0@44047


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-13 01:25:47 +00:00
Mel Choyce f8c6849fb4 Help/About: Upload videos to CDN and remove autoplay/loop.
Props skithund, afercia, lonelyvegan.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43969


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-06 02:51:45 +00:00
Gary Pendergast 1b4fb4f9f0 About: Move images to the CDN, and use `<picture>`.
Ensures the correct assets are used for the device loading the page.

Props joemcgill.
See #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43968


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-05 22:25:47 +00:00
Gary Pendergast ebd29f6fb9 About: Add ℹ️ to the classic editor link, to make it stand out a little more.
Props melchoyce.
See #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43967


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-04 23:04:45 +00:00
mcsf 73b656936c Update `sidebars_widgets` to match Twenty Nineteen's single widget area
* Also update the customizer tests to match it.

Props SergeyBiryukov, pento.


Built from https://develop.svn.wordpress.org/branches/5.0@43954


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-30 20:25:46 +00:00
Mel Choyce fa65b25ac7 Help/About: Update "Support for the Classic Editor plugin will remain in WordPress until 2021" to "through 2021" to further clarify timeline.
Props kjellr.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43953


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-30 16:27:47 +00:00
Mel Choyce 34e52b90e9 Help/About: Fix the user's saved WordPress.org username from being changed to wordpressdotorg when they click the About page link to install the Classic Editor plugin.
Props pento.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43952


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-30 16:23:46 +00:00
youknowriad 3dd6578998 Block Editor: Update @wordpress package dependencies.
Update packages:

 - @wordpress/block-library@2.2.8
 - @wordpress/components@7.0.3
 - @wordpress/edit-post@3.1.3
 - @wordpress/editor@9.0.3
 - @wordpress/format-library@1.2.6
 - @wordpress/list-reusable-blocks@1.1.16
 - @wordpress/nux@3.0.4

Other changes:

Fix a translator comment in edit-form-blocks.php.
Rename the gutenberg_ functions in blocks/latest-comments.php.

Props pento.
Fixes #45145.

Built from https://develop.svn.wordpress.org/branches/5.0@43949


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-30 09:59:52 +00:00
Andrew Ozz 98b042e189 Help/About: Do not show the "Keep it Classic" section and the link to it at the top when the Classic Editor plugin is already installed.
See #45178.
Built from https://develop.svn.wordpress.org/branches/5.0@43947


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-29 08:30:46 +00:00
Mel Choyce 625cae3537 Help/About: Minor updates.
- Updated the various images.
- Added new "developer happiness" images.
- Fixed the responsive figcaption styles.
- Added a link to wporg plugin favorites as a shortcode to get to the classic plugin.
- Renamed "cover image" to "cover."
- Updated CSS to account for small-screen issues.

Props desrosj, audrasjb, antpb, jjj, elrae, Otto42, afercia, karmatosed, kjellr, alexislloyd, melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43946


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-28 17:31:47 +00:00
Gary Pendergast 07ebb6262c Block Editor: Clarify a translator comment in meta box handling.
Props ocean90.
See #45217.


Built from https://develop.svn.wordpress.org/branches/5.0@43945


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-27 06:39:48 +00:00
youknowriad 91c4d2295b Block Editor: Fix the WordPress packages and vendor script registration.
The version is set properly and the scripts are automatically loaded in the footer.
This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy.
Fixes #45402.
See #45396.

Built from https://develop.svn.wordpress.org/branches/5.0@43942


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 08:35:45 +00:00
Gary Pendergast be60664fe1 Block Editor: Add a placeholder for meta boxes that don't work in the block editor.
If a meta box is registered with the `__block_editor_compatible_meta_box` set to `false`, it's indicating that it doesn't work in the block editor. If that's the case, we can add a place holder to inform the user that they'll need to use the classic interface to work with this meta box.

Props pento, jorgefilipecosta, peterwilsoncc, karmatosed, noisysocks, dd32.
See #45217.


Built from https://develop.svn.wordpress.org/branches/5.0@43941


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 08:15:46 +00:00
youknowriad 97e84f8a03 Block Editor: Refresh nonces used by wp.apiFetch.
Adds heartbeat nonces refreshing support to wp.apiFetch requests.

Props pento, adamsilverstein, dd32, desrosj.
Fixes #45113. 

Built from https://develop.svn.wordpress.org/branches/5.0@43939


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 19:40:46 +00:00
gziolo a69e8cf788 About: Update Freedoms page to include illustrations.
@cathibosco has made some great illustrations of the Four Freedoms on https://wordpress.org/about/. Let's bring that over to the admin Freedoms page.

Props @melchoyce, @cathibosco, @boemedia, @karmatosed, @tobifjellner, @helen, @matveb, @mcsf.
Fixes #45386.


Built from https://develop.svn.wordpress.org/branches/5.0@43938


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 18:03:45 +00:00
lonelyvegan eaaa8c7dc6 Help/About: Add copy for new block editor.
Adds information about the new block editor (Gutenberg) and the Classic Editor
to the about page.

Props @pixelverbieger, @ocean90, @melchoyce, @boemedia, @sami.keijonen, @TimothyBlynJacobs, @xkon, @afercia, @Otto42, @pento.
Fixes #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43937


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 15:24:45 +00:00
youknowriad db6ae8a9be Block Editor: Fix loading the script handling the "Manage Reusable Blocks" page.
This ensures the "import from JSON" and "export JSON" buttons are shown properly.
The script is loaded in the footer because it relies on the DOM being already there.

Props noisysocks, mukesh27.
Fixes #45396.

Built from https://develop.svn.wordpress.org/branches/5.0@43936


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 07:25:45 +00:00
youknowriad 3ab0f22ec6 Block Editor: Fix PHP warning showing up when loading editor styles while in RTL.
In RTL languages, WordPress adds style-editor-rtl.css editor styles to the global $editor_styles
This patch ignores handling these styles if the file is not preset.

Props desrosj, mostafa.s1990.
Fixes #45288.

Built from https://develop.svn.wordpress.org/branches/5.0@43923


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 19:30:48 +00:00
Mel Choyce cec4083b46 About Page: Update images and de-italicize a11y note.
Props @matveb, @kjellr, @Alexis Lloyd, @courtney0burton, @melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43922


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 17:00:48 +00:00
mcsf 0d5fd392e8 Warn users of Gutenberg plugin of its deactivation upon 5.0 upgrade.
Fixes #45073.


Built from https://develop.svn.wordpress.org/branches/5.0@43921


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 16:35:48 +00:00
mcsf ba1c444bf3 Block Editor: Show privacy help notice on Privacy Policy page.
When editing a page set to be the Privacy Policy page, display a help notice
containing a link to the Privacy Policy guide.

This changeset ports this functionality to the new Block Editor.

Props desrosj.
Fixes #45057.


Built from https://develop.svn.wordpress.org/branches/5.0@43920


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 16:18:49 +00:00
danielbachhuber 0fb5da94e6 Block Editor: Update @WordPress dependencies to match Gutenberg 4.5.1.
Updates packages: annotations,
api-fetch,
block-library,
blocks,
components,
core-data,
data,
dom, edit-post,
editor,
format-library,
jest-console,
jest-preset-default,
keycodes,
html-entities,
list-reusable-blocks,
notices,
nux,
rich-text,
scripts,
token-list, url,
viewport

Fixes undefined notices in some blocks. Removes incorrect `'gutenberg'` textdomain too.

See #45145

Built from https://develop.svn.wordpress.org/branches/5.0@43919


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 15:09:57 +00:00
danielbachhuber c06c2fe2d6 Block Editor: Expose value of `user_can_richedit()`.
In order for the Block Editor to know whether to allow visual editing, it needs to know the value of `user_can_richedit()`.

Props youknowriad.
Fixes #45375.

Built from https://develop.svn.wordpress.org/branches/5.0@43916


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 14:11:48 +00:00
Mel Choyce 110a98f5e7 About Page: Initial About Page design and strings for 5.0.
Props @pixelverbieger, @ocean90, @karmatosed, @pento, @boemedia, @lonelyvegan, @sami.keijonen, @TimothyBlynJacobs, @xkon, @afercia, @laurelfulford, @joostdevalk, @ipstenu, @matveb, @joen, @tinkerbelly, @chanthaboune, @kjellr, @alexislloyd, @melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43913


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 02:39:49 +00:00
Gary Pendergast aea8dfd090 Upgrade/Install: Split `Sample Page`, `Hello World`, and `Privacy Policy` content.
[43820] converted the content to blocks, but included block markers in the translateable strings, which made translations difficult to do accurately.

Props desrosj, dd32, ocean90.
See #45151.


Built from https://develop.svn.wordpress.org/branches/5.0@43912


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 01:48:49 +00:00
Gary Pendergast 5ad2582000 Block Editor: Load TinyMCE inline scripts later.
Previously, the TinyMCE inline scripts were added on the `init` action in the block editor. In the classic editor, however, these scripts are loaded when the TinyMCE window is printed, and some plugins rely on them being loaded later, so they can attach to the appropriate filters.

See #45338.


Built from https://develop.svn.wordpress.org/branches/5.0@43901


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-15 23:53:49 +00:00
Gary Pendergast e39fe11309 Docs: Future-proof comments referencing 5.0 TODOs.
Some Customizer-related files contain inline comments referencing work to do for #42364 for 5.0. Those comments are now outdated as #42364 was moved to the 5.1 milestone.

Props dlh.
See #45115.


Built from https://develop.svn.wordpress.org/branches/5.0@43887


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 04:23:48 +00:00
Gary Pendergast 8f8f3bb91d Block Editor: Hide the Custom Fields meta box option if that meta box has been removed.
Some plugins remove the Custom Fields meta box, particularly when they provide functionality that replaces it. The block editor would correctly not display this meta box in these circumstances, but it still showed the option to display or hide it.

Props pento, noisysocks.
See #45282.



Built from https://develop.svn.wordpress.org/branches/5.0@43885


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 03:38:50 +00:00
Gary Pendergast 54368e50b6 Block Editor: Update `@wordpress` dependencies to the latest version.
Changes of note:
- Includes the new Annotations API package.
- `wp-polyfill-ecmascript.js` is renamed to `wp-polyfill.js`.
- `strip_dynamic_blocks()` has been removed in favour of `excerpt_remove_blocks()`.
- The PHP block parser is now syncing from the `block-serialization-default-parser` package.
- `do_blocks()` uses the new parser.
- The `do_block` filter has been removed from `do_blocks()`, in favour of a `render_block` filter in `render_block()`.

See #45145, #45190, #45264, #45282.


Built from https://develop.svn.wordpress.org/branches/5.0@43884


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 02:27:57 +00:00
Gary Pendergast fdf428e44f Tests: Fix tests broken in PHP 5.x after [43879].
See #45290.


Built from https://develop.svn.wordpress.org/branches/5.0@43883


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 09:44:49 +00:00
Gary Pendergast cd22d51724 Meta Boxes: Add the `block_editor_meta_box_hidden_fields` action.
Lacking an appropriate action in the classic editor, plugins that add meta boxes have historically hooked into various actions in order to add hidden input fields.

This change also adds backwards compatibility for two of the most common: `edit_form_after_title`, and `edit_form_advanced`.

Props pento, danielbachhuber.
See #45283.


Built from https://develop.svn.wordpress.org/branches/5.0@43882


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 09:06:47 +00:00
Gary Pendergast 98e9bbdc19 Block Editor: Prevent the meta box form from being accidentally submitted.
Meta boxes are loaded inside a wrapper form, that the block editor submits as part of the saving process. It shouldn't be submitted manually.

See #45284.

Built from https://develop.svn.wordpress.org/branches/5.0@43880


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 08:33:46 +00:00
herregroen c22a63ec3a I18N: Set translations for all WordPress packages scripts.
Calls `wp_set_script_translations` for all packages scripts that have translations. Also correctly sets the domain on the translations.

Props omarreiss, pento, ocean90.
Fixes #45161.

Built from https://develop.svn.wordpress.org/branches/5.0@43878


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-08 11:34:48 +00:00
Dominik Schilling 3d6cb1b458 Script Loader: Ensure default packages are registered when loaded via load-scripts.php.
Props CantoThemes, ocean90.
See #45271.
Built from https://develop.svn.wordpress.org/branches/5.0@43877


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-08 09:24:51 +00:00
Gary Pendergast a46a68ad7f Meta Boxes: Add curly brackets missed in [43861].
This was causing the custom meta box to be incorrectly added to post types that don't support it.

Props ocean90, epointal.
Fixes #45257,

Built from https://develop.svn.wordpress.org/branches/5.0@43863


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-04 23:23:49 +00:00
Gary Pendergast 325cb107d1 Build Tools: Update the `@wordpress` packages.
This brings support for the custom fields meta box to the block editor.

The `webpack` and `copy-webpack-plugin` packages have also been updated.

See #45145.
Fixes #45257.


Built from https://develop.svn.wordpress.org/branches/5.0@43861


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-03 07:57:54 +00:00
Gary Pendergast e0664765b6 Editor: Cast the result of the `default_content`, `default_title`, and `default_excerpt` filters.
If a plugin returns a non-string value (or returns `null`) on these filters, it can cause errors in the block editor. Casting them as a string prevents these errors.

Props dd32.
See #45236.


Built from https://develop.svn.wordpress.org/branches/5.0@43858


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 05:20:47 +00:00
Gary Pendergast 6ad646a080 Block Editor: Remove CodeMirror settings.
CodeMirror is no longer used in the block editor, so we don't need to load the settings.

Props noisysocks.
Fixes #45248.


Built from https://develop.svn.wordpress.org/branches/5.0@43857


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 05:07:47 +00:00
Gary Pendergast d9e31a1bb9 Block Editor: Don't show back compat or incompatible meta boxes in Options.
Meta boxes that exist for back compat, or that are incompatible with the block editor aren't displayed, so they don't need an option to display or hide them in the Options dialog.

Props noisysocks.
Fixes #45249.


Built from https://develop.svn.wordpress.org/branches/5.0@43856


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 04:33:46 +00:00
Gary Pendergast 049d3a6db8 Posts: Remove the slug from Quick Edit for posts that are not `is_post_type_viewable()`.
This is a followup to [43728], which added the same check, but using the `publicly_queryable` option. This behaviour is incorrect for `_builtin` post types, which go by the logic in `is_post_type_viewable()`, instead.

See #43278.

Built from https://develop.svn.wordpress.org/branches/5.0@43855


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:35:46 +00:00
Gary Pendergast eb4031a209 Blocks: Add "Export as JSON" action to the `wp_block` post list screen.
Remove the "Quick Edit" for `wp_block`s, too, as they don't need any of that functionality.

Props noisysocks.
Fixes #45247.


Built from https://develop.svn.wordpress.org/branches/5.0@43854


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:25:47 +00:00
danielbachhuber b277797add Blocks: Include necessary labels for the 'wp_block' post type.
See #45098

Built from https://develop.svn.wordpress.org/branches/5.0@43849


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:16:44 +00:00
Gary Pendergast 1fb36474cb FTP/PemFTP Library: Fix some PHP notices.
- `ftp_base::glob()` used `each()`, which is deprecated as of PHP 7.2.
- `ftp_base::fget()` was missing the decleration of its third parameter, `$rest`.

Props itowhid06.
See #44489.


Built from https://develop.svn.wordpress.org/branches/5.0@43848


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:15:54 +00:00
Gary Pendergast ebb5e6dd0d Build Tools: Upgrade `@wordpress` packages to the latest version.
This also includes the new `@wordpress/format-library` and `@wordpress/notices` packages.

`package-lock.json` has been completely regenerated in this commit.

See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43840


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:36:36 +00:00
Gary Pendergast f2e3a6c1ac Meta boxes: Don't show the block editor incompatiblity message when it doesn't apply.
We should only be showing this message in the classic editor interface, for meta boxes that are marked as being incompatible with the block editor.

Fixes #45207.


Built from https://develop.svn.wordpress.org/branches/5.0@43839


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:31:06 +00:00
Gary Pendergast 3549683ca3 Meta boxes: Don't assume that callback args are an array.
While the documentation for `add_meta_box()` specifices that `$callback_args` should be an array, this has never been enforced, and we have workarounds in place for when it's passed as something other than an array.

Rather than break sites that are passing unexpected data, we can quietly just allow for it, instead.

Props johnjamesjacoby, birgire.
Fixes #45206.


Built from https://develop.svn.wordpress.org/branches/5.0@43838


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:30:14 +00:00
Gary Pendergast 742913ca97 Block Editor: Fix meta boxes not showing.
The block editor needs to duplicate the classic meta box behaviour, so it can extract the registered meta boxes, and import them into the block editor.

To match the classic editor behaviour as closely as possible, this moves the relevant code from the classic editor, into a new function, so it can be called by both.

Props pento, peterwilsoncc.
Fixes #45172.


Built from https://develop.svn.wordpress.org/branches/5.0@43837


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 08:29:23 +00:00