danielbachhuber
eea6942164
Block Editor: Preload `wp/v2/media` with OPTIONS for caps check.
...
Also introduces a `block_editor_preload_paths` filter for plugins and themes to preload additional data.
Props imath, mattheu.
Fixes #45194 .
Built from https://develop.svn.wordpress.org/branches/5.0@43833
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-29 00:25:38 +00:00
Gary Pendergast
0c54153886
Meta Boxes: Fix error when a meta box is rendered with a static method callback.
...
When `WP_DEBUG` is set, ensure that a static method callback is passed to `ReflectionMethod`, instead of `ReflectionFunction`.
Props DrewAPicture.
Fixes #45192 .
Built from https://develop.svn.wordpress.org/branches/5.0@43830
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 08:12:39 +00:00
Drew Jaynes
2f515c6db0
Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions.
...
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.
Notations have been added for the following functions:
* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()
Merges [42710] to the 5.0 branch.
Props janalwin.
Fixes #43254 .
Built from https://develop.svn.wordpress.org/branches/5.0@43827
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-26 07:38:26 +00:00
Sergey Biryukov
bbd58a5c35
Upgrade/Install: Convert `Sample Page`, `Hello World`, and `Privacy Policy` to block content.
...
Props desrosj, garrett-eclipse, danielbachhuber.
Fixes #45151 .
Built from https://develop.svn.wordpress.org/branches/5.0@43820
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-24 18:51:51 +00:00
Gary Pendergast
0b98b31c1f
Block Editor: Remove some errant debugging included in [43815].
...
Props bordoni.
See #45037 .
Built from https://develop.svn.wordpress.org/branches/5.0@43816
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-24 09:00:39 +00:00
Gary Pendergast
dde5487499
Editor: Minor bug fixes.
...
Change the default layout slightly, and tweak the HTML stored in `post_content`.
Props matveb, karmatosed, joen, youknowriad, aduth, iseulde, pento, EphoxJames, mkaz, jnylen0, notnownikki, lonelyvegan, chopinbach, njpanderson, mimo84, intronic, westonruter, mcsf, dmsnell, afercia, paulwilde, mitogh, codebykat, mrahmadawais, kopepasah, circlecube, adamsilverstein, timmydcrawford, ephox-mogran, nbachiyski, JDGrimes, laurelfulford, Soean, mapk, sirjonathan, j-falk, ryelle, helen, netweb, lamosty, willybahuaud, maurobringolf, jorbin, spocke, androb, annaharrison, Afraithe, georgeh, matt, melchoyce, nitrajka, sirreal, babbardel, arush, martinlugton, iandunn, oyously, rileybrook, azaozz, folletto, ianstewart, johnpixle, clorith, joedolson, ipstenu, mrwweb, diegoliv, jeffpaul, lukecavanagh, shaunandrews, hugobaeta, jjj, mizejewski, buzztone, jdembowski, webdevmattcrom, GaryJones, jasonagnew, dd32, ieatwebsites, gma992, swissspidy, dixitadusara, ameeker, stagger-lee, jblz, nicbertino, rahmohn, vladanost, gziolo, lancewillett, lynneux, betsela, fuyuko, msdesign21, thrijith, chanthaboune, Cloud887, hblackett, vishalkakadiya, c-shultz, nfmohit, noisysocks, omarreiss, hedgefield, hideokamoto, mirucon, nosolosw, DannyCooper, burhandodhy, zebulan, benjamin_zekavica, danielbachhuber, jorgefilipecosta, ajitbohra, bph, ChrisVanPatten, dixitadusara, antpb, mikehaydon, jahvi, floriansimeth, Mathiu, amedina, diegoreymendez, etoledom, caxco93, yoavf, welcher, bobbingwide, jonsurrell, notlaura, ocean90, eliorivero, wpscholar, Shelob9, travislopes, earnjam, designsimply, johnwatkins0, dfangstrom, igorsch, jaswrks, daniloercoli, rianrietveld, dimadin, SergioEstevao, dlocc, tinkerbelly, schlessera, sumobi, kjellr, ireneyoast, hypest, tfrommen, intronic, johnny5, samikeijonen, bpayton, atimmer, Rahmon, tg-ephox, nerrad, talldan, Xyfi.
See #45037 .
Built from https://develop.svn.wordpress.org/branches/5.0@43815
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-24 06:46:40 +00:00
danielbachhuber
7e3414597f
Meta: Allow empty strings to be set by Custom Fields meta box.
...
Because the REST API allows meta keys to have empty values, the Custom Fields meta box should permit the same behavior.
Props charlestonsw, soulseekah.
Fixes #43559 .
Built from https://develop.svn.wordpress.org/branches/5.0@43811
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-23 18:56:38 +00:00
Aaron Jorbin
634bb165bc
Bundled Theme: Make twentynineteen the default theme.
...
After [43808], we can now make twentynineteen the default theme. Twentyseventeen has been a great default, but 5.0 and twentynineteen is guten.
Fixes #45152 .
Built from https://develop.svn.wordpress.org/branches/5.0@43809
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-23 16:51:39 +00:00
Gary Pendergast
46e270096b
Dashboard: Remove the Try Gutenberg callout.
...
Block or block not. There is no try.
Props mukesh27.
See #45063 .
Built from https://develop.svn.wordpress.org/branches/5.0@43807
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-23 11:04:40 +00:00
Gary Pendergast
c60c870ab8
Blocks: Add the reusable block post type, `wp_block`.
...
See #45098 .
Built from https://develop.svn.wordpress.org/branches/5.0@43804
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-23 06:53:38 +00:00
Dominik Schilling
957a6af144
Meta Boxes: Sync checks for valid meta boxes from `do_meta_boxes()` to `the_block_editor_meta_boxes()`.
...
See #45112 .
Built from https://develop.svn.wordpress.org/branches/5.0@43792
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-23 06:08:59 +00:00
Gary Pendergast
38aa44817f
Build: Update images following [43684].
...
`grunt-contrib-imagemin` was updated, which included some changes to image minification. Those changes are now applies.
Props netweb.
See #45080 .
Built from https://develop.svn.wordpress.org/branches/5.0@43785
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-22 05:06:38 +00:00
Gary Pendergast
ce66f73e68
Build: Updated CSS vendor prefixes following [43684].
...
`autoprefixer` was updated, which included some vendor prefix changes. Those changes are now applied.
Props netweb.
See #45080 .
Built from https://develop.svn.wordpress.org/branches/5.0@43784
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-22 05:04:40 +00:00
Gary Pendergast
433dfae509
Block Editor: Add extra body classes when the block editor is loaded.
...
See #45037 .
Built from https://develop.svn.wordpress.org/branches/5.0@43780
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-22 03:14:40 +00:00
Gary Pendergast
6800a811b6
Meta Boxes: Add `__back_compat_meta_box` and `__block_editor_compatible_meta_box` flags to meta boxes.
...
When meta boxes are registered, they can use the `__back_compat_meta_box` and `__block_editor_compatible_meta_box` flags, to show whether this registration just exists for if the classic editor is loaded, and whether this meta box is compatible with the block editor.
When a meta box marks itself as incompatible with the block editor, and `WP_DEBUG` is enabled, a warning will show inside that meta box in the classic editor.
As all core meta boxes have been recreated in the block editor, they can be marked with the `__back_compat_meta_box` flag.
See #45112 .
Built from https://develop.svn.wordpress.org/branches/5.0@43779
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-22 02:32:41 +00:00
Gary Pendergast
acda70184d
Block Editor: Add helper functions to collect meta box information.
...
To allow the block editor to render meta boxes, it needs to collect information about how those meta boxes are registered, and format it for the block editor to make use of.
See #45112 .
Built from https://develop.svn.wordpress.org/branches/5.0@43778
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-22 02:16:39 +00:00
Gary Pendergast
e0361726c2
Block Editor: Add an `is_block_editor()` method to `WP_Screen`.
...
This method allows checking (or setting) whether the block editor is loading on the current screen.
See #45037 .
Built from https://develop.svn.wordpress.org/branches/5.0@43777
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-22 02:06:40 +00:00
danielbachhuber
5a627786bf
Help/About: Ensure the space after the period for the 4.9.8 changelog entry is preserved.
...
Props chetan200891, burhandodhy, swissspidy.
Merges [43622] to the 5.0 branch.
See #44717 .
Built from https://develop.svn.wordpress.org/branches/5.0@43772
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-19 18:41:40 +00:00
mcsf
326cd6af15
Deactivate Gutenberg plugin on update to 5.0.
...
Fixes #45123 .
Built from https://develop.svn.wordpress.org/branches/5.0@43765
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-19 10:51:39 +00:00
Gary Pendergast
93343de1bd
i18n: Remove some translation domains accidentally included in [43762].
...
See #45110 .
Built from https://develop.svn.wordpress.org/branches/5.0@43764
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-19 09:12:38 +00:00
Gary Pendergast
de323bc14c
Block Editor: Add helper functions for displaying the editor.
...
`use_block_editor_for_post()` and `use_block_editor_for_post_type()` determine if the block editor should be loaded.
`get_block_categories()` and `get_block_editor_server_block_settings()` provide data be included while the block editor is loading.
See #45110 .
Built from https://develop.svn.wordpress.org/branches/5.0@43762
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-19 08:44:41 +00:00
Sergey Biryukov
591a09dea0
Media: Pass EXIF data to the `wp_read_image_metadata` filter.
...
Props desrosj.
Merges [42879] to the 5.0 branch.
Fixes #43624 .
Built from https://develop.svn.wordpress.org/branches/5.0@43750
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-18 04:15:26 +00:00
Sergey Biryukov
b6e0d06fff
Media: In `wp_read_image_metadata()`, rename `$sourceImageType` variable to `$image_type` to match coding standards.
...
Merges [42878] to the 5.0 branch.
See #43624 .
Built from https://develop.svn.wordpress.org/branches/5.0@43749
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-18 04:14:25 +00:00
Sergey Biryukov
38235a183e
Media: Remove checkered background for icons in Attachment Details.
...
Props BandonRandon.
Merges [42642] to the 5.0 branch.
Fixes #42535 . See #41948 .
Built from https://develop.svn.wordpress.org/branches/5.0@43745
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-18 03:11:26 +00:00
Gary Pendergast
392f33495f
Posts: Remove the slug from Quick Edit for CPTs with `publicly_queryable` disabled.
...
In the full edit screen, CPTs that have disabled the `publicly_queryable` option will hide the slug field, as it doesn't need to be edited. This change brings the Quick Edit view into line with that behaviour.
Merges [43664] to the 5.0 branch.
Props bhargavmehta, krutidugade.
Fixes #43278 .
Built from https://develop.svn.wordpress.org/branches/5.0@43728
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-15 05:35:25 +00:00
Sergey Biryukov
37dcf205e6
Docs: Correct `@since` value for `_wp_privacy_statuses()`.
...
Fix typo in `@since` entry for `WP_Privacy_Policy_Content:add()`.
Props dimadin.
Merges [43638] to the 5.0 branch.
Fixes #44915 .
Built from https://develop.svn.wordpress.org/branches/5.0@43710
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-11 04:32:22 +00:00
Sergey Biryukov
f9ba011f33
Docs: Correct parameter type for `WP_Privacy_Policy_Content::notice()`.
...
Props burhandodhy.
Merges [43609] to the 5.0 branch.
Fixes #44877 .
Built from https://develop.svn.wordpress.org/branches/5.0@43709
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-11 04:31:23 +00:00
Sergey Biryukov
7860cb4a83
Customize: Increase the colour contrast of the line numbers in CodeMirror.
...
Props earnjam, abdullahramzan, audrasjb, Luminus.
Merges [43574] to the 5.0 branch.
Fixes #44763 .
Built from https://develop.svn.wordpress.org/branches/5.0@43700
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-11 03:42:22 +00:00
Sergey Biryukov
15d1c6398c
Script loader: remove (PHP based) compression from `load-styles.php` and `load-scripts.php`. WIth the amount of scripts and stylesheets grown a lot over the years, it has become pretty slow and consumes a lot of server resources. Also, most servers are set to compress PHP output anyway.
...
Props LucasRolff, azaozz.
Merges [43580] to the 5.0 branch.
Fixes #44815 . See #43308 .
Built from https://develop.svn.wordpress.org/branches/5.0@43697
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-11 03:23:22 +00:00
Aaron Jorbin
dda1111bdf
Build/Test Tools: Revert grunt-contrib-uglify update
...
Follow up to [43684].
See #45064 .
Built from https://develop.svn.wordpress.org/branches/5.0@43686
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-10 04:11:25 +00:00
Aaron Jorbin
a870c7e8f3
Build/Test: Update dependencies for 5.0
...
Updates package dependencies to more modern versions, also adds .nvmrc and package-lock.json as followups to [43683] and [43571].
See #44600 .
Fixes #45064 .
Built from https://develop.svn.wordpress.org/branches/5.0@43684
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-09 02:52:45 +00:00
Dominik Schilling
4ae8f8d4e6
Bump 4.9 branch to version 4.9.8.
...
Built from https://develop.svn.wordpress.org/branches/4.9@43552
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-02 20:13:24 +00:00
Aaron Jorbin
9f6f75bd8b
Gutenberg: Restrict "Try Gutenberg" based on capability and gutenstatus
...
When Gutenberg is either not installed, or not activated, only show the callout to users with the `install_plugins` capability.
When Gutenberg is activated, expand that to include all users with the `edit_posts` capability.
4.9 branch commit.
Props pento.
Fixes #44680 .
Built from https://develop.svn.wordpress.org/branches/4.9@43544
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-31 14:52:28 +00:00
Sergey Biryukov
deee543f0d
Dashboard: Tweak the "Try Gutenberg" callout:
...
* Introduce `try_gutenberg_learn_more_link` filter that allows hosts or site owners to change the link, to provide extra information about Gutenberg, specific to their service.
* Only display the "Install" buttons if we're able to directly write to disk to install the plugins.
* Make sure the "Dismiss" link works correctly.
Props pento, andrew.taylor, leemon.
Fixes #41316 .
Built from https://develop.svn.wordpress.org/branches/4.9@43537
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-26 15:06:26 +00:00
Gary Pendergast
da5f52aae3
Dashboard: Tweak the "Try Gutenberg" subheading line height.
...
Props pento, pbiron, afercia, SergeyBiryukov.
Fixes #44627 .
Built from https://develop.svn.wordpress.org/branches/4.9@43536
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-26 03:54:24 +00:00
Sergey Biryukov
e7c1553bde
Privacy: Revert [43525].
...
The commenter cookies checkbox is not legally required, so should be disabled by default.
Merges [43531] to the 4.9 branch.
Fixes #44373 .
Built from https://develop.svn.wordpress.org/branches/4.9@43532
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-24 17:08:26 +00:00
Sergey Biryukov
fa163b9c0a
I18N: Separate two "About" strings with different context.
...
Props desrosj, XpertOne, Nao.
Merges [43527] to the 4.9 branch.
Fixes #44139 .
Built from https://develop.svn.wordpress.org/branches/4.9@43528
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-24 15:06:26 +00:00
Sergey Biryukov
c0a7aaf659
Privacy: Remove the setting to enable comment cookies consent added in [43469].
...
This needs some more work to ensure expected behaviour.
Merges [43525] to the 4.9 branch.
See #44373 .
Built from https://develop.svn.wordpress.org/branches/4.9@43526
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-24 12:53:26 +00:00
Gary Pendergast
b20bfba009
Dashboard: Improve "Try Gutenberg" subheading appearance for long headings.
...
When translated, the callout subheadings can wrap onto a new line, which caused them to overlap the paragraph text.
Props earnjam, fierevere.
Fixes #44611 .
Built from https://develop.svn.wordpress.org/branches/4.9@43523
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-24 03:05:26 +00:00
Gary Pendergast
a9ea4a1f7d
Dashboard: Make some of the "Try Gutenberg" links translatable.
...
Some of the links in the "Try Gutenberg" callout go to wordpress.org, so would potentially be better served by localised site.
Props dimadin.
See #41316 .
Built from https://develop.svn.wordpress.org/branches/4.9@43522
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-24 02:52:29 +00:00
Sergey Biryukov
0dfd159712
Privacy: Improve grammar on Privacy Settings screen.
...
Props ianbelanger, garrett-eclipse.
Merges [43513] to the 4.9 branch.
Fixes #44612 .
Built from https://develop.svn.wordpress.org/branches/4.9@43514
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 20:16:26 +00:00
Sergey Biryukov
76138b9b66
Privacy: Use a consistent case for "Privacy Policy page" on Privacy Settings screen.
...
Props XpertOne, idea15, garrett-eclipse.
Merges [43508] to the 4.9 branch.
Fixes #44130 .
Built from https://develop.svn.wordpress.org/branches/4.9@43509
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 12:17:25 +00:00
Sergey Biryukov
4a6101fc53
I18N: Update list of continents and cities for the timezone selection.
...
Props soulseekah, dyrer.
Merges [43504] to the 4.9 branch.
Fixes #44574 .
Built from https://develop.svn.wordpress.org/branches/4.9@43505
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 11:27:24 +00:00
Gary Pendergast
bf820c9036
Dashboard: Introduce the "Try Gutenberg" callout.
...
To encourage folks to prepare for Gutenberg, this new Dashboard box allows site users to easily install and try the Gutenberg plugin now, or to install the Classic Editor plugin before WordPress 5.0 is released.
Props pento, melchoyce, joen, karmatosed, joemcgill, SergeyBiryukov, jorbin, bph, Clorith, afercia, chanthaboune, chrislema, kjellr, matveb, michelleweber.
Fixes #41316 .
Built from https://develop.svn.wordpress.org/branches/4.9@43502
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-18 06:42:26 +00:00
Sergey Biryukov
9ebbcad7a0
Privacy: Mark Privacy Policy page as such in the Pages list table.
...
Props desrosj, subrataemfluence, ianbelanger, danieltj.
Merges [43495] to the 4.9 branch.
Fixes #44006 .
Built from https://develop.svn.wordpress.org/branches/4.9@43496
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:47:26 +00:00
Sergey Biryukov
d954d6213a
Privacy: Enable pagination screen options for privacy requests list tables.
...
Props birgire, pbiron.
Merges [43486] to the 4.9 branch.
Fixes #44025 .
Built from https://develop.svn.wordpress.org/branches/4.9@43487
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:08:26 +00:00
Sergey Biryukov
7aab30a907
Privacy: Remove some unnecessary code comments.
...
[42967] introduced some WPCS-related comments, probably accidentally saved by an IDE.
Props burhandodhy.
Merges [43465] to the 4.9 branch.
Fixes #44590 .
Built from https://develop.svn.wordpress.org/branches/4.9@43485
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 15:25:24 +00:00
Sergey Biryukov
29dfd13361
Privacy: Rename `username_or_email_to_export` POST variable on Erase Personal Data screen to a more generic `username_or_email_for_privacy_request`.
...
Props ianbelanger, allendav.
Merges [43478] to the 4.9 branch.
Fixes #44181 .
Built from https://develop.svn.wordpress.org/branches/4.9@43479
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 14:18:27 +00:00
Andrew Ozz
eeef639639
Privacy: Add a setting to disable comment cookie consent.
...
Merges [43469] to the 4.9 branch.
Fixes #44373 .
Built from https://develop.svn.wordpress.org/branches/4.9@43470
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 09:30:25 +00:00
Sergey Biryukov
c0903e830b
Posts, Post Types: Add a new `add_inline_data` action which allows extra fields to be added to the inline editing fields.
...
Props mensmaximus, NathanAtmoz.
Merges [42676] and [43460] to the 4.9 branch.
Fixes #36085 .
Built from https://develop.svn.wordpress.org/branches/4.9@43461
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 15:34:25 +00:00
Sergey Biryukov
cb2625e260
Privacy: Use consistent values for the site name and URL used in notification emails.
...
The functions `send_confirmation_on_profile_email()`, `_wp_privacy_send_request_confirmation_notification()`, `_wp_privacy_send_erasure_fulfillment_notification()`, and `wp_send_user_request()` all include a title and URL indicating the current site. However, so far they have dealt with those values inconsistently, sometimes using the site values, other times using the network values if in a multisite. This changeset ensures that only the current site is taken into account in all cases and that special characters in the site name are consistently decoded.
Props subrataemfluence, desrosj.
Merges [43388], [43390], and [43435] to the 4.9 branch.
Fixes #44396 .
Built from https://develop.svn.wordpress.org/branches/4.9@43459
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 14:24:26 +00:00
Sergey Biryukov
30b402c24b
Privacy: append `(Draft)` to draft page titles in the page drop-down on the Privacy Settings screen.
...
Props allendav, desrosj.
Merges [43376] and [43454] to the 4.9 branch.
Fixes #44100 .
Built from https://develop.svn.wordpress.org/branches/4.9@43455
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:52:26 +00:00
Sergey Biryukov
8040b247a4
Privacy: on the Privacy Settings screen change `view` to `preview` when a draft page is selected for the privacy policy.
...
Props garrett-eclipse, desrosj.
Merges [43374] to the 4.9 branch.
Fixes #44131 .
Built from https://develop.svn.wordpress.org/branches/4.9@43453
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:30:26 +00:00
Sergey Biryukov
b74a18dc8b
Privacy: Silence is golden and invisible.
...
"Be more discrete." declared matt in [3155], and since then, "Silence is Golden" has been the calling card of placeholder index files. Historically, these have been php files, but [43012] changed that and added index.html files for privacy export generated folders.
The php silence files produce no visible content. This adds consistency with these new html files in that there will be no visible content. Silence will fall when the question is asked.
Merges [43446] to the 4.9 branch.
Fixes #44195 .
Props audrasjb, rafsuntaskin, Ov3rfly, johnbillion, pento
Built from https://develop.svn.wordpress.org/branches/4.9@43448
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 12:02:29 +00:00
Aaron Campbell
cf8c4fa0d8
Bump 4.9 branch to version 4.9.7
...
Built from https://develop.svn.wordpress.org/branches/4.9@43407
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 16:05:26 +00:00
John Blackbourn
1f5f8129de
Security: Harden the random aspect of the hash used for user profile and admin email address changes.
...
Props BjornW
Fixes #43771
Merges [43367] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@43368
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:39:07 +00:00
John Blackbourn
15054d8a94
Options, Meta APIs: Use the correct escaping function when outputting the meta box context.
...
Props khaihong, abdullahramzan, leanderiversen, aryamaaru, lbenicio, palmiak
Fixes #44274
Merges [43365] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@43366
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:38:18 +00:00
Sergey Biryukov
cd2f52dda1
Privacy: Make sure `wp_add_privacy_policy_content()` does not cause a fatal error by unintentionally flushing rewrite rules outside of the admin context.
...
Add a `_doing_it_wrong()` message describing the correct usage of the function.
Props kraftbj, azaozz, SergeyBiryukov, YuriV.
Merges [43361], [43362], [43363] to the 4.9 branch.
Fixes #44142 .
Built from https://develop.svn.wordpress.org/branches/4.9@43364
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:37:26 +00:00
Sergey Biryukov
ea7c189825
Privacy: Only link to menus panel in Customizer if selected privacy page can be accessed there.
...
Props dlh.
Merges [43343] to the 4.9 branch.
Fixes #44117 .
Built from https://develop.svn.wordpress.org/branches/4.9@43358
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:34:55 +00:00
Sergey Biryukov
567d4b0961
Community Events Dashboard: Always show a WordCamp if one is coming up.
...
WordCamps are celebrations of the local WordPress Community and once a local one is scheduled, people in that community should know it is coming. This adjusts the WordPress Events in the dashboard widgets to always display a WordCamp, even if there are multiple Meetups happening first.
Props iandunn, metalandcoffee, warmlaundry, alejandroxlopez, jorbin.
Merges [42726], [42728], and [43356] to the 4.9 branch.
Fixes #41112 .
Built from https://develop.svn.wordpress.org/branches/4.9@43357
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:34:30 +00:00
Sergey Biryukov
e2bf0ae498
Privacy: Remove unnecessary `This email has been sent to ###EMAIL###` from privacy emails.
...
The line was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.
Props iandunn, ianbelanger, desrosj.
Merges [43353] to the 4.9 branch.
Fixes #44030 .
Built from https://develop.svn.wordpress.org/branches/4.9@43354
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:33:14 +00:00
Sergey Biryukov
eaf96830ce
Privacy: Fix typo in default privacy policy text.
...
Props garetharnold, abdullahramzan.
Merges [43350] to the 4.9 branch.
Fixes #44166 .
Built from https://develop.svn.wordpress.org/branches/4.9@43351
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:31:57 +00:00
Sergey Biryukov
98eb869d8b
Docs: Add missing documentation and duplicate hook references for `wp_privacy_personal_data_export_file`, `wp_privacy_personal_data_exporters`, and `wp_privacy_personal_data_erasers` hooks.
...
Props birgire.
Merges [43303] to the 4.9 branch.
See #44125 .
Built from https://develop.svn.wordpress.org/branches/4.9@43305
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 13:16:25 +00:00
Sergey Biryukov
e782caa1e7
Comments: Escape permalink values on edit screen to prevent XSS.
...
There doesn't appear to be any way for an attacker to introduce malicious input into the URL, unless a plugin is filtering the URL to add it, but it's better to be safe than sorry.
Props 1naveengiri, joyously.
Merges [43290] to the 4.9 branch.
Fixes #44115 .
Built from https://develop.svn.wordpress.org/branches/4.9@43301
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 12:40:26 +00:00
Sergey Biryukov
4d9aadc80c
Privacy: Correct the error check when creating an export folder in `wp_privacy_generate_personal_data_export_file()`.
...
`wp_mkdir_p()` returns `false` on error, not a `WP_Error` object.
Props birgire.
Merges [43299] to the 4.9 branch.
Fixes #44158 .
Built from https://develop.svn.wordpress.org/branches/4.9@43300
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 12:02:29 +00:00
iandunn
0afda3e678
Bump 4.9 branch to version 4.9.5.
...
Built from https://develop.svn.wordpress.org/branches/4.9@43296
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-17 18:56:26 +00:00
Andrew Ozz
f4a436c522
Privacy: Rename exports folder to avoid deleting other files.
...
Previously, personal data exports were stored in `wp-content/uploads/exports`, which is generic enough that it's likely there are existing folders with that name, either created by plugins or manually by administrators. If that folder were reused by Core, then `wp_privacy_delete_old_export_files()` would delete all of the existing files inside it, which is almost certainly not what the site owner wants or expects.
To avoid that, the folder is being renamed to include a specific reference to Core, and a more verbose description of its purpose. With those factored in, it's very unlikely that there will be any conflicts with existing folders.
The `wp_privacy_exports_dir()` and `wp_privacy_exports_url()` functions were introduced to provide a canonical source for the location, and the `wp_privacy_exports_dir` and `wp_privacy_exports_url` filters were introduced to allow plugins to customize it.
Props johnjamesjacoby, allendav.
Merges [43284] to the 4.9 branch.
Fixes #44091 .
Built from https://develop.svn.wordpress.org/branches/4.9@43285
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 20:32:26 +00:00
Andrew Ozz
2062f3f891
Privacy: use the more compatible `word-break: break-all;`, see [43278].
...
Merges [43282] to the 4.9 branch.
See #44092 .
Built from https://develop.svn.wordpress.org/branches/4.9@43283
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 20:09:26 +00:00
Andrew Ozz
d78a4944a2
Privacy: fix styling of the "next steps" buttons on the Export/Erase tools screens when text is long.
...
Props audrasjb, ianbelanger.
Merges [43278] to the 4.9 branch.
Fixes #44092 .
Built from https://develop.svn.wordpress.org/branches/4.9@43281
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 19:45:27 +00:00
Andrew Ozz
3e4f800ee3
Privacy: fix styling of the Privacy Settings buttons on mobile/small screens.
...
Props ianbelanger, azaozz.
Merges [43279] to the 4.9 branch.
Fixes #44093 .
Built from https://develop.svn.wordpress.org/branches/4.9@43280
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 19:43:28 +00:00
iandunn
d1007dd45c
Privacy: require `manage_privacy_options` capability for showing `WP_Privacy_Policy_Content::notice()`.
...
Props ocean90.
Merges [43248] to the 4.9 branch.
Fixes #44055 .
Built from https://develop.svn.wordpress.org/branches/4.9@43277
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 18:04:25 +00:00
Andrew Ozz
61322a844a
Privacy: Reposition log in policy link to avoid overlapping elements.
...
Previously, the link used absolute positioning, in order to stick it at the bottom of the page. That was done in order to create visual separation between it and the "action" links, like "Lost Your Password?"
The absolute positioning can cause conflicts in some situations, though. For example, if extra text or error notices are added above the form, then the login link would be positioned on top of other elements.
Switching to relative positioning with extra margins avoids those issues, while maintaining the visual separation between the "action" links and the privacy policy link.
Props imath, melchoyce, desrosj, xkon, iandunn.
Merges [43274] to the 4.9 branch.
Fixes #44046 .
Built from https://develop.svn.wordpress.org/branches/4.9@43276
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 16:55:46 +00:00
Sergey Biryukov
09fe564f4e
Privacy: only remove the "Suggested text has changed" bubble when an admin visits the Privacy Policy Guide screen.
...
Props azaozz.
Merges [43269] to the 4.9 branch.
Fixes #44063 .
Built from https://develop.svn.wordpress.org/branches/4.9@43273
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 15:52:25 +00:00
Sergey Biryukov
9438733d24
Privacy: automatically create a Privacy Policy page when installing WordPress.
...
Props fclaussen, azaozz.
Merges [42981], [42982], [43243] to the 4.9 branch.
Fixes #43491 .
Built from https://develop.svn.wordpress.org/branches/4.9@43272
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 15:30:26 +00:00
Sergey Biryukov
10c9d391a8
Privacy: fix Export and Erase Personal Data list-tables on small screens.
...
Props ianbelanger, subrataemfluence, desrosj.
Merges [43251] to the 4.9 branch.
Fixes #44026 .
Built from https://develop.svn.wordpress.org/branches/4.9@43271
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 15:10:25 +00:00
Andrew Ozz
0ffa2fc49b
Privacy: add `wp_page_for_privacy_policy` to `populate_options()`.
...
Props ocean90.
Merges [43267] to the 4.9 branch.
Fixes #44076 .
Built from https://develop.svn.wordpress.org/branches/4.9@43268
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 17:02:26 +00:00
Andrew Ozz
ca52f0f101
Privacy: fix markup for the table of contents on privacy policy guide screen.
...
Props ocean90, azaozz.
Merges [43265] to the 4.9 branch.
Fixes #44056 .
Built from https://develop.svn.wordpress.org/branches/4.9@43266
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 16:48:27 +00:00
Andrew Ozz
77d526e000
Privacy: fix the "Privacy Policy Guide updated" message and add a link to the guide.
...
Props birgire, azaozz.
Merges [43263] to the 4.9 branch.
Fixes #44057 .
Built from https://develop.svn.wordpress.org/branches/4.9@43264
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 16:25:28 +00:00
Dominik Schilling
7c30cc3c92
Privacy: Don't show privacy feature pointer to new users.
...
Merge of [43259] to the 4.9 branch.
See #44062 .
Built from https://develop.svn.wordpress.org/branches/4.9@43260
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 15:53:26 +00:00
Andrew Ozz
b82ed28add
Privacy: improve inline documentation.
...
Props desrosj.
Merges [43256] to the 4.9 branch.
Fixes #44075 .
Built from https://develop.svn.wordpress.org/branches/4.9@43257
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 15:12:25 +00:00
Sergey Biryukov
6e76869056
Privacy: exclude the wrapper from the default policy content.
...
Props azaozz.
Merges [43242] to the 4.9 branch.
Fixes #44048 .
Built from https://develop.svn.wordpress.org/branches/4.9@43255
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 14:07:24 +00:00
Sergey Biryukov
eb592352b5
Privacy: fix two typos in `WP_Privacy_Policy_Content::get_default_content()`.
...
Props dlh.
Merges [43249] to the 4.9 branch.
Fixes #44050 .
Built from https://develop.svn.wordpress.org/branches/4.9@43254
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 14:03:25 +00:00
Sergey Biryukov
b475d439b3
Privacy: Reposition pointer to ensure dismiss link is always visible.
...
r43158 introduced a new admin pointer for the privacy tools added in 4.9.6. With the previous positioning, though, sometimes the `Dismiss` link would be fixed off screen, making it impossible for the user to dismiss the pointer. This happened when there were enough extra menu items, or when the viewport height was short enough.
This commit repositions the pointer to work around that problem. One down side of this workaround is that the arrow will not always be positioned next to the `Tools` menu, where it should be. That's an acceptable compromise given the current time constraints, though. A long term solution would be to make `WP_Pointer` robust enough to handle this use case.
Props imath, audrasjb, desrosj.
Merges [43246] to the 4.9 branch.
Fixes #44045 .
Built from https://develop.svn.wordpress.org/branches/4.9@43253
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 14:00:26 +00:00
Sergey Biryukov
4d5c5e90dd
Privacy: define `$title` and `$parent_file` in privacy.php. Fixes showing the proper document title.
...
Props ocean90.
Merges [43250] to the 4.9 branch.
Fixes #44064 .
Built from https://develop.svn.wordpress.org/branches/4.9@43252
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 13:54:24 +00:00
Sergey Biryukov
1600aef2ab
Privacy: On Privacy Settings screen, check if any pages exist before displaying the page selector.
...
Props abdullahramzan, desrosj, melchoyce.
Merges [43238] to the 4.9 branch.
Fixes #43940 .
Built from https://develop.svn.wordpress.org/branches/4.9@43239
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:41:26 +00:00
Sergey Biryukov
8c9bb731ed
Privacy: Normalize file paths in `wp_privacy_generate_personal_data_export_file()` to make sure Windows paths don't have their backslashes stripped.
...
Props xkon, pmbaldha.
Merges [43234] to the 4.9 branch.
Fixes #43908 .
Built from https://develop.svn.wordpress.org/branches/4.9@43235
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:13:27 +00:00
Sergey Biryukov
faf5abc16e
Privacy: Update request confirmation notice text for clarity.
...
Props desrosj, melchoyce, garrett-eclipse.
Merges [43232] to the 4.9 branch.
Fixes #43970 .
Built from https://develop.svn.wordpress.org/branches/4.9@43233
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:05:26 +00:00
Sergey Biryukov
ad8efe232e
Privacy: Send an email notification to the user once their personal data erasure request is fulfilled.
...
Props desrosj, allendav, garrett-eclipse.
Merges [43230] to the 4.9 branch.
Fixes #43973 .
Built from https://develop.svn.wordpress.org/branches/4.9@43231
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:44:25 +00:00
Sergey Biryukov
2c2db8337f
Privacy: Avoid a PHP notice in `wp_ajax_wp_privacy_erase_personal_data()`, make sure `$eraser_key` is always defined.
...
Props allendav.
Merges [43228] to the 4.9 branch.
Fixes #44040 .
Built from https://develop.svn.wordpress.org/branches/4.9@43229
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:25:25 +00:00
Andrew Ozz
f149d8fabc
Privacy: Replace intrusive policy update notice with menu bubbles.
...
Previously, when a plugin updated its suggested privacy policy text, an admin notice was shown on all screens in the Administration Panels. That was done in order to make sure that administrators were aware of it, so that they could update their policy if needed. That was a very heavy-handed and intrusive approach, though, which leads to a poor user experience, and notice fatigue.
An alternative approach is to use bubble notifications in the menu, similar to when plugins have updates that need to be installed. That still makes it obvious that something needs the administrator's attention, but is not as distracting as a notice.
The notice will still appear on the Privacy page, though, since it is relevant to that screen, and provides an explanation of why the bubble is appearing.
Props azaozz, xkon, iandunn.
Merges [43223] to the 4.9 branch.
Fixes #43954 . See #43953 .
Built from https://develop.svn.wordpress.org/branches/4.9@43225
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:08:26 +00:00
Sergey Biryukov
fbb106494f
Privacy: Tweak Privacy Policy page intro text for clarity.
...
Props macbookandrew, allendav.
Merges [43218] to the 4.9 branch.
See #43933 .
Built from https://develop.svn.wordpress.org/branches/4.9@43219
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 16:14:25 +00:00
Andrew Ozz
6bbbdf94c0
Privacy: fix styling on personal data tables.
...
Props melchoyce, allendav.
Merges [43216] to the 4.9 branch.
Fixes #43909 .
Built from https://develop.svn.wordpress.org/branches/4.9@43217
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 16:04:25 +00:00
Sergey Biryukov
3bd2b3ad62
Privacy: Reposition admin pointer to avoid covering collapsed menu.
...
Previously the pointer overlapped the menu in order to draw attention to the fact that it applies to both the `Tools` and `Settings` menus. That caused a conflict if the menu was collapsed, though, because the icons were covered by the pointer and therefore inaccessible.
Additionally, minor tweaks were made to the text order and formatting. The order of the two sections was swapped in the title and paragraph, in order to match the order of the corresponding menu items. The spacing around headings and paragraphs was tweaked to remove extraneous whitespace.
Props littler.chicken, desrosj, ianbelanger, melchoyce.
Merges [43210] to the 4.9 branch.
Fixes #43961 .
Built from https://develop.svn.wordpress.org/branches/4.9@43214
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 15:54:25 +00:00
Andrew Ozz
bf039f8987
Privacy: cleanup of the "Export Personal Data" and "Erase Personal Data" screens.
...
Props desrosj, xkon.
Merges [43212] to the 4.9 branch.
See #43929 .
Built from https://develop.svn.wordpress.org/branches/4.9@43213
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 10:03:27 +00:00
Sergey Biryukov
4cf2959f1e
Privacy: Pass export request ID to `wp_privacy_personal_data_export_file_created` filter.
...
Props thomasplevy.
Merges [43208] to the 4.9 branch.
Fixes #44031 .
Built from https://develop.svn.wordpress.org/branches/4.9@43209
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 23:19:25 +00:00
Sergey Biryukov
728530718b
Privacy: Make the help hint for Privacy Policy page more translatable and accessible.
...
Props tobifjellner.
Merges [43206] to the 4.9 branch.
See #43980 .
Built from https://develop.svn.wordpress.org/branches/4.9@43207
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 23:14:26 +00:00
Andrew Ozz
44dc191a6d
Privacy: show the privacy policy guide and suggested content on a new page instead of a postbox. Then:
...
- Separate the guide text form the suggested policy text.
- Add table of content for easier navigation.
- Move the content to tools.php (prevents the settings menu of being open).
- Add a link to the guide from the Privacy settings screen.
Props melchoyce, azaozz.
Merges [43184] and [43203] to the 4.9 branch.
Fixes #43980 .
Built from https://develop.svn.wordpress.org/branches/4.9@43204
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 21:00:28 +00:00
Andrew Ozz
7156e5171c
Privacy: remove the help tab from Settings => Privacy until we have something helpful to say :)
...
Props allendav.
Merges [43201] to the 4.9 branch.
Fixes #44023 .
Built from https://develop.svn.wordpress.org/branches/4.9@43202
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 18:14:26 +00:00
Andrew Ozz
45c4047586
Privacy: fix spacing on small screens for the Use This Page button in Privacy Tools.
...
Props PressTigers, desrosj.
Merges [43193] to the 4.9 branch.
Fixes #43852 .
Built from https://develop.svn.wordpress.org/branches/4.9@43194
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 16:16:25 +00:00
Sergey Biryukov
547912fbfc
Privacy: Add `id` attribute to `WP_Privacy_Requests_Table` and `WP_Privacy_Data_Export_Requests_Table` rows, for consistency with other post list tables.
...
Props desrosj.
Merges [43191] to the 4.9 branch.
Fixes #44015 .
Built from https://develop.svn.wordpress.org/branches/4.9@43192
git-svn-id: http://core.svn.wordpress.org/branches/4.9@43021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 15:08:26 +00:00