Boone Gorges
f584a3debb
Add unit tests for `post_exists()`.
...
Props MikeHansenMe.
See #34012 .
Built from https://develop.svn.wordpress.org/trunk@34680
git-svn-id: http://core.svn.wordpress.org/trunk@34644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 04:02:24 +00:00
Boone Gorges
061c536031
Don't require explicit taxonomy when getting terms by term_taxonomy_id.
...
Props wonderboymusic.
Fixes #30620 .
Built from https://develop.svn.wordpress.org/trunk@34679
git-svn-id: http://core.svn.wordpress.org/trunk@34643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 03:52:25 +00:00
Drew Jaynes
e9cfe211bc
Tests: Flush rewrite rules between tests in an attempt to avoid permalinks pollution in `Tests_Author_Template`.
...
See #30355 .
Built from https://develop.svn.wordpress.org/trunk@34678
git-svn-id: http://core.svn.wordpress.org/trunk@34642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 02:19:26 +00:00
Drew Jaynes
d242d5bbfb
Introduce `get_the_author_posts_link()`, which returns the HTML link to the author page for the current post's author.
...
`the_author_posts_link()` has in-turn been converted into a wrapper, with most of its logic moved to the new function.
Adds tests for the new function.
Props chipbennett, zrothauser, wonderboymusic, DrewAPicture.
Fixes #30355 .
Built from https://develop.svn.wordpress.org/trunk@34677
git-svn-id: http://core.svn.wordpress.org/trunk@34641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 01:49:25 +00:00
Jeremy Felt
d5b2929dbb
Docs: Clarify `$user` parameter documentation in `wpmu_validate_blog_signup`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34676
git-svn-id: http://core.svn.wordpress.org/trunk@34640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 01:33:27 +00:00
John Blackbourn
5f09357c21
Revert r34674 due to failures on PHP < 5.4.
...
See #16859
Built from https://develop.svn.wordpress.org/trunk@34675
git-svn-id: http://core.svn.wordpress.org/trunk@34639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 01:01:24 +00:00
John Blackbourn
eb352accc4
Avoid stripping square brackets from URLs, and instead correctly encode them.
...
Square brackets must be encoded in the path, path parameters, query parameters, and fragment, but must not be encoded in anything up to the domain and port.
Adds a bunch of tests, including square brackets in query parameters, IPv6 URLs, and several other permutations.
See #16859
Built from https://develop.svn.wordpress.org/trunk@34674
git-svn-id: http://core.svn.wordpress.org/trunk@34638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 00:41:24 +00:00
Jeremy Felt
ea03ecbe66
Fixes #33816 .
...
MS: Adjust formatting of code in `site-new.php` to improve readability.
Fixes #34066 .
Built from https://develop.svn.wordpress.org/trunk@34673
git-svn-id: http://core.svn.wordpress.org/trunk@34637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 23:30:24 +00:00
Jeremy Felt
5397416276
MS: Delete `rewrite_rules` when updating a switched site's URL.
...
Previously, rewrite rules could be flushed and regenerated in the context of another site. Deleting the rules when in a switched state allows for them to be generated properly on the next page view.
Fixes #33816 .
Built from https://develop.svn.wordpress.org/trunk@34672
git-svn-id: http://core.svn.wordpress.org/trunk@34636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 23:24:27 +00:00
Helen Hou-Sandí
02703fae19
Sample permalink: Buttons still need the `.button` class.
...
Also fixes unit tests post-[34670]. The test methods have been slightly renamed because it is no longer a button. Hopefully this name will be more future-proof.
see #18306 .
Built from https://develop.svn.wordpress.org/trunk@34671
git-svn-id: http://core.svn.wordpress.org/trunk@34635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 22:07:25 +00:00
Helen Hou-Sandí
e976f9b503
Edit: Remove the redundant "View Post" button-link and link the sample permalink.
...
Previously there were two persistent "View Post" links on an edit screen: next to the permalink and in the toolbar. This would then become three links after a post was published or updated, as a link is also included in the admin notice. This is a lot of redundancy and visual noise for a flow that is not your primary action upon starting to edit a post. The "View Post" link next to the sample permalink was particularly bad because it is styled like a button, but unlike a button, does not keep you on the current screen.
Because the permalink is now linked, there is no highlighted slug that you can click to edit, but rather just the "Edit" button.
props scribu, lessbloat, sabreuse, SergeyBiryukov, DrewAPicture, helen.
see #18306 .
Built from https://develop.svn.wordpress.org/trunk@34670
git-svn-id: http://core.svn.wordpress.org/trunk@34634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 20:10:26 +00:00
Boone Gorges
f7f4fb01ab
Fix comment_order for single page comment threads.
...
The old comment pagination logic had a separate block for comment threads that
appeared on a single page. After the refactoring in [34561], all comment
pagination logic is unified.
This change ensures that 'comment_order' is respected in all scenarios.
Fixes #8071 .
Built from https://develop.svn.wordpress.org/trunk@34669
git-svn-id: http://core.svn.wordpress.org/trunk@34633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 19:30:26 +00:00
John Blackbourn
5bfa878fee
Correctly slash post fields when trashing and untrashing posts.
...
Fixes #27550
Props dmenard, Denis-de-Bernardy
Built from https://develop.svn.wordpress.org/trunk@34668
git-svn-id: http://core.svn.wordpress.org/trunk@34632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 19:26:25 +00:00
John Blackbourn
2571b6dcec
Correct the logic used when determining whether to display the 'Mine' link on post list tables. It should only be shown when the count for the user's posts differs for the total count of posts. `is_multi_author()` cannot be used because it only considers Posts.
...
Fixes #19609
Built from https://develop.svn.wordpress.org/trunk@34667
git-svn-id: http://core.svn.wordpress.org/trunk@34631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 19:15:24 +00:00
John Blackbourn
51667f882a
Add a `nav_menu_item_title` filter for filtering nav menu item titles.
...
Fixes #33447
Props paulwilde
Built from https://develop.svn.wordpress.org/trunk@34666
git-svn-id: http://core.svn.wordpress.org/trunk@34630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 18:41:26 +00:00
John Blackbourn
8d362918a8
Add a missing `@param` doc for `confirm_another_blog_signup()`.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@34665
git-svn-id: http://core.svn.wordpress.org/trunk@34629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 17:58:26 +00:00
John Blackbourn
b14f6467dc
Avoid using `assertNotFalse()` which is only available in phpunit >= 4.0.0
...
See #33070
Built from https://develop.svn.wordpress.org/trunk@34664
git-svn-id: http://core.svn.wordpress.org/trunk@34628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 16:28:26 +00:00
John Blackbourn
2a8abfef81
Update `get_the_post_thumbnail_url()` so it returns false on failure, to bring it inline with `wp_get_attachment_image_url()`. Correct and introduce new tests.
...
Fixes #33070
Built from https://develop.svn.wordpress.org/trunk@34663
git-svn-id: http://core.svn.wordpress.org/trunk@34627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 15:34:25 +00:00
Drew Jaynes
14c9ea88ea
Widgets: Pass `$instance` to the `widget_nav_menu_args` filter in the Custom Menu widget.
...
Props walterbarcelos for the initial patch.
Fixes #33944 .
Built from https://develop.svn.wordpress.org/trunk@34662
git-svn-id: http://core.svn.wordpress.org/trunk@34626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 15:31:25 +00:00
Boone Gorges
90544d66f2
In `get_page_of_comment()`, use a true `COUNT` query.
...
This improves memory usage by not compiling a list of comment IDs.
See #34057 .
Built from https://develop.svn.wordpress.org/trunk@34661
git-svn-id: http://core.svn.wordpress.org/trunk@34625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 15:10:50 +00:00
Boone Gorges
ae60606ff8
Use correct 'page_id' parameter in `get_page_of_comment()`.
...
See #34057 .
Built from https://develop.svn.wordpress.org/trunk@34660
git-svn-id: http://core.svn.wordpress.org/trunk@34624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 15:10:27 +00:00
Gary Pendergast
635d3bb34e
Rewrite: When redirecting old slugs, include URL endpoints.
...
Historically, `wp_old_slug_redirect()` has only ever redirected the old slug of posts, it hasn't included URL endpoints, or worked with comment feed URLs. By adding support for these, we ensure a greater range of URLs aren't killed when the slug changes.
Props swissspdy.
Fixes #33920 .
Built from https://develop.svn.wordpress.org/trunk@34659
git-svn-id: http://core.svn.wordpress.org/trunk@34623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 06:57:26 +00:00
Scott Taylor
8bb4c2c2e9
Theme Editor: ensure that files named `index.php` in theme subfolders are not labeled as "Main Index Template"
...
Props MikeHansenMe, wonderboymusic, bravokeyl, Shelob9.
Fixes #27201 .
Built from https://develop.svn.wordpress.org/trunk@34658
git-svn-id: http://core.svn.wordpress.org/trunk@34622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 03:11:24 +00:00
Scott Taylor
6cde1a05cb
After [34629], use `$size_class` instead of `$size`.
...
See #32093 .
Built from https://develop.svn.wordpress.org/trunk@34657
git-svn-id: http://core.svn.wordpress.org/trunk@34621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 02:50:24 +00:00
Aaron Jorbin
ce6d084900
Exclude external HTTP tests from multisite run
...
In [30298] the unit tests default confirguration was modified to exclude external-http tests. This change was never migrated to the multisite XML configuration. The external HTTP code doesn't follow different logic in multisite, so the logic to exclude the tests then ( The external-http tests are very slow, and Wp_Http functionality is fairly isolated ) holds true here as well.
See #33968
Built from https://develop.svn.wordpress.org/trunk@34656
git-svn-id: http://core.svn.wordpress.org/trunk@34620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 02:37:25 +00:00
Gary Pendergast
9347f1af71
WPDB: Make sure we don't run sanity checks on DB dropins.
...
Previously, we'd run the sanity checks if `is_mysql` was not set to `false`. This caused problems for DB drop-ins that didn't define `is_mysql` at all. Instead, we can just check if `is_mysql` is `empty()`.
Also fix some unit tests that accidently ran correctly because of the strict `false ===` comparison.
Fixes #33501 .
Built from https://develop.svn.wordpress.org/trunk@34655
git-svn-id: http://core.svn.wordpress.org/trunk@34619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 01:17:24 +00:00
Drew Jaynes
6b07e4a325
Tests: Add a test for the 'before' and 'after' arguments in `wp_page_menu()` when used as a fallback for `wp_nav_menu()`.
...
When `wp_page_menu()` is used as a fallback for `wp_nav_menu()`, the `before` and `after` arguments should be set and output as `<ul>` and `</ul>`, respectively.
See #11095 . See [34653].
Built from https://develop.svn.wordpress.org/trunk@34654
git-svn-id: http://core.svn.wordpress.org/trunk@34618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 00:47:25 +00:00
Scott Taylor
b4ed533e66
After [34200], force 'before' and 'after' to `<ul>` and `</ul>` when `wp_nav_menu()` falls back to `wp_page_menu()`.
...
See #11095 .
Built from https://develop.svn.wordpress.org/trunk@34653
git-svn-id: http://core.svn.wordpress.org/trunk@34617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 23:39:27 +00:00
Drew Jaynes
a908b87996
Docs: Improve the hook documentation for the `plugins_api_args` filter.
...
Standardizes the hook doc summary and expands on the expected type for the `$args` parameter.
See #34035 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34652
git-svn-id: http://core.svn.wordpress.org/trunk@34616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 23:03:24 +00:00
Drew Jaynes
9c46e6605e
Docs: Improve the hook documentation for the `themes_api` filter.
...
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.
Also updates the expected types on the `$override` parameter.
See #34036 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34651
git-svn-id: http://core.svn.wordpress.org/trunk@34615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 23:01:24 +00:00
Drew Jaynes
0d447249c3
Docs: Normalize the data table spacing in the `themes_api()` DocBlock following a typo fix in [34649].
...
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34650
git-svn-id: http://core.svn.wordpress.org/trunk@34614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:49:24 +00:00
Drew Jaynes
ad33a92b6b
Docs: Fix two typos in the DocBlock description for `themes_api()`:
...
* The fourth `$action` type is 'feature_list'
* The first `$action` type in the data table should be 'query_themes'
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34649
git-svn-id: http://core.svn.wordpress.org/trunk@34613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:47:25 +00:00
Drew Jaynes
b27d14ccf3
Docs: Adjust the `themes_api()` DocBlock description to clarify the "second" available hook, `themes_api`, and add new information for the "third" hook, `themes_api_result`.
...
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34648
git-svn-id: http://core.svn.wordpress.org/trunk@34612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:45:25 +00:00
Drew Jaynes
ed719e4d32
Docs: Improve the hook documentation for the `plugins_api` filter.
...
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.
See #34035 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34647
git-svn-id: http://core.svn.wordpress.org/trunk@34611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:29:24 +00:00
John Blackbourn
e177565b03
Switch several assertions to `assertNotWPError()` so more context is provided when the assertion fails.
...
Built from https://develop.svn.wordpress.org/trunk@34646
git-svn-id: http://core.svn.wordpress.org/trunk@34610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:27:24 +00:00
Drew Jaynes
e7294234b9
Docs: Adjust the `plugins_api()` DocBlock description to clarify the "second" available hook, `plugins_api`, and add new information for the "third" hook, `plugins_api_result`.
...
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34645
git-svn-id: http://core.svn.wordpress.org/trunk@34609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:23:24 +00:00
Drew Jaynes
6e47f2a1ee
Docs: Slightly improve the readability of the data table in the DocBlock description for the `oembed_providers` hook by centering the HTTPS column.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34644
git-svn-id: http://core.svn.wordpress.org/trunk@34608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:11:48 +00:00
Scott Taylor
8cd1db9c9c
Canonical: after [34272], don't redirect rewrite endpoints on attachment URLs when pretty permalinks are enabled.
...
Fixes #19918 .
Built from https://develop.svn.wordpress.org/trunk@34643
git-svn-id: http://core.svn.wordpress.org/trunk@34607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:11:25 +00:00
Drew Jaynes
61196c4862
Docs: Update the DocBlock summary for `plugins_api()` to reflect the "WordPress.org" Plugins API.
...
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34642
git-svn-id: http://core.svn.wordpress.org/trunk@34606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:07:24 +00:00
Drew Jaynes
5b07b691f7
Docs: Further improve documentation for `plugins_api()`.
...
* Adds a matrix-like data table demonstrating which arguments are available for the different `$action` types
* Adjusts the return types to accommodate an `array` for the 'hot_tags' `$action` choice
Props ocean90.
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34641
git-svn-id: http://core.svn.wordpress.org/trunk@34605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:00:25 +00:00
Drew Jaynes
b6de1478fd
Docs: Vastly improve documentation for `themes_api()`.
...
Adds:
* A hash notation with descriptions for all accepted arguments
* A matrix-like data table demonstrating which arguments are available for the different `$action` types
* A better summary and description with linked hooks
* An improved return description with a link to external information
Props ocean90.
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34640
git-svn-id: http://core.svn.wordpress.org/trunk@34604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:52:25 +00:00
John Blackbourn
702e4e8ea7
Don't set `CURLOPT_CAINFO` when `sslverify` is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled.
...
This fixes issues with local HTTPS requests (eg. WP Cron) on OS X where cURL is using SecureTransport instead of OpenSSL.
Fixes #33978
Built from https://develop.svn.wordpress.org/trunk@34639
git-svn-id: http://core.svn.wordpress.org/trunk@34603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:37:24 +00:00
John Blackbourn
cbdd8e5494
Introduce `WP_UnitTestCase::assertNotWPError()` for when a test needs to assert that something is, well, not a `WP_Error`.
...
See #33978
Built from https://develop.svn.wordpress.org/trunk@34638
git-svn-id: http://core.svn.wordpress.org/trunk@34602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:29:26 +00:00
Helen Hou-Sandí
9cfddb6c3b
Autoprefixer for [34634].
...
Normally when there are multiple comma-separated values in CSS, each one would go on its own indented line. However, Autoprefixer appears to be tripping up on gradients at the moment, so it's going to stay on one line until we investigate upstream.
see #33299 .
Built from https://develop.svn.wordpress.org/trunk@34637
git-svn-id: http://core.svn.wordpress.org/trunk@34601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 19:17:25 +00:00
Scott Taylor
f78170934a
Users List Table: show the "Change role to" dropdown on the top and bottom. Currently only shows on top.
...
See #27743 .
Built from https://develop.svn.wordpress.org/trunk@34636
git-svn-id: http://core.svn.wordpress.org/trunk@34600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 19:11:26 +00:00
Drew Jaynes
9c46736476
Docs: Fix some syntatical issues in the DocBlock for `WP::send_headers()` following [34632].
...
See #20226 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34635
git-svn-id: http://core.svn.wordpress.org/trunk@34599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:49:29 +00:00
Scott Taylor
1c74c7108f
Feature Image: Improve the preview for transparent background images by using CSS3 to show a checkered background.
...
Props metodiew.
Fixes #33299 .
Built from https://develop.svn.wordpress.org/trunk@34634
git-svn-id: http://core.svn.wordpress.org/trunk@34598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:41:25 +00:00
Scott Taylor
7bc7ea0076
After [34629], update unit tests to reflect this change.
...
See #32093 .
Built from https://develop.svn.wordpress.org/trunk@34633
git-svn-id: http://core.svn.wordpress.org/trunk@34597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:30:24 +00:00
Scott Taylor
8272a839cd
Update the docs in `WP` to explain the need to do [34476].
...
Fixes #20226 .
Built from https://develop.svn.wordpress.org/trunk@34632
git-svn-id: http://core.svn.wordpress.org/trunk@34596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:28:24 +00:00
Drew Jaynes
ccef2fc743
Docs: Add documentation for the `$browse`, `$user`, `$search`, `$author`, `$tag`, `$installed_plugins`, and `$page` parameters in `plugins_api()`.
...
Props ocean90.
Fixes #34035 .
Built from https://develop.svn.wordpress.org/trunk@34631
git-svn-id: http://core.svn.wordpress.org/trunk@34595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:13:48 +00:00