df343d59f2
Build/Test: Die with an error if populate_network fails
...
If you are missing WP_TESTS_EMAIL, populate_network will fail and it can be hard to debug. As populate_network can return a wp_error object, we can detect that and display the error to a user.
See: https://github.com/WordPress/gutenberg/pull/22613
Fixes : #50251
Props: TimothyBlynJacobs
Built from https://develop.svn.wordpress.org/trunk@47904
git-svn-id: http://core.svn.wordpress.org/trunk@47678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:04:10 +00:00
524f188982
Toolbar: Display a "View Post" link when viewing comments for a single post on Comments screen.
...
Props Otto42, matt, SergeyBiryukov.
Fixes #50312 .
Built from https://develop.svn.wordpress.org/trunk@47903
git-svn-id: http://core.svn.wordpress.org/trunk@47677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 19:57:10 +00:00
27485fd7aa
General: Continuing to work towards a passing PHP Compatibility scan.
...
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.
With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750 ).
Props desrosj, johnbillion, jrf.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47902
git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:40:12 +00:00
e2790b4e63
Build/Test Tools: Disable Travis CI build Slack notifications for non-official branches.
...
When branches are unintentionally pushed to the GitHub `wordpress-develop` mirror by committers, a build is triggered in Travis and the result is reported in Slack if the criteria defined is met.
Though this is not the desired workflow (any modifications made to the mirror are erased when the repository is synced from SVN), this can cause a lot of noise if several pushes are made and raise false alarms.
This change limits builds only to the `master` branch, and branches meeting the `X.X` pattern to match each branched version.
Props desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307 .
Built from https://develop.svn.wordpress.org/trunk@47901
git-svn-id: http://core.svn.wordpress.org/trunk@47675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:03:12 +00:00
353def14e2
Docs: Document the `term_order` value for the `orderby` parameter of `WP_Term_Query::__construct()`.
...
Props pbiron.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47898
git-svn-id: http://core.svn.wordpress.org/trunk@47672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:41:06 +00:00
5636fb886b
Docs: Reformat the `orderby` section of `WP_Term_Query::__construct()` for better readability.
...
This makes it more consistent with the `fields` section.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47897
git-svn-id: http://core.svn.wordpress.org/trunk@47671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:37:09 +00:00
f22e113e95
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.
Follow-up to [46230].
Props munyagu.
Fixes #50309 . See #47957 .
Built from https://develop.svn.wordpress.org/trunk@47896
git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:43:15 +00:00
683507fe14
External Libraries: Update clipboard.js to 2.0.6.
...
This change includes some bug fixes and removal of the PhantomJS dependency.
Changelog: https://github.com/zenorocha/clipboard.js/compare/v2.0.4...v2.0.6
Props hareesh-pillai.
Fixes #50306 .
Built from https://develop.svn.wordpress.org/trunk@47895
git-svn-id: http://core.svn.wordpress.org/trunk@47669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:12:33 +00:00
cf597dcf7c
Plugins: Make the message displayed when no plugins are installed more concise.
...
Props johnjamesjacoby, Presskopp.
Fixes #42336 .
Built from https://develop.svn.wordpress.org/trunk@47894
git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:51:13 +00:00
b247cafd91
Docs: Correct `@since` version for `available_permalink_structure_tags` filter.
...
Follow-up to [41182].
Props tiagohillebrandt, sabernhardt.
Fixes #42624 .
Built from https://develop.svn.wordpress.org/trunk@47893
git-svn-id: http://core.svn.wordpress.org/trunk@47667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:38:09 +00:00
72b5018aa3
Docs: Miscellaneous DocBlock corrections.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47892
git-svn-id: http://core.svn.wordpress.org/trunk@47666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:02:13 +00:00
86b50870ec
Formatting: add a new 'safe_style_disallowed_chars' filter.
...
Enable developers to change the regex used in `safecss_filter_attr` to limit characters in the parsed CSS.
Props paulschreiber, swissspidy, rmccue, bartekcholewa, miinasikk.
Fixes #37134 .
Built from https://develop.svn.wordpress.org/trunk@47891
git-svn-id: http://core.svn.wordpress.org/trunk@47665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 23:46:11 +00:00
569c006248
Comments: Rename `Walker_Comment::comment_text()` to `::filter_comment_text()` for clarity.
...
Ensure the comment object is not null before checking its status.
Follow-up to [47887].
See #49956 .
Built from https://develop.svn.wordpress.org/trunk@47889
git-svn-id: http://core.svn.wordpress.org/trunk@47663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 21:45:10 +00:00
9f86174e08
Comments: Ensure that unmoderated comments won't be search indexed.
...
After a comment is submitted, only allow a brief window where the comment is live on the site.
Fixes #49956 .
Props: jonkolbert, ayeshrajans, Asif2BD, peterwilsoncc, imath, audrasjb, jonoaldersonwp, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47887
git-svn-id: http://core.svn.wordpress.org/trunk@47661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 20:12:07 +00:00
30b61fc9e8
Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
...
Some themes already had these checks in place as a result of [41756], but not others.
Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860 .
Built from https://develop.svn.wordpress.org/trunk@47886
git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 17:05:13 +00:00
3fd1fe298a
Docs: Correct `@param` type for `pre_redirect_guess_404_permalink` filter.
...
Improve filter documentation for consistency with other similar short-circuit filters in core.
Follow-up to [47878].
See #16557 .
Built from https://develop.svn.wordpress.org/trunk@47885
git-svn-id: http://core.svn.wordpress.org/trunk@47659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 16:23:11 +00:00
ba92ed7615
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/updates.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50235 .
Built from https://develop.svn.wordpress.org/trunk@47884
git-svn-id: http://core.svn.wordpress.org/trunk@47658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 21:41:09 +00:00
0318a92948
Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting.
...
Props desrosj, pbiron, azaozz.
Fixes #50291 .
Built from https://develop.svn.wordpress.org/trunk@47883
git-svn-id: http://core.svn.wordpress.org/trunk@47657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:53:15 +00:00
94be20e612
Build/Test Tools: Avoid an empty "title" heading if no title is set in `_wp_die_handler_exit()` and `_wp_die_handler_txt()`.
...
Fixes #50297 .
Built from https://develop.svn.wordpress.org/trunk@47882
git-svn-id: http://core.svn.wordpress.org/trunk@47656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:50:08 +00:00
c5ac08ba45
Build/Test Tools: Add PHPUnit to Composer dev dependencies.
...
This helps setting up the correct version of PHPUnit to run WordPress core tests locally and for using it as source for code autocompletion in tests. Also introduces a new Composer script `test` to run the PHPUnit tests.
Props welcher, ayeshrajans, vinkla, johnbillion, Rarst, netweb, ocean90.
Fixes #46815 .
Built from https://develop.svn.wordpress.org/trunk@47881
git-svn-id: http://core.svn.wordpress.org/trunk@47655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:31:07 +00:00
c7aab4121f
Build/Test Tools: Let `WP_UnitTestCase_Base` extend the namespaced version of PHPUnit's test case class.
...
With the minimum PHP version requirement set to 5.6 we're now able to use namespaces by default. This replaces `PHPUnit_Framework_TestCase` with `PHPUnit\Framework\TestCase` for `WP_UnitTestCase_Base` to solve autocompletion issues with code editors when using more recent PHPUnit versions. `PHPUnit\Framework\TestCase` is available since PHPUnit 5.4 and now the minimum required PHPUnit version.
Fixes #50236 .
Built from https://develop.svn.wordpress.org/trunk@47880
git-svn-id: http://core.svn.wordpress.org/trunk@47654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:43:13 +00:00
69a866a1a9
Administration: Unify the date structure in list view and excerpt view.
...
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.
Fixes : #35391 .
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.
Built from https://develop.svn.wordpress.org/trunk@47879
git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:15:08 +00:00
f201c1b217
Canonical: Add the ability to disable `redirect_guess_404_permalink()`.
...
This also adds a few more filters to make adding redirects easier. Notably:
1. `do_redirect_guess_404_permalink`
2. `pre_redirect_guess_404_permalink`
3. `strict_redirect_guess_404_permalink`
Fixes : #16557 .
Props: msafi, nacin, simonwheatley, westi, mboynes, joostdevalk, Lex_Robinson, MikeSchinkel, haukep, paulschreiber, DrewAPicture, ravenswd, esemlabel, stevegibson12, martychc23, DrLightman, jivanpal, neonkowy, laternastudio, apedog, audrasjb, davidbaumwald, Confridin, donmhico, ryotsun.
Built from https://develop.svn.wordpress.org/trunk@47878
git-svn-id: http://core.svn.wordpress.org/trunk@47652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 18:49:10 +00:00
b65cf7f992
Build/Test Tools: Improve Travis config to pass config validation.
...
* Add missing `os` and `dist` with the current default values.
* Replace the alias `matrix` with `jobs`.
* Remove unsupported `on_start` for `notifications.slack`.
Fixes #50296 .
Built from https://develop.svn.wordpress.org/trunk@47877
git-svn-id: http://core.svn.wordpress.org/trunk@47651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 16:39:08 +00:00
7152c73f6a
Editor: Fix code style for constructor arguments added in [47875].
...
Also revert unintended changes to `WP_Block_Type::__construct()` DocBlock.
See #48529 .
Built from https://develop.svn.wordpress.org/trunk@47876
git-svn-id: http://core.svn.wordpress.org/trunk@47650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 16:27:15 +00:00
c704057e0d
Add fields to WP_Block_Type
...
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.
Props spacedmonkey, aduth.
Fixes #48529 .
Built from https://develop.svn.wordpress.org/trunk@47875
git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 12:27:08 +00:00
1c176ffb1e
Docs: Correct and clarify an inline comment about the `upload_url_path` and `upload_path` options in `wp-admin/options-media.php`.
...
Synchronize it with a similar comment in `wp-admin/options.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47874
git-svn-id: http://core.svn.wordpress.org/trunk@47648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 11:22:13 +00:00
cda84f2409
Build/Test Tools: Bump `node-sass` and `webpack-dev-server` versions as a result of `npm audit`.
...
Props whyisjake.
See #49768 .
Built from https://develop.svn.wordpress.org/trunk@47873
git-svn-id: http://core.svn.wordpress.org/trunk@47647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 20:24:46 +00:00
f7da44c8d2
Upgrade/Install: Rename `wp_in_maintenance_mode()` to `wp_is_maintenance_mode()`, for consistency with `wp_is_recovery_mode()`.
...
While the former name might be a bit more accurate, the latter matches the existing naming pattern.
Follow-up to [47623].
Fixes #49959 .
Built from https://develop.svn.wordpress.org/trunk@47871
git-svn-id: http://core.svn.wordpress.org/trunk@47646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:54:24 +00:00
5f47ca5b8b
Docs: Adjust the documentation for the new `ID` alias in `get_term_by()` for consistency with `get_user_by()`.
...
Follow-up to [47865].
See #45163 .
Built from https://develop.svn.wordpress.org/trunk@47870
git-svn-id: http://core.svn.wordpress.org/trunk@47645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:53:04 +00:00
9859bf6204
Build/Test Tools: Revert some devDependency changes for 5.5.
...
After bumping some major updates, tests on Travis are failing.
See: https://travis-ci.com/WordPress/wordpress-develop/builds/168839259 ##49768.
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47869
git-svn-id: http://core.svn.wordpress.org/trunk@47644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:51:42 +00:00
ef135efa6d
Build/Test Tools: Bump devDependencies for WordPress 5.5
...
There are several other changes that need to be made for the security audit, this is just the first pass.
Fixes #49768 .
Props SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47867
git-svn-id: http://core.svn.wordpress.org/trunk@47643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-30 04:56:34 +00:00
e8fa5d6fc2
Code Standards: Clean up whitespace on the end of a file.
...
See: #45163 .
Props: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47866
git-svn-id: http://core.svn.wordpress.org/trunk@47642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 23:35:11 +00:00
7798f64340
Taxonomy: Extend `get_term_by` to accept `ID` as a term parameter.
...
Similar to `get_user_by`, both `ID` and `id` should be able to accepted.
Fixes #45163 .
Props emrikol, esoj.
Built from https://develop.svn.wordpress.org/trunk@47865
git-svn-id: http://core.svn.wordpress.org/trunk@47641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 22:43:09 +00:00
2277a9df24
Docs: Improve documentation for functions in `wp-includes/category.php` per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47864
git-svn-id: http://core.svn.wordpress.org/trunk@47640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 10:07:10 +00:00
bc18c233d6
Docs: Document that `get_category_by_slug()` returns `false` if the category doesn't exist.
...
Props stevenlinx.
Fixes #50277 .
Built from https://develop.svn.wordpress.org/trunk@47863
git-svn-id: http://core.svn.wordpress.org/trunk@47639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 10:02:13 +00:00
8924832842
Coding Standards: Use strict comparison in `wp-admin/_index.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47862
git-svn-id: http://core.svn.wordpress.org/trunk@47638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-28 10:02:12 +00:00
8713fac0d7
Docs: Remove unused `@global` declarations from `_WP_Editors::print_tinymce_scripts()`.
...
Follow-up to [47860].
See #45398 .
Built from https://develop.svn.wordpress.org/trunk@47861
git-svn-id: http://core.svn.wordpress.org/trunk@47637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 19:48:11 +00:00
552883574b
Editor: Remove TinyMCE global version.
...
The global variable is not being used in the `editor_settings` method.
Fixes #45398 .
Props ishitaka, noisysocks, mista-flo.
Built from https://develop.svn.wordpress.org/trunk@47860
git-svn-id: http://core.svn.wordpress.org/trunk@47636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 19:28:12 +00:00
38b7495af7
Administration and Site Health: Make information on Search engine visibility more prominent.
...
- makes the "Search engines discouraged" message on the Dashboard more prominent
- adds "Search engine visibility" information under Site Health > Info > WordPress
- removes title case in favor of sentence case in all the related strings
Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce.
Fixes #35288 .
Built from https://develop.svn.wordpress.org/trunk@47859
git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 14:33:11 +00:00
95d53b9a66
Docs: Correct `@return` value for `WP_REST_Meta_Fields::get_value()`.
...
Props chrisvanpatten.
Fixes #50259 .
Built from https://develop.svn.wordpress.org/trunk@47858
git-svn-id: http://core.svn.wordpress.org/trunk@47634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 09:44:11 +00:00
57fb3c6cf0
Coding Standards: Change auto-update filters to be more consistent.
...
* send_theme_auto_update_email 👉 auto_theme_update_send_email
* wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled
* wp_themes_auto_update_enabled 👉 themes_auto_update_enabled
Want to make sure that @ronalfy gets props for his work in #50052 too.
See #50052 .
Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47857
git-svn-id: http://core.svn.wordpress.org/trunk@47633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 18:03:08 +00:00
a01835679a
Posts, Post Types: Pass the post object to the `delete_attachment` action.
...
Also add the missing `$post` parameter to the `delete_post` and `deleted_post` actions in `wp_delete_attachment()`.
See #30940 .
Built from https://develop.svn.wordpress.org/trunk@47856
git-svn-id: http://core.svn.wordpress.org/trunk@47632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 14:49:06 +00:00
7b192d406a
Coding Standards: Fix instances of `Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47855
git-svn-id: http://core.svn.wordpress.org/trunk@47631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 09:37:10 +00:00
235bd98f3c
Docs: Improve documentation for `add_existing_user_to_blog()`.
...
Props stevenlinx.
Fixes #50243 .
Built from https://develop.svn.wordpress.org/trunk@47854
git-svn-id: http://core.svn.wordpress.org/trunk@47630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-25 14:23:13 +00:00
786ac48c84
Coding Standards: Use strict comparison in `wp-admin/network` where static strings are involved.
...
Includes minor code layout fixes for better readability.
Follow-up to [47808].
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47853
git-svn-id: http://core.svn.wordpress.org/trunk@47629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-24 09:17:09 +00:00
5899bf0f32
Coding Standards: Use strict comparison for `$wp_db_version` check in `wp-admin/network/upgrade.php`.
...
Follow-up to [47787], [47788].
See #50155 , #49542 .
Built from https://develop.svn.wordpress.org/trunk@47852
git-svn-id: http://core.svn.wordpress.org/trunk@47628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-24 09:15:07 +00:00
5b4174e409
Coding Standards: Use strict comparison for more `count()` calls.
...
Follow-up to [47848].
Props mukesh27.
Fixes #50232 . See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47851
git-svn-id: http://core.svn.wordpress.org/trunk@47627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 16:22:07 +00:00
ed71319421
Role/Capability: Use meta caps `edit_post`, `read_post`, and `delete_post` directly.
...
Rather than consulting the post type object, let `map_meta_cap()` handle that for us.
Props peterwilsoncc, ocean90.
Fixes #50128 .
See #23226 .
Built from https://develop.svn.wordpress.org/trunk@47850
git-svn-id: http://core.svn.wordpress.org/trunk@47626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 15:24:07 +00:00
aaeab2f3f5
Rest API: Ensure `rest_ensure_response()` upgrades `WP_HTTP_Response` to `WP_REST_Response`.
...
An instance of `WP_HTTP_Response` doesn't ensure that the required methods used in `WP_REST_Server::dispatch()` exist, currently causing a fatal error.
Props ali11007, TimothyBlynJacobs, ocean90.
Fixes #49495 .
Built from https://develop.svn.wordpress.org/trunk@47849
git-svn-id: http://core.svn.wordpress.org/trunk@47625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 14:36:09 +00:00
Aaron Jorbin
Sergey Biryukov
desrosj
Adam Silverstein
whyisjake
Dominik Schilling
Andrew Ozz
gziolo
Andrea Fercia